From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 8 10:30:00 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 92037FB7 for ; Sun, 8 Sep 2013 10:30:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5B49D2682 for ; Sun, 8 Sep 2013 10:30:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r88AU0gv050288 for ; Sun, 8 Sep 2013 10:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r88AU0eF050246; Sun, 8 Sep 2013 10:30:00 GMT (envelope-from gnats) Resent-Date: Sun, 8 Sep 2013 10:30:00 GMT Resent-Message-Id: <201309081030.r88AU0eF050246@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Shahar Klein Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B78EEEDB for ; Sun, 8 Sep 2013 10:25:32 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A60182674 for ; Sun, 8 Sep 2013 10:25:32 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r88APWbI011365 for ; Sun, 8 Sep 2013 10:25:32 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r88APWmH011362; Sun, 8 Sep 2013 10:25:32 GMT (envelope-from nobody) Message-Id: <201309081025.r88APWmH011362@oldred.freebsd.org> Date: Sun, 8 Sep 2013 10:25:32 GMT From: Shahar Klein To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: misc/181931: vlan over lagg over mlxen crashes the kernel X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 10:30:00 -0000 >Number: 181931 >Category: misc >Synopsis: vlan over lagg over mlxen crashes the kernel >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 08 10:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Shahar Klein >Release: 9.1 >Organization: Mellanox >Environment: FreeBSD 9.1-RELEASE FreeBSD 9.1-RELEASE root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Creating a vlan over lagg over mlxen crashes the kernel >How-To-Repeat: ifconfig lagg0 create ifconfig lagg0 laggport mlxen0 laggport mlxen1 ifconfig lagg0.400 create >Fix: seems like a sanity test is needed entering the rx_vlan handler --- a/sys/ofed/drivers/net/mlx4/en_netdev.c +++ b/sys/ofed/drivers/net/mlx4/en_netdev.c @@ -51,6 +51,9 @@ static void mlx4_en_vlan_rx_add_vid(void *arg, struct net_device *dev, u16 vid) int idx; u8 field; + if (arg != priv) + return; + if ((vid == 0) || (vid > 4095)) /* Invalid */ return; en_dbg(HW, priv, "adding VLAN:%d\n", vid); @@ -72,6 +75,9 @@ static void mlx4_en_vlan_rx_kill_vid(void *arg, struct net_device *dev, u16 vid) int idx; u8 field; + if (arg != priv) + return; + if ((vid == 0) || (vid > 4095)) /* Invalid */ return; en_dbg(HW, priv, "Killing VID:%d\n", vid); >Release-Note: >Audit-Trail: >Unformatted: