From owner-freebsd-current@FreeBSD.ORG Sun Oct 27 00:22:59 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 13FC1AF3 for ; Sun, 27 Oct 2013 00:22:59 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-qc0-x231.google.com (mail-qc0-x231.google.com [IPv6:2607:f8b0:400d:c01::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C79002B80 for ; Sun, 27 Oct 2013 00:22:58 +0000 (UTC) Received: by mail-qc0-f177.google.com with SMTP id u18so3076134qcx.36 for ; Sat, 26 Oct 2013 17:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=YBClTC3xiv6mrEPtgcX8Hbh3hNSUaLY/iJlewbkh7Aw=; b=Jw5YlZrvimo+DG4x3haNlUMwEL6sSVH8to67AL+PkNP/xiaahJg62sS0hPL6uMnbje EFnEmja1fTTaxqL7lmFPBvv6Ei/2qziTYweQECfmkQjLjnMXsKc7HixB9p+kDDd/CqsZ K8xdVWRV9N9EeJjeL6P592XwieVDuCGcx+Umo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=YBClTC3xiv6mrEPtgcX8Hbh3hNSUaLY/iJlewbkh7Aw=; b=KM2sZqWumXyu1+Ao8PaL8iVl0EyK3NHhWH+vMPyxVeC3JXhCaJ6ghf6mlNrSTtBkp+ 2nV/U6QCB1p3WwenOtqTxcvsTiGTybvW+vLpL0poHHH+fGVp2BqG+o2GR3HNAReAuPst uX5r4A3ufmDYhPAaPtFgtXjDR/6zAUWKwce9nT8aUJUn5StPV76OX5TcccjLTY9DsnGl ggKOVt1mXkAePHCWxXNjVayyB6P6r9VPR/DuzYVLxFX0F7cLMc95rSTeyl1Zh/z1Dy3A QbkwUKF2cwVtkxC4T6oN44BMhxasBbhguFHo3/xga9JUv4BMWPLmUJG5gAG2Ved1c2gQ 0xdg== X-Gm-Message-State: ALoCoQmCPoMZ3c5zvXyOk05DgMY2gYVvJDLfhzfNSy+PX46QO+deTf5eKbDCL7MFZKVxRJc7S/Ou X-Received: by 10.49.59.44 with SMTP id w12mr19848077qeq.57.1382833377384; Sat, 26 Oct 2013 17:22:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.96.63.101 with HTTP; Sat, 26 Oct 2013 17:22:27 -0700 (PDT) In-Reply-To: <1382799852.32760.2.camel@localhost> References: <1382799852.32760.2.camel@localhost> From: Eitan Adler Date: Sat, 26 Oct 2013 20:22:27 -0400 Message-ID: Subject: Re: [PATCH] contrib/groff Queisce -Wdangling else To: Sean Bruno Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-current@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Oct 2013 00:22:59 -0000 On Sat, Oct 26, 2013 at 11:04 AM, Sean Bruno wrote: > This adds proper braces to clear Clang warnings about dangling else > statements in groff. There is no(intended) functional change. For contributed code why not just disable warnings? Fixing code is good but doing so in our repository instead of upstream doesn't help as much. -- Eitan Adler