From owner-freebsd-current@FreeBSD.ORG Sun Nov 3 02:18:01 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 77EE3F88; Sun, 3 Nov 2013 02:18:01 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-oa0-x22a.google.com (mail-oa0-x22a.google.com [IPv6:2607:f8b0:4003:c02::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 34BC8253B; Sun, 3 Nov 2013 02:18:01 +0000 (UTC) Received: by mail-oa0-f42.google.com with SMTP id k14so6059778oag.29 for ; Sat, 02 Nov 2013 19:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=0nVXdPjC1xoCi+ZmoEVeqYZ9ncDRf36Il2gLQZsOqbM=; b=IqUopvuNQJEMMqDtwIvAHf9a8cO3jdhj34R7yaEcjSABGPek1VWNzgq9jyqORNUSKb rfmm5QDekm9kCseDaZ+CAt4cD2xWT7ZUbKXie7vjj9NCERAEwJx3D/0T693jYL+xIGyp JOmopiSKQ0PsV016c4RUMviV7eRHObnoEuirnOQGtqyA8FyPQ9w6nLSBFvD7hnJIQP/8 dw9hMGhOto74EXmVuaNWExSpS9xeYZPeIO1yssvZt8A3xXi2MbMBOOWY2sWp3S+t1vtC Qum2dVHk5Uz8xlgJQIMhG5AkW2NGetqhI6eJhCFvxfdLohpviOMoX4LbKWcwcUDc0CSw OGWw== MIME-Version: 1.0 X-Received: by 10.60.117.38 with SMTP id kb6mr8189900oeb.7.1383445080523; Sat, 02 Nov 2013 19:18:00 -0700 (PDT) Received: by 10.76.19.115 with HTTP; Sat, 2 Nov 2013 19:18:00 -0700 (PDT) In-Reply-To: References: Date: Sat, 2 Nov 2013 22:18:00 -0400 Message-ID: Subject: Re: [CFT] bsdinstall and zfsboot enhancements From: Outback Dingo To: Devin Teske Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: " Current" , "Teske, Devin" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Nov 2013 02:18:01 -0000 On Sat, Nov 2, 2013 at 1:59 PM, Teske, Devin wrote: > Hi all, > > Another Call For Testing... > This one is for bsdinstall. > > Two patchsets are required for this CFT: > > http://druidbsd.cvs.sf.net/viewvc/druidbsd/bsdinstall_debug/ > http://druidbsd.cvs.sf.net/viewvc/druidbsd/bsdinstall_zfs/ > > The enhancements are: > > + Add a `-D FILE" command-line option for overriding the > path to the bsdinstall log file (BSDINSTALL_LOG env var). > > + Document new `-D FILE' in the man page for bsdinstall. > > + If FILE in `-D FILE' begins with a +, debug output goes to > stdout (interleaved between dialog(1) invocations/output) as > well as to FILE (minus the leading + of course). > > + If BSDINSTALL_LOG cannot be written, then debugging is > disabled (except in the case of a leading + in the pathname, > wherein debug will still be printed to stdout). > > + Update source code format to approximate a future shstyle(9) > > + Fix a dangling participle ("Begun ..." -> "Began ...") > > + Rewrite the docsinstall script (was necessary to abate direct > dependency on BSDINSTALL_LOG (instead, use fault-tolerant > bsdconfig framework which displays appropriate errors for > package management). > > + Add additional debug output for dhclient/rtsol/wpa_cliscan > > + Display script errors in a textbox rather than just on stdout > > + Update many coments. > > + Add new f_show_err() API call (like f_show_msg but changes > the dialog title to "Error")(see bsdconfig's `common.subr'). > > + Add new f_eval_catch() API call for executing a command via > eval but not before logging the command to debug. Several > example cases documented in API header for function in > bsdconfig's `common.subr'. > > + Fix dialog auto-sizing when launched as an rvalue to a pipe > for indirected scripts (previously would default to 80x24 sizing > in this case, now it can autosize to full size even when in a pipe > chain). > > + Fix a bug in f_snprintf wherein if the $format argument began > with a "-" or "--" it would be misinterpreted as a flag to printf. (this > is in bsdcofig's strings.subr) > > + Add accompanying f_sprintf() and f_vsprintf() to go along with > already existing f_snprintf() and f_vsnprintf() (see bsdconfig's > strings.subr). > > + Update bsdinstall's "config" script to adjust ttyu* entries in > /etc/ttys when it is determined that we are in-fact doing an install > over serial (e.g. bhyve). > > + Remove some unnecessary default ZFS datasets from the > automatic "zfsboot" script. Such as: /usr/ports/distfiles > /usr/ports/packages /usr/obj /var/db /var/empty /var/mail and > /var/run (these can all be created as-needed once the system is > installed). > > + Remove setuid=off for /usr/home (as discussed with others from > last round of CFT). > > + Fix some i18n string violations in "zfsboot" > > + Bolster debugging output in "zfsboot" > > + Fix some string quoting issues in "zfsboot" > > + Fix some variable scope issues in "zfsboot" > > + Only display the ZFS vdev type selection menu when running > interactively (duh). > > + Change "Create" to "Install" in "zfsboot" main menu > > + Increase pedantic error checking in "zfsboot" (type-check > arguments and such). > > + Add a call to "graid destroy" to kill automatic metadata (part of > the series of pedantic destructions we do when bootstrapping > a new/naked disk). > > + Make judicious use of new f_eval_catch() in "zfsboot" > > + More comments (zfsboot). > > + Fixup some variable names for consistency (zfsboot). > > nice work, looks good, patched the bootloader also, seems to function well, love the kernel selection variable > -- > Devin > > _____________ > The information contained in this message is proprietary and/or > confidential. If you are not the intended recipient, please: (i) delete the > message and all copies; (ii) do not disclose, distribute or use the message > in any manner; and (iii) notify the sender immediately. In addition, please > be aware that any message addressed to our domain is subject to archiving > and review by persons other than the intended recipient. Thank you. >