From owner-freebsd-hackers@FreeBSD.ORG  Sun Jan 27 06:51:14 2013
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id CCDF9187;
 Sun, 27 Jan 2013 06:51:14 +0000 (UTC)
 (envelope-from tim@kientzle.com)
Received: from monday.kientzle.com (99-115-135-74.uvs.sntcca.sbcglobal.net
 [99.115.135.74]) by mx1.freebsd.org (Postfix) with ESMTP id AF7B524E;
 Sun, 27 Jan 2013 06:51:14 +0000 (UTC)
Received: (from root@localhost)
 by monday.kientzle.com (8.14.4/8.14.4) id r0R6pDoe025565;
 Sun, 27 Jan 2013 06:51:13 GMT (envelope-from tim@kientzle.com)
Received: from [192.168.2.143] (CiscoE3000 [192.168.1.65])
 by kientzle.com with SMTP id 479pvcxm5s2i5gcrg4hudf455i;
 Sun, 27 Jan 2013 06:51:13 +0000 (UTC)
 (envelope-from tim@kientzle.com)
Subject: Re: Testing SIOCADDMULTI?
Mime-Version: 1.0 (Apple Message framework v1283)
Content-Type: text/plain; charset=us-ascii
From: Tim Kientzle <tim@kientzle.com>
In-Reply-To: <AE65AFB2-A767-4457-B30A-007956A7D216@freebsd.org>
Date: Sat, 26 Jan 2013 22:51:12 -0800
Content-Transfer-Encoding: 7bit
Message-Id: <7A0E9B71-0232-4808-B5D4-5B0D811B353C@kientzle.com>
References: <AE65AFB2-A767-4457-B30A-007956A7D216@freebsd.org>
To: Tim Kientzle <kientzle@freebsd.org>
X-Mailer: Apple Mail (2.1283)
Cc: freebsd-hackers <freebsd-hackers@freebsd.org>
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Jan 2013 06:51:14 -0000


On Jan 26, 2013, at 3:56 PM, Tim Kientzle wrote:

> My next TODO items for this network driver is to implement
> the SIOCADDMULTI and SIOCDELMULTI ioctls.

Looking through other drivers (and net/if.c), I've
managed to implement ADDMULTI by adding
the multicast ethernet address to the list maintained
by the controller.

DELMULTI seems trickier.   Since if.c does not pass
the specific address being removed down to the
driver, it looks like I have no choice but to remove
every multicast address from the controller and then
re-insert all of the ones that are still valid.

(This controller doesn't use a hash filter; it uses
a list of valid multicast addresses.)

Is there a better approach?

> I'm not quite sure what they do, though, and have
> no idea how to test them to see if they are working
> correctly.

Would still appreciate any suggestions for how to test these.

Cheers,

Tim