From owner-freebsd-hackers@FreeBSD.ORG  Sun Aug 25 06:39:33 2013
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id ACB3B9A6
 for <freebsd-hackers@freebsd.org>; Sun, 25 Aug 2013 06:39:33 +0000 (UTC)
 (envelope-from jlh@FreeBSD.org)
Received: from caravan.chchile.org (caravan.chchile.org [178.32.125.136])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 744DB2B3D
 for <freebsd-hackers@freebsd.org>; Sun, 25 Aug 2013 06:39:33 +0000 (UTC)
Received: by caravan.chchile.org (Postfix, from userid 1000)
 id 77EE7C0191; Sun, 25 Aug 2013 06:39:31 +0000 (UTC)
Date: Sun, 25 Aug 2013 08:39:31 +0200
From: Jeremie Le Hen <jlh@FreeBSD.org>
To: Eitan Adler <lists@eitanadler.com>
Subject: Re: weekly periodic security status
Message-ID: <20130825063931.GH24767@caravan.chchile.org>
Mail-Followup-To: Eitan Adler <lists@eitanadler.com>,
 FreeBSD Hackers <freebsd-hackers@freebsd.org>
References: <20130822204958.GC24767@caravan.chchile.org>
 <CAF6rxg=hfT829b0yNc5YObnz6U4+3afuEPR3JZK9nvXophCtvg@mail.gmail.com>
 <20130824204725.GF24767@caravan.chchile.org>
 <CAF6rxgkyw28xibzpAkGxj9O9HHHikW=zfwNHh7nn6bXJ6xn8gg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAF6rxgkyw28xibzpAkGxj9O9HHHikW=zfwNHh7nn6bXJ6xn8gg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org>
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Aug 2013 06:39:33 -0000

On Sat, Aug 24, 2013 at 06:03:37PM -0400, Eitan Adler wrote:
> On Sat, Aug 24, 2013 at 4:47 PM, Jeremie Le Hen <jlh@freebsd.org> wrote:
> > On Sat, Aug 24, 2013 at 10:41:56AM -0400, Eitan Adler wrote:
> >> On Thu, Aug 22, 2013 at 4:49 PM, Jeremie Le Hen <jlh@freebsd.org> wrote:
> >> > Well, whatever, if you have any concerns, objections or comments, please
> >> > speak now :).
> >>
> >> This LGTM but please include a comment above the warning with a date /
> >> release number when this compatibility can be removed.
> >
> > If the old variable names are deprecated in releng/10, they can be
> > removed in releng/11, can't they?
> 
> Yes, and this should be indicated in a comment.  When I see
> "deprecated" or "old hack" or similar terms in code it takes some
> archaeology to figure out when it was added and when it could be
> removed.   It would be nice to help the future reader a bit.

The purpose of my question was to know what to put in the comment ;-).
Thanks for pointing this out.

-- 
Jeremie Le Hen

Scientists say the world is made up of Protons, Neutrons and Electrons.
They forgot to mention Morons.