From owner-freebsd-java@FreeBSD.ORG Sun Sep 15 06:07:11 2013 Return-Path: Delivered-To: java@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3F882A9F; Sun, 15 Sep 2013 06:07:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D04922004; Sun, 15 Sep 2013 06:07:10 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r8F676wG053358; Sun, 15 Sep 2013 09:07:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r8F676wG053358 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r8F676p5053357; Sun, 15 Sep 2013 09:07:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 15 Sep 2013 09:07:06 +0300 From: Konstantin Belousov To: Dimitry Andric Subject: Re: Building java/openjdk7 with clang Message-ID: <20130915060706.GH41229@kib.kiev.ua> References: <108F3771-64B3-40E9-91FA-04C160442608@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mDTzbtJQQC4mO8fU" Content-Disposition: inline In-Reply-To: <108F3771-64B3-40E9-91FA-04C160442608@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: java@FreeBSD.org, Baptiste Daroussin , Greg Lewis X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2013 06:07:11 -0000 --mDTzbtJQQC4mO8fU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 15, 2013 at 01:45:19AM +0200, Dimitry Andric wrote: > Hi, >=20 > I took some time to figure out how to build java/openjdk7 with clang. > There are a few items I changed: >=20 > - Change a few instances of "ifneq ($(COMPILER_WARNINGS_FATAL),false)" > to "ifeq ($(COMPILER_WARNINGS_FATAL),true)", to make sure -Werror is > *not* used. There are zillions of warnings in openjdk, and I don't > think it is worth the trouble to fix them all (even if that is > possible :). > - Remove -fcheck-new from CFLAGS, since clang does not support it, and > it does not make sense anyway. This is the only one that is not > strictly needed; if -Werror is not enabled, clang will just print a > warning that the option is unused, but it won't be fatal. > - Change the $(CC) -dumpspecs hack in one of the Makefiles to something > more portable. The -dumpspecs is done to figure out if the compiler > uses --hash-style=3Dgnu when linking, and if it does, it changes the > option to --hash-style=3Dboth. On FreeBSD, this is basically a no-op, Compiler ? Do you reference the ELF hash there ? Why do you think this is nop ? > so it could also be commented out entirely. > - In jdk/src/solaris/native/java/net/net_util_md.c, change two > instances of CHECK_NULL() to CHECK_NULL_RETURN(), since the function > they are in is supposed to return a value. I chose to return 0, > since that is what the function seems to use as a default value. >=20 > With these fixes, openjdk7 builds and runs fine for me. I tried to run > "gmake test" in the work directory, but that didn't do much, so I am > not sure if a full test suite will survive anything. It would be nice > if anybody knows a good way to test the produced binaries more > thoroughly. >=20 > -Dimitry >=20 >=20 --mDTzbtJQQC4mO8fU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iQIcBAEBAgAGBQJSNU6JAAoJEJDCuSvBvK1BC8IP/A6Cd4anXv/w1o0gEN2r9tpn NR+QzRhrN7ej7Q6FwLvmG40ue6IJhst7qbL4x80Fs6o87NjuUOWyXNRpWQMWkGxU SH+KoxiU9fx3zQLZ8q0jF8671UM4lSKNKcEV0wJdvA4F16H8vO+ufRnfRF0SkQVQ mLxOLJoSIM/nqT0VDFaDwI+LXwv/EvAs+KjFqpoq30cnjJe79owzSCJK4+5tNnLS JyLDt3q1ZxjeAcq1k+2DPE4ghLkPeYhZ801sXG1aos6ziMz+e2TPbzvODLJsld3+ FlFHOx2MG6cQOdJiBPn3VdALazKuZNENf3GqftNo5y4hMOIgsEJZA5+GBBloM44X +VIN4nHa5e9qOA9E0EKpUGoezGMqLmHuNysrPeCZdiCGVDGq45h/x7oEJvKwcu1I VWdwUP+xlviK8NKZnUGmwjPpqXny1A8tlEMTZ/JnE7UHerTgJ9Bq0UZmMIGa5v2Y nsDQeRplKEhyoWF51gkjiHFoeFQqON9B35F1GIxad4RLDGb5ZPlyYPvJMRwBswBM nDTMslyi/zfhObVLQmynjxqo0GFjyS03fDIJqcZt1ahBmLEu+a57vx/S07109BsC mOSLh+eIh1jazaLbzLh+YK7bNow4oW/ZVZuKBvZQps2kgPQmlW9Xb6Q0m8lYgA6F LJ3v+aiel7+O/yDCR8R6 =L6xc -----END PGP SIGNATURE----- --mDTzbtJQQC4mO8fU-- From owner-freebsd-java@FreeBSD.ORG Sun Sep 15 09:45:25 2013 Return-Path: Delivered-To: java@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 27D41FDD; Sun, 15 Sep 2013 09:45:25 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9EB412845; Sun, 15 Sep 2013 09:45:24 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::2dfe:a80e:4c91:edd0] (unknown [IPv6:2001:7b8:3a7:0:2dfe:a80e:4c91:edd0]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 4D1685C44; Sun, 15 Sep 2013 11:45:22 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_C82A5FEB-637E-43BE-AA7C-B57FCB1E84EF"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: Building java/openjdk7 with clang From: Dimitry Andric In-Reply-To: <20130915060706.GH41229@kib.kiev.ua> Date: Sun, 15 Sep 2013 11:45:09 +0200 Message-Id: References: <108F3771-64B3-40E9-91FA-04C160442608@FreeBSD.org> <20130915060706.GH41229@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1510) Cc: java@FreeBSD.org, Baptiste Daroussin , Greg Lewis X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2013 09:45:25 -0000 --Apple-Mail=_C82A5FEB-637E-43BE-AA7C-B57FCB1E84EF Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Sep 15, 2013, at 08:07, Konstantin Belousov wrote: > On Sun, Sep 15, 2013 at 01:45:19AM +0200, Dimitry Andric wrote: ... >> - Change the $(CC) -dumpspecs hack in one of the Makefiles to something >> more portable. The -dumpspecs is done to figure out if the compiler >> uses --hash-style=gnu when linking, and if it does, it changes the >> option to --hash-style=both. On FreeBSD, this is basically a no-op, > Compiler ? Do you reference the ELF hash there ? Why do you think this is > nop ? Before your r236137 in head, our gcc did not pass --hash-style at all, afterwards it passes --hash-style=both (for dynamic executables). Similar for our clang, before and after r236258. So grepping for --hash-style=gnu in the verbose output will never give a hit, and the JDK Makefile will never add an explicit --hash-style=both argument. Therefore, for FreeBSD, the whole block is effectively a nop. Maybe the change from -dumpspecs to a small link operation using -v can be sent upstream, so it works for all compilers. -Dimitry --Apple-Mail=_C82A5FEB-637E-43BE-AA7C-B57FCB1E84EF Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) iEYEARECAAYFAlI1gbAACgkQsF6jCi4glqPOKQCg4z5P2X6cOSefpX4qVxfmKDIH /B0AoPPDyXMv5vk939kDjIkY/YsduqH3 =zUJA -----END PGP SIGNATURE----- --Apple-Mail=_C82A5FEB-637E-43BE-AA7C-B57FCB1E84EF-- From owner-freebsd-java@FreeBSD.ORG Sun Sep 15 18:51:43 2013 Return-Path: Delivered-To: freebsd-java@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E48B1D72; Sun, 15 Sep 2013 18:51:43 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B87B72FAE; Sun, 15 Sep 2013 18:51:43 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r8FIphMx070234; Sun, 15 Sep 2013 18:51:43 GMT (envelope-from madpilot@freefall.freebsd.org) Received: (from madpilot@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r8FIphwD070233; Sun, 15 Sep 2013 18:51:43 GMT (envelope-from madpilot) Date: Sun, 15 Sep 2013 18:51:43 GMT Message-Id: <201309151851.r8FIphwD070233@freefall.freebsd.org> To: madpilot@FreeBSD.org, freebsd-java@FreeBSD.org, madpilot@FreeBSD.org From: madpilot@FreeBSD.org Subject: Re: java/182100: Usage of iconv is missing in openjdk6-b27_7 X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2013 18:51:44 -0000 Synopsis: Usage of iconv is missing in openjdk6-b27_7 Responsible-Changed-From-To: freebsd-java->madpilot Responsible-Changed-By: madpilot Responsible-Changed-When: Sun Sep 15 18:51:43 UTC 2013 Responsible-Changed-Why: I'll take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=182100 From owner-freebsd-java@FreeBSD.ORG Sun Sep 15 20:11:39 2013 Return-Path: Delivered-To: java@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7796AE09; Sun, 15 Sep 2013 20:11:39 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4363D2370; Sun, 15 Sep 2013 20:11:38 +0000 (UTC) Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.14.7/8.14.7) with ESMTP id r8FJlUKP030536; Sun, 15 Sep 2013 12:47:30 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.14.7/8.14.7/Submit) id r8FJlT9E030535; Sun, 15 Sep 2013 12:47:29 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Sun, 15 Sep 2013 12:47:29 -0700 From: Greg Lewis To: Dimitry Andric Subject: Re: Building java/openjdk7 with clang Message-ID: <20130915194729.GA35020@misty.eyesbeyond.com> References: <108F3771-64B3-40E9-91FA-04C160442608@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <108F3771-64B3-40E9-91FA-04C160442608@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: java@freebsd.org, Baptiste Daroussin , Greg Lewis X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2013 20:11:39 -0000 G'day Dimitry, On Sun, Sep 15, 2013 at 01:45:19AM +0200, Dimitry Andric wrote: > I took some time to figure out how to build java/openjdk7 with clang. > There are a few items I changed: > > - Change a few instances of "ifneq ($(COMPILER_WARNINGS_FATAL),false)" > to "ifeq ($(COMPILER_WARNINGS_FATAL),true)", to make sure -Werror is > *not* used. There are zillions of warnings in openjdk, and I don't > think it is worth the trouble to fix them all (even if that is > possible :). > - Remove -fcheck-new from CFLAGS, since clang does not support it, and > it does not make sense anyway. This is the only one that is not > strictly needed; if -Werror is not enabled, clang will just print a > warning that the option is unused, but it won't be fatal. > - Change the $(CC) -dumpspecs hack in one of the Makefiles to something > more portable. The -dumpspecs is done to figure out if the compiler > uses --hash-style=gnu when linking, and if it does, it changes the > option to --hash-style=both. On FreeBSD, this is basically a no-op, > so it could also be commented out entirely. > - In jdk/src/solaris/native/java/net/net_util_md.c, change two > instances of CHECK_NULL() to CHECK_NULL_RETURN(), since the function > they are in is supposed to return a value. I chose to return 0, > since that is what the function seems to use as a default value. > > With these fixes, openjdk7 builds and runs fine for me. I tried to run > "gmake test" in the work directory, but that didn't do much, so I am > not sure if a full test suite will survive anything. It would be nice > if anybody knows a good way to test the produced binaries more > thoroughly. What version of FreeBSD did you do this on? Does it break compilation with gcc? For the change wrt COMPILER_WARNINGS_FATAL, why not set this to false for clang rather than turn this off unless explicitly on for all compilers? In terms of testing, that's a bit of a sore spot. You could notionally run it through the test suite, but you'd need to compare that to a version built with gcc since I suspect there will be numerous failures anyway. -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org From owner-freebsd-java@FreeBSD.ORG Sun Sep 15 21:59:40 2013 Return-Path: Delivered-To: java@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 485C5384; Sun, 15 Sep 2013 21:59:40 +0000 (UTC) (envelope-from dim@freebsd.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8F9122811; Sun, 15 Sep 2013 21:59:39 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::4d44:96a2:eeb5:1518] (unknown [IPv6:2001:7b8:3a7:0:4d44:96a2:eeb5:1518]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 79E275C44; Sun, 15 Sep 2013 23:59:30 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_EF54FA7C-BD10-4024-AEEE-7651A5C44C58"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: Building java/openjdk7 with clang From: Dimitry Andric In-Reply-To: <20130915194729.GA35020@misty.eyesbeyond.com> Date: Sun, 15 Sep 2013 23:59:22 +0200 Message-Id: <8E1E16F7-23F6-48EB-90C4-4DD44A50A4A6@freebsd.org> References: <108F3771-64B3-40E9-91FA-04C160442608@FreeBSD.org> <20130915194729.GA35020@misty.eyesbeyond.com> To: Greg Lewis X-Mailer: Apple Mail (2.1510) Cc: "java@FreeBSD.org" , Baptiste Daroussin X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2013 21:59:40 -0000 --Apple-Mail=_EF54FA7C-BD10-4024-AEEE-7651A5C44C58 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Sep 15, 2013, at 21:47, Greg Lewis wrote: > On Sun, Sep 15, 2013 at 01:45:19AM +0200, Dimitry Andric wrote: >> I took some time to figure out how to build java/openjdk7 with clang. >> There are a few items I changed: >> >> - Change a few instances of "ifneq ($(COMPILER_WARNINGS_FATAL),false)" >> to "ifeq ($(COMPILER_WARNINGS_FATAL),true)", to make sure -Werror is >> *not* used. There are zillions of warnings in openjdk, and I don't >> think it is worth the trouble to fix them all (even if that is >> possible :). >> - Remove -fcheck-new from CFLAGS, since clang does not support it, and >> it does not make sense anyway. This is the only one that is not >> strictly needed; if -Werror is not enabled, clang will just print a >> warning that the option is unused, but it won't be fatal. >> - Change the $(CC) -dumpspecs hack in one of the Makefiles to something >> more portable. The -dumpspecs is done to figure out if the compiler >> uses --hash-style=gnu when linking, and if it does, it changes the >> option to --hash-style=both. On FreeBSD, this is basically a no-op, >> so it could also be commented out entirely. >> - In jdk/src/solaris/native/java/net/net_util_md.c, change two >> instances of CHECK_NULL() to CHECK_NULL_RETURN(), since the function >> they are in is supposed to return a value. I chose to return 0, >> since that is what the function seems to use as a default value. >> >> With these fixes, openjdk7 builds and runs fine for me. I tried to run >> "gmake test" in the work directory, but that didn't do much, so I am >> not sure if a full test suite will survive anything. It would be nice >> if anybody knows a good way to test the produced binaries more >> thoroughly. > > What version of FreeBSD did you do this on? Does it break compilation > with gcc? This was on a very recent head. I have not tested building with gcc, but I don't think any of these changes are very likely to cause breakage for gcc. I also don't expect them to cause any trouble for stable branches. > For the change wrt COMPILER_WARNINGS_FATAL, why not set this to false > for clang rather than turn this off unless explicitly on for all compilers? Because the default value of COMPILER_WARNINGS_FATAL was off for bsd, see jdk/make/common/shared/Defs-bsd.gmk, which has: # Default for COMPILER_WARNINGS_FATAL on BSD (C & C++ compiler warnings) ifndef COMPILER_WARNINGS_FATAL COMPILER_WARNINGS_FATAL=false endif However, the value of COMPILER_WARNINGS_FATAL was not checked consistently. In most makefiles, the test is: ifeq ($(COMPILER_WARNINGS_FATAL),true) so if the macro is not defined at all, the test will fail, but only in two makefiles, the test is: ifneq ($(COMPILER_WARNINGS_FATAL),false) which causes the test to (erroneously) succeed if the macro is not defined at all! This is what caused the -Werror option to be added, even while the global setting COMPILER_WARNINGS_FATAL was off. Maybe the Makefiles should really be fixed to properly include the global Defs-bsd.gmk file, but that looks like it will cause a lot more churn. > In terms of testing, that's a bit of a sore spot. You could notionally > run it through the test suite, but you'd need to compare that to a version > built with gcc since I suspect there will be numerous failures anyway. I tried running "gmake test" in the root of the work dir, but while it did indicate success, it also didn't seem to do very much. So where is the real test suite located? -Dimitry --Apple-Mail=_EF54FA7C-BD10-4024-AEEE-7651A5C44C58 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) iEYEARECAAYFAlI2LcEACgkQsF6jCi4glqOGhwCgq4iKhsHuJ36D53lGvtSSp75O 4wcAoMp1a4DGka8189f+g5AjltfyRo9d =0SOG -----END PGP SIGNATURE----- --Apple-Mail=_EF54FA7C-BD10-4024-AEEE-7651A5C44C58-- From owner-freebsd-java@FreeBSD.ORG Mon Sep 16 11:06:47 2013 Return-Path: Delivered-To: freebsd-java@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A9224BBD for ; Mon, 16 Sep 2013 11:06:47 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7C5A52158 for ; Mon, 16 Sep 2013 11:06:47 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r8GB6liK089664 for ; Mon, 16 Sep 2013 11:06:47 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r8GB6l6a089662 for freebsd-java@FreeBSD.org; Mon, 16 Sep 2013 11:06:47 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 16 Sep 2013 11:06:47 GMT Message-Id: <201309161106.r8GB6l6a089662@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-java@FreeBSD.org Subject: Current problem reports assigned to freebsd-java@FreeBSD.org X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2013 11:06:47 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o ports/181136 java java/icedtea-web not build o ports/180643 java java/openjdk6 build fails on amd64 -current o ports/178856 java java/openjdk6, java/openjdk7: Java fails to print when o ports/178816 java java/netbeans does not build, compile error at java/op o ports/178728 java [UPDATE] devel/apache-ant to v1.9.0 o ports/178647 java java/openjdk6 does not build (without extra hack) o ports/178199 java java/openjdk6 regression amd64/clang o ports/177802 java Could not update openfire because of problem in java/o o ports/175300 java java/jamvm fails to compile on ARM6 (raspberry-pi) o ports/174826 java java/openjdk6: gmake[5]: *** [/usr/ports/java/openjdk6 o ports/174825 java java/openjdk6: fails to build on i386 (64-bit mode not o ports/173603 java java/icedtea-web starts javaws incorrectly o ports/173592 java java/openjdk6 fails on FreeBSD_9_1_RC2 o ports/173210 java java/openjdk6 - use better src placement o java/172962 java Sig11 while compiling OpenJDK6-b26 using clang o ports/171014 java [patch] Correct java/openjdk6 Dependency Declaration o ports/167903 java [PATCH] java/openjdk6: Fix build failure in 8.3 jail r o ports/164941 java [UPDATE] [NEW PORTS] java/classpath-initial, including o ports/162991 java java/openjdk6 fails to build o java/162522 java OpenJDK 6 is not setting close on exec o java/160553 java Jaikoz java based audio tagger core dumps o ports/159787 java java/openjdk6 nio muti-thread bug o ports/154884 java java/openjdk6: Every NetBeans version on FreeBSD 8.1 c f java/147512 java Crash of RXTX-2.1-7 on AMD64 system o java/140002 java java/openjdk6: jconsole dumps tomcat when contacting j o java/128809 java JVM aborted when GNU RXTX write to serial port. o java/123555 java linux-sun-jdk15, linux-sun-jdk16 produce a coredump o java/122513 java native JDKs unbuildable with Linux ones o ports/119732 java java/linux-sun-jre16: linux-sun-jre16 plugin doesn't w o java/119063 java An unexpected error has been detected by Java Runtime o ports/116082 java java/linux-sun-jdk16 jconsole is unable to connect to 31 problems total. From owner-freebsd-java@FreeBSD.ORG Thu Sep 19 10:30:37 2013 Return-Path: Delivered-To: java@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id F2A03DF9; Thu, 19 Sep 2013 10:30:36 +0000 (UTC) (envelope-from welcome@aexp.com) Received: from inetigak.in4u.ch (inetigak.in4u.ch [62.2.176.13]) by mx1.freebsd.org (Postfix) with ESMTP id F1319244A; Thu, 19 Sep 2013 10:30:34 +0000 (UTC) Received: from 62.2.176.13(helo=yotkaojpqgp.xnrqpfsyquzampk.va) by inetigak.in4u.ch with esmtpa (Exim 4.69) (envelope-from ) id 1MMO1W-8079ys-2O for java@freebsd.org; Thu, 19 Sep 2013 11:30:35 +0100 Received: from 62.2.176.13 (account welcome@aexp.com HELO yyxzhjlabhkpt.uxpasyvmlmwryvb.ua) by inetigak.in4u.ch (CommuniGate Pro SMTP 5.2.3) with ESMTPA id 488661995 for java@freebsd.org; Thu, 19 Sep 2013 11:30:35 +0100 Date: Thu, 19 Sep 2013 11:30:35 +0100 From: "Oliver_Negron" X-Mailer: The Bat! (v2.00.3) Personal X-Priority: 3 (Normal) Message-ID: <6362625700.QIWW0J3M958731@xxhfl.crqgxmqvcl.biz> To: , , , , Subject: Important - Attached Docs MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----------012C49A931CF5F2B" X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2013 10:30:37 -0000 ------------012C49A931CF5F2B Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit Check attached form. Marion_Perkins Portfolio Manager Commercial Banking Support Thames Gateway Commercial Office 2nd Floor, Riverbridge House, Anchor Boulevard, Crossways, Dartford, Kent DA2 6SL Depot Code 023 Tel: 01322 973865 Fax: 01322 770724 email: Marion_Perkins@rbs.co.uk Supporting your business ambitions – www.natwest.com/ahead This information is classified as Confidential unless otherwise stated. The Royal Bank of Scotland plc, Registered in Scotland No. 90312. Registered Office: 36 St Andrew Square, Edinburgh EH2 2YB Authorised by the Prudential Regulation Authority and regulated by the Financial Conduct Authority and the Prudential Regulation Authority. This e-mail message is confidential and for use by the addressee only. If the message is received by anyone other than the addressee, please return the message to the sender by replying to it and then delete the message from your computer. Internet e-mails are not necessarily secure. The Royal Bank of Scotland plc does not accept responsibility for changes made to this message after it was sent. The Royal Bank of Scotland plc may monitor e-mails for business and operational purposes. By replying to this message you give your consent to our monitoring of your email communications with us. Whilst all reasonable care has been taken to avoid the transmission of viruses, it is the responsibility of the recipient to ensure that the onward transmission, opening or use of this message and any attachments will not adversely affect its systems or data. No responsibility is accepted by The Royal Bank of Scotland plc in this regard and the recipient should carry out such virus and other checks as it considers appropriate. ------------012C49A931CF5F2B-- From owner-freebsd-java@FreeBSD.ORG Thu Sep 19 21:29:08 2013 Return-Path: Delivered-To: java@FreeBSD.org Received: from hammer.pct.niksun.com (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by hub.freebsd.org (Postfix) with ESMTP id 1D520943; Thu, 19 Sep 2013 21:29:03 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Message-ID: <523B6C00.7070501@FreeBSD.org> Date: Thu, 19 Sep 2013 17:26:24 -0400 From: Jung-uk Kim User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Dimitry Andric , Baptiste Daroussin Subject: Re: Building java/openjdk7 with clang References: <108F3771-64B3-40E9-91FA-04C160442608@FreeBSD.org> In-Reply-To: <108F3771-64B3-40E9-91FA-04C160442608@FreeBSD.org> X-Enigmail-Version: 1.5.2 Content-Type: multipart/mixed; boundary="------------090604040406090907070200" Cc: java@FreeBSD.org, Greg Lewis X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2013 21:29:08 -0000 This is a multi-part message in MIME format. --------------090604040406090907070200 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2013-09-14 19:45:19 -0400, Dimitry Andric wrote: > Hi, > > I took some time to figure out how to build java/openjdk7 with > clang. There are a few items I changed: BTW, patch-set and patch-set-jdk are directly coming from the OpenJDK Mercurial repositories: http://hg.openjdk.java.net/bsd-port/bsd-port/ http://hg.openjdk.java.net/bsd-port/bsd-port/corba/ http://hg.openjdk.java.net/bsd-port/bsd-port/hotspot/ http://hg.openjdk.java.net/bsd-port/bsd-port/jaxp/ http://hg.openjdk.java.net/bsd-port/bsd-port/jaxws/ http://hg.openjdk.java.net/bsd-port/bsd-port/jdk/ http://hg.openjdk.java.net/bsd-port/bsd-port/langtools/ Note the bsd-port is shared with other BSDs and we don't want to upset other BSD users. ;-) > - Change a few instances of "ifneq > ($(COMPILER_WARNINGS_FATAL),false)" to "ifeq > ($(COMPILER_WARNINGS_FATAL),true)", to make sure -Werror is *not* > used. There are zillions of warnings in openjdk, and I don't think > it is worth the trouble to fix them all (even if that is possible > :). AFAIK, it was *intentionally* turned on by default for HotSpot. We can override it via MAKE_ENV for ports tree for now, however. > - Remove -fcheck-new from CFLAGS, since clang does not support it, > and it does not make sense anyway. This is the only one that is > not strictly needed; if -Werror is not enabled, clang will just > print a warning that the option is unused, but it won't be fatal. A proper fix may be committed to upstream to minimize diff. Please see my patch for example. > - Change the $(CC) -dumpspecs hack in one of the Makefiles to > something more portable. The -dumpspecs is done to figure out if > the compiler uses --hash-style=gnu when linking, and if it does, it > changes the option to --hash-style=both. On FreeBSD, this is > basically a no-op, so it could also be commented out entirely. Agreed. It was based on Defs-linux.gmk but it is actually BSD-specific file. I don't think any BSDs ever used '--hash-style=gnu'. Therefore, this check should be removed altogether, IMO. BTW, your test doesn't work because the output is going to stderr, not stdout. Please see my patch for "-fcheck-new" for a proper test. ;-) > - In jdk/src/solaris/native/java/net/net_util_md.c, change two > instances of CHECK_NULL() to CHECK_NULL_RETURN(), since the > function they are in is supposed to return a value. I chose to > return 0, since that is what the function seems to use as a default > value. Looks good. Actually, this problem was fixed in JDK8 long ago: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/eb441933f6fe > With these fixes, openjdk7 builds and runs fine for me. I tried to > run "gmake test" in the work directory, but that didn't do much, so > I am not sure if a full test suite will survive anything. It would > be nice if anybody knows a good way to test the produced binaries > more thoroughly. Thanks for working on this! Jung-uk Kim * PS: The attached patch is also available from here: http://people.freebsd.org/~jkim/openjdk7.diff -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iQEcBAEBAgAGBQJSO2v/AAoJECXpabHZMqHOtVIIAIHsmyECYTRq/aZ8XDpqaWF7 fgzLk9Cr3+nigSTHBf/vqDqaMUEQz9uQlgv+YrKYoNlbiUw/DjDg9tmpRxKtsDRh 6qg4hzVlVdgJqMvIaRi+SFsLZY3/eym1NzWs2MKqJj0BqmSt4uubkQP43xJCGMgO 2A5e4q3RO97MwV/z0ocQ5LgB092a3OkyF+9lMG0enw1FJgfQSwcnZuqQa7howF4l +nazX5ey3aVfzwVUaldjsl5XsdTlX0ed5hd+bc60pEc5P+fcBmW1Mzpl8BJg0mgh qaKYyWrtHWcWEBq/Y2C6jv/F8JljH9UWuBlvOOJzXo9aOSW5MPguNXQbA8MoPo8= =QTdD -----END PGP SIGNATURE----- --------------090604040406090907070200 Content-Type: text/x-patch; name="openjdk7.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="openjdk7.diff" Index: java/openjdk7/Makefile =================================================================== --- java/openjdk7/Makefile (revision 327646) +++ java/openjdk7/Makefile (working copy) @@ -29,7 +29,6 @@ USES= iconv gmake USE_XORG+= x11 xext xi xrender xt xtst MAKE_ARGS= CC=${CC} CXX=${CXX} HOST_CC=${CC} MAKE_JOBS_UNSAFE= yes -USE_GCC= any OPTIONS_DEFINE= DEBUG POLICY TZUPDATE OPTIONS_DEFAULT= POLICY TZUPDATE @@ -86,6 +85,7 @@ MAKE_ENV+= LANG="C" \ JAVACMD=${BOOTSTRAPJDKDIR}/bin/java \ X11DIR="${LOCALBASE}" \ LOCALDIR="${LOCALBASE}" \ + COMPILER_WARNINGS_FATAL="false" \ NO_DOCS="true" \ SKIP_COMPARE_IMAGES="true" \ SKIP_FASTDEBUG_BUILD="true" \ Index: java/openjdk7/files/patch-set-clang =================================================================== --- java/openjdk7/files/patch-set-clang (revision 0) +++ java/openjdk7/files/patch-set-clang (working copy) @@ -0,0 +1,13 @@ +--- hotspot/make/bsd/makefiles/gcc.make.orig ++++ hotspot/make/bsd/makefiles/gcc.make +@@ -111,7 +111,10 @@ + CFLAGS += -fno-rtti + CFLAGS += -fno-exceptions + CFLAGS += -pthread ++# Clang does not support -fcheck-new. ++ifeq (,$(findstring clang,$(shell $(CC) -v 2>&1))) + CFLAGS += -fcheck-new ++endif + # version 4 and above support fvisibility=hidden (matches jni_x86.h file) + # except 4.1.2 gives pointless warnings that can't be disabled (afaik) + ifneq "$(shell expr \( $(CC_VER_MAJOR) \> 4 \) \| \( \( $(CC_VER_MAJOR) = 4 \) \& \( $(CC_VER_MINOR) \>= 3 \) \))" "0" Property changes on: java/openjdk7/files/patch-set-clang ___________________________________________________________________ Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: java/openjdk7/files/patch-set-jdk-clang =================================================================== --- java/openjdk7/files/patch-set-jdk-clang (revision 0) +++ java/openjdk7/files/patch-set-jdk-clang (working copy) @@ -0,0 +1,17 @@ +--- jdk/make/common/Defs-bsd.gmk.orig ++++ jdk/make/common/Defs-bsd.gmk +@@ -217,14 +217,6 @@ + LDFLAGS_COMMON += $(LDFLAGS_COMMON_$(ARCH)) + endif + +-# If this is a --hash-style=gnu system, use --hash-style=both +-# The gnu .hash section won't work on some Linux systems like SuSE 10. +-_HAS_HASH_STYLE_GNU:=$(shell $(CC) -dumpspecs | $(GREP) -- '--hash-style=gnu') +-ifneq ($(_HAS_HASH_STYLE_GNU),) +- LDFLAGS_HASH_STYLE = -Wl,--hash-style=both +-endif +-LDFLAGS_COMMON += $(LDFLAGS_HASH_STYLE) +- + # + # Selection of warning messages + # Property changes on: java/openjdk7/files/patch-set-jdk-clang ___________________________________________________________________ Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Index: java/openjdk7/files/patch-src-solaris-native-java-net-net_util_md.c =================================================================== --- java/openjdk7/files/patch-src-solaris-native-java-net-net_util_md.c (revision 0) +++ java/openjdk7/files/patch-src-solaris-native-java-net-net_util_md.c (working copy) @@ -0,0 +1,14 @@ +--- jdk/src/solaris/native/java/net/net_util_md.c.orig ++++ jdk/src/solaris/native/java/net/net_util_md.c +@@ -118,9 +118,9 @@ + static jfieldID ni_defaultIndexID; + if (ni_class == NULL) { + jclass c = (*env)->FindClass(env, "java/net/NetworkInterface"); +- CHECK_NULL(c); ++ CHECK_NULL_RETURN(c, 0); + c = (*env)->NewGlobalRef(env, c); +- CHECK_NULL(c); ++ CHECK_NULL_RETURN(c, 0); + ni_defaultIndexID = (*env)->GetStaticFieldID( + env, c, "defaultIndex", "I"); + ni_class = c; Property changes on: java/openjdk7/files/patch-src-solaris-native-java-net-net_util_md.c ___________________________________________________________________ Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property --------------090604040406090907070200-- From owner-freebsd-java@FreeBSD.ORG Sat Sep 21 08:28:12 2013 Return-Path: Delivered-To: java@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4F2FFF7C for ; Sat, 21 Sep 2013 08:28:12 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from portsmon.freebsd.org (portsmon.freebsd.org [IPv6:2001:1900:2254:206a::50:3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 266722058 for ; Sat, 21 Sep 2013 08:28:12 +0000 (UTC) Received: from portsmon.freebsd.org ([127.0.1.104]) by portsmon.freebsd.org (8.14.7/8.14.7) with ESMTP id r8L8SCNZ028850 for ; Sat, 21 Sep 2013 08:28:12 GMT (envelope-from linimon@FreeBSD.org) Date: Sat, 21 Sep 2013 08:28:12 GMT Message-Id: <201309210828.r8L8SCNZ028850@portsmon.freebsd.org> From: linimon@FreeBSD.org To: java@freebsd.org Subject: FreeBSD ports that you maintain which are currently marked broken X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: portmgr-feedback@FreeBSD.org List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Sep 2013 08:28:12 -0000 Dear FreeBSD port maintainer: As part of an ongoing effort to reduce the number of problems in the FreeBSD ports system, we periodically notify users of ports that are marked as "broken" in their Makefiles. In many cases these ports are failing to compile on some subset of the FreeBSD build environments. The most common problem is that recent versions of -CURRENT include gcc4.2, which is much stricter than older versions. The next most common problem is that compiles succeed on the i386 architecture (e.g. the common Intel PC), but fail on one or more of the other architectures due to assumptions about things such as size of various types, byte-alignment issues, and so forth. In occasional cases we see that the same port may have different errors in different build environments. The script that runs on the build cluster uses heuristics to try to 'guess' the error type to help you isolate problems, but it is only a rough guide. One more note: on occasion, there are transient build errors seen on the build farm. Unfortunately, there is not yet any way for this algorithm to tell the difference (humans are much, much better at this kind of thing.) The errors are listed below. In the case where the same problem exists on more than one build environment, the URL points to the latest errorlog for that type. (By 'build environment' here we mean 'combination of 7.x/8.x/9.x/-current with target architecture'.) (Note: the dates are included to help you to gauge whether or not the error still applies to the latest version. The program that generates this report is not yet able to determine this automatically.) portname: java/jai-imageio broken because: relies on linuxpluginwrapper build errors: none. overview: http://portsmon.FreeBSD.org/portoverview.py?category=java&portname=jai-imageio If these errors are ones that you are already aware of, please accept our apologies and ignore this message. On the other hand, if you no longer wish to maintain this port (or ports), please reply with a message stating that, and accept our thanks for your efforts in the past. Every effort has been made to make sure that these error reports really do correspond to a port that you maintain. However, due to the fact that this is an automated process, it may indeed generate false matches. If one of these errors fits that description, please forward this email to the author of this software, Mark Linimon , so that he can attempt to fix the problem in the future. Thanks for your efforts to help improve FreeBSD.