From owner-freebsd-net@FreeBSD.ORG Sun Nov 17 02:22:56 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C235EE44 for ; Sun, 17 Nov 2013 02:22:56 +0000 (UTC) Received: from mail-ob0-x234.google.com (mail-ob0-x234.google.com [IPv6:2607:f8b0:4003:c01::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8F4F02178 for ; Sun, 17 Nov 2013 02:22:56 +0000 (UTC) Received: by mail-ob0-f180.google.com with SMTP id vb8so5603609obc.11 for ; Sat, 16 Nov 2013 18:22:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=OUmfN14CFzHN3rtP4cqaaPNgbDZSosEZug26Myyy5KM=; b=HmaocQ7pxEyuSCJ8fnOGlmQC5cN3lmBfTqIWycMZVw15t4zPSpORBEoOOYmrCDpNjZ qnz+70GJO1e0jyXKy9CWIRIhmesuQb4JgOQ0xG5UdpmQfE1izJ6wlCBb9ZyRvwKis6Tw wKUrfvQo5t3VLiQ83Wd8tA52oCysLeMnJfxufNIuQLDC/DiTxLDzkvII4zKd9ro3WW5K tg7lpAcL27E+0nIukinYCtRnkb02d70yjNtUJ2mhXsYOYgVBEYEIfnRdZs5yIe72xah0 R4p5pliS9j2qUibcvnqPATXZSzlYyBpsMdJxZwiYv0yAEm+KpWrCWqqf6xPn1LN7wJGq +RUA== X-Received: by 10.182.24.69 with SMTP id s5mr13761009obf.35.1384654975210; Sat, 16 Nov 2013 18:22:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.60.46.170 with HTTP; Sat, 16 Nov 2013 18:22:35 -0800 (PST) In-Reply-To: <4CA8022F-E827-4417-9541-4E3EB4D6155E@obsigna.com> References: <6066426D-84BE-40F6-904D-9FF97B128555@obsigna.com> <5287EE0F.3070800@smeets.im> <4CA8022F-E827-4417-9541-4E3EB4D6155E@obsigna.com> From: Raimundo Santos Date: Sun, 17 Nov 2013 00:22:35 -0200 Message-ID: Subject: Re: MPD5 PPTP and L2TP server problem with FreeBSD 9.2-RELEASE-p1 To: "Dr. Rolf Jansen" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.16 Cc: "freebsd-net@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Nov 2013 02:22:56 -0000 On 16 November 2013 20:52, Dr. Rolf Jansen wrote: > > Am 16.11.2013 um 20:13 schrieb Florian Smeets : > > > On 16/11/13 22:48, Dr. Rolf Jansen wrote: > > > > > > Do you set net.inet.ip.forwarding in /etc/sysctl.conf? Try setting > > gateway_enable="YES" in /etc/rc.conf. This is caused by some changes in > > the rc system and the scripts it calls on interface creation. This bit > > me too. > > > > It looks like directly setting net.inet.ip.forwarding in sysctl.conf has > > never been officially supported. Though the last time I used > > gateway_enable was probably in the 4.X days, and setting it in > > sysctl.conf has always worked for me, until now :) > same problem to me: http://thread.gmane.org/gmane.os.freebsd.devel.net/40700/focus=40701 Eugene's follow up was very instructive. By now, my production router have gateway_enable="YES" even with sysctl.conf configured to forward packets. Where can we send a PR? As sugested by Eugene, it is not fault of MPD, right? cheers, Raimundo Santos From owner-freebsd-net@FreeBSD.ORG Sun Nov 17 02:41:58 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 14629367 for ; Sun, 17 Nov 2013 02:41:58 +0000 (UTC) Received: from mail-qa0-x22f.google.com (mail-qa0-x22f.google.com [IPv6:2607:f8b0:400d:c00::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C71BF2242 for ; Sun, 17 Nov 2013 02:41:57 +0000 (UTC) Received: by mail-qa0-f47.google.com with SMTP id w8so1475300qac.6 for ; Sat, 16 Nov 2013 18:41:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=WoCiCr8hycsesN6L6hTSIIfPmtIMZj+fIBsID3kZOQc=; b=GAKUNum6qdD5dKC3+Q45bDWulQovIvUuY8P53jg/p+YVLXspAMBvAabUMTZOZJNd9k TFuiJVrYaaswWPwrzJ1K+ki0cSyfO/XGsRMTncTLl4UgFYocV8FeAEMUSS0+Obv1kYDL 8HAFnu0R0/F91XkKviHc9J3j6sOgV4Os/28Wk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=WoCiCr8hycsesN6L6hTSIIfPmtIMZj+fIBsID3kZOQc=; b=QMoDaOqXiCd3iFH9JUWqwxISi67+Mz6tUtYL4lInq1rAKnrkMi6u45Q2Nq+h7FbgAF 3myBzlEcKp8q4A4oio8u4QdJ0Gc7Vll0or8oZ7VBAdIVu1UHy2GjV+t+qHeXHCNQAe3T 2/GGAf68SRTXGs36d6Gap6AInJ/1uc3cT58PrrpMcNIcWXufRa8vatlpe2GoBW406kt8 lH+zJfr4vA3UFV9mL9PLqybhpnrudHF5D8FFNr/IztDfAHejYHc2A0FDnovq2vwQSFvS YyNHSHihW7ZEi8toT/Pi1d+juO6KC0xfC3KBwbv3nO7VgGhU8HNisdjtpL2froULPVAH iYOw== X-Gm-Message-State: ALoCoQkTp+yVaKPclofxCQF2xL1O2W1d7QFVTBvZEIz/hP4vC7NA6S5xCNR82LK3kna7vh3E8K3b X-Received: by 10.224.131.67 with SMTP id w3mr23413630qas.62.1384656116781; Sat, 16 Nov 2013 18:41:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.96.63.101 with HTTP; Sat, 16 Nov 2013 18:41:26 -0800 (PST) In-Reply-To: <20131115165210.23f82578@stevek-ubuntu> References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> From: Eitan Adler Date: Sat, 16 Nov 2013 21:41:26 -0500 Message-ID: Subject: Re: [JNPR] Network stack as a module (RFC) To: Steve Kiernan Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-net@freebsd.org" , luigi@freebsd.org, Marcel Moolenaar , zec@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Nov 2013 02:41:58 -0000 On Fri, Nov 15, 2013 at 4:52 PM, Steve Kiernan wrote: > This is a follow up to the request sent back in January titled "Proposal for changes to network device drivers and network stack". > > In order to make it easier to review, we will be submitting pieces to be contributed in logical blocks. > > Please review the following patch and provide feedback: > http://people.freebsd.org/~marcel/Juniper/201311/netstack-option.diff There are a few empty #ifdef blocks: such as in sys/compat/svr4/svr4_proto.h +#ifdef NETSTACK +#else +#endif +#ifdef NETSTACK +#else +#endif +#ifdef NETSTACK +#else +#endif +#ifdef NETSTACK +#else +#endif Do we need these? From owner-freebsd-net@FreeBSD.ORG Sun Nov 17 18:10:18 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B68DF313; Sun, 17 Nov 2013 18:10:18 +0000 (UTC) Received: from mail.xcllnt.net (mail.xcllnt.net [50.0.150.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7234D2B20; Sun, 17 Nov 2013 18:10:18 +0000 (UTC) Received: from macbook-air.wifi.xcllnt.net (50-0-150-213.dsl.static.sonic.net [50.0.150.213]) (authenticated bits=0) by mail.xcllnt.net (8.14.7/8.14.7) with ESMTP id rAHIAFTQ005001 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 17 Nov 2013 10:10:16 -0800 (PST) (envelope-from marcel@xcllnt.net) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: [JNPR] Network stack as a module (RFC) From: Marcel Moolenaar In-Reply-To: <20131116084919.GF7577@glebius.int.ru> Date: Sun, 17 Nov 2013 10:10:15 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <1DAF9090-08DA-404B-B86B-57E5D124D70D@xcllnt.net> References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131116084919.GF7577@glebius.int.ru> To: Gleb Smirnoff X-Mailer: Apple Mail (2.1822) Cc: luigi@freebsd.org, Marcel Moolenaar , Steve Kiernan , freebsd-net@freebsd.org, zec@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Nov 2013 18:10:18 -0000 On Nov 16, 2013, at 12:49 AM, Gleb Smirnoff wrote: > Steve, >=20 > On Fri, Nov 15, 2013 at 04:52:10PM -0500, Steve Kiernan wrote: > S> This is a follow up to the request sent back in January titled = "Proposal for changes to network device drivers and network stack". > S>=20 > S> In order to make it easier to review, we will be submitting pieces = to be contributed in logical blocks. > S>=20 > S> Please review the following patch and provide feedback: > S> = http://people.freebsd.org/~marcel/Juniper/201311/netstack-option.diff > S>=20 > S> The details of this patch are as follows (and what is suggested for = the commit log): > S>=20 > S> Add a NETSTACK option to facilitate separating network stack pieces = from the > S> rest of the OS core. This is the first step towards having the = network stack > S> as a module. >=20 > You probably mean "having the network stack optional", since under = module we > usually mean loadable kernel module. Actually, we do mean module. At Juniper we have the FreeBSD stack as a loadable module now. We also have the Juniper stack as a loadable module. Depending on context, we can use the most appropriate one. Yes, this implies that we also have a stable interface between the NIC driver and the network stack itself. We'll be contributing that as well... Note that assumptions in the finalization of setting up networking limits the network stack from being loaded manually, not to mention that unloading is an entirely different challenge. Nonetheless it's very useful without all that and I think it will make it easier for people to change the network stack or experiment with beta versions this way. It all really comes in handy for the opaque ifnet work... FYI, --=20 Marcel Moolenaar marcel@xcllnt.net From owner-freebsd-net@FreeBSD.ORG Sun Nov 17 21:00:01 2013 Return-Path: Delivered-To: freebsd-net@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BA910B03 for ; Sun, 17 Nov 2013 21:00:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AAA9522F5 for ; Sun, 17 Nov 2013 21:00:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAHL01YJ001241 for ; Sun, 17 Nov 2013 21:00:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAHL0124001240; Sun, 17 Nov 2013 21:00:01 GMT (envelope-from gnats) Date: Sun, 17 Nov 2013 21:00:01 GMT Message-Id: <201311172100.rAHL0124001240@freefall.freebsd.org> To: freebsd-net@FreeBSD.org Cc: From: dfilter@FreeBSD.ORG (dfilter service) Subject: Re: kern/181931: commit references a PR X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: dfilter service List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Nov 2013 21:00:01 -0000 The following reply was made to PR kern/181931; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/181931: commit references a PR Date: Sun, 17 Nov 2013 20:58:38 +0000 (UTC) Author: alfred Date: Sun Nov 17 20:58:31 2013 New Revision: 258276 URL: http://svnweb.freebsd.org/changeset/base/258276 Log: Fix creating a vlan over lagg over mlxen crash. PR: 181931 Submitted by: Shahar Klein (shahark mellanox.com) Modified: head/sys/ofed/drivers/net/mlx4/en_netdev.c Modified: head/sys/ofed/drivers/net/mlx4/en_netdev.c ============================================================================== --- head/sys/ofed/drivers/net/mlx4/en_netdev.c Sun Nov 17 20:29:33 2013 (r258275) +++ head/sys/ofed/drivers/net/mlx4/en_netdev.c Sun Nov 17 20:58:31 2013 (r258276) @@ -52,6 +52,9 @@ static void mlx4_en_vlan_rx_add_vid(void int idx; u8 field; + if (arg != priv) + return; + if ((vid == 0) || (vid > 4095)) /* Invalid */ return; en_dbg(HW, priv, "adding VLAN:%d\n", vid); @@ -73,6 +76,9 @@ static void mlx4_en_vlan_rx_kill_vid(voi int idx; u8 field; + if (arg != priv) + return; + if ((vid == 0) || (vid > 4095)) /* Invalid */ return; en_dbg(HW, priv, "Killing VID:%d\n", vid); _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-net@FreeBSD.ORG Sun Nov 17 22:30:01 2013 Return-Path: Delivered-To: freebsd-net@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9D9AC336 for ; Sun, 17 Nov 2013 22:30:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8E107294C for ; Sun, 17 Nov 2013 22:30:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAHMU1hR020613 for ; Sun, 17 Nov 2013 22:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAHMU1ZS020612; Sun, 17 Nov 2013 22:30:01 GMT (envelope-from gnats) Date: Sun, 17 Nov 2013 22:30:01 GMT Message-Id: <201311172230.rAHMU1ZS020612@freefall.freebsd.org> To: freebsd-net@FreeBSD.org Cc: From: dfilter@FreeBSD.ORG (dfilter service) Subject: Re: kern/181931: commit references a PR X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: dfilter service List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Nov 2013 22:30:01 -0000 The following reply was made to PR kern/181931; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/181931: commit references a PR Date: Sun, 17 Nov 2013 22:24:42 +0000 (UTC) Author: alfred Date: Sun Nov 17 22:24:34 2013 New Revision: 258280 URL: http://svnweb.freebsd.org/changeset/base/258280 Log: MFC: 258276 Fix creating a vlan over lagg over mlxen crash. PR: 181931 Submitted by: Shahar Klein (shahark mellanox.com) Approved by: re Modified: stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c Directory Properties: stable/10/sys/ (props changed) Modified: stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c ============================================================================== --- stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c Sun Nov 17 21:36:19 2013 (r258279) +++ stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c Sun Nov 17 22:24:34 2013 (r258280) @@ -52,6 +52,9 @@ static void mlx4_en_vlan_rx_add_vid(void int idx; u8 field; + if (arg != priv) + return; + if ((vid == 0) || (vid > 4095)) /* Invalid */ return; en_dbg(HW, priv, "adding VLAN:%d\n", vid); @@ -73,6 +76,9 @@ static void mlx4_en_vlan_rx_kill_vid(voi int idx; u8 field; + if (arg != priv) + return; + if ((vid == 0) || (vid > 4095)) /* Invalid */ return; en_dbg(HW, priv, "Killing VID:%d\n", vid); _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-net@FreeBSD.ORG Mon Nov 18 00:39:08 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6565C7A6 for ; Mon, 18 Nov 2013 00:39:08 +0000 (UTC) Received: from mo6-p00-ob.rzone.de (mo6-p00-ob.rzone.de [IPv6:2a01:238:20a:202:5300::1]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EB7AD2145 for ; Mon, 18 Nov 2013 00:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1384735144; l=1621; s=domk; d=obsigna.com; h=To:References:Content-Transfer-Encoding:Cc:Date:In-Reply-To:From: Subject:Mime-Version:Content-Type:X-RZG-CLASS-ID:X-RZG-AUTH; bh=lzRMyO2ED1WBTc3aNvCFKfJeUvk=; b=tOhJHgdmtmGG30GYChG+vNk7/EOMEBaA6/NBq58G2SM1p2MVDoOqTUzdYqJ1OUImRsY 6yVYbZ2V3GVKr8bNKo72ZZ92FF7ryvBh1LbPLKm6/ZUIEO2S3W+tFGGutfP+hkL++Ozrz vCXjzwZ+oo5v7wZoN2CDqv7M9vnKQGW/URE= X-RZG-AUTH: :O2kGeEG7b/pS1EK7WHa0hxqKZr4lnx6UhToX1IWHkW4X7v2ImaU2BqlKi/2sgPjP5gc7 X-RZG-CLASS-ID: mo00 Received: from mail.obsigna.com (bd1db303.virtua.com.br [189.29.179.3]) by smtp.strato.de (RZmta 32.13 DYNA|AUTH) with (TLSv1.2:DHE-RSA-AES256-GCM-SHA384 encrypted) ESMTPSA id 002931pAI0d30yK ; Mon, 18 Nov 2013 01:39:03 +0100 (CET) Received: from rolf.projectworld.net (rolf.projectworld.net [192.168.222.5]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.obsigna.com (Postfix) with ESMTPSA id 78282142AF428; Sun, 17 Nov 2013 22:38:59 -0200 (BRST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: MPD5 PPTP and L2TP server problem with FreeBSD 9.2-RELEASE-p1 From: "Dr. Rolf Jansen" In-Reply-To: Date: Sun, 17 Nov 2013 22:38:58 -0200 Content-Transfer-Encoding: quoted-printable Message-Id: <79A66F26-E7D5-4A2E-8887-502AFACC7091@obsigna.com> References: <6066426D-84BE-40F6-904D-9FF97B128555@obsigna.com> <5287EE0F.3070800@smeets.im> <4CA8022F-E827-4417-9541-4E3EB4D6155E@obsigna.com> To: Raimundo Santos X-Mailer: Apple Mail (2.1510) Cc: "freebsd-net@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 00:39:08 -0000 Am 17.11.2013 um 00:22 schrieb Raimundo Santos : > On 16 November 2013 20:52, Dr. Rolf Jansen wrote: >=20 >> Am 16.11.2013 um 20:13 schrieb Florian Smeets : >>=20 >>> On 16/11/13 22:48, Dr. Rolf Jansen wrote: >>>=20 >>>=20 >>> Do you set net.inet.ip.forwarding in /etc/sysctl.conf? Try setting >>> gateway_enable=3D"YES" in /etc/rc.conf. This is caused by some = changes in >>> the rc system and the scripts it calls on interface creation. This = bit >>> me too. >>>=20 >>> It looks like directly setting net.inet.ip.forwarding in sysctl.conf = has >>> never been officially supported. Though the last time I used >>> gateway_enable was probably in the 4.X days, and setting it in >>> sysctl.conf has always worked for me, until now :) >=20 > same problem to me: > http://thread.gmane.org/gmane.os.freebsd.devel.net/40700/focus=3D40701 >=20 > Eugene's follow up was very instructive. By now, my production router = have > gateway_enable=3D"YES" even with sysctl.conf configured to forward = packets. >=20 > Where can we send a PR? As sugested by Eugene, it is not fault of MPD, > right? A PR can be send using the following web interface: http://www.freebsd.org/send-pr.html For an overview of the PR system, you might want to read the following: = http://www.freebsd.org/doc/en_US.ISO8859-1/articles/contributing/contrib-h= ow.html#CONTRIB-GENERAL I switched to gateway_enable=3D"YES" in rc.conf, and in addition I = disabled devd. I don't need to edit the sysctl directly, it was only a = habit. Best regards Rolf From owner-freebsd-net@FreeBSD.ORG Mon Nov 18 11:06:53 2013 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B3DD2A77 for ; Mon, 18 Nov 2013 11:06:53 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A263B208C for ; Mon, 18 Nov 2013 11:06:53 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAIB6ro6009130 for ; Mon, 18 Nov 2013 11:06:53 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAIB6rav009128 for freebsd-net@FreeBSD.org; Mon, 18 Nov 2013 11:06:53 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 18 Nov 2013 11:06:53 GMT Message-Id: <201311181106.rAIB6rav009128@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-net@FreeBSD.org Subject: Current problem reports assigned to freebsd-net@FreeBSD.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 11:06:53 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o bin/183687 net [patch] route(8): route add -net 172.20 add wrong host o kern/183659 net [tcp] ]TCP stack lock contention with short-lived conn o conf/183407 net [rc.d] [patch] Routing restart returns non-zero exitco o kern/183391 net [oce] 10gigabit networking problems with Emulex OCE 11 o kern/183390 net [ixgbe] 10gigabit networking problems o kern/182917 net [igb] strange out traffic with igb interfaces o kern/182847 net [netinet6] [patch] Remove dead code o kern/182665 net [wlan] Kernel panic when creating second wlandev. o kern/182382 net [tcp] sysctl to set TCP CC method on BIG ENDIAN system o kern/182297 net [cm] ArcNet driver fails to detect the link address - o kern/182212 net [patch] [ng_mppc] ng_mppc(4) blocks on network errors o kern/181970 net [re] LAN RealtekŪ 8111G is not supported by re driver o kern/181931 net [vlan] [lagg] vlan over lagg over mlxen crashes the ke o kern/181823 net [ip6] [patch] make ipv6 mroute return same errror code o kern/181741 net [kernel] [patch] Packet loss when 'control' messages a o kern/181703 net [re] [patch] Fix Realtek 8111G Ethernet controller not o kern/181657 net [bpf] [patch] BPF_COP/BPF_COPX instruction reservation o kern/181257 net [bge] bge link status change o kern/181236 net [igb] igb driver unstable work o kern/181135 net [netmap] [patch] sys/dev/netmap patch for Linux compat o kern/181131 net [netmap] [patch] sys/dev/netmap memory allocation impr o kern/181006 net [run] [patch] mbuf leak in run(4) driver o kern/180893 net [if_ethersubr] [patch] Packets received with own LLADD o kern/180844 net [panic] [re] Intermittent panic (re driver?) o kern/180775 net [bxe] if_bxe driver broken with Broadcom BCM57711 card o kern/180722 net [bluetooth] bluetooth takes 30-50 attempts to pair to s kern/180468 net [request] LOCAL_PEERCRED support for PF_INET o kern/180065 net [netinet6] [patch] Multicast loopback to own host brok o kern/179926 net [lacp] [patch] active aggregator selection bug o kern/179824 net [ixgbe] System (9.1-p4) hangs on heavy ixgbe network t o kern/179733 net [lagg] [patch] interface loses capabilities when proto o kern/179429 net [tap] STP enabled tap bridge o kern/179299 net [igb] Intel X540-T2 - unstable driver a kern/179264 net [vimage] [pf] Core dump with Packet filter and VIMAGE o kern/178947 net [arp] arp rejecting not working o kern/178782 net [ixgbe] 82599EB SFP does not work with passthrough und o kern/178612 net [run] kernel panic due the problems with run driver o kern/178472 net [ip6] [patch] make return code consistent with IPv4 co o kern/178079 net [tcp] Switching TCP CC algorithm panics on sparc64 wit s kern/178071 net FreeBSD unable to recongize Kontron (Industrial Comput o kern/177905 net [xl] [panic] ifmedia_set when pluging CardBus LAN card o kern/177618 net [bridge] Problem with bridge firewall with trunk ports o kern/177402 net [igb] [pf] problem with ethernet driver igb + pf / alt o kern/177400 net [jme] JMC25x 1000baseT establishment issues o kern/177366 net [ieee80211] negative malloc(9) statistics for 80211nod f kern/177362 net [netinet] [patch] Wrong control used to return TOS o kern/177194 net [netgraph] Unnamed netgraph nodes for vlan interfaces o kern/177184 net [bge] [patch] enable wake on lan o kern/177139 net [igb] igb drops ethernet ports 2 and 3 o kern/176884 net [re] re0 flapping up/down o kern/176671 net [epair] MAC address for epair device not unique o kern/176484 net [ipsec] [enc] [patch] panic: IPsec + enc(4); device na o kern/176446 net [netinet] [patch] Concurrency in ixgbe driving out-of- o kern/176420 net [kernel] [patch] incorrect errno for LOCAL_PEERCRED o kern/176419 net [kernel] [patch] socketpair support for LOCAL_PEERCRED o kern/176401 net [netgraph] page fault in netgraph o kern/176167 net [ipsec][lagg] using lagg and ipsec causes immediate pa o kern/176027 net [em] [patch] flow control systcl consistency for em dr o kern/176026 net [tcp] [patch] TCP wrappers caused quite a lot of warni o kern/175864 net [re] Intel MB D510MO, onboard ethernet not working aft o kern/175852 net [amd64] [patch] in_cksum_hdr() behaves differently on o kern/175734 net no ethernet detected on system with EG20T PCH chipset o kern/175267 net [pf] [tap] pf + tap keep state problem o kern/175236 net [epair] [gif] epair and gif Devices On Bridge o kern/175182 net [panic] kernel panic on RADIX_MPATH when deleting rout o kern/175153 net [tcp] will there miss a FIN when do TSO? o kern/174959 net [net] [patch] rnh_walktree_from visits spurious nodes o kern/174958 net [net] [patch] rnh_walktree_from makes unreasonable ass o kern/174897 net [route] Interface routes are broken o kern/174851 net [bxe] [patch] UDP checksum offload is wrong in bxe dri o kern/174850 net [bxe] [patch] bxe driver does not receive multicasts o kern/174849 net [bxe] [patch] bxe driver can hang kernel when reset o kern/174822 net [tcp] Page fault in tcp_discardcb under high traffic o kern/174602 net [gif] [ipsec] traceroute issue on gif tunnel with ipse o kern/174535 net [tcp] TCP fast retransmit feature works strange o kern/173871 net [gif] process of 'ifconfig gif0 create hangs' when if_ o kern/173475 net [tun] tun(4) stays opened by PID after process is term o kern/173201 net [ixgbe] [patch] Missing / broken ixgbe sysctl's and tu o kern/173137 net [em] em(4) unable to run at gigabit with 9.1-RC2 o kern/173002 net [patch] data type size problem in if_spppsubr.c o kern/172895 net [ixgb] [ixgbe] do not properly determine link-state o kern/172683 net [ip6] Duplicate IPv6 Link Local Addresses o kern/172675 net [netinet] [patch] sysctl_tcp_hc_list (net.inet.tcp.hos p kern/172113 net [panic] [e1000] [patch] 9.1-RC1/amd64 panices in igb(4 o kern/171840 net [ip6] IPv6 packets transmitting only on queue 0 o kern/171739 net [bce] [panic] bce related kernel panic o kern/171711 net [dummynet] [panic] Kernel panic in dummynet o kern/171532 net [ndis] ndis(4) driver includes 'pccard'-specific code, o kern/171531 net [ndis] undocumented dependency for ndis(4) o kern/171524 net [ipmi] ipmi driver crashes kernel by reboot or shutdow s kern/171508 net [epair] [request] Add the ability to name epair device o kern/171228 net [re] [patch] if_re - eeprom write issues o kern/170701 net [ppp] killl ppp or reboot with active ppp connection c o kern/170267 net [ixgbe] IXGBE_LE32_TO_CPUS is probably an unintentiona o kern/170081 net [fxp] pf/nat/jails not working if checksum offloading o kern/169898 net ifconfig(8) fails to set MTU on multiple interfaces. o kern/169676 net [bge] [hang] system hangs, fully or partially after re o kern/169620 net [ng] [pf] ng_l2tp incoming packet bypass pf firewall o kern/169459 net [ppp] umodem/ppp/3g stopped working after update from o kern/169438 net [ipsec] ipv4-in-ipv6 tunnel mode IPsec does not work p kern/168294 net [ixgbe] [patch] ixgbe driver compiled in kernel has no o kern/168246 net [em] Multiple em(4) not working with qemu o kern/168245 net [arp] [regression] Permanent ARP entry not deleted on o kern/168244 net [arp] [regression] Unable to manually remove permanent o kern/168183 net [bce] bce driver hang system o kern/167603 net [ip] IP fragment reassembly's broken: file transfer ov o kern/167500 net [em] [panic] Kernel panics in em driver o kern/167325 net [netinet] [patch] sosend sometimes return EINVAL with o kern/167202 net [igmp]: Sending multiple IGMP packets crashes kernel o kern/166462 net [gre] gre(4) when using a tunnel source address from c o kern/166285 net [arp] FreeBSD v8.1 REL p8 arp: unknown hardware addres o kern/166255 net [net] [patch] It should be possible to disable "promis p kern/165903 net mbuf leak o kern/165622 net [ndis][panic][patch] Unregistered use of FPU in kernel s kern/165562 net [request] add support for Intel i350 in FreeBSD 7.4 o kern/165526 net [bxe] UDP packets checksum calculation whithin if_bxe o kern/165488 net [ppp] [panic] Fatal trap 12 jails and ppp , kernel wit o kern/165305 net [ip6] [request] Feature parity between IP_TOS and IPV6 o kern/165296 net [vlan] [patch] Fix EVL_APPLY_VLID, update EVL_APPLY_PR o kern/165181 net [igb] igb freezes after about 2 weeks of uptime o kern/165174 net [patch] [tap] allow tap(4) to keep its address on clos o kern/165152 net [ip6] Does not work through the issue of ipv6 addresse o kern/164495 net [igb] connect double head igb to switch cause system t o kern/164490 net [pfil] Incorrect IP checksum on pfil pass from ip_outp o kern/164475 net [gre] gre misses RUNNING flag after a reboot o kern/164265 net [netinet] [patch] tcp_lro_rx computes wrong checksum i o kern/163903 net [igb] "igb0:tx(0)","bpf interface lock" v2.2.5 9-STABL o kern/163481 net freebsd do not add itself to ping route packet o kern/162927 net [tun] Modem-PPP error ppp[1538]: tun0: Phase: Clearing o kern/162558 net [dummynet] [panic] seldom dummynet panics o kern/162153 net [em] intel em driver 7.2.4 don't compile o kern/162110 net [igb] [panic] RELENG_9 panics on boot in IGB driver - o kern/162028 net [ixgbe] [patch] misplaced #endif in ixgbe.c o kern/161277 net [em] [patch] BMC cannot receive IPMI traffic after loa o kern/160873 net [igb] igb(4) from HEAD fails to build on 7-STABLE o kern/160750 net Intel PRO/1000 connection breaks under load until rebo o kern/160693 net [gif] [em] Multicast packet are not passed from GIF0 t o kern/160293 net [ieee80211] ppanic] kernel panic during network setup o kern/160206 net [gif] gifX stops working after a while (IPv6 tunnel) o kern/159817 net [udp] write UDPv4: No buffer space available (code=55) o kern/159629 net [ipsec] [panic] kernel panic with IPsec in transport m o kern/159621 net [tcp] [panic] panic: soabort: so_count o kern/159603 net [netinet] [patch] in_ifscrubprefix() - network route c o kern/159601 net [netinet] [patch] in_scrubprefix() - loopback route re o kern/159294 net [em] em watchdog timeouts o kern/159203 net [wpi] Intel 3945ABG Wireless LAN not support IBSS o kern/158930 net [bpf] BPF element leak in ifp->bpf_if->bif_dlist o kern/158726 net [ip6] [patch] ICMPv6 Router Announcement flooding limi o kern/158694 net [ix] [lagg] ix0 is not working within lagg(4) o kern/158665 net [ip6] [panic] kernel pagefault in in6_setscope() o kern/158635 net [em] TSO breaks BPF packet captures with em driver f kern/157802 net [dummynet] [panic] kernel panic in dummynet o kern/157785 net amd64 + jail + ipfw + natd = very slow outbound traffi o kern/157418 net [em] em driver lockup during boot on Supermicro X9SCM- o kern/157410 net [ip6] IPv6 Router Advertisements Cause Excessive CPU U o kern/157287 net [re] [panic] INVARIANTS panic (Memory modified after f o kern/157200 net [network.subr] [patch] stf(4) can not communicate betw o kern/157182 net [lagg] lagg interface not working together with epair o kern/156877 net [dummynet] [panic] dummynet move_pkt() null ptr derefe o kern/156667 net [em] em0 fails to init on CURRENT after March 17 o kern/156408 net [vlan] Routing failure when using VLANs vs. Physical e o kern/156328 net [icmp]: host can ping other subnet but no have IP from o kern/156317 net [ip6] Wrong order of IPv6 NS DAD/MLD Report o kern/156279 net [if_bridge][divert][ipfw] unable to correctly re-injec o kern/156226 net [lagg]: failover does not announce the failover to swi o kern/156030 net [ip6] [panic] Crash in nd6_dad_start() due to null ptr o kern/155680 net [multicast] problems with multicast s kern/155642 net [new driver] [request] Add driver for Realtek RTL8191S o kern/155597 net [panic] Kernel panics with "sbdrop" message o kern/155420 net [vlan] adding vlan break existent vlan o kern/155177 net [route] [panic] Panic when inject routes in kernel o kern/155010 net [msk] ntfs-3g via iscsi using msk driver cause kernel o kern/154943 net [gif] ifconfig gifX create on existing gifX clears IP s kern/154851 net [new driver] [request]: Port brcm80211 driver from Lin o kern/154850 net [netgraph] [patch] ng_ether fails to name nodes when t o kern/154679 net [em] Fatal trap 12: "em1 taskq" only at startup (8.1-R o kern/154600 net [tcp] [panic] Random kernel panics on tcp_output o kern/154557 net [tcp] Freeze tcp-session of the clients, if in the gat o kern/154443 net [if_bridge] Kernel module bridgestp.ko missing after u o kern/154286 net [netgraph] [panic] 8.2-PRERELEASE panic in netgraph o kern/154255 net [nfs] NFS not responding o kern/154214 net [stf] [panic] Panic when creating stf interface o kern/154185 net race condition in mb_dupcl p kern/154169 net [multicast] [ip6] Node Information Query multicast add o kern/154134 net [ip6] stuck kernel state in LISTEN on ipv6 daemon whic o kern/154091 net [netgraph] [panic] netgraph, unaligned mbuf? o conf/154062 net [vlan] [patch] change to way of auto-generatation of v o kern/153937 net [ral] ralink panics the system (amd64 freeBSDD 8.X) wh o kern/153936 net [ixgbe] [patch] MPRC workaround incorrectly applied to o kern/153816 net [ixgbe] ixgbe doesn't work properly with the Intel 10g o kern/153772 net [ixgbe] [patch] sysctls reference wrong XON/XOFF varia o kern/153497 net [netgraph] netgraph panic due to race conditions o kern/153454 net [patch] [wlan] [urtw] Support ad-hoc and hostap modes o kern/153308 net [em] em interface use 100% cpu o kern/153244 net [em] em(4) fails to send UDP to port 0xffff o kern/152893 net [netgraph] [panic] 8.2-PRERELEASE panic in netgraph o kern/152853 net [em] tftpd (and likely other udp traffic) fails over e o kern/152828 net [em] poor performance on 8.1, 8.2-PRE o kern/152569 net [net]: Multiple ppp connections and routing table prob o kern/152235 net [arp] Permanent local ARP entries are not properly upd o kern/152141 net [vlan] [patch] encapsulate vlan in ng_ether before out o kern/152036 net [libc] getifaddrs(3) returns truncated sockaddrs for n o kern/151690 net [ep] network connectivity won't work until dhclient is o kern/151681 net [nfs] NFS mount via IPv6 leads to hang on client with o kern/151593 net [igb] [panic] Kernel panic when bringing up igb networ o kern/150920 net [ixgbe][igb] Panic when packets are dropped with heade o kern/150557 net [igb] igb0: Watchdog timeout -- resetting o kern/150251 net [patch] [ixgbe] Late cable insertion broken o kern/150249 net [ixgbe] Media type detection broken o bin/150224 net ppp(8) does not reassign static IP after kill -KILL co f kern/149969 net [wlan] [ral] ralink rt2661 fails to maintain connectio o kern/149643 net [rum] device not sending proper beacon frames in ap mo o kern/149609 net [panic] reboot after adding second default route o kern/149117 net [inet] [patch] in_pcbbind: redundant test o kern/149086 net [multicast] Generic multicast join failure in 8.1 o kern/148018 net [flowtable] flowtable crashes on ia64 o kern/147912 net [boot] FreeBSD 8 Beta won't boot on Thinkpad i1300 11 o kern/147894 net [ipsec] IPv6-in-IPv4 does not work inside an ESP-only o kern/147155 net [ip6] setfb not work with ipv6 o kern/146845 net [libc] close(2) returns error 54 (connection reset by f kern/146792 net [flowtable] flowcleaner 100% cpu's core load o kern/146719 net [pf] [panic] PF or dumynet kernel panic o kern/146534 net [icmp6] wrong source address in echo reply o kern/146427 net [mwl] Additional virtual access points don't work on m f kern/146394 net [vlan] IP source address for outgoing connections o bin/146377 net [ppp] [tun] Interface doesn't clear addresses when PPP o kern/146358 net [vlan] wrong destination MAC address o kern/146165 net [wlan] [panic] Setting bssid in adhoc mode causes pani o kern/146082 net [ng_l2tp] a false invaliant check was performed in ng_ o kern/146037 net [panic] mpd + CoA = kernel panic o kern/145825 net [panic] panic: soabort: so_count o kern/145728 net [lagg] Stops working lagg between two servers. p kern/145600 net TCP/ECN behaves different to CE/CWR than ns2 reference f kern/144917 net [flowtable] [panic] flowtable crashes system [regressi o kern/144882 net MacBookPro =>4.1 does not connect to BSD in hostap wit o kern/144874 net [if_bridge] [patch] if_bridge frees mbuf after pfil ho o conf/144700 net [rc.d] async dhclient breaks stuff for too many people o kern/144616 net [nat] [panic] ip_nat panic FreeBSD 7.2 f kern/144315 net [ipfw] [panic] freebsd 8-stable reboot after add ipfw o kern/144231 net bind/connect/sendto too strict about sockaddr length o kern/143846 net [gif] bringing gif3 tunnel down causes gif0 tunnel to s kern/143673 net [stf] [request] there should be a way to support multi s kern/143666 net [ip6] [request] PMTU black hole detection not implemen o kern/143622 net [pfil] [patch] unlock pfil lock while calling firewall o kern/143593 net [ipsec] When using IPSec, tcpdump doesn't show outgoin o kern/143591 net [ral] RT2561C-based DLink card (DWL-510) fails to work o kern/143208 net [ipsec] [gif] IPSec over gif interface not working o kern/143034 net [panic] system reboots itself in tcp code [regression] o kern/142877 net [hang] network-related repeatable 8.0-STABLE hard hang o kern/142774 net Problem with outgoing connections on interface with mu o kern/142772 net [libc] lla_lookup: new lle malloc failed f kern/142518 net [em] [lagg] Problem on 8.0-STABLE with em and lagg o kern/142018 net [iwi] [patch] Possibly wrong interpretation of beacon- o kern/141861 net [wi] data garbled with WEP and wi(4) with Prism 2.5 f kern/141741 net Etherlink III NIC won't work after upgrade to FBSD 8, o kern/140742 net rum(4) Two asus-WL167G adapters cannot talk to each ot o kern/140682 net [netgraph] [panic] random panic in netgraph f kern/140634 net [vlan] destroying if_lagg interface with if_vlan membe o kern/140619 net [ifnet] [patch] refine obsolete if_var.h comments desc o kern/140346 net [wlan] High bandwidth use causes loss of wlan connecti o kern/140142 net [ip6] [panic] FreeBSD 7.2-amd64 panic w/IPv6 o kern/140066 net [bwi] install report for 8.0 RC 2 (multiple problems) o kern/139387 net [ipsec] Wrong lenth of PF_KEY messages in promiscuous o bin/139346 net [patch] arp(8) add option to remove static entries lis o kern/139268 net [if_bridge] [patch] allow if_bridge to forward just VL p kern/139204 net [arp] DHCP server replies rejected, ARP entry lost bef o kern/139117 net [lagg] + wlan boot timing (EBUSY) o kern/138850 net [dummynet] dummynet doesn't work correctly on a bridge o kern/138782 net [panic] sbflush_internal: cc 0 || mb 0xffffff004127b00 o kern/138688 net [rum] possibly broken on 8 Beta 4 amd64: able to wpa a o kern/138678 net [lo] FreeBSD does not assign linklocal address to loop o kern/138407 net [gre] gre(4) interface does not come up after reboot o kern/138332 net [tun] [lor] ifconfig tun0 destroy causes LOR if_adata/ o kern/138266 net [panic] kernel panic when udp benchmark test used as r f kern/138029 net [bpf] [panic] periodically kernel panic and reboot o kern/137881 net [netgraph] [panic] ng_pppoe fatal trap 12 p bin/137841 net [patch] wpa_supplicant(8) cannot verify SHA256 signed p kern/137776 net [rum] panic in rum(4) driver on 8.0-BETA2 o bin/137641 net ifconfig(8): various problems with "vlan_device.vlan_i o kern/137392 net [ip] [panic] crash in ip_nat.c line 2577 o kern/137372 net [ral] FreeBSD doesn't support wireless interface from o kern/137089 net [lagg] lagg falsely triggers IPv6 duplicate address de o kern/136911 net [netgraph] [panic] system panic on kldload ng_bpf.ko t o kern/136618 net [pf][stf] panic on cloning interface without unit numb o kern/135502 net [periodic] Warning message raised by rtfree function i o kern/134583 net [hang] Machine with jail freezes after random amount o o kern/134531 net [route] [panic] kernel crash related to routes/zebra o kern/134157 net [dummynet] dummynet loads cpu for 100% and make a syst o kern/133969 net [dummynet] [panic] Fatal trap 12: page fault while in o kern/133968 net [dummynet] [panic] dummynet kernel panic o kern/133736 net [udp] ip_id not protected ... o kern/133595 net [panic] Kernel Panic at pcpu.h:195 o kern/133572 net [ppp] [hang] incoming PPTP connection hangs the system o kern/133490 net [bpf] [panic] 'kmem_map too small' panic on Dell r900 o kern/133235 net [netinet] [patch] Process SIOCDLIFADDR command incorre f kern/133213 net arp and sshd errors on 7.1-PRERELEASE o kern/133060 net [ipsec] [pfsync] [panic] Kernel panic with ipsec + pfs o kern/132889 net [ndis] [panic] NDIS kernel crash on load BCM4321 AGN d o conf/132851 net [patch] rc.conf(5): allow to setfib(1) for service run o kern/132734 net [ifmib] [panic] panic in net/if_mib.c o kern/132705 net [libwrap] [patch] libwrap - infinite loop if hosts.all o kern/132672 net [ndis] [panic] ndis with rt2860.sys causes kernel pani o kern/132354 net [nat] Getting some packages to ipnat(8) causes crash o kern/132277 net [crypto] [ipsec] poor performance using cryptodevice f o kern/131781 net [ndis] ndis keeps dropping the link o kern/131776 net [wi] driver fails to init o kern/131753 net [altq] [panic] kernel panic in hfsc_dequeue o bin/131365 net route(8): route add changes interpretation of network f kern/130820 net [ndis] wpa_supplicant(8) returns 'no space on device' o kern/130628 net [nfs] NFS / rpc.lockd deadlock on 7.1-R o kern/130525 net [ndis] [panic] 64 bit ar5008 ndisgen-erated driver cau o kern/130311 net [wlan_xauth] [panic] hostapd restart causing kernel pa o kern/130109 net [ipfw] Can not set fib for packets originated from loc f kern/130059 net [panic] Leaking 50k mbufs/hour f kern/129719 net [nfs] [panic] Panic during shutdown, tcp_ctloutput: in o kern/129517 net [ipsec] [panic] double fault / stack overflow f kern/129508 net [carp] [panic] Kernel panic with EtherIP (may be relat o kern/129219 net [ppp] Kernel panic when using kernel mode ppp o kern/129197 net [panic] 7.0 IP stack related panic o bin/128954 net ifconfig(8) deletes valid routes o bin/128602 net [an] wpa_supplicant(8) crashes with an(4) o kern/128448 net [nfs] 6.4-RC1 Boot Fails if NFS Hostname cannot be res o bin/128295 net [patch] ifconfig(8) does not print TOE4 or TOE6 capabi o bin/128001 net wpa_supplicant(8), wlan(4), and wi(4) issues o kern/127826 net [iwi] iwi0 driver has reduced performance and connecti o kern/127815 net [gif] [patch] if_gif does not set vlan attributes from o kern/127724 net [rtalloc] rtfree: 0xc5a8f870 has 1 refs f bin/127719 net [arp] arp: Segmentation fault (core dumped) f kern/127528 net [icmp]: icmp socket receives icmp replies not owned by p kern/127360 net [socket] TOE socket options missing from sosetopt() o bin/127192 net routed(8) removes the secondary alias IP of interface f kern/127145 net [wi]: prism (wi) driver crash at bigger traffic o kern/126895 net [patch] [ral] Add antenna selection (marked as TBD) o kern/126874 net [vlan]: Zebra problem if ifconfig vlanX destroy o kern/126695 net rtfree messages and network disruption upon use of if_ o kern/126339 net [ipw] ipw driver drops the connection o kern/126075 net [inet] [patch] internet control accesses beyond end of o bin/125922 net [patch] Deadlock in arp(8) o kern/125920 net [arp] Kernel Routing Table loses Ethernet Link status o kern/125845 net [netinet] [patch] tcp_lro_rx() should make use of hard o kern/125258 net [socket] socket's SO_REUSEADDR option does not work o kern/125239 net [gre] kernel crash when using gre o kern/124341 net [ral] promiscuous mode for wireless device ral0 looses o kern/124225 net [ndis] [patch] ndis network driver sometimes loses net o kern/124160 net [libc] connect(2) function loops indefinitely o kern/124021 net [ip6] [panic] page fault in nd6_output() o kern/123968 net [rum] [panic] rum driver causes kernel panic with WPA. o kern/123892 net [tap] [patch] No buffer space available o kern/123890 net [ppp] [panic] crash & reboot on work with PPP low-spee o kern/123858 net [stf] [patch] stf not usable behind a NAT o kern/123758 net [panic] panic while restarting net/freenet6 o bin/123633 net ifconfig(8) doesn't set inet and ether address in one o kern/123559 net [iwi] iwi periodically disassociates/associates [regre o bin/123465 net [ip6] route(8): route add -inet6 -interfac o kern/123463 net [ipsec] [panic] repeatable crash related to ipsec-tool o conf/123330 net [nsswitch.conf] Enabling samba wins in nsswitch.conf c o kern/123160 net [ip] Panic and reboot at sysctl kern.polling.enable=0 o kern/122989 net [swi] [panic] 6.3 kernel panic in swi1: net o kern/122954 net [lagg] IPv6 EUI64 incorrectly chosen for lagg devices f kern/122780 net [lagg] tcpdump on lagg interface during high pps wedge o kern/122685 net It is not visible passing packets in tcpdump(1) o kern/122319 net [wi] imposible to enable ad-hoc demo mode with Orinoco o kern/122290 net [netgraph] [panic] Netgraph related "kmem_map too smal o kern/122252 net [ipmi] [bge] IPMI problem with BCM5704 (does not work o kern/122033 net [ral] [lor] Lock order reversal in ral0 at bootup ieee o bin/121895 net [patch] rtsol(8)/rtsold(8) doesn't handle managed netw s kern/121774 net [swi] [panic] 6.3 kernel panic in swi1: net o kern/121555 net [panic] Fatal trap 12: current process = 12 (swi1: net o kern/121534 net [ipl] [nat] FreeBSD Release 6.3 Kernel Trap 12: o kern/121443 net [gif] [lor] icmp6_input/nd6_lookup o kern/121437 net [vlan] Routing to layer-2 address does not work on VLA o bin/121359 net [patch] [security] ppp(8): fix local stack overflow in o kern/121257 net [tcp] TSO + natd -> slow outgoing tcp traffic o kern/121181 net [panic] Fatal trap 3: breakpoint instruction fault whi o kern/120966 net [rum] kernel panic with if_rum and WPA encryption o kern/120566 net [request]: ifconfig(8) make order of arguments more fr o kern/120304 net [netgraph] [patch] netgraph source assumes 32-bit time o kern/120266 net [udp] [panic] gnugk causes kernel panic when closing U o bin/120060 net routed(8) deletes link-level routes in the presence of o kern/119945 net [rum] [panic] rum device in hostap mode, cause kernel o kern/119791 net [nfs] UDP NFS mount of aliased IP addresses from a Sol o kern/119617 net [nfs] nfs error on wpa network when reseting/shutdown f kern/119516 net [ip6] [panic] _mtx_lock_sleep: recursed on non-recursi o kern/119432 net [arp] route add -host -iface causes arp e o kern/119225 net [wi] 7.0-RC1 no carrier with Prism 2.5 wifi card [regr o kern/118727 net [netgraph] [patch] [request] add new ng_pf module o kern/117423 net [vlan] Duplicate IP on different interfaces o bin/117339 net [patch] route(8): loading routing management commands o bin/116643 net [patch] [request] fstat(1): add INET/INET6 socket deta o kern/116185 net [iwi] if_iwi driver leads system to reboot o kern/115239 net [ipnat] panic with 'kmem_map too small' using ipnat o kern/115019 net [netgraph] ng_ether upper hook packet flow stops on ad o kern/115002 net [wi] if_wi timeout. failed allocation (busy bit). ifco o kern/114915 net [patch] [pcn] pcn (sys/pci/if_pcn.c) ethernet driver f o kern/113432 net [ucom] WARNING: attempt to net_add_domain(netgraph) af o kern/112722 net [ipsec] [udp] IP v4 udp fragmented packet reject o kern/112686 net [patm] patm driver freezes System (FreeBSD 6.2-p4) i38 o bin/112557 net [patch] ppp(8) lock file should not use symlink name o kern/112528 net [nfs] NFS over TCP under load hangs with "impossible p o kern/111537 net [inet6] [patch] ip6_input() treats mbuf cluster wrong o kern/111457 net [ral] ral(4) freeze o kern/110284 net [if_ethersubr] Invalid Assumption in SIOCSIFADDR in et o kern/110249 net [kernel] [regression] [patch] setsockopt() error regre o kern/109470 net [wi] Orinoco Classic Gold PC Card Can't Channel Hop o bin/108895 net pppd(8): PPPoE dead connections on 6.2 [regression] f kern/108197 net [panic] [gif] [ip6] if_delmulti reference counting pan o kern/107944 net [wi] [patch] Forget to unlock mutex-locks o conf/107035 net [patch] bridge(8): bridge interface given in rc.conf n o kern/106444 net [netgraph] [panic] Kernel Panic on Binding to an ip to o kern/106316 net [dummynet] dummynet with multipass ipfw drops packets o kern/105945 net Address can disappear from network interface s kern/105943 net Network stack may modify read-only mbuf chain copies o bin/105925 net problems with ifconfig(8) and vlan(4) [regression] o kern/104851 net [inet6] [patch] On link routes not configured when usi o kern/104751 net [netgraph] kernel panic, when getting info about my tr o kern/104738 net [inet] [patch] Reentrant problem with inet_ntoa in the o kern/103191 net Unpredictable reboot o kern/103135 net [ipsec] ipsec with ipfw divert (not NAT) encodes a pac o kern/102540 net [netgraph] [patch] supporting vlan(4) by ng_fec(4) o conf/102502 net [netgraph] [patch] ifconfig name does't rename netgrap o kern/102035 net [plip] plip networking disables parallel port printing o kern/100709 net [libc] getaddrinfo(3) should return TTL info o kern/100519 net [netisr] suggestion to fix suboptimal network polling o kern/98597 net [inet6] Bug in FreeBSD 6.1 IPv6 link-local DAD procedu o bin/98218 net wpa_supplicant(8) blacklist not working o kern/97306 net [netgraph] NG_L2TP locks after connection with failed o conf/97014 net [gif] gifconfig_gif? in rc.conf does not recognize IPv f kern/96268 net [socket] TCP socket performance drops by 3000% if pack o kern/95519 net [ral] ral0 could not map mbuf o kern/95288 net [pppd] [tty] [panic] if_ppp panic in sys/kern/tty_subr o kern/95277 net [netinet] [patch] IP Encapsulation mask_match() return o kern/95267 net packet drops periodically appear f kern/93378 net [tcp] Slow data transfer in Postfix and Cyrus IMAP (wo o kern/93019 net [ppp] ppp and tunX problems: no traffic after restarti o kern/92880 net [libc] [patch] almost rewritten inet_network(3) functi s kern/92279 net [dc] Core faults everytime I reboot, possible NIC issu o kern/91859 net [ndis] if_ndis does not work with Asus WL-138 o kern/91364 net [ral] [wep] WF-511 RT2500 Card PCI and WEP o kern/91311 net [aue] aue interface hanging o kern/87421 net [netgraph] [panic]: ng_ether + ng_eiface + if_bridge o kern/86871 net [tcp] [patch] allocation logic for PCBs in TIME_WAIT s o kern/86427 net [lor] Deadlock with FASTIPSEC and nat o kern/85780 net 'panic: bogus refcnt 0' in routing/ipv6 o bin/85445 net ifconfig(8): deprecated keyword to ifconfig inoperativ o bin/82975 net route change does not parse classfull network as given o kern/82881 net [netgraph] [panic] ng_fec(4) causes kernel panic after o kern/82468 net Using 64MB tcp send/recv buffers, trafficflow stops, i o bin/82185 net [patch] ndp(8) can delete the incorrect entry o kern/81095 net IPsec connection stops working if associated network i o kern/78968 net FreeBSD freezes on mbufs exhaustion (network interface o kern/78090 net [ipf] ipf filtering on bridged packets doesn't work if o kern/77341 net [ip6] problems with IPV6 implementation o kern/75873 net Usability problem with non-RFC-compliant IP spoof prot s kern/75407 net [an] an(4): no carrier after short time a kern/71474 net [route] route lookup does not skip interfaces marked d o kern/71469 net default route to internet magically disappears with mu o kern/68889 net [panic] m_copym, length > size of mbuf chain o kern/66225 net [netgraph] [patch] extend ng_eiface(4) control message o kern/65616 net IPSEC can't detunnel GRE packets after real ESP encryp s kern/60293 net [patch] FreeBSD arp poison patch a kern/56233 net IPsec tunnel (ESP) over IPv6: MTU computation is wrong s bin/41647 net ifconfig(8) doesn't accept lladdr along with inet addr o kern/39937 net ipstealth issue a kern/38554 net [patch] changing interface ipaddress doesn't seem to w o kern/31940 net ip queue length too short for >500kpps o kern/31647 net [libc] socket calls can return undocumented EINVAL o kern/30186 net [libc] getaddrinfo(3) does not handle incorrect servna f kern/24959 net [patch] proper TCP_NOPUSH/TCP_CORK compatibility o conf/23063 net [arp] [patch] for static ARP tables in rc.network o kern/21998 net [socket] [patch] ident only for outgoing connections o kern/5877 net [socket] sb_cc counts control data as well as data dat 471 problems total. From owner-freebsd-net@FreeBSD.ORG Mon Nov 18 16:42:00 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 61AA4D13; Mon, 18 Nov 2013 16:42:00 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C51C12606; Mon, 18 Nov 2013 16:41:58 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id rAIGfo8G062837 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 18 Nov 2013 20:41:50 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id rAIGfnsB062836; Mon, 18 Nov 2013 20:41:49 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 18 Nov 2013 20:41:49 +0400 From: Gleb Smirnoff To: Marcel Moolenaar Subject: Re: [JNPR] Network stack as a module (RFC) Message-ID: <20131118164149.GV7577@glebius.int.ru> References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131116084919.GF7577@glebius.int.ru> <1DAF9090-08DA-404B-B86B-57E5D124D70D@xcllnt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1DAF9090-08DA-404B-B86B-57E5D124D70D@xcllnt.net> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: luigi@freebsd.org, Marcel Moolenaar , Steve Kiernan , freebsd-net@freebsd.org, zec@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 16:42:00 -0000 Marcel, On Sun, Nov 17, 2013 at 10:10:15AM -0800, Marcel Moolenaar wrote: M> > S> Add a NETSTACK option to facilitate separating network stack pieces from the M> > S> rest of the OS core. This is the first step towards having the network stack M> > S> as a module. M> > M> > You probably mean "having the network stack optional", since under module we M> > usually mean loadable kernel module. M> M> Actually, we do mean module. At Juniper we have the FreeBSD stack M> as a loadable module now. We also have the Juniper stack as a M> loadable module. Depending on context, we can use the most M> appropriate one. Yes, this implies that we also have a stable M> interface between the NIC driver and the network stack itself. M> We'll be contributing that as well... M> M> Note that assumptions in the finalization of setting up networking M> limits the network stack from being loaded manually, not to mention M> that unloading is an entirely different challenge. Nonetheless it's M> very useful without all that and I think it will make it easier for M> people to change the network stack or experiment with beta versions M> this way. Have you measured the performance impact on the loadable stack? I suppose many functions, that are now called directly, with loadable stack will be called via functon pointers. M> It all really comes in handy for the opaque ifnet work... Actually I wanted to start it for a long time. But since at EuroBSDCon 2011 you said that you plan to import Junipers' transform of ifnet, I held off my intentions. Until now I was almost sure that plan on brining junipers ifnet was abandoned. -- Totus tuus, Glebius. From owner-freebsd-net@FreeBSD.ORG Mon Nov 18 17:56:39 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B08F34F9; Mon, 18 Nov 2013 17:56:39 +0000 (UTC) Received: from mail.xcllnt.net (mail.xcllnt.net [50.0.150.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8845C2B45; Mon, 18 Nov 2013 17:56:39 +0000 (UTC) Received: from marcelm-sslvpn-nc.jnpr.net ([66.129.239.13]) (authenticated bits=0) by mail.xcllnt.net (8.14.7/8.14.7) with ESMTP id rAIHuYxR014705 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 18 Nov 2013 09:56:36 -0800 (PST) (envelope-from marcel@xcllnt.net) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: [JNPR] Network stack as a module (RFC) From: Marcel Moolenaar In-Reply-To: <20131118164149.GV7577@glebius.int.ru> Date: Mon, 18 Nov 2013 09:56:28 -0800 Content-Transfer-Encoding: 7bit Message-Id: <5D6C46A7-4C36-4477-B088-E6011E1C4405@xcllnt.net> References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131116084919.GF7577@glebius.int.ru> <1DAF9090-08DA-404B-B86B-57E5D124D70D@xcllnt.net> <20131118164149.GV7577@glebius.int.ru> To: Gleb Smirnoff X-Mailer: Apple Mail (2.1822) Cc: luigi@freebsd.org, Marcel Moolenaar , Steve Kiernan , freebsd-net@freebsd.org, zec@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 17:56:39 -0000 On Nov 18, 2013, at 8:41 AM, Gleb Smirnoff wrote: > > Have you measured the performance impact on the loadable stack? I > suppose many functions, that are now called directly, with loadable > stack will be called via functon pointers. No impact. Building the stack as a module doesn't actually change any function calls. > M> It all really comes in handy for the opaque ifnet work... > > Actually I wanted to start it for a long time. But since at > EuroBSDCon 2011 you said that you plan to import Junipers' > transform of ifnet, I held off my intentions. Until now I > was almost sure that plan on brining junipers ifnet was > abandoned. I think there's been a communication problem. I'll talk to you and Andre offline... -- Marcel Moolenaar marcel@xcllnt.net From owner-freebsd-net@FreeBSD.ORG Mon Nov 18 19:20:40 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 68131A80; Mon, 18 Nov 2013 19:20:40 +0000 (UTC) Received: from tx2outboundpool.messaging.microsoft.com (tx2ehsobe003.messaging.microsoft.com [65.55.88.13]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2B7A420E6; Mon, 18 Nov 2013 19:20:39 +0000 (UTC) Received: from mail85-tx2-R.bigfish.com (10.9.14.238) by TX2EHSOBE002.bigfish.com (10.9.40.22) with Microsoft SMTP Server id 14.1.225.22; Mon, 18 Nov 2013 19:20:32 +0000 Received: from mail85-tx2 (localhost [127.0.0.1]) by mail85-tx2-R.bigfish.com (Postfix) with ESMTP id 00FEB1E063C; Mon, 18 Nov 2013 19:20:33 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.239.16; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: -2 X-BigFish: VPS-2(zz98dI1432Izz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h1d1ah1d2ah1fc6hzz8275ch1de098h8275dh1de097hz31h2a8h839h944hd24hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1e23h1fe8h1ff5h2218h2216h1155h) Received-SPF: softfail (mail85-tx2: transitioning domain of juniper.net does not designate 66.129.239.16 as permitted sender) client-ip=66.129.239.16; envelope-from=stevek@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail85-tx2 (localhost.localdomain [127.0.0.1]) by mail85-tx2 (MessageSwitch) id 1384802431841765_29787; Mon, 18 Nov 2013 19:20:31 +0000 (UTC) Received: from TX2EHSMHS007.bigfish.com (unknown [10.9.14.232]) by mail85-tx2.bigfish.com (Postfix) with ESMTP id C809B46005A; Mon, 18 Nov 2013 19:20:31 +0000 (UTC) Received: from P-EMF02-SAC.jnpr.net (66.129.239.16) by TX2EHSMHS007.bigfish.com (10.9.99.107) with Microsoft SMTP Server (TLS) id 14.16.227.3; Mon, 18 Nov 2013 19:20:30 +0000 Received: from stevek-ubuntu (172.25.4.212) by P-EMF02-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server id 14.3.146.0; Mon, 18 Nov 2013 11:20:29 -0800 Date: Mon, 18 Nov 2013 14:20:26 -0500 From: Steve Kiernan To: Adrian Chadd Subject: Re: [JNPR] Network stack as a module (RFC) Message-ID: <20131118142026.500fcba5@stevek-ubuntu> In-Reply-To: References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> Organization: Juniper Networks Inc. X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: FreeBSD Net , Luigi Rizzo , Marcel Moolenaar , zec@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 19:20:40 -0000 On Fri, 15 Nov 2013 18:03:07 -0800 Adrian Chadd wrote: > Hi, > > We can't commit it with 'netstack' against all of the drivers. > > I think the default should be "assume freebsd's networking stack" and > if someone disables that option, the drivers just won't link. Thus, > someone compiling FreeBSD without netstack shouldn't be compiling > GENERIC - they would be compiling a custom kernel with their own > device stuff. Sure, that's fine with me. I had been considering back and forth about whether or not to add NETSTACK to the NIC drivers and the like. I went with adding it in for completeness sake, but I'm good with not having to add it for drivers. -- Stephen J. Kiernan Juniper Networks, Inc. stevek_at_juniper.net From owner-freebsd-net@FreeBSD.ORG Mon Nov 18 19:26:32 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2AEC039A; Mon, 18 Nov 2013 19:26:32 +0000 (UTC) Received: from am1outboundpool.messaging.microsoft.com (am1ehsobe005.messaging.microsoft.com [213.199.154.208]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B007421B0; Mon, 18 Nov 2013 19:26:31 +0000 (UTC) Received: from mail61-am1-R.bigfish.com (10.3.201.231) by AM1EHSOBE023.bigfish.com (10.3.207.145) with Microsoft SMTP Server id 14.1.225.22; Mon, 18 Nov 2013 19:26:24 +0000 Received: from mail61-am1 (localhost [127.0.0.1]) by mail61-am1-R.bigfish.com (Postfix) with ESMTP id 09F034A0077; Mon, 18 Nov 2013 19:26:24 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.239.16; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: -5 X-BigFish: VPS-5(zzdb82h98dI9371I1432I168aJzz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h1d1ah1d2ah1fc6hzz8275ch1de098h17326ah8275bh8275dh1de097h186068hz31h2a8h839h944hd24hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1e23h1fe8h1ff5h2218h2216h1155h) Received-SPF: softfail (mail61-am1: transitioning domain of juniper.net does not designate 66.129.239.16 as permitted sender) client-ip=66.129.239.16; envelope-from=stevek@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail61-am1 (localhost.localdomain [127.0.0.1]) by mail61-am1 (MessageSwitch) id 1384802781858872_8170; Mon, 18 Nov 2013 19:26:21 +0000 (UTC) Received: from AM1EHSMHS004.bigfish.com (unknown [10.3.201.244]) by mail61-am1.bigfish.com (Postfix) with ESMTP id CD03040006E; Mon, 18 Nov 2013 19:26:21 +0000 (UTC) Received: from P-EMF02-SAC.jnpr.net (66.129.239.16) by AM1EHSMHS004.bigfish.com (10.3.207.104) with Microsoft SMTP Server (TLS) id 14.16.227.3; Mon, 18 Nov 2013 19:26:21 +0000 Received: from stevek-ubuntu (172.25.4.212) by P-EMF02-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server id 14.3.146.0; Mon, 18 Nov 2013 11:26:19 -0800 Date: Mon, 18 Nov 2013 14:26:16 -0500 From: Steve Kiernan To: Eitan Adler Subject: Re: [JNPR] Network stack as a module (RFC) Message-ID: <20131118142616.354526ae@stevek-ubuntu> In-Reply-To: References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> Organization: Juniper Networks Inc. X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: "freebsd-net@freebsd.org" , luigi@freebsd.org, Marcel Moolenaar , zec@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 19:26:32 -0000 On Sat, 16 Nov 2013 21:41:26 -0500 Eitan Adler wrote: > On Fri, Nov 15, 2013 at 4:52 PM, Steve Kiernan wrote: > > This is a follow up to the request sent back in January titled "Proposal for changes to network device drivers and network stack". > > > > In order to make it easier to review, we will be submitting pieces to be contributed in logical blocks. > > > > Please review the following patch and provide feedback: > > http://people.freebsd.org/~marcel/Juniper/201311/netstack-option.diff > > There are a few empty #ifdef blocks: such as in sys/compat/svr4/svr4_proto.h > > > +#ifdef NETSTACK > +#else > +#endif > +#ifdef NETSTACK > +#else > +#endif > +#ifdef NETSTACK > +#else > +#endif > +#ifdef NETSTACK > +#else > +#endif > > Do we need these? These are artifacts of running "make sysent" in the sys/compat/svr4 directory. Since the file says "DO NOT EDIT", I left those additions alone. -- Stephen J. Kiernan Juniper Networks, Inc. stevek_at_juniper.net From owner-freebsd-net@FreeBSD.ORG Mon Nov 18 19:35:22 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EEFE0B1E; Mon, 18 Nov 2013 19:35:21 +0000 (UTC) Received: from db8outboundpool.messaging.microsoft.com (mail-db8lp0184.outbound.messaging.microsoft.com [213.199.154.184]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5C1D6224E; Mon, 18 Nov 2013 19:35:20 +0000 (UTC) Received: from mail58-db8-R.bigfish.com (10.174.8.253) by DB8EHSOBE002.bigfish.com (10.174.4.65) with Microsoft SMTP Server id 14.1.225.22; Mon, 18 Nov 2013 19:35:18 +0000 Received: from mail58-db8 (localhost [127.0.0.1]) by mail58-db8-R.bigfish.com (Postfix) with ESMTP id D0DB2DA094A; Mon, 18 Nov 2013 19:35:18 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.239.11; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: -2 X-BigFish: VPS-2(zz98dI1432Izz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h1d1ah1d2ah1fc6hzz8275ch1de098h17326ah8275dh1de097h186068hz31h2a8h839h944hd24hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1e23h1fe8h1ff5h2218h2216h1155h) Received-SPF: softfail (mail58-db8: transitioning domain of juniper.net does not designate 66.129.239.11 as permitted sender) client-ip=66.129.239.11; envelope-from=stevek@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail58-db8 (localhost.localdomain [127.0.0.1]) by mail58-db8 (MessageSwitch) id 1384803316669903_20514; Mon, 18 Nov 2013 19:35:16 +0000 (UTC) Received: from DB8EHSMHS032.bigfish.com (unknown [10.174.8.225]) by mail58-db8.bigfish.com (Postfix) with ESMTP id 9EA30480055; Mon, 18 Nov 2013 19:35:16 +0000 (UTC) Received: from P-EMF02-SAC.jnpr.net (66.129.239.11) by DB8EHSMHS032.bigfish.com (10.174.4.42) with Microsoft SMTP Server (TLS) id 14.16.227.3; Mon, 18 Nov 2013 19:35:14 +0000 Received: from stevek-ubuntu (172.25.4.212) by P-EMF02-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server id 14.3.146.0; Mon, 18 Nov 2013 11:35:12 -0800 Date: Mon, 18 Nov 2013 14:35:08 -0500 From: Steve Kiernan To: Gleb Smirnoff Subject: Re: [JNPR] Network stack as a module (RFC) Message-ID: <20131118143508.0253e663@stevek-ubuntu> In-Reply-To: <20131118164149.GV7577@glebius.int.ru> References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131116084919.GF7577@glebius.int.ru> <1DAF9090-08DA-404B-B86B-57E5D124D70D@xcllnt.net> <20131118164149.GV7577@glebius.int.ru> Organization: Juniper Networks Inc. X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: freebsd-net@freebsd.org, luigi@freebsd.org, Marcel Moolenaar , zec@freebsd.org, Marcel Moolenaar X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 19:35:22 -0000 On Mon, 18 Nov 2013 20:41:49 +0400 Gleb Smirnoff wrote: > Marcel, > > On Sun, Nov 17, 2013 at 10:10:15AM -0800, Marcel Moolenaar wrote: > M> > S> Add a NETSTACK option to facilitate separating network stack pieces from the > M> > S> rest of the OS core. This is the first step towards having the network stack > M> > S> as a module. > M> > > M> > You probably mean "having the network stack optional", since under module we > M> > usually mean loadable kernel module. > M> > M> Actually, we do mean module. At Juniper we have the FreeBSD stack > M> as a loadable module now. We also have the Juniper stack as a > M> loadable module. Depending on context, we can use the most > M> appropriate one. Yes, this implies that we also have a stable > M> interface between the NIC driver and the network stack itself. > M> We'll be contributing that as well... > M> > M> Note that assumptions in the finalization of setting up networking > M> limits the network stack from being loaded manually, not to mention > M> that unloading is an entirely different challenge. Nonetheless it's > M> very useful without all that and I think it will make it easier for > M> people to change the network stack or experiment with beta versions > M> this way. > > Have you measured the performance impact on the loadable stack? I > suppose many functions, that are now called directly, with loadable > stack will be called via functon pointers. No, only a small number of functions were needed to be methods in a netstack kobj in the current implementation that we have. And some of those may need to change, as they revolve around NFS exports. Currently, we have four (4) methods that are needed: socreate vfs_export vfs_setpublicfs vfs_stdcheckexp When one is not dealing with NFS exports, only the socreate method is of interest. It is called just before mac_socket_create() would be called in socreate(). See http://people.freebsd.org/~marcel/Juniper/netstack-v2.diff, which is the full patch set that had been previously sent out. Some things have changed a bit since then, but if you look for curnetstack usage in the patch, you should be able to see the places where netsack methods are called. -- Stephen J. Kiernan Juniper Networks, Inc. stevek_at_juniper.net From owner-freebsd-net@FreeBSD.ORG Mon Nov 18 20:23:42 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6D8BDF31; Mon, 18 Nov 2013 20:23:42 +0000 (UTC) Received: from mail-qe0-x229.google.com (mail-qe0-x229.google.com [IPv6:2607:f8b0:400d:c02::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EFE692528; Mon, 18 Nov 2013 20:23:41 +0000 (UTC) Received: by mail-qe0-f41.google.com with SMTP id x7so4504521qeu.28 for ; Mon, 18 Nov 2013 12:23:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=rYXuYHGQNDat6kksVGlEOj5NPU/llx7gSkBb5ZyCTA0=; b=Rk/WVOtgIB8pjngAAI+tkjQSvIQOIDTR0f1gE28BfUuKKgC/8StNQEvZj0SsjUAAvN ZeKtRgv+jDLIk0RpbYO6hzkCdMQyhHwfM57+gs9qiWCmxHnIHpapZR8+sv8HP9VdpBUV nM8Xpr3tK52AQokJGuPP0/8AY7ZsBCAdHwzPN/AYF3Pl5Q9qL0Bsh64HlfH2oUC1uR0j +JfFvXlahMIyfnXJgVNR+olPbDi01xjoj9/1kyLc5hOhkfUeY5wBMYDXHKamTvoAK1Go ZKGRjgLWWtLHuoFarkvstp+oL3ynHqHf9IU4C4osycyVt1s7isHk36aOgB+w+pwZn0Jr hJfA== MIME-Version: 1.0 X-Received: by 10.49.71.207 with SMTP id x15mr37253280qeu.49.1384806221182; Mon, 18 Nov 2013 12:23:41 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.224.207.66 with HTTP; Mon, 18 Nov 2013 12:23:41 -0800 (PST) In-Reply-To: <20131118142026.500fcba5@stevek-ubuntu> References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131118142026.500fcba5@stevek-ubuntu> Date: Mon, 18 Nov 2013 12:23:41 -0800 X-Google-Sender-Auth: WIh9gecfJwTJMRdNrjtlSCcnFAM Message-ID: Subject: Re: [JNPR] Network stack as a module (RFC) From: Adrian Chadd To: Steve Kiernan Content-Type: text/plain; charset=ISO-8859-1 Cc: FreeBSD Net , Luigi Rizzo , Marcel Moolenaar , zec@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 20:23:42 -0000 On 18 November 2013 11:20, Steve Kiernan wrote: > > Sure, that's fine with me. I had been considering back and forth about > whether or not to add NETSTACK to the NIC drivers and the like. > I went with adding it in for completeness sake, but I'm good with not > having to add it for drivers. ok. let's do that. So ideally (!), the aim is to make it so it's both selectable as buildable _and_ loadable as a module, right? The drivers will ideally treat the if/ifnet stuff as opaque as possible and use methods/macros to access things. (if they use methods, then we can turn some of them into macros for source builds, but have an option to turn them into actual methods that can be indirected easily enough for what you need.) How's that sound? -adrian From owner-freebsd-net@FreeBSD.ORG Mon Nov 18 22:01:56 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6BD113A8; Mon, 18 Nov 2013 22:01:56 +0000 (UTC) Received: from am1outboundpool.messaging.microsoft.com (am1ehsobe003.messaging.microsoft.com [213.199.154.206]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CA2AB2A39; Mon, 18 Nov 2013 22:01:55 +0000 (UTC) Received: from mail6-am1-R.bigfish.com (10.3.201.240) by AM1EHSOBE025.bigfish.com (10.3.207.147) with Microsoft SMTP Server id 14.1.225.22; Mon, 18 Nov 2013 21:46:37 +0000 Received: from mail6-am1 (localhost [127.0.0.1]) by mail6-am1-R.bigfish.com (Postfix) with ESMTP id E9B313000D3; Mon, 18 Nov 2013 21:46:36 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.239.16; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: -2 X-BigFish: VPS-2(zz98dI1432Izz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h1d1ah1d2ah1fc6hzz8275ch1de098h8275dh1de097hz31h2a8h839h944hd24hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1e23h1fe8h1ff5h2218h2216h1155h) Received-SPF: softfail (mail6-am1: transitioning domain of juniper.net does not designate 66.129.239.16 as permitted sender) client-ip=66.129.239.16; envelope-from=stevek@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail6-am1 (localhost.localdomain [127.0.0.1]) by mail6-am1 (MessageSwitch) id 1384811195528612_2200; Mon, 18 Nov 2013 21:46:35 +0000 (UTC) Received: from AM1EHSMHS001.bigfish.com (unknown [10.3.201.227]) by mail6-am1.bigfish.com (Postfix) with ESMTP id 7CC2632008E; Mon, 18 Nov 2013 21:46:35 +0000 (UTC) Received: from P-EMF02-SAC.jnpr.net (66.129.239.16) by AM1EHSMHS001.bigfish.com (10.3.207.101) with Microsoft SMTP Server (TLS) id 14.16.227.3; Mon, 18 Nov 2013 21:46:34 +0000 Received: from stevek-ubuntu (172.25.4.212) by P-EMF02-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server id 14.3.146.0; Mon, 18 Nov 2013 13:46:32 -0800 Date: Mon, 18 Nov 2013 16:46:28 -0500 From: Steve Kiernan To: Adrian Chadd Subject: Re: [JNPR] Network stack as a module (RFC) Message-ID: <20131118164628.49b6d807@stevek-ubuntu> In-Reply-To: References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131118142026.500fcba5@stevek-ubuntu> Organization: Juniper Networks Inc. X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: FreeBSD Net , Luigi Rizzo , Marcel Moolenaar , zec@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 22:01:56 -0000 On Mon, 18 Nov 2013 12:23:41 -0800 Adrian Chadd wrote: > On 18 November 2013 11:20, Steve Kiernan wrote: > > > > > Sure, that's fine with me. I had been considering back and forth about > > whether or not to add NETSTACK to the NIC drivers and the like. > > I went with adding it in for completeness sake, but I'm good with not > > having to add it for drivers. > > ok. let's do that. > > So ideally (!), the aim is to make it so it's both selectable as > buildable _and_ loadable as a module, right? > > The drivers will ideally treat the if/ifnet stuff as opaque as > possible and use methods/macros to access things. > > (if they use methods, then we can turn some of them into macros for > source builds, but have an option to turn them into actual methods > that can be indirected easily enough for what you need.) > > How's that sound? Sounds like a good plan to me. -- Stephen J. Kiernan Juniper Networks, Inc. stevek_at_juniper.net From owner-freebsd-net@FreeBSD.ORG Mon Nov 18 23:50:01 2013 Return-Path: Delivered-To: freebsd-net@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B5B72FA3 for ; Mon, 18 Nov 2013 23:50:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8AC91233B for ; Mon, 18 Nov 2013 23:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAINo0tP022760 for ; Mon, 18 Nov 2013 23:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAINo0lA022759; Mon, 18 Nov 2013 23:50:00 GMT (envelope-from gnats) Date: Mon, 18 Nov 2013 23:50:00 GMT Message-Id: <201311182350.rAINo0lA022759@freefall.freebsd.org> To: freebsd-net@FreeBSD.org Cc: From: Andrew Kinney Subject: Re: kern/183732: [igb] igb interface output byte counter double real output bytes on 8.4-RELEASE generic kernel X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: Andrew Kinney List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 23:50:01 -0000 The following reply was made to PR kern/183732; it has been noted by GNATS. From: Andrew Kinney To: bug-followup@FreeBSD.org, andykinney@advantagecom.net Cc: Subject: Re: kern/183732: [igb] igb interface output byte counter double real output bytes on 8.4-RELEASE generic kernel Date: Mon, 18 Nov 2013 15:21:36 -0800 The other bug was against 8.4-stable, which receive no action and no work because it isn't RELEASE. This PR is against 8.4-RELEASE. It may seem like I'm splitting hairs to say this isn't duplicate, but read the follow-ups on the other bug. Nobody cares because that one is not against a released version. That's why I submitted the PR against a released version that someone somewhere is supposed to care about. If feel you have to close a bug, I think I've made a clear argument for you to re-open this PR and close the other one. 8.4-RELEASE is a supported release. You stating I should jump on 9.2 (and a completely new set of unknown problems for a production machine) completely neglects the fact that 8.4-RELEASE is supported and this should get attention. This bug needs to get fixed. While it doesn't cause crashes for prevent booting, it does cause problems for billing our clients. We use the byte counters for billing and costing. If it were always exactly double the real bytes, we could deal with it, but it's not. Sometimes the delta in bytes drops to about 1/10th the real traffic for periods of 15 to 30 minutes at a time. So, it's anyone's guess what the real byte count should have been. Good luck ever convincing a customer with a large overage that they should trust your numbers after they see this. If public policy for the FreeBSD project has changed and you only want to support one release, then make that policy change public. Don't dance around excusing bugs for supposedly supported releases because I'm wrong for having chosen something other than the latest version. Sincerely, Andrew Kinney President / CTO Advantagecom Networks, Inc. From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 11:45:34 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 52C76E9B; Tue, 19 Nov 2013 11:45:34 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CD9682A01; Tue, 19 Nov 2013 11:45:33 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id rAJBjVrq068086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 19 Nov 2013 15:45:31 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id rAJBjVAx068085; Tue, 19 Nov 2013 15:45:31 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 19 Nov 2013 15:45:31 +0400 From: Gleb Smirnoff To: Steve Kiernan Subject: Re: [JNPR] Network stack as a module (RFC) Message-ID: <20131119114531.GF7577@glebius.int.ru> References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131116084919.GF7577@glebius.int.ru> <1DAF9090-08DA-404B-B86B-57E5D124D70D@xcllnt.net> <20131118164149.GV7577@glebius.int.ru> <20131118143508.0253e663@stevek-ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131118143508.0253e663@stevek-ubuntu> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: freebsd-net@freebsd.org, luigi@freebsd.org, Marcel Moolenaar , zec@freebsd.org, Marcel Moolenaar X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 11:45:34 -0000 Steve, On Mon, Nov 18, 2013 at 02:35:08PM -0500, Steve Kiernan wrote: S> > Have you measured the performance impact on the loadable stack? I S> > suppose many functions, that are now called directly, with loadable S> > stack will be called via functon pointers. S> S> No, only a small number of functions were needed to be methods in a S> netstack kobj in the current implementation that we have. And some of S> those may need to change, as they revolve around NFS exports. S> S> Currently, we have four (4) methods that are needed: S> socreate S> vfs_export S> vfs_setpublicfs S> vfs_stdcheckexp S> S> When one is not dealing with NFS exports, only the socreate method is S> of interest. It is called just before mac_socket_create() would be S> called in socreate(). Sounds okay. Thank you. S> See http://people.freebsd.org/~marcel/Juniper/netstack-v2.diff, which S> is the full patch set that had been previously sent out. Some things S> have changed a bit since then, but if you look for curnetstack usage S> in the patch, you should be able to see the places where netsack S> methods are called. The patch is quite huge to understand it as a whole. :) -- Totus tuus, Glebius. From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 14:09:18 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B60025D5; Tue, 19 Nov 2013 14:09:18 +0000 (UTC) Received: from mail-pb0-x22f.google.com (mail-pb0-x22f.google.com [IPv6:2607:f8b0:400e:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8F68E226C; Tue, 19 Nov 2013 14:09:18 +0000 (UTC) Received: by mail-pb0-f47.google.com with SMTP id um1so1940177pbc.34 for ; Tue, 19 Nov 2013 06:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=BRWplGjbBCovCpkr4bRKMjGG+DFRxYMnzT83L2EG0Bs=; b=jlohamBT2KmnMuSbTEhGIxCrczOrUjlNjTrFk8ZXPZP1gKPBD+1+NPoMdm1ydgDuds qcaY8wdmHWrrO/zxa/iICF8STyvXGSQQBW1ZI+a+fzGQ/SF+zSxwldaHKTu0lvbUM5lN u3sUz3EVCSayOfHYLVe8Oy8mgoQqepewO/GMfwZIT5hXI1X8YWbzNdd9K8pWJXE6AOTz 1NuoUI7TuBINgJYh7pyeHPragWnN/vUWpP9w/Jji6dJ9+lrnTguhdITEHjR2KvSuovFy HGqgjhXXJVmZOiKm53YPttTNSs/YsrIxUCEdhas47xQVHrbxHeR/K52vNqvT5wJx/5UJ puNw== MIME-Version: 1.0 X-Received: by 10.69.25.38 with SMTP id in6mr1133048pbd.178.1384870158201; Tue, 19 Nov 2013 06:09:18 -0800 (PST) Sender: tomek.cedro@gmail.com Received: by 10.68.191.6 with HTTP; Tue, 19 Nov 2013 06:09:18 -0800 (PST) Date: Tue, 19 Nov 2013 15:09:18 +0100 X-Google-Sender-Auth: 1W3tYkKxe7Z-I6rKzCxzJdxVb28 Message-ID: Subject: bug in dhclient / dhclient.conf / dhcp-options parser? From: CeDeROM To: FreeBSD Questions Mailing List , freebsd-net@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 14:09:18 -0000 Hello :-) I need to send additional options with dhcp request, so I add "send" option for an interface in /etc/dhclient.conf, however options are non-standard and they use option value below 100 and they are not sent in dhcp request. I have noticed that other options with names known to dhcp-options and decimal numbers above 100 are sent correctly, so maybe there is an error in the options number parser, or I do something wrong? Here is my example /etc/dhclient.conf configuation: interface "em0"{ send option-060 "vendor"; <-- does not go out in dhcp request send option-077 "user"; <-- does not go out in dhcp request send option-123 "blah123"; <-- goes out in dhcp request send root-path "blahroot"; <-- goes out in dhcp request } Please advise, quick solution appreciated :-) Tomek -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 14:15:21 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 89EB5762; Tue, 19 Nov 2013 14:15:21 +0000 (UTC) Received: from mail-pd0-x229.google.com (mail-pd0-x229.google.com [IPv6:2607:f8b0:400e:c02::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 62AF722ED; Tue, 19 Nov 2013 14:15:21 +0000 (UTC) Received: by mail-pd0-f169.google.com with SMTP id v10so2578301pde.14 for ; Tue, 19 Nov 2013 06:15:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=6hI2I8u0/wggAJxOiJt05gjQLDZZk0rzVjJhmkgbQVk=; b=YMu8sXL769J4TkXC+bnRjpRSUBE8N9la+lTu8TRNGuZ0rCNY1X2Dr7CD5DFPMc3Kj/ S/lJvVjNfstwv+c9ZJDN6CLlrqxb89zTMgo9u86aE5/aAwe28T/ZxQ5DRAxnbY7LxAU3 PjCY16xzKLg+EtOqZYMrsEqtHVrhn1+/q8lRlyYR9QFImVNuh4ipOOL+YHEfx/nU8mt/ ZgwR9GKbsfwNxy9BKe5XyE/XA634EFGyYdd5vtcLTw5N34lPu17rwpej/KTWARTzrfmt he0DpV22S9fAaJ7n19syb7xgKRpfKZu50YUbfIph3nifkhFOE91mGwR7q7out9v7285E wcWw== MIME-Version: 1.0 X-Received: by 10.68.189.133 with SMTP id gi5mr26548352pbc.57.1384870520959; Tue, 19 Nov 2013 06:15:20 -0800 (PST) Sender: tomek.cedro@gmail.com Received: by 10.68.191.6 with HTTP; Tue, 19 Nov 2013 06:15:20 -0800 (PST) In-Reply-To: References: Date: Tue, 19 Nov 2013 15:15:20 +0100 X-Google-Sender-Auth: 6c3-cgT7t7Q8TkP6PRdlypDEtd0 Message-ID: Subject: Re: bug in dhclient / dhclient.conf / dhcp-options parser? From: CeDeROM To: FreeBSD Questions Mailing List , freebsd-net@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 14:15:21 -0000 On Tue, Nov 19, 2013 at 3:09 PM, CeDeROM wrote: > I have noticed that other options with names known to > dhcp-options and decimal numbers above 100 are sent correctly, so > maybe there is an error in the options number parser, or I do > something wrong? I have just tested value 88 (example below 100) and it works correctly, so parsing seems okay. Why some option numbers are treated in a different way then? :-( Best regards :-) Tomek -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 14:43:26 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C333BFF for ; Tue, 19 Nov 2013 14:43:26 +0000 (UTC) Received: from sam.nabble.com (sam.nabble.com [216.139.236.26]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A605624C6 for ; Tue, 19 Nov 2013 14:43:26 +0000 (UTC) Received: from [192.168.236.26] (helo=sam.nabble.com) by sam.nabble.com with esmtp (Exim 4.72) (envelope-from ) id 1VimWT-0006pb-J1 for freebsd-net@freebsd.org; Tue, 19 Nov 2013 06:43:25 -0800 Date: Tue, 19 Nov 2013 06:43:25 -0800 (PST) From: CMarinier To: freebsd-net@freebsd.org Message-ID: <1384872205571-5862262.post@n5.nabble.com> In-Reply-To: <1362583262334-5793139.post@n5.nabble.com> References: <2DE61B0869B7484997BCA012845482C7EBE62DDD88@WIN2008.Domnt.abi.ca> <1362583262334-5793139.post@n5.nabble.com> Subject: Re: kernel: arpresolve: can't allocate llinfo for 65.59.233.102 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 14:43:26 -0000 Hi, I experience a similar problem. After a few hours, "arpresolve: can't allocate llinfo" messages start to accumulate in /var/log/messages. I run FreeBSD 9.2 Release (amd64) without a default route. Only one of the three Ethernet interfaces produces these errors. The FreeBSD machine is a WAN emulator connected to three Cisco routers. Normal ARP tables have two entries for each interface (one for self and one for the router); when this problem occurs, the ARP table for the failing interface contains only the entry for self. OSPF does not seem to mind (but it uses multicast). Ping fails from FreeBSD and from the router; when the router pings, tcpdump on FreeBSD can see the packets. This problem is sometimes accompanied by "Invalid argument" errors on the same interface. Can anyone shed light on this? Thank you. -- C Marinier -- View this message in context: http://freebsd.1045724.n5.nabble.com/kernel-arpresolve-can-t-allocate-llinfo-for-65-59-233-102-tp5742320p5862262.html Sent from the freebsd-net mailing list archive at Nabble.com. From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 15:23:15 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1AD2AC29 for ; Tue, 19 Nov 2013 15:23:15 +0000 (UTC) Received: from port.iol.cz (port.iol.cz [194.228.1.9]) by mx1.freebsd.org (Postfix) with ESMTP id AAE4C2762 for ; Tue, 19 Nov 2013 15:23:14 +0000 (UTC) X-SBRS: None X-SBRS-none: None X-RECVLIST: ETMAIL-CZ X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai26AOaBi1IlvOf5/2dsb2JhbABZgXEEAU1EOA4DJAeCTIJMiAOpeIg8BA2BFRdwBIMCOwYBAgN2JBuHZgEBFQEInneHApASBSIFiQqOQYEzGIQEA548i2OBPIFtOw X-IPAS-Result: Ai26AOaBi1IlvOf5/2dsb2JhbABZgXEEAU1EOA4DJAeCTIJMiAOpeIg8BA2BFRdwBIMCOwYBAgN2JBuHZgEBFQEInneHApASBSIFiQqOQYEzGIQEA548i2OBPIFtOw X-Ironport-Spamtest-Result: SUSPECTED X-IronPort-AV: E=Sophos;i="4.93,729,1378850400"; d="scan'208,217";a="292755168" Received: from ip-37-188-231-249.eurotel.cz (HELO pepa-PC) ([37.188.231.249]) by smtp.etmail.cz with SMTP; 19 Nov 2013 16:23:12 +0100 Organization: hilfe-fur-haustiere Message-ID: <20b1e4dac6f2264fc578009e001aa46b@centrum.cz> From: "hilfe-fur-haustiere" To: Subject: www.Hilfe-fur-Haustiere.net Date: Tue, 19 Nov 2013 16:23:11 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="238" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.16 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: hilfe-fur-haustiere@centrum.cz List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 15:23:15 -0000 =A0 www.Hilfe-fur-Haustiere.net From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 16:55:17 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 78FAF521; Tue, 19 Nov 2013 16:55:17 +0000 (UTC) Received: from am1outboundpool.messaging.microsoft.com (am1ehsobe006.messaging.microsoft.com [213.199.154.209]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 076412B61; Tue, 19 Nov 2013 16:55:16 +0000 (UTC) Received: from mail103-am1-R.bigfish.com (10.3.201.230) by AM1EHSOBE015.bigfish.com (10.3.207.137) with Microsoft SMTP Server id 14.1.225.22; Tue, 19 Nov 2013 16:55:08 +0000 Received: from mail103-am1 (localhost [127.0.0.1]) by mail103-am1-R.bigfish.com (Postfix) with ESMTP id 5EEF84000C3; Tue, 19 Nov 2013 16:55:08 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.239.16; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: -2 X-BigFish: VPS-2(zz98dI1432Izz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h1d1ah1d2ah1fc6hzz8275ch1de098h17326ah8275dh1de097h186068hz31h2a8h839h944hd24hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1e23h1fe8h1ff5h2218h2216h1155h) Received-SPF: softfail (mail103-am1: transitioning domain of juniper.net does not designate 66.129.239.16 as permitted sender) client-ip=66.129.239.16; envelope-from=stevek@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail103-am1 (localhost.localdomain [127.0.0.1]) by mail103-am1 (MessageSwitch) id 1384880106409500_21219; Tue, 19 Nov 2013 16:55:06 +0000 (UTC) Received: from AM1EHSMHS001.bigfish.com (unknown [10.3.201.238]) by mail103-am1.bigfish.com (Postfix) with ESMTP id 5F1A41A0053; Tue, 19 Nov 2013 16:55:06 +0000 (UTC) Received: from P-EMF02-SAC.jnpr.net (66.129.239.16) by AM1EHSMHS001.bigfish.com (10.3.207.101) with Microsoft SMTP Server (TLS) id 14.16.227.3; Tue, 19 Nov 2013 16:55:03 +0000 Received: from stevek-ubuntu (172.25.4.212) by P-EMF02-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server id 14.3.146.0; Tue, 19 Nov 2013 08:54:58 -0800 Date: Tue, 19 Nov 2013 11:54:55 -0500 From: Steve Kiernan To: Gleb Smirnoff Subject: Re: [JNPR] Network stack as a module (RFC) Message-ID: <20131119115455.3da072a1@stevek-ubuntu> In-Reply-To: <20131119114531.GF7577@glebius.int.ru> References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131116084919.GF7577@glebius.int.ru> <1DAF9090-08DA-404B-B86B-57E5D124D70D@xcllnt.net> <20131118164149.GV7577@glebius.int.ru> <20131118143508.0253e663@stevek-ubuntu> <20131119114531.GF7577@glebius.int.ru> Organization: Juniper Networks Inc. X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: freebsd-net@freebsd.org, luigi@freebsd.org, Marcel Moolenaar , zec@freebsd.org, Marcel Moolenaar X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 16:55:17 -0000 On Tue, 19 Nov 2013 15:45:31 +0400 Gleb Smirnoff wrote: > On Mon, Nov 18, 2013 at 02:35:08PM -0500, Steve Kiernan wrote: > > S> See http://people.freebsd.org/~marcel/Juniper/netstack-v2.diff, which > S> is the full patch set that had been previously sent out. Some things > S> have changed a bit since then, but if you look for curnetstack usage > S> in the patch, you should be able to see the places where netsack > S> methods are called. > > The patch is quite huge to understand it as a whole. :) Yes, it is. This is why we are doing it a piece at a time now, starting with the option. Much easier to digest that way. :) -- Stephen J. Kiernan Juniper Networks, Inc. stevek_at_juniper.net From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 17:47:46 2013 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 554C7298 for ; Tue, 19 Nov 2013 17:47:46 +0000 (UTC) Received: from smtp.alterapraxis.com (unknown [101.164.33.212]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0C2F42FA7 for ; Tue, 19 Nov 2013 17:47:46 +0000 (UTC) Received: from smtp.alterapraxis.com (tony [127.0.0.1]) by smtp.alterapraxis.com (Postfix) with ESMTP id B00C46331AA for ; Wed, 20 Nov 2013 04:44:16 +1100 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alterapraxis.com; s=alterapraxis; t=1384883056; bh=3ksc+rA4gk6bw0SI571B78pOYJaw/OoBEwOER3WeYXI=; h=Date:From:To:Subject; b=cM+id+oc9OV890xmQ0XRQmrHa0zTOR3ANiwG5tC4dglZeIL/aPjSa3kEtC9vm76IY uiBUEpjRDsmzzSEcRccYK1+tJfqVtey1tTMXJcuuFMx17NSkffE7RuazseYEsJDOjI 3EgFqtadQqQbuOrekWlxe4W1NRJrhtfRxl2hkNPY= Received: from [127.0.0.1] (localhost [127.0.0.1]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: eocallaghan@alterapraxis.com) by smtp.alterapraxis.com (Postfix) with ESMTPSA id 53CBB633183 for ; Wed, 20 Nov 2013 04:44:16 +1100 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alterapraxis.com; s=alterapraxis; t=1384883056; bh=3ksc+rA4gk6bw0SI571B78pOYJaw/OoBEwOER3WeYXI=; h=Date:From:To:Subject; b=cM+id+oc9OV890xmQ0XRQmrHa0zTOR3ANiwG5tC4dglZeIL/aPjSa3kEtC9vm76IY uiBUEpjRDsmzzSEcRccYK1+tJfqVtey1tTMXJcuuFMx17NSkffE7RuazseYEsJDOjI 3EgFqtadQqQbuOrekWlxe4W1NRJrhtfRxl2hkNPY= Date: Wed, 20 Nov 2013 04:47:29 +1100 From: Edward O'Callaghan To: freebsd-net@FreeBSD.org Subject: [PATCH]: Trivial dmesg formatting. Message-ID: <20131120044729.14b495d3.eocallaghan@alterapraxis.com> Organization: Altera Praxis Pty Ltd Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/o4gpcp5Vqk5c9DDtbq=vI8Q" X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 17:47:46 -0000 --MP_/o4gpcp5Vqk5c9DDtbq=vI8Q Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hello, Just some house keeping. Cheers, Edward. --MP_/o4gpcp5Vqk5c9DDtbq=vI8Q Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=netvsc.patch Index: sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c (revision 258349) +++ sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c (working copy) @@ -182,7 +182,7 @@ static void netvsc_init(void) { - printf("Netvsc initializing... "); + printf("Netvsc initializing... \n"); =20 /* * XXXKYS: cleanup initialization --MP_/o4gpcp5Vqk5c9DDtbq=vI8Q-- From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 17:49:01 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B2F7C332; Tue, 19 Nov 2013 17:49:01 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 933A32FB4; Tue, 19 Nov 2013 17:49:01 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id rAJHn062065676 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Nov 2013 09:49:00 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id rAJHn0Hj065675; Tue, 19 Nov 2013 09:49:00 -0800 (PST) (envelope-from jmg) Date: Tue, 19 Nov 2013 09:48:59 -0800 From: John-Mark Gurney To: CeDeROM Subject: Re: bug in dhclient / dhclient.conf / dhcp-options parser? Message-ID: <20131119174859.GB2279@funkthat.com> Mail-Followup-To: CeDeROM , FreeBSD Questions Mailing List , freebsd-net@freebsd.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Tue, 19 Nov 2013 09:49:00 -0800 (PST) Cc: freebsd-net@freebsd.org, FreeBSD Questions Mailing List X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 17:49:01 -0000 CeDeROM wrote this message on Tue, Nov 19, 2013 at 15:09 +0100: > Hello :-) > > I need to send additional options with dhcp request, so I add "send" > option for an interface in /etc/dhclient.conf, however options are > non-standard and they use option value below 100 and they are not sent > in dhcp request. I have noticed that other options with names known to > dhcp-options and decimal numbers above 100 are sent correctly, so > maybe there is an error in the options number parser, or I do > something wrong? > > Here is my example /etc/dhclient.conf configuation: > > interface "em0"{ > send option-060 "vendor"; <-- does not go out in dhcp request > send option-077 "user"; <-- does not go out in dhcp request > send option-123 "blah123"; <-- goes out in dhcp request > send root-path "blahroot"; <-- goes out in dhcp request > } > > Please advise, quick solution appreciated :-) Are you trying to send option 60, or option 48? 060 may be being parsed as an octal number instead of decimal, which would be 48 instead of 60.. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 19:28:56 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CC988577 for ; Tue, 19 Nov 2013 19:28:56 +0000 (UTC) Received: from mail-bk0-x22b.google.com (mail-bk0-x22b.google.com [IPv6:2a00:1450:4008:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 604E8261B for ; Tue, 19 Nov 2013 19:28:56 +0000 (UTC) Received: by mail-bk0-f43.google.com with SMTP id mz12so1015194bkb.2 for ; Tue, 19 Nov 2013 11:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Azn5t+6PW2QofoW5/3RA0Zgzt0g/kj1eMAr+7W9sflg=; b=oxeq18mRn+hpkgakAchDAYRG2Hy1htPeTHr7DDF7EQ4j4lr6Sk2CTE6OX060K0URjw 8CK+mjgdYE5FVLvam3FwCFwgSYPOTyWAZ+96cUkwyUzKYh/1yZB/RTaJfYI2GA6uQVPR EpY2eiypGZayLVloYkwy0DAr0U1ziooFOeMlE7w905cVQ6ZyDpIY9Wws4Piu7DI0OEEv F0Xs/DlyLMVppTOIe1WjzfjT9TOqCaabmHrzJolDRrLiFl9PXeW8GYEWO4q0BrhTqeC2 SQYq1kSdVOJOg/3mtnlQPMUHmjq7BHHV8waeHQHeRxXrhMKfEzs4im4xPOYNVm/0/0XB +/mg== X-Received: by 10.205.36.193 with SMTP id tb1mr2203532bkb.28.1384889334475; Tue, 19 Nov 2013 11:28:54 -0800 (PST) Received: from omg (pluknet-1-pt.tunnel.tserv11.ams1.ipv6.he.net. [2001:470:1f14:4d0::2]) by mx.google.com with ESMTPSA id l5sm21584475bko.7.2013.11.19.11.28.53 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 19 Nov 2013 11:28:53 -0800 (PST) Sender: Sergey Kandaurov Date: Tue, 19 Nov 2013 23:28:50 +0400 From: Sergey Kandaurov To: Edward O'Callaghan Subject: Re: [PATCH]: Trivial dmesg formatting. Message-ID: <20131119192850.GA97826@omg> References: <20131120044729.14b495d3.eocallaghan@alterapraxis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <20131120044729.14b495d3.eocallaghan@alterapraxis.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-net@FreeBSD.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 19:28:56 -0000 --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 20, 2013 at 04:47:29AM +1100, Edward O'Callaghan wrote: > Index: sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c (revision 258349) > +++ sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c (working copy) > @@ -182,7 +182,7 @@ > static void > netvsc_init(void) > { > - printf("Netvsc initializing... "); > + printf("Netvsc initializing... \n"); > =20 > /* > * XXXKYS: cleanup initialization Just putting "\n" here is probably not enough to fix formatting. Looking at the code below I think it was done specially so that the line could be appended with "Already initialized!", depending on hyperv and boot state. Personally I'd put the whole thing under bootverbose. --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQEcBAEBAgAGBQJSi7vyAAoJED9Ol7oQYHQZBoMIAK1XK3aiR5/NH/Oa2SEaqOZ1 jD/5o9nTXKGMeX08eymFKM3Hd9C2BUFfhXX+JhC00FCbSBUhhtzmqTWNMUZ1MmpQ AqKnD0wDVdBJvOjUGbmeOaiIEngbQhHmSRQ75/20HzKrMJqy9H3zR9KXwB8Hbmp4 AyhoHckkbcDHUzr2Y40F1Srx3h91kADqaHDoILSnoDNtw1Ibht/+P+kSPR7RQE+K 9k0LwU/uu8bCv4mjoShfJjV2X5Gh3aXkmb71QL54+SG81aSQiXYj3DW110z++CgJ LVZf/4UX3JjzX1lQCjuVRq9Ej1RST16kKseWC1QEN8PUyMGXm0Php33q7moZYjU= =ISQu -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU-- From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 21:31:31 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0BE71C59; Tue, 19 Nov 2013 21:31:31 +0000 (UTC) Received: from mail-pb0-x232.google.com (mail-pb0-x232.google.com [IPv6:2607:f8b0:400e:c01::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D7CBA2E37; Tue, 19 Nov 2013 21:31:30 +0000 (UTC) Received: by mail-pb0-f50.google.com with SMTP id rr13so2507343pbb.9 for ; Tue, 19 Nov 2013 13:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=UCu3+8qyKFp7JrdL0i5HcJJmgA1vyv58FaIQ1O/4hVM=; b=PKHXECB4KVhOcjFRl4V0ExxfvkYNALSfpyk4LIFggGVMJYCQAe8/rub2NSS3o9/ric 5no8Q1c9mySr62FL0iA5h9SIxbRR3ci3uR960uAiZa/ckKtvADQE3prAVFm+VIkBHgBb 6r0LvZFv8QPJi9Ium13Oip4jb2sv94xpdfO50/Lefmw4BJBBa6jrGYHYFT6pEcLr2F8y ux0PYxID+A561bSL+1Iuo8Lii5QERO8IIyFHtfzPLdAJ4DndTZZ6ttFuDfY1AMFPxXqL Gu66hy7uH382qN37ZeoxeSsIZ7xsHoyUCwJ3IqBWqXCLrSS+4nKgHbFzW9+KYEpgiMRS MwUQ== MIME-Version: 1.0 X-Received: by 10.66.118.233 with SMTP id kp9mr2314714pab.182.1384896690537; Tue, 19 Nov 2013 13:31:30 -0800 (PST) Sender: tomek.cedro@gmail.com Received: by 10.68.191.6 with HTTP; Tue, 19 Nov 2013 13:31:30 -0800 (PST) In-Reply-To: <20131119174859.GB2279@funkthat.com> References: <20131119174859.GB2279@funkthat.com> Date: Tue, 19 Nov 2013 22:31:30 +0100 X-Google-Sender-Auth: ZMDMSmdsoYVx5g291JJLEhdwBWQ Message-ID: Subject: Re: bug in dhclient / dhclient.conf / dhcp-options parser? From: CeDeROM To: CeDeROM , FreeBSD Questions Mailing List , freebsd-net@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 21:31:31 -0000 On Tue, Nov 19, 2013 at 6:48 PM, John-Mark Gurney wrote: > Are you trying to send option 60, or option 48? 060 may be being > parsed as an octal number instead of decimal, which would be 48 > instead of 60.. Manual states that these are decimal values, I have tried both decimal and octal for 60d but none of them works :-( I have tried 88d and 123d and these works, so there seems to be a bug in the parser that does not parse those numbers correctly for some reason :-) Best regards! :-) Tomek -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 21:31:28 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 649E0C58 for ; Tue, 19 Nov 2013 21:31:28 +0000 (UTC) Received: from rs102.luxsci.com (rs102.luxsci.com [74.205.104.183]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1FE662E36 for ; Tue, 19 Nov 2013 21:31:27 +0000 (UTC) Received: from rs102.luxsci.com (localhost.localdomain [127.0.0.1]) by rs102.luxsci.com (8.13.8/8.13.8) with ESMTP id rAJLPbhG029675 for ; Tue, 19 Nov 2013 15:25:37 -0600 Received: (from lshttpd@localhost) by rs102.luxsci.com (8.13.8/8.13.8/Submit) id rAJLPbq4029669; Tue, 19 Nov 2013 21:25:37 GMT Message-Id: <201311192125.rAJLPbq4029669@rs102.luxsci.com> From: "Isaac (.ike) Levy" Date: Tue, 19 Nov 2013 21:25:37 +0000 To: freebsd-net@freebsd.org Errors-To: ike@blackskyresearch.net MIME-Version: 1.0 X-Comment: 74627-7324-1 Subject: =?ISO-8859-1?B?Y2FycCAiY2FycHBlZXIiIG9wdGlvbiAodW5pY2FzdCk=?= Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: ike@blackskyresearch.net List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 21:31:28 -0000 Hi All, Does the FreeBSD carp implementation have the "carppeer" feature from=20 OpenBSD? I thought this had been brought in some time ago... I was just digging through the carp(4) et. al., on FreeBSD 9.2, and=20 couldn't find any info. -- The use case: restricting carp traffic to a particular trusted network,=20 (in my case, that network is a crossover cable :) Thanks! Best, .ike From owner-freebsd-net@FreeBSD.ORG Wed Nov 20 04:02:03 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 65571896; Wed, 20 Nov 2013 04:02:03 +0000 (UTC) Received: from mail-wg0-x230.google.com (mail-wg0-x230.google.com [IPv6:2a00:1450:400c:c00::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5173E29C6; Wed, 20 Nov 2013 04:02:02 +0000 (UTC) Received: by mail-wg0-f48.google.com with SMTP id n12so8557702wgh.15 for ; Tue, 19 Nov 2013 20:02:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9Y6YbBVCGEi5+ljNJ7RZWEywQsfFRZ2umjmo1oSQ2y4=; b=bj3/1Y04k3XZehVjs89Ou97Pt5kOfeBqBtz5dLNmUItPOtPEUfl1FXGxkPV9F+KJXs mr/sdZ5YwNJyNt29hBWW5rA83I56NmhYo5RBH5Ppr8s5s+jESz6JgKGmzl9UdjlLMwg5 09UXs/uVgpFJ7DZ/F+cqVXInvPwCRzNSlkPOV7wz63wqk+fMGaTXGVaNrdB9ka1MFbUS I7177MO9nce0+ZQBa/u9mDyrN/n8u0G2g4YtMWv8F2krRUQgm7xDuwMSzsmrPPoirUwG ExGek/p6LdZLw6zgZzG02YT6H8mbLo8fE07Av04HXyZNGDTc5gdUK8bf3KGnviMu/4GN IrqQ== MIME-Version: 1.0 X-Received: by 10.180.198.109 with SMTP id jb13mr13170115wic.55.1384920120718; Tue, 19 Nov 2013 20:02:00 -0800 (PST) Received: by 10.194.38.167 with HTTP; Tue, 19 Nov 2013 20:02:00 -0800 (PST) In-Reply-To: <20131119114531.GF7577@glebius.int.ru> References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131116084919.GF7577@glebius.int.ru> <1DAF9090-08DA-404B-B86B-57E5D124D70D@xcllnt.net> <20131118164149.GV7577@glebius.int.ru> <20131118143508.0253e663@stevek-ubuntu> <20131119114531.GF7577@glebius.int.ru> Date: Wed, 20 Nov 2013 09:32:00 +0530 Message-ID: Subject: Re: [JNPR] Network stack as a module (RFC) From: Dheeraj Kandula To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.16 Cc: luigi@freebsd.org, Marcel Moolenaar , Steve Kiernan , freebsd-net@freebsd.org, zec@freebsd.org, Marcel Moolenaar X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2013 04:02:03 -0000 Is there a link explaining about what changes have gone into this huge Diff. That would help people like me to figure out what is being addressed in the diff. I get the point that the whole network stack will be a loadable module now. Isn't it? On Tue, Nov 19, 2013 at 5:15 PM, Gleb Smirnoff wrote: > Steve, > > On Mon, Nov 18, 2013 at 02:35:08PM -0500, Steve Kiernan wrote: > S> > Have you measured the performance impact on the loadable stack? I > S> > suppose many functions, that are now called directly, with loadable > S> > stack will be called via functon pointers. > S> > S> No, only a small number of functions were needed to be methods in a > S> netstack kobj in the current implementation that we have. And some of > S> those may need to change, as they revolve around NFS exports. > S> > S> Currently, we have four (4) methods that are needed: > S> socreate > S> vfs_export > S> vfs_setpublicfs > S> vfs_stdcheckexp > S> > S> When one is not dealing with NFS exports, only the socreate method is > S> of interest. It is called just before mac_socket_create() would be > S> called in socreate(). > > Sounds okay. Thank you. > > S> See http://people.freebsd.org/~marcel/Juniper/netstack-v2.diff, which > S> is the full patch set that had been previously sent out. Some things > S> have changed a bit since then, but if you look for curnetstack usage > S> in the patch, you should be able to see the places where netsack > S> methods are called. > > The patch is quite huge to understand it as a whole. :) > > -- > Totus tuus, Glebius. > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Wed Nov 20 19:41:57 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CDA153EA; Wed, 20 Nov 2013 19:41:57 +0000 (UTC) Received: from db9outboundpool.messaging.microsoft.com (mail-db9lp0248.outbound.messaging.microsoft.com [213.199.154.248]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 36D7E240B; Wed, 20 Nov 2013 19:41:56 +0000 (UTC) Received: from mail127-db9-R.bigfish.com (10.174.16.234) by DB9EHSOBE034.bigfish.com (10.174.14.97) with Microsoft SMTP Server id 14.1.225.22; Wed, 20 Nov 2013 19:11:30 +0000 Received: from mail127-db9 (localhost [127.0.0.1]) by mail127-db9-R.bigfish.com (Postfix) with ESMTP id 4D815600E8; Wed, 20 Nov 2013 19:11:30 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.239.11; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: -1 X-BigFish: VPS-1(zz98dIzz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h1d1ah1d2ah1fc6hz8dhz8275ch1de098h17326ah8275bh8275dh1de097h186068hz31h2a8h839h944hd24hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1e23h1fe8h1ff5h2218h2216h226dh22d0h1155h) Received-SPF: softfail (mail127-db9: transitioning domain of juniper.net does not designate 66.129.239.11 as permitted sender) client-ip=66.129.239.11; envelope-from=stevek@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail127-db9 (localhost.localdomain [127.0.0.1]) by mail127-db9 (MessageSwitch) id 1384974688680609_29744; Wed, 20 Nov 2013 19:11:28 +0000 (UTC) Received: from DB9EHSMHS028.bigfish.com (unknown [10.174.16.242]) by mail127-db9.bigfish.com (Postfix) with ESMTP id A0A4D3C0069; Wed, 20 Nov 2013 19:11:28 +0000 (UTC) Received: from P-EMF02-SAC.jnpr.net (66.129.239.11) by DB9EHSMHS028.bigfish.com (10.174.14.38) with Microsoft SMTP Server (TLS) id 14.16.227.3; Wed, 20 Nov 2013 19:11:27 +0000 Received: from stevek-ubuntu (172.25.4.212) by P-EMF02-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server id 14.3.146.0; Wed, 20 Nov 2013 11:11:24 -0800 Date: Wed, 20 Nov 2013 14:11:17 -0500 From: Steve Kiernan To: Dheeraj Kandula Subject: Re: [JNPR] Network stack as a module (RFC) Message-ID: <20131120141117.71e1703e@stevek-ubuntu> In-Reply-To: References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131116084919.GF7577@glebius.int.ru> <1DAF9090-08DA-404B-B86B-57E5D124D70D@xcllnt.net> <20131118164149.GV7577@glebius.int.ru> <20131118143508.0253e663@stevek-ubuntu> <20131119114531.GF7577@glebius.int.ru> Organization: Juniper Networks Inc. X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: luigi@freebsd.org, Marcel Moolenaar , freebsd-net@freebsd.org, zec@freebsd.org, Marcel Moolenaar X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2013 19:41:58 -0000 On Wed, 20 Nov 2013 09:32:00 +0530 Dheeraj Kandula wrote: > Is there a link explaining about what changes have gone into this huge > Diff. That would help people like me to figure out what is being addressed > in the diff. I get the point that the whole network stack will be a > loadable module now. Isn't it? The big diff from back in January isn't what people necessarily need to look at right now. I could send a description of all the pieces in that patch, but I think it would be confusing to people at this point, as we are now trying to instead break the patch set up into easily digestible pieces. http://people.freebsd.org/~marcel/Juniper/201311/netstack-option.diff is the starting point, introducing the NETSTACK option. Yes, the final point will be the capability to have the network stack as a loadable module. The does not preclude building the network stack into the kernel (which is the default, even with the NETSTACK option being introduced, as we are adding the option to the relevant DEFAULTS files.) -- Stephen J. Kiernan Juniper Networks, Inc. stevek_at_juniper.net From owner-freebsd-net@FreeBSD.ORG Wed Nov 20 20:16:48 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7318035A; Wed, 20 Nov 2013 20:16:48 +0000 (UTC) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 401D6266D; Wed, 20 Nov 2013 20:16:48 +0000 (UTC) Received: from julian-mbp3.pixel8networks.com (50-196-156-133-static.hfc.comcastbusiness.net [50.196.156.133]) (authenticated bits=0) by vps1.elischer.org (8.14.7/8.14.7) with ESMTP id rAKKGjPY005856 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 20 Nov 2013 12:16:46 -0800 (PST) (envelope-from julian@freebsd.org) Message-ID: <528D18A8.5050001@freebsd.org> Date: Wed, 20 Nov 2013 12:16:40 -0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Steve Kiernan , Gleb Smirnoff Subject: Re: [JNPR] Network stack as a module (RFC) References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131116084919.GF7577@glebius.int.ru> <1DAF9090-08DA-404B-B86B-57E5D124D70D@xcllnt.net> <20131118164149.GV7577@glebius.int.ru> <20131118143508.0253e663@stevek-ubuntu> <20131119114531.GF7577@glebius.int.ru> <20131119115455.3da072a1@stevek-ubuntu> In-Reply-To: <20131119115455.3da072a1@stevek-ubuntu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org, luigi@freebsd.org, Marcel Moolenaar , zec@freebsd.org, Marcel Moolenaar X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2013 20:16:48 -0000 On 11/19/13, 8:54 AM, Steve Kiernan wrote: > On Tue, 19 Nov 2013 15:45:31 +0400 > Gleb Smirnoff wrote: > >> On Mon, Nov 18, 2013 at 02:35:08PM -0500, Steve Kiernan wrote: >> >> S> See http://people.freebsd.org/~marcel/Juniper/netstack-v2.diff, which >> S> is the full patch set that had been previously sent out. Some things >> S> have changed a bit since then, but if you look for curnetstack usage >> S> in the patch, you should be able to see the places where netsack >> S> methods are called. >> >> The patch is quite huge to understand it as a whole. :) > Yes, it is. This is why we are doing it a piece at a time now, starting > with the option. Much easier to digest that way. :) and thankyou for taking the time to do so. > > -- > Stephen J. Kiernan > Juniper Networks, Inc. > stevek_at_juniper.net > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Wed Nov 20 22:02:28 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ED356308; Wed, 20 Nov 2013 22:02:27 +0000 (UTC) Received: from mail-qa0-x22c.google.com (mail-qa0-x22c.google.com [IPv6:2607:f8b0:400d:c00::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5915D2CCC; Wed, 20 Nov 2013 22:02:27 +0000 (UTC) Received: by mail-qa0-f44.google.com with SMTP id i13so2574116qae.3 for ; Wed, 20 Nov 2013 14:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=HQFZhn/dLqkdw1iISOkod7K0WU/e+sX2vtPWRWn3csw=; b=FrEz4seDFuHpbprYomYXLQuE9UOhnywGQgvic2EH8H74GdrxF5vWx30NcMsVRD13w2 33W+VzQO+Sm6fe2B8kad/8LKNO4g+96dmxd++l2MH5hyrHwd4XSo2LMNSRK86Vg6hgoc lSx+lrOupDE0nt0AgxX57W2VrkIyU8EWkP4v5NcD8NdAwWzetnr02Kz0T8opNI11bkmJ V3xs1GsFEmQKjjjMmmBBfCIXSj2n3l4bXIvzxMaxkZraYMN/VQ3200bEifhZ0cz8ZoS2 bqPz2OA1jghdmbFOy17kV5NHxSEMPcn2FsG7v5LX7TZ5WEkIbeUJd0IABcULvI6w9gwp 8tXw== MIME-Version: 1.0 X-Received: by 10.224.64.200 with SMTP id f8mr5675355qai.55.1384984946603; Wed, 20 Nov 2013 14:02:26 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.224.207.66 with HTTP; Wed, 20 Nov 2013 14:02:26 -0800 (PST) In-Reply-To: <201311182258.rAIMwEFd048783@svn.freebsd.org> References: <201311182258.rAIMwEFd048783@svn.freebsd.org> Date: Wed, 20 Nov 2013 14:02:26 -0800 X-Google-Sender-Auth: ki1OX3h-CVp1suO6clamTiMqGqo Message-ID: Subject: Re: svn commit: r258328 - head/sys/net From: Adrian Chadd To: "George V. Neville-Neil" , "freebsd-arch@freebsd.org" , FreeBSD Net Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2013 22:02:28 -0000 Can we revert this and just quickly put together something else that won't potentially come back to bite us with weird side effects? My suggestions (and I'm happy to do this work if needed): * create a lightweight mbuf queue representation so an mbuf list isn't just the mbuf header pointer; * create a new ether input (say, ether_input_multi) that takes an mbuf list, so existing driver code does the right thing. After that it'd be nice to write a set of mbuf list macros for abstract the whole queue, dequeue, concat, iterate, etc (like sys/queue.h, but for mbufs.) What do people think? (I've been doing it for m->next chained things, but not m->m_nextpkt things..) -adrian On 18 November 2013 14:58, George V. Neville-Neil wrote: > Author: gnn > Date: Mon Nov 18 22:58:14 2013 > New Revision: 258328 > URL: http://svnweb.freebsd.org/changeset/base/258328 > > Log: > Allow ethernet drivers to pass in packets connected via the nextpkt pointer. > Handling packets in this way allows drivers to amortize work during packet reception. > > Submitted by: Vijay Singh > Sponsored by: NetApp > > Modified: > head/sys/net/if_ethersubr.c > > Modified: head/sys/net/if_ethersubr.c > ============================================================================== > --- head/sys/net/if_ethersubr.c Mon Nov 18 22:55:50 2013 (r258327) > +++ head/sys/net/if_ethersubr.c Mon Nov 18 22:58:14 2013 (r258328) > @@ -708,13 +708,25 @@ static void > ether_input(struct ifnet *ifp, struct mbuf *m) > { > > + struct mbuf *mn; > + > /* > - * We will rely on rcvif being set properly in the deferred context, > - * so assert it is correct here. > + * The drivers are allowed to pass in a chain of packets linked with > + * m_nextpkt. We split them up into separate packets here and pass > + * them up. This allows the drivers to amortize the receive lock. > */ > - KASSERT(m->m_pkthdr.rcvif == ifp, ("%s: ifnet mismatch", __func__)); > + while (m) { > + mn = m->m_nextpkt; > + m->m_nextpkt = NULL; > > - netisr_dispatch(NETISR_ETHER, m); > + /* > + * We will rely on rcvif being set properly in the deferred context, > + * so assert it is correct here. > + */ > + KASSERT(m->m_pkthdr.rcvif == ifp, ("%s: ifnet mismatch", __func__)); > + netisr_dispatch(NETISR_ETHER, m); > + m = mn; > + } > } > > /* From owner-freebsd-net@FreeBSD.ORG Wed Nov 20 22:29:56 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AE8E9D27; Wed, 20 Nov 2013 22:29:56 +0000 (UTC) Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7E2AB2E11; Wed, 20 Nov 2013 22:29:56 +0000 (UTC) Received: from [209.249.190.124] (port=55801 helo=gnnmac.hudson-trading.com) by vps.hungerhost.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.80.1) (envelope-from ) id 1VjGHP-0008Qy-E7; Wed, 20 Nov 2013 17:29:53 -0500 Content-Type: multipart/signed; boundary="Apple-Mail=_E7352C3B-1624-44C1-8794-7B37258E98DD"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: svn commit: r258328 - head/sys/net From: George Neville-Neil In-Reply-To: Date: Wed, 20 Nov 2013 17:29:37 -0500 Message-Id: <023E719B-1059-4670-8556-EBAC18A2F007@freebsd.org> References: <201311182258.rAIMwEFd048783@svn.freebsd.org> To: Adrian Chadd X-Mailer: Apple Mail (2.1822) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - freebsd.org X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com Cc: "svn-src-head@freebsd.org" , FreeBSD Net , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2013 22:29:56 -0000 --Apple-Mail=_E7352C3B-1624-44C1-8794-7B37258E98DD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Nov 20, 2013, at 17:02 , Adrian Chadd wrote: > Can we revert this and just quickly put together something else that > won't potentially come back to bite us with weird side effects? >=20 > My suggestions (and I'm happy to do this work if needed): >=20 > * create a lightweight mbuf queue representation so an mbuf list isn't > just the mbuf header pointer; > * create a new ether input (say, ether_input_multi) that takes an mbuf > list, so existing driver code does the right thing. >=20 > After that it'd be nice to write a set of mbuf list macros for > abstract the whole queue, dequeue, concat, iterate, etc (like > sys/queue.h, but for mbufs.) >=20 > What do people think? >=20 > (I've been doing it for m->next chained things, but not m->m_nextpkt = things..) I think the right way to do this is to move forwards and not backwards. This change has the nice effect of not breaking anything else in the tree while providing us with a feature that will be useful. =20 If you want to add an ether_input_multi() that might make sense as an adjunct to what=92s there now. Best, Geoge =20 --Apple-Mail=_E7352C3B-1624-44C1-8794-7B37258E98DD Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlKNN9EACgkQYdh2wUQKM9IhNwCgxNJQY383jR+pHPAg6DuJc4/a O4wAnirp4BKvFIPw48tB7ddl+po7Fb2G =YkRf -----END PGP SIGNATURE----- --Apple-Mail=_E7352C3B-1624-44C1-8794-7B37258E98DD-- From owner-freebsd-net@FreeBSD.ORG Wed Nov 20 22:46:57 2013 Return-Path: Delivered-To: freebsd-net@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7665B64B; Wed, 20 Nov 2013 22:46:57 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4E0AA2F21; Wed, 20 Nov 2013 22:46:57 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAKMkvX1064219; Wed, 20 Nov 2013 22:46:57 GMT (envelope-from ae@freefall.freebsd.org) Received: (from ae@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAKMkuWO064218; Wed, 20 Nov 2013 22:46:56 GMT (envelope-from ae) Date: Wed, 20 Nov 2013 22:46:56 GMT Message-Id: <201311202246.rAKMkuWO064218@freefall.freebsd.org> To: a@arifumi.net, ae@FreeBSD.org, freebsd-net@FreeBSD.org, ae@FreeBSD.org From: ae@FreeBSD.org Subject: Re: kern/143666: [ip6] [request] PMTU black hole detection not implemented X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2013 22:46:57 -0000 Synopsis: [ip6] [request] PMTU black hole detection not implemented State-Changed-From-To: suspended->open State-Changed-By: ae State-Changed-When: Wed Nov 20 22:46:19 UTC 2013 State-Changed-Why: Take it. Responsible-Changed-From-To: freebsd-net->ae Responsible-Changed-By: ae Responsible-Changed-When: Wed Nov 20 22:46:19 UTC 2013 Responsible-Changed-Why: Take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=143666 From owner-freebsd-net@FreeBSD.ORG Thu Nov 21 00:00:36 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2CD4CAE0; Thu, 21 Nov 2013 00:00:36 +0000 (UTC) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id E0D552317; Thu, 21 Nov 2013 00:00:34 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 6093F7300A; Thu, 21 Nov 2013 01:02:45 +0100 (CET) Date: Thu, 21 Nov 2013 01:02:45 +0100 From: Luigi Rizzo To: George Neville-Neil Subject: Re: svn commit: r258328 - head/sys/net Message-ID: <20131121000245.GA30549@onelab2.iet.unipi.it> References: <201311182258.rAIMwEFd048783@svn.freebsd.org> <023E719B-1059-4670-8556-EBAC18A2F007@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <023E719B-1059-4670-8556-EBAC18A2F007@freebsd.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Adrian Chadd , "src-committers@freebsd.org" , FreeBSD Net , "svn-src-all@freebsd.org" , "freebsd-arch@freebsd.org" , "svn-src-head@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 00:00:36 -0000 On Wed, Nov 20, 2013 at 05:29:37PM -0500, George Neville-Neil wrote: > > On Nov 20, 2013, at 17:02 , Adrian Chadd wrote: > > > Can we revert this and just quickly put together something else that > > won't potentially come back to bite us with weird side effects? > > > > My suggestions (and I'm happy to do this work if needed): > > > > * create a lightweight mbuf queue representation so an mbuf list isn't > > just the mbuf header pointer; > > * create a new ether input (say, ether_input_multi) that takes an mbuf > > list, so existing driver code does the right thing. > > > > After that it'd be nice to write a set of mbuf list macros for > > abstract the whole queue, dequeue, concat, iterate, etc (like > > sys/queue.h, but for mbufs.) > > > > What do people think? > > > > (I've been doing it for m->next chained things, but not m->m_nextpkt things..) > > I think the right way to do this is to move forwards and not backwards. > This change has the nice effect of not breaking anything else in the > tree while providing us with a feature that will be useful. I am a bit torn on this. George is right - we should move forward, and we have been discussing this trivial change for two years. It is impossible to tell when someone will find the time to implement the mbuf queue and the new method (more on this later). So we should not back it out. At the same time: in principle this change does not break anything, but Robert is right that some of the 50-100 drivers we have might forget to clear m_nextpkt and cause trouble. So it would be nice to implement some protection, maybe something as simple as setting a flag in the first mbuf to tell that this is a chain and not a single mbuf. We have 12 M_PROTO* flags to use. For the next step: I am still wondering what is the best way to implement an alternate ifp->if_input_multi method (which takes an mbuf queue as an argument, and can be checked by the compiler). I am not too fond of having two different input methods, as it complicates life when one has to intercept packets. On the other hand, globally changing all drivers to use the if_input_multi() method is too much trouble, so i suspect we will have to come up with some nice trick, e.g. use a pseudo mbuf with m_type = MT_MBQUEUE and overload the m_hdr fields as queue pointers. cheers luigi From owner-freebsd-net@FreeBSD.ORG Thu Nov 21 00:07:09 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 67CBCE2D; Thu, 21 Nov 2013 00:07:09 +0000 (UTC) Received: from mail-qe0-x235.google.com (mail-qe0-x235.google.com [IPv6:2607:f8b0:400d:c02::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C7EDF236D; Thu, 21 Nov 2013 00:07:08 +0000 (UTC) Received: by mail-qe0-f53.google.com with SMTP id cy11so6858980qeb.12 for ; Wed, 20 Nov 2013 16:07:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=KajDMffiIXncp1WKPF9oXTEogDIzTZoJnsZewsmr2v8=; b=bb5uCOqzwFDPLeDtWrLPQHTspQiCQw/FjzDGq5dn2zznM8FsTnKl3FJ07qJtLqm3rp LdBs86y1eJy/W/dqUUskphKO8PC474dmlUkIX18/qZBCwxjes6SLZ6kD6pDvGgy/h5bI dYHKtz2iy1z+5n473RgGIkMOHnG1V47UcdKnS30VRYU3CvvdK17JzY472PAwazvv4eWc +UdSxZ4R9tlbgJaky1FNSfTW5XkBKWsoxWRmFAnvbQPe3Ug5fBZs1S37ugy80BjRPd60 B0eAUBElEVAaEEwafM5IAh2qOplByAReAvVzbD7QjT5KFbjcJc8y9iK+C1IRVHBkFhLO uD6A== MIME-Version: 1.0 X-Received: by 10.224.12.10 with SMTP id v10mr6394090qav.98.1384992427830; Wed, 20 Nov 2013 16:07:07 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.224.207.66 with HTTP; Wed, 20 Nov 2013 16:07:07 -0800 (PST) In-Reply-To: <20131121000245.GA30549@onelab2.iet.unipi.it> References: <201311182258.rAIMwEFd048783@svn.freebsd.org> <023E719B-1059-4670-8556-EBAC18A2F007@freebsd.org> <20131121000245.GA30549@onelab2.iet.unipi.it> Date: Wed, 20 Nov 2013 16:07:07 -0800 X-Google-Sender-Auth: WL_16bDMg3EIC-et8hOOltYtOIc Message-ID: Subject: Re: svn commit: r258328 - head/sys/net From: Adrian Chadd To: Luigi Rizzo Content-Type: text/plain; charset=ISO-8859-1 Cc: "src-committers@freebsd.org" , FreeBSD Net , "svn-src-all@freebsd.org" , George Neville-Neil , "freebsd-arch@freebsd.org" , "svn-src-head@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 00:07:09 -0000 Hi, We should migrate drivers to use a multi-input method where it's appropriate. It's the same pain as if_transmit() is/was. I'd really like to avoid having hacky solutions like mbufs with magic types. If we're going down that path, we should create a correct inline messaging mechanism that includes arbitrary messages in the stream, where some may or may not be mbufs. Magic mbufs just makes me want to tear out my eyes a little. So, the reason I'd like to back it out is because we should be doing it via a multi method with some type that represents an mbuf list. If George doesn't mind, I'll add a multi input method, move this stuff into it, and make ether_input just be single frames. -adrian From owner-freebsd-net@FreeBSD.ORG Thu Nov 21 00:32:49 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 999C24C2; Thu, 21 Nov 2013 00:32:49 +0000 (UTC) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id 56CEF24EB; Thu, 21 Nov 2013 00:32:49 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 975807300A; Thu, 21 Nov 2013 01:35:06 +0100 (CET) Date: Thu, 21 Nov 2013 01:35:06 +0100 From: Luigi Rizzo To: Adrian Chadd Subject: Re: svn commit: r258328 - head/sys/net Message-ID: <20131121003506.GA30962@onelab2.iet.unipi.it> References: <201311182258.rAIMwEFd048783@svn.freebsd.org> <023E719B-1059-4670-8556-EBAC18A2F007@freebsd.org> <20131121000245.GA30549@onelab2.iet.unipi.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "src-committers@freebsd.org" , FreeBSD Net , "svn-src-all@freebsd.org" , George Neville-Neil , "freebsd-arch@freebsd.org" , "svn-src-head@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 00:32:49 -0000 On Wed, Nov 20, 2013 at 04:07:07PM -0800, Adrian Chadd wrote: > Hi, > > We should migrate drivers to use a multi-input method where it's > appropriate. It's the same pain as if_transmit() is/was. right, and i think that is very confusing and i'd rather not replicate the experience. But what is your plan, have both if_input and if_input_multi ? And then make the vlan and all similar filters intercept both ? Because all of the existing options have pros and cons: 1. having both if_input and if_input_multi is visually cleaner but requires extending ifnet and some convoluted code in the initialization (same as if_transmit) 2. just if_input with typed mbufs is less clean but has the big advantage thay you only need to change ether_input() (and equivalent for other L2 protocols), and it is not error prone 3. having only if_input_multi (even without renaming if_input) requires you to change all the 100+ drivers. It seems to me that #2 at least preserves binary compatibility with driver modules and is easier to backport to other versions of FreeBSD, this is why i prefer it. my two cents... cheers luigi > I'd really like to avoid having hacky solutions like mbufs with magic > types. If we're going down that path, we should create a correct > inline messaging mechanism that includes arbitrary messages in the > stream, where some may or may not be mbufs. Magic mbufs just makes me > want to tear out my eyes a little. > > So, the reason I'd like to back it out is because we should be doing > it via a multi method with some type that represents an mbuf list. If > George doesn't mind, I'll add a multi input method, move this stuff > into it, and make ether_input just be single frames. > > > > -adrian From owner-freebsd-net@FreeBSD.ORG Thu Nov 21 01:27:24 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 720F0200; Thu, 21 Nov 2013 01:27:24 +0000 (UTC) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DEF0E2754; Thu, 21 Nov 2013 01:27:23 +0000 (UTC) Received: from julian-mbp3.pixel8networks.com (50-196-156-133-static.hfc.comcastbusiness.net [50.196.156.133]) (authenticated bits=0) by vps1.elischer.org (8.14.7/8.14.7) with ESMTP id rAL1RKmp006812 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 20 Nov 2013 17:27:22 -0800 (PST) (envelope-from julian@freebsd.org) Message-ID: <528D6173.4080406@freebsd.org> Date: Wed, 20 Nov 2013 17:27:15 -0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Adrian Chadd , "George V. Neville-Neil" , "freebsd-arch@freebsd.org" , FreeBSD Net Subject: Re: svn commit: r258328 - head/sys/net References: <201311182258.rAIMwEFd048783@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 01:27:24 -0000 On 11/20/13, 2:02 PM, Adrian Chadd wrote: > Can we revert this and just quickly put together something else that > won't potentially come back to bite us with weird side effects? > > My suggestions (and I'm happy to do this work if needed): > > * create a lightweight mbuf queue representation so an mbuf list isn't > just the mbuf header pointer; > * create a new ether input (say, ether_input_multi) that takes an mbuf > list, so existing driver code does the right thing. > > After that it'd be nice to write a set of mbuf list macros for > abstract the whole queue, dequeue, concat, iterate, etc (like > sys/queue.h, but for mbufs.) > > What do people think? > > (I've been doing it for m->next chained things, but not m->m_nextpkt things..) I was thinking: new interfaces.. (your -multi names sound good). macros for handling said lists so that people don't screw them up Old drivers run with no change. > > > > -adrian > > > On 18 November 2013 14:58, George V. Neville-Neil wrote: >> Author: gnn >> Date: Mon Nov 18 22:58:14 2013 >> New Revision: 258328 >> URL: http://svnweb.freebsd.org/changeset/base/258328 >> >> Log: >> Allow ethernet drivers to pass in packets connected via the nextpkt pointer. >> Handling packets in this way allows drivers to amortize work during packet reception. >> >> Submitted by: Vijay Singh >> Sponsored by: NetApp >> >> Modified: >> head/sys/net/if_ethersubr.c >> >> Modified: head/sys/net/if_ethersubr.c >> ============================================================================== >> --- head/sys/net/if_ethersubr.c Mon Nov 18 22:55:50 2013 (r258327) >> +++ head/sys/net/if_ethersubr.c Mon Nov 18 22:58:14 2013 (r258328) >> @@ -708,13 +708,25 @@ static void >> ether_input(struct ifnet *ifp, struct mbuf *m) >> { >> >> + struct mbuf *mn; >> + >> /* >> - * We will rely on rcvif being set properly in the deferred context, >> - * so assert it is correct here. >> + * The drivers are allowed to pass in a chain of packets linked with >> + * m_nextpkt. We split them up into separate packets here and pass >> + * them up. This allows the drivers to amortize the receive lock. >> */ >> - KASSERT(m->m_pkthdr.rcvif == ifp, ("%s: ifnet mismatch", __func__)); >> + while (m) { >> + mn = m->m_nextpkt; >> + m->m_nextpkt = NULL; >> >> - netisr_dispatch(NETISR_ETHER, m); >> + /* >> + * We will rely on rcvif being set properly in the deferred context, >> + * so assert it is correct here. >> + */ >> + KASSERT(m->m_pkthdr.rcvif == ifp, ("%s: ifnet mismatch", __func__)); >> + netisr_dispatch(NETISR_ETHER, m); >> + m = mn; >> + } >> } >> >> /* From owner-freebsd-net@FreeBSD.ORG Thu Nov 21 01:31:53 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 99B77523; Thu, 21 Nov 2013 01:31:53 +0000 (UTC) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6008327A0; Thu, 21 Nov 2013 01:31:53 +0000 (UTC) Received: from julian-mbp3.pixel8networks.com (50-196-156-133-static.hfc.comcastbusiness.net [50.196.156.133]) (authenticated bits=0) by vps1.elischer.org (8.14.7/8.14.7) with ESMTP id rAL1Vku3006851 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 20 Nov 2013 17:31:47 -0800 (PST) (envelope-from julian@freebsd.org) Message-ID: <528D627D.2020009@freebsd.org> Date: Wed, 20 Nov 2013 17:31:41 -0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Luigi Rizzo , Adrian Chadd Subject: Re: svn commit: r258328 - head/sys/net References: <201311182258.rAIMwEFd048783@svn.freebsd.org> <023E719B-1059-4670-8556-EBAC18A2F007@freebsd.org> <20131121000245.GA30549@onelab2.iet.unipi.it> <20131121003506.GA30962@onelab2.iet.unipi.it> In-Reply-To: <20131121003506.GA30962@onelab2.iet.unipi.it> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "src-committers@freebsd.org" , FreeBSD Net , "svn-src-all@freebsd.org" , George Neville-Neil , "freebsd-arch@freebsd.org" , "svn-src-head@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 01:31:53 -0000 On 11/20/13, 4:35 PM, Luigi Rizzo wrote: > On Wed, Nov 20, 2013 at 04:07:07PM -0800, Adrian Chadd wrote: >> Hi, >> >> We should migrate drivers to use a multi-input method where it's >> appropriate. It's the same pain as if_transmit() is/was. > right, and i think that is very confusing and i'd rather > not replicate the experience. > > But what is your plan, have both if_input and if_input_multi ? > And then make the vlan and all similar filters intercept both ? > Because all of the existing options have pros and cons: > > 1. having both if_input and if_input_multi is visually cleaner > but requires extending ifnet and some convoluted code in the > initialization (same as if_transmit) > > 2. just if_input with typed mbufs is less clean but has the big > advantage thay you only need to change ether_input() (and equivalent > for other L2 protocols), and it is not error prone if_input_multi() or whatever it is called is just this patch split into two bits. in the simple case it just calls the single one multiple times, just like this patch does. it is clean from teh compiler's point of view, > > 3. having only if_input_multi (even without renaming if_input) > requires you to change all the 100+ drivers. > > It seems to me that #2 at least preserves binary compatibility > with driver modules and is easier to backport to other versions > of FreeBSD, this is why i prefer it. > > my two cents... > > cheers > luigi > >> I'd really like to avoid having hacky solutions like mbufs with magic >> types. If we're going down that path, we should create a correct >> inline messaging mechanism that includes arbitrary messages in the >> stream, where some may or may not be mbufs. Magic mbufs just makes me >> want to tear out my eyes a little. >> >> So, the reason I'd like to back it out is because we should be doing >> it via a multi method with some type that represents an mbuf list. If >> George doesn't mind, I'll add a multi input method, move this stuff >> into it, and make ether_input just be single frames. >> >> >> >> -adrian > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Thu Nov 21 06:23:44 2013 Return-Path: Delivered-To: freebsd-net@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 08972D8E; Thu, 21 Nov 2013 06:23:44 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D335F25B6; Thu, 21 Nov 2013 06:23:43 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAL6Nhxb074106; Thu, 21 Nov 2013 06:23:43 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAL6NhfV074105; Thu, 21 Nov 2013 06:23:43 GMT (envelope-from linimon) Date: Thu, 21 Nov 2013 06:23:43 GMT Message-Id: <201311210623.rAL6NhfV074105@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-net@FreeBSD.org From: linimon@FreeBSD.org Subject: Re: kern/184084: [ral] kernel crash by ral (RT3090) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 06:23:44 -0000 Old Synopsis: kernel crash by ral (RT3090) New Synopsis: [ral] kernel crash by ral (RT3090) Responsible-Changed-From-To: freebsd-bugs->freebsd-net Responsible-Changed-By: linimon Responsible-Changed-When: Thu Nov 21 06:23:27 UTC 2013 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=184084 From owner-freebsd-net@FreeBSD.ORG Thu Nov 21 14:36:28 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C01DA1D9; Thu, 21 Nov 2013 14:36:28 +0000 (UTC) Received: from mail-la0-x22b.google.com (mail-la0-x22b.google.com [IPv6:2a00:1450:4010:c03::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 308832B87; Thu, 21 Nov 2013 14:36:27 +0000 (UTC) Received: by mail-la0-f43.google.com with SMTP id n7so8595584lam.16 for ; Thu, 21 Nov 2013 06:36:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=VaVxEoUPpZNrmL8zcobT0aB48Mi+hvla+bWrEHYteMo=; b=BurAQuIngXdOcdketejPR7elj5w0MY3hoCyCzMhvbvSzuqm7TN1GBcQjAdgUTgzvIn s/gsQdjTUnW7KNALsYFNAgtheZXbq3PcATRk0h7fznzK1suM+cYHQ+BSQzaxq0lRckP7 zOV+mHt3qS2zuK4yN9VMNI7VaxanbbIZ2J/VwuqUxXYnerOvZAPZrP1RdqUtrteMhFDu OItCvwsXA2/o1Q0ubBEv8wFfSTx0tevd6m0eUVdr2n6UbBfpCxXUzXa5hfSHD6FUI0OD D9W0i5UFKMFnD9N+dRIY6yM/Hm+ylgmEJDbw/oJfUUSB9WAkVxG9eagn8wqFYrE1L74g MxPw== X-Received: by 10.112.150.103 with SMTP id uh7mr2039905lbb.34.1385044585178; Thu, 21 Nov 2013 06:36:25 -0800 (PST) Received: from [192.168.2.30] ([2.176.162.77]) by mx.google.com with ESMTPSA id vz9sm23479590lbb.17.2013.11.21.06.36.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 21 Nov 2013 06:36:24 -0800 (PST) Message-ID: <528E1A83.7070509@gmail.com> Date: Thu, 21 Nov 2013 18:06:51 +0330 From: Hooman Fazaeli User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: Adrian Chadd Subject: Re: svn commit: r258328 - head/sys/net References: <201311182258.rAIMwEFd048783@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "src-committers@freebsd.org" , FreeBSD Net , "svn-src-all@freebsd.org" , "George V. Neville-Neil" , "freebsd-arch@freebsd.org" , "svn-src-head@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 14:36:28 -0000 On 11/21/2013 1:32 AM, Adrian Chadd wrote: > Can we revert this and just quickly put together something else that > won't potentially come back to bite us with weird side effects? > > My suggestions (and I'm happy to do this work if needed): > > * create a lightweight mbuf queue representation so an mbuf list isn't > just the mbuf header pointer; > * create a new ether input (say, ether_input_multi) that takes an mbuf > list, so existing driver code does the right thing. > > After that it'd be nice to write a set of mbuf list macros for > abstract the whole queue, dequeue, concat, iterate, etc (like > sys/queue.h, but for mbufs.) > > What do people think? > > (I've been doing it for m->next chained things, but not m->m_nextpkt things..) > > > > -adrian > > > What are possible sideeffects? What are the benefits we achieve by a distinct queue structure and having both if_input and if_input_multi? -- Best regards. Hooman Fazaeli From owner-freebsd-net@FreeBSD.ORG Thu Nov 21 20:27:26 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 89427F14; Thu, 21 Nov 2013 20:27:26 +0000 (UTC) Received: from mail-qe0-x234.google.com (mail-qe0-x234.google.com [IPv6:2607:f8b0:400d:c02::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E84912331; Thu, 21 Nov 2013 20:27:25 +0000 (UTC) Received: by mail-qe0-f52.google.com with SMTP id ne12so225806qeb.25 for ; Thu, 21 Nov 2013 12:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=rVgtVdKNVGHJJXvnnjh8Lu0bJyME0SRoO5j6+SiROAM=; b=016dqiEySlUq3jx/zYzuzOGlS455QON0BUUqCdFrrBFCnxw3idNEP32VzDdii4mN2U YYFKuXV2HyInaqZTgMU4t6nQQf0zOUqhLkdOV4aFz2NQ+b9MIbt8Id3VPWUyBEZc5AcB 1jG4rHFmIW+c8x+q9fZUkDWRE3+KZ6+Bk9scn8FIcUIuag5fJQ2Axbp+hUjlWvVwP2br vJUUofbnqs1rUilvsXpcSuJpM2uFpM3CnbpQ++JLWWZlyvKJw2pizkb6mhJKx9SOHsLH Im6W4r7PzZXxlcKR/IHxRMdri3plEBKhskqPhZdoknuD1oJFBK7lyo7iQPMLEaP0walF wvUw== MIME-Version: 1.0 X-Received: by 10.224.12.10 with SMTP id v10mr14737114qav.98.1385065645153; Thu, 21 Nov 2013 12:27:25 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.224.207.66 with HTTP; Thu, 21 Nov 2013 12:27:25 -0800 (PST) In-Reply-To: <528E1A83.7070509@gmail.com> References: <201311182258.rAIMwEFd048783@svn.freebsd.org> <528E1A83.7070509@gmail.com> Date: Thu, 21 Nov 2013 12:27:25 -0800 X-Google-Sender-Auth: RV0JYfXTj1fTPfmfag55WipDIHw Message-ID: Subject: Re: svn commit: r258328 - head/sys/net From: Adrian Chadd To: Hooman Fazaeli Content-Type: text/plain; charset=ISO-8859-1 Cc: "src-committers@freebsd.org" , FreeBSD Net , "svn-src-all@freebsd.org" , "George V. Neville-Neil" , "freebsd-arch@freebsd.org" , "svn-src-head@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 20:27:26 -0000 On 21 November 2013 06:36, Hooman Fazaeli wrote: > What are possible sideeffects? What are the benefits we achieve by a > distinct > queue structure and having both if_input and if_input_multi? Doing incremental development where you can minimise unintended side-effects during development? -adrian From owner-freebsd-net@FreeBSD.ORG Fri Nov 22 15:26:56 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BBFA0220 for ; Fri, 22 Nov 2013 15:26:56 +0000 (UTC) Received: from mail-ob0-x231.google.com (mail-ob0-x231.google.com [IPv6:2607:f8b0:4003:c01::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 880062B41 for ; Fri, 22 Nov 2013 15:26:56 +0000 (UTC) Received: by mail-ob0-f177.google.com with SMTP id va2so1424996obc.36 for ; Fri, 22 Nov 2013 07:26:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=SqiuUgRChCKqyTybbyG8StdQkpDKPNz8aKvvyM3A3yA=; b=OPOQG3yBTzI4piAYYOApvHxuMTjNx8o49vFoi+HlMLfprciJypXyeqY+MxCvELjIL9 ezndAcBiKId+ThBc7yRIT888aw5C5H4HJgZKSZfa1xDxDbuQkqWv/sdON5f+OblozscF 4q0KWnNDdx1cXFP88+pmTGhDPrqedxyavTNVOYwzXBcVQ6XIVkOtRshi49jvCn1lnUhk MG/+wfyYi3UStpTxKMZKKTbyRmaTL09/8A3ZZ7tRGfFfJtJL3eZUySxwKE1nABkbGqTx 2BScrtoQxRuinGwC8wk8t9HOJiQ5Y/eke1m1KJ4ChCzZ5zT2cD8toBD8oA+LZu0brrTr v5gQ== X-Received: by 10.182.126.167 with SMTP id mz7mr1137192obb.69.1385134015405; Fri, 22 Nov 2013 07:26:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.60.46.170 with HTTP; Fri, 22 Nov 2013 07:26:35 -0800 (PST) In-Reply-To: <79A66F26-E7D5-4A2E-8887-502AFACC7091@obsigna.com> References: <6066426D-84BE-40F6-904D-9FF97B128555@obsigna.com> <5287EE0F.3070800@smeets.im> <4CA8022F-E827-4417-9541-4E3EB4D6155E@obsigna.com> <79A66F26-E7D5-4A2E-8887-502AFACC7091@obsigna.com> From: Raimundo Santos Date: Fri, 22 Nov 2013 13:26:35 -0200 Message-ID: Subject: Re: MPD5 PPTP and L2TP server problem with FreeBSD 9.2-RELEASE-p1 To: "Dr. Rolf Jansen" , "freebsd-net@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.16 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2013 15:26:56 -0000 On 17 November 2013 22:38, Dr. Rolf Jansen wrote: > I switched to gateway_enable="YES" in rc.conf, and in addition I disabled > devd. I don't need to edit the sysctl directly, it was only a habit. Me too got this habit. I do not see the real need to do a PR by now, no time to evaluate if the problems noted by Eugene worth the PR. Thank you. From owner-freebsd-net@FreeBSD.ORG Fri Nov 22 20:14:54 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EE9E6C60 for ; Fri, 22 Nov 2013 20:14:54 +0000 (UTC) Received: from mail-lb0-x233.google.com (mail-lb0-x233.google.com [IPv6:2a00:1450:4010:c04::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 77D312BE3 for ; Fri, 22 Nov 2013 20:14:54 +0000 (UTC) Received: by mail-lb0-f179.google.com with SMTP id l4so1401699lbv.10 for ; Fri, 22 Nov 2013 12:14:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=1k5GBgpIKfy3gy5cpD5n400MeW5zTn4EduqmRhPemkk=; b=byX79fu/Ft3ZD+NLyZ5VD9NorpthJB23OOIejhiRM6O1m+uq00Yc6kTh+ibkJwphfe 1+FmsFSN6Yd2/Vg3w6zIzrY++ckzDOte9i6rMgFPOLAQclg+Mtm30Jyy35E1iEn0pYoQ NWWyyTzt4L200l3oAGyPF8Qo4nay+gYOnBm7KAx+ggmZLODgHXYAY+yllcQ8k5Rs8D1m WBhdn4eP08oSn+S8C1wImjagIPtDc1Yd934+VlcYSP2vZBNKszJobtQgCTlhwzysoQ6X 2Q85xELrq0q5OMN4tJG3gz0rFFFeXH4ahWYb7c7av8WCWQijxNmdGOfKpEgWbJmf0AN3 wPPw== X-Received: by 10.152.22.4 with SMTP id z4mr11091678lae.14.1385151292467; Fri, 22 Nov 2013 12:14:52 -0800 (PST) Received: from [192.168.2.30] ([2.176.162.77]) by mx.google.com with ESMTPSA id c10sm24955303lbd.9.2013.11.22.12.14.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 22 Nov 2013 12:14:50 -0800 (PST) Message-ID: <528FBB56.80607@gmail.com> Date: Fri, 22 Nov 2013 23:45:18 +0330 From: Hooman Fazaeli User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: Raimundo Santos Subject: Re: MPD5 PPTP and L2TP server problem with FreeBSD 9.2-RELEASE-p1 References: <6066426D-84BE-40F6-904D-9FF97B128555@obsigna.com> <5287EE0F.3070800@smeets.im> <4CA8022F-E827-4417-9541-4E3EB4D6155E@obsigna.com> <79A66F26-E7D5-4A2E-8887-502AFACC7091@obsigna.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "freebsd-net@freebsd.org" , "Dr. Rolf Jansen" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2013 20:14:55 -0000 On 11/22/2013 6:56 PM, Raimundo Santos wrote: > On 17 November 2013 22:38, Dr. Rolf Jansen wrote: > >> I switched to gateway_enable="YES" in rc.conf, and in addition I disabled >> devd. I don't need to edit the sysctl directly, it was only a habit. > > Me too got this habit. > > I do not see the real need to do a PR by now, no time to evaluate if the > problems noted by Eugene worth the PR. > > Thank you. > _______________________________________________ IMHO, It is wrong to check forwarding status from gateway_enable. rc.conf settings are meant for startup configuration and not indicators of the running status of the system. A PR would be the least contribution to fixing the problem and saving the time of other freebsd users. -- Best regards. Hooman Fazaeli From owner-freebsd-net@FreeBSD.ORG Fri Nov 22 21:39:02 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CDD62B48; Fri, 22 Nov 2013 21:39:02 +0000 (UTC) Received: from mail-qe0-x229.google.com (mail-qe0-x229.google.com [IPv6:2607:f8b0:400d:c02::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 704B32FB1; Fri, 22 Nov 2013 21:39:02 +0000 (UTC) Received: by mail-qe0-f41.google.com with SMTP id x7so1447487qeu.0 for ; Fri, 22 Nov 2013 13:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=upA3l79iC9rvuQRwEZGqJglu1DdtOVjxNgpklV3B/F8=; b=zMJ1og9ibWBDy9QKZb64RDfhH7e8PgwmhfDXQ/197eQLwP2QGvnnkNenSUIzSqnM2i E6LWWk9y5Ij2CMoVS5UNtnHoaXg+EJmCvNr+3Rh9doXUAMuviLySJAW3d2mcoxlQcYlI xldmK9PTJQatnGKV7ZArek99pT7WuB97AEMTfyqYgGQ9fVFXYzF29HjG+O8dl8kRqh/s Zx/bDjgHW04C55T9ioT700WNtF5wYKfqxAW/vEW5+4uhRspDPq4XzASv9rWiTYc64V9T QgVwF/H53zU86ZyJXhSGpwbUqGrzaWSaNjOWLB/824qsd100PnfL5tFcM7F+w+PTn4qI 8FGg== MIME-Version: 1.0 X-Received: by 10.49.127.205 with SMTP id ni13mr24215584qeb.40.1385156341718; Fri, 22 Nov 2013 13:39:01 -0800 (PST) Sender: carpeddiem@gmail.com Received: by 10.224.87.135 with HTTP; Fri, 22 Nov 2013 13:39:01 -0800 (PST) In-Reply-To: References: Date: Fri, 22 Nov 2013 16:39:01 -0500 X-Google-Sender-Auth: VTXcp06mn9OHktBviLVhwZEQ7HA Message-ID: Subject: Re: NETDUMP ARM alignment fault fix From: Ed Maste To: Boris Astardzhiev Content-Type: text/plain; charset=ISO-8859-1 Cc: Attilio Rao , "freebsd-net@freebsd.org" , freebsd-arm@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2013 21:39:02 -0000 On 14 November 2013 01:34, Boris Astardzhiev wrote: > Hi, > > I've experienced some alignment faults using NETDUMP on the Sheevaplug ARM > board. > The function in question is netdump_send_arp(). I've attached a simple fix > to it and I'm posting it > as it might be of use to someone. Thanks for the patch. I've committed a simplified version in r258488. From owner-freebsd-net@FreeBSD.ORG Sat Nov 23 10:55:42 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 760B4B46; Sat, 23 Nov 2013 10:55:42 +0000 (UTC) Received: from cyrus.watson.org (cyrus.watson.org [198.74.231.69]) by mx1.freebsd.org (Postfix) with ESMTP id 4ED41221F; Sat, 23 Nov 2013 10:55:42 +0000 (UTC) Received: from fledge.watson.org (fledge.watson.org [198.74.231.63]) by cyrus.watson.org (Postfix) with ESMTPS id 4614146B3C; Sat, 23 Nov 2013 05:55:35 -0500 (EST) Date: Sat, 23 Nov 2013 10:55:34 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Adrian Chadd Subject: Re: svn commit: r258328 - head/sys/net In-Reply-To: Message-ID: References: <201311182258.rAIMwEFd048783@svn.freebsd.org> <023E719B-1059-4670-8556-EBAC18A2F007@freebsd.org> <20131121000245.GA30549@onelab2.iet.unipi.it> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: "src-committers@freebsd.org" , FreeBSD Net , "svn-src-all@freebsd.org" , George Neville-Neil , "freebsd-arch@freebsd.org" , "svn-src-head@freebsd.org" , Luigi Rizzo X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Nov 2013 10:55:42 -0000 On Wed, 20 Nov 2013, Adrian Chadd wrote: > We should migrate drivers to use a multi-input method where it's > appropriate. It's the same pain as if_transmit() is/was. > > I'd really like to avoid having hacky solutions like mbufs with magic types. > If we're going down that path, we should create a correct inline messaging > mechanism that includes arbitrary messages in the stream, where some may or > may not be mbufs. Magic mbufs just makes me want to tear out my eyes a > little. > > So, the reason I'd like to back it out is because we should be doing it via > a multi method with some type that represents an mbuf list. If George > doesn't mind, I'll add a multi input method, move this stuff into it, and > make ether_input just be single frames. My worry here is that the failure modes for easy oversights and bugs are quite subtle ones: mbuf leakage and data corruption. Our goal should be to shift as many as possible of those bugs to compiler-detected events (e.g., due to type checking), or where not possible, run-time detected events (e.g., due to easily detected non-NULL pointers). I'm OK with the current change staying in the tree for a few weeks on the path there, but I much prefer the world in which we use different symbols for different "types". This is especially important if we will have device driver vendors maintaining drivers across many versions (which we do): we really don't want a driver using ether_input for queue handoff in 11.x to just mysteriously leak mbufs in 10.x. Instead, the driver should fail to compile. Robert From owner-freebsd-net@FreeBSD.ORG Sat Nov 23 10:57:33 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E365CDCD; Sat, 23 Nov 2013 10:57:32 +0000 (UTC) Received: from cyrus.watson.org (cyrus.watson.org [198.74.231.69]) by mx1.freebsd.org (Postfix) with ESMTP id BD1DC223F; Sat, 23 Nov 2013 10:57:32 +0000 (UTC) Received: from fledge.watson.org (fledge.watson.org [198.74.231.63]) by cyrus.watson.org (Postfix) with ESMTPS id 61B7C46B3C; Sat, 23 Nov 2013 05:57:32 -0500 (EST) Date: Sat, 23 Nov 2013 10:57:31 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Julian Elischer Subject: Re: svn commit: r258328 - head/sys/net In-Reply-To: <528D6173.4080406@freebsd.org> Message-ID: References: <201311182258.rAIMwEFd048783@svn.freebsd.org> <528D6173.4080406@freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Adrian Chadd , "src-committers@freebsd.org" , FreeBSD Net , "svn-src-all@freebsd.org" , "George V. Neville-Neil" , "freebsd-arch@freebsd.org" , "svn-src-head@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Nov 2013 10:57:33 -0000 On Wed, 20 Nov 2013, Julian Elischer wrote: >> After that it'd be nice to write a set of mbuf list macros for abstract the >> whole queue, dequeue, concat, iterate, etc (like sys/queue.h, but for >> mbufs.) >> >> What do people think? >> >> (I've been doing it for m->next chained things, but not m->m_nextpkt >> things..) > > I was thinking: new interfaces.. (your -multi names sound good). macros for > handling said lists so that people don't screw them up Old drivers run with > no change. To me, the name "multi" is ambiguous: could be multicast. If we call the new datastructure "mbqueue" or "mqueue", then we should name the method ether_input_mbqueue or ether_input_mqueue. Robert > >> >> >> >> -adrian >> >> >> On 18 November 2013 14:58, George V. Neville-Neil wrote: >>> Author: gnn >>> Date: Mon Nov 18 22:58:14 2013 >>> New Revision: 258328 >>> URL: http://svnweb.freebsd.org/changeset/base/258328 >>> >>> Log: >>> Allow ethernet drivers to pass in packets connected via the nextpkt >>> pointer. >>> Handling packets in this way allows drivers to amortize work during >>> packet reception. >>> >>> Submitted by: Vijay Singh >>> Sponsored by: NetApp >>> >>> Modified: >>> head/sys/net/if_ethersubr.c >>> >>> Modified: head/sys/net/if_ethersubr.c >>> ============================================================================== >>> --- head/sys/net/if_ethersubr.c Mon Nov 18 22:55:50 2013 (r258327) >>> +++ head/sys/net/if_ethersubr.c Mon Nov 18 22:58:14 2013 (r258328) >>> @@ -708,13 +708,25 @@ static void >>> ether_input(struct ifnet *ifp, struct mbuf *m) >>> { >>> >>> + struct mbuf *mn; >>> + >>> /* >>> - * We will rely on rcvif being set properly in the deferred >>> context, >>> - * so assert it is correct here. >>> + * The drivers are allowed to pass in a chain of packets linked >>> with >>> + * m_nextpkt. We split them up into separate packets here and pass >>> + * them up. This allows the drivers to amortize the receive lock. >>> */ >>> - KASSERT(m->m_pkthdr.rcvif == ifp, ("%s: ifnet mismatch", >>> __func__)); >>> + while (m) { >>> + mn = m->m_nextpkt; >>> + m->m_nextpkt = NULL; >>> >>> - netisr_dispatch(NETISR_ETHER, m); >>> + /* >>> + * We will rely on rcvif being set properly in the >>> deferred context, >>> + * so assert it is correct here. >>> + */ >>> + KASSERT(m->m_pkthdr.rcvif == ifp, ("%s: ifnet mismatch", >>> __func__)); >>> + netisr_dispatch(NETISR_ETHER, m); >>> + m = mn; >>> + } >>> } >>> >>> /* > >