From owner-freebsd-ppc@FreeBSD.ORG Sun Sep 8 01:09:11 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A9843149; Sun, 8 Sep 2013 01:09:11 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-bk0-x22f.google.com (mail-bk0-x22f.google.com [IPv6:2a00:1450:4008:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1A2132E9A; Sun, 8 Sep 2013 01:09:10 +0000 (UTC) Received: by mail-bk0-f47.google.com with SMTP id mx12so1775810bkb.6 for ; Sat, 07 Sep 2013 18:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=r3yiAab7ZgqvoURdIfl5tm0rUbvosXdZbpv/2BQVKok=; b=Urmyqb6z0QGDrYTp0MmJdCL0fQVZ70jBvFi6mexqPxlFEkqMLM7+Zto3OM0lWBqmb4 F43osHqh4DkebksCYzHnE7qPV+MW1yaW2LW26nqQj/VvUlpTTNkKDamvzDjwLqnxCdkt v/dL5yy9rH63eu7utpCao8oLhvqYlfjnZbdbW4oOaVrPAg6Ojv4TJFIxf/9Sc0jGI26p b0TQHYfR4syyI3xIZhlpi8lCQSm/x+nE02uQ59uFJI8krTsvM4CP/EFLn/XhMoiZ48/D mOZDTseehsO9oWC1tAS9tiTm7GupRRVuMq46FgvRfkM3Qm/YvidkrzNdQsqLYUCfpZVw Hn0A== MIME-Version: 1.0 X-Received: by 10.204.123.199 with SMTP id q7mr8768728bkr.10.1378602549328; Sat, 07 Sep 2013 18:09:09 -0700 (PDT) Sender: chmeeedalf@gmail.com Received: by 10.205.13.199 with HTTP; Sat, 7 Sep 2013 18:09:09 -0700 (PDT) Date: Sat, 7 Sep 2013 18:09:09 -0700 X-Google-Sender-Auth: -IKAn4hTz6kaSky5oN-wU7cK3eA Message-ID: Subject: Kernel panic during page-out From: Justin Hibbits To: FreeBSD PowerPC ML , Nathan Whitehorn Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 01:09:11 -0000 I'm seeing a kernel panic on my G5, I think when it tries to page out to swap, with the message: Lock vm object not exclusively locked @ .../aim/mmu_oea64.c:1529 backtrace: .kdb_backtrace+0x5c .vpanic+0x13c .panic+0x38 .__rw_assert+0x184 .moea64_is_modified+0x54 .moea64_remove_all+0x78 .vm_pageout_object_deactivate_pages+0x2e4 .vm_daemon+0x358 .fork_exit+0xdc .fork_trampoline+0x10 This machine has 12GiB RAM, running r254922. - Justin From owner-freebsd-ppc@FreeBSD.ORG Sun Sep 8 02:23:44 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A73958CD; Sun, 8 Sep 2013 02:23:44 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) by mx1.freebsd.org (Postfix) with ESMTP id 6777B21DD; Sun, 8 Sep 2013 02:23:44 +0000 (UTC) Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57]) by alto.onthenet.com.au (Postfix) with ESMTPS id 5483D11BB0; Sun, 8 Sep 2013 12:23:41 +1000 (EST) Received: from Peters-MacBook-Pro.local (c-67-161-27-37.hsd1.ca.comcast.net [67.161.27.37]) by dommail.onthenet.com.au (MOS 4.2.4-GA) with ESMTP id BOM61519 (AUTH peterg@ptree32.com.au); Sun, 8 Sep 2013 12:23:40 +1000 Message-ID: <522BDFA5.8010803@freebsd.org> Date: Sat, 07 Sep 2013 19:23:33 -0700 From: Peter Grehan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Justin Hibbits Subject: Re: Kernel panic during page-out References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD PowerPC ML X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 02:23:44 -0000 Hi Justin, > I'm seeing a kernel panic on my G5, I think when it tries to page out to > swap, with the message: > > Lock vm object not exclusively locked @ .../aim/mmu_oea64.c:1529 > backtrace: > .kdb_backtrace+0x5c > .vpanic+0x13c > .panic+0x38 > .__rw_assert+0x184 > .moea64_is_modified+0x54 > .moea64_remove_all+0x78 > .vm_pageout_object_deactivate_pages+0x2e4 > .vm_daemon+0x358 > .fork_exit+0xdc > .fork_trampoline+0x10 > > This machine has 12GiB RAM, running r254922. This is the same panic I saw on the g5 imac when I only had 512MB of RAM - 'twas much too easy to reproduce. The fix is moea64_is_modified ... - VM_OBJECT_ASSERT_WLOCKED(m->object); + VM_OBJECT_ASSERT_LOCKED(m->object); This is consistent with locking higher up in the call chain. Apologies for not submitting that when I found it (and discussed it with Nathan). later, Peter. From owner-freebsd-ppc@FreeBSD.ORG Sun Sep 8 05:27:31 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 1C35ABFE; Sun, 8 Sep 2013 05:27:31 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-bk0-x236.google.com (mail-bk0-x236.google.com [IPv6:2a00:1450:4008:c01::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4F51629C2; Sun, 8 Sep 2013 05:27:30 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id mz12so1859964bkb.13 for ; Sat, 07 Sep 2013 22:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=D3KC+DySUZG4LUipFrJnmcB8osJXertEcRKpjxP5zJI=; b=M0j3DlR3sXW2ESZdZjFruki2e8OYbojPsRGYjqD0g8bk0Vp40v2ve64igJMYKww02N YcmW4ZPtQW3fExCqBK57usVOfUySCi6vPs3HCi0ezzMl4PXcS7gsuT9jegjeWU1OHACq grScfObQ6gb3EFPaKLvrWmtRMKrCUITbhZHxxDiVQTrlNtbHUPd2v3PC/fgSamr1Yig9 W2QbimeKK1xwSf03co1I331f3p0d9bu0SHexIFc+q3w9VghWLqKT1iY5iPDh/9mkXBGI hOdF0wrIUOUOw0Pf8ZDcHQZF9zC1cXZ8X9UGRkLdhCDvT8366piv9eRXwxdJ0ivdPrpu 0k5Q== MIME-Version: 1.0 X-Received: by 10.205.10.200 with SMTP id pb8mr9277687bkb.16.1378618048491; Sat, 07 Sep 2013 22:27:28 -0700 (PDT) Sender: chmeeedalf@gmail.com Received: by 10.205.13.199 with HTTP; Sat, 7 Sep 2013 22:27:28 -0700 (PDT) In-Reply-To: <522BDFA5.8010803@freebsd.org> References: <522BDFA5.8010803@freebsd.org> Date: Sat, 7 Sep 2013 22:27:28 -0700 X-Google-Sender-Auth: ZZC1iPFnlIpoRIaM1hLUD6aLaBI Message-ID: Subject: Re: Kernel panic during page-out From: Justin Hibbits To: Peter Grehan Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: FreeBSD PowerPC ML X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 05:27:31 -0000 Hi Peter On Sat, Sep 7, 2013 at 7:23 PM, Peter Grehan wrote: > Hi Justin, > > > I'm seeing a kernel panic on my G5, I think when it tries to page out to >> swap, with the message: >> >> Lock vm object not exclusively locked @ .../aim/mmu_oea64.c:1529 >> backtrace: >> .kdb_backtrace+0x5c >> .vpanic+0x13c >> .panic+0x38 >> .__rw_assert+0x184 >> .moea64_is_modified+0x54 >> .moea64_remove_all+0x78 >> .vm_pageout_object_deactivate_**pages+0x2e4 >> .vm_daemon+0x358 >> .fork_exit+0xdc >> .fork_trampoline+0x10 >> >> This machine has 12GiB RAM, running r254922. >> > > This is the same panic I saw on the g5 imac when I only had 512MB of RAM > - 'twas much too easy to reproduce. > > The fix is > > moea64_is_modified > ... > - VM_OBJECT_ASSERT_WLOCKED(m->**object); > + VM_OBJECT_ASSERT_LOCKED(m->**object); > > This is consistent with locking higher up in the call chain. Apologies > for not submitting that when I found it (and discussed it with Nathan). > > > later, > > Peter. > > If this is the correct fix, it should be pushed in through re@, and go into 10. Is this correct? I haven't checked the full locking on it. - Justin From owner-freebsd-ppc@FreeBSD.ORG Sun Sep 8 10:06:10 2013 Return-Path: Delivered-To: powerpc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CB33B9B5; Sun, 8 Sep 2013 10:06:10 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 8CE052591; Sun, 8 Sep 2013 10:06:10 +0000 (UTC) Received: from nine.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id 8F67645AA; Sun, 8 Sep 2013 10:06:09 +0000 (UTC) Received: by nine.des.no (Postfix, from userid 1001) id EBAF829463; Sun, 8 Sep 2013 12:05:42 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: src-committers@freebsd.org Subject: Re: svn commit: r255385 - in head/etc: . etc.amd64 References: <201309080946.r889kNSX050568@svn.freebsd.org> Date: Sun, 08 Sep 2013 12:05:42 +0200 In-Reply-To: <201309080946.r889kNSX050568@svn.freebsd.org> (Dag-Erling SmXXrgrav's message of "Sun, 8 Sep 2013 09:46:23 +0000 (UTC)") Message-ID: <86wqmrfx1l.fsf@nine.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, powerpc@freebsd.org X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 10:06:10 -0000 Dag-Erling SmXXrgrav writes: > Log: > Add a stock libmap32.conf for amd64. The first two lines have no effect > except to document the hardcoded standard library search path for 32-bit > binaries. The third line performs the equivalent substitution for the > private library directory. powerpc64 probably needs this as well, but I know next to nothing about it and have no way of testing it. How to test: % svn co -r255386 svn://svn.freebsd.org/base/head libprivate % cd libprivate % make TARGET=3Dfoo64 buildworld % sudo mkdir /foo64 % sudo make TARGET=3Dfoo64 installworld DESTDIR=3D/foo64 % sudo make TARGET=3Dfoo64 -C etc distribution DESTDIR=3D/foo64 % make TARGET=3Dfoo32 buildworld % sudo mkdir /foo64/32 % sudo make TARGET=3Dfoo32 installworld DESTDIR=3D/foo64/32 % sudo mount -t dev dev /foo64/dev % sudo chroot /foo64 /bin/sh % ldd /32/usr/bin/ssh With libmap32.conf in place, this should show that libssh.so.5 resolves to /usr/lib32/private/libssh.so.5; otherwise, it will show up as not found. (r255386 is the revision that made libssh private, prior to which there was no practical need for this mapping) DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no From owner-freebsd-ppc@FreeBSD.ORG Sun Sep 8 18:54:34 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 847AEC00; Sun, 8 Sep 2013 18:54:34 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtpauth2.wiscmail.wisc.edu (wmauth2.doit.wisc.edu [144.92.197.222]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5B61C2B8E; Sun, 8 Sep 2013 18:54:33 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth2.wiscmail.wisc.edu by smtpauth2.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MST00500LLPXM00@smtpauth2.wiscmail.wisc.edu>; Sun, 08 Sep 2013 13:54:26 -0500 (CDT) X-Spam-PmxInfo: Server=avs-2, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.9.8.184815, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from comporellon.tachypleus.net (adsl-76-208-67-185.dsl.mdsnwi.sbcglobal.net [76.208.67.185]) by smtpauth2.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MST00MQYLUOGE20@smtpauth2.wiscmail.wisc.edu>; Sun, 08 Sep 2013 13:54:26 -0500 (CDT) Message-id: <522CC7E0.9060508@freebsd.org> Date: Sun, 08 Sep 2013 13:54:24 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130810 Thunderbird/17.0.8 To: FreeBSD PowerPC ML , freebsd-arm@freebsd.org Subject: Patch for Cross-Reference Phandles X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 18:54:34 -0000 Open Firmware has three namespaces for handles: 1. Instance handles, for open devices 2. Package handles for the client interface 3. Package handles for device tree cross references On Powermac hardware, we assume that (2) and (3) are identical and call both phandles. On embedded FDT systems, you can't open devices and so we abuse ihandle_t for (3). IBM pSeries hardware, however, has all three things. With that in mind, I'd like to start separating them. The patch at http://people.freebsd.org/~nwhitehorn/xref_phandle.diff adds a new function (OF_child_xref_phandle) that takes a phandle of type (3) and turns into one of type (2) by searching for entries named "phandle", "ibm,phandle", or "linux,phandle" in the tree. This should work for FDT as well, but is not connected in the patch to anything actually FDT related. Comments would be appreciated. I'd like to get to get this as in as soon as possible (given the HEAD freeze) otherwise. -Nathan From owner-freebsd-ppc@FreeBSD.ORG Sun Sep 8 18:57:20 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 44CE9C7D; Sun, 8 Sep 2013 18:57:20 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) by mx1.freebsd.org (Postfix) with ESMTP id 043AE2BA7; Sun, 8 Sep 2013 18:57:19 +0000 (UTC) Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57]) by alto.onthenet.com.au (Postfix) with ESMTPS id 3C2881225E; Mon, 9 Sep 2013 04:57:19 +1000 (EST) Received: from Peters-MacBook-Pro.local (c-69-181-164-196.hsd1.ca.comcast.net [69.181.164.196]) by dommail.onthenet.com.au (MOS 4.2.4-GA) with ESMTP id BOM73264 (AUTH peterg@ptree32.com.au); Mon, 9 Sep 2013 04:57:18 +1000 Message-ID: <522CC88B.8040105@freebsd.org> Date: Sun, 08 Sep 2013 11:57:15 -0700 From: Peter Grehan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Justin Hibbits Subject: Re: Kernel panic during page-out References: <522BDFA5.8010803@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD PowerPC ML X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 18:57:20 -0000 Hi Justin, > If this is the correct fix, it should be pushed in through re@, and go into > 10. Is this correct? I haven't checked the full locking on it. Yes, certain it's correct based on other assertions in the same and similar call sequences, and it should go into 10 via re@. later, Peter. From owner-freebsd-ppc@FreeBSD.ORG Sun Sep 8 19:42:17 2013 Return-Path: Delivered-To: powerpc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E2E6E908; Sun, 8 Sep 2013 19:42:17 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtpauth2.wiscmail.wisc.edu (wmauth2.doit.wisc.edu [144.92.197.222]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B69FD2D88; Sun, 8 Sep 2013 19:42:17 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=UTF-8; format=flowed Received: from avs-daemon.smtpauth2.wiscmail.wisc.edu by smtpauth2.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MST00K00NUZF000@smtpauth2.wiscmail.wisc.edu>; Sun, 08 Sep 2013 14:42:16 -0500 (CDT) X-Spam-PmxInfo: Server=avs-2, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.9.8.193024, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from comporellon.tachypleus.net (adsl-76-208-67-185.dsl.mdsnwi.sbcglobal.net [76.208.67.185]) by smtpauth2.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MST00EUHO2FLN00@smtpauth2.wiscmail.wisc.edu>; Sun, 08 Sep 2013 14:42:16 -0500 (CDT) Message-id: <522CD317.1090605@freebsd.org> Date: Sun, 08 Sep 2013 14:42:15 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130810 Thunderbird/17.0.8 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= Subject: Re: svn commit: r255385 - in head/etc: . etc.amd64 References: <201309080946.r889kNSX050568@svn.freebsd.org> <86wqmrfx1l.fsf@nine.des.no> In-reply-to: <86wqmrfx1l.fsf@nine.des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, powerpc@freebsd.org X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 19:42:18 -0000 On 09/08/13 05:05, Dag-Erling Smørgrav wrote: > Dag-Erling SmXXrgrav writes: >> Log: >> Add a stock libmap32.conf for amd64. The first two lines have no effect >> except to document the hardcoded standard library search path for 32-bit >> binaries. The third line performs the equivalent substitution for the >> private library directory. > powerpc64 probably needs this as well, but I know next to nothing about > it and have no way of testing it. > > How to test: > > % svn co -r255386 svn://svn.freebsd.org/base/head libprivate > % cd libprivate > % make TARGET=foo64 buildworld > % sudo mkdir /foo64 > % sudo make TARGET=foo64 installworld DESTDIR=/foo64 > % sudo make TARGET=foo64 -C etc distribution DESTDIR=/foo64 > % make TARGET=foo32 buildworld > % sudo mkdir /foo64/32 > % sudo make TARGET=foo32 installworld DESTDIR=/foo64/32 > % sudo mount -t dev dev /foo64/dev > % sudo chroot /foo64 /bin/sh > % ldd /32/usr/bin/ssh > > With libmap32.conf in place, this should show that libssh.so.5 resolves > to /usr/lib32/private/libssh.so.5; otherwise, it will show up as not > found. > > (r255386 is the revision that made libssh private, prior to which there > was no practical need for this mapping) > > DES That works perfectly well on my powerpc64 box -- the binary's libraries and the executable runs flawlessly. Why is your stock libmap32.conf stuck in etc.amd64? It should be MI for all 64-bit platforms that support 32-bit binaries. -Nathan From owner-freebsd-ppc@FreeBSD.ORG Sun Sep 8 19:59:12 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B97DFDDE for ; Sun, 8 Sep 2013 19:59:12 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtpauth4.wiscmail.wisc.edu (wmauth4.doit.wisc.edu [144.92.197.145]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8EF842E19 for ; Sun, 8 Sep 2013 19:59:12 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth4.wiscmail.wisc.edu by smtpauth4.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MST00A00LCUKP00@smtpauth4.wiscmail.wisc.edu> for freebsd-ppc@freebsd.org; Sun, 08 Sep 2013 13:59:04 -0500 (CDT) X-Spam-PmxInfo: Server=avs-4, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.9.8.184815, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from comporellon.tachypleus.net (adsl-76-208-67-185.dsl.mdsnwi.sbcglobal.net [76.208.67.185]) by smtpauth4.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MST00I3CM2GTK20@smtpauth4.wiscmail.wisc.edu> for freebsd-ppc@freebsd.org; Sun, 08 Sep 2013 13:59:04 -0500 (CDT) Message-id: <522CC8F8.8060107@freebsd.org> Date: Sun, 08 Sep 2013 13:59:04 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130810 Thunderbird/17.0.8 To: freebsd-ppc@freebsd.org Subject: Re: Kernel panic during page-out References: <522BDFA5.8010803@freebsd.org> <522CC88B.8040105@freebsd.org> In-reply-to: <522CC88B.8040105@freebsd.org> X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 19:59:12 -0000 On 09/08/13 13:57, Peter Grehan wrote: > Hi Justin, > >> If this is the correct fix, it should be pushed in through re@, and >> go into >> 10. Is this correct? I haven't checked the full locking on it. > > Yes, certain it's correct based on other assertions in the same and > similar call sequences, and it should go into 10 via re@. > Are you going to handle the commit? You seem to be using the passive voice... -Nathan From owner-freebsd-ppc@FreeBSD.ORG Sun Sep 8 20:04:53 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id AED98305; Sun, 8 Sep 2013 20:04:53 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) by mx1.freebsd.org (Postfix) with ESMTP id 6D2132E8A; Sun, 8 Sep 2013 20:04:53 +0000 (UTC) Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57]) by alto.onthenet.com.au (Postfix) with ESMTPS id 59C0312226; Mon, 9 Sep 2013 06:04:51 +1000 (EST) Received: from Peters-MacBook-Pro.local (c-69-181-164-196.hsd1.ca.comcast.net [69.181.164.196]) by dommail.onthenet.com.au (MOS 4.2.4-GA) with ESMTP id BOM74103 (AUTH peterg@ptree32.com.au); Mon, 9 Sep 2013 06:04:50 +1000 Message-ID: <522CD85F.2070506@freebsd.org> Date: Sun, 08 Sep 2013 13:04:47 -0700 From: Peter Grehan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Nathan Whitehorn Subject: Re: Kernel panic during page-out References: <522BDFA5.8010803@freebsd.org> <522CC88B.8040105@freebsd.org> <522CC8F8.8060107@freebsd.org> In-Reply-To: <522CC8F8.8060107@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-ppc@freebsd.org X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 20:04:53 -0000 Hi Nathan, > Are you going to handle the commit? You seem to be using the passive > voice... Heavily involved in bhyve 10- activity so may not get to it. Might be best if Justin or yourself submits this. I wanted to verify on 32-bit first since the fix applies there as well, but ran out of time :( later, Peter. From owner-freebsd-ppc@FreeBSD.ORG Mon Sep 9 11:06:53 2013 Return-Path: Delivered-To: freebsd-ppc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 54B3EE2A for ; Mon, 9 Sep 2013 11:06:53 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 41D672A04 for ; Mon, 9 Sep 2013 11:06:53 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r89B6rad019084 for ; Mon, 9 Sep 2013 11:06:53 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r89B6qds018378 for freebsd-ppc@FreeBSD.org; Mon, 9 Sep 2013 11:06:52 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 9 Sep 2013 11:06:52 GMT Message-Id: <201309091106.r89B6qds018378@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-ppc@FreeBSD.org Subject: Current problem reports assigned to freebsd-ppc@FreeBSD.org X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Sep 2013 11:06:53 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o power/181502 ppc /usr/include/stdint.h 9.2-RC1/powerpc does not compile o power/180593 ppc PowerMac G5 shuts down when building pcre o power/178038 ppc clang++ fails to produce a binary in powerpc64 o power/175151 ppc Loader fails to load modules on PPC64 o power/170340 ppc Enabling geom-mirror on 9.1-powerpc64 prevents the sys o power/164225 ppc Boot fails on IBM 7028-6E1 (heap memory claim failed) o power/161947 ppc multimedia/libdvdnav builds broken binaries on big end o power/161045 ppc X doesn't detect ADB mouse up event until another even o power/149009 ppc sysinstall(8) on powerpc fails to install manpages, so o power/140241 ppc [kernel] [patch] Linker set problems on PowerPC EABI o power/135576 ppc gdb cannot debug threaded programs on ppc o power/133503 ppc [sound] Sound stutter after switching ttys o power/131548 ppc ofw_syscons no longer supports 32-bit framebuffer 13 problems total. From owner-freebsd-ppc@FreeBSD.ORG Wed Sep 11 18:02:53 2013 Return-Path: Delivered-To: powerpc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0FE7C58D; Wed, 11 Sep 2013 18:02:53 +0000 (UTC) (envelope-from tinderbox@freebsd.org) Received: from freebsd-current.sentex.ca (freebsd-current.sentex.ca [64.7.128.98]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C948D2CD0; Wed, 11 Sep 2013 18:02:52 +0000 (UTC) Received: from freebsd-current.sentex.ca (localhost [127.0.0.1]) by freebsd-current.sentex.ca (8.14.5/8.14.5) with ESMTP id r8BI2p6F096317; Wed, 11 Sep 2013 14:02:51 -0400 (EDT) (envelope-from tinderbox@freebsd.org) Received: (from tinderbox@localhost) by freebsd-current.sentex.ca (8.14.5/8.14.5/Submit) id r8BI2plK096309; Wed, 11 Sep 2013 18:02:51 GMT (envelope-from tinderbox@freebsd.org) Date: Wed, 11 Sep 2013 18:02:51 GMT Message-Id: <201309111802.r8BI2plK096309@freebsd-current.sentex.ca> X-Authentication-Warning: freebsd-current.sentex.ca: tinderbox set sender to FreeBSD Tinderbox using -f Sender: FreeBSD Tinderbox From: FreeBSD Tinderbox To: FreeBSD Tinderbox , , Subject: [head tinderbox] failure on powerpc/powerpc Precedence: bulk X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Sep 2013 18:02:53 -0000 TB --- 2013-09-11 15:20:35 - tinderbox 2.10 running on freebsd-current.sentex.ca TB --- 2013-09-11 15:20:35 - FreeBSD freebsd-current.sentex.ca 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #0: Mon Mar 26 13:54:12 EDT 2012 des@freebsd-current.sentex.ca:/usr/obj/usr/src/sys/GENERIC amd64 TB --- 2013-09-11 15:20:35 - starting HEAD tinderbox run for powerpc/powerpc TB --- 2013-09-11 15:20:35 - cleaning the object tree TB --- 2013-09-11 15:20:35 - /usr/local/bin/svn stat /src TB --- 2013-09-11 15:20:38 - At svn revision 255470 TB --- 2013-09-11 15:20:39 - building world TB --- 2013-09-11 15:20:39 - CROSS_BUILD_TESTING=YES TB --- 2013-09-11 15:20:39 - MAKEOBJDIRPREFIX=/obj TB --- 2013-09-11 15:20:39 - PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2013-09-11 15:20:39 - SRCCONF=/dev/null TB --- 2013-09-11 15:20:39 - TARGET=powerpc TB --- 2013-09-11 15:20:39 - TARGET_ARCH=powerpc TB --- 2013-09-11 15:20:39 - TZ=UTC TB --- 2013-09-11 15:20:39 - __MAKE_CONF=/dev/null TB --- 2013-09-11 15:20:39 - cd /src TB --- 2013-09-11 15:20:39 - /usr/bin/make -B buildworld >>> Building an up-to-date make(1) >>> World build started on Wed Sep 11 15:20:46 UTC 2013 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries >>> stage 4.3: make dependencies >>> stage 4.4: building everything >>> World build completed on Wed Sep 11 17:55:00 UTC 2013 TB --- 2013-09-11 17:55:00 - generating LINT kernel config TB --- 2013-09-11 17:55:00 - cd /src/sys/powerpc/conf TB --- 2013-09-11 17:55:00 - /usr/bin/make -B LINT TB --- 2013-09-11 17:55:00 - cd /src/sys/powerpc/conf TB --- 2013-09-11 17:55:00 - /usr/sbin/config -m LINT TB --- 2013-09-11 17:55:00 - building LINT kernel TB --- 2013-09-11 17:55:00 - CROSS_BUILD_TESTING=YES TB --- 2013-09-11 17:55:00 - MAKEOBJDIRPREFIX=/obj TB --- 2013-09-11 17:55:00 - PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2013-09-11 17:55:00 - SRCCONF=/dev/null TB --- 2013-09-11 17:55:00 - TARGET=powerpc TB --- 2013-09-11 17:55:00 - TARGET_ARCH=powerpc TB --- 2013-09-11 17:55:00 - TZ=UTC TB --- 2013-09-11 17:55:00 - __MAKE_CONF=/dev/null TB --- 2013-09-11 17:55:00 - cd /src TB --- 2013-09-11 17:55:00 - /usr/bin/make -B buildkernel KERNCONF=LINT >>> Kernel build for LINT started on Wed Sep 11 17:55:00 UTC 2013 >>> stage 1: configuring the kernel >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3.1: making dependencies >>> stage 3.2: building everything [...] cc -c -O -pipe -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=15000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-builtin -msoft-float -Wa,-many -fno-omit-frame-pointer -msoft-float -mno-altivec -ffreestanding -fstack-protector -Werror /src/sys/kern/uipc_shm.c cc -c -O -pipe -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=15000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-builtin -msoft-float -Wa,-many -fno-omit-frame-pointer -msoft-float -mno-altivec -ffreestanding -fstack-protector -Werror /src/sys/kern/uipc_sockbuf.c cc -c -O -pipe -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=15000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-builtin -msoft-float -Wa,-many -fno-omit-frame-pointer -msoft-float -mno-altivec -ffreestanding -fstack-protector -Werror /src/sys/kern/uipc_socket.c cc -c -O -pipe -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=15000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-builtin -msoft-float -Wa,-many -fno-omit-frame-pointer -msoft-float -mno-altivec -ffreestanding -fstack-protector -Werror /src/sys/kern/uipc_syscalls.c cc1: warnings being treated as errors /src/sys/kern/uipc_syscalls.c: In function 'vn_sendfile': /src/sys/kern/uipc_syscalls.c:2196: warning: 'obj_size' may be used uninitialized in this function /src/sys/kern/uipc_syscalls.c:2192: warning: 'pg' may be used uninitialized in this function *** Error code 1 Stop. bmake[1]: stopped in /obj/powerpc.powerpc/src/sys/LINT *** Error code 1 Stop. bmake: stopped in /src *** Error code 1 Stop in /src. TB --- 2013-09-11 18:02:51 - WARNING: /usr/bin/make returned exit code 1 TB --- 2013-09-11 18:02:51 - ERROR: failed to build LINT kernel TB --- 2013-09-11 18:02:51 - 8448.49 user 1065.09 system 9736.70 real http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-powerpc-powerpc.full From owner-freebsd-ppc@FreeBSD.ORG Thu Sep 12 15:07:22 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 1003D586; Thu, 12 Sep 2013 15:07:22 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtpauth3.wiscmail.wisc.edu (wmauth3.doit.wisc.edu [144.92.197.226]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D9D712944; Thu, 12 Sep 2013 15:07:21 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MT000L00OD6ZT00@smtpauth3.wiscmail.wisc.edu>; Thu, 12 Sep 2013 10:07:20 -0500 (CDT) X-Spam-PmxInfo: Server=avs-3, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.9.12.145714, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from comporellon.tachypleus.net (unknown [76.210.60.217]) by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MT0003B0Q067Q00@smtpauth3.wiscmail.wisc.edu>; Thu, 12 Sep 2013 10:07:19 -0500 (CDT) Message-id: <5231D8A6.9080501@freebsd.org> Date: Thu, 12 Sep 2013 10:07:18 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130907 Thunderbird/17.0.8 To: freebsd-ppc@freebsd.org, freebsd-arm@freebsd.org, freebsd-sparc64 Subject: Re: Patch for Cross-Reference Phandles References: <522CC7E0.9060508@freebsd.org> In-reply-to: <522CC7E0.9060508@freebsd.org> X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Sep 2013 15:07:22 -0000 On 09/08/13 13:54, Nathan Whitehorn wrote: > Open Firmware has three namespaces for handles: > 1. Instance handles, for open devices > 2. Package handles for the client interface > 3. Package handles for device tree cross references > > On Powermac hardware, we assume that (2) and (3) are identical and > call both phandles. On embedded FDT systems, you can't open devices > and so we abuse ihandle_t for (3). IBM pSeries hardware, however, has > all three things. With that in mind, I'd like to start separating > them. The patch at > http://people.freebsd.org/~nwhitehorn/xref_phandle.diff adds a new > function (OF_child_xref_phandle) that takes a phandle of type (3) and > turns into one of type (2) by searching for entries named "phandle", > "ibm,phandle", or "linux,phandle" in the tree. This should work for > FDT as well, but is not connected in the patch to anything actually > FDT related. > > Comments would be appreciated. I'd like to get to get this as in as > soon as possible (given the HEAD freeze) otherwise. > -Nathan Since I haven't heard anything, it shouldn't affect any existing platforms or code, and it would be nice to have this interface available in the 10.x series, I plan to ask re@ for commit approval tomorrow. Please let me know if there are any objections. -Nathan From owner-freebsd-ppc@FreeBSD.ORG Sat Sep 14 13:32:04 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 567CA3B3; Sat, 14 Sep 2013 13:32:04 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E5181273E; Sat, 14 Sep 2013 13:32:03 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.7/8.14.7/ALCHEMY.FRANKEN.DE) with ESMTP id r8EDVtJZ032862; Sat, 14 Sep 2013 15:31:56 +0200 (CEST) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.7/8.14.7/Submit) id r8EDVtC9032861; Sat, 14 Sep 2013 15:31:55 +0200 (CEST) (envelope-from marius) Date: Sat, 14 Sep 2013 15:31:55 +0200 From: Marius Strobl To: Nathan Whitehorn Subject: Re: Patch for Cross-Reference Phandles Message-ID: <20130914133155.GA32845@alchemy.franken.de> References: <522CC7E0.9060508@freebsd.org> <5231D8A6.9080501@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5231D8A6.9080501@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-arm@freebsd.org, freebsd-sparc64 , freebsd-ppc@freebsd.org X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 13:32:04 -0000 On Thu, Sep 12, 2013 at 10:07:18AM -0500, Nathan Whitehorn wrote: > On 09/08/13 13:54, Nathan Whitehorn wrote: > > Open Firmware has three namespaces for handles: > > 1. Instance handles, for open devices > > 2. Package handles for the client interface > > 3. Package handles for device tree cross references > > > > On Powermac hardware, we assume that (2) and (3) are identical and > > call both phandles. On embedded FDT systems, you can't open devices > > and so we abuse ihandle_t for (3). IBM pSeries hardware, however, has > > all three things. With that in mind, I'd like to start separating > > them. The patch at > > http://people.freebsd.org/~nwhitehorn/xref_phandle.diff adds a new > > function (OF_child_xref_phandle) that takes a phandle of type (3) and > > turns into one of type (2) by searching for entries named "phandle", > > "ibm,phandle", or "linux,phandle" in the tree. This should work for > > FDT as well, but is not connected in the patch to anything actually > > FDT related. > > > > Comments would be appreciated. I'd like to get to get this as in as > > soon as possible (given the HEAD freeze) otherwise. > > -Nathan > > Since I haven't heard anything, it shouldn't affect any existing > platforms or code, and it would be nice to have this interface available > in the 10.x series, I plan to ask re@ for commit approval tomorrow. > Please let me know if there are any objections. Technically that patch is fine. It would be nice if you could fix the style bugs before committing, though. In OF_child_xref_phandle(), the variables should go above the comment and you don't need to initialize the static global one in ofw_pcibus.c to zero explicitly. If you do nevertheless, spaces should go before and after the '='. Marius From owner-freebsd-ppc@FreeBSD.ORG Sat Sep 14 14:06:52 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 422EBD6D; Sat, 14 Sep 2013 14:06:52 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtpauth3.wiscmail.wisc.edu (wmauth3.doit.wisc.edu [144.92.197.226]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 185F2291E; Sat, 14 Sep 2013 14:06:51 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MT400J00CEVCB00@smtpauth3.wiscmail.wisc.edu>; Sat, 14 Sep 2013 09:06:43 -0500 (CDT) X-Spam-PmxInfo: Server=avs-3, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.9.14.135714, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from comporellon.tachypleus.net (unknown [76.210.60.217]) by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MT40038DCJ5JS20@smtpauth3.wiscmail.wisc.edu>; Sat, 14 Sep 2013 09:06:43 -0500 (CDT) Message-id: <52346D71.4080407@freebsd.org> Date: Sat, 14 Sep 2013 09:06:41 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130907 Thunderbird/17.0.8 To: Marius Strobl Subject: Re: Patch for Cross-Reference Phandles References: <522CC7E0.9060508@freebsd.org> <5231D8A6.9080501@freebsd.org> <20130914133155.GA32845@alchemy.franken.de> In-reply-to: <20130914133155.GA32845@alchemy.franken.de> Cc: freebsd-arm@freebsd.org, freebsd-sparc64 , freebsd-ppc@freebsd.org X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 14:06:52 -0000 On 09/14/13 08:31, Marius Strobl wrote: > On Thu, Sep 12, 2013 at 10:07:18AM -0500, Nathan Whitehorn wrote: >> On 09/08/13 13:54, Nathan Whitehorn wrote: >>> Open Firmware has three namespaces for handles: >>> 1. Instance handles, for open devices >>> 2. Package handles for the client interface >>> 3. Package handles for device tree cross references >>> >>> On Powermac hardware, we assume that (2) and (3) are identical and >>> call both phandles. On embedded FDT systems, you can't open devices >>> and so we abuse ihandle_t for (3). IBM pSeries hardware, however, has >>> all three things. With that in mind, I'd like to start separating >>> them. The patch at >>> http://people.freebsd.org/~nwhitehorn/xref_phandle.diff adds a new >>> function (OF_child_xref_phandle) that takes a phandle of type (3) and >>> turns into one of type (2) by searching for entries named "phandle", >>> "ibm,phandle", or "linux,phandle" in the tree. This should work for >>> FDT as well, but is not connected in the patch to anything actually >>> FDT related. >>> >>> Comments would be appreciated. I'd like to get to get this as in as >>> soon as possible (given the HEAD freeze) otherwise. >>> -Nathan >> Since I haven't heard anything, it shouldn't affect any existing >> platforms or code, and it would be nice to have this interface available >> in the 10.x series, I plan to ask re@ for commit approval tomorrow. >> Please let me know if there are any objections. > Technically that patch is fine. It would be nice if you could fix the > style bugs before committing, though. In OF_child_xref_phandle(), the > variables should go above the comment and you don't need to initialize > the static global one in ofw_pcibus.c to zero explicitly. If you do > nevertheless, spaces should go before and after the '='. > Thanks! I think the explicit zero initialization adds some clarity for people reading the code, so I'd like to keep it. The rest of the changes have been made. -Nathan From owner-freebsd-ppc@FreeBSD.ORG Sat Sep 14 15:43:33 2013 Return-Path: Delivered-To: freebsd-ppc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 53ABA4FF; Sat, 14 Sep 2013 15:43:33 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 008BB2CC5; Sat, 14 Sep 2013 15:43:29 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1VKs0O-000BuH-LE; Sat, 14 Sep 2013 15:43:28 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r8EFhPfO010734; Sat, 14 Sep 2013 09:43:25 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+MaafYJZuieIDvKxh91f/m Subject: Re: Patch for Cross-Reference Phandles From: Ian Lepore To: Nathan Whitehorn In-Reply-To: <52346D71.4080407@freebsd.org> References: <522CC7E0.9060508@freebsd.org> <5231D8A6.9080501@freebsd.org> <20130914133155.GA32845@alchemy.franken.de> <52346D71.4080407@freebsd.org> Content-Type: text/plain; charset="us-ascii" Date: Sat, 14 Sep 2013 09:43:25 -0600 Message-ID: <1379173405.1197.7.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: freebsd-arm@FreeBSD.org, freebsd-ppc@FreeBSD.org, freebsd-sparc64 , Marius Strobl X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 15:43:33 -0000 On Sat, 2013-09-14 at 09:06 -0500, Nathan Whitehorn wrote: > On 09/14/13 08:31, Marius Strobl wrote: > > On Thu, Sep 12, 2013 at 10:07:18AM -0500, Nathan Whitehorn wrote: > >> On 09/08/13 13:54, Nathan Whitehorn wrote: > >>> Open Firmware has three namespaces for handles: > >>> 1. Instance handles, for open devices > >>> 2. Package handles for the client interface > >>> 3. Package handles for device tree cross references > >>> > >>> On Powermac hardware, we assume that (2) and (3) are identical and > >>> call both phandles. On embedded FDT systems, you can't open devices > >>> and so we abuse ihandle_t for (3). IBM pSeries hardware, however, has > >>> all three things. With that in mind, I'd like to start separating > >>> them. The patch at > >>> http://people.freebsd.org/~nwhitehorn/xref_phandle.diff adds a new > >>> function (OF_child_xref_phandle) that takes a phandle of type (3) and > >>> turns into one of type (2) by searching for entries named "phandle", > >>> "ibm,phandle", or "linux,phandle" in the tree. This should work for > >>> FDT as well, but is not connected in the patch to anything actually > >>> FDT related. > >>> > >>> Comments would be appreciated. I'd like to get to get this as in as > >>> soon as possible (given the HEAD freeze) otherwise. > >>> -Nathan > >> Since I haven't heard anything, it shouldn't affect any existing > >> platforms or code, and it would be nice to have this interface available > >> in the 10.x series, I plan to ask re@ for commit approval tomorrow. > >> Please let me know if there are any objections. > > Technically that patch is fine. It would be nice if you could fix the > > style bugs before committing, though. In OF_child_xref_phandle(), the > > variables should go above the comment and you don't need to initialize > > the static global one in ofw_pcibus.c to zero explicitly. If you do > > nevertheless, spaces should go before and after the '='. > > > > Thanks! I think the explicit zero initialization adds some clarity for > people reading the code, so I'd like to keep it. The rest of the changes > have been made. > -Nathan The explicit zero init also makes it 4 bytes harder to fit the kernel into a small flash on embedded systems. We should be eliminating zero-inits that move items from bss to data, not adding new ones. -- Ian From owner-freebsd-ppc@FreeBSD.ORG Sat Sep 14 17:27:37 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 49583E7E; Sat, 14 Sep 2013 17:27:37 +0000 (UTC) (envelope-from jmg@h2.funkthat.com) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 211AB20D0; Sat, 14 Sep 2013 17:27:36 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id r8EHRZnU042249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 14 Sep 2013 10:27:36 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id r8EHRZRq042248; Sat, 14 Sep 2013 10:27:35 -0700 (PDT) (envelope-from jmg) Date: Sat, 14 Sep 2013 10:27:35 -0700 From: John-Mark Gurney To: Ian Lepore Subject: Re: Patch for Cross-Reference Phandles Message-ID: <20130914172735.GX68682@funkthat.com> Mail-Followup-To: Ian Lepore , Nathan Whitehorn , freebsd-arm@freebsd.org, freebsd-ppc@freebsd.org, freebsd-sparc64 References: <522CC7E0.9060508@freebsd.org> <5231D8A6.9080501@freebsd.org> <20130914133155.GA32845@alchemy.franken.de> <52346D71.4080407@freebsd.org> <1379173405.1197.7.camel@revolution.hippie.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1379173405.1197.7.camel@revolution.hippie.lan> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Sat, 14 Sep 2013 10:27:36 -0700 (PDT) Cc: freebsd-sparc64 , freebsd-arm@freebsd.org, freebsd-ppc@freebsd.org X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 17:27:37 -0000 Ian Lepore wrote this message on Sat, Sep 14, 2013 at 09:43 -0600: > On Sat, 2013-09-14 at 09:06 -0500, Nathan Whitehorn wrote: > > On 09/14/13 08:31, Marius Strobl wrote: > > > On Thu, Sep 12, 2013 at 10:07:18AM -0500, Nathan Whitehorn wrote: > > >> On 09/08/13 13:54, Nathan Whitehorn wrote: > > >>> Open Firmware has three namespaces for handles: > > >>> 1. Instance handles, for open devices > > >>> 2. Package handles for the client interface > > >>> 3. Package handles for device tree cross references > > >>> > > >>> On Powermac hardware, we assume that (2) and (3) are identical and > > >>> call both phandles. On embedded FDT systems, you can't open devices > > >>> and so we abuse ihandle_t for (3). IBM pSeries hardware, however, has > > >>> all three things. With that in mind, I'd like to start separating > > >>> them. The patch at > > >>> http://people.freebsd.org/~nwhitehorn/xref_phandle.diff adds a new > > >>> function (OF_child_xref_phandle) that takes a phandle of type (3) and > > >>> turns into one of type (2) by searching for entries named "phandle", > > >>> "ibm,phandle", or "linux,phandle" in the tree. This should work for > > >>> FDT as well, but is not connected in the patch to anything actually > > >>> FDT related. > > >>> > > >>> Comments would be appreciated. I'd like to get to get this as in as > > >>> soon as possible (given the HEAD freeze) otherwise. > > >>> -Nathan > > >> Since I haven't heard anything, it shouldn't affect any existing > > >> platforms or code, and it would be nice to have this interface available > > >> in the 10.x series, I plan to ask re@ for commit approval tomorrow. > > >> Please let me know if there are any objections. > > > Technically that patch is fine. It would be nice if you could fix the > > > style bugs before committing, though. In OF_child_xref_phandle(), the > > > variables should go above the comment and you don't need to initialize > > > the static global one in ofw_pcibus.c to zero explicitly. If you do > > > nevertheless, spaces should go before and after the '='. > > > > > > > Thanks! I think the explicit zero initialization adds some clarity for > > people reading the code, so I'd like to keep it. The rest of the changes > > have been made. > > -Nathan > > The explicit zero init also makes it 4 bytes harder to fit the kernel > into a small flash on embedded systems. We should be eliminating > zero-inits that move items from bss to data, not adding new ones. I just ran a simple test: int foo = 0; and compiled it, both with: FreeBSD clang version 3.3 (tags/RELEASE_33/final 183502) 20130610 Target: x86_64-unknown-freebsd10.0 Thread model: posix and: FreeBSD clang version 3.3 (trunk 178860) 20130405 Target: armv6--freebsd Thread model: posix and: gcc (GCC) 4.2.1 20070831 patched [FreeBSD] Copyright (C) 2007 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. all are smart enough to know that zero init is the same as locating it in bss, and do so... and not put it in data... Oh, these were all compiled w/o any options, just -c foo.c... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-ppc@FreeBSD.ORG Sat Sep 14 17:55:46 2013 Return-Path: Delivered-To: freebsd-ppc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 36196417; Sat, 14 Sep 2013 17:55:46 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E9B9021F7; Sat, 14 Sep 2013 17:55:45 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1VKu4O-00074h-Lj; Sat, 14 Sep 2013 17:55:44 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r8EHtfLF010841; Sat, 14 Sep 2013 11:55:41 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18HhcAWuRO6t29SuGbzw4AI Subject: Re: Patch for Cross-Reference Phandles From: Ian Lepore To: John-Mark Gurney In-Reply-To: <20130914172735.GX68682@funkthat.com> References: <522CC7E0.9060508@freebsd.org> <5231D8A6.9080501@freebsd.org> <20130914133155.GA32845@alchemy.franken.de> <52346D71.4080407@freebsd.org> <1379173405.1197.7.camel@revolution.hippie.lan> <20130914172735.GX68682@funkthat.com> Content-Type: text/plain; charset="us-ascii" Date: Sat, 14 Sep 2013 11:55:41 -0600 Message-ID: <1379181341.1197.26.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: freebsd-arm@FreeBSD.org, freebsd-sparc64 , freebsd-ppc@FreeBSD.org X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 17:55:46 -0000 On Sat, 2013-09-14 at 10:27 -0700, John-Mark Gurney wrote: > Ian Lepore wrote this message on Sat, Sep 14, 2013 at 09:43 -0600: > > On Sat, 2013-09-14 at 09:06 -0500, Nathan Whitehorn wrote: > > > On 09/14/13 08:31, Marius Strobl wrote: > > > > On Thu, Sep 12, 2013 at 10:07:18AM -0500, Nathan Whitehorn wrote: > > > >> On 09/08/13 13:54, Nathan Whitehorn wrote: > > > >>> Open Firmware has three namespaces for handles: > > > >>> 1. Instance handles, for open devices > > > >>> 2. Package handles for the client interface > > > >>> 3. Package handles for device tree cross references > > > >>> > > > >>> On Powermac hardware, we assume that (2) and (3) are identical and > > > >>> call both phandles. On embedded FDT systems, you can't open devices > > > >>> and so we abuse ihandle_t for (3). IBM pSeries hardware, however, has > > > >>> all three things. With that in mind, I'd like to start separating > > > >>> them. The patch at > > > >>> http://people.freebsd.org/~nwhitehorn/xref_phandle.diff adds a new > > > >>> function (OF_child_xref_phandle) that takes a phandle of type (3) and > > > >>> turns into one of type (2) by searching for entries named "phandle", > > > >>> "ibm,phandle", or "linux,phandle" in the tree. This should work for > > > >>> FDT as well, but is not connected in the patch to anything actually > > > >>> FDT related. > > > >>> > > > >>> Comments would be appreciated. I'd like to get to get this as in as > > > >>> soon as possible (given the HEAD freeze) otherwise. > > > >>> -Nathan > > > >> Since I haven't heard anything, it shouldn't affect any existing > > > >> platforms or code, and it would be nice to have this interface available > > > >> in the 10.x series, I plan to ask re@ for commit approval tomorrow. > > > >> Please let me know if there are any objections. > > > > Technically that patch is fine. It would be nice if you could fix the > > > > style bugs before committing, though. In OF_child_xref_phandle(), the > > > > variables should go above the comment and you don't need to initialize > > > > the static global one in ofw_pcibus.c to zero explicitly. If you do > > > > nevertheless, spaces should go before and after the '='. > > > > > > > > > > Thanks! I think the explicit zero initialization adds some clarity for > > > people reading the code, so I'd like to keep it. The rest of the changes > > > have been made. > > > -Nathan > > > > The explicit zero init also makes it 4 bytes harder to fit the kernel > > into a small flash on embedded systems. We should be eliminating > > zero-inits that move items from bss to data, not adding new ones. > > I just ran a simple test: > int foo = 0; > > and compiled it, both with: > FreeBSD clang version 3.3 (tags/RELEASE_33/final 183502) 20130610 > Target: x86_64-unknown-freebsd10.0 > Thread model: posix > > and: > FreeBSD clang version 3.3 (trunk 178860) 20130405 > Target: armv6--freebsd > Thread model: posix > > and: > gcc (GCC) 4.2.1 20070831 patched [FreeBSD] > Copyright (C) 2007 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > all are smart enough to know that zero init is the same as locating it > in bss, and do so... and not put it in data... Oh, these were all > compiled w/o any options, just -c foo.c... > Huh. That's pretty surprising to me, because IMO, an explicit zero-init is NOT the same as putting it in bss, it's explicitly a way to say "I want this in the data segment." I guess there are other ways to control placement these days. -- Ian From owner-freebsd-ppc@FreeBSD.ORG Sat Sep 14 23:56:41 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 64DFACAA; Sat, 14 Sep 2013 23:56:41 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wi0-x231.google.com (mail-wi0-x231.google.com [IPv6:2a00:1450:400c:c05::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 76E0522D1; Sat, 14 Sep 2013 23:56:40 +0000 (UTC) Received: by mail-wi0-f177.google.com with SMTP id cb5so2148200wib.4 for ; Sat, 14 Sep 2013 16:56:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=ZycrML/hIP2Sah54+NzJc9dtsEWQz87fPAXwIgL86FI=; b=O8wo6agX40agX2tJMcAVOcfiqHCa5JevI5OqeZ1A8AEapGUQ7hUcDcRdG+MN526Lsp +zQdYZae4BFWNiMFcYjw+Kp4KRu6ozZs0Be32TW3EULRYRzwLbBAalxU7W1RE5na1r82 bWQzyr4jXwtxscrnGxwd59G1M2MEhzGhRKzbGWcUtm2gyAQeH1o0HTDJ+5iVuCjISRDI B13CKbgk72hX2BWhb5o9gdvBoai4/Ey1TDtwzzGPdmcTQDRBHtWJZ75ZpyakX9Blu4F6 gfYC3v+3lpmFLy0q3LI3f0WMyGz26HKbomrqURGXIm0bWCEZvzU30/I8eub8NgIq1fN1 O0Yw== MIME-Version: 1.0 X-Received: by 10.180.211.206 with SMTP id ne14mr7879817wic.30.1379202998780; Sat, 14 Sep 2013 16:56:38 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.216.73.133 with HTTP; Sat, 14 Sep 2013 16:56:38 -0700 (PDT) In-Reply-To: <1379181341.1197.26.camel@revolution.hippie.lan> References: <522CC7E0.9060508@freebsd.org> <5231D8A6.9080501@freebsd.org> <20130914133155.GA32845@alchemy.franken.de> <52346D71.4080407@freebsd.org> <1379173405.1197.7.camel@revolution.hippie.lan> <20130914172735.GX68682@funkthat.com> <1379181341.1197.26.camel@revolution.hippie.lan> Date: Sat, 14 Sep 2013 16:56:38 -0700 X-Google-Sender-Auth: _CI1hHXjH1V6SuhYPJe4s_9MoYo Message-ID: Subject: Re: Patch for Cross-Reference Phandles From: Adrian Chadd To: Ian Lepore Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: John-Mark Gurney , FreeBSD PowerPC ML , "freebsd-arm@freebsd.org" , freebsd-sparc64 X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 23:56:41 -0000 ... holy crap. :-) erm, try writing some code that does something with it: int foo[2] = { 0, 0 }; main() { int i; for (i = 0; i < 2; i++) { foo[i] = i; } } .. and then make foo[2] be foo[512] and explicitly set it up to be zero'ed. see what happens. -a On 14 September 2013 10:55, Ian Lepore wrote: > On Sat, 2013-09-14 at 10:27 -0700, John-Mark Gurney wrote: > > Ian Lepore wrote this message on Sat, Sep 14, 2013 at 09:43 -0600: > > > On Sat, 2013-09-14 at 09:06 -0500, Nathan Whitehorn wrote: > > > > On 09/14/13 08:31, Marius Strobl wrote: > > > > > On Thu, Sep 12, 2013 at 10:07:18AM -0500, Nathan Whitehorn wrote: > > > > >> On 09/08/13 13:54, Nathan Whitehorn wrote: > > > > >>> Open Firmware has three namespaces for handles: > > > > >>> 1. Instance handles, for open devices > > > > >>> 2. Package handles for the client interface > > > > >>> 3. Package handles for device tree cross references > > > > >>> > > > > >>> On Powermac hardware, we assume that (2) and (3) are identical > and > > > > >>> call both phandles. On embedded FDT systems, you can't open > devices > > > > >>> and so we abuse ihandle_t for (3). IBM pSeries hardware, > however, has > > > > >>> all three things. With that in mind, I'd like to start separating > > > > >>> them. The patch at > > > > >>> http://people.freebsd.org/~nwhitehorn/xref_phandle.diff adds a > new > > > > >>> function (OF_child_xref_phandle) that takes a phandle of type > (3) and > > > > >>> turns into one of type (2) by searching for entries named > "phandle", > > > > >>> "ibm,phandle", or "linux,phandle" in the tree. This should work > for > > > > >>> FDT as well, but is not connected in the patch to anything > actually > > > > >>> FDT related. > > > > >>> > > > > >>> Comments would be appreciated. I'd like to get to get this as in > as > > > > >>> soon as possible (given the HEAD freeze) otherwise. > > > > >>> -Nathan > > > > >> Since I haven't heard anything, it shouldn't affect any existing > > > > >> platforms or code, and it would be nice to have this interface > available > > > > >> in the 10.x series, I plan to ask re@ for commit approval > tomorrow. > > > > >> Please let me know if there are any objections. > > > > > Technically that patch is fine. It would be nice if you could fix > the > > > > > style bugs before committing, though. In OF_child_xref_phandle(), > the > > > > > variables should go above the comment and you don't need to > initialize > > > > > the static global one in ofw_pcibus.c to zero explicitly. If you do > > > > > nevertheless, spaces should go before and after the '='. > > > > > > > > > > > > > Thanks! I think the explicit zero initialization adds some clarity > for > > > > people reading the code, so I'd like to keep it. The rest of the > changes > > > > have been made. > > > > -Nathan > > > > > > The explicit zero init also makes it 4 bytes harder to fit the kernel > > > into a small flash on embedded systems. We should be eliminating > > > zero-inits that move items from bss to data, not adding new ones. > > > > I just ran a simple test: > > int foo = 0; > > > > and compiled it, both with: > > FreeBSD clang version 3.3 (tags/RELEASE_33/final 183502) 20130610 > > Target: x86_64-unknown-freebsd10.0 > > Thread model: posix > > > > and: > > FreeBSD clang version 3.3 (trunk 178860) 20130405 > > Target: armv6--freebsd > > Thread model: posix > > > > and: > > gcc (GCC) 4.2.1 20070831 patched [FreeBSD] > > Copyright (C) 2007 Free Software Foundation, Inc. > > This is free software; see the source for copying conditions. There is > NO > > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR > PURPOSE. > > > > all are smart enough to know that zero init is the same as locating it > > in bss, and do so... and not put it in data... Oh, these were all > > compiled w/o any options, just -c foo.c... > > > > Huh. That's pretty surprising to me, because IMO, an explicit zero-init > is NOT the same as putting it in bss, it's explicitly a way to say "I > want this in the data segment." I guess there are other ways to control > placement these days. > > -- Ian > > > _______________________________________________ > freebsd-ppc@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ppc > To unsubscribe, send any mail to "freebsd-ppc-unsubscribe@freebsd.org" >