From owner-freebsd-rc@FreeBSD.ORG Sun Mar 3 11:05:38 2013 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B7568481; Sun, 3 Mar 2013 11:05:38 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ia0-x232.google.com (mail-ia0-x232.google.com [IPv6:2607:f8b0:4001:c02::232]) by mx1.freebsd.org (Postfix) with ESMTP id 38973F25; Sun, 3 Mar 2013 11:05:38 +0000 (UTC) Received: by mail-ia0-f178.google.com with SMTP id y26so3920705iab.37 for ; Sun, 03 Mar 2013 03:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=4pDEe/W0qGLSGf3N3iEpGrXlR//Zrgjot4Rz/Av3Va4=; b=hagMNypXxkqfhQII40SAdt9d9icg/jItjld4wuR5Uv2pSKRXaMObqwEfc3er2h+cLr /zsJwKj0UeJUPt2JG5Z0jkGRLGksQOvRfjnzei3ZCC4FQB36NC2TWODQmyoamVbk5rhE dY/1fjp2bRPjVrOIk2P22sWiSis+7G0+WPp0jMGJfDo25HBAixFvB6PDfrd63IDLF3XL q2hr5hP9plZSCGhZgKsIovVJBP7vWfNc4knRSmw2qph1ZyGeDfwMcfb2ph5g5+sSgegI rzqBh+3d6Ft3n6hjCASM/gMzdEpAh8Cj/E2beqIxjnGPe+izB5qCRfLN8SdUoY64l12d AfmQ== X-Received: by 10.42.155.136 with SMTP id u8mr12483995icw.26.1362308737670; Sun, 03 Mar 2013 03:05:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.63.12 with HTTP; Sun, 3 Mar 2013 03:05:07 -0800 (PST) In-Reply-To: References: <20121118.150935.240651183336258002.hrs@allbsd.org> <20130123.061642.1790268617280808873.hrs@allbsd.org> From: Chris Rees Date: Sun, 3 Mar 2013 11:05:07 +0000 Message-ID: Subject: Re: mountlate being too mount-happy To: Hiroki Sato Content-Type: text/plain; charset=ISO-8859-1 Cc: Mateusz Guzik , "freebsd-rc@freebsd.org" , Mateusz Guzik X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Mar 2013 11:05:38 -0000 On 22 January 2013 21:30, Chris Rees wrote: > On 22 January 2013 21:16, Hiroki Sato wrote: >> Chris Rees wrote >> in : >> >> ut> [dragging it up again!] >> ut> >> ut> On 18 November 2012 14:28, Chris Rees wrote: >> ut> > On 18 November 2012 06:09, Hiroki Sato wrote: >> ut> >> Mateusz Guzik wrote >> ut> >> in <20121118002245.GB15055@dft-labs.eu>: >> ut> >> >> ut> >> mj> On Sun, Nov 18, 2012 at 07:43:25AM +0900, Hiroki Sato wrote: >> ut> >> mj> > Chris Rees wrote >> ut> >> mj> > in < >> ut> CADLo839wqzAPenuQDOVpQ74yjCMkPQNceKpvs_N9XNwMLrkC1A@mail.gmail.com>: >> ut> >> mj> > >> ut> >> mj> > ut> On 2 November 2012 14:21, Eitan Adler >> ut> wrote: >> ut> >> mj> > ut> > On 2 November 2012 09:56, Chris Rees >> ut> wrote: >> ut> >> mj> > ut> >> I'll take a look. >> ut> >> mj> > ut> > >> ut> >> mj> > ut> > untested: >> ut> >> mj> > ut> >> ut> >> mj> > ut> Based on Eitan's patch, I've tested this one, and documented >> ut> it in mount(8) too: >> ut> >> mj> > ut> >> ut> >> mj> > ut> http://www.bayofrum.net/~crees/patches/mountonlylate.diff >> ut> >> mj> > ut> >> ut> >> mj> > ut> Does anyone have any suggestions/objections/urge to approve it? >> ut> >> mj> > >> ut> >> mj> > Is the original problem due to backgrounding of NFS mount only? If >> ut> >> mj> > so, implementing prevention of duplicate invocation into mount(8) >> ut> >> mj> > would be more reasonable, I think. >> ut> >> mj> > >> ut> >> mj> >> ut> >> mj> We have 2 distinct scripts that try to mount same set of filesystems. >> ut> >> mj> I think this is the real bug here and proposed patches makes it go >> ut> away in >> ut> >> mj> an IMHO acceptable way. >> ut> >> >> ut> >> I just wanted to make sure if the case is limited to background NFS >> ut> >> mount or not. >> ut> >> >> ut> >> rc.d/mountlate just tries to mount the filesystems that are not >> ut> >> mounted yet at that time in addition to the "late" ones, not always >> ut> >> to mount the same set twice. If it is a bug, it is better to simply >> ut> >> fix -l to exclude not-yet-mounted ones without "late" keyword than >> ut> >> adding another option. >> ut> > >> ut> > I don't think it's a bug as such-- -l option is clearly labelled in >> ut> > the manpage (emphasis mine): >> ut> > >> ut> > When used in conjunction with the -a option, *also* mount those >> ut> > file systems which are marked as ``late''. >> ut> > >> ut> > I think that for POLA and to avoid changing behaviour of an option >> ut> > that's been there a long time we need the -L option. >> ut> > >> ut> > I disagree with Mateusz here-- split operations in rc makes two >> ut> > scripts necessary; mount and mountlate are two separate operations, >> ut> > done at different times. >> ut> >> ut> Hiroki-san, do you still believe that changing the behaviour of -l is the >> ut> correct way to go, rather than add a -L option for only late filesystems? >> ut> (mount -la currently mounts *all* filesystems, you suggested to change to >> ut> just late). >> ut> >> ut> I'd like to fix this, but I want to make sure you're happy with the >> ut> solution. >> >> Sorry for being unresponsive. Can you give me a couple of days to >> double-check the behavior? > > That'd be fantastic, thank you. > Ping? :) Chris From owner-freebsd-rc@FreeBSD.ORG Mon Mar 4 11:06:48 2013 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E08D2F25 for ; Mon, 4 Mar 2013 11:06:48 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id D22DCE5F for ; Mon, 4 Mar 2013 11:06:48 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r24B6mi3038887 for ; Mon, 4 Mar 2013 11:06:48 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r24B6mlI038884 for freebsd-rc@FreeBSD.org; Mon, 4 Mar 2013 11:06:48 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 4 Mar 2013 11:06:48 GMT Message-Id: <201303041106.r24B6mlI038884@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2013 11:06:48 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/176347 rc [rc.conf] [patch] Add support for firewall deny lists o conf/176181 rc [rc.subr] rc.subr emitting warnings for non-defined xx o conf/175311 rc [patch] add "dump" fs type support to rc.d/dumpon o conf/175105 rc /etc/rc.d/* and more: syntax 'return_boolean_cmd && do o conf/175079 rc [rc.subr] [patch] rc.subr poorly handles recursive run o conf/174595 rc /etc/rc.d/sysctl : unknown oid 'XXX' [regression] o bin/173153 rc [rc.d] [patch] $netwait_ip should be more parallel o conf/172787 rc [rc.conf] FreeBSD 9.x broken alias syntax on vlan inte o conf/172532 rc [rc] [patch] service routing restart always fails o conf/169047 rc [rc.subr] [patch] /etc/rc.subr not checking some scrip o bin/168544 rc [patch] [rc]: addswap-mounted swapfiles cause panic on o conf/167566 rc [rc.d] [patch] ipdivert module loading vs. ipfw rc.d o o conf/166484 rc [rc] [patch] rc.initdiskless patch for different major o conf/165769 rc [rc][jai][ipv6] IPv6 Initialization on external iface o conf/164393 rc [rc.d] restarting netif with static addresses doesn't o conf/163508 rc [rc.subr] [patch] Add "enable" and "disable" commands o conf/163488 rc Confusing explanation in defaults/rc.conf o conf/163321 rc [rc.conf] [patch] allow _fib syntax in rc.conf o conf/162642 rc .sh scripts in /usr/local/etc/rc.d get executed, not s o conf/161107 rc [rc] stop_boot in mountcritlocal usage is incorrect. o conf/160403 rc [rc] [patch] concurrently running rc-scripts during bo o conf/160240 rc rc.d/mdconfig and mdconfig2 should autoset $_type to v o conf/159846 rc [rc.conf] routing_stop_inet6() logic doesn't handle ip o conf/158557 rc [patch] /etc/rc.d/pf broken messages o conf/158127 rc [patch] remount_optional option in rc.initdiskless doe o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances a conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip p conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). p conf/123119 rc [patch] rc script for ipfw does not handle IPv6 o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug a conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses f conf/118255 rc savecore never finding kernel core dumps (rcorder prob f conf/117935 rc [patch] ppp fails to start at boot because of missing f conf/113915 rc [ndis] [patch] ndis wireless driver fails to associate o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p f conf/105689 rc [ppp] [request] syslogd starts too late at boot f conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp f conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d f conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle a conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi a conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} f conf/56934 rc [patch] rc.firewall rules for natd expect an interface 86 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Mar 4 20:58:23 2013 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D235D606 for ; Mon, 4 Mar 2013 20:58:23 +0000 (UTC) (envelope-from lkchen@k-state.edu) Received: from ksu-out.merit.edu (ksu-out.merit.edu [207.75.117.133]) by mx1.freebsd.org (Postfix) with ESMTP id 9FADF14AE for ; Mon, 4 Mar 2013 20:58:23 +0000 (UTC) X-Merit-ExtLoop1: 1 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgEFAJ0JNVHPS3TT/2dsb2JhbABEFoY6vQ4Wc4IfAQEBBAECIGIPGAICDRkCIwcvGRuHZgMPDKEajlWIXw1MiDqBI4sifBUGg2WBEwOIbIseXY0zhRiDJoFLCRce X-IronPort-AV: E=Sophos;i="4.84,781,1355115600"; d="scan'208";a="75974386" X-MERIT-SOURCE: KSU Received: from ksu-sfpop-mailstore02.merit.edu ([207.75.116.211]) by sfpop-ironport01.merit.edu with ESMTP; 04 Mar 2013 15:58:16 -0500 Date: Mon, 4 Mar 2013 15:58:16 -0500 (EST) From: "Lawrence K. Chen, P.Eng." To: freebsd-rc@freebsd.org Message-ID: <1069563317.22488674.1362430696968.JavaMail.root@k-state.edu> In-Reply-To: Subject: Re: mountlate being too mount-happy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [129.130.0.181] X-Mailer: Zimbra 7.2.2_GA_2852 (ZimbraWebClient - GC25 ([unknown])/7.2.2_GA_2852) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2013 20:58:23 -0000 ----- Original Message ----- > On 22 January 2013 21:30, Chris Rees wrote: > > On 22 January 2013 21:16, Hiroki Sato wrote: > >> Chris Rees wrote > >> in > >> : > >> > >> ut> [dragging it up again!] > >> ut> > >> ut> On 18 November 2012 14:28, Chris Rees > >> wrote: > >> ut> > On 18 November 2012 06:09, Hiroki Sato > >> wrote: > >> ut> >> Mateusz Guzik wrote > >> ut> >> in <20121118002245.GB15055@dft-labs.eu>: > >> ut> >> > >> ut> >> mj> On Sun, Nov 18, 2012 at 07:43:25AM +0900, Hiroki Sato > >> wrote: > >> ut> >> mj> > Chris Rees wrote > >> ut> >> mj> > in < > >> ut> > >> CADLo839wqzAPenuQDOVpQ74yjCMkPQNceKpvs_N9XNwMLrkC1A@mail.gmail.com>: > >> ut> >> mj> > > >> ut> >> mj> > ut> On 2 November 2012 14:21, Eitan Adler > >> > >> ut> wrote: > >> ut> >> mj> > ut> > On 2 November 2012 09:56, Chris Rees > >> > >> ut> wrote: > >> ut> >> mj> > ut> >> I'll take a look. > >> ut> >> mj> > ut> > > >> ut> >> mj> > ut> > untested: > >> ut> >> mj> > ut> > >> ut> >> mj> > ut> Based on Eitan's patch, I've tested this one, and > >> documented > >> ut> it in mount(8) too: > >> ut> >> mj> > ut> > >> ut> >> mj> > ut> > >> http://www.bayofrum.net/~crees/patches/mountonlylate.diff > >> ut> >> mj> > ut> > >> ut> >> mj> > ut> Does anyone have any suggestions/objections/urge > >> to approve it? > >> ut> >> mj> > > >> ut> >> mj> > Is the original problem due to backgrounding of NFS > >> mount only? If > >> ut> >> mj> > so, implementing prevention of duplicate invocation > >> into mount(8) > >> ut> >> mj> > would be more reasonable, I think. > >> ut> >> mj> > > >> ut> >> mj> > >> ut> >> mj> We have 2 distinct scripts that try to mount same set > >> of filesystems. > >> ut> >> mj> I think this is the real bug here and proposed patches > >> makes it go > >> ut> away in > >> ut> >> mj> an IMHO acceptable way. > >> ut> >> > >> ut> >> I just wanted to make sure if the case is limited to > >> background NFS > >> ut> >> mount or not. > >> ut> >> > >> ut> >> rc.d/mountlate just tries to mount the filesystems that are > >> not > >> ut> >> mounted yet at that time in addition to the "late" ones, > >> not always > >> ut> >> to mount the same set twice. If it is a bug, it is better > >> to simply > >> ut> >> fix -l to exclude not-yet-mounted ones without "late" > >> keyword than > >> ut> >> adding another option. > >> ut> > > >> ut> > I don't think it's a bug as such-- -l option is clearly > >> labelled in > >> ut> > the manpage (emphasis mine): > >> ut> > > >> ut> > When used in conjunction with the -a option, *also* mount > >> those > >> ut> > file systems which are marked as ``late''. > >> ut> > > >> ut> > I think that for POLA and to avoid changing behaviour of an > >> option > >> ut> > that's been there a long time we need the -L option. > >> ut> > > >> ut> > I disagree with Mateusz here-- split operations in rc makes > >> two > >> ut> > scripts necessary; mount and mountlate are two separate > >> operations, > >> ut> > done at different times. > >> ut> > >> ut> Hiroki-san, do you still believe that changing the behaviour > >> of -l is the > >> ut> correct way to go, rather than add a -L option for only late > >> filesystems? > >> ut> (mount -la currently mounts *all* filesystems, you suggested > >> to change to > >> ut> just late). > >> ut> > >> ut> I'd like to fix this, but I want to make sure you're happy > >> with the > >> ut> solution. > >> > >> Sorry for being unresponsive. Can you give me a couple of days > >> to > >> double-check the behavior? > > > > That'd be fantastic, thank you. > > > > Ping? > > :) > > Chris Hmmm, I forgot about this annoyance....had two problems with mountlate....it runs too early (only like a couple of rc scripts after the first mount) and the nfs background issue. I mount nfs filesystems from a VM on my FreeBSD system, so mountlate needs to come sufficiently after the VM starts. Making the VM startup be "BEFORE: mountlate" caused some other problem that I forget. Now that I think of it, it wonder if there's something that depends on /compat/linux/proc and/or /compat/linux/sys...but doesn't specify it in its rc script. And, using nfs background would cause them to happen twice. I ended up taking the nfs mounts out of fstab and doing the nfs background mounts in rc.local. Lawrence