From owner-freebsd-rc@FreeBSD.ORG Mon Apr 1 11:06:49 2013 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id CDABE8EF for ; Mon, 1 Apr 2013 11:06:49 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id BE3C7340 for ; Mon, 1 Apr 2013 11:06:49 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r31B6nWX033778 for ; Mon, 1 Apr 2013 11:06:49 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r31B6nSg033776 for freebsd-rc@FreeBSD.org; Mon, 1 Apr 2013 11:06:49 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 1 Apr 2013 11:06:49 GMT Message-Id: <201304011106.r31B6nSg033776@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 11:06:49 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/177217 rc [patch] rc.d/ddb -- squelch warning when ddb_enable=ye o conf/177089 rc ntpd startup script does not work well o conf/176347 rc [rc.conf] [patch] Add support for firewall deny lists o conf/176181 rc [rc.subr] rc.subr emitting warnings for non-defined xx o conf/175311 rc [patch] add "dump" fs type support to rc.d/dumpon o conf/175105 rc /etc/rc.d/* and more: syntax 'return_boolean_cmd && do o conf/175079 rc [rc.subr] [patch] rc.subr poorly handles recursive run o bin/173153 rc [rc.d] [patch] $netwait_ip should be more parallel o conf/172787 rc [rc.conf] FreeBSD 9.x broken alias syntax on vlan inte o conf/172532 rc [rc] [patch] service routing restart always fails o conf/169047 rc [rc.subr] [patch] /etc/rc.subr not checking some scrip o bin/168544 rc [patch] [rc]: addswap-mounted swapfiles cause panic on o conf/167566 rc [rc.d] [patch] ipdivert module loading vs. ipfw rc.d o o conf/166484 rc [rc] [patch] rc.initdiskless patch for different major o conf/165769 rc [rc][jai][ipv6] IPv6 Initialization on external iface o conf/164393 rc [rc.d] restarting netif with static addresses doesn't o conf/163508 rc [rc.subr] [patch] Add "enable" and "disable" commands o conf/163488 rc Confusing explanation in defaults/rc.conf o conf/163321 rc [rc.conf] [patch] allow _fib syntax in rc.conf o conf/162642 rc .sh scripts in /usr/local/etc/rc.d get executed, not s o conf/161107 rc [rc] stop_boot in mountcritlocal usage is incorrect. o conf/160403 rc [rc] [patch] concurrently running rc-scripts during bo o conf/160240 rc rc.d/mdconfig and mdconfig2 should autoset $_type to v o conf/159846 rc [rc.conf] routing_stop_inet6() logic doesn't handle ip o conf/158557 rc [patch] /etc/rc.d/pf broken messages o conf/158127 rc [patch] remount_optional option in rc.initdiskless doe o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances a conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip p conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug a conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses f conf/118255 rc savecore never finding kernel core dumps (rcorder prob f conf/117935 rc [patch] ppp fails to start at boot because of missing f conf/113915 rc [ndis] [patch] ndis wireless driver fails to associate o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p f conf/105689 rc [ppp] [request] syslogd starts too late at boot f conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp f conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d f conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle a conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi a conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} f conf/56934 rc [patch] rc.firewall rules for natd expect an interface f conf/13775 rc multi-user boot may hang in NIS environment 87 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Apr 1 19:01:57 2013 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 10010D50; Mon, 1 Apr 2013 19:01:57 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) by mx1.freebsd.org (Postfix) with ESMTP id E337D9C7; Mon, 1 Apr 2013 19:01:56 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 47BFAB960; Mon, 1 Apr 2013 15:01:56 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org Subject: Re: rc.subr: disabling globbing while processing devfs rules Date: Mon, 1 Apr 2013 14:06:50 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <514D6AC5.8010409@FreeBSD.org> In-Reply-To: <514D6AC5.8010409@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201304011406.50417.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 01 Apr 2013 15:01:56 -0400 (EDT) Cc: freebsd-rc@freebsd.org, Andriy Gapon X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 19:01:57 -0000 On Saturday, March 23, 2013 4:41:41 am Andriy Gapon wrote: > > Any objections / concerns for the following change? > > An example. > This rule in devfs.rules: > add path da* mode 660 group operator > and this directory: > /data > result in the following rule being actually installed: > 100 path data group operator mode 660 > > Of course, I could refine the pattern in the rule, but I shouldn't have to do > it, because the pattern is for /dev/ entries, not arbitrary files in the > filesystem namespace. > > commit 7ce5e9ca5c107e2669f18efa472c1ab14999247c > Author: Andriy Gapon > Date: Sat Mar 23 10:29:39 2013 +0200 > > rc.subr: disabling globbing while processing devfs rules in > devfs_rulesets_from_file() > > The rules themselves typically have shell-like patterns and it is incorrect > when they get replaced with matching filesystem entries. > > Shell magic by: jilles > > diff --git a/etc/rc.subr b/etc/rc.subr > index f37ede7..9952c82 100644 > --- a/etc/rc.subr > +++ b/etc/rc.subr > @@ -1301,7 +1301,7 @@ make_symlink() > # > devfs_rulesets_from_file() > { > - local file _err _me > + local file _err _me _opts > file="$1" > _me="devfs_rulesets_from_file" > _err=0 > @@ -1314,6 +1314,11 @@ devfs_rulesets_from_file() > debug "$_me: no such file ($file)" > return 0 > fi > + > + # Disable globbing so that the rule patterns are not expanded > + # by accident with matching filesystem entries. > + _opts=$-; set -f > + > debug "reading rulesets from file ($file)" > { while read line > do > @@ -1360,6 +1365,7 @@ devfs_rulesets_from_file() > break > fi > done } < $file > + case $_opts in *f*) ;; *) set +f ;; esac > return $_err > } Why not use 'local -' instead of the $- magic? That is: devfs_rulesets_from_file() { local file _err _me - ... set -f ... } That would seem to be simpler. -- John Baldwin From owner-freebsd-rc@FreeBSD.ORG Mon Apr 1 19:56:20 2013 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id A1A4B81D; Mon, 1 Apr 2013 19:56:20 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (unknown [IPv6:2001:610:1108:5012::107]) by mx1.freebsd.org (Postfix) with ESMTP id 6C1AAD4D; Mon, 1 Apr 2013 19:56:20 +0000 (UTC) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mx1.stack.nl (Postfix) with ESMTP id B17BE1203CC; Mon, 1 Apr 2013 21:56:04 +0200 (CEST) Received: by snail.stack.nl (Postfix, from userid 1677) id 82D3B2848C; Mon, 1 Apr 2013 21:56:01 +0200 (CEST) Date: Mon, 1 Apr 2013 21:56:01 +0200 From: Jilles Tjoelker To: John Baldwin Subject: Re: rc.subr: disabling globbing while processing devfs rules Message-ID: <20130401195601.GA47384@stack.nl> References: <514D6AC5.8010409@FreeBSD.org> <201304011406.50417.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201304011406.50417.jhb@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-current@freebsd.org, freebsd-rc@freebsd.org, Andriy Gapon X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 19:56:20 -0000 On Mon, Apr 01, 2013 at 02:06:50PM -0400, John Baldwin wrote: > Why not use 'local -' instead of the $- magic? That is: > devfs_rulesets_from_file() > { > local file _err _me - > > ... > set -f > ... > } > That would seem to be simpler. I had mentioned this possibility on IRC, but this feature is specific to Almquist-derived shells (ash) and so something more portable was selected. (It's still not standard because POSIX does not specify "local" but it works on most shells in use.) -- Jilles Tjoelker From owner-freebsd-rc@FreeBSD.ORG Mon Apr 1 20:17:05 2013 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 0A6C01F7; Mon, 1 Apr 2013 20:17:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) by mx1.freebsd.org (Postfix) with ESMTP id DC422E34; Mon, 1 Apr 2013 20:17:04 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id EF67EB977; Mon, 1 Apr 2013 16:17:03 -0400 (EDT) From: John Baldwin To: Jilles Tjoelker Subject: Re: rc.subr: disabling globbing while processing devfs rules Date: Mon, 1 Apr 2013 16:16:15 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <514D6AC5.8010409@FreeBSD.org> <201304011406.50417.jhb@freebsd.org> <20130401195601.GA47384@stack.nl> In-Reply-To: <20130401195601.GA47384@stack.nl> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201304011616.15191.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 01 Apr 2013 16:17:04 -0400 (EDT) Cc: freebsd-current@freebsd.org, freebsd-rc@freebsd.org, Andriy Gapon X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 20:17:05 -0000 On Monday, April 01, 2013 3:56:01 pm Jilles Tjoelker wrote: > On Mon, Apr 01, 2013 at 02:06:50PM -0400, John Baldwin wrote: > > Why not use 'local -' instead of the $- magic? That is: > > > devfs_rulesets_from_file() > > { > > local file _err _me - > > > > ... > > set -f > > ... > > } > > > That would seem to be simpler. > > I had mentioned this possibility on IRC, but this feature is specific to > Almquist-derived shells (ash) and so something more portable was > selected. (It's still not standard because POSIX does not specify > "local" but it works on most shells in use.) rc.subr isn't meant to be portable, it's a script that is part of the FreeBSD base system. I find the 'local -' syntax more readable (and used the feature quite a bit in etcupdate). -- John Baldwin From owner-freebsd-rc@FreeBSD.ORG Mon Apr 1 20:30:18 2013 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id EF5EE76D; Mon, 1 Apr 2013 20:30:18 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id D085BEF3; Mon, 1 Apr 2013 20:30:16 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id XAA28419; Mon, 01 Apr 2013 23:30:15 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1UMlMt-0006Ta-0F; Mon, 01 Apr 2013 23:30:15 +0300 Message-ID: <5159EE54.8070906@FreeBSD.org> Date: Mon, 01 Apr 2013 23:30:12 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130321 Thunderbird/17.0.4 MIME-Version: 1.0 To: John Baldwin Subject: Re: rc.subr: disabling globbing while processing devfs rules References: <514D6AC5.8010409@FreeBSD.org> <201304011406.50417.jhb@freebsd.org> <20130401195601.GA47384@stack.nl> <201304011616.15191.jhb@freebsd.org> In-Reply-To: <201304011616.15191.jhb@freebsd.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org, freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 20:30:19 -0000 on 01/04/2013 23:16 John Baldwin said the following: > On Monday, April 01, 2013 3:56:01 pm Jilles Tjoelker wrote: >> On Mon, Apr 01, 2013 at 02:06:50PM -0400, John Baldwin wrote: >>> Why not use 'local -' instead of the $- magic? That is: >> >>> devfs_rulesets_from_file() >>> { >>> local file _err _me - >>> >>> ... >>> set -f >>> ... >>> } >> >>> That would seem to be simpler. >> >> I had mentioned this possibility on IRC, but this feature is specific to >> Almquist-derived shells (ash) and so something more portable was >> selected. (It's still not standard because POSIX does not specify >> "local" but it works on most shells in use.) > > rc.subr isn't meant to be portable, it's a script that is part of the FreeBSD > base system. I find the 'local -' syntax more readable (and used the feature > quite a bit in etcupdate). > You have to set an example in etc/ :-) I used a script in etc/rc.d as a starting point, Jilles guided me from there. -- Andriy Gapon