From owner-freebsd-rc@FreeBSD.ORG Mon Jun 3 11:06:51 2013 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 681BA5DF for ; Mon, 3 Jun 2013 11:06:51 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 5693613C0 for ; Mon, 3 Jun 2013 11:06:51 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r53B6pUM015145 for ; Mon, 3 Jun 2013 11:06:51 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r53B6ouh015143 for freebsd-rc@FreeBSD.org; Mon, 3 Jun 2013 11:06:50 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 3 Jun 2013 11:06:50 GMT Message-Id: <201306031106.r53B6ouh015143@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2013 11:06:51 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/177217 rc [patch] rc.d/ddb -- squelch warning when ddb_enable=ye o conf/177089 rc ntpd startup script does not work well o conf/176347 rc [rc.conf] [patch] Add support for firewall deny lists o conf/176181 rc [rc.subr] rc.subr emitting warnings for non-defined xx o conf/175311 rc [patch] add "dump" fs type support to rc.d/dumpon o conf/175105 rc /etc/rc.d/* and more: syntax 'return_boolean_cmd && do o conf/175079 rc [rc.subr] [patch] rc.subr poorly handles recursive run o bin/173153 rc [rc.d] [patch] $netwait_ip should be more parallel o conf/172787 rc [rc.conf] FreeBSD 9.x broken alias syntax on vlan inte o conf/172532 rc [rc] [patch] service routing restart always fails o conf/169047 rc [rc.subr] [patch] /etc/rc.subr not checking some scrip o bin/168544 rc [patch] [rc]: addswap-mounted swapfiles cause panic on o conf/167566 rc [rc.d] [patch] ipdivert module loading vs. ipfw rc.d o o conf/166484 rc [rc] [patch] rc.initdiskless patch for different major o conf/165769 rc [rc][jai][ipv6] IPv6 Initialization on external iface o conf/164393 rc [rc.d] restarting netif with static addresses doesn't o conf/163508 rc [rc.subr] [patch] Add "enable" and "disable" commands o conf/163488 rc Confusing explanation in defaults/rc.conf o conf/163321 rc [rc.conf] [patch] allow _fib syntax in rc.conf o conf/162642 rc .sh scripts in /usr/local/etc/rc.d get executed, not s o conf/161107 rc [rc] stop_boot in mountcritlocal usage is incorrect. o conf/160403 rc [rc] [patch] concurrently running rc-scripts during bo o conf/160240 rc rc.d/mdconfig and mdconfig2 should autoset $_type to v o conf/159846 rc [rc.conf] routing_stop_inet6() logic doesn't handle ip o conf/158557 rc [patch] /etc/rc.d/pf broken messages o conf/158127 rc [patch] remount_optional option in rc.initdiskless doe o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances a conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip p conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug a conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses f conf/118255 rc savecore never finding kernel core dumps (rcorder prob f conf/117935 rc [patch] ppp fails to start at boot because of missing f conf/113915 rc [ndis] [patch] ndis wireless driver fails to associate o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p f conf/105689 rc [ppp] [request] syslogd starts too late at boot f conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp f conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d f conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle a conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi a conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} f conf/56934 rc [patch] rc.firewall rules for natd expect an interface f conf/13775 rc multi-user boot may hang in NIS environment 87 problems total. From owner-freebsd-rc@FreeBSD.ORG Sat Jun 8 18:44:51 2013 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 8F3E4482; Sat, 8 Jun 2013 18:44:51 +0000 (UTC) (envelope-from smh@freebsd.org) Received: from smtp1.multiplay.co.uk (smtp1.multiplay.co.uk [85.236.96.35]) by mx1.freebsd.org (Postfix) with ESMTP id 42C321FDA; Sat, 8 Jun 2013 18:44:48 +0000 (UTC) Received: by smtp1.multiplay.co.uk (Postfix, from userid 65534) id B53A120E7088A; Sat, 8 Jun 2013 18:44:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.multiplay.co.uk X-Spam-Level: X-Spam-Status: No, score=-2.5 required=8.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.1 Received: from r2d2 (82-69-141-170.dsl.in-addr.zen.co.uk [82.69.141.170]) by smtp1.multiplay.co.uk (Postfix) with ESMTPA id 1010C20E70847; Sat, 8 Jun 2013 18:44:44 +0000 (UTC) Message-ID: From: "Steven Hartland" To: Subject: Feeback on patch to add ZFS support to mdconfig rc.d scripts Date: Sat, 8 Jun 2013 19:44:45 +0100 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_02DE_01CE6480.A0B2FFC0" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: zfs-devel@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jun 2013 18:44:51 -0000 This is a multi-part message in MIME format. ------=_NextPart_000_02DE_01CE6480.A0B2FFC0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit Attached is a patch which adds ZFS support to the mdconfig rc.d scritps along with some other little fixes while I was there. Our use case for this here is to create a ZFS pool on a swap backed node for temporary data which supports all the cool features of ZFS, for us thats compression. Possible enhancements, suggested by pjd in IRC include default flags such as:-o cachefile=none Current summary:- ======= Add ZFS pool creation support to mdconfig rc.d script Fix failure error redirection in mount check Fix invalid configuration detection enabling -t vnode to be skipped if -f is specified as supported by mdconfig. Fix fsck not working if mount point is not present in fstab. TODO: update rc.conf man page ======= I've tested on a number of configs including:- mdconfig_md0="-t swap -s 12g" mdconfig_md0_zfs_pool="tmpfs" mdconfig_md0_zfs_flags="-m /mnt -o cachefile=none -O compression=on -O atime=off -O exec=off -O primarycache=none -O sync=disabled" mdconfig_md1="-f /data/test.vnode" mdconfig_md1_zfs_pool="vnodefs" mdconfig_md1_zfs_flags="-m /root/vnode -o cachefile=none" mdconfig_md2="-f /data/test2.vnode" mdconfig_md3="-s 12g" # Should error, didn't before. What do people think? Regards steve ------=_NextPart_000_02DE_01CE6480.A0B2FFC0 Content-Type: application/octet-stream; name="mdconfig-zfs.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="mdconfig-zfs.patch" Add ZFS pool creation support to mdconfig rc.d script=0A= =0A= Fix failure error redirection in mount check=0A= =0A= Fix invalid configuration detection enabling -t vnode=0A= to be skipped if -f is specified as supported=0A= by mdconfig.=0A= =0A= Fix fsck not working if mount point is not present in fstab.=0A= =0A= TODO: update rc.conf man page=0A= --- /etc/rc.d/mdconfig.orig 2013-06-08 00:55:48.599761883 +0000=0A= +++ /etc/rc.d/mdconfig 2013-06-08 16:24:06.092215311 +0000=0A= @@ -61,6 +61,29 @@=0A= fi=0A= }=0A= =0A= +get_opt()=0A= +{=0A= + local _flag _param _opt=0A= +=0A= + _flag=3D$1=0A= + _param=3D$2=0A= +=0A= + _opt=3D${_config##*-${_flag}\ }=0A= + if [ "${_opt}" =3D "${_config}" ]; then=0A= + _opt=3D""=0A= + else=0A= + _opt=3D${_opt%%\ *}=0A= + fi=0A= + eval _${_param}=3D${_opt}=0A= + debug "${_md} ${_param}=3D${_opt}"=0A= +=0A= + if [ -z "${_opt}" ]; then=0A= + return 0=0A= + fi=0A= +=0A= + return 1=0A= +}=0A= +=0A= init_variables()=0A= {=0A= local _i=0A= @@ -70,16 +93,20 @@=0A= _dev=3D"/dev/${_md}"=0A= eval _config=3D\$mdconfig_${_md}=0A= eval _newfs=3D\$mdconfig_${_md}_newfs=0A= + eval _zpool=3D\$mdconfig_${_md}_zfs_pool=0A= + eval _zflags=3D\$mdconfig_${_md}_zfs_flags=0A= =0A= - _type=3D${_config##*-t\ }=0A= - _type=3D${_type%%\ *}=0A= + get_opt "t" "type"=0A= + get_opt "f" "file"=0A= if [ -z "${_type}" ]; then=0A= - err 1 "You need to specify \"-t \" in mdconfig_${_md}"=0A= + if [ -n "${_file}" ]; then=0A= + _type=3D"vnode"=0A= + else=0A= + err 1 "You need to specify \"-t \" in mdconfig_${_md}"=0A= + fi=0A= fi=0A= =0A= if [ "${_type}" =3D "vnode" ]; then=0A= - _file=3D${_config##*-f\ }=0A= - _file=3D${_file%%\ *}=0A= if [ -z "${_file}" ]; then=0A= err 2 "You need to specify \"-f \" in mdconfig_${_md} for = vnode devices"=0A= fi=0A= @@ -96,11 +123,13 @@=0A= debug "${_md} file: ${_file}"=0A= debug "${_md} fs: ${_fs}"=0A= debug "${_md} newfs flags: ${_newfs}"=0A= + debug "${_md} ZFS pool: ${_zpool}"=0A= + debug "${_md} ZFS flags: ${_zflags}"=0A= }=0A= =0A= mdconfig_start()=0A= {=0A= - local _md _mp _config _type _dev _file _fs _newfs _fsck_cmd=0A= + local _md _mp _config _type _dev _file _fs _newfs _fsck_cmd _zpool = _zflags=0A= =0A= for _md in ${_mdconfig_list}; do=0A= init_variables ${_md}=0A= @@ -126,6 +155,18 @@=0A= echo "Creating ${_md} device failed, moving on."=0A= continue=0A= fi=0A= +=0A= + if [ -n "${_zpool}" ]; then=0A= + if [ "${_type}" =3D "vnode" ]; then=0A= + echo "Importing ZFS pool ${_zpool}."=0A= + zpool import ${_zpool}=0A= + else=0A= + echo "Creating ZFS pool ${_zpool}."=0A= + zpool create ${_zflags} ${_zpool} ${_md}=0A= + fi=0A= + continue=0A= + fi=0A= +=0A= # Skip fsck for uzip devices.=0A= if [ "${_type}" =3D "vnode" ]; then=0A= if [ "${_file}" !=3D "${_file%.uzip}" ]; then=0A= @@ -143,7 +184,8 @@=0A= else=0A= newfs ${_newfs} ${_dev} >/dev/null=0A= fi=0A= - if mount -d ${_dev} 2>&1 >/dev/null; then=0A= +=0A= + if mount -d ${_dev} >/dev/null 2>&1; then=0A= echo "Mounting ${_dev}."=0A= mount ${_dev}=0A= fi=0A= @@ -159,7 +201,12 @@=0A= init_variables ${_md}=0A= if [ "${_type}" !=3D "vnode" -o "${_fs}" =3D "/" ]; then=0A= for _i in `df ${_dev} 2>/dev/null`; do _mp=3D${_i}; done=0A= - if [ -z "${_mp}" -o "${_mp}" !=3D "${_mp%%%}" ]; then=0A= + if [ -n "${_zpool}" ]; then=0A= + if zpool list ${_zpool} >/dev/null 2>&1; then=0A= + echo "Exporting ZFS pool ${_zpool}."=0A= + zpool export ${_zpool}=0A= + fi=0A= + elif [ -z "${_mp}" -o "${_mp}" !=3D "${_mp%%%}" ]; then=0A= echo "Device ${_dev} isn't mounted."=0A= else=0A= echo "Umounting ${_dev}."=0A= --- /etc/rc.d/mdconfig2.orig 2013-06-08 16:33:49.583875813 +0000=0A= +++ /etc/rc.d/mdconfig2 2013-06-08 17:28:02.079420674 +0000=0A= @@ -62,6 +62,29 @@=0A= fi=0A= }=0A= =0A= +get_opt()=0A= +{=0A= + local _flag _param _opt=0A= +=0A= + _flag=3D$1=0A= + _param=3D$2=0A= +=0A= + _opt=3D${_config##*-${_flag}\ }=0A= + if [ "${_opt}" =3D "${_config}" ]; then=0A= + _opt=3D""=0A= + else=0A= + _opt=3D${_opt%%\ *}=0A= + fi=0A= + eval _${_param}=3D${_opt}=0A= + debug "${_md} ${_param}=3D${_opt}"=0A= +=0A= + if [ -z "${_opt}" ]; then=0A= + return 0=0A= + fi=0A= +=0A= + return 1=0A= +}=0A= +=0A= init_variables()=0A= {=0A= local _i=0A= @@ -75,16 +98,19 @@=0A= eval _perms=3D\$mdconfig_${_md}_perms=0A= eval _files=3D\$mdconfig_${_md}_files=0A= eval _populate=3D\$mdconfig_${_md}_cmd=0A= + eval _zpool=3D\$mdconfig_${_md}_zfs_pool=0A= =0A= - _type=3D${_config##*-t\ }=0A= - _type=3D${_type%%\ *}=0A= + get_opt "t" "type"=0A= + get_opt "f" "file"=0A= if [ -z "${_type}" ]; then=0A= - err 1 "You need to specify \"-t \" in mdconfig_${_md}"=0A= + if [ -n "${_file}" ]; then=0A= + _type=3D"vnode"=0A= + else=0A= + err 1 "You need to specify \"-t \" in mdconfig_${_md}"=0A= + fi=0A= fi=0A= =0A= if [ "${_type}" =3D "vnode" ]; then=0A= - _file=3D${_config##*-f\ }=0A= - _file=3D${_file%%\ *}=0A= if [ -z "${_file}" ]; then=0A= err 2 "You need to specify \"-f \" in mdconfig_${_md} for = vnode devices"=0A= fi=0A= @@ -136,26 +162,42 @@=0A= echo "Creating ${_md} device failed, moving on."=0A= continue=0A= fi=0A= - # Skip fsck for uzip devices.=0A= - if [ "${_file}" !=3D "${_file%.uzip}" ]; then=0A= - _fsck_cmd=3D":"=0A= - elif checkyesno background_fsck; then=0A= - _fsck_cmd=3D"fsck -F"=0A= +=0A= + if [ -n "${_zpool}" ]; then=0A= + if [ "${_type}" =3D "vnode" ]; then=0A= + echo "Importing ZFS pool ${_zpool}."=0A= + zpool import ${_zpool}=0A= + else=0A= + echo "Creating ZFS pool ${_zpool}."=0A= + zpool create ${_zflags} ${_zpool} ${_md}=0A= + fi=0A= else=0A= - _fsck_cmd=3D"fsck"=0A= - fi=0A= - if ! eval ${_fsck_cmd} -p ${_dev} >/dev/null; then=0A= - echo "Fsck failed on ${_dev}, not mounting the filesystem."=0A= - continue=0A= - fi=0A= - if mount -d ${_dev} >/dev/null 2>&1; then=0A= - echo "Mounting ${_dev}."=0A= - mount ${_dev}=0A= + # Skip fsck for uzip devices.=0A= + if [ "${_file}" !=3D "${_file%.uzip}" ]; then=0A= + _fsck_cmd=3D":"=0A= + elif checkyesno background_fsck; then=0A= + _fsck_cmd=3D"fsck -t ufs -F"=0A= + else=0A= + _fsck_cmd=3D"fsck -t ufs"=0A= + fi=0A= + if ! eval ${_fsck_cmd} -p ${_dev} >/dev/null; then=0A= + echo "Fsck failed on ${_dev}, not mounting the filesystem."=0A= + continue=0A= + fi=0A= + if mount -d ${_dev} >/dev/null 2>&1; then=0A= + echo "Mounting ${_dev}."=0A= + mount ${_dev}=0A= + fi=0A= fi=0A= fi=0A= =0A= - for _i in `df ${_dev} 2>/dev/null`; do _mp=3D${_i}; done=0A= - if [ ! -z "${_mp}" -a "${_mp}" =3D "${_mp%%%}" ]; then=0A= + if [ -n "${_zpool}" ]; then=0A= + _mp=3D`zfs list -H -o mountpoint ${_zpool} 2>/dev/null`=0A= + else=0A= + for _i in `df ${_dev} 2>/dev/null`; do _mp=3D${_i}; done=0A= + fi=0A= +=0A= + if [ -n "${_mp}" -a "${_mp}" =3D "${_mp%%%}" ]; then=0A= _mounted=3D"yes"=0A= fi=0A= =0A= ------=_NextPart_000_02DE_01CE6480.A0B2FFC0-- From owner-freebsd-rc@FreeBSD.ORG Sat Jun 8 19:20:43 2013 Return-Path: Delivered-To: rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id BAB56D9E; Sat, 8 Jun 2013 19:20:43 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 0BA6A10E6; Sat, 8 Jun 2013 19:20:39 +0000 (UTC) Received: from alph.d.allbsd.org (p2175-ipbf701funabasi.chiba.ocn.ne.jp [122.25.209.175]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r58JKMPt042630 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 9 Jun 2013 04:20:32 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.5/8.14.5) with ESMTP id r58JKK9F061043; Sun, 9 Jun 2013 04:20:22 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 09 Jun 2013 04:19:03 +0900 (JST) Message-Id: <20130609.041903.541782050134731313.hrs@allbsd.org> To: smh@FreeBSD.org Subject: Re: Feeback on patch to add ZFS support to mdconfig rc.d scripts From: Hiroki Sato In-Reply-To: References: X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sun_Jun__9_04_19_03_2013_534)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Sun, 09 Jun 2013 04:20:32 +0900 (JST) X-Spam-Status: No, score=-94.5 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,RCVD_IN_PBL,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: rc@FreeBSD.org, zfs-devel@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jun 2013 19:20:43 -0000 ----Security_Multipart(Sun_Jun__9_04_19_03_2013_534)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit "Steven Hartland" wrote in : sm> Attached is a patch which adds ZFS support to the sm> mdconfig rc.d scritps along with some other little sm> fixes while I was there. sm> sm> Our use case for this here is to create a ZFS pool sm> on a swap backed node for temporary data which supports sm> all the cool features of ZFS, for us thats compression. sm> sm> Possible enhancements, suggested by pjd in IRC include sm> default flags such as:-o cachefile=none sm> sm> Current summary:- sm> ======= sm> Add ZFS pool creation support to mdconfig rc.d script sm> sm> Fix failure error redirection in mount check sm> sm> Fix invalid configuration detection enabling -t vnode sm> to be skipped if -f is specified as supported sm> by mdconfig. sm> sm> Fix fsck not working if mount point is not present in fstab. sm> sm> TODO: update rc.conf man page sm> ======= I think this should be separated into adding non-fs md support into rc.d/mdconfig and on-the-fly zpool creation/import into rc.d/zfs since the rc.d/mdconfig script does not (and should not) depend on zfs.ko module. rc.d/mdconfig is located before mountcritlocal, so probably rc.d/zfs_md or something is needed just after rc.d/mdconfig2. -- Hiroki ----Security_Multipart(Sun_Jun__9_04_19_03_2013_534)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlGzg6cACgkQTyzT2CeTzy3ABgCZARMSpN4m7I251NYJHcxJbQNi mhIAn2AGQsDRK99iL9uo13uU0uFcNJlV =yMgS -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Jun__9_04_19_03_2013_534)----