From owner-freebsd-standards@FreeBSD.ORG Mon Oct 21 11:06:55 2013 Return-Path: Delivered-To: freebsd-standards@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7F5EFA6C for ; Mon, 21 Oct 2013 11:06:55 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6BFED2E2C for ; Mon, 21 Oct 2013 11:06:55 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9LB6tpg018789 for ; Mon, 21 Oct 2013 11:06:55 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9LB6s2N018787 for freebsd-standards@FreeBSD.org; Mon, 21 Oct 2013 11:06:54 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 21 Oct 2013 11:06:54 GMT Message-Id: <201310211106.r9LB6s2N018787@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-standards@FreeBSD.org Subject: Current problem reports assigned to freebsd-standards@FreeBSD.org X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Oct 2013 11:06:55 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o stand/179248 standards A return value of telldir(3) only seekable for once o stand/177742 standards conflict of dd's bs= option with use of conv=sparse o stand/176683 standards catman pages shall be stored in /var (/usr/local/var,/ o stand/176412 standards newfs writes by default, compare to bsdlabel/disklabel o stand/175711 standards When the server has more than 3 days, rising interrupt p stand/175453 standards Catching C++ std::bad_cast doesn't work in FreeBSD 9.1 o stand/174938 standards Problem statement: iSCSI target failure o stand/173421 standards [libc] [patch] strptime() accepts formats that should o stand/173087 standards pax(1) does not support the pax interchange format o stand/172805 standards Fix catopen(3)'s EINVAL usage and document EFTYPE o stand/172276 standards POSIX: {get,set}groups gidsetsize is u_int not int o stand/172215 standards localeconv() grouping appears not to match POSIX o stand/170403 standards wrong ntohs expression type tickling clang o stand/169697 standards syslogd(8) is not BOM aware o stand/166349 standards Support the assignment-allocation character for fscanf p stand/164787 standards dirfd() function not available when _POSIX_C_SOURCE is o kern/164674 standards [patch] [libc] vfprintf/vfwprintf return error (EOF) o o stand/162434 standards getaddrinfo: addrinfo.ai_family is an address family, o stand/150093 standards C++ std::locale support is broken o stand/130067 standards Wrong numeric limits in system headers? o stand/125751 standards man 3 pthread_getschedparam section ERRORS incomplete o stand/124860 standards flockfile(3) doesn't work when the memory has been exh o stand/121921 standards [patch] Add leap second support to at(1), atrun(8) o stand/116477 standards rm(1): rm behaves unexpectedly when using -r and relat o bin/116413 standards incorrect getconf(1) handling of unsigned constants gi o stand/116081 standards make does not work with the directive sinclude a stand/86484 standards [patch] mkfifo(1) uses wrong permissions o stand/81287 standards [patch] fingerd(8) might send a line not ending in CRL a stand/80293 standards sysconf() does not support well-defined unistd values o stand/79056 standards [feature request] [atch] regex(3) regression tests o stand/70813 standards [patch] ls(1) not Posix compliant o stand/66357 standards make POSIX conformance problem ('sh -e' & '+' command- s kern/64875 standards [libc] [patch] [request] add a system call: fdatasync( o stand/56476 standards [patch] cd9660 unicode support simple hack o stand/54410 standards one-true-awk not POSIX compliant (no extended REs) o stand/46119 standards Priority problems for SCHED_OTHER using pthreads o stand/44365 standards [headers] [patch] [request] introduce ulong and unchar a stand/41576 standards ln(1): replacing old dir-symlinks a docs/26003 standards getgroups(2) lists NGROUPS_MAX but not syslimits.h s stand/24590 standards timezone function not compatible witn Single Unix Spec o stand/21519 standards sys/dir.h should be deprecated some more s bin/14925 standards getsubopt isn't poisonous enough 42 problems total. From owner-freebsd-standards@FreeBSD.ORG Tue Oct 22 15:47:19 2013 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 07508104; Tue, 22 Oct 2013 15:47:19 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay004.isp.belgacom.be (mailrelay004.isp.belgacom.be [195.238.6.170]) by mx1.freebsd.org (Postfix) with ESMTP id 6D2FD23B4; Tue, 22 Oct 2013 15:47:18 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap4GANacZlJbsUOq/2dsb2JhbABZFoJxOE6tOpEUgSQXdIIlAQEFOhwjEAsYCSUPKh4GARKICgEDBbpFj04HhCkDmAiBMIskhTSDJjo Received: from 170.67-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.67.170]) by relay.skynet.be with ESMTP; 22 Oct 2013 17:47:16 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id r9MFlFud079522; Tue, 22 Oct 2013 17:47:15 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Tue, 22 Oct 2013 17:47:15 +0200 From: Tijl Coosemans To: William Grzybowski , freebsd-standards@FreeBSD.org Subject: Re: VLC 2.1.0 Message-ID: <20131022174715.59433270@kalimero.tijl.coosemans.org> In-Reply-To: References: <20131022152502.61214646@kalimero.tijl.coosemans.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: multimedia-list freebsd X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2013 15:47:19 -0000 On Tue, 22 Oct 2013 12:30:38 -0200 William Grzybowski wrote: > On Tue, Oct 22, 2013 at 11:25 AM, Tijl Coosemans wrote: >> On Tue, 22 Oct 2013 10:55:28 -0200 William Grzybowski wrote: >>> I am trying to update vlc to 2.1.0, its the final step to get rid of >>> ffmpeg1 as well. >>> I was wondering if any c++ guru out there have any clues on how to fix this: >>> >>> http://pastebin.ca/2469885 >>> >>> http://people.freebsd.org/~wg/vlc2.1.0.txt >> >> I think the problem is that clang doesn't expect } after a label. >> So try adding a ; or (void)0; between the label and vlc_cleanup_run(). > > That works, thank you! I suspect that clang is correct to complain about this and if so we might want to add (void)0; to the definition of pthread_cleanup_pop in /usr/include/pthread.h. Let's see what -standards has to say about this. Summarised: the idiom that VLC uses is this: pthread_cleanup_push(...); ... if (error) goto cleanup; ... cleanup: pthread_cleanup_pop(...); Because the definition of the pthread_cleanup_pop macro starts with } clang complains. From owner-freebsd-standards@FreeBSD.ORG Tue Oct 22 19:09:07 2013 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5F41BDD3 for ; Tue, 22 Oct 2013 19:09:07 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-oa0-f48.google.com (mail-oa0-f48.google.com [209.85.219.48]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 251AF2051 for ; Tue, 22 Oct 2013 19:09:07 +0000 (UTC) Received: by mail-oa0-f48.google.com with SMTP id m17so7045445oag.35 for ; Tue, 22 Oct 2013 12:09:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=x0O5OV1XLR2aNC/tXMe0CqAcxcgGLE/tPI1MqCSedE8=; b=ElgkHdXnqyT0dmosWRD+DHTgf/+NM1+XxVZq5BoEplPL5kRg0hQ00aNYquR9j+O2so Cme6xeQqOcu1ocjCq6K8wHdUzTZAWwx5RK3tKkjn9oY7guxnd0rllHhgyhLISl5JTjZA th/i6wRqC5g2liDMkDP+qDaMuAy4YKxm1f4yCOq3sBPmRbXduHOB25eE64XP+rP5tySF Uxkf17e+i7R3+dFu97VP/ueI95UKbcnmNqiUmMZXesMeWe0lKtOLpqaKiNCDE5ECsCAX cwZfhv6aL15QbAy7E4MeSBVmeiMSAiLXpeKMoQM0SUF03wm+rNUPLJ3Tot0jrPRfREkK /oqA== X-Gm-Message-State: ALoCoQnziGtq3FzAVGHJjk9XJ3Vg/eXn8p/fJAYa8msMLPonAlibuGhchkTA5/sohVcAR+VPn53Z X-Received: by 10.182.213.39 with SMTP id np7mr20962obc.92.1382468940028; Tue, 22 Oct 2013 12:09:00 -0700 (PDT) Received: from monkey-bot.int.fusionio.com ([209.117.142.2]) by mx.google.com with ESMTPSA id z5sm42667147obg.13.2013.10.22.12.08.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Oct 2013 12:08:58 -0700 (PDT) Sender: Warner Losh Subject: Re: VLC 2.1.0 Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <20131022174715.59433270@kalimero.tijl.coosemans.org> Date: Tue, 22 Oct 2013 13:08:56 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20131022152502.61214646@kalimero.tijl.coosemans.org> <20131022174715.59433270@kalimero.tijl.coosemans.org> To: Tijl Coosemans X-Mailer: Apple Mail (2.1085) Cc: multimedia-list freebsd , William Grzybowski , freebsd-standards@FreeBSD.org X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2013 19:09:07 -0000 On Oct 22, 2013, at 9:47 AM, Tijl Coosemans wrote: > On Tue, 22 Oct 2013 12:30:38 -0200 William Grzybowski wrote: >> On Tue, Oct 22, 2013 at 11:25 AM, Tijl Coosemans = wrote: >>> On Tue, 22 Oct 2013 10:55:28 -0200 William Grzybowski wrote: >>>> I am trying to update vlc to 2.1.0, its the final step to get rid = of >>>> ffmpeg1 as well. >>>> I was wondering if any c++ guru out there have any clues on how to = fix this: >>>>=20 >>>> http://pastebin.ca/2469885 >>>>=20 >>>> http://people.freebsd.org/~wg/vlc2.1.0.txt >>>=20 >>> I think the problem is that clang doesn't expect } after a label. >>> So try adding a ; or (void)0; between the label and = vlc_cleanup_run(). >>=20 >> That works, thank you! >=20 > I suspect that clang is correct to complain about this and if so we > might want to add (void)0; to the definition of pthread_cleanup_pop > in /usr/include/pthread.h. Let's see what -standards has to say > about this. >=20 > Summarised: the idiom that VLC uses is this: >=20 > pthread_cleanup_push(...); > ... > if (error) goto cleanup; > ... > cleanup: > pthread_cleanup_pop(...); >=20 > Because the definition of the pthread_cleanup_pop macro starts with } > clang complains. Any statement will do there... Clang is correct in complaining because a = label in C labels the statement not the location. (void) 0; is as good or bad as any... Warner= From owner-freebsd-standards@FreeBSD.ORG Tue Oct 22 21:23:29 2013 Return-Path: Delivered-To: freebsd-standards@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 46983560; Tue, 22 Oct 2013 21:23:29 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0A8D229CA; Tue, 22 Oct 2013 21:23:29 +0000 (UTC) Received: from turtle.stack.nl (turtle.stack.nl [IPv6:2001:610:1108:5010::132]) by mx1.stack.nl (Postfix) with ESMTP id B22A1359315; Tue, 22 Oct 2013 23:23:27 +0200 (CEST) Received: by turtle.stack.nl (Postfix, from userid 1677) id 7EDAACB4E; Tue, 22 Oct 2013 23:23:27 +0200 (CEST) Date: Tue, 22 Oct 2013 23:23:27 +0200 From: Jilles Tjoelker To: Tijl Coosemans Subject: Re: VLC 2.1.0 Message-ID: <20131022212327.GB20055@stack.nl> References: <20131022152502.61214646@kalimero.tijl.coosemans.org> <20131022174715.59433270@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131022174715.59433270@kalimero.tijl.coosemans.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: multimedia-list freebsd , William Grzybowski , freebsd-standards@FreeBSD.org X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2013 21:23:29 -0000 On Tue, Oct 22, 2013 at 05:47:15PM +0200, Tijl Coosemans wrote: > On Tue, 22 Oct 2013 12:30:38 -0200 William Grzybowski wrote: > > On Tue, Oct 22, 2013 at 11:25 AM, Tijl Coosemans wrote: > >> On Tue, 22 Oct 2013 10:55:28 -0200 William Grzybowski wrote: > >>> I am trying to update vlc to 2.1.0, its the final step to get rid of > >>> ffmpeg1 as well. > >>> I was wondering if any c++ guru out there have any clues on how to fix this: > >>> http://pastebin.ca/2469885 > >>> http://people.freebsd.org/~wg/vlc2.1.0.txt > >> I think the problem is that clang doesn't expect } after a label. > >> So try adding a ; or (void)0; between the label and vlc_cleanup_run(). > > That works, thank you! > I suspect that clang is correct to complain about this and if so we > might want to add (void)0; to the definition of pthread_cleanup_pop > in /usr/include/pthread.h. Let's see what -standards has to say > about this. > Summarised: the idiom that VLC uses is this: > pthread_cleanup_push(...); > ... > if (error) goto cleanup; > ... > cleanup: > pthread_cleanup_pop(...); > Because the definition of the pthread_cleanup_pop macro starts with } > clang complains. glibc has do { } while (0); at the start of the pthread_cleanup_pop define. I think this is a better option than ; or (void)0; as it minimizes the wrong things it can combine with. Reading POSIX, it seems valid to put a label right before an invocation of pthread_cleanup_pop. In such a case, the invocation still appears as a statement and can be paired with a pthread_cleanup_push in the same lexical scope. Therefore the following patch to src seems appropriate. Index: include/pthread.h =================================================================== --- include/pthread.h (revision 256728) +++ include/pthread.h (working copy) @@ -175,6 +175,7 @@ { #define pthread_cleanup_pop(execute) \ + do { } while (0); \ } \ __pthread_cleanup_pop_imp(execute); \ } -- Jilles Tjoelker From owner-freebsd-standards@FreeBSD.ORG Wed Oct 23 10:12:41 2013 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D8E9B275; Wed, 23 Oct 2013 10:12:41 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay011.isp.belgacom.be (mailrelay011.isp.belgacom.be [195.238.6.178]) by mx1.freebsd.org (Postfix) with ESMTP id 4E25822B6; Wed, 23 Oct 2013 10:12:41 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlQGAA2gZ1Jbs4WZ/2dsb2JhbABZgwe8XoJ6gSYXdIIlAQEFViMQCxgJJQ8qHgaIHQG6YY9OB4QqA5Ath1uSCIMmOg Received: from 153.133-179-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.179.133.153]) by relay.skynet.be with ESMTP; 23 Oct 2013 12:12:39 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id r9NACcqk009372; Wed, 23 Oct 2013 12:12:38 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Wed, 23 Oct 2013 12:12:37 +0200 From: Tijl Coosemans To: Jilles Tjoelker Subject: Re: VLC 2.1.0 Message-ID: <20131023121237.51e5a79e@kalimero.tijl.coosemans.org> In-Reply-To: <20131022212327.GB20055@stack.nl> References: <20131022152502.61214646@kalimero.tijl.coosemans.org> <20131022174715.59433270@kalimero.tijl.coosemans.org> <20131022212327.GB20055@stack.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/pNkYODNbZBn4WVupizbFP3L" Cc: multimedia-list freebsd , William Grzybowski , freebsd-standards@FreeBSD.org X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Oct 2013 10:12:42 -0000 --MP_/pNkYODNbZBn4WVupizbFP3L Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tue, 22 Oct 2013 23:23:27 +0200 Jilles Tjoelker wrote: > On Tue, Oct 22, 2013 at 05:47:15PM +0200, Tijl Coosemans wrote: >> Summarised: the idiom that VLC uses is this: >> >> pthread_cleanup_push(...); >> ... >> if (error) goto cleanup; >> ... >> cleanup: >> pthread_cleanup_pop(...); >> >> Because the definition of the pthread_cleanup_pop macro starts with } >> clang complains. > > glibc has do { } while (0); at the start of the pthread_cleanup_pop > define. I think this is a better option than ; or (void)0; as it > minimizes the wrong things it can combine with. > > Reading POSIX, it seems valid to put a label right before an invocation > of pthread_cleanup_pop. In such a case, the invocation still appears as > a statement and can be paired with a pthread_cleanup_push in the same > lexical scope. > > Therefore the following patch to src seems appropriate. > > Index: include/pthread.h > =================================================================== > --- include/pthread.h (revision 256728) > +++ include/pthread.h (working copy) > @@ -175,6 +175,7 @@ > { > > #define pthread_cleanup_pop(execute) \ > + do { } while (0); \ > } \ > __pthread_cleanup_pop_imp(execute); \ > } I had to think a bit about what could combine with (void)0; but not do-while, but ?: can, so I agree. I've extended your patch further to force the use of ;. Please review. --MP_/pNkYODNbZBn4WVupizbFP3L Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=pthread_cleanup.patch Index: include/pthread.h =================================================================== --- include/pthread.h (revision 256953) +++ include/pthread.h (working copy) @@ -168,17 +168,18 @@ int pthread_barrierattr_init(pthread_ba int pthread_barrierattr_setpshared(pthread_barrierattr_t *, int); #define pthread_cleanup_push(cleanup_routine, cleanup_arg) \ - { \ + do { \ struct _pthread_cleanup_info __cleanup_info__; \ __pthread_cleanup_push_imp(cleanup_routine, cleanup_arg,\ &__cleanup_info__); \ - { + { \ + do { } while(0) #define pthread_cleanup_pop(execute) \ - (void)0; \ + do { } while(0); \ } \ __pthread_cleanup_pop_imp(execute); \ - } + } while(0) int pthread_condattr_destroy(pthread_condattr_t *); int pthread_condattr_getclock(const pthread_condattr_t *, --MP_/pNkYODNbZBn4WVupizbFP3L-- From owner-freebsd-standards@FreeBSD.ORG Wed Oct 23 14:40:37 2013 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 124916A9 for ; Wed, 23 Oct 2013 14:40:37 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ie0-f170.google.com (mail-ie0-f170.google.com [209.85.223.170]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D261324BD for ; Wed, 23 Oct 2013 14:40:36 +0000 (UTC) Received: by mail-ie0-f170.google.com with SMTP id at1so1477429iec.15 for ; Wed, 23 Oct 2013 07:40:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=4og7KLUpscb9WxuVwpbzyEkIHC8QYBH98/Y+W/O+vSs=; b=UdhC7iKRX5YtYiUnLU8ROz4myVdq9mCjNZw5BbgdBAC6oHUEN1Cx5Nb/ios6kFpVwx SVI9l4xw9TS02EC7F436Y/R8LRdT0UKRAe3pEWh3MaB+NnMY9oBO+VbdZwbRh9Dqs3HE 7gBsLBOIQBGBsUEX9auHhMq42qUazPWsc3aSClbzuEOtNSl/UXDT+zZZk39bkGrovpML tgwih9MC2aXxYMT5BpIB88iXFSJ9NVDaTGDRbZcOMP08VOQgXtL3JvZShsccHl8O1hDa GwpDMmW42RngXq4ycm7vqZDZfgheEMnQrOj2tecfeqeRHkpmx5/ey1RB1gMgc08IMRqQ RCgA== X-Gm-Message-State: ALoCoQkLFACrYzQA1vmmyLnOPLbHM5UdA5wMQX0B9p3QIkJdHg6bdIn0NGcpvORaHuUHTGn3ohj9 X-Received: by 10.50.6.99 with SMTP id z3mr999922igz.27.1382539230143; Wed, 23 Oct 2013 07:40:30 -0700 (PDT) Received: from 53.imp.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id q6sm8026155igi.0.2013.10.23.07.40.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 23 Oct 2013 07:40:29 -0700 (PDT) Sender: Warner Losh Subject: Re: VLC 2.1.0 Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <20131023121237.51e5a79e@kalimero.tijl.coosemans.org> Date: Wed, 23 Oct 2013 08:40:27 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <55D30F7E-4F38-472C-8143-53200D55DFBA@bsdimp.com> References: <20131022152502.61214646@kalimero.tijl.coosemans.org> <20131022174715.59433270@kalimero.tijl.coosemans.org> <20131022212327.GB20055@stack.nl> <20131023121237.51e5a79e@kalimero.tijl.coosemans.org> To: Tijl Coosemans X-Mailer: Apple Mail (2.1085) Cc: multimedia-list freebsd , William Grzybowski , freebsd-standards@FreeBSD.org, Jilles Tjoelker X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Oct 2013 14:40:37 -0000 On Oct 23, 2013, at 4:12 AM, Tijl Coosemans wrote: > I think this patch is way too complex. We just need a real statement = before the } in the unorthodox push/pop macros to make them = syntactically a statement in all contexts... (void)0; does that, as = does do { ...} while(0); In the cases where it would matter the = difference between {} and do { } while(0); can't happen with this macro = because it can't be used in the context of an if statement without {}... Warner