From owner-freebsd-testing@FreeBSD.ORG Tue Nov 5 00:53:37 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C000ED8B for ; Tue, 5 Nov 2013 00:53:37 +0000 (UTC) (envelope-from tyler@monkeypox.org) Received: from sanddollar.geekisp.com (sanddollar.geekisp.com [216.168.135.167]) by mx1.freebsd.org (Postfix) with SMTP id 541682FCF for ; Tue, 5 Nov 2013 00:53:36 +0000 (UTC) Received: (qmail 833 invoked by uid 1003); 5 Nov 2013 00:53:30 -0000 Received: from unknown (HELO kiwi.coupleofllamas.com) (tyler@monkeypox.org@64.125.69.200) by mail.geekisp.com with (DHE-RSA-AES256-SHA encrypted) SMTP; 5 Nov 2013 00:53:30 -0000 Date: Mon, 4 Nov 2013 16:53:16 -0800 From: "R. Tyler Croy" To: freebsd-testing@freebsd.org Subject: Low-hanging fruit for noobies? Message-ID: <20131105005316.GB11443@kiwi.coupleofllamas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yEPQxsgoJgBvi8ip" Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Nov 2013 00:53:37 -0000 --yEPQxsgoJgBvi8ip Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I've been following jmmv's work for a while, but haven't taken the plunge into playing with Kyua at all. Is there a list of low-hanging fruit, or easy test cases that could be implemented as a gentle introduction, or is it still too early in the process for that? I've already looked through the https://wiki.freebsd.org/TestSuite page, but I'm not sure where I could jump in and try my hand at writing some cases. - R. Tyler Croy -------------------------------------- Code: https://github.com/rtyler Chatter: https://twitter.com/agentdero rtyler@jabber.org --yEPQxsgoJgBvi8ip Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlJ4QXwACgkQFCbH3D9R4W8wDQCfZ8ADnHo+JqSVFCi2oHed6HOD A00An1Qg083RzfSmsfjuhclkJbVDDm78 =4CnG -----END PGP SIGNATURE----- --yEPQxsgoJgBvi8ip-- From owner-freebsd-testing@FreeBSD.ORG Tue Nov 5 01:01:22 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D4EB5F5B for ; Tue, 5 Nov 2013 01:01:22 +0000 (UTC) (envelope-from julio@meroh.net) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com [209.85.215.47]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 610872062 for ; Tue, 5 Nov 2013 01:01:21 +0000 (UTC) Received: by mail-la0-f47.google.com with SMTP id er20so1540065lab.6 for ; Mon, 04 Nov 2013 17:01:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=TmbwO8psct/iXrSQ73jCD65gboL6iz8vjUrECV2pmQI=; b=TFi/7smd4TS8/gxDHWP0xbmPAhx9xod6QzMXkIZhRWhOeq+KLanRHWwduBRZpGR30o fjGTwJ0j+RZRpuEQCclPD4K1HlHY1lW+xrtGtFwK+51qbCC9cZTq3mHSg9rvBke4LYd8 +5PLynyjuhyVvLXcBRewLmuEcKBwY9xHfwtNwTGe45h6ejQAim0pnBCvu3wDDnACI5Cj PKareKadCZB31sP6XDoUD61XflSvoonMoRhBaYdpF+BKABb5AU8vJq+MZtYLGaz/hxWp /nW9hUcp+shgi3PZu+TkEQir/RWo+fOx/rIYvrqbX9tcBRImfxLjFNMKl+1r66ReThgr mgXw== X-Gm-Message-State: ALoCoQmKYcD3+jmRkWXBCl4VHbIU/B806uNEOj02Leg3tTTYz36po5yT9RZf6lgVNRX3xwU6LqpX X-Received: by 10.112.143.138 with SMTP id se10mr6764205lbb.26.1383613280111; Mon, 04 Nov 2013 17:01:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.132.135 with HTTP; Mon, 4 Nov 2013 17:01:00 -0800 (PST) X-Originating-IP: [108.176.158.82] In-Reply-To: <20131105005316.GB11443@kiwi.coupleofllamas.com> References: <20131105005316.GB11443@kiwi.coupleofllamas.com> From: Julio Merino Date: Mon, 4 Nov 2013 20:01:00 -0500 Message-ID: Subject: Re: Low-hanging fruit for noobies? To: "R. Tyler Croy" Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-testing@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Nov 2013 01:01:22 -0000 On Mon, Nov 4, 2013 at 7:53 PM, R. Tyler Croy wrote: > I've been following jmmv's work for a while, but haven't taken the plunge into > playing with Kyua at all. > > Is there a list of low-hanging fruit, or easy test cases that could be > implemented as a gentle introduction, or is it still too early in the process > for that? Hi, I'd say it's a bit early. I have got to finish a couple of details with the infrastructure before creating/porting tests is easily doable and parallelizable. That's part of the reason why there has been no formal announcement about the wiki page you quoted yet ;-) But be sure that, once we pass that barrier --hopefully soon after my current set of outstanding patches go in--, it will be easy for you to help with test additions! (... which is actually the important part of this project!) Cheers, -- Julio Merino / @jmmv From owner-freebsd-testing@FreeBSD.ORG Tue Nov 5 08:12:52 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0BFC88D1 for ; Tue, 5 Nov 2013 08:12:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-vc0-x230.google.com (mail-vc0-x230.google.com [IPv6:2607:f8b0:400c:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C2D142461 for ; Tue, 5 Nov 2013 08:12:51 +0000 (UTC) Received: by mail-vc0-f176.google.com with SMTP id ia6so5375430vcb.35 for ; Tue, 05 Nov 2013 00:12:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=92j4QI2d1IY+TkcfThYn1H6subJi6/si694aoBDHarE=; b=lCGWDcYuhUuupeEpysVA/ZHuqPsB9a1HU0H+ne/Pe9XtrTWtwfcQmlgIhZ/58bbDBT uW3ThpTfYbpwFZ/kWDmZTyn+l1S6bsLN02ra3iItFyvihdbjUb5qmHI8FAZ+sNY1ZWKj tS4JzQluyKq4cRQtdd01hQdAaSKmwma5VXjPKvRoY9QEN/r1bcm3AYkmmaehaZY7x/fg E/lJWybg7SpPaJ/ImIolZeQYXDc27STjIv/YVlowP6lv7Dc7oOdRYceahnwAUBQxSiVE pqdURa9DqvnE3cz1gQ8DyFmIfSFbw94nZOOh9a56NkLCIrp0XhakYPGfJrcfJFyP1nv9 V2gg== MIME-Version: 1.0 X-Received: by 10.58.11.73 with SMTP id o9mr14582613veb.8.1383639170843; Tue, 05 Nov 2013 00:12:50 -0800 (PST) Received: by 10.220.14.196 with HTTP; Tue, 5 Nov 2013 00:12:50 -0800 (PST) In-Reply-To: <20131105005316.GB11443@kiwi.coupleofllamas.com> References: <20131105005316.GB11443@kiwi.coupleofllamas.com> Date: Tue, 5 Nov 2013 00:12:50 -0800 Message-ID: Subject: Re: Low-hanging fruit for noobies? From: Garrett Cooper To: "R. Tyler Croy" Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Nov 2013 08:12:52 -0000 On Mon, Nov 4, 2013 at 4:53 PM, R. Tyler Croy wrote: > I've been following jmmv's work for a while, but haven't taken the plunge into > playing with Kyua at all. > > Is there a list of low-hanging fruit, or easy test cases that could be > implemented as a gentle introduction, or is it still too early in the process > for that? > > I've already looked through the https://wiki.freebsd.org/TestSuite page, but > I'm not sure where I could jump in and try my hand at writing some cases. The easiest thing that could probably be done is take the work I did with prove.test.mk, py-nose.test.mk, and py-unittest.test.mk (on github) and make it work with the direction that jmmv is proposing for atf/kyua with kyua being the unified top-level driver/reporting engine for testing on FreeBSD. py*.mk needs polishing, but prove.test.mk is "ready for production" (I've been using it for some time for the stuff in tools/regression that I didn't fully port over to ATF). Cheers! -Garrett From owner-freebsd-testing@FreeBSD.ORG Wed Nov 6 00:18:16 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id BBF526FF for ; Wed, 6 Nov 2013 00:18:16 +0000 (UTC) (envelope-from julio@meroh.net) Received: from mail-la0-f45.google.com (mail-la0-f45.google.com [209.85.215.45]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2F6B721CB for ; Wed, 6 Nov 2013 00:18:15 +0000 (UTC) Received: by mail-la0-f45.google.com with SMTP id el20so1170830lab.32 for ; Tue, 05 Nov 2013 16:18:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-type; bh=vOMCoNAKJdhmtCyYPpV198pSJ2yXryeBT3gw5Oi+olM=; b=lsxZJ2SFK0HlyihAj65TCfYoL2T/E5Iaj2hdk/8T36KVZkvMr7FqhzKMV0ljb3vUiJ /B/eR5h616Zky8TVUPAgLZYzcfS59Oe2tnOE0iCFKFjrRf+dK1EpDS9tPG4rVvA86WnE 9SmY3u8FJKXrkgxZB/W7+ndCywUtMW3vlhZ43yjbPpA/BM9yHsVlxhSqK2BtHpNFm6J7 LWmmKlbXqTjOZivjxb49IfuPneW57m2cLq+akCK2TSJv+eRddKg1J517uN29vSVfFycB v0tOZxNmjBbhozjKx0AwXUzK/MbtdemZSOlrVqsj78FyoZ5pKmJhjMMIJg8dEe6CbX1H 4iig== X-Gm-Message-State: ALoCoQkPa0Ob18ERK6eoXWVb8cG98R8tMAgAQrwOsTZBpCvXiBMvz+5+4Y1Qfv1hw5WFVkMhsqYW X-Received: by 10.152.225.161 with SMTP id rl1mr181754lac.38.1383697094024; Tue, 05 Nov 2013 16:18:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.132.135 with HTTP; Tue, 5 Nov 2013 16:17:52 -0800 (PST) X-Originating-IP: [172.26.105.74] From: Julio Merino Date: Tue, 5 Nov 2013 19:17:52 -0500 Message-ID: Subject: Fixing the build with TESTS To: freebsd-testing@freebsd.org Content-Type: multipart/mixed; boundary=001a113490fac4fa2804ea7715a0 Cc: Rui Paulo X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Nov 2013 00:18:16 -0000 --001a113490fac4fa2804ea7715a0 Content-Type: text/plain; charset=ISO-8859-1 Hello, The previous changes to enable the installation of tests broke the build and is the reason why Rui had to default the TESTS knob to 'no'. The reason for the breakage is the following: When buildworld starts by building the basic "bootstrap" libraries, it does a "make all" within various lib/* directories, including libcrypt. libcrypt had tests added to it, which means that "make all" recursed into the tests directory and attempted to build them. But, at that point, the atf libraries had not yet been built. I did not encounter this issue because I'm running builds with MK_CLEAN=no (yup, lesson learned). I think it's wrong for this stage of buildworld to attempt building tests at all. atf is just one of the many dependencies we'd encounter, and we should not try to build all dependencies upfront... because we cannot. (Just imagine when libc starts getting tests.) The fix-build-bootstrap.patch attached attempts to correct this by explicitly disabling the build of any tests during the initial build of the bootstrap components. I'm not sure this patch is nice enough, although it follows the style of various other related knobs; if you have better ideas, please share. Additionally, we will encounter similar issues once we have tests that use C++ (which we will, if only because of libatf-c++'s tests), so we should also do what fix-build-atf-cxx.patch proposes. Thoughts? Thanks, -- Julio Merino / @jmmv --001a113490fac4fa2804ea7715a0 Content-Type: application/octet-stream; name="fix-build-atf-cxx.patch" Content-Disposition: attachment; filename="fix-build-atf-cxx.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnnpmnyh0 QWRkIGxpYmF0Zi1jKysgdG8gdGhlIHByZWJ1aWxkIGxpYnMuCgpTb21lIHRlc3RzIG1heSByZXF1 aXJlIEMrKyBzbyB3ZSBtdXN0IGVuc3VyZSB0aGlzIGxpYnJhcnkgZXhpc3RzIGFzIHBhcnQKb2Yg dGhlIGJvb3RzdHJhcCBwcm9jZXNzIG9yIGVsc2UgdGhleSB3aWxsIGZhaWwgdG8gYnVpbGQuCgpJ bmRleDogc3JjL01ha2VmaWxlLmluYzEKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3JjLm9yaWcvTWFrZWZpbGUu aW5jMQorKysgc3JjL01ha2VmaWxlLmluYzEKQEAgLTE0NjIsNiArMTQ2Miw3IEBAIF9wcmVidWls ZF9saWJzPQkke19rZXJiZXJvczVfbGliX2xpYmFzbjEKIAkJJHtfa2VyYmVyb3M1X2xpYl9saWJy b2tlbn0gXAogCQkke19rZXJiZXJvczVfbGliX2xpYndpbmR9IFwKIAkJJHtfbGliX2F0Zl9saWJh dGZfY30gXAorCQkke19saWJfYXRmX2xpYmF0Zl9jeHh9IFwKIAkJbGliL2xpYmJ6MiAke19saWJj b21fZXJyfSBsaWIvbGliY3J5cHQgXAogCQlsaWIvbGliZWxmIGxpYi9saWJleHBhdCBcCiAJCSR7 X2xpYl9saWJnc3NhcGl9ICR7X2xpYl9saWJpcHh9IFwKQEAgLTE0NzcsNiArMTQ3OCw3IEBAIF9w cmVidWlsZF9saWJzPQkke19rZXJiZXJvczVfbGliX2xpYmFzbjEKIAogLmlmICR7TUtfQVRGfSAh PSAibm8iCiBfbGliX2F0Zl9saWJhdGZfYz0JbGliL2F0Zi9saWJhdGYtYworX2xpYl9hdGZfbGli YXRmX2N4eD0JbGliL2F0Zi9saWJhdGYtYysrCiAuZW5kaWYKIAogLmlmICR7TUtfTElCVEhSfSAh PSAibm8iCg== --001a113490fac4fa2804ea7715a0 Content-Type: application/octet-stream; name="fix-build-bootstrap.patch" Content-Disposition: attachment; filename="fix-build-bootstrap.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnnpmnzo1 Rml4IGNsZWFuIGJ1aWxkcyB3aGVuIFdJVEhfVEVTVFMgaXMgZW5hYmxlZC4KClRoZSBhZGRpdGlv biBvZiB0aGUgVEVTVFMga25vYiBhbmQgaXRzIGVuYWJsaW5nIG9mIHRoZSBidWlsZCBvZiB0ZXN0 cyBpbgpsaWIvbGliY3J5cHQvdGVzdHMvIGJyb2tlIHRoZSBidWlsZC4gIFRoZSByZWFzb24gaXMg dGhhdCB3ZSBjYW5ub3QgZGVzY2VuZAppbnRvIHRlc3RzLyBzdWJkaXJlY3RvcmllcyB1bnRpbCBh bGwgcHJlcmVxdWlzaXRlcyBoYXZlIGJlZW4gYnVpbHQsIHdoaWNoCmluIHRoZSBjYXNlIG9mIHRl c3RzIG1heSBiZSAiYSBsb3Qgb2YgdGhpbmdzIiAobGliYXRmLWMgaW4gdGhpcyBjYXNlKS4KCkVu c3VyZSB0aGF0IHdlIGRvIG5vdCB3YWxrIHRlc3RzLyBkaXJlY3RvcmllcyBkdXJpbmcgdGhlIGJv b3RzdHJhcHBpbmcgb2YKdGhlIGxpYnJhcmllcyBhcyBwYXJ0IG9mIGJ1aWxkd29ybGQuCgpJbmRl eDogc3JjL01ha2VmaWxlLmluYzEKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3JjLm9yaWcvTWFrZWZpbGUuaW5j MQorKysgc3JjL01ha2VmaWxlLmluYzEKQEAgLTE1ODUsMTAgKzE1ODUsMTIgQEAgJHtfbGlifV9f UEw6IC5QSE9OWSAuTUFLRQogLmlmIGV4aXN0cygkey5DVVJESVJ9LyR7X2xpYn0pCiAJJHtfK199 QCR7RUNIT0RJUn0gIj09PT4gJHtfbGlifSAob2JqLGRlcGVuZCxhbGwsaW5zdGFsbCkiOyBcCiAJ CWNkICR7LkNVUkRJUn0vJHtfbGlifSAmJiBcCi0JCSR7TUFLRX0gRElSUFJGWD0ke19saWJ9LyBv YmogJiYgXAotCQkke01BS0V9IERJUlBSRlg9JHtfbGlifS8gZGVwZW5kICYmIFwKLQkJJHtNQUtF fSAtRE5PX1BST0ZJTEUgLUROT19QSUMgRElSUFJGWD0ke19saWJ9LyBhbGwgJiYgXAotCQkke01B S0V9IC1ETk9fUFJPRklMRSAtRE5PX1BJQyBESVJQUkZYPSR7X2xpYn0vIGluc3RhbGwKKwkJJHtN QUtFfSBESVJQUkZYPSR7X2xpYn0vIC1EX05PX1RFU1RTX1lFVCBvYmogJiYgXAorCQkke01BS0V9 IERJUlBSRlg9JHtfbGlifS8gLURfTk9fVEVTVFNfWUVUIGRlcGVuZCAmJiBcCisJCSR7TUFLRX0g RElSUFJGWD0ke19saWJ9LyAtRF9OT19URVNUU19ZRVQgLUROT19QUk9GSUxFIFwKKwkJICAgIC1E Tk9fUElDIGFsbCAmJiBcCisJCSR7TUFLRX0gRElSUFJGWD0ke19saWJ9LyAtRF9OT19URVNUU19Z RVQgLUROT19QUk9GSUxFIFwKKwkJICAgIC1ETk9fUElDIGluc3RhbGwKIC5lbmRpZgogLmVuZGZv cgogCkBAIC0xNTk3LDEwICsxNTk5LDEwIEBAICR7X2xpYn1fX0w6IC5QSE9OWSAuTUFLRQogLmlm IGV4aXN0cygkey5DVVJESVJ9LyR7X2xpYn0pCiAJJHtfK199QCR7RUNIT0RJUn0gIj09PT4gJHtf bGlifSAob2JqLGRlcGVuZCxhbGwsaW5zdGFsbCkiOyBcCiAJCWNkICR7LkNVUkRJUn0vJHtfbGli fSAmJiBcCi0JCSR7TUFLRX0gRElSUFJGWD0ke19saWJ9LyBvYmogJiYgXAotCQkke01BS0V9IERJ UlBSRlg9JHtfbGlifS8gZGVwZW5kICYmIFwKLQkJJHtNQUtFfSBESVJQUkZYPSR7X2xpYn0vIGFs bCAmJiBcCi0JCSR7TUFLRX0gRElSUFJGWD0ke19saWJ9LyBpbnN0YWxsCisJCSR7TUFLRX0gRElS UFJGWD0ke19saWJ9LyAtRF9OT19URVNUU19ZRVQgb2JqICYmIFwKKwkJJHtNQUtFfSBESVJQUkZY PSR7X2xpYn0vIC1EX05PX1RFU1RTX1lFVCBkZXBlbmQgJiYgXAorCQkke01BS0V9IERJUlBSRlg9 JHtfbGlifS8gLURfTk9fVEVTVFNfWUVUIGFsbCAmJiBcCisJCSR7TUFLRX0gRElSUFJGWD0ke19s aWJ9LyAtRF9OT19URVNUU19ZRVQgaW5zdGFsbAogLmVuZGlmCiAuZW5kZm9yCiAKQEAgLTE2MTAs MTAgKzE2MTIsMTIgQEAgJHtfbGlifV9fTDogLlBIT05ZIC5NQUtFCiBsaWIvbGlicGFtX19MOiAu UEhPTlkgLk1BS0UKIAkke18rX31AJHtFQ0hPRElSfSAiPT09PiBsaWIvbGlicGFtIChvYmosZGVw ZW5kLGFsbCxpbnN0YWxsKSI7IFwKIAkJY2QgJHsuQ1VSRElSfS9saWIvbGlicGFtICYmIFwKLQkJ JHtNQUtFfSBESVJQUkZYPWxpYi9saWJwYW0vIG9iaiAmJiBcCi0JCSR7TUFLRX0gRElSUFJGWD1s aWIvbGlicGFtLyBkZXBlbmQgJiYgXAotCQkke01BS0V9IERJUlBSRlg9bGliL2xpYnBhbS8gLURf Tk9fTElCUEFNX1NPX1lFVCBhbGwgJiYgXAotCQkke01BS0V9IERJUlBSRlg9bGliL2xpYnBhbS8g LURfTk9fTElCUEFNX1NPX1lFVCBpbnN0YWxsCisJCSR7TUFLRX0gRElSUFJGWD1saWIvbGlicGFt LyAtRF9OT19URVNUU19ZRVQgb2JqICYmIFwKKwkJJHtNQUtFfSBESVJQUkZYPWxpYi9saWJwYW0v IC1EX05PX1RFU1RTX1lFVCBkZXBlbmQgJiYgXAorCQkke01BS0V9IERJUlBSRlg9bGliL2xpYnBh bS8gLURfTk9fVEVTVFNfWUVUIFwKKwkJICAgIC1EX05PX0xJQlBBTV9TT19ZRVQgYWxsICYmIFwK KwkJJHtNQUtFfSBESVJQUkZYPWxpYi9saWJwYW0vIC1EX05PX1RFU1RTX1lFVCBcCisJCSAgICAt RF9OT19MSUJQQU1fU09fWUVUIGluc3RhbGwKIAogX3ByZXJlcV9saWJzOiAke19wcmVyZXFfbGli czpTLyQvX19QTC99CiBfc3RhcnR1cF9saWJzOiAke19zdGFydHVwX2xpYnM6Uy8kL19fTC99Cklu ZGV4OiBzcmMvc2hhcmUvbWsvYnNkLm93bi5tawo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzcmMub3JpZy9zaGFy ZS9tay9ic2Qub3duLm1rCisrKyBzcmMvc2hhcmUvbWsvYnNkLm93bi5tawpAQCAtNTU2LDYgKzU1 NiwxMyBAQCBNS19DTEFOR19GVUxMOj0gbm8KIE1LX0xMREI6PSBubwogLmVuZGlmCiAKKy5pZiBk ZWZpbmVkKF9OT19URVNUU19ZRVQpCisjIEF0IHRoZSBiZWdpbm5pbmcgb2YgYSBmcmVzaCBidWls ZHdvcmxkLCB3ZSBtdXN0IGVuc3VyZSB0aGF0IHdlIGRvbid0CisjIGRlc2NlbmQgaW50byBhbnkg dGVzdHMvIHN1YmRpcmVjdG9yaWVzIHVudGlsIHdlIGhhdmUgYnVpbHQgYWxsIHRoZQorIyBuZWNl c3NhcnkgZGVwZW5kZW50IGxpYnJhcmllcy4KK01LX1RFU1RTOj0gbm8KKy5lbmRpZgorCiAjCiAj IFNldCBkZWZhdWx0cyBmb3IgdGhlIE1LXypfU1VQUE9SVCB2YXJpYWJsZXMuCiAjCg== --001a113490fac4fa2804ea7715a0-- From owner-freebsd-testing@FreeBSD.ORG Wed Nov 6 01:52:31 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A03BBA2F for ; Wed, 6 Nov 2013 01:52:31 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-ve0-x232.google.com (mail-ve0-x232.google.com [IPv6:2607:f8b0:400c:c01::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5BD7425E3 for ; Wed, 6 Nov 2013 01:52:31 +0000 (UTC) Received: by mail-ve0-f178.google.com with SMTP id db12so3126017veb.37 for ; Tue, 05 Nov 2013 17:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Y3o7RQuCFaDNphtcIgclR6M8nWcX7p1vIvClRoOZTps=; b=HE5/aPsXtufJDTJqhcwO2TFlqwFsHsjqOHCmW1M00Mx2zbZhTr6+XuLihmLQ1QA1pF MFKpWpgVQ+RR1ju0S1RXGf/SddvYDLPpTQUTTenxuIyydWoSLios3qWwDu5Y6bjLzq/o 31km9njHbXWIx0i5RoyKogvqejnkvrzkq6ftSVOnEfwFUqAwfp4cfTCkGb6JokpMOQfs wtoxCT4Z3dhz4ElNReH7vsexA+AMdReJAjJSRQF8FYfKtt9Ru5vFXdkE6pl/7fwdSseS UkBmOS5qttvPcthVjz8d3Tp/fPisf3boFb4cMAgmp2Jj/fFagBeI6iIJHZOWwxikKiWq 9YYA== MIME-Version: 1.0 X-Received: by 10.221.64.17 with SMTP id xg17mr324306vcb.5.1383702749413; Tue, 05 Nov 2013 17:52:29 -0800 (PST) Received: by 10.220.14.196 with HTTP; Tue, 5 Nov 2013 17:52:29 -0800 (PST) In-Reply-To: References: Date: Tue, 5 Nov 2013 17:52:29 -0800 Message-ID: Subject: Re: Fixing the build with TESTS From: Garrett Cooper To: Julio Merino Content-Type: multipart/mixed; boundary=001a1133158edae0f204ea7866d2 Cc: "freebsd-testing@freebsd.org" , Rui Paulo X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Nov 2013 01:52:31 -0000 --001a1133158edae0f204ea7866d2 Content-Type: text/plain; charset=ISO-8859-1 On Tue, Nov 5, 2013 at 4:17 PM, Julio Merino wrote: > Hello, > > The previous changes to enable the installation of tests broke the > build and is the reason why Rui had to default the TESTS knob to 'no'. > The reason for the breakage is the following: > > When buildworld starts by building the basic "bootstrap" libraries, it > does a "make all" within various lib/* directories, including > libcrypt. libcrypt had tests added to it, which means that "make all" > recursed into the tests directory and attempted to build them. But, at > that point, the atf libraries had not yet been built. I did not > encounter this issue because I'm running builds with MK_CLEAN=no (yup, > lesson learned). > > I think it's wrong for this stage of buildworld to attempt building > tests at all. atf is just one of the many dependencies we'd encounter, > and we should not try to build all dependencies upfront... because we > cannot. (Just imagine when libc starts getting tests.) > > The fix-build-bootstrap.patch attached attempts to correct this by > explicitly disabling the build of any tests during the initial build > of the bootstrap components. I'm not sure this patch is nice enough, > although it follows the style of various other related knobs; if you > have better ideas, please share. > > Additionally, we will encounter similar issues once we have tests that > use C++ (which we will, if only because of libatf-c++'s tests), so we > should also do what fix-build-atf-cxx.patch proposes. > > Thoughts? I fixed this on my branch some time ago. See this patch for more details (from http://lists.freebsd.org/pipermail/freebsd-toolchain/2013-April/000804.html ) : http://lists.freebsd.org/pipermail/freebsd-toolchain/attachments/20130424/c44daa61/attachment.obj . If you change the former patch to refer to lib/atf instead of lib/atf/libatf-c, things will just work too is the order is properly specified in lib/atf :). I've attached entire up-to-date patch set, just for simplicity. Thanks! -Garrett --001a1133158edae0f204ea7866d2 Content-Type: application/octet-stream; name="bsd.own.mk-patch" Content-Disposition: attachment; filename="bsd.own.mk-patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnnwuseh2 LS0tIHNoYXJlL21rL2JzZC5vd24ubWsJMjAxMy0xMS0wMyAxMzozMjoyNi4wMDAwMDAwMDAgLTA4 MDAKKysrIHNoYXJlL21rL2JzZC5vd24ubWsJMjAxMy0xMS0wNCAxNTo0OTo0My4wMDAwMDAwMDAg LTA4MDAKQEAgLTM3OSw2ICszODMsMTQgQEAKICAgICBURVNUUyBcCiAgICAgVVNCX0dBREdFVF9F WEFNUExFUwogCisjIGJzZC50ZXN0Lm1rIGRvZXNuJ3Qgd29yayB3aXRoICFibWFrZS4gQWxzbyBk b24ndCBidWlsZCB0ZXN0cyBpZiBOT19URVNUUyBpcworIyBkZWZpbmVkOyB0aGlzIGlzIGZvciBi dWlsZHdvcmxkIGFuZCBlbHNld2hlcmUgKHBvcnRzIHBvdGVudGlhbGx5KS4KKy5pZiAhZGVmaW5l ZChOT19URVNUUykKK19fREVGQVVMVF9OT19PUFRJT05TKz1URVNUUworLmVsc2UKK01LX1RFU1RT Oj0Jbm8KKy5lbmRpZgorCiAjCiAjIERlZmF1bHQgYmVoYXZpb3VyIG9mIHNvbWUgb3B0aW9ucyBk ZXBlbmRzIG9uIHRoZSBhcmNoaXRlY3R1cmUuICBVbmZvcnR1bmF0ZWx5CiAjIHRoaXMgbWVhbnMg dGhhdCB3ZSBoYXZlIHRvIHRlc3QgVEFSR0VUX0FSQ0ggKHRoZSBidWlsZHdvcmxkIGNhc2UpIGFz IHdlbGwK --001a1133158edae0f204ea7866d2 Content-Type: application/octet-stream; name="bsd.subdir.mk-patch" Content-Disposition: attachment; filename="bsd.subdir.mk-patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnnwuset3 LS0tIC91c3Ivc3JjLnN2bi9zaGFyZS9tay9ic2Quc3ViZGlyLm1rCTIwMTMtMTEtMDMgMTM6MzI6 MjYuMDAwMDAwMDAwIC0wODAwCisrKyBzaGFyZS9tay9ic2Quc3ViZGlyLm1rCTIwMTMtMTEtMDQg MTU6NDk6NDMuMDAwMDAwMDAwIC0wODAwCkBAIC00Myw2ICs0MywxMSBAQAogLmVuZGZvcgogLmVu ZGlmCiAKKy5pZiAke01LX1RFU1RTfSAhPSAibm8iICYmIGV4aXN0cygkey5DVVJESVJ9L3Rlc3Rz L01ha2VmaWxlKQorU1VCRElSKz0gdGVzdHMKK1NVQkRJUl9UQVJHRVRTKz0gdGVzdAorLmVuZGlm CisKIF9TVUJESVI6IC5VU0UgLk1BS0UKIC5pZiBkZWZpbmVkKFNVQkRJUikgJiYgIWVtcHR5KFNV QkRJUikgJiYgIWRlZmluZWQoTk9fU1VCRElSKQogCUAke18rX31zZXQgLWU7IGZvciBlbnRyeSBp biAke1NVQkRJUn07IGRvIFwK --001a1133158edae0f204ea7866d2 Content-Type: application/octet-stream; name="Makefile.inc1-patch" Content-Disposition: attachment; filename="Makefile.inc1-patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnnwusf24 LS0tIE1ha2VmaWxlLmluYzEJMjAxMy0xMS0wNCAxNTozOTozOS4wMDAwMDAwMDAgLTA4MDAKKysr IE1ha2VmaWxlLmluYzEJMjAxMy0xMS0wNCAxNTo1MTowMy4wMDAwMDAwMDAgLTA4MDAKQEAgLTkx LDYgKzkyLDkgQEAKIC5pZiAke01LX09GRUR9ICE9ICJubyIKIFNVQkRJUis9Y29udHJpYi9vZmVk CiAuZW5kaWYKKy5pZiAke01LX1RFU1RTfSAhPSAibm8iCitTVUJESVIrPXRlc3RzCisuZW5kaWYK ICMKICMgV2UgbXVzdCBkbyBldGMvIGxhc3QgZm9yIGluc3RhbGwvZGlzdHJpYnV0ZSB0byB3b3Jr LgogIwpAQCAtMjQ2LDcgKzI1MCw3IEBACiAJCVNTUF9DRkxBR1M9IFwKIAkJLURXSVRIT1VUX0hU TUwgLURXSVRIT1VUX0lORk8gLUROT19MSU5UIC1EV0lUSE9VVF9NQU4gXAogCQktRE5PX1BJQyAt RE5PX1BST0ZJTEUgLUROT19TSEFSRUQgXAotCQktRE5PX0NQVV9DRkxBR1MgLUROT19XQVJOUyAt RE5PX0NURiAtREVBUkxZX0JVSUxECisJCS1ETk9fQ1BVX0NGTEFHUyAtRE5PX1dBUk5TIC1ETk9f Q1RGIC1ERUFSTFlfQlVJTEQgLUROT19URVNUUwogCiAjIGJ1aWxkLXRvb2xzIHN0YWdlCiBUTUFL RT0JCU1BS0VPQkpESVJQUkVGSVg9JHtPQkpUUkVFfSBcCkBAIC0yNTYsMTIgKzI2MCwxMiBAQAog CQlCT09UU1RSQVBQSU5HPSR7T1NSRUxEQVRFfSBcCiAJCVNTUF9DRkxBR1M9IFwKIAkJLUROT19M SU5UIFwKLQkJLUROT19DUFVfQ0ZMQUdTIC1ETk9fV0FSTlMgLUROT19DVEYgLURFQVJMWV9CVUlM RAorCQktRE5PX0NQVV9DRkxBR1MgLUROT19XQVJOUyAtRE5PX0NURiAtREVBUkxZX0JVSUxEIC1E Tk9fVEVTVFMKIAogIyBjcm9zcy10b29scyBzdGFnZQogWE1BS0U9CQlUT09MU19QUkVGSVg9JHtX T1JMRFRNUH0gJHtCTUFLRX0gXAogCQlUQVJHRVQ9JHtUQVJHRVR9IFRBUkdFVF9BUkNIPSR7VEFS R0VUX0FSQ0h9IFwKLQkJLURXSVRIT1VUX0dEQgorCQktRFdJVEhPVVRfR0RCIC1ETk9fVEVTVFMK IAogIyB3b3JsZCBzdGFnZQogV01BS0VFTlY9CSR7Q1JPU1NFTlZ9IFwKQEAgLTM5OSw3ICs0MDMs OCBAQAogCQktRExJQlJBUklFU19PTkxZIFwKIAkJLUROT19DUFVfQ0ZMQUdTIFwKIAkJLUROT19D VEYgXAotCQktRE5PX0xJTlQKKwkJLUROT19MSU5UIFwKKwkJLUROT19URVNUUwogCiBMSUIzMldN QUtFPQkke0xJQjMyV01BS0VFTlZ9ICR7TUFLRX0gJHtMSUIzMldNQUtFRkxBR1N9IFwKIAkJLURX SVRIT1VUX01BTiAtRFdJVEhPVVRfSU5GTyAtRFdJVEhPVVRfSFRNTApAQCAtNTYzLDcgKzU2Niw3 IEBACiAJQGVjaG8gIi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tIgogCSR7XytffWNkICR7LkNVUkRJUn07IFwKIAkgICAgJHtXTUFL RX0gLUROT19GU0NIRyAtRFdJVEhPVVRfSFRNTCAtRFdJVEhPVVRfSU5GTyAtRE5PX0xJTlQgXAot CSAgICAtRFdJVEhPVVRfTUFOIC1ETk9fUFJPRklMRSBsaWJyYXJpZXMKKwkgICAgLURXSVRIT1VU X01BTiAtRE5PX1BST0ZJTEUgLUROT19URVNUUyBsaWJyYXJpZXMKIF9kZXBlbmQ6CiAJQGVjaG8K IAlAZWNobyAiLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0iCkBAIC0xNDg3LDcgKzE0NzgsNyBAQAogCQkke19rZXJiZXJvczVfbGli X2xpYmh4NTA5fSAke19rZXJiZXJvczVfbGliX2xpYmtyYjV9IFwKIAkJJHtfa2VyYmVyb3M1X2xp Yl9saWJyb2tlbn0gXAogCQkke19rZXJiZXJvczVfbGliX2xpYndpbmR9IFwKLQkJJHtfbGliX2F0 Zl9saWJhdGZfY30gXAorCQkke19saWJfYXRmfSBcCiAJCWxpYi9saWJiejIgJHtfbGliY29tX2Vy cn0gbGliL2xpYmNyeXB0IFwKIAkJbGliL2xpYmVsZiBsaWIvbGliZXhwYXQgXAogCQkke19saWJf bGliZ3NzYXBpfSAke19saWJfbGliaXB4fSBcCkBAIC0xNTAyLDcgKzE0OTMsNyBAQAogCQkke19z ZWN1cmVfbGliX2xpYnNzaH0gJHtfc2VjdXJlX2xpYl9saWJzc2x9CiAKIC5pZiAke01LX0FURn0g IT0gIm5vIgotX2xpYl9hdGZfbGliYXRmX2M9CWxpYi9hdGYvbGliYXRmLWMKK19saWJfYXRmPQls aWIvYXRmCiAuZW5kaWYKIAogLmlmICR7TUtfTElCVEhSfSAhPSAibm8iCkBAIC0xODY2LDcgKzE4 NTksNyBAQAogCiBOT0ZVTj0tRE5PX0ZTQ0hHIC1EV0lUSE9VVF9IVE1MIC1EV0lUSE9VVF9JTkZP IC1ETk9fTElOVCBcCiAJLURXSVRIT1VUX01BTiAtRFdJVEhPVVRfTkxTIC1ETk9fUFJPRklMRSBc Ci0JLURXSVRIT1VUX0tFUkJFUk9TIC1EV0lUSE9VVF9SRVNDVUUgLUROT19XQVJOUyBcCisJLURX SVRIT1VUX0tFUkJFUk9TIC1EV0lUSE9VVF9SRVNDVUUgLUROT19URVNUUyAtRE5PX1dBUk5TIFwK IAlUQVJHRVQ9JHtYREVWfSBUQVJHRVRfQVJDSD0ke1hERVZfQVJDSH0gXAogCUNQVVRZUEU9JHtY REVWX0NQVVRZUEV9CiAK --001a1133158edae0f204ea7866d2-- From owner-freebsd-testing@FreeBSD.ORG Wed Nov 6 03:26:38 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9485634D for ; Wed, 6 Nov 2013 03:26:38 +0000 (UTC) (envelope-from julio@meroh.net) Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com [209.85.217.173]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 086992BDF for ; Wed, 6 Nov 2013 03:26:37 +0000 (UTC) Received: by mail-lb0-f173.google.com with SMTP id w7so7199771lbi.4 for ; Tue, 05 Nov 2013 19:26:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=Zgqs3K4+rpGxSjj/PY2deDJy4OAZ9zIv9bZPuYLsg9c=; b=GM7AB+kKniheLSUJzRBAOGyKbazW1W4tjp3ce5HchDPkcNhGypDT+ZRuk6IY14y6NQ cXTUf5LmZXFXTP4C/DEZgrWIz+M3HIczGlJP7m5e+NjsyEbCOBXhNaIeS+QZN9zVxaD5 Zzq0uIpzarssVVSl1VojZJzTSuxzpfrkjXqcnzRkezRKrO/xu0Hk8CyJ3qckc+dDHEqx DrDTcLAupo3SNoyb11wTgw7r4TIU1pUFUk+9/ZIde7+FfFwG7wqGywoyae+puKEiKQ63 QPT/x1iL/FoQmqQQWOD39+5z+/RNWigVW//8fl9Zm9h/XAoRO7AXLPdRCZ8g8faQm6Uh QzNg== X-Gm-Message-State: ALoCoQk5Nq3MKaNTz7lMZ00/ThXPa0rgjh5zPyCzxy6h+8eJlvcRx4+St3OEN8luli6Rs2vwneRl X-Received: by 10.112.155.70 with SMTP id vu6mr35251lbb.41.1383708389970; Tue, 05 Nov 2013 19:26:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.132.135 with HTTP; Tue, 5 Nov 2013 19:26:08 -0800 (PST) X-Originating-IP: [172.26.38.22] In-Reply-To: References: From: Julio Merino Date: Tue, 5 Nov 2013 22:26:08 -0500 Message-ID: Subject: Re: Fixing the build with TESTS To: Garrett Cooper Content-Type: multipart/mixed; boundary=089e0115fe1e0eb79504ea79b73b Cc: Rui Paulo , freebsd-testing@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Nov 2013 03:26:38 -0000 --089e0115fe1e0eb79504ea79b73b Content-Type: text/plain; charset=ISO-8859-1 On Tue, Nov 05, 2013 at 05:52:29PM -0800, Garrett Cooper wrote: > I fixed this on my branch some time ago. See this patch for more > details (from http://lists.freebsd.org/pipermail/freebsd-toolchain/2013-April/000804.html > ) : http://lists.freebsd.org/pipermail/freebsd-toolchain/attachments/20130424/c44daa61/attachment.obj > . > > If you change the former patch to refer to lib/atf instead of > lib/atf/libatf-c, things will just work too is the order is properly > specified in lib/atf :). > > I've attached entire up-to-date patch set, just for simplicity. I like your approach more. However, it seems that your change to bsd.own.mk could be better handled by the existing NO_* functionality, couldn't it? Updated the two patches and descriptions accordingly. Please take another look! --089e0115fe1e0eb79504ea79b73b Content-Type: text/x-diff; charset=us-ascii; name="fix-build-all-atf.diff" Content-Disposition: attachment; filename="fix-build-all-atf.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: b6c564a9ff829e83_0.1 QWRkIGxpYmF0Zi1jKysgdG8gdGhlIHByZWJ1aWxkIGxpYnMuDQoNClNvbWUgdGVzdHMgbWF5IHJl cXVpcmUgQysrIHNvIHdlIG11c3QgZW5zdXJlIHRoaXMgbGlicmFyeSBleGlzdHMgYXMgcGFydA0K b2YgdGhlIGJvb3RzdHJhcCBwcm9jZXNzIG9yIGVsc2UgdGhleSB3aWxsIGZhaWwgdG8gYnVpbGQu ICBEbyB0aGlzIGJ5DQpqdXN0IGRlcGVuZGluZyBvbiBsaWIvYXRmIGFzIHBhcnQgb2YgdGhlIGJv b3RzdHJhcCBsaWJyYXJpZXMgaW5zdGVhZCBvZg0KdXNpbmcgbGliL2F0Zi9saWJhdGYtYy4NCg0K U3VibWl0dGVkIGJ5OglHYXJyZXR0IENvb3BlciA8eWFuZXVyYWJleWEgYXQgZ21haWwgZG90IGNv bT4NCg0KSW5kZXg6IGhlYWQvTWFrZWZpbGUuaW5jMQ0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIGhlYWQub3Jp Zy9NYWtlZmlsZS5pbmMxDQorKysgaGVhZC9NYWtlZmlsZS5pbmMxDQpAQCAtMTQ4OCw3ICsxNDg4 LDcgQEAgX3ByZWJ1aWxkX2xpYnM9CSR7X2tlcmJlcm9zNV9saWJfbGliYXNuMQ0KIAkJJHtfa2Vy YmVyb3M1X2xpYl9saWJoeDUwOX0gJHtfa2VyYmVyb3M1X2xpYl9saWJrcmI1fSBcDQogCQkke19r ZXJiZXJvczVfbGliX2xpYnJva2VufSBcDQogCQkke19rZXJiZXJvczVfbGliX2xpYndpbmR9IFwN Ci0JCSR7X2xpYl9hdGZfbGliYXRmX2N9IFwNCisJCSR7X2xpYl9hdGZ9IFwNCiAJCWxpYi9saWJi ejIgJHtfbGliY29tX2Vycn0gbGliL2xpYmNyeXB0IFwNCiAJCWxpYi9saWJlbGYgbGliL2xpYmV4 cGF0IFwNCiAJCSR7X2xpYl9saWJnc3NhcGl9ICR7X2xpYl9saWJpcHh9IFwNCkBAIC0xNTAzLDcg KzE1MDMsNyBAQCBfcHJlYnVpbGRfbGlicz0JJHtfa2VyYmVyb3M1X2xpYl9saWJhc24xDQogCQkk e19zZWN1cmVfbGliX2xpYnNzaH0gJHtfc2VjdXJlX2xpYl9saWJzc2x9DQogDQogLmlmICR7TUtf QVRGfSAhPSAibm8iDQotX2xpYl9hdGZfbGliYXRmX2M9CWxpYi9hdGYvbGliYXRmLWMNCitfbGli X2F0Zj0JbGliL2F0Zg0KIC5lbmRpZg0KIA0KIC5pZiAke01LX0xJQlRIUn0gIT0gIm5vIg0K --089e0115fe1e0eb79504ea79b73b Content-Type: text/x-diff; charset=us-ascii; name="fix-build-bootstrap.diff" Content-Disposition: attachment; filename="fix-build-bootstrap.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: b6c564a9ff829e83_0.3 Rml4IGJ1aWxkd29ybGQgd2hlbiBXSVRIX1RFU1RTIGlzIGVuYWJsZWQuDQoNClRoZSBhZGRpdGlv biBvZiB0aGUgVEVTVFMga25vYiBhbmQgaXRzIGVuYWJsaW5nIG9mIHRoZSBidWlsZCBvZiB0ZXN0 cyBpbg0KbGliL2xpYmNyeXB0L3Rlc3RzLyBicm9rZSB0aGUgYnVpbGQuICBUaGUgcmVhc29uIGlz IHRoYXQgd2UgY2Fubm90IGRlc2NlbmQNCmludG8gdGVzdHMvIHN1YmRpcmVjdG9yaWVzIHVudGls IGFsbCBwcmVyZXF1aXNpdGVzIGhhdmUgYmVlbiBidWlsdCwgd2hpY2gNCmluIHRoZSBjYXNlIG9m IHRlc3RzIG1heSBiZSAiYSBsb3Qgb2YgdGhpbmdzIiAobGliYXRmLWMgaW4gdGhpcyBjYXNlKS4N Cg0KRW5zdXJlIHRoYXQgd2UgZG8gbm90IHdhbGsgdGVzdHMvIGRpcmVjdG9yaWVzIGR1cmluZyB0 aGUgYm9vdHN0cmFwcGluZyBvZg0KdGhlIGxpYnJhcmllcyBhcyBwYXJ0IG9mIGJ1aWxkd29ybGQu DQoNClN1Ym1pdHRlZCBieToJR2FycmV0dCBDb29wZXIgPHlhbmV1cmFiZXlhIGF0IGdtYWlsIGRv dCBjb20+DQoNCkluZGV4OiBoZWFkL01ha2VmaWxlLmluYzENCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBoZWFk Lm9yaWcvTWFrZWZpbGUuaW5jMQ0KKysrIGhlYWQvTWFrZWZpbGUuaW5jMQ0KQEAgLTI0Niw3ICsy NDYsNyBAQCBCTUFLRT0JCU1BS0VPQkpESVJQUkVGSVg9JHtXT1JMRFRNUH0gXA0KIAkJU1NQX0NG TEFHUz0gXA0KIAkJLURXSVRIT1VUX0hUTUwgLURXSVRIT1VUX0lORk8gLUROT19MSU5UIC1EV0lU SE9VVF9NQU4gXA0KIAkJLUROT19QSUMgLUROT19QUk9GSUxFIC1ETk9fU0hBUkVEIFwNCi0JCS1E Tk9fQ1BVX0NGTEFHUyAtRE5PX1dBUk5TIC1ETk9fQ1RGIC1ERUFSTFlfQlVJTEQNCisJCS1ETk9f Q1BVX0NGTEFHUyAtRE5PX1dBUk5TIC1ETk9fQ1RGIC1ERUFSTFlfQlVJTEQgLUROT19URVNUUw0K IA0KICMgYnVpbGQtdG9vbHMgc3RhZ2UNCiBUTUFLRT0JCU1BS0VPQkpESVJQUkVGSVg9JHtPQkpU UkVFfSBcDQpAQCAtMjU2LDEyICsyNTYsMTIgQEAgVE1BS0U9CQlNQUtFT0JKRElSUFJFRklYPSR7 T0JKVFJFRX0gXA0KIAkJQk9PVFNUUkFQUElORz0ke09TUkVMREFURX0gXA0KIAkJU1NQX0NGTEFH Uz0gXA0KIAkJLUROT19MSU5UIFwNCi0JCS1ETk9fQ1BVX0NGTEFHUyAtRE5PX1dBUk5TIC1ETk9f Q1RGIC1ERUFSTFlfQlVJTEQNCisJCS1ETk9fQ1BVX0NGTEFHUyAtRE5PX1dBUk5TIC1ETk9fQ1RG IC1ERUFSTFlfQlVJTEQgLUROT19URVNUUw0KIA0KICMgY3Jvc3MtdG9vbHMgc3RhZ2UNCiBYTUFL RT0JCVRPT0xTX1BSRUZJWD0ke1dPUkxEVE1QfSAke0JNQUtFfSBcDQogCQlUQVJHRVQ9JHtUQVJH RVR9IFRBUkdFVF9BUkNIPSR7VEFSR0VUX0FSQ0h9IFwNCi0JCS1EV0lUSE9VVF9HREINCisJCS1E V0lUSE9VVF9HREIgLUROT19URVNUUw0KIA0KICMgd29ybGQgc3RhZ2UNCiBXTUFLRUVOVj0JJHtD Uk9TU0VOVn0gXA0KQEAgLTM5OSw3ICszOTksOCBAQCBMSUIzMldNQUtFRkxBR1MrPQlcDQogCQkt RExJQlJBUklFU19PTkxZIFwNCiAJCS1ETk9fQ1BVX0NGTEFHUyBcDQogCQktRE5PX0NURiBcDQot CQktRE5PX0xJTlQNCisJCS1ETk9fTElOVCBcDQorCQktRE5PX1RFU1RTDQogDQogTElCMzJXTUFL RT0JJHtMSUIzMldNQUtFRU5WfSAke01BS0V9ICR7TElCMzJXTUFLRUZMQUdTfSBcDQogCQktRFdJ VEhPVVRfTUFOIC1EV0lUSE9VVF9JTkZPIC1EV0lUSE9VVF9IVE1MDQpAQCAtNTYzLDcgKzU2NCw3 IEBAIF9saWJyYXJpZXM6DQogCUBlY2hvICItLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSINCiAJJHtfK199Y2QgJHsuQ1VSRElSfTsg XA0KIAkgICAgJHtXTUFLRX0gLUROT19GU0NIRyAtRFdJVEhPVVRfSFRNTCAtRFdJVEhPVVRfSU5G TyAtRE5PX0xJTlQgXA0KLQkgICAgLURXSVRIT1VUX01BTiAtRE5PX1BST0ZJTEUgbGlicmFyaWVz DQorCSAgICAtRFdJVEhPVVRfTUFOIC1ETk9fUFJPRklMRSAtRE5PX1RFU1RTIGxpYnJhcmllcw0K IF9kZXBlbmQ6DQogCUBlY2hvDQogCUBlY2hvICItLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSINCkBAIC0xODY2LDcgKzE4NjcsNyBA QCBYREVWX0NQVVRZUEU/PSR7VEFSR0VUX0NQVVRZUEV9DQogDQogTk9GVU49LUROT19GU0NIRyAt RFdJVEhPVVRfSFRNTCAtRFdJVEhPVVRfSU5GTyAtRE5PX0xJTlQgXA0KIAktRFdJVEhPVVRfTUFO IC1EV0lUSE9VVF9OTFMgLUROT19QUk9GSUxFIFwNCi0JLURXSVRIT1VUX0tFUkJFUk9TIC1EV0lU SE9VVF9SRVNDVUUgLUROT19XQVJOUyBcDQorCS1EV0lUSE9VVF9LRVJCRVJPUyAtRFdJVEhPVVRf UkVTQ1VFIC1ETk9fVEVTVFMgLUROT19XQVJOUyBcDQogCVRBUkdFVD0ke1hERVZ9IFRBUkdFVF9B UkNIPSR7WERFVl9BUkNIfSBcDQogCUNQVVRZUEU9JHtYREVWX0NQVVRZUEV9DQogDQpJbmRleDog aGVhZC9zaGFyZS9tay9ic2Qub3duLm1rDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gaGVhZC5vcmlnL3NoYXJl L21rL2JzZC5vd24ubWsNCisrKyBoZWFkL3NoYXJlL21rL2JzZC5vd24ubWsNCkBAIC0yMjcsNyAr MjI3LDggQEAgQ09NUFJFU1NfRVhUPz0JLmd6DQogICAgIERFQlVHX0ZJTEVTIFwNCiAgICAgSU5T VEFMTExJQiBcDQogICAgIE1BTiBcDQotICAgIFBST0ZJTEUNCisgICAgUFJPRklMRSBcDQorICAg IFRFU1RTDQogLmlmIGRlZmluZWQoTk9fJHt2YXJ9KQ0KIC5pZiBkZWZpbmVkKFdJVEhfJHt2YXJ9 KQ0KIC51bmRlZiBXSVRIXyR7dmFyfQ0K --089e0115fe1e0eb79504ea79b73b-- From owner-freebsd-testing@FreeBSD.ORG Wed Nov 6 17:15:14 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4DC07E29 for ; Wed, 6 Nov 2013 17:15:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-vb0-x22a.google.com (mail-vb0-x22a.google.com [IPv6:2607:f8b0:400c:c02::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0DB5E2E0C for ; Wed, 6 Nov 2013 17:15:13 +0000 (UTC) Received: by mail-vb0-f42.google.com with SMTP id p14so3672398vbm.29 for ; Wed, 06 Nov 2013 09:15:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=/QxwOeJnm040iZU1dUKuKp3Ln1MPDFN+Q8tnlgpVIwc=; b=H2JWceFu6NE1RHHb6F/aa6h5ceMRgzALSmingK9YRNKTRoYRGY5bGQbkpfSSvNUaeV secT4dVzbtCCIXRDIYrUKXJUUfjeTYB/YgZFmR4zSP9rLgv8AtqZxyhmbffJDfA3J2gE n12hJsJGbiPAAKn2M/6LgyPq5jb6ozz4T+YGlH47SwonBWVyVaWwy4JqCEJ6AHxxWZJx SHPmOTs0iICJWlnlL4ptmvKEXCi1IR5dEXfjCBjvnoTkFXp2BUlNlmhIS7wLe/HhrS3b u0zGhTmJ4n3b/XFTlc84bi4dBtZdYMuAyH9QQD2sDBEbuGECOFMwICPbgmukjh05VXLC eVQA== MIME-Version: 1.0 X-Received: by 10.220.253.66 with SMTP id mz2mr3319168vcb.10.1383758113203; Wed, 06 Nov 2013 09:15:13 -0800 (PST) Received: by 10.220.14.196 with HTTP; Wed, 6 Nov 2013 09:15:13 -0800 (PST) In-Reply-To: References: Date: Wed, 6 Nov 2013 09:15:13 -0800 Message-ID: Subject: Re: Fixing the build with TESTS From: Garrett Cooper To: Julio Merino Content-Type: text/plain; charset=ISO-8859-1 Cc: Rui Paulo , "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Nov 2013 17:15:14 -0000 On Tue, Nov 5, 2013 at 7:26 PM, Julio Merino wrote: > On Tue, Nov 05, 2013 at 05:52:29PM -0800, Garrett Cooper wrote: >> I fixed this on my branch some time ago. See this patch for more >> details (from http://lists.freebsd.org/pipermail/freebsd-toolchain/2013-April/000804.html >> ) : http://lists.freebsd.org/pipermail/freebsd-toolchain/attachments/20130424/c44daa61/attachment.obj >> . >> >> If you change the former patch to refer to lib/atf instead of >> lib/atf/libatf-c, things will just work too is the order is properly >> specified in lib/atf :). >> >> I've attached entire up-to-date patch set, just for simplicity. > > I like your approach more. However, it seems that your change to > bsd.own.mk could be better handled by the existing NO_* functionality, > couldn't it? > > Updated the two patches and descriptions accordingly. > Please take another look! It's a little bit trickier than that; my updated diff doesn't take bmake into account as I was able to unbmake-ify atf.tests.mk, bsd.tests.mk, and bsd.progs.mk. The original diff for bsd.own.mk looked like this: +# bsd.test.mk doesn't work with !bmake. Also don't build tests if NO_TESTS is +# defined; this is for buildworld and elsewhere (ports potentially). +.if defined(.PARSEDIR) && !defined(NO_TESTS) +__DEFAULT_NO_OPTIONS+=TESTS +.else +MK_TESTS:= no +.endif But I agree, yes.. that's no longer necessary on my branch. Thanks! -Garrett