From owner-freebsd-toolchain@FreeBSD.ORG Mon Apr 22 11:06:53 2013 Return-Path: Delivered-To: freebsd-toolchain@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 5517261D for ; Mon, 22 Apr 2013 11:06:53 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 2B8D81095 for ; Mon, 22 Apr 2013 11:06:53 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3MB6rYS089299 for ; Mon, 22 Apr 2013 11:06:53 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3MB6q2q089297 for freebsd-toolchain@FreeBSD.org; Mon, 22 Apr 2013 11:06:52 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 22 Apr 2013 11:06:52 GMT Message-Id: <201304221106.r3MB6q2q089297@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-toolchain@FreeBSD.org Subject: Current problem reports assigned to freebsd-toolchain@FreeBSD.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2013 11:06:53 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o bin/175930 toolchain [headers] clang does not define __STDC_ISO_10646__, de 1 problem total. From owner-freebsd-toolchain@FreeBSD.ORG Mon Apr 22 12:28:52 2013 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 176CD167; Mon, 22 Apr 2013 12:28:52 +0000 (UTC) (envelope-from barbara@nieriargenti.it) Received: from smtp.ispservice.it (ip-47-123.sn2.eutelia.it [83.211.47.123]) by mx1.freebsd.org (Postfix) with ESMTP id 8492717A7; Mon, 22 Apr 2013 12:28:50 +0000 (UTC) Received: from nieriargenti.it ([111.144.23.118]) (authenticated bits=0) by smtp.ispservice.it (8.14.1/8.13.4) with ESMTP id r3MCJLoc010321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 22 Apr 2013 14:19:32 +0200 Message-ID: Date: Mon, 22 Apr 2013 15:19:38 +0300 From: "" X-Accept-Language: en-us MIME-Version: 1.0 To: , Subject: =?US-ASCII?B?VG9wIG5vdGNoIENvcHkgd2F0Y2hlcyBmb3Igc2VyaW91cyB0cmVuZHNldHRlcnM=?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2013 12:28:52 -0000 People judge you by the clothes you wear and the watch on your wrist - first impressions count http://u2s.su/jeq From owner-freebsd-toolchain@FreeBSD.ORG Tue Apr 23 16:39:09 2013 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E89785D7; Tue, 23 Apr 2013 16:39:09 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by mx1.freebsd.org (Postfix) with ESMTP id BF9331FDD; Tue, 23 Apr 2013 16:39:09 +0000 (UTC) Received: by mail-pa0-f49.google.com with SMTP id kp14so606793pab.36 for ; Tue, 23 Apr 2013 09:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:x-mailer:from:subject:date :to; bh=R7LoHx2D1x2qwhZ7P84bXgBVcp/A6S41glS8KEketLI=; b=hvaRr3VjhZSNgnbVySqENWh8ga6NZm+CzAXgF2tsFkbuXMERud6PhJRNBZ0U14uMWe Dc4bEgKt4VyaVpOzUVMZy3mW+8GHzg+jsZbpWcP6WD7mJOJdIKSWW4jZVJJz89oyviev 2JWOZAoZM9UTkNPsGelONzAdY88QkTuSjsopNp1epdIh4k6B60oxRySNCSeE5fWJ3C9N zWRYWrRs8M/Zl7n9JztiFgGJFZ1YieCdrtA7TLLDyqc99Z05dwuvnmwUQaosymn230WA DOuFQzuRrNfNiqZSYpMqFZHzsuN6lNN4mj9uOP6Cys31zsa3qNXO03ULWQisF/iRdvGS AKWQ== X-Received: by 10.66.232.230 with SMTP id tr6mr31698083pac.83.1366735149147; Tue, 23 Apr 2013 09:39:09 -0700 (PDT) Received: from [10.43.238.124] (mobile-166-147-080-091.mycingular.net. [166.147.80.91]) by mx.google.com with ESMTPS id ak1sm30188765pbc.10.2013.04.23.09.39.06 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Apr 2013 09:39:08 -0700 (PDT) References: Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: X-Mailer: iPhone Mail (10B329) From: Garrett Cooper Subject: Re: [RFC] [Optionally] build tests with buildworld Date: Tue, 23 Apr 2013 09:39:03 -0700 To: "arch@FreeBSD.org" , "toolchain@FreeBSD.org" Cc: "Simon J. Gerraty" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2013 16:39:10 -0000 On Apr 19, 2013, at 11:17 PM, Garrett Cooper wrote: > Hi arch@ and toolchain@, > One of the items that I'm proposing be added to Makefile.inc1 in > order to make building and installing tests on CURRENT (ATF and > otherwise) is a build knob called TESTS_WITH_WORLD (the name can be > modified), which allows me to build and install various tests on my > git branch like the example ATF tests I produced, pjdfstest, some of > the prove tests from tools/regression, etc (there are other > outstanding changes, but this was the key one that I need feedback on > just to be safe). > The effective change is attached (Gmail will no doubt mangle it, > so please let me know if you want another copy). I made the change to > Makefile.inc1 in order to ensure that the change was self-contained > and because it was the simplest, cleanest way to do things without > introducing a lot of unwanted complexity. > I'm asking for feedback on the following items: > 1. Does the change make functional sense? If not, why? > 2. Do the semantics (variable names, whether or not they're > defined) need to be modified to match MK_* semantics or be made more > consistent in any particular way? If so, why? > 3. Will anyone have serious heartburn (already have a similar > change implemented, think it's done in a backwards manner) if this > change is implemented? If so, why? > Thanks! > -Garrett >=20 > PS Please CC me on all replies as I'm not subscribed to the list. > Ping? If no one replies in a week I'll consider it implicit agreement :)= .. Thanks, -Garrett= From owner-freebsd-toolchain@FreeBSD.ORG Tue Apr 23 16:59:54 2013 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id DF052183; Tue, 23 Apr 2013 16:59:54 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id 21DAA10F0; Tue, 23 Apr 2013 16:59:53 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.5/8.14.5) with ESMTP id r3NGxwtP091665; Tue, 23 Apr 2013 11:59:58 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.5/8.14.5/Submit) id r3NGxwpG091664; Tue, 23 Apr 2013 11:59:58 -0500 (CDT) (envelope-from brooks) Date: Tue, 23 Apr 2013 11:59:58 -0500 From: Brooks Davis To: Garrett Cooper Subject: Re: [RFC] [Optionally] build tests with buildworld Message-ID: <20130423165958.GA91607@lor.one-eyed-alien.net> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: arch@freebsd.org, "Simon J. Gerraty" , toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2013 16:59:54 -0000 --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 19, 2013 at 11:17:50PM -0700, Garrett Cooper wrote: > Hi arch@ and toolchain@, > One of the items that I'm proposing be added to Makefile.inc1 in > order to make building and installing tests on CURRENT (ATF and > otherwise) is a build knob called TESTS_WITH_WORLD (the name can be > modified), which allows me to build and install various tests on my > git branch like the example ATF tests I produced, pjdfstest, some of > the prove tests from tools/regression, etc (there are other > outstanding changes, but this was the key one that I need feedback on > just to be safe). I don't understand way you don't use WITH_TESTS processed through bsd.own.mk. You'd presumably have to add it to the list of supported NO_* options for the bootstrap case, but that's trivial. Then you use could use normal MK_* variables. That would also let you use WITH(OUT)_TESTS in individual directories and they would always work. At a glance using WITHOUT_TESTS and NO_TEST internally would simplify some of the special cases in your patch. On a side note, I like the HMAKE change independent of the rest of the patch. -- Brooks --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFRdr4NXY6L6fI4GtQRAoJcAKCDe1KqUkRo/Jwss2TBwL8LEXWt4ACgyRqL FZmO4CxJZE5hRtxoE00tYH0= =gPvz -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK-- From owner-freebsd-toolchain@FreeBSD.ORG Tue Apr 23 17:28:47 2013 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 5CAA1F76; Tue, 23 Apr 2013 17:28:47 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by mx1.freebsd.org (Postfix) with ESMTP id 28CDD1285; Tue, 23 Apr 2013 17:28:47 +0000 (UTC) Received: by mail-pa0-f53.google.com with SMTP id bh4so631469pad.12 for ; Tue, 23 Apr 2013 10:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:subject:mime-version:content-type:from:in-reply-to:date :cc:content-transfer-encoding:message-id:references:to:x-mailer; bh=MVDWPTHNYYS4fVs5dRvhlABR0qks+Z5qkwT5ge6b4KI=; b=bGFzWIA/khdEiJ1u6TDkTU7sgP8X04EntXp/KSh8LOy6+IxcXKdlvvJlQ0Qkv/oUvw EYN7P39TTVKhSunq8SrbJTtrZ+I6SPFxEMY5ZotwqWitDMTKqjIA86DF7ViH6uQTIJ1r cFOjNLKom/0OusBaM5CWXOanPCsABcE4GwL7TFEFwQ2GPcPjNCqiZoMwQtMoqeU92oy7 AlYU+YaALPHBlvx68cMV8o6r9d9cVRkpZehB8ykzRl8sdwKPaZ/nANWE32Bz9PfrSX1p bjk4GgRegt4ioLNHkaBofuF8MSSsQG/pIJag7q+RZjhCYiIlGPDIDmRv0pTANDnqYiZV xIOA== X-Received: by 10.67.1.69 with SMTP id be5mr14689822pad.154.1366738126791; Tue, 23 Apr 2013 10:28:46 -0700 (PDT) Received: from fuji-wireless.local (c-98-203-241-95.hsd1.wa.comcast.net. [98.203.241.95]) by mx.google.com with ESMTPS id qh4sm32636986pac.8.2013.04.23.10.28.45 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Apr 2013 10:28:46 -0700 (PDT) Subject: Re: [RFC] [Optionally] build tests with buildworld Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Garrett Cooper In-Reply-To: <20130423165958.GA91607@lor.one-eyed-alien.net> Date: Tue, 23 Apr 2013 10:28:44 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <1D2E12CF-08F2-4151-AB33-84C4270CFBC6@gmail.com> References: <20130423165958.GA91607@lor.one-eyed-alien.net> To: Brooks Davis X-Mailer: Apple Mail (2.1283) Cc: arch@freebsd.org, "Simon J. Gerraty" , benno@FreeBSD.org, toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2013 17:28:47 -0000 Hi Brooks! On Apr 23, 2013, at 9:59 AM, Brooks Davis wrote: > On Fri, Apr 19, 2013 at 11:17:50PM -0700, Garrett Cooper wrote: >> Hi arch@ and toolchain@, >> One of the items that I'm proposing be added to Makefile.inc1 in >> order to make building and installing tests on CURRENT (ATF and >> otherwise) is a build knob called TESTS_WITH_WORLD (the name can be >> modified), which allows me to build and install various tests on my >> git branch like the example ATF tests I produced, pjdfstest, some of >> the prove tests from tools/regression, etc (there are other >> outstanding changes, but this was the key one that I need feedback on >> just to be safe). >=20 > I don't understand way you don't use WITH_TESTS processed > through bsd.own.mk. You'd presumably have to add it to the list of > supported NO_* options for the bootstrap case, but that's trivial. = Then > you use could use normal MK_* variables. That would also let you use > WITH(OUT)_TESTS in individual directories and they would always work. >=20 > At a glance using WITHOUT_TESTS and NO_TEST internally would simplify > some of the special cases in your patch. This is something that I considered, but I wasn't sure that it was the = best route to go about things because I thought we were doing away/had = done away with most of the NO_* knobs (and unfortunately one cannot mix = and match WITH_* and WITHOUT_* because they're considered contradictory = according to bsd.own.mk -- something that Simon has debated against = having in the past). I'm all for doing that though because that would simplify things greatly = from an end-user perspective. > On a side note, I like the HMAKE change independent of the rest of the > patch. Cool! I'll polish up the patch with that piece and send it over to = benno@ :). Thanks! -Garrett= From owner-freebsd-toolchain@FreeBSD.ORG Wed Apr 24 16:15:33 2013 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id F1FA4661; Wed, 24 Apr 2013 16:15:32 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pb0-x236.google.com (mail-pb0-x236.google.com [IPv6:2607:f8b0:400e:c01::236]) by mx1.freebsd.org (Postfix) with ESMTP id B8EBB1E34; Wed, 24 Apr 2013 16:15:32 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id jt11so502995pbb.13 for ; Wed, 24 Apr 2013 09:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:subject:mime-version:content-type:from:in-reply-to:date :cc:message-id:references:to:x-mailer; bh=trBYWrygjfr4Y9aWKUQnGBvNpF70HuP6/KZryXOS6Wg=; b=sHJC94k78hkUDTTqWUBZ0eOF1T6oHoxykFMhASReVVzaiaOlfVCrH65rKBm3mMZEc5 Ns7YzEHohviNd1wBAvTnzHnOCuxXJsmsJCFZbDhMP3nfBNX9yLEkQl/pF+HJWJAyJFJR a3tvkqpvb5hR292yhD62KaaNUOvXVLzqbgKScitklyW5iwzRbzgb/U1QgsdPNR3VoV0N quCuPJqkPRLY1vlFRP5tLWmdwOEb9GIBp01hbPz52crjySnpIXhAPv6yLsqz3Zs0J3ob 89Z9eu/8HeXDYh/iO4139tpNcg27vhS1dXDpiUgLNTE9ttzvmjY6fqgHSrZvbHM1+FII 30gA== X-Received: by 10.68.11.73 with SMTP id o9mr17793307pbb.18.1366820132509; Wed, 24 Apr 2013 09:15:32 -0700 (PDT) Received: from fuji-wireless.local (c-98-203-241-95.hsd1.wa.comcast.net. [98.203.241.95]) by mx.google.com with ESMTPSA id t1sm4209257pab.12.2013.04.24.09.15.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 24 Apr 2013 09:15:31 -0700 (PDT) Subject: Re: [RFC] [Optionally] build tests with buildworld Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: multipart/mixed; boundary="Apple-Mail=_8DBC637E-2732-44C7-A30E-A2898AE64D0E" From: Garrett Cooper In-Reply-To: <1D2E12CF-08F2-4151-AB33-84C4270CFBC6@gmail.com> Date: Wed, 24 Apr 2013 09:15:30 -0700 Message-Id: References: <20130423165958.GA91607@lor.one-eyed-alien.net> <1D2E12CF-08F2-4151-AB33-84C4270CFBC6@gmail.com> To: Brooks Davis X-Mailer: Apple Mail (2.1283) Cc: arch@freebsd.org, "Simon J. Gerraty" , benno@FreeBSD.org, toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2013 16:15:33 -0000 --Apple-Mail=_8DBC637E-2732-44C7-A30E-A2898AE64D0E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Apr 23, 2013, at 10:28 AM, Garrett Cooper wrote: > On Apr 23, 2013, at 9:59 AM, Brooks Davis wrote: >=20 >> On Fri, Apr 19, 2013 at 11:17:50PM -0700, Garrett Cooper wrote: >>> Hi arch@ and toolchain@, >>> One of the items that I'm proposing be added to Makefile.inc1 in >>> order to make building and installing tests on CURRENT (ATF and >>> otherwise) is a build knob called TESTS_WITH_WORLD (the name can be >>> modified), which allows me to build and install various tests on my >>> git branch like the example ATF tests I produced, pjdfstest, some of >>> the prove tests from tools/regression, etc (there are other >>> outstanding changes, but this was the key one that I need feedback = on >>> just to be safe). >>=20 >> I don't understand way you don't use WITH_TESTS processed >> through bsd.own.mk. You'd presumably have to add it to the list of >> supported NO_* options for the bootstrap case, but that's trivial. = Then >> you use could use normal MK_* variables. That would also let you use >> WITH(OUT)_TESTS in individual directories and they would always work. >>=20 >> At a glance using WITHOUT_TESTS and NO_TEST internally would simplify >> some of the special cases in your patch. >=20 > This is something that I considered, but I wasn't sure that it was the = best route to go about things because I thought we were doing away/had = done away with most of the NO_* knobs (and unfortunately one cannot mix = and match WITH_* and WITHOUT_* because they're considered contradictory = according to bsd.own.mk -- something that Simon has debated against = having in the past). >=20 > I'm all for doing that though because that would simplify things = greatly from an end-user perspective. Hi Brooks! Does this look ok? Most of the MK_TESTS logic has been shoved = into bsd.own.mk and NO_TESTS is sprinkled around Makefile.inc1 as = recommended. Thanks! -Garrett --Apple-Mail=_8DBC637E-2732-44C7-A30E-A2898AE64D0E Content-Disposition: attachment; filename=build-tests-with-world.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="build-tests-with-world.patch" Content-Transfer-Encoding: 7bit Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 249833) +++ Makefile.inc1 (working copy) @@ -91,6 +91,9 @@ .if ${MK_OFED} != "no" SUBDIR+=contrib/ofed .endif +.if ${MK_TESTS} != "no" +SUBDIR+=tests +.endif # # We must do etc/ last for install/distribute to work. # @@ -253,7 +256,8 @@ SSP_CFLAGS= \ -DWITHOUT_HTML -DWITHOUT_INFO -DNO_LINT -DWITHOUT_MAN \ -DNO_PIC -DNO_PROFILE -DNO_SHARED \ - -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD + -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD \ + -DNO_TESTS \ # build-tools stage TMAKE= MAKEOBJDIRPREFIX=${OBJTREE} \ @@ -263,12 +267,14 @@ BOOTSTRAPPING=${OSRELDATE} \ SSP_CFLAGS= \ -DNO_LINT \ - -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD + -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD \ + -DNO_TESTS \ # cross-tools stage XMAKE= TOOLS_PREFIX=${WORLDTMP} ${BMAKE} \ TARGET=${TARGET} TARGET_ARCH=${TARGET_ARCH} \ - -DWITHOUT_GDB + -DWITHOUT_GDB \ + -DNO_TESTS \ # world stage WMAKEENV= ${CROSSENV} \ @@ -343,7 +349,8 @@ -DLIBRARIES_ONLY \ -DNO_CPU_CFLAGS \ -DNO_CTF \ - -DNO_LINT + -DNO_LINT \ + -DNO_TESTS \ LIB32WMAKE= ${LIB32WMAKEENV} ${MAKE} ${LIB32WMAKEFLAGS} \ -DWITHOUT_BIND -DWITHOUT_MAN -DWITHOUT_INFO -DWITHOUT_HTML @@ -489,7 +496,7 @@ @echo "--------------------------------------------------------------" ${_+_}cd ${.CURDIR}; \ ${WMAKE} -DNO_FSCHG -DWITHOUT_HTML -DWITHOUT_INFO -DNO_LINT \ - -DWITHOUT_MAN -DNO_PROFILE libraries + -DWITHOUT_MAN -DNO_PROFILE -DNO_TESTS libraries _depend: @echo @echo "--------------------------------------------------------------" @@ -1734,6 +1741,7 @@ NOFUN=-DNO_FSCHG -DWITHOUT_HTML -DWITHOUT_INFO -DNO_LINT \ -DWITHOUT_MAN -DWITHOUT_NLS -DNO_PROFILE \ -DWITHOUT_KERBEROS -DWITHOUT_RESCUE -DNO_WARNS \ + -DNO_TESTS \ TARGET=${XDEV} TARGET_ARCH=${XDEV_ARCH} \ CPUTYPE=${XDEV_CPUTYPE} Index: share/mk/bsd.own.mk =================================================================== --- share/mk/bsd.own.mk (revision 249833) +++ share/mk/bsd.own.mk (working copy) @@ -376,8 +376,16 @@ NAND \ OFED \ OPENSSH_NONE_CIPHER \ - SHARED_TOOLCHAIN + SHARED_TOOLCHAIN \ +# bsd.test.mk doesn't work with !bmake. Also don't build tests if NO_TESTS is +# defined; this is for buildworld and elsewhere (ports potentially). +.if defined(.PARSEDIR) && !defined(NO_TESTS) +__DEFAULT_NO_OPTIONS+=TESTS +.else +MK_TESTS:= no +.endif + # # Default behaviour of some options depends on the architecture. Unfortunately # this means that we have to test TARGET_ARCH (the buildworld case) as well --Apple-Mail=_8DBC637E-2732-44C7-A30E-A2898AE64D0E-- From owner-freebsd-toolchain@FreeBSD.ORG Wed Apr 24 16:23:09 2013 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B4F13D09; Wed, 24 Apr 2013 16:23:09 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id 810A21EA6; Wed, 24 Apr 2013 16:23:08 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.5/8.14.5) with ESMTP id r3OGN8Qe016839; Wed, 24 Apr 2013 11:23:08 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.5/8.14.5/Submit) id r3OGN8fn016838; Wed, 24 Apr 2013 11:23:08 -0500 (CDT) (envelope-from brooks) Date: Wed, 24 Apr 2013 11:23:08 -0500 From: Brooks Davis To: Garrett Cooper Subject: Re: [RFC] [Optionally] build tests with buildworld Message-ID: <20130424162307.GA16731@lor.one-eyed-alien.net> References: <20130423165958.GA91607@lor.one-eyed-alien.net> <1D2E12CF-08F2-4151-AB33-84C4270CFBC6@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qlTNgmc+xy1dBmNv" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: arch@freebsd.org, "Simon J. Gerraty" , benno@freebsd.org, toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2013 16:23:09 -0000 --qlTNgmc+xy1dBmNv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 24, 2013 at 09:15:30AM -0700, Garrett Cooper wrote: >=20 > On Apr 23, 2013, at 10:28 AM, Garrett Cooper wrote: >=20 > > On Apr 23, 2013, at 9:59 AM, Brooks Davis wrote: > >=20 > >> On Fri, Apr 19, 2013 at 11:17:50PM -0700, Garrett Cooper wrote: > >>> Hi arch@ and toolchain@, > >>> One of the items that I'm proposing be added to Makefile.inc1 in > >>> order to make building and installing tests on CURRENT (ATF and > >>> otherwise) is a build knob called TESTS_WITH_WORLD (the name can be > >>> modified), which allows me to build and install various tests on my > >>> git branch like the example ATF tests I produced, pjdfstest, some of > >>> the prove tests from tools/regression, etc (there are other > >>> outstanding changes, but this was the key one that I need feedback on > >>> just to be safe). > >>=20 > >> I don't understand way you don't use WITH_TESTS processed > >> through bsd.own.mk. You'd presumably have to add it to the list of > >> supported NO_* options for the bootstrap case, but that's trivial. Th= en > >> you use could use normal MK_* variables. That would also let you use > >> WITH(OUT)_TESTS in individual directories and they would always work. > >>=20 > >> At a glance using WITHOUT_TESTS and NO_TEST internally would simplify > >> some of the special cases in your patch. > >=20 > > This is something that I considered, but I wasn't sure that it was the = best route to go about things because I thought we were doing away/had done= away with most of the NO_* knobs (and unfortunately one cannot mix and mat= ch WITH_* and WITHOUT_* because they're considered contradictory according = to bsd.own.mk -- something that Simon has debated against having in the pas= t). > >=20 > > I'm all for doing that though because that would simplify things greatl= y from an end-user perspective. >=20 > Hi Brooks! > Does this look ok? Most of the MK_TESTS logic has been shoved into bsd.o= wn.mk and NO_TESTS is sprinkled around Makefile.inc1 as recommended. > Thanks! > -Garrett The functional parts seem fine. Some comments below. -- Brooks > Index: Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Makefile.inc1 (revision 249833) > +++ Makefile.inc1 (working copy) > @@ -91,6 +91,9 @@ > .if ${MK_OFED} !=3D "no" > SUBDIR+=3Dcontrib/ofed > .endif > +.if ${MK_TESTS} !=3D "no" > +SUBDIR+=3Dtests > +.endif > # > # We must do etc/ last for install/distribute to work. > # > @@ -253,7 +256,8 @@ > SSP_CFLAGS=3D \ > -DWITHOUT_HTML -DWITHOUT_INFO -DNO_LINT -DWITHOUT_MAN \ > -DNO_PIC -DNO_PROFILE -DNO_SHARED \ > - -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD > + -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD \ > + -DNO_TESTS \ The trailing backslash may be a good idea, but is inconsistant with all the Makefiles in the system. If you want to make that change is should discussed seperately. > =20 > # build-tools stage > TMAKE=3D MAKEOBJDIRPREFIX=3D${OBJTREE} \ > @@ -263,12 +267,14 @@ > BOOTSTRAPPING=3D${OSRELDATE} \ > SSP_CFLAGS=3D \ > -DNO_LINT \ > - -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD > + -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD \ > + -DNO_TESTS \ > =20 > # cross-tools stage > XMAKE=3D TOOLS_PREFIX=3D${WORLDTMP} ${BMAKE} \ > TARGET=3D${TARGET} TARGET_ARCH=3D${TARGET_ARCH} \ > - -DWITHOUT_GDB > + -DWITHOUT_GDB \ > + -DNO_TESTS \ > =20 > # world stage > WMAKEENV=3D ${CROSSENV} \ > @@ -343,7 +349,8 @@ > -DLIBRARIES_ONLY \ > -DNO_CPU_CFLAGS \ > -DNO_CTF \ > - -DNO_LINT > + -DNO_LINT \ > + -DNO_TESTS \ > =20 > LIB32WMAKE=3D ${LIB32WMAKEENV} ${MAKE} ${LIB32WMAKEFLAGS} \ > -DWITHOUT_BIND -DWITHOUT_MAN -DWITHOUT_INFO -DWITHOUT_HTML > @@ -489,7 +496,7 @@ > @echo "--------------------------------------------------------------" > ${_+_}cd ${.CURDIR}; \ > ${WMAKE} -DNO_FSCHG -DWITHOUT_HTML -DWITHOUT_INFO -DNO_LINT \ > - -DWITHOUT_MAN -DNO_PROFILE libraries > + -DWITHOUT_MAN -DNO_PROFILE -DNO_TESTS libraries > _depend: > @echo > @echo "--------------------------------------------------------------" > @@ -1734,6 +1741,7 @@ > NOFUN=3D-DNO_FSCHG -DWITHOUT_HTML -DWITHOUT_INFO -DNO_LINT \ > -DWITHOUT_MAN -DWITHOUT_NLS -DNO_PROFILE \ > -DWITHOUT_KERBEROS -DWITHOUT_RESCUE -DNO_WARNS \ > + -DNO_TESTS \ This could be on the previous line. > TARGET=3D${XDEV} TARGET_ARCH=3D${XDEV_ARCH} \ > CPUTYPE=3D${XDEV_CPUTYPE} > =20 > Index: share/mk/bsd.own.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- share/mk/bsd.own.mk (revision 249833) > +++ share/mk/bsd.own.mk (working copy) > @@ -376,8 +376,16 @@ > NAND \ > OFED \ > OPENSSH_NONE_CIPHER \ > - SHARED_TOOLCHAIN > + SHARED_TOOLCHAIN \ > =20 > +# bsd.test.mk doesn't work with !bmake. Also don't build tests if NO_TES= TS is > +# defined; this is for buildworld and elsewhere (ports potentially). > +.if defined(.PARSEDIR) && !defined(NO_TESTS) > +__DEFAULT_NO_OPTIONS+=3DTESTS > +.else > +MK_TESTS:=3D no > +.endif > + > # > # Default behaviour of some options depends on the architecture. Unfort= unately > # this means that we have to test TARGET_ARCH (the buildworld case) as w= ell --qlTNgmc+xy1dBmNv Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFReAbrXY6L6fI4GtQRAtQLAKCJlwevJyNpfBkiUqSIS8T23KW/JwCfYyM1 1VrPW+NyFlhJ9UJw8cow4m4= =FV/q -----END PGP SIGNATURE----- --qlTNgmc+xy1dBmNv-- From owner-freebsd-toolchain@FreeBSD.ORG Wed Apr 24 16:32:15 2013 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 5F190FE; Wed, 24 Apr 2013 16:32:15 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by mx1.freebsd.org (Postfix) with ESMTP id 26DC61F30; Wed, 24 Apr 2013 16:32:15 +0000 (UTC) Received: by mail-pd0-f179.google.com with SMTP id x11so1231787pdj.24 for ; Wed, 24 Apr 2013 09:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:subject:mime-version:content-type:from:in-reply-to:date :cc:message-id:references:to:x-mailer; bh=d06dSJ3rib12iSCgorSeccWKqtgcHaX8v5dYiDSO6DE=; b=m+9HflqR9IOawIOIBAqWv9APpf7M3UzL2f/sisuHodqrkX9t/Uw0LJ5FuHZOBUDu+6 B6F7GxSnKT1/vjHo2MGYobOAeFfYJKxp6cmSOj7OlRxFRSE8lxMtH6QJFm4uVPmrDk8G B6b86Z0Y/Gdi/Yx9C3JBOWAiRAPjUZ3TUWOaw+wWhvJ2SqGas618tasRokzBJEFWUNWo nLZL4R26ODiX0UNtFjmufs+cKjxcYYIUtWCRKtTaEV8+H4y2520ofJtqfkN8bjubusHC fnDgLaKNXb6WBLiGfEBzOIgGO5lwwPOtVty11QrdWB+HxaNoBkFHGilJT7AJvnOfSOYK Sh8g== X-Received: by 10.66.100.231 with SMTP id fb7mr19959620pab.162.1366821129633; Wed, 24 Apr 2013 09:32:09 -0700 (PDT) Received: from fuji-wireless.local (c-98-203-241-95.hsd1.wa.comcast.net. [98.203.241.95]) by mx.google.com with ESMTPSA id br2sm3598772pbc.46.2013.04.24.09.32.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 24 Apr 2013 09:32:08 -0700 (PDT) Subject: Re: [RFC] [Optionally] build tests with buildworld Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: multipart/mixed; boundary="Apple-Mail=_608A1616-6ED2-41C3-8E4C-09215CEE962B" From: Garrett Cooper In-Reply-To: <20130424162307.GA16731@lor.one-eyed-alien.net> Date: Wed, 24 Apr 2013 09:32:07 -0700 Message-Id: References: <20130423165958.GA91607@lor.one-eyed-alien.net> <1D2E12CF-08F2-4151-AB33-84C4270CFBC6@gmail.com> <20130424162307.GA16731@lor.one-eyed-alien.net> To: Brooks Davis X-Mailer: Apple Mail (2.1283) Cc: arch@freebsd.org, "Simon J. Gerraty" , benno@freebsd.org, toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2013 16:32:15 -0000 --Apple-Mail=_608A1616-6ED2-41C3-8E4C-09215CEE962B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Apr 24, 2013, at 9:23 AM, Brooks Davis wrote: >> =85 >> Hi Brooks! >> Does this look ok? Most of the MK_TESTS logic has been shoved = into bsd.own.mk and NO_TESTS is sprinkled around Makefile.inc1 as = recommended. >> Thanks! >> -Garrett >=20 > The functional parts seem fine. Some comments below. Here's an updated version of the patch with your comments = applied. Thanks! -Garrett --Apple-Mail=_608A1616-6ED2-41C3-8E4C-09215CEE962B Content-Disposition: attachment; filename=build-tests-with-world.patch Content-Type: application/octet-stream; name="build-tests-with-world.patch" Content-Transfer-Encoding: 7bit Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 249833) +++ Makefile.inc1 (working copy) @@ -91,6 +91,9 @@ .if ${MK_OFED} != "no" SUBDIR+=contrib/ofed .endif +.if ${MK_TESTS} != "no" +SUBDIR+=tests +.endif # # We must do etc/ last for install/distribute to work. # @@ -253,7 +256,7 @@ SSP_CFLAGS= \ -DWITHOUT_HTML -DWITHOUT_INFO -DNO_LINT -DWITHOUT_MAN \ -DNO_PIC -DNO_PROFILE -DNO_SHARED \ - -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD + -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD -DNO_TESTS # build-tools stage TMAKE= MAKEOBJDIRPREFIX=${OBJTREE} \ @@ -263,12 +266,12 @@ BOOTSTRAPPING=${OSRELDATE} \ SSP_CFLAGS= \ -DNO_LINT \ - -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD + -DNO_CPU_CFLAGS -DNO_WARNS -DNO_CTF -DEARLY_BUILD -DNO_TESTS # cross-tools stage XMAKE= TOOLS_PREFIX=${WORLDTMP} ${BMAKE} \ TARGET=${TARGET} TARGET_ARCH=${TARGET_ARCH} \ - -DWITHOUT_GDB + -DWITHOUT_GDB -DNO_TESTS # world stage WMAKEENV= ${CROSSENV} \ @@ -343,7 +346,8 @@ -DLIBRARIES_ONLY \ -DNO_CPU_CFLAGS \ -DNO_CTF \ - -DNO_LINT + -DNO_LINT \ + -DNO_TESTS LIB32WMAKE= ${LIB32WMAKEENV} ${MAKE} ${LIB32WMAKEFLAGS} \ -DWITHOUT_BIND -DWITHOUT_MAN -DWITHOUT_INFO -DWITHOUT_HTML @@ -489,7 +493,7 @@ @echo "--------------------------------------------------------------" ${_+_}cd ${.CURDIR}; \ ${WMAKE} -DNO_FSCHG -DWITHOUT_HTML -DWITHOUT_INFO -DNO_LINT \ - -DWITHOUT_MAN -DNO_PROFILE libraries + -DWITHOUT_MAN -DNO_PROFILE -DNO_TESTS libraries _depend: @echo @echo "--------------------------------------------------------------" @@ -1733,7 +1737,7 @@ NOFUN=-DNO_FSCHG -DWITHOUT_HTML -DWITHOUT_INFO -DNO_LINT \ -DWITHOUT_MAN -DWITHOUT_NLS -DNO_PROFILE \ - -DWITHOUT_KERBEROS -DWITHOUT_RESCUE -DNO_WARNS \ + -DWITHOUT_KERBEROS -DWITHOUT_RESCUE -DNO_TESTS -DNO_WARNS \ TARGET=${XDEV} TARGET_ARCH=${XDEV_ARCH} \ CPUTYPE=${XDEV_CPUTYPE} Index: share/mk/bsd.own.mk =================================================================== --- share/mk/bsd.own.mk (revision 249833) +++ share/mk/bsd.own.mk (working copy) @@ -378,6 +378,14 @@ OPENSSH_NONE_CIPHER \ SHARED_TOOLCHAIN +# bsd.test.mk doesn't work with !bmake. Also don't build tests if NO_TESTS is +# defined; this is for buildworld and elsewhere (ports potentially). +.if defined(.PARSEDIR) && !defined(NO_TESTS) +__DEFAULT_NO_OPTIONS+=TESTS +.else +MK_TESTS:= no +.endif + # # Default behaviour of some options depends on the architecture. Unfortunately # this means that we have to test TARGET_ARCH (the buildworld case) as well --Apple-Mail=_608A1616-6ED2-41C3-8E4C-09215CEE962B--