From owner-freebsd-toolchain@FreeBSD.ORG Sun Jul 28 21:27:15 2013 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7C9867A6; Sun, 28 Jul 2013 21:27:15 +0000 (UTC) (envelope-from kubito@gmail.com) Received: from mail-la0-x230.google.com (mail-la0-x230.google.com [IPv6:2a00:1450:4010:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2C5872B45; Sun, 28 Jul 2013 21:27:13 +0000 (UTC) Received: by mail-la0-f48.google.com with SMTP id hi8so3483393lab.7 for ; Sun, 28 Jul 2013 14:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Rvb+Xw1Xmjeny08DFaM9CxfCpANkexBCMuHIKllYarw=; b=j0TmsaLc7Nfu1nd3dXPkbtRPCQPsB2YBuicVU1fneXk2Gxg5dbGhJztTxTyGXn+L4H e9ZiHtW8w276LILx8lUU9dPePUEwgBI/ZZePHONLd4SonYPyO3wB0JkN6S6NWBo1D3MW Xho2tOcLyGvLK9uZ/QsfEG4hUVSkRukP5VluVmjn4GAe6kYCjlmY8YULq3s/XMl/j+du N3IOw54QjBX1hVBO2QCiBEJuPKvoK6m9dASVsqzDb06GuxpVY7ZGfbSlVdZOLCwy7jLO AmlOoiiA/kp9B4tR9T+btdEGpbUkuk5wdsfxUk2pJ7whp4AdX4iT3+OvkbFTAYPZ4SmN 91Rg== X-Received: by 10.112.53.10 with SMTP id x10mr24743382lbo.28.1375046832077; Sun, 28 Jul 2013 14:27:12 -0700 (PDT) Received: from orwell.Elisa.gmail.com (a91-154-115-217.elisa-laajakaista.fi. [91.154.115.217]) by mx.google.com with ESMTPSA id k10sm4959313lbl.10.2013.07.28.14.27.10 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 28 Jul 2013 14:27:11 -0700 (PDT) Sender: Raphael Kubo da Costa From: Raphael Kubo da Costa To: Pasi Parviainen Subject: Re: CURRENT: CLANG 3.3 and -stad=c++11 and -stdlib=libc++: isnan()/isninf() oddity References: <20130710155809.0f589c22@thor.walstatt.dyndns.org> <20130710183315.725dfde0@thor.walstatt.dyndns.org> <20130710203200.5359fd18@thor.walstatt.dyndns.org> <51DDC04B.6040209@FreeBSD.org> <20957.49978.73666.392417@khavrinen.csail.mit.edu> <20130711130043.R920@besplex.bde.org> <20130711202908.L84170@besplex.bde.org> <20130712234749.5afa3c9b@thor.walstatt.dyndns.org> <9B0A6D14-640E-4ADD-8E58-0B7867C7C674@FreeBSD.org> <51E145CC.8080900@iki.fi> Date: Mon, 29 Jul 2013 00:27:02 +0300 In-Reply-To: <51E145CC.8080900@iki.fi> (Pasi Parviainen's message of "Sat, 13 Jul 2013 15:19:24 +0300") Message-ID: <861u6iv0ih.fsf@orwell.Elisa> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: Scot Hetzel , "freebsd-toolchain@FreeBSD.org" , Garrett Wollman , FreeBSD Current , Tijl Coosemans , "freebsd-standards@FreeBSD.org" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2013 21:27:15 -0000 Pasi Parviainen writes: > On 13.7.2013 13:12, David Chisnall wrote: >> On 12 Jul 2013, at 22:47, "O. Hartmann" wrote: >> >>> Obviously not really fixed, but even worse: >>> >>> if I use in C code (C99, using clang 3.3 on FreeBSD 10.0-CURRENT/amd64 >>> revision 253287) isnan(x) where x is a "const double", I receive now >>> the following error (which doesn't appear on previous versions): >> >> Thanks. This is now fixed, however the _Generic() usage that we had there is also present in tgmath.h, and so this file will also need to be fixed in the same way. >> >> I've now tested the macros with clang/c99, clang/c11, clang/c++98 and clang/c++11, and gcc/c89 and they all seem to work for unqualified, const, volatile, and const-volatile qualified types. >> >> I've added Ed to the cc: list, as he wrote this code in tgmath.h. >> >> David >> > > Instead of listing all possible type qualifier combinations (like in > r253319), how about using a comma operator to strip away type > qualifiers? Since only the result type of the expression matters and > it isn't evaluated at all. > > like: > > #define __fp_type_select(x, f, d, ld) _Generic((0,(x)), This seems to have been committed in r253321, and broke some code that was working with r253320; namely, some code in x11/kde4-workspace includes math.h and calls isnan() with a const double. From owner-freebsd-toolchain@FreeBSD.ORG Mon Jul 29 08:19:52 2013 Return-Path: Delivered-To: freebsd-toolchain@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D1FDC264; Mon, 29 Jul 2013 08:19:52 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 961DA2591; Mon, 29 Jul 2013 08:19:52 +0000 (UTC) Received: from [192.168.0.2] (cpc27-cmbg15-2-0-cust235.5-4.cable.virginmedia.com [86.27.188.236]) (authenticated bits=0) by theravensnest.org (8.14.5/8.14.5) with ESMTP id r6T8JjmM071640 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 29 Jul 2013 08:19:46 GMT (envelope-from theraven@FreeBSD.org) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: CURRENT: CLANG 3.3 and -stad=c++11 and -stdlib=libc++: isnan()/isninf() oddity From: David Chisnall In-Reply-To: <861u6iv0ih.fsf@orwell.Elisa> Date: Mon, 29 Jul 2013 09:19:40 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20130710155809.0f589c22@thor.walstatt.dyndns.org> <20130710183315.725dfde0@thor.walstatt.dyndns.org> <20130710203200.5359fd18@thor.walstatt.dyndns.org> <51DDC04B.6040209@FreeBSD.org> <20957.49978.73666.392417@khavrinen.csail.mit.edu> <20130711130043.R920@besplex.bde.org> <20130711202908.L84170@besplex.bde.org> <20130712234749.5afa3c9b@thor.walstatt.dyndns.org> <9B0A6D14-640E-4ADD-8E58-0B7867C7C674@FreeBSD.org> <51E145CC.8080900@iki.fi> <861u6iv0ih.fsf@orwell.Elisa> To: Raphael Kubo da Costa X-Mailer: Apple Mail (2.1508) Cc: Scot Hetzel , "freebsd-standards@FreeBSD.org" , "freebsd-toolchain@FreeBSD.org" , Garrett Wollman , FreeBSD Current , Tijl Coosemans X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jul 2013 08:19:52 -0000 On 28 Jul 2013, at 22:27, Raphael Kubo da Costa = wrote: > This seems to have been committed in r253321, and broke some code that > was working with r253320; namely, some code in x11/kde4-workspace > includes math.h and calls isnan() with a const double. Please provide a test case. Specifically, I need to know what language = dialect this is using, because I have tested including math.h and = calling isnan(double) with c89, gnu89, c99, c11, c++03 and c++11 on gcc = (for the modes that it supports) and clang. David From owner-freebsd-toolchain@FreeBSD.ORG Mon Jul 29 11:27:38 2013 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7E00EFA6; Mon, 29 Jul 2013 11:27:38 +0000 (UTC) (envelope-from kubito@gmail.com) Received: from mail-oa0-x231.google.com (mail-oa0-x231.google.com [IPv6:2607:f8b0:4003:c02::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 07B622054; Mon, 29 Jul 2013 11:27:37 +0000 (UTC) Received: by mail-oa0-f49.google.com with SMTP id n16so1286857oag.22 for ; Mon, 29 Jul 2013 04:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Y8Nt738cak9jGA8Oj3TVrQEv6NEdC7+Rb2HlHDlDuvc=; b=OM9355H/eZQQRU0N5v5VmoRrK8EjVCOYgXjID1p2wrEFZfQEcFmMS6EneGtF9zIoHm JDUadzGrbwAoagkpjTA1OnM5E4gh3P3kI8yLcX4FTu9LLRIzktCzX1yOEING7QlCpHFz cZTTbXXrJWlg6nufRW1K/vCtAUQUyyS945OHL5OxTrQVp9xgViWZaMidnIH0i/xSDKwR YscXivvqJaWY9gIRDm5lX47SoERwbG/A+H0jPET7pBRbp1cvxlkY8vdBbliJCRUbAM94 LrgMICQBS45dY2JLIqP25ZgzOWa02Ln4CarxrAzFeQlpaRdBlohlRrr8+gC4cSoX0SdJ yVZA== X-Received: by 10.60.34.130 with SMTP id z2mr15075527oei.87.1375097257406; Mon, 29 Jul 2013 04:27:37 -0700 (PDT) Received: from rachacuca.gmail.com (li113-135.members.linode.com. [69.164.198.135]) by mx.google.com with ESMTPSA id jz7sm86843109obb.4.2013.07.29.04.27.36 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 29 Jul 2013 04:27:36 -0700 (PDT) Sender: Raphael Kubo da Costa From: Raphael Kubo da Costa To: David Chisnall Subject: Re: CURRENT: CLANG 3.3 and -stad=c++11 and -stdlib=libc++: isnan()/isninf() oddity References: <20130710155809.0f589c22@thor.walstatt.dyndns.org> <20130710183315.725dfde0@thor.walstatt.dyndns.org> <20130710203200.5359fd18@thor.walstatt.dyndns.org> <51DDC04B.6040209@FreeBSD.org> <20957.49978.73666.392417@khavrinen.csail.mit.edu> <20130711130043.R920@besplex.bde.org> <20130711202908.L84170@besplex.bde.org> <20130712234749.5afa3c9b@thor.walstatt.dyndns.org> <9B0A6D14-640E-4ADD-8E58-0B7867C7C674@FreeBSD.org> <51E145CC.8080900@iki.fi> <861u6iv0ih.fsf@orwell.Elisa> Date: Mon, 29 Jul 2013 08:27:29 -0300 In-Reply-To: (David Chisnall's message of "Mon, 29 Jul 2013 09:19:40 +0100") Message-ID: <83zjt5mwri.fsf@FreeBSD.org> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Cc: Scot Hetzel , "freebsd-standards@FreeBSD.org" , "freebsd-toolchain@FreeBSD.org" , Garrett Wollman , FreeBSD Current , Tijl Coosemans X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jul 2013 11:27:38 -0000 David Chisnall writes: > On 28 Jul 2013, at 22:27, Raphael Kubo da Costa wrote: > >> This seems to have been committed in r253321, and broke some code that >> was working with r253320; namely, some code in x11/kde4-workspace >> includes math.h and calls isnan() with a const double. > > Please provide a test case. Specifically, I need to know what > language dialect this is using, because I have tested including math.h > and calling isnan(double) with c89, gnu89, c99, c11, c++03 and c++11 > on gcc (for the modes that it supports) and clang. I get the following results with and without -std=c++11 and/or -stdlib=libc++: % cat isnan.cc #include int main() { const double d = 42.0; return isnan(d) ? 1 : 0; } % clang++ isnan.cc isnan.cc:4:10: error: controlling expression type 'const double' not compatible with any generic association type return isnan(d) ? 1 : 0; ^~~~~~~~ /usr/include/math.h:109:2: note: expanded from macro 'isnan' __fp_type_select(x, __inline_isnanf, __inline_isnan, __inline_isnanl) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/math.h:86:49: note: expanded from macro '__fp_type_select' #define __fp_type_select(x, f, d, ld) _Generic((0,(x)), \ ^~~~~ 1 error generated. From owner-freebsd-toolchain@FreeBSD.ORG Mon Jul 29 15:42:50 2013 Return-Path: Delivered-To: freebsd-toolchain@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D7079555; Mon, 29 Jul 2013 15:42:49 +0000 (UTC) (envelope-from pasi.parviainen@iki.fi) Received: from sinikuusama.dnainternet.net (sinikuusama.dnainternet.net [83.102.40.134]) by mx1.freebsd.org (Postfix) with ESMTP id 4F43C2E17; Mon, 29 Jul 2013 15:42:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by sinikuusama.dnainternet.net (Postfix) with ESMTP id 6D0393FC82; Mon, 29 Jul 2013 18:33:26 +0300 (EEST) X-Virus-Scanned: DNA Postiturva at dnainternet.net X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-9999 required=6 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from sinikuusama.dnainternet.net ([83.102.40.134]) by localhost (sinikuusama.dnainternet.net [127.0.0.1]) (DNA Postiturva, port 10041) with ESMTP id FkjCMZS4ItnD; Mon, 29 Jul 2013 18:33:25 +0300 (EEST) Received: from oliivipuu.dnainternet.net (oliivipuu.dnainternet.net [83.102.40.215]) by sinikuusama.dnainternet.net (Postfix) with ESMTP id D829C3FA63; Mon, 29 Jul 2013 18:33:25 +0300 (EEST) Received: from [192.168.0.2] (host-109-204-160-251.tp-fne.tampereenpuhelin.net [109.204.160.251]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by oliivipuu.dnainternet.net (Postfix) with ESMTPS id 6278A5FAA6; Mon, 29 Jul 2013 18:33:16 +0300 (EEST) Message-ID: <51F68ACA.8030500@iki.fi> Date: Mon, 29 Jul 2013 18:31:22 +0300 From: Pasi Parviainen User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Raphael Kubo da Costa Subject: Re: CURRENT: CLANG 3.3 and -stad=c++11 and -stdlib=libc++: isnan()/isninf() oddity References: <20130710155809.0f589c22@thor.walstatt.dyndns.org> <20130710183315.725dfde0@thor.walstatt.dyndns.org> <20130710203200.5359fd18@thor.walstatt.dyndns.org> <51DDC04B.6040209@FreeBSD.org> <20957.49978.73666.392417@khavrinen.csail.mit.edu> <20130711130043.R920@besplex.bde.org> <20130711202908.L84170@besplex.bde.org> <20130712234749.5afa3c9b@thor.walstatt.dyndns.org> <9B0A6D14-640E-4ADD-8E58-0B7867C7C674@FreeBSD.org> <51E145CC.8080900@iki.fi> <861u6iv0ih.fsf@orwell.Elisa> <83zjt5mwri.fsf@FreeBSD.org> In-Reply-To: <83zjt5mwri.fsf@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Scot Hetzel , "freebsd-standards@FreeBSD.org" , "freebsd-toolchain@FreeBSD.org" , Garrett Wollman , FreeBSD Current , Tijl Coosemans X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jul 2013 15:42:50 -0000 On 29.7.2013 14:27, Raphael Kubo da Costa wrote: > David Chisnall writes: > >> On 28 Jul 2013, at 22:27, Raphael Kubo da Costa wrote: >> >>> This seems to have been committed in r253321, and broke some code that >>> was working with r253320; namely, some code in x11/kde4-workspace >>> includes math.h and calls isnan() with a const double. >> >> Please provide a test case. Specifically, I need to know what >> language dialect this is using, because I have tested including math.h >> and calling isnan(double) with c89, gnu89, c99, c11, c++03 and c++11 >> on gcc (for the modes that it supports) and clang. > > I get the following results with and without -std=c++11 and/or > -stdlib=libc++: > > % cat isnan.cc > #include > int main() { > const double d = 42.0; > return isnan(d) ? 1 : 0; > } > > % clang++ isnan.cc > isnan.cc:4:10: error: controlling expression type 'const double' not > compatible with any generic association type > return isnan(d) ? 1 : 0; > ^~~~~~~~ > /usr/include/math.h:109:2: note: expanded from macro 'isnan' > __fp_type_select(x, __inline_isnanf, __inline_isnan, > __inline_isnanl) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/math.h:86:49: note: expanded from macro '__fp_type_select' > #define __fp_type_select(x, f, d, ld) _Generic((0,(x)), > \ > ^~~~~ > 1 error generated. > In the first place C++ code should be using cmath instead of math.h. That said, this is a result of just an another wonderful little difference between C and C++. C standard explicitly states that comma operator does not yield an lvalue but in C++ it can if the right most operand is an lvalue. If C++ compatibility is desired then unary + operator (e.g. _Generic(+(x),...) could be used for the same effect, only downside with this is that the integer arguments are promoted, but that doesn't matter in this case. Pasi From owner-freebsd-toolchain@FreeBSD.ORG Mon Jul 29 20:19:19 2013 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 09A0B9DB; Mon, 29 Jul 2013 20:19:19 +0000 (UTC) (envelope-from kubito@gmail.com) Received: from mail-lb0-x22f.google.com (mail-lb0-x22f.google.com [IPv6:2a00:1450:4010:c04::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1992A2DBE; Mon, 29 Jul 2013 20:19:17 +0000 (UTC) Received: by mail-lb0-f175.google.com with SMTP id 13so1087731lba.34 for ; Mon, 29 Jul 2013 13:19:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=OjEsHxPHAmFHGkUic9UqG2IefoRw42UjeP24+EML4g0=; b=EO9oBLuPdjrWxErjW0LnlKcT07UDROYa9P07YZ0tCw4MtQ2koj7fviaswIOp41w9e9 J9btuBJg/o07lm2wAnnS+rYoi55ntYzaG5LUI+0YCw5Xzxx1UcsEi15tybsUKNlNIn7E Kuc+wGxS8axDyGr9M5HhLLmJaJ45T+OHeFaTIUO7vbsCYDEg1y382kgChm6znGc1TWHE fsa+y/KLuXHcVz2dUuxJDq/crlZD06yB18XgE9m5YD9DORpG4alF3DkyvHLQ3zXJCpCL gvqH4CyGd8Gi+rJIW8EFtMEFeufKqCaDuElyZSm9ntb520gwAbdaswUCuP9yXYGi1Dc3 CGSA== X-Received: by 10.112.157.226 with SMTP id wp2mr26292403lbb.65.1375129155313; Mon, 29 Jul 2013 13:19:15 -0700 (PDT) Received: from orwell.Elisa.gmail.com (a91-154-115-217.elisa-laajakaista.fi. [91.154.115.217]) by mx.google.com with ESMTPSA id j1sm3906801lag.4.2013.07.29.13.19.13 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 29 Jul 2013 13:19:14 -0700 (PDT) Sender: Raphael Kubo da Costa From: Raphael Kubo da Costa To: FreeBSD Current Subject: Re: CURRENT: CLANG 3.3 and -stad=c++11 and -stdlib=libc++: isnan()/isninf() oddity References: <20130710155809.0f589c22@thor.walstatt.dyndns.org> <20130710183315.725dfde0@thor.walstatt.dyndns.org> <20130710203200.5359fd18@thor.walstatt.dyndns.org> <51DDC04B.6040209@FreeBSD.org> <20957.49978.73666.392417@khavrinen.csail.mit.edu> <20130711130043.R920@besplex.bde.org> <20130711202908.L84170@besplex.bde.org> <20130712234749.5afa3c9b@thor.walstatt.dyndns.org> <9B0A6D14-640E-4ADD-8E58-0B7867C7C674@FreeBSD.org> <51E145CC.8080900@iki.fi> <861u6iv0ih.fsf@orwell.Elisa> Date: Mon, 29 Jul 2013 23:18:59 +0300 In-Reply-To: <861u6iv0ih.fsf@orwell.Elisa> (Raphael Kubo da Costa's message of "Mon, 29 Jul 2013 00:27:02 +0300") Message-ID: <868v0pdsr0.fsf@orwell.Elisa> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: "freebsd-toolchain@FreeBSD.org" , "freebsd-standards@FreeBSD.org" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jul 2013 20:19:19 -0000 Raphael Kubo da Costa writes: > This seems to have been committed in r253321, and broke some code that > was working with r253320; namely, some code in x11/kde4-workspace > includes math.h and calls isnan() with a const double. For posterity, David has reverted the code back to the previous behaviour in r253766.