From owner-svn-ports-all@FreeBSD.ORG  Sun Jan 27 00:39:21 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 15B285C2;
 Sun, 27 Jan 2013 00:39:21 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 by mx1.freebsd.org (Postfix) with ESMTP id E48857FA;
 Sun, 27 Jan 2013 00:39:18 +0000 (UTC)
Received: from cellar.lan (d24-156-192-11.home4.cgocable.net [24.156.192.11])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by apnoea.adamw.org (Postfix) with ESMTPSA id 9011811F9C5;
 Sat, 26 Jan 2013 19:39:16 -0500 (EST)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: svn commit: r311004 - head/devel/rbenv
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <CAMuy=+jt5cU6SN+omKMtAsoHaWuQyMLTXq5KyjLvwVjL+q6Ggg@mail.gmail.com>
Date: Sat, 26 Jan 2013 19:40:14 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <10D8E274-1457-47AE-9971-3DC4DDBA4A75@adamw.org>
References: <201301261106.r0QB61l8070374@svn.freebsd.org>
 <CAMuy=+gw=BaoZQ2_7nhVX7OBk=Lv29ym4McziuVCVhOiWwsizA@mail.gmail.com>
 <E0FDED6D-4F1F-408E-95A7-B313BFF983EA@adamw.org>
 <CAMuy=+jt5cU6SN+omKMtAsoHaWuQyMLTXq5KyjLvwVjL+q6Ggg@mail.gmail.com>
To: Jason Helfman <jgh@FreeBSD.org>
X-Mailer: Apple Mail (2.1499)
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 Marcus von Appen <mva@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Jan 2013 00:39:21 -0000

On 2013-01-26, at 17:31, Jason Helfman <jgh@FreeBSD.org> wrote:

> On Sat, Jan 26, 2013 at 8:27 AM, Adam Weinberger <adamw@adamw.org> =
wrote:
>=20
>=20
> On 2013-01-26, at 10:18, Jason Helfman <jgh@FreeBSD.org> wrote:
>=20
>> On Sat, Jan 26, 2013 at 3:06 AM, Marcus von Appen <mva@freebsd.org> =
wrote:
>> +%%DATADIR%%/completions/rbenv.bash
>> +%%DATADIR%%/completions/rbenv.zsh
>> +@dirrm %%DATADIR%%/completions
>> +@dirrm %%DATADIR%%
>>=20
>>=20
>> IMHO shouldn't completions be tied into the OPTIONS framework and be =
conditional installed as other ports?
>>=20
>> -jgh
>=20
> This port doesn't install completions in the bash or zsh completion =
bundle dirs. it installs it in its own DATADIR, leaving it up to the =
user to copy or symlink to it from the proper location. We don't need an =
OPTION for everything under the sun.
>=20
> # Adam
>=20
> Fair enough. I haven't seen it done this way yet, but I also haven't =
dug the tree for an example comparison.

Standardizing locations for completions could be a good thing, for this =
exact reason. ${ZSH,BASH,TCSH}_COMPLETION_DIR in bsd.port.mk could be =
helpful.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org