From owner-svn-src-stable-8@FreeBSD.ORG Sun Aug 25 15:00:34 2013 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CAC03C39; Sun, 25 Aug 2013 15:00:34 +0000 (UTC) (envelope-from jilles@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B61F121DD; Sun, 25 Aug 2013 15:00:34 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r7PF0Yrc053517; Sun, 25 Aug 2013 15:00:34 GMT (envelope-from jilles@svn.freebsd.org) Received: (from jilles@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r7PF0YbN053515; Sun, 25 Aug 2013 15:00:34 GMT (envelope-from jilles@svn.freebsd.org) Message-Id: <201308251500.r7PF0YbN053515@svn.freebsd.org> From: Jilles Tjoelker Date: Sun, 25 Aug 2013 15:00:34 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org Subject: svn commit: r254869 - stable/8/lib/libc/gen X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Aug 2013 15:00:34 -0000 Author: jilles Date: Sun Aug 25 15:00:34 2013 New Revision: 254869 URL: http://svnweb.freebsd.org/changeset/base/254869 Log: MFC r250412: posix_spawn_file_actions_addopen(3): Correct error for bad file descriptor. As per POSIX.1-2008, posix_spawn_file_actions_add* return [EBADF] if a file descriptor is negative, not [EINVAL]. The bug was only in the manual page; the code is correct. Modified: stable/8/lib/libc/gen/posix_spawn_file_actions_addopen.3 Directory Properties: stable/8/lib/libc/ (props changed) Modified: stable/8/lib/libc/gen/posix_spawn_file_actions_addopen.3 ============================================================================== --- stable/8/lib/libc/gen/posix_spawn_file_actions_addopen.3 Sun Aug 25 14:58:44 2013 (r254868) +++ stable/8/lib/libc/gen/posix_spawn_file_actions_addopen.3 Sun Aug 25 15:00:34 2013 (r254869) @@ -34,7 +34,7 @@ .\" .\" $FreeBSD$ .\" -.Dd Mar 24, 2008 +.Dd May 9, 2013 .Dt POSIX_SPAWN_FILE_ACTIONS_ADDOPEN 3 .Os .Sh NAME @@ -145,7 +145,7 @@ otherwise, an error number is returned t These functions fail if: .Bl -tag -width Er -.It Bq Er EINVAL +.It Bq Er EBADF The value specified by .Fa fildes or From owner-svn-src-stable-8@FreeBSD.ORG Sun Aug 25 15:01:44 2013 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 376F1FC7; Sun, 25 Aug 2013 15:01:44 +0000 (UTC) (envelope-from jilles@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 246D52217; Sun, 25 Aug 2013 15:01:44 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r7PF1iiB054143; Sun, 25 Aug 2013 15:01:44 GMT (envelope-from jilles@svn.freebsd.org) Received: (from jilles@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r7PF1hTP054142; Sun, 25 Aug 2013 15:01:43 GMT (envelope-from jilles@svn.freebsd.org) Message-Id: <201308251501.r7PF1hTP054142@svn.freebsd.org> From: Jilles Tjoelker Date: Sun, 25 Aug 2013 15:01:43 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org Subject: svn commit: r254872 - stable/8/lib/libc/gen X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Aug 2013 15:01:44 -0000 Author: jilles Date: Sun Aug 25 15:01:43 2013 New Revision: 254872 URL: http://svnweb.freebsd.org/changeset/base/254872 Log: MFC 250421: posix_spawn_file_actions_adddup2(3): Document difference with dup2(). The ability to clear a file descriptor's close-on-exec flag via posix_spawn_file_actions_adddup2() is in fact proposed in Austin Group issue #411. Modified: stable/8/lib/libc/gen/posix_spawn_file_actions_addopen.3 Directory Properties: stable/8/lib/libc/ (props changed) Modified: stable/8/lib/libc/gen/posix_spawn_file_actions_addopen.3 ============================================================================== --- stable/8/lib/libc/gen/posix_spawn_file_actions_addopen.3 Sun Aug 25 15:01:35 2013 (r254871) +++ stable/8/lib/libc/gen/posix_spawn_file_actions_addopen.3 Sun Aug 25 15:01:43 2013 (r254872) @@ -123,7 +123,19 @@ to be duplicated as dup2(fildes, newfildes) .Ed .Pp -had been called) when a new process is spawned using this file actions object. +had been called) when a new process is spawned using this file actions object, +except that the +.Dv FD_CLOEXEC +flag for +.Fa newfildes +is cleared even if +.Fa fildes +is equal to +.Fa newfildes . +The difference from +.Fn dup2 +is useful for passing a particular file descriptor +to a particular child process. .Pp The .Fn posix_spawn_file_actions_addclose @@ -169,7 +181,16 @@ The and .Fn posix_spawn_file_actions_addclose functions conform to -.St -p1003.1-2001 . +.St -p1003.1-2001 , +with the exception of the behavior of +.Fn posix_spawn_file_actions_adddup2 +if +.Fa fildes +is equal to +.Fa newfildes +(clearing +.Dv FD_CLOEXEC ) . +A future update of the Standard is expected to require this behavior, .Sh HISTORY The .Fn posix_spawn_file_actions_addopen , From owner-svn-src-stable-8@FreeBSD.ORG Thu Aug 29 12:25:12 2013 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B558595; Thu, 29 Aug 2013 12:25:12 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A2667228B; Thu, 29 Aug 2013 12:25:12 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r7TCPCQw002311; Thu, 29 Aug 2013 12:25:12 GMT (envelope-from avg@svn.freebsd.org) Received: (from avg@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r7TCPCET002310; Thu, 29 Aug 2013 12:25:12 GMT (envelope-from avg@svn.freebsd.org) Message-Id: <201308291225.r7TCPCET002310@svn.freebsd.org> From: Andriy Gapon Date: Thu, 29 Aug 2013 12:25:12 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org Subject: svn commit: r255020 - stable/8/sys/fs/devfs X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Aug 2013 12:25:12 -0000 Author: avg Date: Thu Aug 29 12:25:12 2013 New Revision: 255020 URL: http://svnweb.freebsd.org/changeset/base/255020 Log: MFC r211847: Set de_dir for user created symbolic links. This MFC should fix a panic introduced in r254708. Reported by: Toomas Aas , jase Tested by: jase MFC slacker: jh Modified: stable/8/sys/fs/devfs/devfs_vnops.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/fs/ (props changed) Modified: stable/8/sys/fs/devfs/devfs_vnops.c ============================================================================== --- stable/8/sys/fs/devfs/devfs_vnops.c Thu Aug 29 11:49:53 2013 (r255019) +++ stable/8/sys/fs/devfs/devfs_vnops.c Thu Aug 29 12:25:12 2013 (r255020) @@ -1513,6 +1513,7 @@ devfs_symlink(struct vop_symlink_args *a de->de_gid = 0; de->de_mode = 0755; de->de_inode = alloc_unr(devfs_inos); + de->de_dir = dd; de->de_dirent->d_type = DT_LNK; i = strlen(ap->a_target) + 1; de->de_symlink = malloc(i, M_DEVFS, M_WAITOK); From owner-svn-src-stable-8@FreeBSD.ORG Thu Aug 29 14:27:50 2013 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 8287C856; Thu, 29 Aug 2013 14:27:50 +0000 (UTC) (envelope-from jase@FreeBSD.org) Received: from svr06-mx.btshosting.co.uk (mx-2.btshosting.co.uk [IPv6:2a01:4f8:121:2403:2::]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 35B472BC0; Thu, 29 Aug 2013 14:27:47 +0000 (UTC) Received: from [192.168.1.242] (unknown [90.202.210.251]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by svr06-mx.btshosting.co.uk (Postfix) with ESMTPSA id 604E588BDE; Thu, 29 Aug 2013 14:27:45 +0000 (UTC) Message-ID: <521F5A60.1090401@FreeBSD.org> Date: Thu, 29 Aug 2013 15:27:44 +0100 From: Jase Thew Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Andriy Gapon Subject: Re: svn commit: r255020 - stable/8/sys/fs/devfs References: <201308291225.r7TCPCET002310@svn.freebsd.org> In-Reply-To: <201308291225.r7TCPCET002310@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Aug 2013 14:27:50 -0000 On 29/08/2013 13:25, Andriy Gapon wrote: > Author: avg > Date: Thu Aug 29 12:25:12 2013 > New Revision: 255020 > URL: http://svnweb.freebsd.org/changeset/base/255020 > > Log: > MFC r211847: Set de_dir for user created symbolic links. > > This MFC should fix a panic introduced in r254708. > > Reported by: Toomas Aas , jase > Tested by: jase > MFC slacker: jh Thanks! -- Jase Thew jase@FreeBSD.org FreeBSD Ports Committer