From owner-svn-src-user@FreeBSD.ORG  Sun Sep  8 21:04:43 2013
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id B9D89322;
 Sun,  8 Sep 2013 21:04:43 +0000 (UTC)
 (envelope-from cperciva@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A753B2160;
 Sun,  8 Sep 2013 21:04:43 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r88L4heh061341;
 Sun, 8 Sep 2013 21:04:43 GMT (envelope-from cperciva@svn.freebsd.org)
Received: (from cperciva@localhost)
 by svn.freebsd.org (8.14.7/8.14.5/Submit) id r88L4hO0061340;
 Sun, 8 Sep 2013 21:04:43 GMT (envelope-from cperciva@svn.freebsd.org)
Message-Id: <201309082104.r88L4hO0061340@svn.freebsd.org>
From: Colin Percival <cperciva@FreeBSD.org>
Date: Sun, 8 Sep 2013 21:04:43 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
Subject: svn commit: r255406 - user/cperciva/freebsd-update-mirror
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Sep 2013 21:04:43 -0000

Author: cperciva
Date: Sun Sep  8 21:04:43 2013
New Revision: 255406
URL: http://svnweb.freebsd.org/changeset/base/255406

Log:
  Refuse to package up files for publication if their permissions are set
  such that they will not be readable by the web server.

Modified:
  user/cperciva/freebsd-update-mirror/umirror-package.sh

Modified: user/cperciva/freebsd-update-mirror/umirror-package.sh
==============================================================================
--- user/cperciva/freebsd-update-mirror/umirror-package.sh	Sun Sep  8 20:48:23 2013	(r255405)
+++ user/cperciva/freebsd-update-mirror/umirror-package.sh	Sun Sep  8 21:04:43 2013	(r255406)
@@ -17,6 +17,14 @@ if [ -z "${ID}" ]; then
 	ID=`date "+%s"`
 fi
 
+# Check that the files we're publishing have publishable permissions
+if find "${PRIVDIR}" \! -perm -444 | grep -q .; then
+	echo "Files to be published have bad permissions:"
+	find "${PRIVDIR}" \! -perm -444
+	echo
+	echo "You should fix this before publishing them."
+fi
+
 # Create a tarball
 tar -cf "${PRIVDIR}/dec-${ID}" -C "${STAGEDIR}" .