From owner-freebsd-dtrace@FreeBSD.ORG Thu Oct 9 08:14:19 2014 Return-Path: Delivered-To: freebsd-dtrace@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B2D173C1; Thu, 9 Oct 2014 08:14:19 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id CC8AC850; Thu, 9 Oct 2014 08:14:18 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA11364; Thu, 09 Oct 2014 11:14:17 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Xc8rZ-0004v9-2d; Thu, 09 Oct 2014 11:14:17 +0300 Message-ID: <543643A1.6030002@FreeBSD.org> Date: Thu, 09 Oct 2014 11:13:21 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: freebsd-dtrace@FreeBSD.org Subject: removing solaris cyclic Content-Type: text/plain; charset=X-VIET-VPS Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2014 08:14:19 -0000 I would like to ask for a review and/or testing of the following branch for a phased removal of solaris cyclic code: https://github.com/avg-I/freebsd/compare/review/no-cyclic Raw diff: https://github.com/avg-I/freebsd/compare/master...review/no-cyclic.diff The only user of cyclic now is DTrace profile provider, so I am converting it to use our improved callout(9). cyclic is almost a complete implementation of an alternative to our callout(9), so having that big chunk of foreign code which duplicates a core function is not nice. One thing that I am not sure about is what PROF_ARTIFICIAL_FRAMES should be on different platforms. Also, I am not sure if the number of interrupt, timer, etc frames depends on a timer being used. I'd appreciate any help on this. Thanks! -- Andriy Gapon