From owner-freebsd-geom@FreeBSD.ORG Fri Oct 17 01:26:21 2014 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1430C8D3 for ; Fri, 17 Oct 2014 01:26:21 +0000 (UTC) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0078.outbound.protection.outlook.com [157.56.111.78]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AE120C37 for ; Fri, 17 Oct 2014 01:26:19 +0000 (UTC) Received: from DM2PR0801MB0944.namprd08.prod.outlook.com (25.160.131.27) by DM2PR0801MB0944.namprd08.prod.outlook.com (25.160.131.27) with Microsoft SMTP Server (TLS) id 15.0.1049.19; Fri, 17 Oct 2014 01:10:12 +0000 Received: from DM2PR0801MB0944.namprd08.prod.outlook.com ([25.160.131.27]) by DM2PR0801MB0944.namprd08.prod.outlook.com ([25.160.131.27]) with mapi id 15.00.1049.012; Fri, 17 Oct 2014 01:10:12 +0000 From: "Pokala, Ravi" To: "freebsd-geom@freebsd.org" Subject: Minor addition to confdot (w/ patch) Thread-Topic: Minor addition to confdot (w/ patch) Thread-Index: AQHP6acZ20Kw8n8E9Em2C83KYVfWKA== Date: Fri, 17 Oct 2014 01:10:12 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.4.5.141003 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [64.80.217.3] x-microsoft-antispam: BCL:0;PCL:0;RULEID:;SRVR:DM2PR0801MB0944; x-exchange-antispam-report-test: UriScan:; x-forefront-prvs: 0367A50BB1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(164054003)(189002)(199003)(107886001)(106356001)(77096002)(105586002)(229853001)(120916001)(80022003)(66066001)(40100003)(86362001)(54356999)(2351001)(99286002)(107046002)(2656002)(95666004)(85852003)(99396003)(106116001)(21056001)(87936001)(76482002)(85306004)(92566001)(101416001)(97736003)(31966008)(110136001)(122556002)(83506001)(20776003)(64706001)(36756003)(19580395003)(50986999)(92726001)(46102003)(4396001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0801MB0944; H:DM2PR0801MB0944.namprd08.prod.outlook.com; FPR:; MLV:sfv; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Content-Type: text/plain; charset="us-ascii" Content-ID: <14E0127C728B2A40B686A22A768C6B08@namprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: panasas.com X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Oct 2014 01:26:21 -0000 Hi folks, The GEOM stack diagrams created by 'sysctl -b kern.geom.confdot' (and then run through `dot') are really quite handy. One thing that we really needed at Panasas, but which is not included in the diagram, is the providers' sectorsize and stripesize. This small change adds that info; if there are no objections, could someone submit it on my behalf? Thanks, Ravi Index: sys/geom/geom_dump.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/geom/geom_dump.c (revision 273186) +++ sys/geom/geom_dump.c (working copy) @@ -61,8 +61,8 @@ g_confdot_provider(struct sbuf *sb, struct g_provider *pp) { =20 - sbuf_printf(sb, "z%p [shape=3Dhexagon,label=3D\"%s\\nr%dw%de%d\\nerr#%d\"];\n", - pp, pp->name, pp->acr, pp->acw, pp->ace, pp->error); + sbuf_printf(sb, "z%p [shape=3Dhexagon,label=3D\"%s\\nr%dw%de%d\\nerr#%d\\nsector=3D%d\\nstripe= =3D%d\"];\ n", + pp, pp->name, pp->acr, pp->acw, pp->ace, pp->error, pp->sectorsize, pp->stripesize); } =20 static void