From owner-freebsd-net@FreeBSD.ORG  Sun Sep 14 06:10:17 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 06EA5B35;
 Sun, 14 Sep 2014 06:10:17 +0000 (UTC)
Received: from mail-qa0-x229.google.com (mail-qa0-x229.google.com
 [IPv6:2607:f8b0:400d:c00::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id AA7F5B3D;
 Sun, 14 Sep 2014 06:10:16 +0000 (UTC)
Received: by mail-qa0-f41.google.com with SMTP id f12so2599566qad.14
 for <multiple recipients>; Sat, 13 Sep 2014 23:10:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=ABZD4he02bJ/6yREz5ohVS3Wh2zuJ4ie6OJ4GcwUMN8=;
 b=HAbvjQahITiKR8ffsv4TKRDzWmed+nIVtIvRv2FeF9Xugy9Lic6lFD0EwQXxTqPNuQ
 aDg8sQ90qZhVH/T3FYLnxlj6affnIgF0+EDPyZeqtyzDGME5LjcNkmQCzSDLTw8FFbQq
 NOg3jzta4nXC4OBDd7sVA5tYDj0aaZp2Ynlm8viMKBpDTMewxyDOvuX62/3nlciAG/mp
 Po/m3oJ2J08qJDgtKJLjaFao+Mj6mKrA/JFux8OQF4qfijwF3y68ewJGTF8KIU3DFdzS
 RGm1bwQR3sHlO4b3SdLDR6mS7gm10lqvL+PfUPueOKHaP7xuSKdCToPYSF9ZO/o0qsN7
 GwtA==
MIME-Version: 1.0
X-Received: by 10.140.82.71 with SMTP id g65mr26590147qgd.75.1410675015824;
 Sat, 13 Sep 2014 23:10:15 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.224.39.139 with HTTP; Sat, 13 Sep 2014 23:10:15 -0700 (PDT)
In-Reply-To: <CA+b0zg_Eq7wLP6SRCpBUT5DXDPSxSk=WFZ7-c98W_Xg74-Krzg@mail.gmail.com>
References: <CAJ-Vmok6aSE=ZFZcrBCZUTdHTXosE2eAzG+xkhwn=XM7c7P3Pg@mail.gmail.com>
 <CA+b0zg_Eq7wLP6SRCpBUT5DXDPSxSk=WFZ7-c98W_Xg74-Krzg@mail.gmail.com>
Date: Sat, 13 Sep 2014 23:10:15 -0700
X-Google-Sender-Auth: UzRmF5Jhk_yJKOAiLpiPYaCd8eo
Message-ID: <CAJ-VmonvT7YAxLm3L-+=nz9fsbMDF-Td4iVmqr4+Zo=98Pz2Rg@mail.gmail.com>
Subject: Re: [igb] add DROP_EN to each RX queue config if TX flow control is
 disabled
From: Adrian Chadd <adrian@freebsd.org>
To: Eric Joyner <ricera10@gmail.com>
Content-Type: text/plain; charset=UTF-8
Cc: Jack F Vogel <jfv@freebsd.org>, FreeBSD Net <freebsd-net@freebsd.org>,
 "Joyner, Eric" <eric.joyner@intel.com>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Sep 2014 06:10:17 -0000

On 13 September 2014 13:09, Eric Joyner <ricera10@gmail.com> wrote:
> This looks good to me. The only comment I have is that according to the I350
> datasheet, DROP_EN is already set on all the queues but 0 by default, but I
> haven't checked for the other adapters covered by igb.

Right, but the igb_initialize_receive_units() function actually
overrides the queue SRRCTL; it doesn't do a read-modify-write of what
the initial defaults are.


-a