From owner-freebsd-net@FreeBSD.ORG Sun Dec 14 00:31:53 2014 Return-Path: <owner-freebsd-net@FreeBSD.ORG> Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CFC0DF4A for <freebsd-net@freebsd.org>; Sun, 14 Dec 2014 00:31:53 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B1B47C89 for <freebsd-net@freebsd.org>; Sun, 14 Dec 2014 00:31:53 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id sBE0Vr1s022568 for <freebsd-net@freebsd.org>; Sun, 14 Dec 2014 00:31:53 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id sBE0Vr5f022566; Sun, 14 Dec 2014 00:31:53 GMT (envelope-from root) Date: Sun, 14 Dec 2014 00:31:53 +0000 To: freebsd-net@freebsd.org From: "rodrigc (Craig Rodrigues)" <phabric-noreply@FreeBSD.org> Subject: [Differential] [Request, 70 lines] D1309: VIMAGE PF fixes #1 Message-ID: <differential-rev-PHID-DREV-s3ozye4th7n7swlll3te-req@FreeBSD.org> X-Priority: 3 Thread-Topic: D1309: VIMAGE PF fixes #1 X-Herald-Rules: none X-Phabricator-To: <PHID-USER-2q5asccazp7ohcpzdm6o> X-Phabricator-To: <PHID-USER-ug3kdqciycpghwfscl6v> X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3> X-Phabricator-Cc: <PHID-MLST-crbi54kg7ihel5ezzzmu> X-Phabricator-Cc: <PHID-MLST-5lcr2rqsbmuavxbsw4mm> X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc> Thread-Index: NzA2ZjJlODRkOGZmNmYwM2M1MmQ1N2YzYTJk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: <differential-other>, <differential-reviewers>, <differential-cc>, <differential-review-request> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/> List-Post: <mailto:freebsd-net@freebsd.org> List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sun, 14 Dec 2014 00:31:53 -0000 rodrigc created this revision. rodrigc added reviewers: bz, glebius. rodrigc added subscribers: freebsd-net, freebsd-pf, freebsd-virtualization. REVISION SUMMARY Merge: r258322 from projects/pf branch - Split functions that initialize various pf parts into their vimage parts and global parts. - Since global parts appeared to be only mutex initializations, just abandon them and use MTX_SYSINIT() instead. - Kill my incorrect VNET_FOREACH() iterator and instead use correct approach with VNET_SYSINIT(). Submitted by: glebius, Nikos Vassiliadis <nvass gmx.com> Reviewed by: trociny TEST PLAN - compiled CURRENT kernel with this patch - booted - created VNET jail - started PF in the jail Eliminated some crashes such as PR 194515 REVISION DETAIL https://reviews.freebsd.org/D1309 AFFECTED FILES sys/net/pfvar.h sys/netpfil/pf/pf.c sys/netpfil/pf/pf_if.c sys/netpfil/pf/pf_ioctl.c sys/netpfil/pf/pf_norm.c To: rodrigc, bz, glebius Cc: freebsd-virtualization, freebsd-pf, freebsd-net