From owner-freebsd-numerics@FreeBSD.ORG Sun Oct 12 13:17:41 2014 Return-Path: Delivered-To: freebsd-numerics@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E6F41B4C for ; Sun, 12 Oct 2014 13:17:41 +0000 (UTC) Received: from nibbler.fubar.geek.nz (nibbler.fubar.geek.nz [199.48.134.198]) by mx1.freebsd.org (Postfix) with ESMTP id CD8317DC for ; Sun, 12 Oct 2014 13:17:41 +0000 (UTC) Received: from bender.lan (97e07ab1.skybroadband.com [151.224.122.177]) by nibbler.fubar.geek.nz (Postfix) with ESMTPSA id C7E785CC08 for ; Sun, 12 Oct 2014 13:17:34 +0000 (UTC) Date: Sun, 12 Oct 2014 14:17:13 +0100 From: Andrew Turner To: freebsd-numerics@freebsd.org Subject: ARM floating-point change Message-ID: <20141012141713.7310051b@bender.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Oct 2014 13:17:42 -0000 I'm looking for someone who known more about floating-point than I do to review one of me changes. The change in question adds 6 new functions to the ARM libc to perform floating-point comparisons. These functions are required as part of the ABI spec. The review is at [1]. I am mostly interested in having someone check __aeabi_cfcmpeq_helper and __aeabi_cdcmpeq_helper are correct. They should both return when either argument is a quiet NaN unless one is a signalling NaN for floats and doubles respectively. These functions are used by a functions that is defined to not raise a floating point exception with comparing with quiet NaNs and all comparisons with signalling NaNs could potentially raise an exception. Because of this requirement these functions are used to filter out the cases we have one or more quiet NaNs and no signalling NaNs. Andrew [1] https://reviews.freebsd.org/D872