From owner-freebsd-testing@FreeBSD.ORG Thu Jan 9 23:34:13 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id 02B5D1000
for <freebsd-testing@freebsd.org>; Thu, 9 Jan 2014 23:34:13 +0000 (UTC)
Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com
[209.85.215.181])
(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
(No client certificate requested)
by mx1.freebsd.org (Postfix) with ESMTPS id 8A9CF1AD0
for <freebsd-testing@freebsd.org>; Thu, 9 Jan 2014 23:34:12 +0000 (UTC)
Received: by mail-ea0-f181.google.com with SMTP id m10so1758209eaj.26
for <freebsd-testing@freebsd.org>; Thu, 09 Jan 2014 15:34:05 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
:content-type:content-disposition:user-agent;
bh=vX+TCRPLYLS8rwp/HjdSRb/j7m3aQmybMOyYe+2Ay+w=;
b=jgesx5z/KJyN0qq9cDCvcxat1RjeMvogpBypaocDuKuFM/XJeFVO1nGT9M/UXqN6/0
XHpouca7CF34xh9TNynAWTPyxdXkccvL0b0KBw/JhYnHM51FF5soYf6x/YF9ensPg0xw
6vv44j7dRT6v89zwmAs1LNgw0BZAKQcq2yoAH6e59L0jTAlZLqq71GXrI0lOdlEuA2gY
Ahp5DkxtEms0G/JJserWjaaAazEFlfHSpOVhAjMT67B6peYIWM1+CsyD6t2lswaYqxen
H87IJ4kQ8ncIc5IEmDgy/RnGdLA95FJXXlf4HQArsu6cDmgOH95fZR6TbOsw+iTMhWLx
TqHw==
X-Gm-Message-State: ALoCoQnWhhAzG4KG8WoTpq5MS+WZeFHhUHV7BtrMlKYkihkNym0r2fAsxs7n1MGPSgYg8+yVyzI5
X-Received: by 10.14.176.195 with SMTP id b43mr5130496eem.39.1389310445593;
Thu, 09 Jan 2014 15:34:05 -0800 (PST)
Received: from fbair.virtual.network ([109.255.125.95])
by mx.google.com with ESMTPSA id h3sm9793591eem.15.2014.01.09.15.34.04
for <multiple recipients>
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Thu, 09 Jan 2014 15:34:04 -0800 (PST)
Date: Thu, 9 Jan 2014 18:34:02 -0500
From: Julio Merino <julio@meroh.net>
To: freebsd-testing@freebsd.org
Subject: Fixing installation of Kyuafiles
Message-ID: <20140109233402.GA8193@fbair.virtual.network>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="/04w6evG8XlLl3ft"
Content-Disposition: inline
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: sjg@freebsd.org
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jan 2014 23:34:13 -0000
--/04w6evG8XlLl3ft
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Hello,
The bin/sh and bin/test tests are broken because they cannot be run as root,
yet the testing machines are currently running stuff as root. This is easy
to fix by adding a require_user="unprivileged" property to the tests.
I was going to fix this by adding manually-crafted Kyuafile files that do
the above in bin/sh/tests/ and bin/test/tests/ and setting KYUAFILE=yes in
the corresponding Makefile files... but unfortunately that does not work
with NO_CLEAN builds.
The problem is that bsd.test.mk generates Kyuafile files in the obj directory
and setting KYUAFILE=yes means that make will _still_ see the Kyuafile in the
obj directory and not the one that just appeared in src.
Does the attached patch seem reasonable to prevent this in the future?
The patch does not fix current build trees with NO_CLEAN, but because
WITH_TESTS is not yet the default I don't think it's a big deal.
Thank you.
--/04w6evG8XlLl3ft
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="kyuafiles.diff"
Allow tests to provide a Kyuafile when they relied on auto-generation.
When generating a Kyuafile in the KYUAFILE=auto case, use a filename
that is unlikely to clash with the filename used by explicitly-provided
Kyuafiles.
This allows a Makefile to set KYUAFILE=yes and provide a Kyuafile in
the same directory when such Makefile was previously relying on
KYUAFILE=auto.
Fixes issues with new Kyuafiles not being picked up in NO_CLEAN builds.
Index: UPDATING
===================================================================
--- UPDATING (revision 260496)
+++ UPDATING (working copy)
@@ -31,6 +31,14 @@
disable the most expensive debugging functionality run
"ln -s 'abort:false,junk:false' /etc/malloc.conf".)
+20140109:
+ If a Makefile in a tests/ directory was auto-generating a Kyuafile
+ instead of providing an explicit one, this would prevent such
+ Makefile from providing its own Kyuafile in the future during
+ NO_CLEAN builds. This has been fixed in the Makefiles but manual
+ intervention is needed to clean an objdir if you use NO_CLEAN:
+ # find /usr/obj -name Kyuafile | xargs rm -f
+
20131213:
The behavior of gss_pseudo_random() for the krb5 mechanism
has changed, for applications requesting a longer random string
Index: share/mk/bsd.test.mk
===================================================================
--- share/mk/bsd.test.mk (revision 260496)
+++ share/mk/bsd.test.mk (working copy)
@@ -79,14 +79,17 @@
PROG_VARS+= BINDIR
PROGS_TARGETS+= install
-.if ${KYUAFILE:tl} != "no"
+.if ${KYUAFILE:tl} == "yes"
FILES+= Kyuafile
FILESDIR_Kyuafile= ${TESTSDIR}
+.elif ${KYUAFILE:tl} == "auto"
+FILES+= Kyuafile.auto
+FILESDIR_Kyuafile.auto= ${TESTSDIR}
+FILESNAME_Kyuafile.auto= Kyuafile
-.if ${KYUAFILE:tl} == "auto"
-CLEANFILES+= Kyuafile Kyuafile.tmp
+CLEANFILES+= Kyuafile.auto Kyuafile.auto.tmp
-Kyuafile: Makefile
+Kyuafile.auto: Makefile
@{ \
echo '-- Automatically generated by bsd.test.mk.'; \
echo; \
@@ -94,17 +97,16 @@
echo; \
echo 'test_suite("${TESTSUITE}")'; \
echo; \
- } >Kyuafile.tmp
+ } >Kyuafile.auto.tmp
.for _T in ${_TESTS}
@echo "${TEST_INTERFACE.${_T}}_test_program{name=\"${_T}\"}" \
- >>Kyuafile.tmp
+ >>Kyuafile.auto.tmp
.endfor
.for _T in ${TESTS_SUBDIRS:N.WAIT}
- @echo "include(\"${_T}/Kyuafile\")" >>Kyuafile.tmp
+ @echo "include(\"${_T}/Kyuafile\")" >>Kyuafile.auto.tmp
.endfor
- @mv Kyuafile.tmp Kyuafile
+ @mv Kyuafile.auto.tmp Kyuafile.auto
.endif
-.endif
KYUA?= ${KYUA_PREFIX}/bin/kyua
.if exists(${KYUA})
--/04w6evG8XlLl3ft--
From owner-freebsd-testing@FreeBSD.ORG Thu Jan 9 23:42:43 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id EE8E5298;
Thu, 9 Jan 2014 23:42:43 +0000 (UTC)
Received: from mail-pd0-x22c.google.com (mail-pd0-x22c.google.com
[IPv6:2607:f8b0:400e:c02::22c])
(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
(No client certificate requested)
by mx1.freebsd.org (Postfix) with ESMTPS id BDA3D1C7D;
Thu, 9 Jan 2014 23:42:43 +0000 (UTC)
Received: by mail-pd0-f172.google.com with SMTP id g10so3796954pdj.17
for <multiple recipients>; Thu, 09 Jan 2014 15:42:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=references:mime-version:in-reply-to:content-type
:content-transfer-encoding:message-id:cc:from:subject:date:to;
bh=8pjffH72MWTJmTfaT5MCPrU2Mpw0U1d/VwiUe0fQXdI=;
b=rJn5Ozi2XPKBApDChtWH7ZzxkkPGe4dbx8XSONajA0HWeXuiIQq0FFwY9iso4p5AEJ
4AxuFewIia0zE+0vCd2SOl1OZcXvFUR1f5pPtFvanaZbu3n68YiGhHtIznT/2iUF+pip
DgK1wRsdz2qPvtuU0RSq61oPkQHqhmNO7Cj4zW+4fMC4B4JzkprHr57ekBdAxsf6QEC1
45bAlW3LhHYT+Edpj/SRfaVQ4tbHk2RsAUkWam0eCxTI5SdljrBqr8m8SeDkgb3viTGh
JcDjInTWTg5cxh9/PSPSlWEUYMhYoTvEBEYY/ymTSlNwbJlx0oioeinISiDonlYGS5xG
FJTQ==
X-Received: by 10.68.201.226 with SMTP id kd2mr6736764pbc.157.1389310963341;
Thu, 09 Jan 2014 15:42:43 -0800 (PST)
Received: from [10.0.2.128] ([64.14.143.130])
by mx.google.com with ESMTPSA id i10sm16060808pat.11.2014.01.09.15.42.40
for <multiple recipients>
(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
Thu, 09 Jan 2014 15:42:41 -0800 (PST)
References: <20140109233402.GA8193@fbair.virtual.network>
Mime-Version: 1.0 (1.0)
In-Reply-To: <20140109233402.GA8193@fbair.virtual.network>
Content-Type: text/plain;
charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-Id: <68CF4BF2-E97F-4B5E-920E-854FD6BCA083@gmail.com>
X-Mailer: iPhone Mail (11B554a)
From: Garrett Cooper <yaneurabeya@gmail.com>
Subject: Re: Fixing installation of Kyuafiles
Date: Thu, 9 Jan 2014 15:42:39 -0800
To: Julio Merino <julio@meroh.net>
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>,
"sjg@freebsd.org" <sjg@freebsd.org>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jan 2014 23:42:44 -0000
> On Jan 9, 2014, at 15:34, Julio Merino <julio@meroh.net> wrote:
>=20
> Hello,
>=20
> The bin/sh and bin/test tests are broken because they cannot be run as roo=
t,
> yet the testing machines are currently running stuff as root. This is eas=
y
> to fix by adding a require_user=3D"unprivileged" property to the tests.
>=20
> I was going to fix this by adding manually-crafted Kyuafile files that do
> the above in bin/sh/tests/ and bin/test/tests/ and setting KYUAFILE=3Dyes i=
n
> the corresponding Makefile files... but unfortunately that does not work
> with NO_CLEAN builds.
>=20
> The problem is that bsd.test.mk generates Kyuafile files in the obj direct=
ory
> and setting KYUAFILE=3Dyes means that make will _still_ see the Kyuafile i=
n the
> obj directory and not the one that just appeared in src.
>=20
> Does the attached patch seem reasonable to prevent this in the future?
>=20
> The patch does not fix current build trees with NO_CLEAN, but because
> WITH_TESTS is not yet the default I don't think it's a big deal.
>=20
> Thank you.
> <kyuafiles.diff>
Why not use ${.TARGET} instead of Kyuafile.auto?=
From owner-freebsd-testing@FreeBSD.ORG Thu Jan 9 23:45:38 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id 94B8030E
for <freebsd-testing@freebsd.org>; Thu, 9 Jan 2014 23:45:38 +0000 (UTC)
Received: from mail-la0-f49.google.com (mail-la0-f49.google.com
[209.85.215.49])
(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
(No client certificate requested)
by mx1.freebsd.org (Postfix) with ESMTPS id 1D3091C9C
for <freebsd-testing@freebsd.org>; Thu, 9 Jan 2014 23:45:37 +0000 (UTC)
Received: by mail-la0-f49.google.com with SMTP id er20so2650046lab.8
for <freebsd-testing@freebsd.org>; Thu, 09 Jan 2014 15:45:29 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:in-reply-to:references:from:date
:message-id:subject:to:cc:content-type;
bh=utDteSv3qzps0uL2ey+QXFAv/ZbgIFnnwdAxdGJ6Y4w=;
b=PAV6+UJJmg9ail2Q4Ap17UBTcHtdTTtDCezNE95UG9Pine5lDFmLhF2vdgMNVpdHjA
S1FRpX2IoX7rZeroXuuuqPSBOq9wRyxuKevN+EnD+8UwazHoVaxl/vcad6Do1676Q7ak
y4i2CaphtSBx1m2ZEjAYwN4XU5Rvadt4LvJDGx6JwDybLfEnVqxSneIJ4FuuGNICRwgc
Lnsk33sciOL+YpV8N47kDv4/BFtWmbgLHND+VPMaDq/7lwiuKjtf69s90BqaUsX9NXE0
gky4RXAsVEcn7g5fGAoQC0g2xubdzl/03X/sayHfUepYt1SWE2ve2vVF70cHBeQndCUn
IUyA==
X-Gm-Message-State: ALoCoQnpY10b9VV5DQWRI/hsyMzxkDciS6qXGJWCxEB0ZU+uOoA2grfP27apMH/0ODQspVjnQM2E
X-Received: by 10.152.228.168 with SMTP id sj8mr2393243lac.59.1389311129733;
Thu, 09 Jan 2014 15:45:29 -0800 (PST)
MIME-Version: 1.0
Received: by 10.112.129.101 with HTTP; Thu, 9 Jan 2014 15:45:09 -0800 (PST)
X-Originating-IP: [109.255.125.95]
In-Reply-To: <68CF4BF2-E97F-4B5E-920E-854FD6BCA083@gmail.com>
References: <20140109233402.GA8193@fbair.virtual.network>
<68CF4BF2-E97F-4B5E-920E-854FD6BCA083@gmail.com>
From: Julio Merino <julio@meroh.net>
Date: Thu, 9 Jan 2014 23:45:09 +0000
Message-ID: <CADyfeQV_G8LiOCDPce7RhR1MNnfTpn+B5SGW79+Jhwvs8xj=sw@mail.gmail.com>
Subject: Re: Fixing installation of Kyuafiles
To: Garrett Cooper <yaneurabeya@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>,
"sjg@freebsd.org" <sjg@freebsd.org>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jan 2014 23:45:38 -0000
On Thu, Jan 9, 2014 at 11:42 PM, Garrett Cooper <yaneurabeya@gmail.com> wrote:
> Why not use ${.TARGET} instead of Kyuafile.auto?
If there is a simpler way than my patch, sure, by all means! I kinda
feel that what I did is a hack, hence this email asking for advice :-P
But I'm not sure I follow you... use how?
--
Julio Merino / @jmmv
From owner-freebsd-testing@FreeBSD.ORG Fri Jan 10 00:25:09 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id 629B5372
for <freebsd-testing@freebsd.org>; Fri, 10 Jan 2014 00:25:09 +0000 (UTC)
Received: from co9outboundpool.messaging.microsoft.com
(co9ehsobe001.messaging.microsoft.com [207.46.163.24])
(using TLSv1 with cipher AES128-SHA (128/128 bits))
(No client certificate requested)
by mx1.freebsd.org (Postfix) with ESMTPS id 2083E1F92
for <freebsd-testing@freebsd.org>; Fri, 10 Jan 2014 00:25:08 +0000 (UTC)
Received: from mail12-co9-R.bigfish.com (10.236.132.228) by
CO9EHSOBE013.bigfish.com (10.236.130.76) with Microsoft SMTP Server id
14.1.225.22; Fri, 10 Jan 2014 00:09:57 +0000
Received: from mail12-co9 (localhost [127.0.0.1]) by mail12-co9-R.bigfish.com
(Postfix) with ESMTP id E57503001E3;
Fri, 10 Jan 2014 00:09:56 +0000 (UTC)
X-Forefront-Antispam-Report: CIP:66.129.239.16; KIP:(null); UIP:(null); IPV:NLI;
H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI
X-SpamScore: 2
X-BigFish: VPS2(zz1432Izz1f42h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah1fc6h1082kzz1de097hz31h2a8h839hd25hf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h14ddh1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1b88h224fh1fb3h1d0ch1d2eh1d3fh1de2h1dfeh1dffh1e23h1fe8h1ff5h2218h2216h226dh22d0h2327h2336h2381h2438h1155h)
Received-SPF: softfail (mail12-co9: transitioning domain of juniper.net does
not designate 66.129.239.16 as permitted sender) client-ip=66.129.239.16;
envelope-from=sjg@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ;
Received: from mail12-co9 (localhost.localdomain [127.0.0.1]) by mail12-co9
(MessageSwitch) id 1389312594228544_28516; Fri, 10 Jan 2014 00:09:54 +0000
(UTC)
Received: from CO9EHSMHS026.bigfish.com (unknown [10.236.132.237]) by
mail12-co9.bigfish.com (Postfix) with ESMTP id 324B920005E; Fri, 10 Jan 2014
00:09:54 +0000 (UTC)
Received: from P-EMF02-SAC.jnpr.net (66.129.239.16) by
CO9EHSMHS026.bigfish.com (10.236.130.36) with Microsoft SMTP Server (TLS) id
14.16.227.3; Fri, 10 Jan 2014 00:09:53 +0000
Received: from magenta.juniper.net (172.17.27.123) by P-EMF02-SAC.jnpr.net
(172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.146.0; Thu, 9 Jan
2014 16:09:53 -0800
Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by
magenta.juniper.net (8.11.3/8.11.3) with ESMTP id s0A09qL44428; Thu, 9 Jan
2014 16:09:52 -0800 (PST) (envelope-from sjg@juniper.net)
Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net
(Postfix) with ESMTP id 3F2BF5807E; Thu, 9 Jan 2014 16:09:52 -0800 (PST)
To: Julio Merino <julio@meroh.net>
Subject: Re: Fixing installation of Kyuafiles
In-Reply-To: <20140109233402.GA8193@fbair.virtual.network>
References: <20140109233402.GA8193@fbair.virtual.network>
Comments: In-reply-to: Julio Merino <julio@meroh.net>
message dated "Thu, 09 Jan 2014 18:34:02 -0500."
From: "Simon J. Gerraty" <sjg@juniper.net>
X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1
Date: Thu, 9 Jan 2014 16:09:52 -0800
Message-ID: <20140110000952.3F2BF5807E@chaos.jnpr.net>
MIME-Version: 1.0
Content-Type: text/plain
X-OriginatorOrg: juniper.net
X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn%
Cc: freebsd-testing@freebsd.org, sjg@juniper.net
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jan 2014 00:25:09 -0000
>The bin/sh and bin/test tests are broken because they cannot be run as root,
>yet the testing machines are currently running stuff as root. This is easy
>to fix by adding a require_user="unprivileged" property to the tests.
>
>I was going to fix this by adding manually-crafted Kyuafile files that do
>the above in bin/sh/tests/ and bin/test/tests/ and setting KYUAFILE=yes in
>the corresponding Makefile files... but unfortunately that does not work
>with NO_CLEAN builds.
is the issue limited to just those dirs?
>The problem is that bsd.test.mk generates Kyuafile files in the obj directory
>and setting KYUAFILE=yes means that make will _still_ see the Kyuafile in the
>obj directory and not the one that just appeared in src.
>
>Does the attached patch seem reasonable to prevent this in the future?
This seems a reasonable change.
From owner-freebsd-testing@FreeBSD.ORG Fri Jan 10 01:10:49 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id 5323DB67
for <freebsd-testing@freebsd.org>; Fri, 10 Jan 2014 01:10:49 +0000 (UTC)
Received: from tx2outboundpool.messaging.microsoft.com
(tx2ehsobe001.messaging.microsoft.com [65.55.88.11])
(using TLSv1 with cipher AES128-SHA (128/128 bits))
(No client certificate requested)
by mx1.freebsd.org (Postfix) with ESMTPS id 07D5E1322
for <freebsd-testing@freebsd.org>; Fri, 10 Jan 2014 01:10:48 +0000 (UTC)
Received: from mail208-tx2-R.bigfish.com (10.9.14.232) by
TX2EHSOBE008.bigfish.com (10.9.40.28) with Microsoft SMTP Server id
14.1.225.22; Fri, 10 Jan 2014 00:25:22 +0000
Received: from mail208-tx2 (localhost [127.0.0.1]) by
mail208-tx2-R.bigfish.com (Postfix) with ESMTP id 402DE260260; Fri, 10 Jan
2014 00:25:22 +0000 (UTC)
X-Forefront-Antispam-Report: CIP:66.129.239.16; KIP:(null); UIP:(null); IPV:NLI;
H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI
X-SpamScore: 3
X-BigFish: VPS3(zzzz1f42h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah1fc6h1082kzzz31h2a8h839hd25hf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h14ddh1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1b88h224fh1fb3h1d0ch1d2eh1d3fh1de2h1dfeh1dffh1e23h1fe8h1ff5h2218h2216h226dh22d0h2327h2336h2381h2438h1155h)
Received-SPF: softfail (mail208-tx2: transitioning domain of juniper.net does
not designate 66.129.239.16 as permitted sender) client-ip=66.129.239.16;
envelope-from=sjg@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ;
Received: from mail208-tx2 (localhost.localdomain [127.0.0.1]) by mail208-tx2
(MessageSwitch) id 1389313520350210_6166;
Fri, 10 Jan 2014 00:25:20 +0000 (UTC)
Received: from TX2EHSMHS019.bigfish.com (unknown [10.9.14.232]) by
mail208-tx2.bigfish.com (Postfix) with ESMTP id 50D62180064; Fri, 10 Jan 2014
00:25:20 +0000 (UTC)
Received: from P-EMF02-SAC.jnpr.net (66.129.239.16) by
TX2EHSMHS019.bigfish.com (10.9.99.119) with Microsoft SMTP Server (TLS) id
14.16.227.3; Fri, 10 Jan 2014 00:25:20 +0000
Received: from magenta.juniper.net (172.17.27.123) by P-EMF02-SAC.jnpr.net
(172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.146.0; Thu, 9 Jan
2014 16:25:19 -0800
Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by
magenta.juniper.net (8.11.3/8.11.3) with ESMTP id s0A0PHL54850; Thu, 9 Jan
2014 16:25:17 -0800 (PST) (envelope-from sjg@juniper.net)
Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net
(Postfix) with ESMTP id 9085E5807E; Thu, 9 Jan 2014 16:25:17 -0800 (PST)
To: Julio Merino <julio@meroh.net>
Subject: Re: Fixing installation of Kyuafiles
In-Reply-To: <CADyfeQV_G8LiOCDPce7RhR1MNnfTpn+B5SGW79+Jhwvs8xj=sw@mail.gmail.com>
References: <20140109233402.GA8193@fbair.virtual.network>
<68CF4BF2-E97F-4B5E-920E-854FD6BCA083@gmail.com>
<CADyfeQV_G8LiOCDPce7RhR1MNnfTpn+B5SGW79+Jhwvs8xj=sw@mail.gmail.com>
Comments: In-reply-to: Julio Merino <julio@meroh.net>
message dated "Thu, 09 Jan 2014 23:45:09 +0000."
From: "Simon J. Gerraty" <sjg@juniper.net>
X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1
Date: Thu, 9 Jan 2014 16:25:17 -0800
Message-ID: <20140110002517.9085E5807E@chaos.jnpr.net>
MIME-Version: 1.0
Content-Type: text/plain
X-OriginatorOrg: juniper.net
X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn%
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>,
sjg@juniper.net
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jan 2014 01:10:49 -0000
On Thu, 9 Jan 2014 23:45:09 +0000, Julio Merino writes:
>If there is a simpler way than my patch, sure, by all means! I kinda
>feel that what I did is a hack, hence this email asking for advice :-P
if you want to stick to generated files, allowing for setting knobs in
makefile that influence them, would address both issues. But unless
this is a more generic issue, may not be worth it.
Another alternative is:
.if ${KYUAFILE:tl} != "no"
FILES+= Kyuafile
.if ${KYUAFILE:tl} == "auto"
.NOPATH: Kyuafile
.elif ${.OBJDIR} != ${.CURDIR} && exists(${.CURDIR}/Kyuafile)
# remove any generated file *now*
x!= rm -f ${.OBJDIR}/Kyuafile; echo
.endif
.endif
etc. You could make that
.elif ${.OBJDIR} != ${.CURDIR} && exists(${.CURDIR}/Kyuafile) && exists(${.OBJDIR}/Kyuafile)
if the gratuitous rm -f bothers you.
From owner-freebsd-testing@FreeBSD.ORG Fri Jan 10 17:55:52 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id 1559C30F;
Fri, 10 Jan 2014 17:55:52 +0000 (UTC)
Received: from mail-pd0-x22a.google.com (mail-pd0-x22a.google.com
[IPv6:2607:f8b0:400e:c02::22a])
(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
(No client certificate requested)
by mx1.freebsd.org (Postfix) with ESMTPS id D7126109F;
Fri, 10 Jan 2014 17:55:51 +0000 (UTC)
Received: by mail-pd0-f170.google.com with SMTP id g10so4886659pdj.1
for <multiple recipients>; Fri, 10 Jan 2014 09:55:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=references:mime-version:in-reply-to:content-type
:content-transfer-encoding:message-id:cc:from:subject:date:to;
bh=LQVRvoQjY9zwJXYUy3/qBUDn52PmLTYT2c+uT/06oU0=;
b=AWMM2Lo30YKl915t9A+vDEVWmCoszBMeEnIPpAVQEukjOBsZw8Aj9Bq1a0mvtnqSFj
E2NKZdHLlmBbPY3ocBc+mbkb9oERdNqRZ35ne/6EJ1B+Dx41CjIj4B2uoor8Ymehunxe
ROxZKRETuFJKdwFsRElDB22J/ycsWDMsB0kjQ6e1kYnv3LxuaLvFChDYETjDyUEiSS4p
Ft46ba7OE1LinrFn/R6staFFT+efh+9v0Qx03WasnwTXlhbHaaes2zMJhStaEKDB2MpP
JvIBeS1dZmtL4JuqHcyGQRJgnsiUFv4d58/vxjChECEoLxskKIuf8Etuxbxdw4MPi1qq
GWAA==
X-Received: by 10.68.190.228 with SMTP id gt4mr13210640pbc.94.1389376551441;
Fri, 10 Jan 2014 09:55:51 -0800 (PST)
Received: from [10.0.2.128] ([64.14.143.130])
by mx.google.com with ESMTPSA id ha10sm18995832pbd.17.2014.01.10.09.55.49
for <multiple recipients>
(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
Fri, 10 Jan 2014 09:55:49 -0800 (PST)
References: <20140109233402.GA8193@fbair.virtual.network>
<68CF4BF2-E97F-4B5E-920E-854FD6BCA083@gmail.com>
<CADyfeQV_G8LiOCDPce7RhR1MNnfTpn+B5SGW79+Jhwvs8xj=sw@mail.gmail.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <CADyfeQV_G8LiOCDPce7RhR1MNnfTpn+B5SGW79+Jhwvs8xj=sw@mail.gmail.com>
Content-Type: text/plain;
charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-Id: <F29F79E0-1461-4C90-9954-889FC169D400@gmail.com>
X-Mailer: iPhone Mail (11B554a)
From: Garrett Cooper <yaneurabeya@gmail.com>
Subject: Re: Fixing installation of Kyuafiles
Date: Fri, 10 Jan 2014 09:55:46 -0800
To: Julio Merino <julio@meroh.net>
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>,
"sjg@freebsd.org" <sjg@freebsd.org>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jan 2014 17:55:52 -0000
> On Jan 9, 2014, at 15:45, Julio Merino <julio@meroh.net> wrote:
>=20
>> On Thu, Jan 9, 2014 at 11:42 PM, Garrett Cooper <yaneurabeya@gmail.com> w=
rote:
>> Why not use ${.TARGET} instead of Kyuafile.auto?
>=20
> If there is a simpler way than my patch, sure, by all means! I kinda
> feel that what I did is a hack, hence this email asking for advice :-P
>=20
> But I'm not sure I follow you... use how?
Foo:
echo a string > ${.TARGET}
Vs
Foo:
echo a string > Foo
The former's hard codes less than the latter.
Cheers,
-Garrett=
From owner-freebsd-testing@FreeBSD.ORG Sat Jan 11 08:07:59 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id 7D54E1A4
for <freebsd-testing@freebsd.org>; Sat, 11 Jan 2014 08:07:59 +0000 (UTC)
Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com
[209.85.217.181])
(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
(No client certificate requested)
by mx1.freebsd.org (Postfix) with ESMTPS id 038DF1C87
for <freebsd-testing@freebsd.org>; Sat, 11 Jan 2014 08:07:58 +0000 (UTC)
Received: by mail-lb0-f181.google.com with SMTP id z5so1704867lbh.12
for <freebsd-testing@freebsd.org>; Sat, 11 Jan 2014 00:07:50 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:in-reply-to:references:from:date
:message-id:subject:to:cc:content-type;
bh=+UVOjjTtChlelgwzTS1LOcRj6xUuuGqo95gaM6z9Gj4=;
b=nMamHsG8V7gJyLi9HEyeDtencmQVQE0e91YbC8ACr4C3GQ58i5fQQTvCv/yk0PzGoq
IAWH0rt3T1SLGT79AoY8kj71duQxjG3Bldlt9yqH0tvp0nHZkD/GvlzkrXU3qIjJv6zN
apKIx1NImeF04t2BZ/q4Fz29e7RN3GLTbkYMnw2iW+jbvEPNkfhqBDHfT6hRsYbY7c0E
pf4LBi1CX93TR57MZ5rfNoUORPw+mG1pKxxHIbJ0pItZvewKsJLd+ND7+bjRV8xPlUda
9E15yy3YhydCnNy3WspxTwrXIgQxyFxonIpbHqwru8AK1GFS5WjT5+tXDqA0Xu1i6yHd
4P+Q==
X-Gm-Message-State: ALoCoQnLVFlARwlZ9L3wnNLtFzreYJADi+nfcG5MjsDWuLDyssSHq+Af7nteZsyQMgHtq6jMjnx4
X-Received: by 10.152.180.66 with SMTP id dm2mr64743lac.88.1389427670486; Sat,
11 Jan 2014 00:07:50 -0800 (PST)
MIME-Version: 1.0
Received: by 10.112.129.101 with HTTP; Sat, 11 Jan 2014 00:07:30 -0800 (PST)
X-Originating-IP: [62.57.0.127]
In-Reply-To: <F29F79E0-1461-4C90-9954-889FC169D400@gmail.com>
References: <20140109233402.GA8193@fbair.virtual.network>
<68CF4BF2-E97F-4B5E-920E-854FD6BCA083@gmail.com>
<CADyfeQV_G8LiOCDPce7RhR1MNnfTpn+B5SGW79+Jhwvs8xj=sw@mail.gmail.com>
<F29F79E0-1461-4C90-9954-889FC169D400@gmail.com>
From: Julio Merino <julio@meroh.net>
Date: Sat, 11 Jan 2014 09:07:30 +0100
Message-ID: <CADyfeQW-0i0dsKzK4UJhftGxuOL=ZC1bJWOEzEt9A_213ymEPw@mail.gmail.com>
Subject: Re: Fixing installation of Kyuafiles
To: Garrett Cooper <yaneurabeya@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>,
"sjg@freebsd.org" <sjg@freebsd.org>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>,
<mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Jan 2014 08:07:59 -0000
On Fri, Jan 10, 2014 at 6:55 PM, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>
>> On Jan 9, 2014, at 15:45, Julio Merino <julio@meroh.net> wrote:
>>
>>> On Thu, Jan 9, 2014 at 11:42 PM, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>>> Why not use ${.TARGET} instead of Kyuafile.auto?
>>
>> If there is a simpler way than my patch, sure, by all means! I kinda
>> feel that what I did is a hack, hence this email asking for advice :-P
>>
>> But I'm not sure I follow you... use how?
>
> Foo:
> echo a string > ${.TARGET}
>
> Vs
>
> Foo:
> echo a string > Foo
>
> The former's hard codes less than the latter.
Ah! Somehow I understood that you wanted me to use ${.TARGET} *instead
of* everything else I did in the patch -- hence why it didn't make
much sense originally!
--
Julio Merino / @jmmv