From owner-freebsd-testing@FreeBSD.ORG Sun Feb 16 05:25:07 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0B8B0CA7; Sun, 16 Feb 2014 05:25:07 +0000 (UTC) Received: from mail-pb0-x22f.google.com (mail-pb0-x22f.google.com [IPv6:2607:f8b0:400e:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C99771EA0; Sun, 16 Feb 2014 05:25:06 +0000 (UTC) Received: by mail-pb0-f47.google.com with SMTP id rp16so13987931pbb.34 for ; Sat, 15 Feb 2014 21:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:content-transfer-encoding:subject:date:message-id :cc:to:mime-version; bh=7scBxZD2SrKyCHzJpop0vR/uM/iV5pJ9t2aUvSVpMWk=; b=ikkhlixzUB4nUzlUqoY4/pPY3J1yz/24Cr9DrclklAR6pPKrX/pJogWExhHK/GPJfq H0JXXEMDN3jPn6FCHR7r7o8EDZ7cGRM9jxxUrWcJNA45iEbIUmeI0V0uBAQiVf5pL8Pf eF7lHDdr2hcnRO023MHXDyXu7vIgv4oVPsVpRWtlweea03Hu1UYin4iuu36OkseYBjtz CxPxRcj7NqO8oixFJWmxdb9YM/srRAh3D/XjQpU2w1iq/sE5CmE75wSv+rDFU4oPMjtw +n0wpRgI45ZHyO9VZsQxhYh2U+MHpVd4uCFX/aWKN+OWbfcZPoM1vo96D2r8CWbITr2A 0YGg== X-Received: by 10.68.247.201 with SMTP id yg9mr80760pbc.148.1392528306361; Sat, 15 Feb 2014 21:25:06 -0800 (PST) Received: from [192.168.20.5] (c-50-135-127-159.hsd1.wa.comcast.net. [50.135.127.159]) by mx.google.com with ESMTPSA id eb5sm83215984pad.22.2014.02.15.21.25.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 15 Feb 2014 21:25:05 -0800 (PST) From: Garrett Cooper Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Compile error with gcc Date: Sat, 15 Feb 2014 21:25:03 -0800 Message-Id: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com> To: Julio Merino Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) X-Mailer: Apple Mail (2.1827) Cc: freebsd-testing@FreeBSD.org, Dimitry Andric X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Feb 2014 05:25:07 -0000 Hi Julio, I ran into this error when trying to compile ATF with gcc on = code based off of r261958: --- application.So --- /usr/src/contrib/atf/atf-c++/detail/application.cpp: In constructor = 'atf::application::usage_error::usage_error(const char*, ...)': /usr/src/contrib/atf/atf-c++/detail/application.cpp:71: error: = 'vsnprintf' is not a member of 'std' *** [application.So] Error code 1 I haven=92t dug into why this is occurring yet, but I assume = it=92s because of the ATF 0.20 upgrade. I=92m compiling with gcc/g++ of course, and not clang/libcxxrt. Thanks! -Garrett= From owner-freebsd-testing@FreeBSD.ORG Sun Feb 16 07:28:38 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DB79C915; Sun, 16 Feb 2014 07:28:37 +0000 (UTC) Received: from mail-pd0-x22f.google.com (mail-pd0-x22f.google.com [IPv6:2607:f8b0:400e:c02::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9CC6C1635; Sun, 16 Feb 2014 07:28:37 +0000 (UTC) Received: by mail-pd0-f175.google.com with SMTP id w10so13526668pde.6 for ; Sat, 15 Feb 2014 23:28:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=3XZ27tMkHBBQ2SSDVQRji6fLrp0PH3yg8l4Tlo1GkUE=; b=xnR/2Q8Va32dFxRUn5EvpR8ksKoANsoSTl8Cy+0ll0ToawNLIiMg30HEK+9DFsa/Ys HJkvWgGafAPBpXMUgepRx//4DiUUHh2bIcg+HyOeAcZlQK1Qje8aaDBzRUrWzvObN3Ot u5RP3+L5CnPHCob5IzuwbuPj9YSnQcZ+1f1gYyl5KPsagYRW7M7YrpDDSjhgYjSTSfI1 /fQ/CcpWjwHJsnTdAwwvq6swhTSdZbEuaOuQsckI+znoCelucy65NizYC8HxLqQQyecg LFMoggIDnHQ1PzMj9YGIdQxI3seAhltsjXEBYGjkY3QB6zUkNwrH3SL2AmYkO+fMVfvR W6aw== X-Received: by 10.66.142.132 with SMTP id rw4mr19617797pab.6.1392535717300; Sat, 15 Feb 2014 23:28:37 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:92b:5b4a:998e:fd5d? ([2601:8:ab80:7d6:92b:5b4a:998e:fd5d]) by mx.google.com with ESMTPSA id de1sm33481848pbc.7.2014.02.15.23.28.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 15 Feb 2014 23:28:35 -0800 (PST) Content-Type: multipart/mixed; boundary="Apple-Mail=_C59D78A5-8089-4457-998F-DDABCD9D6BE2" Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Compile error with gcc From: Garrett Cooper In-Reply-To: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com> Date: Sat, 15 Feb 2014 23:28:33 -0800 Message-Id: References: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com> To: Julio Merino X-Mailer: Apple Mail (2.1827) Cc: freebsd-testing@FreeBSD.org, Dimitry Andric X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Feb 2014 07:28:38 -0000 --Apple-Mail=_C59D78A5-8089-4457-998F-DDABCD9D6BE2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Feb 15, 2014, at 9:25 PM, Garrett Cooper = wrote: > Hi Julio, > I ran into this error when trying to compile ATF with gcc on = code based off of r261958: >=20 > --- application.So --- > /usr/src/contrib/atf/atf-c++/detail/application.cpp: In constructor = 'atf::application::usage_error::usage_error(const char*, ...)': > /usr/src/contrib/atf/atf-c++/detail/application.cpp:71: error: = 'vsnprintf' is not a member of 'std' > *** [application.So] Error code 1 >=20 > I haven=92t dug into why this is occurring yet, but I assume = it=92s because of the ATF 0.20 upgrade. > I=92m compiling with gcc/g++ of course, and not clang/libcxxrt. This patch seems to work with gcc and clang/libcxxrt. I didn=92t = try it without clang/libcxxrt though... Thanks! -Garrett --Apple-Mail=_C59D78A5-8089-4457-998F-DDABCD9D6BE2 Content-Disposition: attachment; filename=0001-Unbreak-compiling-ATF-after-the-0.20-upgrade-with-gc.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Unbreak-compiling-ATF-after-the-0.20-upgrade-with-gc.patch" Content-Transfer-Encoding: quoted-printable =46rom=2040e316948a2e9c01f972ce8bae8580191bfd6163=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Garrett=20Cooper=20=0A= Date:=20Sat,=2015=20Feb=202014=2006:45:48=20-0800=0ASubject:=20[PATCH]=20= Unbreak=20compiling=20ATF=20after=20the=200.20=20upgrade=20with=20gcc=0A=0A= ---=0A=20contrib/atf/bconfig.h=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20|=202=20+-=0A=20lib/atf/libatf-c++/tests/detail/Makefile=20= |=204=20++++=0A=202=20files=20changed,=205=20insertions(+),=201=20= deletion(-)=0A=0Adiff=20--git=20a/contrib/atf/bconfig.h=20= b/contrib/atf/bconfig.h=0Aindex=202993f22..822d934=20100644=0A---=20= a/contrib/atf/bconfig.h=0A+++=20b/contrib/atf/bconfig.h=0A@@=20-56,7=20= +56,7=20@@=0A=20#define=20HAVE_UNSETENV=201=0A=20=0A=20/*=20Define=20to=20= 1=20if=20vsnprintf=20is=20in=20std=20*/=0A-#define=20= HAVE_VSNPRINTF_IN_STD=201=0A+/*=20#undef=20HAVE_VSNPRINTF_IN_STD=20*/=0A=20= =0A=20/*=20Define=20to=20the=20sub-directory=20in=20which=20libtool=20= stores=20uninstalled=20libraries.=0A=20=20=20=20*/=0Adiff=20--git=20= a/lib/atf/libatf-c++/tests/detail/Makefile=20= b/lib/atf/libatf-c++/tests/detail/Makefile=0Aindex=204e2e9cf..55576fe=20= 100644=0A---=20a/lib/atf/libatf-c++/tests/detail/Makefile=0A+++=20= b/lib/atf/libatf-c++/tests/detail/Makefile=0A@@=20-9,6=20+9,10=20@@=20= ATF=3D=09=09${.CURDIR:H:H:H:H:H}/contrib/atf=0A=20=0A=20CFLAGS+=3D=09= -I${ATF}=0A=20=0A+.if=20${MK_LIBCPLUSPLUS}=20=3D=3D=20"yes"=0A+CFLAGS+=3D=09= -DHAVE_VSNPRINTF_IN_STD=0A+.endif=0A+=0A=20.for=20_T=20in=09= application_test=20\=0A=20=09=09env_test=20\=0A=20=09=09exceptions_test=20= \=0A--=20=0A1.8.5.2=0A=0A= --Apple-Mail=_C59D78A5-8089-4457-998F-DDABCD9D6BE2-- From owner-freebsd-testing@FreeBSD.ORG Sun Feb 16 12:11:37 2014 Return-Path: Delivered-To: freebsd-testing@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F0EAEDA5; Sun, 16 Feb 2014 12:11:36 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AB1101848; Sun, 16 Feb 2014 12:11:36 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::21c3:44c8:db38:e11b] (unknown [IPv6:2001:7b8:3a7:0:21c3:44c8:db38:e11b]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 84A935C45; Sun, 16 Feb 2014 13:11:32 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_E1EE7649-678C-4FDF-9414-5CCF67D3D728"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Compile error with gcc From: Dimitry Andric In-Reply-To: Date: Sun, 16 Feb 2014 13:11:19 +0100 Message-Id: References: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com> To: Garrett Cooper X-Mailer: Apple Mail (2.1827) Cc: Julio Merino , freebsd-testing@FreeBSD.org, David Chisnall X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Feb 2014 12:11:37 -0000 --Apple-Mail=_E1EE7649-678C-4FDF-9414-5CCF67D3D728 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 16 Feb 2014, at 08:28, Garrett Cooper wrote: > On Feb 15, 2014, at 9:25 PM, Garrett Cooper = wrote: >=20 >> Hi Julio, >> I ran into this error when trying to compile ATF with gcc on = code based off of r261958: >>=20 >> --- application.So --- >> /usr/src/contrib/atf/atf-c++/detail/application.cpp: In constructor = 'atf::application::usage_error::usage_error(const char*, ...)': >> /usr/src/contrib/atf/atf-c++/detail/application.cpp:71: error: = 'vsnprintf' is not a member of 'std' >> *** [application.So] Error code 1 >>=20 >> I haven=92t dug into why this is occurring yet, but I assume = it=92s because of the ATF 0.20 upgrade. >> I=92m compiling with gcc/g++ of course, and not clang/libcxxrt. >=20 > This patch seems to work with gcc and clang/libcxxrt. I didn=92t = try it without clang/libcxxrt though... > Thanks! > -Garrett >=20 > <0001-Unbreak-compiling-ATF-after-the-0.20-upgrade-with-gc.patch> I don't think this will always work correctly. If MK_LIBCPLUSPLUS is defined in bsd.own.mk, it only means libc++ is being *built*, not that it is being used. It is probably easier and more fool-proof to check if _LIBCPP_VERSION is defined (which is the case when you use libc++) in bconfig.h, like so: Index: contrib/atf/bconfig.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- contrib/atf/bconfig.h (revision 261974) +++ contrib/atf/bconfig.h (working copy) @@ -56,7 +56,9 @@ #define HAVE_UNSETENV 1 /* Define to 1 if vsnprintf is in std */ +#ifdef _LIBCPP_VERSION #define HAVE_VSNPRINTF_IN_STD 1 +#endif /* Define to the sub-directory in which libtool stores uninstalled = libraries. */ Finally, please note that libstdc++'s cstdio header *does* have a declaration for vsnprintf(), but it is only active when _GLIBCXX_USE_C99 is defined. Unfortunately, the libstdc++ configure script does not define that variable when you run it, since according to the script, we lack a few C99 maths functions. -Dimitry --Apple-Mail=_E1EE7649-678C-4FDF-9414-5CCF67D3D728 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlMAqvAACgkQsF6jCi4glqNzBgCfdDUjfxA7jhMNz95QsV+p4+0g DQYAn2+kREo6Yl0M9GG6H3LEgtvdWiy9 =Urju -----END PGP SIGNATURE----- --Apple-Mail=_E1EE7649-678C-4FDF-9414-5CCF67D3D728-- From owner-freebsd-testing@FreeBSD.ORG Sun Feb 16 12:22:15 2014 Return-Path: Delivered-To: freebsd-testing@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 92EF1221; Sun, 16 Feb 2014 12:22:15 +0000 (UTC) Received: from blu0-omc1-s21.blu0.hotmail.com (blu0-omc1-s21.blu0.hotmail.com [65.55.116.32]) by mx1.freebsd.org (Postfix) with ESMTP id 5452018D7; Sun, 16 Feb 2014 12:22:14 +0000 (UTC) Received: from BLU0-SMTP202 ([65.55.116.9]) by blu0-omc1-s21.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 16 Feb 2014 04:21:08 -0800 X-TMN: [lA8MOxDSg0D8zDG0f+syy05/vX9H6u0H] X-Originating-Email: [jmmv@outlook.com] Message-ID: Received: from jmmv-macbookpro2.meroh.net ([108.176.158.82]) by BLU0-SMTP202.blu0.hotmail.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 16 Feb 2014 04:21:06 -0800 Content-Type: text/plain; charset="windows-1252" MIME-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Compile error with gcc From: Julio Merino In-Reply-To: Date: Sun, 16 Feb 2014 07:21:08 -0500 Content-Transfer-Encoding: quoted-printable References: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com> To: Garrett Cooper X-Mailer: Apple Mail (2.1827) X-OriginalArrivalTime: 16 Feb 2014 12:21:06.0624 (UTC) FILETIME=[911F9C00:01CF2B11] Cc: freebsd-testing@FreeBSD.org, Dimitry Andric X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Feb 2014 12:22:15 -0000 On Feb 16, 2014, at 2:28, Garrett Cooper wrote: > On Feb 15, 2014, at 9:25 PM, Garrett Cooper = wrote: >=20 >> Hi Julio, >> I ran into this error when trying to compile ATF with gcc on = code based off of r261958: >>=20 >> --- application.So --- >> /usr/src/contrib/atf/atf-c++/detail/application.cpp: In constructor = 'atf::application::usage_error::usage_error(const char*, ...)': >> /usr/src/contrib/atf/atf-c++/detail/application.cpp:71: error: = 'vsnprintf' is not a member of 'std' >> *** [application.So] Error code 1 >>=20 >> I haven=92t dug into why this is occurring yet, but I assume = it=92s because of the ATF 0.20 upgrade. >> I=92m compiling with gcc/g++ of course, and not clang/libcxxrt. >=20 > This patch seems to work with gcc and clang/libcxxrt. I didn=92t = try it without clang/libcxxrt though... Good finding! But the workaround should rather go into = lib/atf/Makefile.inc along all other configuration options. Testing a patch and submitting soon.= From owner-freebsd-testing@FreeBSD.ORG Sun Feb 16 12:46:23 2014 Return-Path: Delivered-To: freebsd-testing@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4E56AD9C; Sun, 16 Feb 2014 12:46:23 +0000 (UTC) Received: from blu0-omc1-s16.blu0.hotmail.com (blu0-omc1-s16.blu0.hotmail.com [65.55.116.27]) by mx1.freebsd.org (Postfix) with ESMTP id 0C7401A41; Sun, 16 Feb 2014 12:46:22 +0000 (UTC) Received: from BLU0-SMTP284 ([65.55.116.7]) by blu0-omc1-s16.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 16 Feb 2014 04:45:16 -0800 X-TMN: [SVW/0o0Py3Z/N41ptNkcT0XpYQbKUYfJ] X-Originating-Email: [jmmv@outlook.com] Message-ID: Received: from jmmv-macbookpro2.meroh.net ([108.176.158.82]) by BLU0-SMTP284.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 16 Feb 2014 04:45:09 -0800 Content-Type: text/plain; charset="windows-1252" MIME-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Compile error with gcc From: Julio Merino In-Reply-To: Date: Sun, 16 Feb 2014 07:45:11 -0500 Content-Transfer-Encoding: quoted-printable References: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com> To: Dimitry Andric X-Mailer: Apple Mail (2.1827) X-OriginalArrivalTime: 16 Feb 2014 12:45:15.0063 (UTC) FILETIME=[F075DC70:01CF2B14] Cc: Garrett Cooper , freebsd-testing@FreeBSD.org, David Chisnall X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Feb 2014 12:46:23 -0000 On Feb 16, 2014, at 7:11, Dimitry Andric wrote: >=20 > I don't think this will always work correctly. If MK_LIBCPLUSPLUS is > defined in bsd.own.mk, it only means libc++ is being *built*, not that > it is being used. >=20 > It is probably easier and more fool-proof to check if _LIBCPP_VERSION = is > defined (which is the case when you use libc++) in bconfig.h, like so: >=20 > Index: contrib/atf/bconfig.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- contrib/atf/bconfig.h (revision 261974) > +++ contrib/atf/bconfig.h (working copy) > @@ -56,7 +56,9 @@ > #define HAVE_UNSETENV 1 >=20 > /* Define to 1 if vsnprintf is in std */ > +#ifdef _LIBCPP_VERSION > #define HAVE_VSNPRINTF_IN_STD 1 > +#endif Let's not do that unless we can change configure.ac to generate these = same contents. Maybe we can just revert this to _not_ define HAVE_VSNPRINTF_IN_STD as = it used to be the case before the new import? Things were working just = fine with both libstdc++ and libc++ even if that setting was not = accurate for the latter...= From owner-freebsd-testing@FreeBSD.ORG Sun Feb 16 13:05:42 2014 Return-Path: Delivered-To: freebsd-testing@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BC2411E6; Sun, 16 Feb 2014 13:05:42 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 752151B5D; Sun, 16 Feb 2014 13:05:42 +0000 (UTC) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 2BA245C45; Sun, 16 Feb 2014 14:05:40 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_151A528F-60B3-40E0-81CE-70AFA50EE14E"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Compile error with gcc From: Dimitry Andric In-Reply-To: Date: Sun, 16 Feb 2014 14:05:33 +0100 Message-Id: <849648F5-7834-45DD-8BDF-6385BF4F82DB@FreeBSD.org> References: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com> To: Julio Merino X-Mailer: Apple Mail (2.1827) Cc: Garrett Cooper , freebsd-testing@FreeBSD.org, David Chisnall X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Feb 2014 13:05:42 -0000 --Apple-Mail=_151A528F-60B3-40E0-81CE-70AFA50EE14E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 16 Feb 2014, at 13:45, Julio Merino wrote: > On Feb 16, 2014, at 7:11, Dimitry Andric wrote: >>=20 >> I don't think this will always work correctly. If MK_LIBCPLUSPLUS is >> defined in bsd.own.mk, it only means libc++ is being *built*, not = that >> it is being used. >>=20 >> It is probably easier and more fool-proof to check if _LIBCPP_VERSION = is >> defined (which is the case when you use libc++) in bconfig.h, like = so: >>=20 >> Index: contrib/atf/bconfig.h >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- contrib/atf/bconfig.h (revision 261974) >> +++ contrib/atf/bconfig.h (working copy) >> @@ -56,7 +56,9 @@ >> #define HAVE_UNSETENV 1 >>=20 >> /* Define to 1 if vsnprintf is in std */ >> +#ifdef _LIBCPP_VERSION >> #define HAVE_VSNPRINTF_IN_STD 1 >> +#endif >=20 > Let's not do that unless we can change configure.ac to generate these = same contents. >=20 > Maybe we can just revert this to _not_ define HAVE_VSNPRINTF_IN_STD as = it used to be the case before the new import? Things were working just = fine with both libstdc++ and libc++ even if that setting was not = accurate for the latter... Well, contrib/atf/atf-c++/detail/application.cpp has: #if !defined(HAVE_VSNPRINTF_IN_STD) namespace std { using ::vsnprintf; } #endif // !defined(HAVE_VSNPRINTF_IN_STD) so it sort of hacks around it anyway. :-) -Dimitry --Apple-Mail=_151A528F-60B3-40E0-81CE-70AFA50EE14E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlMAt6EACgkQsF6jCi4glqO9UQCffr080erKWdZGeIkyoR2he62G KSgAnjjnX+otNPHleTZ8ia8YNUd6akUM =4OEg -----END PGP SIGNATURE----- --Apple-Mail=_151A528F-60B3-40E0-81CE-70AFA50EE14E-- From owner-freebsd-testing@FreeBSD.ORG Sun Feb 16 13:14:30 2014 Return-Path: Delivered-To: freebsd-testing@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B3B3346E; Sun, 16 Feb 2014 13:14:30 +0000 (UTC) Received: from blu0-omc1-s25.blu0.hotmail.com (blu0-omc1-s25.blu0.hotmail.com [65.55.116.36]) by mx1.freebsd.org (Postfix) with ESMTP id 78E3C1C15; Sun, 16 Feb 2014 13:14:30 +0000 (UTC) Received: from BLU0-SMTP35 ([65.55.116.8]) by blu0-omc1-s25.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 16 Feb 2014 05:13:24 -0800 X-TMN: [Fqmecmpe2RlsJQ85xdVH0WrYfims44AM] X-Originating-Email: [jmmv@outlook.com] Message-ID: Received: from jmmv-macbookpro2.meroh.net ([108.176.158.82]) by BLU0-SMTP35.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 16 Feb 2014 05:13:23 -0800 Content-Type: text/plain; charset="windows-1252" MIME-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Compile error with gcc From: Julio Merino In-Reply-To: <849648F5-7834-45DD-8BDF-6385BF4F82DB@FreeBSD.org> Date: Sun, 16 Feb 2014 08:13:24 -0500 Content-Transfer-Encoding: quoted-printable References: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com> <849648F5-7834-45DD-8BDF-6385BF4F82DB@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.1827) X-OriginalArrivalTime: 16 Feb 2014 13:13:23.0172 (UTC) FILETIME=[DEA6DA40:01CF2B18] Cc: Garrett Cooper , freebsd-testing@FreeBSD.org, David Chisnall X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Feb 2014 13:14:30 -0000 On Feb 16, 2014, at 8:05, Dimitry Andric wrote: > On 16 Feb 2014, at 13:45, Julio Merino wrote: >> On Feb 16, 2014, at 7:11, Dimitry Andric wrote: >>>=20 >>> I don't think this will always work correctly. If MK_LIBCPLUSPLUS = is >>> defined in bsd.own.mk, it only means libc++ is being *built*, not = that >>> it is being used. >>>=20 >>> It is probably easier and more fool-proof to check if = _LIBCPP_VERSION is >>> defined (which is the case when you use libc++) in bconfig.h, like = so: >>>=20 >>> Index: contrib/atf/bconfig.h >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- contrib/atf/bconfig.h (revision 261974) >>> +++ contrib/atf/bconfig.h (working copy) >>> @@ -56,7 +56,9 @@ >>> #define HAVE_UNSETENV 1 >>>=20 >>> /* Define to 1 if vsnprintf is in std */ >>> +#ifdef _LIBCPP_VERSION >>> #define HAVE_VSNPRINTF_IN_STD 1 >>> +#endif >>=20 >> Let's not do that unless we can change configure.ac to generate these = same contents. >>=20 >> Maybe we can just revert this to _not_ define HAVE_VSNPRINTF_IN_STD = as it used to be the case before the new import? Things were working = just fine with both libstdc++ and libc++ even if that setting was not = accurate for the latter... >=20 > Well, contrib/atf/atf-c++/detail/application.cpp has: >=20 > #if !defined(HAVE_VSNPRINTF_IN_STD) > namespace std { > using ::vsnprintf; > } > #endif // !defined(HAVE_VSNPRINTF_IN_STD) >=20 > so it sort of hacks around it anyway. :-) Right, so what does C++ say about this? Is that snippet OK even when = std::vsnprintf is already defined, as is the case for libc++? (I.e. = won't that using directive ever conflict with the library?) If the above is true, then I'd just kill the whole HAVE_VSNPRINTF_IN_STD = stupidity from both bconfig.h and application.cpp!= From owner-freebsd-testing@FreeBSD.ORG Mon Feb 17 06:08:00 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6727097F; Mon, 17 Feb 2014 06:08:00 +0000 (UTC) Received: from mail-pd0-x230.google.com (mail-pd0-x230.google.com [IPv6:2607:f8b0:400e:c02::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 28F3D187C; Mon, 17 Feb 2014 06:08:00 +0000 (UTC) Received: by mail-pd0-f176.google.com with SMTP id w10so14419966pde.7 for ; Sun, 16 Feb 2014 22:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=CfFnpBLlA+M+ZbiYZeOJAbS9lBc9L68NnvNXXnrfNf8=; b=QSpbGMMxUy+5HkrlkPC3ZpGil8xlqpOWJVvKngbZ9KiFTX7Q3KzV3fhFNiqi30d5Dz E3Lmb/PiQegDRpHYWYxqWbONz6pQ8EBc7C8oyzk/jixJV0EfLccrs7iDUT2DmXVfNCap IPHWKvJ6fW3x1wMybqalq+utyaoqun2T0f5LeTLgJuEJBzr1M/zRTzNDiz5P2u0cW1B6 5SjVuiIMkUqmX2vub5MVIsQ0Yv5DPrwhGfa3/TjvjpyTgO4ue4HN/W24oO+kV2CSREJW sumiQISrlqsVuZd9BSv773AllWW6hyoGu50KZcpX7iPH+dUfgIG9y7pJz/ZazzNafBHN AXWA== X-Received: by 10.68.129.201 with SMTP id ny9mr24822370pbb.70.1392617279738; Sun, 16 Feb 2014 22:07:59 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:fd41:1b7b:dfb1:40f1? ([2601:8:ab80:7d6:fd41:1b7b:dfb1:40f1]) by mx.google.com with ESMTPSA id sx8sm109038630pab.5.2014.02.16.22.07.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 16 Feb 2014 22:07:58 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Compile error with gcc From: Garrett Cooper In-Reply-To: Date: Sun, 16 Feb 2014 22:07:55 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <2281FB5D-2BF0-4763-AC24-67EC3864D39B@gmail.com> References: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com> <849648F5-7834-45DD-8BDF-6385BF4F82DB@FreeBSD.org> To: Julio Merino X-Mailer: Apple Mail (2.1827) Cc: freebsd-testing@FreeBSD.org, David Chisnall , Dimitry Andric X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Feb 2014 06:08:00 -0000 On Feb 16, 2014, at 5:13 AM, Julio Merino wrote: > On Feb 16, 2014, at 8:05, Dimitry Andric wrote: >=20 >> On 16 Feb 2014, at 13:45, Julio Merino wrote: >>> On Feb 16, 2014, at 7:11, Dimitry Andric wrote: >>>>=20 >>>> I don't think this will always work correctly. If MK_LIBCPLUSPLUS = is >>>> defined in bsd.own.mk, it only means libc++ is being *built*, not = that >>>> it is being used. >>>>=20 >>>> It is probably easier and more fool-proof to check if = _LIBCPP_VERSION is >>>> defined (which is the case when you use libc++) in bconfig.h, like = so: >>>>=20 >>>> Index: contrib/atf/bconfig.h >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> --- contrib/atf/bconfig.h (revision 261974) >>>> +++ contrib/atf/bconfig.h (working copy) >>>> @@ -56,7 +56,9 @@ >>>> #define HAVE_UNSETENV 1 >>>>=20 >>>> /* Define to 1 if vsnprintf is in std */ >>>> +#ifdef _LIBCPP_VERSION >>>> #define HAVE_VSNPRINTF_IN_STD 1 >>>> +#endif >>>=20 >>> Let's not do that unless we can change configure.ac to generate = these same contents. >>>=20 >>> Maybe we can just revert this to _not_ define HAVE_VSNPRINTF_IN_STD = as it used to be the case before the new import? Things were working = just fine with both libstdc++ and libc++ even if that setting was not = accurate for the latter... >>=20 >> Well, contrib/atf/atf-c++/detail/application.cpp has: >>=20 >> #if !defined(HAVE_VSNPRINTF_IN_STD) >> namespace std { >> using ::vsnprintf; >> } >> #endif // !defined(HAVE_VSNPRINTF_IN_STD) >>=20 >> so it sort of hacks around it anyway. :-) >=20 > Right, so what does C++ say about this? Is that snippet OK even when = std::vsnprintf is already defined, as is the case for libc++? (I.e. = won't that using directive ever conflict with the library?) >=20 > If the above is true, then I'd just kill the whole = HAVE_VSNPRINTF_IN_STD stupidity from both bconfig.h and application.cpp! Thanks Dimitry for the input. Should this check be done with=85 #if defined(__cplusplus) && __cplusplus >=3D etc, and if so, what c++ standard was vsnprintf incorporated into? It = looks like should be 201103L (c++11) ( = http://en.cppreference.com/w/cpp/io/c/vfprintf ). If so, then the = configure.ac tests should instead set the appropriate -std variable (or = setting), then test for c++=92s existence. Similarly, libc++ might need = to be fixed to scope out -std properly, unless it=92s purely a c++11 and = newer library. Thanks! -Garrett From owner-freebsd-testing@FreeBSD.ORG Mon Feb 17 13:57:08 2014 Return-Path: Delivered-To: freebsd-testing@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C039C2C8; Mon, 17 Feb 2014 13:57:08 +0000 (UTC) Received: from blu0-omc1-s15.blu0.hotmail.com (blu0-omc1-s15.blu0.hotmail.com [65.55.116.26]) by mx1.freebsd.org (Postfix) with ESMTP id 82E191458; Mon, 17 Feb 2014 13:57:08 +0000 (UTC) Received: from BLU0-SMTP333 ([65.55.116.9]) by blu0-omc1-s15.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 17 Feb 2014 05:56:02 -0800 X-TMN: [ILbSt8UDzZIW2fp5A2YfD/ipPrnFOf1N] X-Originating-Email: [jmmv@outlook.com] Message-ID: Received: from lime.meroh.net ([108.176.158.82]) by BLU0-SMTP333.blu0.hotmail.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 17 Feb 2014 05:56:00 -0800 Content-Type: text/plain; charset="windows-1252" MIME-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Compile error with gcc From: Julio Merino In-Reply-To: <2281FB5D-2BF0-4763-AC24-67EC3864D39B@gmail.com> Date: Mon, 17 Feb 2014 08:55:59 -0500 Content-Transfer-Encoding: quoted-printable References: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com> <849648F5-7834-45DD-8BDF-6385BF4F82DB@FreeBSD.org> <2281FB5D-2BF0-4763-AC24-67EC3864D39B@gmail.com> To: Garrett Cooper X-Mailer: Apple Mail (2.1827) X-OriginalArrivalTime: 17 Feb 2014 13:56:00.0654 (UTC) FILETIME=[FD7162E0:01CF2BE7] Cc: freebsd-testing@FreeBSD.org, David Chisnall , Dimitry Andric X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Feb 2014 13:57:08 -0000 On Feb 17, 2014, at 01:07 , Garrett Cooper wrote: >=20 > Thanks Dimitry for the input. >=20 > Should this check be done with=85 >=20 > #if defined(__cplusplus) && __cplusplus >=3D I'm not sure it's going to work. I think Dimitry mentioned that our = libstdc++ should already provide std::vsnprintf, but due to the flags = it's built with, it doesn't. I'm not sure if, due to this, the version = check above would do the right thing. > etc, and if so, what c++ standard was vsnprintf incorporated into? It = looks like should be 201103L (c++11) = (http://en.cppreference.com/w/cpp/io/c/vfprintf ). If so, then the = configure.ac tests should instead set the appropriate -std variable (or = setting), then test for c++=92s existence. The point of tests in configure.ac scripts is to _not_ do the above = style of checks. If you are going to use those, then you don't need = configure because you can stick those into the code: configure should be = checking what the compiler actually does, not what it claims to support. = This way the checks are future-proof and are going to work even for = compilers you have not tried yet. Note that the check in configure.ac is working just fine and that's not = the problem. The problem is in FreeBSD, where we have a single = bconfig.h for the two compilers and the two compilers behave differently = in at least one of the detected settings. So... we could generate two bconfig.h files, one for each compiler, and = use them accordingly... or we could try to eliminate the divergence = altogether. To do the latter, I think it's enough to remove the = conditional and leave the code doing: namespace std { using ::vsnprintf; } in all cases. It works in clang but I don't know what the standard has = to say in this regard! (FYI: I fixed the immediate problem in HEAD by changing bconfig.h to = #undef the setting -- just as we had been doing since the initial import = of ATF.)= From owner-freebsd-testing@FreeBSD.ORG Mon Feb 17 18:04:48 2014 Return-Path: Delivered-To: freebsd-testing@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C9298B91; Mon, 17 Feb 2014 18:04:48 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4F5621FB1; Mon, 17 Feb 2014 18:04:48 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::1d12:3dd7:fd12:f1d4] (unknown [IPv6:2001:7b8:3a7:0:1d12:3dd7:fd12:f1d4]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 5E8B05C45; Mon, 17 Feb 2014 19:04:45 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_E7E9F002-0DC8-4E3E-8CE6-67C871F511D2"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Compile error with gcc From: Dimitry Andric In-Reply-To: Date: Mon, 17 Feb 2014 19:04:31 +0100 Message-Id: References: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com> <849648F5-7834-45DD-8BDF-6385BF4F82DB@FreeBSD.org> <2281FB5D-2BF0-4763-AC24-67EC3864D39B@gmail.com> To: Julio Merino X-Mailer: Apple Mail (2.1827) Cc: Garrett Cooper , freebsd-testing@FreeBSD.org, David Chisnall X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Feb 2014 18:04:48 -0000 --Apple-Mail=_E7E9F002-0DC8-4E3E-8CE6-67C871F511D2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 17 Feb 2014, at 14:55, Julio Merino wrote: ... > I'm not sure it's going to work. I think Dimitry mentioned that our = libstdc++ should already provide std::vsnprintf, but due to the flags = it's built with, it doesn't. I'm not sure if, due to this, the version = check above would do the right thing. Our libstdc++ config.h is configured that way, because if you run its = configure script, it notices that a few long double maths functions are = missing. Then it disables *all* C99 support in libstdc++, including all = the stuff we do have, like vsnprintf(). I'm not sure what would be broken if we overrode its automatic = detection, and forced libstdc++ to expose C99 functions. Maybe some = other programs would then complain about missing math functions... >> etc, and if so, what c++ standard was vsnprintf incorporated into? It = looks like should be 201103L (c++11) = (http://en.cppreference.com/w/cpp/io/c/vfprintf ). If so, then the = configure.ac tests should instead set the appropriate -std variable (or = setting), then test for c++=92s existence. >=20 > The point of tests in configure.ac scripts is to _not_ do the above = style of checks. If you are going to use those, then you don't need = configure because you can stick those into the code: configure should be = checking what the compiler actually does, not what it claims to support. = This way the checks are future-proof and are going to work even for = compilers you have not tried yet. >=20 > Note that the check in configure.ac is working just fine and that's = not the problem. The problem is in FreeBSD, where we have a single = bconfig.h for the two compilers and the two compilers behave differently = in at least one of the detected settings. It's not the compilers that behave differently, it is the C++ standard = library. If you compile with clang, but use -stdlib=3Dlibstdc++, you = will encounter the same issue, e.g. std::vsnprintf() will not be = available. > So... we could generate two bconfig.h files, one for each compiler, = and use them accordingly... or we could try to eliminate the divergence = altogether. To do the latter, I think it's enough to remove the = conditional and leave the code doing: >=20 > namespace std { > using ::vsnprintf; > } >=20 > in all cases. It works in clang but I don't know what the standard = has to say in this regard! You would simply be using the non-std version of vsnprintf(). I don't = think this should cause any trouble. Having said all this, I guess it would be simpler to just patch up our = libstdc++ to expose the functions we do have for C99, and not care about = what its configure script outputs. -Dimitry --Apple-Mail=_E7E9F002-0DC8-4E3E-8CE6-67C871F511D2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlMCTzsACgkQsF6jCi4glqMlogCgy7NanLOdqiErh9XUYNeXtFd4 x/cAoIr9KGAXJ9Ig000iVjKUeozbIqtF =bwVo -----END PGP SIGNATURE----- --Apple-Mail=_E7E9F002-0DC8-4E3E-8CE6-67C871F511D2-- From owner-freebsd-testing@FreeBSD.ORG Sat Feb 22 19:54:17 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1AA65C59; Sat, 22 Feb 2014 19:54:17 +0000 (UTC) Received: from mail-la0-x235.google.com (mail-la0-x235.google.com [IPv6:2a00:1450:4010:c03::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 696DD17A2; Sat, 22 Feb 2014 19:54:16 +0000 (UTC) Received: by mail-la0-f53.google.com with SMTP id e16so3749095lan.40 for ; Sat, 22 Feb 2014 11:54:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:cc:content-type; bh=K5w1uxqc2rBnU816RjYJCKcwu50zKwwdrhdQr1+EHG8=; b=Mc7VfshMk0N0907BOjedgGO0hJGTg2ZiHmCI3D2GgXzfqAseNECpE7XSkAm9ndDz5d 6+SC3lXf+n2YBCixj7Pqgns4x5bZZFq3FaCxZxrO+mK/1wBhX6Zia11m1TEhdVDYxPit F+j4mXtx+jjYYub05LKr7EJZT0Zx9dj1QpAe9H93oiY3b2ovDg04DD+YtT6uJeWyEwo0 O00VDI3h7sDhDKyarj76GVMUEIhJ55Ovv5pt71mI3J1zCgDl+c7RgNM2eIYCzgS1PZeE TgqPmX4+9skjiN9VAAi2HxI/BirPAN3QJOaasaAIeat/FGA/e7pGom4keNOwSNFp3mm0 8a0A== MIME-Version: 1.0 X-Received: by 10.112.166.68 with SMTP id ze4mr7235978lbb.58.1393098853802; Sat, 22 Feb 2014 11:54:13 -0800 (PST) Sender: crodr001@gmail.com Received: by 10.112.30.211 with HTTP; Sat, 22 Feb 2014 11:54:13 -0800 (PST) Date: Sat, 22 Feb 2014 11:54:13 -0800 X-Google-Sender-Auth: NKxHNY6uR4IfY_nwxBHCgVCzpJo Message-ID: Subject: [HEADSUP] Jenkins running in FreeBSD cluster From: Craig Rodrigues To: freebsd-current Current Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: freebsd-testing@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Feb 2014 19:54:17 -0000 Hi, I just wanted to let the FreeBSD community know that with the help of some FreeBSD hackers, we have set up an initial Jenkins Continuous Integration server in the FreeBSD cluster. We are the jenkins-admin team and you can contact us at jenkins-admin@freebsd.org. We have a few initial builds going and you can see things here: https://jenkins.freebsd.org We are still working on a few problems, and have some ambitious plans moving forward, which you can read about on our status page: http://wiki.freebsd.org/Jenkins Lastly, if you are able to attend the FreeBSD DevSummit in Ottawa later this year, we will have a working group discussion on Jenkins and Continuous Integration testing for FreeBSD on May 15, 2014: https://wiki.freebsd.org/201405DevSummit/Jenkins We'd love to get more FreeBSD hackers involved to get this going and improve continuous integration and testing on FreeBSD. We would like to use the freebsd-testing@freebsd.org mailing list for followup discussions. I'd like to thank my fellow members of the jenkins-admin team for helping to get things going: Steve Kreuzer Li-Wen Hsu Steve Wills R. Tyler Croy If we can integrate more automated testing of FreeBSD with this, that would be really great! -- Craig