From owner-freebsd-testing@FreeBSD.ORG Mon Sep 8 14:23:55 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5727BC8F for ; Mon, 8 Sep 2014 14:23:55 +0000 (UTC) Received: from mail-qc0-f178.google.com (mail-qc0-f178.google.com [209.85.216.178]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1692113BC for ; Mon, 8 Sep 2014 14:23:54 +0000 (UTC) Received: by mail-qc0-f178.google.com with SMTP id x13so15875961qcv.9 for ; Mon, 08 Sep 2014 07:23:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=hUsccFMpjCxXOH4ZcP+an6ovTiZPOaF3hL6p+q4DSWI=; b=LOleA6vJdv/mRQ1KBZlIOzBhx/FZYJ3NjC5pxnIBBdmPDViaKmwcaDpGYqgLjjtedS xAM1SRryOtbmFmml/bPizblZVMgjjpQoOyALMRbOvV/8jbWveuxezra3Cs9cmKOQQL+X AxQAb0lWazIfJT2U+ehd0sX67gOOBXM52LHfnPYT+PxBJypywMs5m107VSut7adSJY7P GPC0WeslnWhLY5uiMMN3qEZb0Ry3PonE8/1iJn17HKHruLAPblRKwUY/3Y2/e+g95rsb bK70sy05g34DmuCtrYoeMojRjTYmHKgsgfv+WEmA0l1+4TIeyIsf4QvHJbiFz3H2OCbf 7IuA== X-Gm-Message-State: ALoCoQluG/M5QSWgGDCYXoWJiqKyohPiT/3HtUIIcZXLfxJKJ1P+FJnHijz+rbfJu1GfLqepxTfD X-Received: by 10.224.88.3 with SMTP id y3mr42091202qal.65.1410186228036; Mon, 08 Sep 2014 07:23:48 -0700 (PDT) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.83.99 with HTTP; Mon, 8 Sep 2014 07:23:27 -0700 (PDT) X-Originating-IP: [2620:0:1003:1007:6091:363d:d526:1ccd] In-Reply-To: References: From: Julio Merino Date: Mon, 8 Sep 2014 10:23:27 -0400 X-Google-Sender-Auth: bP0mtxfwFgV4lDSIbLx6h8TixyE Message-ID: Subject: Re: Introducing the ZFS test suite To: Alan Somers Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-testing@freebsd.org" , "zfs-devel@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2014 14:23:55 -0000 On Mon, Aug 25, 2014 at 2:38 PM, wrote: > I just merged the ZFS test suite to projects/zfsd/head in change 270604. > [...] > The ZFS test suite still has some problems. Some of these are > blocking it from being merged to head: > * The atf-ksh93 hack. This is not a good thing to officially add to > ATF, but it would be a lot of work to convert the test programs to run > under sh. Especially because of the use of ksh arrays. As we discussed, agreed that this is a bit hackish, but I think this is a reasonable compromise and the hack is unlikely to break anytime soon. (Haven't looked at the specifics that were implemented though.) Therefore, I would personally not consider a "rewrite in sh" to be a blocker for merging into head. > Remember, don't run these tests on a production system. What's the plan for this? Are the tests somehow disabled by default so that a user running the full test suite is not tripped by this? Or will all the panics and deadlocks be fixed before merging to head? Thanks for doing this!