From owner-freebsd-toolchain@FreeBSD.ORG Sun Aug 24 07:00:52 2014 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 98A5529B for ; Sun, 24 Aug 2014 07:00:52 +0000 (UTC) Received: from o2.email.wpengine.com (o2.email.wpengine.com [198.37.147.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C6C103E6C for ; Sun, 24 Aug 2014 07:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=email.wpengine.com; h=to:subject:from:reply-to:mime-version:content-transfer-encoding:content-type; s=smtpapi; bh=YaQWtQMGYxgVoZekapcc1/vKCOU=; b=dbDnZgJ3aF/AwjcpLR 8n/OIh1Rh+1dxlSlhwOgKLmfZEHpYyhEmivX+8LntoO/5i2YHK3/zKTQL+my+eM6 /3XV9ix+MB3I0e5TZFxk9RjZlFErVWci4zSk1gYfm/IzUWxRovC4MMhjeK2jG1S5 oTQMUguG+88YMS5Q2NSkA2o0w= Received: by mf184.sendgrid.net with SMTP id mf184.18032.53F98D9B3C 2014-08-24 07:00:44.038027613 +0000 UTC Received: from pod-2745 (li170-216.members.linode.com [173.230.130.216]) by ismtpd-031.iad1.sendgrid.net (SG) with ESMTP id 14806d128dd.4121.2696f0 for ; Sun, 24 Aug 2014 07:00:43 +0000 (GMT) X-SendGrid-User: wpengine-pod-2745 Received: by pod-2745 (Postfix, from userid 33) id ABF1455039; Sun, 24 Aug 2014 07:00:43 +0000 (UTC) To: freebsd-toolchain@freebsd.org Subject: =?UTF-8?Q?Account_Blocked?= X-PHP-Originating-Script: 33:index.php Date: Sun, 24 Aug 2014 07:00:43 +0000 From: =?UTF-8?Q?Support?= Message-ID: <07f293427c09c91ca94f645116991234@souhail.wpengine.com> X-Priority: 1 X-Mailer: PHPMailer (phpmailer.sourceforge.net) [version ] X-SG-EID: wlcJDif7jBNf8lpcFwdN+nmmx9R1BW3jCJQF9hzKdwVp5r4O9QJeXRn5lOoIcOCJOne5AAj8qmEuXp/VddacjtzhsYEc5culrAqhdZKmXRrNbt/lFTgrTtw4tQGOfR3l19Y5jA4ZPfInK5xu4Zn1XvZc1MaJhMUcn7ktdWObK6g= MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Aug 2014 07:00:52 -0000 Dear costumer, You have received this email because our system has noticed some suspicious activities with AÏÏle ID. All what you need to keep enjoying all the benefits of your id is to confirm your identity , follow the link below to start this process . [1]Confirm Now > Wondering why you got this email? Some massive failed login attempts were been made from unknown location that didnt match with your usual one , as a result we decided to suspend your account temporarily in order to protect it . This is an automated message. Please do not reply to this email. Thanks,  Customer. TM and copyright © 2014  Inc. 1 Infinite Loop, MS 96-DM, Cupertino, CA 95014. All Rights Reserved / Keep Informed / Privacy Policy / My ID References 1. http://goo.gl/IsbNDo From owner-freebsd-toolchain@FreeBSD.ORG Thu Aug 28 17:02:58 2014 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D65C2E00; Thu, 28 Aug 2014 17:02:58 +0000 (UTC) Received: from mail-lb0-x234.google.com (mail-lb0-x234.google.com [IPv6:2a00:1450:4010:c04::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 09E6F1266; Thu, 28 Aug 2014 17:02:57 +0000 (UTC) Received: by mail-lb0-f180.google.com with SMTP id w7so1219295lbi.25 for ; Thu, 28 Aug 2014 10:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:cc:content-type; bh=AIN+SpCXJTmKi8Qbs/CAA3Cr02G3MFKlt2jwi734a6c=; b=hXZv5lEzDqWVr/1gpXS/bucurwsu4EEBAokScuXwRBnCT4uRnQVPFSnk8PCnoRhor5 oTTP7Z++NrX4v3qdhNnADtNAM3TDx2rC0AukLmm9ZAD3oeRF/vqH2t9OIH6Z9Fgoe1pi wTptn+4D20mKfBmU88IYaCG8XOQn1QNfM8wV/ofy74xmj3XsWptBvFf5CL3IKV5l0UoN FGgazA0lFjkXpToPyaODMsLGUNg6SPU+Zo8Tne5FRQHxYwCkEB4qyVkvolu8mIba/HRa Qp0Qux6+RQoRE2yGN44tQW+F83te3AAz36EkW9OrtMA2Ym3PACR8EXpEhycTbPOCqPnb kEHg== MIME-Version: 1.0 X-Received: by 10.112.61.68 with SMTP id n4mr5354153lbr.91.1409245375509; Thu, 28 Aug 2014 10:02:55 -0700 (PDT) Sender: edschouten@gmail.com Received: by 10.152.144.2 with HTTP; Thu, 28 Aug 2014 10:02:55 -0700 (PDT) Date: Thu, 28 Aug 2014 19:02:55 +0200 X-Google-Sender-Auth: zZp9dGYxyBGLbliO0zYZO_0ZfgE Message-ID: Subject: Lock annotations: enable them for libpthread, libstdthreads From: Ed Schouten To: freebsd-arch@freebsd.org, freebsd-toolchain@freebsd.org Content-Type: text/plain; charset=UTF-8 Cc: Pawel Jakub Dawidek X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 17:02:59 -0000 Hello all, As some of you may know, Clang supports some form of thread safety analysis by means of annotations: http://clang.llvm.org/docs/ThreadSafetyAnalysis.html To summarize, it works as follows: - You annotate which functions in your code (in)directly acquire/release/depend on which locks. - You annotate global variables and structure members to specify which locks should be held when accessing them (guards). You can then invoke Clang with -Wthread-safety and it will throw a compiler error in case these invariants don't hold. For example, in case you acquire a lock in an unannotated function and don't unlock it before the function returns, it will generate a warning. Couple of random observations on this feature from my side: - It seems that the thread safety stuff was mainly designed with C++ in mind. So far I haven't been able to get guarding annotations working for mutexes residing in structures; only global mutexes. Still, lock/unlock flow analysis on these mutexes works fine, which should already be a game-changer. - We can even use this feature to mark functions like pthread_cond_wait() as requiring the lock to be held. That's pretty sweet. - In userspace, almost all of the code compiled out of the box with -Wthread-safety turned on. I found one actual bug with this enabled (see r270749) and had to patch up a small number of files in auditdistd and hastd to annotate functions that acquire/release locks (see synch.h). I've written a patch that adds #defines for the attributes that are relevant for us (read: things that are useful for C programs) to and patched up all functions in libpthread and libstdthreads to use these attributes where possible: http://80386.nl/pub/20140828-lock_annotate.txt One of my observations is that if we want to use this in C code seriously (which I hope), we would not use it in the same way as is done in C++ canonically. In kernel space it seems that our locking/unlocking strategy is a lot more asymmetric and non-trivial compared to high-level C++ programs. It is more common to have functions that pick up a lock and don't drop it or vice versa. Especially free()-like functions that expect the object to be locked. This is why I decided to go for a different naming scheme for the macros that is a bit shorter than what's used on the Clang page mentioned above. It is also a bit more accurate for our use case. Instead of it being "THE exclusive lock member function of a mutex", it is a function that just happens to "lock a mutex exclusively". My intent is to slowly push bits and pieces of this patch into HEAD within the next week. As the existing userspace only needs a very small number of patches to build with this flag, I am also going to add -Wthread-safety to WARNS=6, to make sure it won't regress. I'm also planning on MFC'ing at least the changes to , so it is at least possible to write portable code. Be sure to take a look at the diff, play around with it and let me know what you think. Thanks, -- Ed Schouten From owner-freebsd-toolchain@FreeBSD.ORG Thu Aug 28 17:34:18 2014 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C805299B; Thu, 28 Aug 2014 17:34:18 +0000 (UTC) Received: from mail-la0-x233.google.com (mail-la0-x233.google.com [IPv6:2a00:1450:4010:c03::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 265BB1744; Thu, 28 Aug 2014 17:34:17 +0000 (UTC) Received: by mail-la0-f51.google.com with SMTP id gl10so1330536lab.38 for ; Thu, 28 Aug 2014 10:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=+0FQhe0yUGT0+AA7klK5mULGs8jc7IL36ltiXtmYoE8=; b=b9GHw0qI/hvE2SLz/5XKZ2QKOah3fGOiDfWdSkSeuE0ZRZF+Rk7cWs5HoEo44Qp5I3 E8p7U6JVx6raa4akm165lTsIb0m17zm949zVJbHpwETN8pgzzwjMjL9kL0hDwcxj2MVn SolRERNK7JMVJ34rhsnGQp1xK0RYW3xzptLWhpKVtUTmgy/ea4BIWj/NqGguAv9YCvW/ l9bDWwOUtAUjVLFUECdNkMky2E09vOz/CywXSwatM7TpeLgW56PQ9h3uKRcO6AP/WFEW JPfsxI7bsYbxjarw4KJkPddZdm6UQeXIX0aaSKwch8+qyjCkI2/BM6TnuDdyBwsAReFt FNRg== MIME-Version: 1.0 X-Received: by 10.152.29.1 with SMTP id f1mr5778513lah.47.1409247255887; Thu, 28 Aug 2014 10:34:15 -0700 (PDT) Sender: edschouten@gmail.com Received: by 10.152.144.2 with HTTP; Thu, 28 Aug 2014 10:34:15 -0700 (PDT) In-Reply-To: <20140828171859.GA81757@troutmask.apl.washington.edu> References: <20140828171859.GA81757@troutmask.apl.washington.edu> Date: Thu, 28 Aug 2014 19:34:15 +0200 X-Google-Sender-Auth: nX6Ojn0CJ7ejjcr5ULxt0hEbOek Message-ID: Subject: Re: Lock annotations: enable them for libpthread, libstdthreads From: Ed Schouten To: Steve Kargl Content-Type: text/plain; charset=UTF-8 Cc: freebsd-toolchain@freebsd.org, freebsd-arch@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 17:34:18 -0000 On 28 August 2014 19:18, Steve Kargl wrote: > What it is the performance penalty (time and memory)? That is, > buildworld already takes a looooonnnnng time on my system because > of clang. My gut feeling is that impact is minimal. Buildworlds seem to take approximately the same time, mainly because we don't have that many annotated objects/functions/expressions. I will do some measurements. -- Ed Schouten From owner-freebsd-toolchain@FreeBSD.ORG Thu Aug 28 17:37:09 2014 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CE009B0F; Thu, 28 Aug 2014 17:37:09 +0000 (UTC) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask.apl.washington.edu", Issuer "troutmask.apl.washington.edu" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 91047176D; Thu, 28 Aug 2014 17:37:09 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.9/8.14.9) with ESMTP id s7SHIxeR081873 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 28 Aug 2014 10:18:59 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.9/8.14.9/Submit) id s7SHIxfo081872; Thu, 28 Aug 2014 10:18:59 -0700 (PDT) (envelope-from sgk) Date: Thu, 28 Aug 2014 10:18:59 -0700 From: Steve Kargl To: Ed Schouten Subject: Re: Lock annotations: enable them for libpthread, libstdthreads Message-ID: <20140828171859.GA81757@troutmask.apl.washington.edu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-toolchain@freebsd.org, freebsd-arch@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 17:37:09 -0000 On Thu, Aug 28, 2014 at 07:02:55PM +0200, Ed Schouten wrote: > > small number of patches to build with this flag, I am also going to > add -Wthread-safety to WARNS=6, to make sure it won't regress. I'm > also planning on MFC'ing at least the changes to , so it > is at least possible to write portable code. What it is the performance penalty (time and memory)? That is, buildworld already takes a looooonnnnng time on my system because of clang. -- Steve From owner-freebsd-toolchain@FreeBSD.ORG Thu Aug 28 19:22:16 2014 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 209F0556; Thu, 28 Aug 2014 19:22:16 +0000 (UTC) Received: from mail-qg0-x22f.google.com (mail-qg0-x22f.google.com [IPv6:2607:f8b0:400d:c04::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C3AA01480; Thu, 28 Aug 2014 19:22:15 +0000 (UTC) Received: by mail-qg0-f47.google.com with SMTP id z60so1232375qgd.6 for ; Thu, 28 Aug 2014 12:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=UgNx2oE70RiXlomV3HGZiCXpMa9z2PlDKNhzNy1Mv2Q=; b=TmQk1GfowkTQTR7d9ZCdIIaL9T6SWOM2xHvNxDjjmqM5xR1XBoUuMADKLtKPH636Z2 f0TBIDsUjj2ep5McGhcdBYhjGcQNCG1aExzYygkCPjRd7pTIjM7EpwrnncahJ7aXhYia 9v6Doopb3DiIw1/EYfmgxb8fMzEkCtdo+jKnsacIG6ezll9/CCe4CAHVYF3/sYCOD7/N TqcPOoRlz+hlPhC0GUgB5LjE4aJ5JKfOVSU0DeP8woWSW/HzmojcAeKNZp8uF8uFeANL iPdqr9iO3CKWaFiLp6GL9hp/j6YvPYlxI/ks735UIdrtTCVdieHewk1e62QXhyteuYH5 mlDQ== MIME-Version: 1.0 X-Received: by 10.224.46.8 with SMTP id h8mr10068218qaf.6.1409253734659; Thu, 28 Aug 2014 12:22:14 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.39.139 with HTTP; Thu, 28 Aug 2014 12:22:14 -0700 (PDT) In-Reply-To: References: <20140828171859.GA81757@troutmask.apl.washington.edu> Date: Thu, 28 Aug 2014 12:22:14 -0700 X-Google-Sender-Auth: enEHJW-qBTlBVzDM18jUokyop10 Message-ID: Subject: Re: Lock annotations: enable them for libpthread, libstdthreads From: Adrian Chadd To: Ed Schouten Content-Type: text/plain; charset=UTF-8 Cc: freebsd-toolchain@freebsd.org, Steve Kargl , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 19:22:16 -0000 On 28 August 2014 10:34, Ed Schouten wrote: > On 28 August 2014 19:18, Steve Kargl wrote: >> What it is the performance penalty (time and memory)? That is, >> buildworld already takes a looooonnnnng time on my system because >> of clang. > > My gut feeling is that impact is minimal. Buildworlds seem to take > approximately the same time, mainly because we don't have that many > annotated objects/functions/expressions. I will do some measurements. Would you please test on something that isn't the latest generation hardware? Even just a core 2 duo would be fine. -a From owner-freebsd-toolchain@FreeBSD.ORG Fri Aug 29 16:31:06 2014 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8001EC9E for ; Fri, 29 Aug 2014 16:31:06 +0000 (UTC) Received: from mon-colo.panasas.com (mon-colo.panasas.com [209.166.131.137]) by mx1.freebsd.org (Postfix) with ESMTP id 44F0213A4 for ; Fri, 29 Aug 2014 16:31:05 +0000 (UTC) Received: from seabiscuit.panasas.com ([172.17.132.204]) by mon-colo.panasas.com with Microsoft SMTPSVC(7.0.6001.18000); Fri, 29 Aug 2014 12:31:04 -0400 Received: from SEABISCUIT.int.panasas.com ([172.17.132.204]) by seabiscuit ([172.17.132.204]) with mapi id 14.03.0181.006; Fri, 29 Aug 2014 09:31:03 -0700 From: "Sinha, Prokash" To: "freebsd-toolchain@freebsd.org" Subject: Build error Thread-Topic: Build error Thread-Index: AQHPw6aff9TA33t5u0SY0Dkf/UZHrQ== Date: Fri, 29 Aug 2014 16:31:02 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.17.133.204] Content-Type: text/plain; charset="us-ascii" Content-ID: <1CBEFBF60CBB57458C1CAFCD1AAD56A1@panasas.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginalArrivalTime: 29 Aug 2014 16:31:04.0744 (UTC) FILETIME=[A0D69A80:01CFC3A6] X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2014 16:31:06 -0000 I was trying to build the latest from the svn trunk - clang/llvm - langAttrEmitter.cpp:994:29: error: 'SimpleArgument' does not refer to a val= ue Ptr =3D llvm::make_unique(Arg, Attr, "int"); ^ ClangAttrEmitter.cpp:216:9: note: declared here class SimpleArgument : public Argument { ^ ClangAttrEmitter.cpp:994:45: warning: expression result unused [-Wunused-va= lue] Ptr =3D llvm::make_unique(Arg, Attr, "int"); ^~~ ClangAttrEmitter.cpp:994:50: warning: expression result unused [-Wunused-va= lue] Ptr =3D llvm::make_unique(Arg, Attr, "int"); ^~~~ ClangAttrEmitter.cpp:996:17: error: no member named 'make_unique' in namesp= ace 'llvm' Ptr =3D llvm::make_unique(Arg, Attr); ~~~~~~^ Any suggestion? Thanks -prokash From owner-freebsd-toolchain@FreeBSD.ORG Fri Aug 29 17:02:16 2014 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4B790968 for ; Fri, 29 Aug 2014 17:02:16 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "tensor.andric.com", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 06A9118ED for ; Fri, 29 Aug 2014 17:02:15 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::46e:5bb0:8f93:b158] (unknown [IPv6:2001:7b8:3a7:0:46e:5bb0:8f93:b158]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 8D0FAB803; Fri, 29 Aug 2014 19:02:06 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_923FA3E7-3325-40A2-8295-5F79D8C7F58D"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: Build error From: Dimitry Andric In-Reply-To: Date: Fri, 29 Aug 2014 19:01:55 +0200 Message-Id: References: To: "Sinha, Prokash" X-Mailer: Apple Mail (2.1878.6) Cc: "freebsd-toolchain@freebsd.org" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2014 17:02:16 -0000 --Apple-Mail=_923FA3E7-3325-40A2-8295-5F79D8C7F58D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 29 Aug 2014, at 18:31, Sinha, Prokash wrote: > I was trying to build the latest from the svn trunk - clang/llvm - >=20 > langAttrEmitter.cpp:994:29: error: 'SimpleArgument' does not refer to = a value > Ptr =3D llvm::make_unique(Arg, Attr, "int"); > ^ > ClangAttrEmitter.cpp:216:9: note: declared here > class SimpleArgument : public Argument { > ^ > ClangAttrEmitter.cpp:994:45: warning: expression result unused = [-Wunused-value] > Ptr =3D llvm::make_unique(Arg, Attr, "int"); > ^~~ > ClangAttrEmitter.cpp:994:50: warning: expression result unused = [-Wunused-value] > Ptr =3D llvm::make_unique(Arg, Attr, "int"); > ^~~~ > ClangAttrEmitter.cpp:996:17: error: no member named 'make_unique' in = namespace 'llvm' > Ptr =3D llvm::make_unique(Arg, Attr); > ~~~~~~^ >=20 > Any suggestion? Completely clean out /usr/obj, and try again. -Dimitry --Apple-Mail=_923FA3E7-3325-40A2-8295-5F79D8C7F58D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlQAsgcACgkQsF6jCi4glqMAtACdHp64pVWO/P14WgHE9HfIKtI+ 9BIAniBRICwhLDnN7j5J12T+rkJqbU5h =hhbB -----END PGP SIGNATURE----- --Apple-Mail=_923FA3E7-3325-40A2-8295-5F79D8C7F58D-- From owner-freebsd-toolchain@FreeBSD.ORG Sat Aug 30 05:33:30 2014 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E5433EFB; Sat, 30 Aug 2014 05:33:30 +0000 (UTC) Received: from mail-la0-x22d.google.com (mail-la0-x22d.google.com [IPv6:2a00:1450:4010:c03::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 430481D93; Sat, 30 Aug 2014 05:33:30 +0000 (UTC) Received: by mail-la0-f45.google.com with SMTP id pn19so3715307lab.4 for ; Fri, 29 Aug 2014 22:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=5O5zyU14ICNb0mAwlFS3aow3W2oDlwrfOEY094VwpOY=; b=ZrB4N5HAxLWw2XuhwM0MvbaOd0fqrUY9vzCElKhi/sxRiluBU9Hc4SaTxH2BNAN3wM De/CNgOXhi16NfQfXvTJyxFXv8ytWFEDWIWVbPIl5GTXH8kO+ml1CTcm+vE9rbfkCukG Go/4+lNr3ZxEZIckqQ0rDXokaZvHjQhzeoGQ9FaqgxzMSeJ6TNwpup9b/wFowNwBvivW hYrk4rc1MGZNPC+bRiKZRYK9++8gyfhqqLTYqJUXKhvgsM/rJFCwWEXkhgbVlEF466iQ QiQ3XFO4e2hWU0XHTeU+XYX73rwK96H/FfDZqFczB9LckUGVWDyvs+jNZL7Zvo8XbCuU N3Og== MIME-Version: 1.0 X-Received: by 10.152.9.42 with SMTP id w10mr15564169laa.9.1409376807716; Fri, 29 Aug 2014 22:33:27 -0700 (PDT) Sender: edschouten@gmail.com Received: by 10.152.144.2 with HTTP; Fri, 29 Aug 2014 22:33:27 -0700 (PDT) In-Reply-To: References: <20140828171859.GA81757@troutmask.apl.washington.edu> Date: Sat, 30 Aug 2014 07:33:27 +0200 X-Google-Sender-Auth: aWjFVkS6R5-j0PUf_BVS6yr6j8o Message-ID: Subject: Re: Lock annotations: enable them for libpthread, libstdthreads From: Ed Schouten To: Steve Kargl Content-Type: text/plain; charset=UTF-8 Cc: freebsd-toolchain@freebsd.org, freebsd-arch@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Aug 2014 05:33:31 -0000 Hi, On 28 August 2014 19:34, Ed Schouten wrote: > My gut feeling is that impact is minimal. Buildworlds seem to take > approximately the same time, mainly because we don't have that many > annotated objects/functions/expressions. I will do some measurements. Some measurements: I've done five 'make buildworlds' with -Wthread-safety and five without. This was just a single-threaded build (no -j). Real time to build world: -Wthread-safety 1:12:55.60 1:12:48.81 1:12:56.33 1:12:44.58 1:12:48.14 -Wno-thread-safety 1:12:50.50 1:12:52.43 1:12:48.20 1:12:42.85 1:12:43.19 That said, this a pretty fast box (i7 4770) with 32 GB of RAM. Unfortunately, I currently don't have any system running FreeBSD that is significantly slower than that. So if you still have any concerns regarding build times, I would really appreciate it if you'd test this patch yourself. Thanks, -- Ed Schouten From owner-freebsd-toolchain@FreeBSD.ORG Sat Aug 30 16:22:20 2014 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AAFDFC73; Sat, 30 Aug 2014 16:22:20 +0000 (UTC) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask.apl.washington.edu", Issuer "troutmask.apl.washington.edu" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C9021C13; Sat, 30 Aug 2014 16:22:20 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.9/8.14.9) with ESMTP id s7UGMFar094743 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 30 Aug 2014 09:22:15 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.9/8.14.9/Submit) id s7UGMF6F094742; Sat, 30 Aug 2014 09:22:15 -0700 (PDT) (envelope-from sgk) Date: Sat, 30 Aug 2014 09:22:15 -0700 From: Steve Kargl To: Ed Schouten Subject: Re: Lock annotations: enable them for libpthread, libstdthreads Message-ID: <20140830162215.GA94722@troutmask.apl.washington.edu> References: <20140828171859.GA81757@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-toolchain@freebsd.org, freebsd-arch@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Aug 2014 16:22:20 -0000 On Sat, Aug 30, 2014 at 07:33:27AM +0200, Ed Schouten wrote: > > On 28 August 2014 19:34, Ed Schouten wrote: > > My gut feeling is that impact is minimal. Buildworlds seem to take > > approximately the same time, mainly because we don't have that many > > annotated objects/functions/expressions. I will do some measurements. > > Some measurements: I've done five 'make buildworlds' with > -Wthread-safety and five without. This was just a single-threaded > build (no -j). Real time to build world: > > -Wthread-safety > > 1:12:55.60 > 1:12:48.81 > 1:12:56.33 > 1:12:44.58 > 1:12:48.14 > > -Wno-thread-safety > > 1:12:50.50 > 1:12:52.43 > 1:12:48.20 > 1:12:42.85 > 1:12:43.19 > > That said, this a pretty fast box (i7 4770) with 32 GB of RAM. > Unfortunately, I currently don't have any system running FreeBSD that > is significantly slower than that. So if you still have any concerns > regarding build times, I would really appreciate it if you'd test this > patch yourself. > Thanks for testing. The above reduces my fear of feature creep where each change only adds a little bit more time to buildworld. -- Steve