From owner-freebsd-wireless@FreeBSD.ORG Sun Nov 16 12:34:50 2014 Return-Path: Delivered-To: freebsd-wireless@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5A581AD2 for ; Sun, 16 Nov 2014 12:34:50 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 428881C2 for ; Sun, 16 Nov 2014 12:34:50 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sAGCYoDc056422 for ; Sun, 16 Nov 2014 12:34:50 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-wireless@FreeBSD.org Subject: [Bug 193588] [new port] net/malo-firmware-1.4: Staged malo(4) firmware module Date: Sun, 16 Nov 2014 12:34:48 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: robak@freebsd.org X-Bugzilla-Status: In Discussion X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: robak@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Nov 2014 12:34:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193588 Bartek Rutkowski changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch Ready |In Discussion --- Comment #22 from Bartek Rutkowski --- John, I've few doubts about the package, namely the issues listed by portlint: WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX. WARN: Makefile: Consider defining LICENSE. WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them. WARN: Makefile: "NO_PACKAGE" found. do not forget to update ports/LEGAL. and the fact that the port is called 'malo-firmware-1.4' however, the port version seems to be extracted from firmware version, that comes from distfiles and currently is '3.0.0.39', so the package name will be extremely confusing, like 'malo-firmware-1.4-3.0.0.39'. Beside that, what's the '1.4', if the port version is '3.0.0.39'? Mind looking into the Makefile a bit more carefully and help us solve the puzzle? -- You are receiving this mail because: You are on the CC list for the bug.