From owner-freebsd-dtrace@freebsd.org  Tue Sep  8 00:31:20 2015
Return-Path: <owner-freebsd-dtrace@freebsd.org>
Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32BFE9CB89B
 for <freebsd-dtrace@mailman.ysv.freebsd.org>;
 Tue,  8 Sep 2015 00:31:20 +0000 (UTC)
 (envelope-from gnn@neville-neil.com)
Received: from smtp.hungerhost.com (smtp.hungerhost.com [216.38.53.177])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0E5481564
 for <freebsd-dtrace@freebsd.org>; Tue,  8 Sep 2015 00:31:19 +0000 (UTC)
 (envelope-from gnn@neville-neil.com)
Received: from pool-108-54-164-204.nycmny.fios.verizon.net
 ([108.54.164.204]:65276 helo=[172.16.33.1])
 by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)
 (Exim 4.85) (envelope-from <gnn@neville-neil.com>)
 id 1ZZ6oh-0000wR-4I; Mon, 07 Sep 2015 20:31:19 -0400
From: "George Neville-Neil" <gnn@neville-neil.com>
To: "alex.burlyga.ietf alex.burlyga.ietf" <alex.burlyga.ietf@gmail.com>
Cc: freebsd-dtrace@freebsd.org
Subject: Re: Broken dtrace script in /usr/share/dtrace
Date: Mon, 07 Sep 2015 20:31:08 -0400
Message-ID: <DA1A9AD8-73DF-40B8-923C-514C11F25B35@neville-neil.com>
In-Reply-To: <CA+JhTNQjFXCaguomDzty3t97By50_=dY9_M_FUmQEamoMjZtyA@mail.gmail.com>
References: <CA+JhTNQjFXCaguomDzty3t97By50_=dY9_M_FUmQEamoMjZtyA@mail.gmail.com>
MIME-Version: 1.0
X-Mailer: MailMate (1.9.2r5107)
X-AntiAbuse: This header was added to track abuse,
 please include it with any abuse report
X-AntiAbuse: Primary Hostname - vps.hungerhost.com
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - neville-neil.com
X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id:
 gnn@neville-neil.com
X-Source: 
X-Source-Args: 
X-Source-Dir: 
X-BeenThere: freebsd-dtrace@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "A discussion list for developers working on DTrace in FreeBSD."
 <freebsd-dtrace.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-dtrace>, 
 <mailto:freebsd-dtrace-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-dtrace/>
List-Post: <mailto:freebsd-dtrace@freebsd.org>
List-Help: <mailto:freebsd-dtrace-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-dtrace>,
 <mailto:freebsd-dtrace-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Sep 2015 00:31:20 -0000

On 3 Sep 2015, at 13:20, alex.burlyga.ietf alex.burlyga.ietf wrote:

> Wanted to show off dtrace to co-workers of mine and tried running
> /usr/share/dtrace/nfsclienttime. I got an error and was not able to
> run it. Patch bellow that fixes the issue on FreeBSD 10.
>
> Alex
>
> diff --git a/share/dtrace/nfsclienttime b/share/dtrace/nfsclienttime
> index 335f067..e7764cf 100755
> --- a/share/dtrace/nfsclienttime
> +++ b/share/dtrace/nfsclienttime
> @@ -54,13 +54,13 @@ syscall:::entry
>        self->count = 0;
> }
>
> -nfsclient:nfs3::start
> +nfscl:nfs3::start
> {
>
>        self->timestamp = timestamp;
> }
>
> -nfsclient:nfs3::done
> +nfscl:nfs3::done
> {
>
>        self->count += (timestamp - self->timestamp);


Thanks, I've applied the same fix to both nfsclienttime and nfsattrstats.

Committed revision 287544.

Best,
George