From owner-freebsd-geom@FreeBSD.ORG  Sun May 10 17:05:04 2015
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B1168E13
 for <freebsd-geom@freebsd.org>; Sun, 10 May 2015 17:05:04 +0000 (UTC)
Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8CD3112FA
 for <freebsd-geom@freebsd.org>; Sun, 10 May 2015 17:05:04 +0000 (UTC)
Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net
 [75.65.60.66])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by thyme.infocus-llc.com (Postfix) with ESMTPSA id 30C0F37B51B;
 Sun, 10 May 2015 12:04:57 -0500 (CDT)
Received: by draco.over-yonder.net (Postfix, from userid 100)
 id 3llBbD4bLwz15c; Sun, 10 May 2015 12:04:56 -0500 (CDT)
Date: Sun, 10 May 2015 12:04:56 -0500
From: "Matthew D. Fuller" <fullermd@over-yonder.net>
To: Fabian Keil <freebsd-listen@fabiankeil.de>
Cc: freebsd-geom@freebsd.org
Subject: Re: RFC: Pass TRIM through GELI
Message-ID: <20150510170456.GZ2092@over-yonder.net>
References: <20150308000131.GP1742@over-yonder.net>
 <20150324021924.GQ52331@over-yonder.net>
 <20150502125220.GS78376@over-yonder.net>
 <4ea2ed80.2a96d87b@fabiankeil.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4ea2ed80.2a96d87b@fabiankeil.de>
X-Editor: vi
X-OS: FreeBSD <http://www.freebsd.org/>
User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12)
X-Virus-Scanned: clamav-milter 0.98.7 at thyme.infocus-llc.com
X-Virus-Status: Clean
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: GEOM-specific discussions and implementations
 <freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-geom>,
 <mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom/>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
 <mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 May 2015 17:05:04 -0000

On Sun, May 03, 2015 at 03:25:30PM +0200 I heard the voice of
Fabian Keil, and lo! it spake thus:
> 
> One minor issue I ran into is that a patched kernel will reject
> onetime requests from an unpatched userland:

Updated the patch on
<https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198863> with trim
and detach fixed there.  While I was at it, I also made some similar
changes on the boot/trim flags in 'configure' handling so it works
with old userland too.


Of course, it still throws errors up on the terminal when you try, but
then it goes ahead and does the stuff.  I sorta think that's
unnecessary, and maybe we oughta bypass gctl_get_paraml()'s error
spouting; in these cases it's not really fatal if the param isn't
there.  It does point up the being-out-of-sync, but I dunno if that's
worth bugging the user in such a roundabout way.

But either way, that's a whole different issue from just adding trim.
With the new patch, it should at least work with stuff unsync'd.  So,
where's the best place to hide out on the road and waylay a committer?


-- 
Matthew Fuller     (MF4839)   |  fullermd@over-yonder.net
Systems/Network Administrator |  http://www.over-yonder.net/~fullermd/
           On the Internet, nobody can hear you scream.