From owner-freebsd-geom@freebsd.org Tue Jul 7 18:30:50 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90B42994428; Tue, 7 Jul 2015 18:30:50 +0000 (UTC) (envelope-from rdarbha@juniper.net) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0105.outbound.protection.outlook.com [65.55.169.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 010AB1F28; Tue, 7 Jul 2015 18:30:49 +0000 (UTC) (envelope-from rdarbha@juniper.net) Received: from DM2PR0501MB1150.namprd05.prod.outlook.com (10.160.245.152) by DM2PR0501MB1151.namprd05.prod.outlook.com (10.160.245.153) with Microsoft SMTP Server (TLS) id 15.1.201.16; Tue, 7 Jul 2015 18:30:41 +0000 Received: from DM2PR0501MB1150.namprd05.prod.outlook.com ([10.160.245.152]) by DM2PR0501MB1150.namprd05.prod.outlook.com ([10.160.245.152]) with mapi id 15.01.0201.000; Tue, 7 Jul 2015 18:30:41 +0000 From: Raviprakash Darbha To: "freebsd-scsi@freebsd.org" , "freebsd-geom@freebsd.org" CC: Raviprakash Darbha Subject: questions about camcontrol eject Thread-Topic: questions about camcontrol eject Thread-Index: AQHQuOMHih5nUrGIREWDx+FWI6Z8KQ== Date: Tue, 7 Jul 2015 18:30:41 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freebsd.org; dkim=none (message not signed) header.d=none; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [66.129.239.14] x-microsoft-exchange-diagnostics: 1; DM2PR0501MB1151; 5:G//G3T20fMKE7BG/ESagbBtUs5sLap+IGaTdwTbiwtemfHgARKC8uRV/VZQUK5FASwMZ6/rta/87LnMG8WE9lY8q3BB81KJpgYyJMKSiEXEuLPnM47KqP3dqubUixP0rklsKr0pXSNkxefVR80x+4w==; 24:3FsK8Ba/EHQmABNIjxLjiO2KK14hjCyujOTd7+PKviOeW3LlwfA28SDCJIn/z7WFovWQHwHKMp+34ZAtJBqPJZJHVmNvSQOWqtUJb8yjlDU=; 20:wZDiY42HqZsHXpgzbqEB2ERJ+DGpD01DUjn+0oCsFvPGx8I3vvZYiTmFYMMWZqxuJ4o8Uq29hVDNTe44mRMbQA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0501MB1151; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:DM2PR0501MB1151; BCL:0; PCL:0; RULEID:; SRVR:DM2PR0501MB1151; x-forefront-prvs: 0630013541 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(53754006)(46102003)(36756003)(229853001)(77156002)(62966003)(54356999)(50986999)(92566002)(16236675004)(77096005)(2656002)(102836002)(122556002)(83716003)(40100003)(2900100001)(99286002)(450100001)(2501003)(87936001)(19580395003)(86362001)(106116001)(5001770100001)(107886002)(5001960100002)(189998001)(82746002)(33656002)(66066001)(5002640100001)(158833001)(4001430100001)(104396002); DIR:OUT; SFP:1102; SCL:1; SRVR:DM2PR0501MB1151; H:DM2PR0501MB1150.namprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; MIME-Version: 1.0 X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2015 18:30:41.6811 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0501MB1151 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2015 18:30:50 -0000 Hello All I am trying to get cam control eject working on my router with 2 drives for= sometime and have some observations from the code. While allocating memory for ccb we either have a malloc option or a memory = pool. In the eject case we choose the memory pool as its low priority. After getting the ccb and setting the relevant fields it is submitted to th= e ata_action routine but then it fails there returning an error code . //Code snippets from sys/cam/scsi/scsi-pass.c /* * Non-immediate CCBs need a CCB from the per-device pool * of CCBs, which is scheduled by the transport layer. * Immediate CCBs and user-supplied CCBs should just be * malloced. */ if ((inccb->ccb_h.func_code & XPT_FC_QUEUED) && ((inccb->ccb_h.func_code & XPT_FC_USER_CCB) =3D=3D 0)) = { ccb =3D cam_periph_getccb(periph, priority); ccb_malloced =3D 0; } else { ccb =3D xpt_alloc_ccb_nowait(); if (ccb !=3D NULL) xpt_setup_ccb(&ccb->ccb_h, periph->path, priority); ccb_malloced =3D 1; } if (ccb =3D=3D NULL) { xpt_print(periph->path, "unable to allocate CCB\n")= ; error =3D ENOMEM; break; } error =3D passsendccb(periph, ccb, inccb); from sys/cam/ata/ata/xpt.c { struct cam_ed *device; u_int maxlen =3D 0; device =3D start_ccb->ccb_h.path->device; if (device->protocol =3D=3D PROTO_SCSI && (device->flags & CAM_DEV_IDENTIFY_DATA_VALID)) { uint16_t p =3D device->ident_data.config & ATA_PROTO_MASK; maxlen =3D (device->ident_data.config =3D=3D ATA_PROTO_CFA= ) ? 0 : (p =3D=3D ATA_PROTO_ATAPI_16) ? 16 : (p =3D=3D ATA_PROTO_ATAPI_12) ? 12 : 0; ///// maxlen is still set to 0. } if (start_ccb->csio.cdb_len > maxlen) { start_ccb->ccb_h.status =3D CAM_REQ_INVALID; xpt_done(start_ccb); break; ///// hence returning from here. } xpt_action_default(start_ccb); break; } My question is if this is a code path thats expected to run this way in whi= ch case I am missing something or is this a bug ? In the later case I am as= suming the ccb_hdr is not set correctly in case we get the ccb from the poo= l so i m considering to set it by calling xpt_ccb_setup in that case too t= o get the right values in the device structure. Any help is greatly appreciated here. Please let me know if more informatio= n is needed. Thanks Ravi From owner-freebsd-geom@freebsd.org Tue Jul 7 21:01:22 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1320E99582B for ; Tue, 7 Jul 2015 21:01:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ED17514A1 for ; Tue, 7 Jul 2015 21:01:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t67L1LOS042483 for ; Tue, 7 Jul 2015 21:01:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-geom@FreeBSD.org Subject: [Bug 201185] [patch] geli: don't panic on spoil events Date: Tue, 07 Jul 2015 21:01:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fullermd@over-yonder.net X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-geom@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2015 21:01:22 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201185 fullermd@over-yonder.net changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158142|0 |1 is obsolete| | --- Comment #1 from fullermd@over-yonder.net --- Created attachment 158515 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=158515&action=edit Patch Updated patch with requested comment improvement. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-geom@freebsd.org Fri Jul 10 19:27:27 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3CA3997799 for ; Fri, 10 Jul 2015 19:27:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C4C6C32E for ; Fri, 10 Jul 2015 19:27:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t6AJRRIW009531 for ; Fri, 10 Jul 2015 19:27:27 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-geom@FreeBSD.org Subject: [Bug 201185] [patch] geli: don't panic on spoil events Date: Fri, 10 Jul 2015 19:27:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-geom@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 19:27:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201185 --- Comment #2 from commit-hook@freebsd.org --- A commit references this bug: Author: pjd Date: Fri Jul 10 19:27:20 UTC 2015 New revision: 285363 URL: https://svnweb.freebsd.org/changeset/base/285363 Log: Spoil even can happen for some time now even on providers opened exclusively (on the media change event). Update GELI to handle that situation. PR: 201185 Submitted by: Matthew D. Fuller Changes: head/sys/geom/eli/g_eli.c -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-geom@freebsd.org Fri Jul 10 19:28:10 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 584CB9977E9 for ; Fri, 10 Jul 2015 19:28:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 44ABB3BC for ; Fri, 10 Jul 2015 19:28:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t6AJSAc8009798 for ; Fri, 10 Jul 2015 19:28:10 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-geom@FreeBSD.org Subject: [Bug 201185] [patch] geli: don't panic on spoil events Date: Fri, 10 Jul 2015 19:28:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: pjd@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-geom@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 19:28:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201185 Pawel Jakub Dawidek changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|In Progress |Closed -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-geom@freebsd.org Fri Jul 10 19:29:07 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB214997835 for ; Fri, 10 Jul 2015 19:29:06 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72]) by mx1.freebsd.org (Postfix) with ESMTP id 98EC6614 for ; Fri, 10 Jul 2015 19:29:05 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from localhost (unknown [91.206.210.19]) by mail.dawidek.net (Postfix) with ESMTPSA id 774B3FB9; Fri, 10 Jul 2015 21:28:57 +0200 (CEST) Date: Fri, 10 Jul 2015 21:30:19 +0200 From: Pawel Jakub Dawidek To: "Matthew D. Fuller" Cc: =?iso-8859-1?Q?Jos=E9_Garc=EDa?= Juanino , freebsd-geom@freebsd.org Subject: Re: geli panics my system after suspend-resume: g_eli_orphan_spoil_assert() called for cd0.eli Message-ID: <20150710193018.GA1270@garage.freebsd.pl> References: <20150613224602.GB1733@over-yonder.net> <20150615060128.GC1733@over-yonder.net> <20150629013011.GN50491@over-yonder.net> <20150701154233.GA1456@garage.freebsd.pl> <20150701193027.GT50491@over-yonder.net> <20150702094909.GA1186@garage.freebsd.pl> <20150702200109.GC50491@over-yonder.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK" Content-Disposition: inline In-Reply-To: <20150702200109.GC50491@over-yonder.net> X-OS: FreeBSD 11.0-CURRENT amd64 User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 19:29:07 -0000 --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 02, 2015 at 03:01:09PM -0500, Matthew D. Fuller wrote: > On Thu, Jul 02, 2015 at 11:49:10AM +0200 I heard the voice of > Pawel Jakub Dawidek, and lo! it spake thus: > >=20 > > With g_media_changed() we can get spoil event even if we hold > > provider exclusively open. Your patch, Matthew, is correct, but > > could you also update the comment there to take into account > > g_media_changed() addition? >=20 > Sure, you mean replacing the comment saying spoiling can't happen? > Something like: >=20 > Index: g_eli.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- g_eli.c (revision 285057) > +++ g_eli.c (working copy) > @@ -730,10 +730,10 @@ > sc =3D malloc(sizeof(*sc), M_ELI, M_WAITOK | M_ZERO); > gp->start =3D g_eli_start; > /* > - * Spoiling cannot happen actually, because we keep provider open for > - * writing all the time or provider is read-only. > + * Spoiling can happen even though we have the provider open > + * exclusively, e.g. through media change events. > */ > - gp->spoiled =3D g_eli_orphan_spoil_assert; > + gp->spoiled =3D g_eli_orphan; > gp->orphan =3D g_eli_orphan; > gp->dumpconf =3D g_eli_dumpconf; > /* Committed, thanks! --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJVoB1KAAoJEJVLhSuxKFt1VHIQAKLkkjO10kTMFXOW9aX9bMW9 OhCHKsJbk9a5+mlD9oXfaDVgv2ZcA67w8RejaVZ9EuNO6ArGZUiRcjxgh8AdFFAA H0NlGZcqvvYtNXrHISY2/DjWIVlIK2QK1IfjAis+vWSwztDmHTrWZLN0rzCNqtkb SEw4asXc20doMJMcNM8qAch/XeT6ZIz2pJm4VGi9Hw+68RWfyjudb2XZUCYy+o0U HHmtuThDyG2Hu9bo3QgtXtuwXGmSxGHUT0SR9VMhywNXtOFEmRrYYljROMy20a++ 34BHZzmPCG06jrQ+h3hpB/M77NCQKOqSfsNsiDhbwXtFNbpIvBrCvsJScImQy4sJ XsV7kgMmCdkWRbO+Bhl9awPd6pRRAye77/zbCcJG3jbgzDTd0HjFq5+BVWC99A56 60XLIbiBqhXkKhfJyeuMdXg8Tb/5VFKZZAsqbaRfupMvHAT9stvT9lJiOqHZ/vV5 o2KDpwDjNBPQXpklZNia7IYUDi7wfbdv+YRC8MTnmbi9DkXJ5QgjQXLy2Kmlpsfc aSg69wUiXecCe7tI16n/6/aS7+Wh97AJMrTX2tR04ezToES2mYWVNRinrx15HRUl wbHPEaeBzBjPAS5oxWhfOiPhypRje+TSIFZ10LpI9ZkHdPldHWSXvmOqIMScHIwK /Fg/FvyYtmriD7lb2guj =6sFX -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK-- From owner-freebsd-geom@freebsd.org Fri Jul 10 20:00:09 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED6DA997CC1 for ; Fri, 10 Jul 2015 20:00:09 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72]) by mx1.freebsd.org (Postfix) with ESMTP id B94791295 for ; Fri, 10 Jul 2015 20:00:09 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from localhost (unknown [91.206.210.19]) by mail.dawidek.net (Postfix) with ESMTPSA id D85A9FC4; Fri, 10 Jul 2015 21:59:49 +0200 (CEST) Date: Fri, 10 Jul 2015 22:01:01 +0200 From: Pawel Jakub Dawidek To: "Matthew D. Fuller" Cc: freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150710200055.GB1270@garage.freebsd.pl> References: <20150308000131.GP1742@over-yonder.net> <20150324021924.GQ52331@over-yonder.net> <20150502125220.GS78376@over-yonder.net> <20150629013841.GO50491@over-yonder.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="O5XBE6gyVG5Rl6Rj" Content-Disposition: inline In-Reply-To: <20150629013841.GO50491@over-yonder.net> X-OS: FreeBSD 11.0-CURRENT amd64 User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 20:00:10 -0000 --O5XBE6gyVG5Rl6Rj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 28, 2015 at 08:38:41PM -0500, Matthew D. Fuller wrote: > > > Stuffed into bugzilla as > > > > > [...] > > > After last round, everybody seems happy enough with this, so I've > > > filed it as > > > . > >=20 > > Does anybody have outstanding concerns on these? Or, if not, what > > else do we need to move them along? They're working fine for me > > here... >=20 > Ping... still working fine here, and I'm pretty sure I've addressed > every concern anybody's raised. Matthew, I'm sorry that it took me so long to get to your patch. The good news is that I like the patch - it looks clean and complete. The bad news is that I like it a bit too much:) I think I'd prefer that BIO_DELETE is passed through by default and there is an option to turn it off. This would mean changing -t option to -T for init and onetime and renaming the G_ELI_FLAG_DELETE flag to G_ELI_FLAG_IGNORE_DELETE. OR... just removing the ability to ignore BIO_DELETEs. The latter is appealing especially if some days we will implement BIO_DELETEs as overwrites. Then we should have an option to turn that on, which would turn off TRIM/UNMAP. Thinking about it some more, I believe that if someone doesn't want TRIM/UNMAP to hit his SSDs it should be configurable on per-SSD basis and not on every layer above SSD. So at the end I'd change my preference to just passing BIO_DELETEs always. What do you think? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com --O5XBE6gyVG5Rl6Rj Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJVoCR3AAoJEJVLhSuxKFt13fUP/juY4IFaXVXMFtgDZYVTWzsn TPkPslFj0jpW+qWYE4aH21WyrXuVe2r6tBaE8c4ao1MZ9EtJv3qWjFf1P6nELf7R RHY+8boW3fuTp7e/R1ijaMkScD5tWs5cHSkvrxrdXsh9LtcPEyEO5djxG+29oZ+9 t1/cSNW40quiTZthP0df7ljwRYT8uW/buO9n1EOLU1sPf8rhlqkoKxfV2FshUcbm 8TK3mAfUC3TIPxqcuMJUDAc+Nguo1FwW0qYwvIbHIHAg4UDEhlxy3QpYJbY9vhAe iX6+lpSAqUxfgs5NiEAiWeH340a81z/QVM3nG8HVPZaA0DTimmp++Lqa9pwv8p1U xFsKd3R/YdYmBbbepCyYS0G2qKmTUysvtns6RVDwLzZWXoctSdjXvAYoXDi9WG3G wVwSUWQGRad2j0QhffzWAC/ViXrsfFd3e3JyI1qWIq8XWMcXtPJeew01Ewox0PEQ 5mUvQYIpwdrbk5MB3V5jK/IGlVzMB0VOAcSIWwQYRwvlygjP5G37lyU0xkRc5u5f Abi0baZLUk79Wos8PyGbvMMAgee0H4Vk9PwZKQRbgl5yV+4LooUnYKeDrHecRDU4 baqnJzMMtxKavUCTpIJIXTASR22aqoMSXhX6K3EX/o+yG13qFHezkzMCeSrlUQaz jOd3m8wHgQgdZL7q2CW6 =WZrH -----END PGP SIGNATURE----- --O5XBE6gyVG5Rl6Rj-- From owner-freebsd-geom@freebsd.org Fri Jul 10 22:38:34 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DDEE0997A1B for ; Fri, 10 Jul 2015 22:38:33 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A0C26150C; Fri, 10 Jul 2015 22:38:33 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id 69C5E37B643; Fri, 10 Jul 2015 17:28:38 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3mSptY5jpQz2p6; Fri, 10 Jul 2015 17:28:37 -0500 (CDT) Date: Fri, 10 Jul 2015 17:28:37 -0500 From: "Matthew D. Fuller" To: Pawel Jakub Dawidek Cc: freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150710222837.GE96394@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <20150324021924.GQ52331@over-yonder.net> <20150502125220.GS78376@over-yonder.net> <20150629013841.GO50491@over-yonder.net> <20150710200055.GB1270@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150710200055.GB1270@garage.freebsd.pl> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.7 at thyme.infocus-llc.com X-Virus-Status: Clean X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 22:38:34 -0000 On Fri, Jul 10, 2015 at 10:01:01PM +0200 I heard the voice of Pawel Jakub Dawidek, and lo! it spake thus: > > The good news is that I like the patch - it looks clean and > complete. The bad news is that I like it a bit too much:) I think > I'd prefer that BIO_DELETE is passed through by default and there is > an option to turn it off. [...] OR... just removing the ability to > ignore BIO_DELETEs. Well, if we removed the configurability and just made it pass 'em through unconditionally, the patch gets REAL simple[0]. 98% of the patch and probably 99.5 of the work is handling the configuration ;) (though we'd still want to pull out the bit for fixing "geli configure' on onetime providers; I tried pulling that out into a separate patch/PR, but it's entwined enough with the other changes in this that the patches would conflict with each other, so I just left it combined) I'm in favor of having it on by default. That's a small adjustment to the patch to swap the default, a larger to do it by inverting the meaning of the flag. Probably worth the extra effort to make it a NO_DELETE flag, rather than just having the bit almost-always set. Should be able to find time to do it within the next couple days. > Thinking about it some more, I believe that if someone doesn't want > TRIM/UNMAP to hit his SSDs it should be configurable on per-SSD > basis and not on every layer above SSD. Well, I figure there are 2 reasons somebody might want to shut it off. 1) Functionality. The SSD, or controller, or something along the chain, gets indigestion when TRIM's happen. In this case, yeah, you want to shut it off at a level way below GELI. 2) Security. For whatever your threat model is, leaking the "how much space is in use" datum is unacceptable. I suspect this is a miniscule fraction of the userbase (probably a miniscule fraction even of those who think of it as an attack). But insofar as it's a concern that needs handled, doing it in GELI would be the right place, since you'd still want to TRIM on the cleartext partition covering the other 3/4 of your SSD. Case (2) seems a little borderline in general. By no means entirely impossible, but perhaps niche enough to be beyond what we care to put effort into supporting. OTOH, in a "Customer Is Always Right" sense, whether they _really_ need it or not has little to do with whether they'll demand it and refuse and badmouth any solution that doesn't provide it. And since I've already done the work (well, almost all, since I'll have to go through and invert the sense), and since it included a little preening in the configuration code paths that could make things a little simpler for the next time somebody has to add flags (e.g., in the 'configure' code path, which had to be reshuffled a fair bit to handle more than 1 possible flag)... well, why not? [0] e.g., (untested, but) Index: g_eli.c =================================================================== --- g_eli.c (revision 285364) +++ g_eli.c (working copy) @@ -309,13 +309,8 @@ case BIO_WRITE: case BIO_GETATTR: case BIO_FLUSH: + case BIO_DELETE: break; - case BIO_DELETE: - /* - * We could eventually support BIO_DELETE request. - * It could be done by overwritting requested sector with - * random data g_eli_overwrites number of times. - */ default: g_io_deliver(bp, EOPNOTSUPP); return; @@ -342,6 +337,7 @@ break; case BIO_GETATTR: case BIO_FLUSH: + case BIO_DELETE: cbp->bio_done = g_std_done; cp = LIST_FIRST(&sc->sc_geom->consumer); cbp->bio_to = cp->provider; -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream. From owner-freebsd-geom@freebsd.org Sat Jul 11 04:25:36 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5009997916 for ; Sat, 11 Jul 2015 04:25:36 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7F0EBDDF; Sat, 11 Jul 2015 04:25:36 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id 2803237B62B; Fri, 10 Jul 2015 23:25:34 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3mSypP2w3gz2sq; Fri, 10 Jul 2015 23:25:33 -0500 (CDT) Date: Fri, 10 Jul 2015 23:25:33 -0500 From: "Matthew D. Fuller" To: Pawel Jakub Dawidek Cc: freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150711042533.GF96394@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <20150324021924.GQ52331@over-yonder.net> <20150502125220.GS78376@over-yonder.net> <20150629013841.GO50491@over-yonder.net> <20150710200055.GB1270@garage.freebsd.pl> <20150710222837.GE96394@over-yonder.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150710222837.GE96394@over-yonder.net> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.7 at thyme.infocus-llc.com X-Virus-Status: Clean X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2015 04:25:36 -0000 On Fri, Jul 10, 2015 at 05:28:37PM -0500 I heard the voice of Matthew D. Fuller, and lo! it spake thus: > > Should be able to find time to do it within the next couple days. Updated geli and swapon patches in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198863 I'm getting odd panics when using AES-XTS on my test system, but I think it's unrelated as I can trigger it with the unmodified code. Looking into that now... -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream. From owner-freebsd-geom@freebsd.org Sat Jul 11 04:51:26 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2645F997E2D for ; Sat, 11 Jul 2015 04:51:26 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 004781A57 for ; Sat, 11 Jul 2015 04:51:25 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id 2420037B643 for ; Fri, 10 Jul 2015 23:51:25 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3mSzND41sZz2tL; Fri, 10 Jul 2015 23:51:24 -0500 (CDT) Date: Fri, 10 Jul 2015 23:51:24 -0500 From: "Matthew D. Fuller" To: freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150711045124.GH96394@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <20150324021924.GQ52331@over-yonder.net> <20150502125220.GS78376@over-yonder.net> <20150629013841.GO50491@over-yonder.net> <20150710200055.GB1270@garage.freebsd.pl> <20150710222837.GE96394@over-yonder.net> <20150711042533.GF96394@over-yonder.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150711042533.GF96394@over-yonder.net> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.7 at thyme.infocus-llc.com X-Virus-Status: Clean X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2015 04:51:26 -0000 On Fri, Jul 10, 2015 at 11:25:33PM -0500 I heard the voice of Matthew D. Fuller, and lo! it spake thus: > > I'm getting odd panics when using AES-XTS on my test system, but I > think it's unrelated as I can trigger it with the unmodified code. > Looking into that now... Appears to be non-GEOM related; x-ref . -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream. From owner-freebsd-geom@freebsd.org Sat Jul 11 04:59:40 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9097C997F7F for ; Sat, 11 Jul 2015 04:59:40 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 640791E1C for ; Sat, 11 Jul 2015 04:59:40 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id 2F91B37B659 for ; Fri, 10 Jul 2015 23:59:39 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3mSzYk4Mglz2tY; Fri, 10 Jul 2015 23:59:38 -0500 (CDT) Date: Fri, 10 Jul 2015 23:59:38 -0500 From: "Matthew D. Fuller" To: freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150711045938.GI96394@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <20150324021924.GQ52331@over-yonder.net> <20150502125220.GS78376@over-yonder.net> <20150629013841.GO50491@over-yonder.net> <20150710200055.GB1270@garage.freebsd.pl> <20150710222837.GE96394@over-yonder.net> <20150711042533.GF96394@over-yonder.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150711042533.GF96394@over-yonder.net> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.7 at thyme.infocus-llc.com X-Virus-Status: Clean X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2015 04:59:40 -0000 On Fri, Jul 10, 2015 at 11:25:33PM -0500 I heard the voice of Matthew D. Fuller, and lo! it spake thus: > > Updated geli and swapon patches in > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198863 For those follwoing along at home, do note that this inverts the sense of the flags. So if you're using the patches and have a TRIM'able .eli, this update will make it non-trimmable; just 'geli configure -t' it over. And if you've got any 'trim' lines in fstab, take out the trim bit or swapon will yell at you. -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream. From owner-freebsd-geom@freebsd.org Sat Jul 11 13:15:59 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4D3983F3C for ; Sat, 11 Jul 2015 13:15:59 +0000 (UTC) (envelope-from rwmaillists@googlemail.com) Received: from mail-wi0-x22a.google.com (mail-wi0-x22a.google.com [IPv6:2a00:1450:400c:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D971F1004 for ; Sat, 11 Jul 2015 13:15:58 +0000 (UTC) (envelope-from rwmaillists@googlemail.com) Received: by wiga1 with SMTP id a1so35101586wig.0 for ; Sat, 11 Jul 2015 06:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=DR3h7xfR2YYB6d797WirYzF7o7NgTSJlCcyaj00PHc0=; b=FE4Z2lnEifbB7LgcFr3uhMGBjQMqnnbZKkqU3TbNfqieFDHIGPgLyDfePtag8nVthm cfAuZkuzICfmraepY8K2s1FDhvhHjLg2gp1oCN6+HsYH8jZOCmC4Agmz8rAUxMomFpVC vA0czjB0dnh4Xqwmp0gHgjtWAtrGIm6CZkY10IxVHbxOsu32kqCPtXKoBYo83HrMbwUe MRAia0HbNuGYIzgbNfxgViQBkQOlOxTx4ppJ+u2hf3B1PXhNfa2NbGIKin939IB4EQ1b pMx3PlqEsFmZ++ippjBzUYeX8alKwBPfJuGZ8KenfjFB+Mz6XLHmtnF47FoctudRxFHK 9/0g== X-Received: by 10.194.77.97 with SMTP id r1mr47513174wjw.98.1436620557415; Sat, 11 Jul 2015 06:15:57 -0700 (PDT) Received: from gumby.homeunix.com (5ec1f6f9.skybroadband.com. [94.193.246.249]) by smtp.gmail.com with ESMTPSA id bg6sm18134182wjc.13.2015.07.11.06.15.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Jul 2015 06:15:56 -0700 (PDT) Date: Sat, 11 Jul 2015 14:15:53 +0100 From: RW To: freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150711141553.3fcf91f4@gumby.homeunix.com> In-Reply-To: <20150710222837.GE96394@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <20150324021924.GQ52331@over-yonder.net> <20150502125220.GS78376@over-yonder.net> <20150629013841.GO50491@over-yonder.net> <20150710200055.GB1270@garage.freebsd.pl> <20150710222837.GE96394@over-yonder.net> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; amd64-portbld-freebsd10.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2015 13:15:59 -0000 On Fri, 10 Jul 2015 17:28:37 -0500 Matthew D. Fuller wrote: > 2) Security. For whatever your threat model is, leaking the "how much > space is in use" datum is unacceptable. It's not about how much space is free, it's about giving away which blocks do and don't contain data. Perhaps more importantly TRIM breaks plausible deniabily, which was the the point of allowing the geli metadata to be store separately. You can't argue that a partition has been wiped with 'dd if=/dev/random ...' if the the partition has been subsequently trimmed.