From owner-freebsd-jail@FreeBSD.ORG Mon Mar 16 16:04:03 2015 Return-Path: Delivered-To: freebsd-jail@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5865C84F for ; Mon, 16 Mar 2015 16:04:03 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3E9729B7 for ; Mon, 16 Mar 2015 16:04:03 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2GG433H045986 for ; Mon, 16 Mar 2015 16:04:03 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-jail@FreeBSD.org Subject: [Bug 196152] jail_list is not reversed when stopping jails Date: Mon, 16 Mar 2015 16:04:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: feld@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-jail@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2015 16:04:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196152 Mark Felder changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |feld@FreeBSD.org --- Comment #1 from Mark Felder --- Created attachment 154424 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=154424&action=edit reverse jail list This seems fairly simple. It looks like etc/rc.d/jail stop routine works on $@ derived from ${jail_list}, which is _ALL by default: ${jail_list:-_ALL} It returns after shutting down all the jails if _ALL was provided, otherwise works on the ${jail_list} in a for loop. This simple patch creates a reverse list of the items in ${jail_list} and uses that for shutdown instead. I haven't tested, but it looks like it would work just fine. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-jail@FreeBSD.ORG Mon Mar 16 17:02:51 2015 Return-Path: Delivered-To: freebsd-jail@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D6B8D1B7 for ; Mon, 16 Mar 2015 17:02:51 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BD1F819D for ; Mon, 16 Mar 2015 17:02:51 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2GH2pfm032856 for ; Mon, 16 Mar 2015 17:02:51 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-jail@FreeBSD.org Subject: [Bug 196152] jail_list is not reversed when stopping jails Date: Mon, 16 Mar 2015 17:02:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: matt@tnpi.net X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-jail@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2015 17:02:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196152 --- Comment #2 from matt@tnpi.net --- Testing with patch applied: # service jail start Starting jails: dns mysql clamav spamassassin vpopmail smtp webmail haproxy monitor. # service jail stop Stopping jails: monitor haproxy webmail smtp vpopmail spamassassin clamav mysql dns. Looks great to me. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-jail@FreeBSD.ORG Mon Mar 16 17:15:41 2015 Return-Path: Delivered-To: freebsd-jail@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 56DC7341 for ; Mon, 16 Mar 2015 17:15:41 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3D2A9301 for ; Mon, 16 Mar 2015 17:15:41 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2GHFf6S043702 for ; Mon, 16 Mar 2015 17:15:41 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-jail@FreeBSD.org Subject: [Bug 196152] jail_list is not reversed when stopping jails Date: Mon, 16 Mar 2015 17:15:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: feld@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-jail@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2015 17:15:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196152 Mark Felder changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress --- Comment #3 from Mark Felder --- It might be more appropriate to name the variable $reverse_jail_list to make it a bit clearer, but otherwise glad to see this is functioning as intended. I'll see if I can flag someone down and confirm if this is OK for default behavior, but I can't see why not... -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-jail@FreeBSD.ORG Tue Mar 17 13:27:14 2015 Return-Path: Delivered-To: freebsd-jail@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 20597A42 for ; Tue, 17 Mar 2015 13:27:14 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 05E1CD8A for ; Tue, 17 Mar 2015 13:27:14 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2HDRDKX038738 for ; Tue, 17 Mar 2015 13:27:13 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-jail@FreeBSD.org Subject: [Bug 196152] jail_list is not reversed when stopping jails Date: Tue, 17 Mar 2015 13:27:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: feld@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-jail@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2015 13:27:14 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196152 Mark Felder changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154424|0 |1 is obsolete| | --- Comment #4 from Mark Felder --- Created attachment 154450 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=154450&action=edit all sh(1) method alternate method so we don't have to fork out to awk -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-jail@FreeBSD.ORG Tue Mar 17 16:43:11 2015 Return-Path: Delivered-To: freebsd-jail@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0115EB7C for ; Tue, 17 Mar 2015 16:43:10 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DB014878 for ; Tue, 17 Mar 2015 16:43:10 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2HGhAZt066852 for ; Tue, 17 Mar 2015 16:43:10 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-jail@FreeBSD.org Subject: [Bug 196152] jail_list is not reversed when stopping jails Date: Tue, 17 Mar 2015 16:43:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-jail@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2015 16:43:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196152 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-jail@FreeBSD.ORG Tue Mar 17 16:59:37 2015 Return-Path: Delivered-To: freebsd-jail@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7E1A4EA1 for ; Tue, 17 Mar 2015 16:59:37 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 637A09E8 for ; Tue, 17 Mar 2015 16:59:37 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2HGxbSA080998 for ; Tue, 17 Mar 2015 16:59:37 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-jail@FreeBSD.org Subject: [Bug 196152] jail_list is not reversed when stopping jails Date: Tue, 17 Mar 2015 16:59:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: matt@tnpi.net X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-jail@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2015 16:59:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196152 --- Comment #5 from matt@tnpi.net --- Tested again, and works as well as the last one. Thanks again for working on this. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-jail@FreeBSD.ORG Tue Mar 17 17:44:51 2015 Return-Path: Delivered-To: freebsd-jail@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7A9D4988 for ; Tue, 17 Mar 2015 17:44:51 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 60BEBF59 for ; Tue, 17 Mar 2015 17:44:51 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2HHipiJ061262 for ; Tue, 17 Mar 2015 17:44:51 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-jail@FreeBSD.org Subject: [Bug 196152] jail_list is not reversed when stopping jails Date: Tue, 17 Mar 2015 17:44:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: feld@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-jail@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2015 17:44:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196152 --- Comment #6 from Mark Felder --- Jamie, can you provide some feedback on this small patch to the jail rc.d script ? Thanks! -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-jail@FreeBSD.ORG Tue Mar 17 18:22:55 2015 Return-Path: Delivered-To: freebsd-jail@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 59C3CCE for ; Tue, 17 Mar 2015 18:22:55 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3E6973E5 for ; Tue, 17 Mar 2015 18:22:55 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2HIMs3S068869 for ; Tue, 17 Mar 2015 18:22:54 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-jail@FreeBSD.org Subject: [Bug 196152] jail_list is not reversed when stopping jails Date: Tue, 17 Mar 2015 18:22:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jamie@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-jail@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2015 18:22:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196152 --- Comment #7 from Jamie Gritton --- It does the right thing in its place. I would change the __j loop variable should just be _j though - or if you really want __j add it to the local declaration. I'd also like to see a similar reversal done in the _ALL case. In the usual case (jid not specified) jls will list jails in the order created, so reversing its output is still the right thing to do. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-jail@FreeBSD.ORG Tue Mar 17 20:29:42 2015 Return-Path: Delivered-To: freebsd-jail@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 931B37BC for ; Tue, 17 Mar 2015 20:29:42 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 79135763 for ; Tue, 17 Mar 2015 20:29:42 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2HKTf0Z060990 for ; Tue, 17 Mar 2015 20:29:41 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-jail@FreeBSD.org Subject: [Bug 196152] jail_list is not reversed when stopping jails Date: Tue, 17 Mar 2015 20:29:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: feld@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-jail@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2015 20:29:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196152 --- Comment #8 from Mark Felder --- For posterity, I've opened an issue in Fabricator https://reviews.freebsd.org/D2088 Further discussion on the patch continuing there. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-jail@FreeBSD.ORG Thu Mar 19 20:17:09 2015 Return-Path: Delivered-To: freebsd-jail@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 692E584F for ; Thu, 19 Mar 2015 20:17:09 +0000 (UTC) Received: from smtp.free.de (smtp.free.de [91.204.6.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F1A73143 for ; Thu, 19 Mar 2015 20:17:08 +0000 (UTC) Received: (qmail 62208 invoked from network); 19 Mar 2015 21:16:59 +0100 Received: from smtp.free.de (HELO [192.168.178.21]) (k@free.de@[91.204.4.103]) (envelope-sender ) by smtp.free.de (qmail-ldap-1.03) with AES128-SHA encrypted SMTP for ; 19 Mar 2015 21:16:59 +0100 Message-ID: <550B2EBA.9090205@free.de> Date: Thu, 19 Mar 2015 21:16:58 +0100 From: Kai Gallasch Organization: FREE! User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: freebsd-jail@freebsd.org Subject: Current state of VIMAGE on 10-STABLE? Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8mqnrOST6VRS8xxNoe8sh6IOk5KWffGAk" X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 20:17:09 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8mqnrOST6VRS8xxNoe8sh6IOk5KWffGAk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi. What is the current state of VIMAGE jails on 10-STABLE? I'm asking, because I saw that Craig Rodrigues and others are working on some long known problems with VIMAGE and there were some related patches committed to the tree. When I experimented with VIMAGE jails on 10.1-RELENG a few weeks ago, I got this when I stopped a running VIMAGE jail. Freed UMA keg (udp_inpcb) was not empty (180 items). Lost 18 pages of memory. Freed UMA keg (udpcb) was not empty (1757 items). Lost 7 pages of memory. Freed UMA keg (ripcb) was not empty (150 items). Lost 15 pages of memory. hhook_vnet_uninit: hhook_head type=3D1, id=3D1 cleanup required hhook_vnet_uninit: hhook_head type=3D1, id=3D0 cleanup required Has this already been adressed by recent development? Regards, K. --=20 PGP-KeyID =3D 0x70654D7C4FB1F588 --8mqnrOST6VRS8xxNoe8sh6IOk5KWffGAk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJVCy66AAoJEHBlTXxPsfWIu3kP/R0Orb5hGqs2wb9sMyUy3oaZ vbwLTXmMWy/HJ0iSmfwY9XZPeAAM0ty1TREXz6SPI08P7/zTfPLbd5/wMAarX0K4 lEqpadjj2DbUuLsRKM+C1idpVS0ggxeUdmmp80a2QFx1WG8a5s25NKgSnK0e4JHv hztiqHP5GTdxSPrgy6xbiUdXXujt8BQun2UK72bh8kLfJNGECQKUb8DDhd9yuz+A 50dchXlICzzBaV8mvqkf2nA+wEeW6ewXpccCIfdgwJobcN0C4HZ0iEn3Lnf4EKzi oiFlZ+vFhRRTVeIAfu69/0fQ5INhWwwbrArv+bG8js4/i72tLwW+9Yj+kPjR8s3C H8FyyY965Wbrv/llTZ3sx4aFPDmLfUPYT1Eir8UoJ2VmT4WZWVXgCyHuTt6bT+fg pDIru2RfPCEbFIN5o7M2MxTrDMYHpwIMl8TNMOvY+bxLuazOc0fRhtVzOQWEa73w rBGkb2oTd9/I/AWNa68biYUMRNuvbjJd/Vvsna5NXUy67zpLrtRKfYRThpZR0nzz uPilQaNhr5rFz9o6b4NrK3a3PRpzoUkp7WW5e6HOa/x0CztxWj0Ui+e64DJIjieg Fn7sA6mzOXSxvo1pQ6mOVXaZDyK0hcJJLHrdASEMtenqRpOhUBC/24wY3O4Xxc+L qf5M/fQ3KoGJqhnMgmFL =Dlef -----END PGP SIGNATURE----- --8mqnrOST6VRS8xxNoe8sh6IOk5KWffGAk--