From owner-freebsd-scsi@freebsd.org Sun Nov 29 21:15:32 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65EBCA3C31B for ; Sun, 29 Nov 2015 21:15:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 51E9E13D0 for ; Sun, 29 Nov 2015 21:15:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tATLFWxf008317 for ; Sun, 29 Nov 2015 21:15:32 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-scsi@FreeBSD.org Subject: [Bug 204901] GEOM doesn't see new disk capacity after VMDK resize without a reboot Date: Sun, 29 Nov 2015 21:15:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: pi@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-scsi@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Nov 2015 21:15:32 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204901 Kurt Jaeger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-geom@FreeBSD.org |freebsd-scsi@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-scsi@freebsd.org Mon Nov 30 19:40:24 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 31FD3A3C687 for ; Mon, 30 Nov 2015 19:40:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1527D1A9D for ; Mon, 30 Nov 2015 19:40:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tAUJeNbF040284 for ; Mon, 30 Nov 2015 19:40:23 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-scsi@FreeBSD.org Subject: [Bug 204646] 10.2 iSCSI backed zpool shows imporper warnings about non-native block sizes that 10.1 doesn't show Date: Mon, 30 Nov 2015 19:40:23 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 10.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: mav@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-scsi@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2015 19:40:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204646 Alexander Motin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mav@FreeBSD.org --- Comment #2 from Alexander Motin --- recordsize and volblocksize properties are functionally equal, except that one of them is used for datasets, while another is for zvols. Both of them CTL report to initiator as a physical sector size, since that is smallest item that can be written to disks or read back, exactly as for real physical sectors. So I don't see any problem from CTL side here. The only problem I see is in ZFS on initiator side -- it never sets ashift above 13 (8K), that is reasonable, but it still complains about that as an error, that is pointless. I think ZFS code should be fixed to just ignore any physical block sizes above 8K, as if they would not be reported. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-scsi@freebsd.org Mon Nov 30 21:40:38 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F0FA5A3D444 for ; Mon, 30 Nov 2015 21:40:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DD8CA1483 for ; Mon, 30 Nov 2015 21:40:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tAULecQI087034 for ; Mon, 30 Nov 2015 21:40:38 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-scsi@FreeBSD.org Subject: [Bug 121676] [iscsi] iscontrol do not connect iscsi-target on sparc64 Date: Mon, 30 Nov 2015 21:40:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: sparc64 X-Bugzilla-Version: 7.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mmoll@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-scsi@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2015 21:40:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=121676 Michael Moll changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |mmoll@freebsd.org Status|In Progress |Closed --- Comment #4 from Michael Moll --- Tested the iscsi initiator on a fresh CURRENT against a CTL LUN and everything works as expected now. BTW, it also works for me on armv6hf, which is also non-x86. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-scsi@freebsd.org Tue Dec 1 22:56:12 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D26D3A3E56F for ; Tue, 1 Dec 2015 22:56:12 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B488A19BB for ; Tue, 1 Dec 2015 22:56:12 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [192.168.200.208] (unknown [50.136.155.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 9FA311928D7; Tue, 1 Dec 2015 22:56:10 +0000 (UTC) Subject: Re: ciss(4) HP Smart Array P840 To: Jonathon Reinhart , freebsd-scsi@freebsd.org References: <20151120.084410.74714437.sthaug@nethelp.no> <30640027-5C49-4AC0-9BAF-7E6208F7DD13@yahoo.com> From: Sean Bruno Message-ID: <565E258A.7000907@freebsd.org> Date: Tue, 1 Dec 2015 14:56:10 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2015 22:56:12 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 > ------------------------------------------------------------------------------------------------------------------------------------------------------ > > fcae8e0 Appears to be the winner here, adding JBOD / HBA mode > support. If you're happy with the results, I can totally do the merge back to stable/9 for you. But does that actually help you out here? sean > > I've done my best to apply those patches to TrueOS 9.3.1-STABLE, > and I'm building it now. > > After those commits, the only difference between FreeBSD "master" > and my branch is: > > diff -u freebsd/sys/dev/ciss/ciss.c trueos/sys/dev/ciss/ciss.c --- > freebsd/sys/dev/ciss/ciss.c 2015-11-23 17:53:43.119544620 -0500 +++ > trueos/sys/dev/ciss/ciss.c 2015-11-24 10:51:50.609160463 -0500 @@ > -4388,17 +4388,11 @@ DB_COMMAND(ciss_prt, db_ciss_prt) { struct > ciss_softc *sc; - devclass_t dc; - int maxciss, i; > > - dc = devclass_find("ciss"); - if ( dc == NULL ) { - > printf("%s: can't find devclass!\n", __func__); - return; - > } - maxciss = devclass_get_maxunit(dc); - for (i = 0; i < > maxciss; i++) { - sc = devclass_get_softc(dc, i); + sc = > devclass_get_softc(devclass_find("ciss"), 0); + if (sc == NULL) > { + printf("no ciss controllers\n"); + } else { > ciss_print_adapter(sc); } > > > If anyone, namely Sean, be willing to take a look at my diff, I > would greatly appreciate it: > > https://github.com/trueos/trueos/compare/9.3.1-STABLE...JonathonReinhart:update-ciss-to-latest > > You'll see there is one commit that I made, and that is the one > I'm unsure of. > > Thank you for your time, Jonathon Reinhart > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJWXiVVXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5ksYoH/1kau/Bz3QQNWz4VsNVMsd/h aJdE76TjB8E/+SSYfTOMSx09r05Ld4wOxtLDLvmcyOZX1JXNwhqR/whbtPo8CXI7 yHnQKRcWlNTA22pT42P7vQpPKE2NfBqUyg3YJAhpwak91xPT//bEhipXFWHrimCE RKEVso8U8FcLzBrvGtuPLHKGAO/Q15RO/j3x9cDcVTulKWa23dMrJ/qoX6qu226/ odV63sPRKUDrwW4DJzzLep9Q4bEShy/2z4RuRBpSXHWa9iRqWB8wh3RVO9+tyPVE OfBq6KfZ1y7sSxXTe1ntZqY3P/nXhp0tAy+heEU+sHJSYHWxvmtnKtRC89zamXU= =9uLw -----END PGP SIGNATURE----- From owner-freebsd-scsi@freebsd.org Tue Dec 1 23:14:47 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7589A3E9AD for ; Tue, 1 Dec 2015 23:14:47 +0000 (UTC) (envelope-from jonathon.reinhart@gmail.com) Received: from mail-ig0-x22d.google.com (mail-ig0-x22d.google.com [IPv6:2607:f8b0:4001:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C3661330; Tue, 1 Dec 2015 23:14:47 +0000 (UTC) (envelope-from jonathon.reinhart@gmail.com) Received: by igvg19 with SMTP id g19so105965334igv.1; Tue, 01 Dec 2015 15:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=KElP99VON9/j+v/dc9ENRftUjSpjoz/+jNcAfWVGvOc=; b=u1zXtdYnKJQzIkM9pNDqCtCCtSvxdEB+FoUdEnSO6R5+1NnNs8aH7UknlAV0xZgs2J HsoWNMMftWx2EXnRyf0us6HO4VgI1XfXrAFHtK6ucj/spKnUGs+6Jbvw0I2ei/H7T85W VJ/e9STj9ZSH3CI4PxlpJBrqzMIapXHcRCaPdVxxRW7O9Be3EEDzWGu+zTHc0d+6hOGU dvZWb8EQg6R6CgZbzv1gI4afcoW+ruy4vbkkGqlnejiINTu19Iu/9vZxs76LqNUfOG4l CPnEvMD+c/x9BBEoT5mtLSsBAqXi9s1b/XQp5C9z/XeglM6fcl5qjFqCCBSJnY1T+wQH KUHQ== X-Received: by 10.50.150.9 with SMTP id ue9mr717219igb.40.1449011686780; Tue, 01 Dec 2015 15:14:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.36.10.67 with HTTP; Tue, 1 Dec 2015 15:14:17 -0800 (PST) In-Reply-To: <565E258A.7000907@freebsd.org> References: <20151120.084410.74714437.sthaug@nethelp.no> <30640027-5C49-4AC0-9BAF-7E6208F7DD13@yahoo.com> <565E258A.7000907@freebsd.org> From: Jonathon Reinhart Date: Tue, 1 Dec 2015 18:14:17 -0500 Message-ID: Subject: Re: ciss(4) HP Smart Array P840 To: Sean Bruno Cc: freebsd-scsi@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2015 23:14:47 -0000 On Tue, Dec 1, 2015 at 5:56 PM, Sean Bruno wrote: >> fcae8e0 Appears to be the winner here, adding JBOD / HBA mode >> support. > > If you're happy with the results, I can totally do the merge back to > stable/9 for you. But does that actually help you out here? > > sean I was able to re-build FreeNAS 9.3 with the patches, and see that the disks were assigned da* names. As far as I could tell, the patches worked. However, I was seeing periodic messages from the kernel which repeat every ~minute for all 4 drives installed: ciss0: *** Physical drive failure, Port=1I Box=1 Bay=1 reason=0x43 ciss0: *** Physical drive failure, Port=1I Box=1 Bay=2 reason=0x43 ciss0: *** Physical drive failure, Port=1I Box=1 Bay=3 reason=0x43 ciss0: *** Physical drive failure, Port=1I Box=1 Bay=4 reason=0x43 This appears to be printed from ciss_notify_complete(), and the error message actually comes from the card: /* * If the adapter gave us a text message, print it. */ if (cn->message[0] != 0) ciss_printf(sc, "*** %.80s\n", cn->message); I confirmed (by running strings on the firmware image) that it is indeed the card generating this message. HP tech support would lead one to believe otherwise, but they also asked if FreeBSD was Linux-based, so take that for what it's worth. I was unable to determine what reason=0x43 meant. The only clue I had was that the HP Smart Storage Administrator told me that my 4Kn drives were unsupported and unavailable for configuration. I wouldn't imagine this would matter, considering the card was in HBA mode. Nonetheless, I wasn't about to put a machine in production with "Physical drive failure" messages being spewed, red-herring or not. So I've let this project go for now. If anyone trying to install FreeNAS on an HP server finds this, I'd be willing to help in any way I could. Thanks for the help, Jonathon From owner-freebsd-scsi@freebsd.org Thu Dec 3 19:49:30 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F2916A405E8 for ; Thu, 3 Dec 2015 19:49:30 +0000 (UTC) (envelope-from lidl@pix.net) Received: from hydra.pix.net (hydra.pix.net [IPv6:2001:470:e254::4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.pix.net", Issuer "Pix.Com Technologies, LLC CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B79EA1CFA for ; Thu, 3 Dec 2015 19:49:30 +0000 (UTC) (envelope-from lidl@pix.net) Received: from torb.pix.net (torb.pix.net [192.168.16.32]) (authenticated bits=0) by hydra.pix.net (8.15.2/8.15.2) with ESMTPA id tB3JnRx5086424; Thu, 3 Dec 2015 14:49:27 -0500 (EST) (envelope-from lidl@pix.net) To: freebsd-scsi@freebsd.org From: Kurt Lidl Subject: Adaptec 5805 and SAS disks not attaching Message-ID: <56609CC7.6020005@pix.net> Date: Thu, 3 Dec 2015 14:49:27 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 19:49:31 -0000 I recently got a used server, that has an Adaptec 5805 raid controller in it. I bought a couple of enterprise SAS disks. After sorting out the mounting hardware for the machine, I booted a stock FreeBSD 10.2 memory stick on the machine. However, the disks don't attach as daX devices. I have tried configuring the drives as "JBOD", and get the same results. I have tried configuring the drives with neither a RAID or JBOD on them, so the controller can just pass them through to the OS. (It's my intention to run ZFS on the drives.) root@:~lidl # camcontrol devlist at scbus0 target 6 lun 0 (pass0) at scbus0 target 7 lun 0 (pass1) at scbus9 target 0 lun 0 (pass2,ses0) at scbus10 target 0 lun 0 (da0,pass3) Any ideas or obvious gotchas? The controller attaches like this: aac0: mem 0xfba00000-0xfbbfffff irq 26 at device 0.0 on pci7 aac0: Enabling 64-bit address support aac0: Enable Raw I/O aac0: Enable 64-bit array aac0: New comm. interface enabled aac0: Adaptec 5805, aac driver 2.1.9-1 aacp0 on aac0 aacp1 on aac0 aacp2 on aac0 Thanks for any insight. -Kurt From owner-freebsd-scsi@freebsd.org Fri Dec 4 09:13:32 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A24DA3FBE7 for ; Fri, 4 Dec 2015 09:13:32 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-yk0-x229.google.com (mail-yk0-x229.google.com [IPv6:2607:f8b0:4002:c07::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 34EE91558 for ; Fri, 4 Dec 2015 09:13:32 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: by ykba77 with SMTP id a77so116991942ykb.2 for ; Fri, 04 Dec 2015 01:13:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=KkDFmPafD30SO94KWd4yZg0JRyptK86gzm1oSvEfuOA=; b=HW7yxRzmbxAqapf87IU/oOr8erjzAxw8loOQZynAvoq0RkcFKR8sXYTNbh2mnxokCA 51Fto5ogdpwHNsqv+BtdKTZHwTi6/rOlk2Oib5Q9VhbX8V4ly9oC4O/bYE8844JJknQy eyex8NdwhbGsHL6kqN+cvG1r4pWKj/Tz8c98Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc :content-type; bh=KkDFmPafD30SO94KWd4yZg0JRyptK86gzm1oSvEfuOA=; b=UDVKe5x8rrKSxWvTj5iCZlObX0ZGEMm5QWXV3k5kR42nKwv0mvfTJWsyhS2Dnktv/b rwaJvnHTq98K0yP0TPZGplqKHbfwVfyGLFQDh7ZlK9277g5QBCGz6At4qcdkjsazdAnW Rzi8lqJmaoRG4evLJdJqFvveg1aRXUTtoyrligKu4FWY2tJ0A0ZGkh2AwRG6eE6LWvLE Vp02ID4zMYC147pGczdPwqyUGkdQTzfeVU6nUkHcC+kj/59XeLQXhywujVsBGQZO6yBS 3D+zmjHxX+T5idnovtoY74uGboLddKm5K3cTg0ILEqHQjbI+pyjQllh0jSclQkgI6S/n cpJg== X-Gm-Message-State: ALoCoQngXA+aHOfMP1VAPK7lR7d6UD1LS9n9Qcgp/PpqbK4x1jWtZXjiEI9XhvbXJkZrq50GtJ53 MIME-Version: 1.0 X-Received: by 10.129.49.6 with SMTP id x6mr9984476ywx.59.1449220411449; Fri, 04 Dec 2015 01:13:31 -0800 (PST) Received: by 10.37.13.147 with HTTP; Fri, 4 Dec 2015 01:13:31 -0800 (PST) Date: Fri, 4 Dec 2015 02:13:31 -0700 Message-ID: Subject: Accessing static drive info w/o ATA identify and lockup with camcontrol identify From: Kevin Bowling To: freebsd-scsi@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 09:13:32 -0000 This email is two parts that are somewhat related #1 I have seen two cases where camcontrol identify can lock up a box. On a system I have control over, I can downgrade the LSI firmware on a machine with a SAS1008 and dispatch camcontrol identify to all the disks in a loop. I/O on the system will hang silently in the background fairly quickly, but there is no indication as to how low the freeze is. I'm not sure if it's kernel side or firmware. You wont initially notice it, but then zfs will hang waiting for txgs and the machine is out to lunch. On this box, if I upgrade firmware I don't see the lockup. I got another report where a user is seeing this on AHCI https://github.com/saltstack/salt/issues/28518 with the same cause and effect. This user's lockup raises the spidy senses and makes me want to dig deeper and make sure there isn't a loose end in kernel. #2 This all came about because I want to poll device information like disk model, serial number, speeds, etc. Common use cases would be configuration management systems and inventory databases. Issuing an ATA identify seems a bit much and could trigger unwanted HW errata like above. I'm wondering if it would be better to cache the data on interface change in sysctls or something. The data is static, read only, but we need to account for disk swaps. Regards, Kevin From owner-freebsd-scsi@freebsd.org Fri Dec 4 16:21:27 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CEF2EA41E6B for ; Fri, 4 Dec 2015 16:21:27 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 9D6851F3B for ; Fri, 4 Dec 2015 16:21:27 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id 906B1A41E6A; Fri, 4 Dec 2015 16:21:27 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 761BCA41E69 for ; Fri, 4 Dec 2015 16:21:27 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-pf0-x232.google.com (mail-pf0-x232.google.com [IPv6:2607:f8b0:400e:c00::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 319DF1F1B for ; Fri, 4 Dec 2015 16:21:26 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by pfbg73 with SMTP id g73so28991007pfb.1 for ; Fri, 04 Dec 2015 08:21:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=sender:from:content-type:subject:date:message-id:to:mime-version; bh=NExp5vllJjBmdI5FpCXO7vm6R9t4b0fxx2jYoypcMt4=; b=dVF9Z94fKA0AJpYFq1zWjH7MkYwrV0wmaSUvFuXmHU0P4Bfa/E4EHAdObdcQYSOdkc Np5SrVi6bq/vRBimF45ZDSMmXw5G9RbAaDM6MubdqsjNx/w8kgqNSZaWG0HfrqE7Bh+r gwWxl1IvDGL2m02C2jH1yD82qqQQOq/Hi8p7DzD+6Vx9zK+0qGfIDnTtQ1VJuHPscHbb S63gIAAFZT3hJJQWSMeLLA4cwjkd6cCqPnukx99OvbyeiTOU9Klyi+BOVig0Trbfw8sF YW5zrqfxod+GiX7hYgmuRZ4OKRZtEgqfNs1ptvwa6vBFIGMROTzJeZbRe+hNpk/6LwxI Gjig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:content-type:subject:date:message-id :to:mime-version; bh=NExp5vllJjBmdI5FpCXO7vm6R9t4b0fxx2jYoypcMt4=; b=g7J7J84ZQzrtKb1v3Dk2ZrxpJTbjaNqqDc+GMKHoZzojVNxkn5hF0mZBa8F8vEm7si ZdOh8ssTSX7kFJIcbCT/XgpGBLenE//cW5SAJhb/MZXJXLhA3WZ1chyCtMgjSacYtbRf 38ritquWL2OpwWGYitOHgwTnrB0qDrzWJjcoKPtZhEDiSFqCRUTiZV1qwb4k02/cTM3X 6Qh5w/mpNqWLkarX0wHS0QQuKs9KWQR7Uf2QmUlI+yumDtpKN901HKmxNYD9SQQfH3Tg va8e6Lp0EzttOPrGZkA8PuIkZPRf/D2zZSM2Opq1kwqQZxOsl+AIOgUMi+0JLWzDv8U3 FBLg== X-Gm-Message-State: ALoCoQmnpF0Qb25UUVfDAlQtTp04kf8Khc9aqeSy3oEAKzApdxWfVFd/kfe1XXoV9iP/pTzEh7du X-Received: by 10.98.14.26 with SMTP id w26mr22585971pfi.110.1449246086159; Fri, 04 Dec 2015 08:21:26 -0800 (PST) Received: from [100.127.145.191] ([69.53.245.39]) by smtp.gmail.com with ESMTPSA id wo3sm18140826pab.25.2015.12.04.08.21.24 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Dec 2015 08:21:24 -0800 (PST) Sender: Warner Losh From: Warner Losh X-Pgp-Agent: GPGMail 2.5.2 Content-Type: multipart/signed; boundary="Apple-Mail=_EB265E31-DCE0-4A38-83B6-828455222371"; protocol="application/pgp-signature"; micalg=pgp-sha512 Subject: Retiring xpt_create_path_unlocked Date: Fri, 4 Dec 2015 09:21:21 -0700 Message-Id: To: scsi@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 16:21:28 -0000 --Apple-Mail=_EB265E31-DCE0-4A38-83B6-828455222371 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Nobody in the tree uses xpt_create_path_unlocked. It=E2=80=99s just a = simple wrapper for xpt_create_path anyway. Any objection to removing it? Warner --Apple-Mail=_EB265E31-DCE0-4A38-83B6-828455222371 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWYb2CAAoJEGwc0Sh9sBEA4k4P/iFjaxzYkMlbZSQ9gFz0xxC5 hBQGuiCMWV+glj0M8IUqcnVoU4arkUQjXrHvb8QlKF5pJ55YItoV2FRYHiDadRwH XfAMdI1ABxEz+NxHaH7pI9vVA/DPDkxnPuGx2TdWaCi8pWLI1oHyZvEb+LJAvXGO a7d0thF4ikZwbleKjv6/ckanIZkzrGHoFUiBHrHDPtg+D27GfxnZs4wACMLt3fHW GtjKDI8HzY7vO+rjuCj0UjQkAPyH3+zuKWSi5bKTMLE3csyK2UTJGUit55yZT1Nk vdMXNWLpbS9uvO8mdTiKytNGJvYXpYNX/QJKlwEBcix5wCVbx7tlGfJ5MJOXu2f+ aqU0kB8+ON7HIydPtcm7ZsS6bvYYg4aNxU21r36jgQfGGI3k+F/JqXaIVyGs2jLX xvN3c9ykq946Fw07Db00pkTI4LeEu8jwsxOUbIEtrFbEiqCz6vnwipadGHRt6ypO ohnYaLY4i5m6Pu4dWmP/eLkppuH+7cBGjiLJBQlLzodtejIZ0SvQMQKCrWGSc19I M7vbA2RXbZi19a8qvoDC6DJKybOeC5n8ABBxjsO4TWySGumQcrXzmJgJ2S5/XW/u dSlk1GAbTZf9YfbP91YQRHSC+0k5AOs7cd2DEIytcxPF7N3XxM5lvTwxaU7SoEvi ewCt1ueiQ1I1ksMgsYpl =JR77 -----END PGP SIGNATURE----- --Apple-Mail=_EB265E31-DCE0-4A38-83B6-828455222371-- From owner-freebsd-scsi@freebsd.org Fri Dec 4 16:23:15 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84AEAA41F93 for ; Fri, 4 Dec 2015 16:23:15 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp003.me.com (mr11p00im-asmtp003.me.com [17.110.69.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6C3AF1289 for ; Fri, 4 Dec 2015 16:23:15 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from [192.168.1.4] (c-24-6-178-251.hsd1.ca.comcast.net [24.6.178.251]) by mr11p00im-asmtp003.me.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NYU0026LDIJW420@mr11p00im-asmtp003.me.com> for freebsd-scsi@freebsd.org; Fri, 04 Dec 2015 16:23:09 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-12-04_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=0 kscore.compositescore=1 compositescore=0.9 suspectscore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0 spamscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1510090000 definitions=main-1512040268 User-Agent: Microsoft-MacOutlook/0.0.0.151105 Date: Fri, 04 Dec 2015 08:23:06 -0800 Subject: Re: Accessing static drive info w/o ATA identify and lockup with camcontrol identify From: Ravi Pokala Sender: "Pokala, Ravi" To: "freebsd-scsi@freebsd.org" Message-id: <80BB5907-CC31-4F06-9C70-E6F7834FF28E@panasas.com> Thread-topic: Accessing static drive info w/o ATA identify and lockup with camcontrol identify MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 16:23:15 -0000 >Date: Fri, 4 Dec 2015 02:13:31 -0700 >From: Kevin Bowling >To: freebsd-scsi@freebsd.org >Subject: Accessing static drive info w/o ATA identify and lockup with > camcontrol identify >Message-ID: > >Content-Type: text/plain; charset=UTF-8 > >... > >#2 This all came about because I want to poll device information like disk >model, serial number, speeds, etc. Common use cases would be configuration >management systems and inventory databases. Issuing an ATA identify seems >a bit much and could trigger unwanted HW errata like above. I'm wondering >if it would be better to cache the data on interface change in sysctls or >something. The data is static, read only, but we need to account for disk >swaps. At least some of it is already available via `geom disk list': [daneel:~] rpokala% geom disk list ada5 Geom name: ada5 Providers: 1. Name: ada5 Mediasize: 2000398934016 (1.8T) Sectorsize: 512 Stripesize: 4096 Stripeoffset: 0 Mode: r1w1e1 descr: WDC WD20EFRX-68EUZN0 lunid: 50014ee20b9f7c0f ident: WD-WCC4M1VN0P7L fwsectors: 63 fwheads: 16 GEOM keeps this data in a "struct disk", which is populated during drive attach. You can see that the drive model ("descr") and serial number ("ident") are already listed by GEOM. "struct disk" also already has a rotation-rate field; if that's what you mean by "speeds", it should be trivial for me to add that to the GEOM output as well. If by "speeds", you're talking about the connection's bus speed (i.e. 3/6/12Gbps), then that's probably more complicated. -Ravi (rpokala@) >Regards, >Kevin From owner-freebsd-scsi@freebsd.org Fri Dec 4 17:04:02 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E419A416B9 for ; Fri, 4 Dec 2015 17:04:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D6D251CF2 for ; Fri, 4 Dec 2015 17:04:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id D4500A416B8; Fri, 4 Dec 2015 17:04:01 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9F8AA416B7 for ; Fri, 4 Dec 2015 17:04:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ob0-x234.google.com (mail-ob0-x234.google.com [IPv6:2607:f8b0:4003:c01::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 745CB1CF1 for ; Fri, 4 Dec 2015 17:04:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by obbnk6 with SMTP id nk6so77601152obb.2 for ; Fri, 04 Dec 2015 09:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=sender:from:content-type:subject:date:message-id:to:mime-version; bh=pL60yGTNe5FH8EABZWIcTVMdbehyihnoIf7sEi4Nqow=; b=l1X0lPKdIhRV8UNW0+ijHXtA5SJTISOBpdkqaCcsqat5+ztsokQQ2PGAAcFc+zBEQD Evb4gApSvDmS2uTvxzZ0CaRSVt4zqgUd3WgkF6hAniLy7epCr653pCo4678HXEVCibfD qz1K2nb0H/cP4dr+jRyW61YwjzlqzajAEQJoh3D8Zc1oPUXrv7XJMJkREQRnIWBFT+Lc gZdGbVyJvtRU9WN+PlB/ITGh16v2ANEvYiELMEHI234dAwq4OMqapve1F7ffsHcgvVnu QQztkKoWKa+kTlQdGuYSlWiBDaGPCsGhpACLqn/Gwis4xWC/ZmYA8Xt17md+4W7VXkmf j8Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:content-type:subject:date:message-id :to:mime-version; bh=pL60yGTNe5FH8EABZWIcTVMdbehyihnoIf7sEi4Nqow=; b=V/BymUw9FSWRDEhEtc3T9BIbGvGrx3LtRdxxhiX728ItExArYBbbdFol2ZmP5xA8iy Hv9VN3A4S3emWBoEm8RF31b8weAZtkVqrtUfytjMOxXgQOnivQCrOf9rq/zutFnXuinI 2Tt/4KE+xzv6xj3DzoyjAgGVCt4krGGFNhufDeR3GTNa2DZlN5UMKvqQeHKRmOynL5K1 zfoInqtCWJ9Oj4TQ62IOLI0gsepMfm90E2akwu8TyUTCiYtSoYbWteIykATzYV0h/q7M whrNuEUorLWb6dklsiLnYW6YaZKekl1NUicPk+yktFU+c8YDzBT8PY8nQcvYJ7EmTCit +SBg== X-Gm-Message-State: ALoCoQnupHqxkT4eJVLYFhhcubLaF/htVPdnezD2tY3El0Ygq+7zThXND8v10ZlEoPXw/6ZjBliI X-Received: by 10.182.28.4 with SMTP id x4mr10019521obg.13.1449248640351; Fri, 04 Dec 2015 09:04:00 -0800 (PST) Received: from ?IPv6:2601:280:4900:3700:4939:59c6:c70c:980e? ([2601:280:4900:3700:4939:59c6:c70c:980e]) by smtp.gmail.com with ESMTPSA id j131sm6174925oib.0.2015.12.04.09.03.59 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Dec 2015 09:03:59 -0800 (PST) Sender: Warner Losh From: Warner Losh X-Pgp-Agent: GPGMail 2.5.2 Content-Type: multipart/signed; boundary="Apple-Mail=_7EA0CD9A-0EC4-4974-B5EA-9E0713E99790"; protocol="application/pgp-signature"; micalg=pgp-sha512 Subject: Minor improvement in debugging Date: Fri, 4 Dec 2015 10:03:58 -0700 Message-Id: To: scsi@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 17:04:02 -0000 --Apple-Mail=_7EA0CD9A-0EC4-4974-B5EA-9E0713E99790 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 While writing the NVMe CAM attachment, I noticed that the xpt_action() routine=E2=80=99s logging would be a lot more useful if we logged the = function code. In addition, it is useful to log calls to the SIM inside of xpt_action_default(). Some sims have debugs, others don=E2=80=99t. This review fixes that. https://reviews.freebsd.org/D4382 Warner P.S. I=E2=80=99ll be sending out a bunch of review pointers to this = list. If there=E2=80=99s a more-preferred way to do this, please let me know. --Apple-Mail=_7EA0CD9A-0EC4-4974-B5EA-9E0713E99790 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWYcd/AAoJEGwc0Sh9sBEAwjQP/iITi2x1+0kqtMQ1s5QR52VT ZlfdHgWXWtZx9nfx+xmOvLc+KQpWctjk17qCng2ZvydMqLgbdk/Xs9HAbRVtW/wD iK2DF1c8OjJgZ4+QZklQmAwAomxPr2XSTEynGEARiEUv+AAtWAOxRUwWGqkLmCzH 8dTOEmumTxcSgYX8S8liuUr5XeiJtd7DS+x7ApZJPVGkgykdqvMZ0vZP0dNJpWOG TYXUFmNXDXlupaka+DEb84sl4dWb3qU25zboq53Q+ZJgMBhtWwwUoy46il6JyzeY TL+iMP4kzOtJEELKBula/cCiGMGlL1+ZziHNFrZbW6fDzUOeHIZTNbOAMAh4p0jF SwhczIK+fIcz7NVb4Jz5deCUDZ2a1SSctjOWNUQJ2BiQe+TWPJoNZvlHagm9Xh7f R3aonUCTONwtsMhecBfKdn5bXM2nRnvuCXMMrVWwNUj6loBBVif0rXnEgpN+bkA7 QNxpOXjdlyql+0wvpDYbQ/hT58iCHpzrSoZPb8Uu19+aptJl+Gpe1CbiXs8lEo2y gTq/XgIhr70q3HN07VbybQAAB0NidS6G88PCXhzqLZ0tOLh34KUqiZGi788hZltN LVichD0EOeihJ38JZPJ2w2w/TVAyVQZTQNsZdhiOwmt/XTywWYaBW1Wo78A0q6bC TWOi5fPVs3moSAFHjym9 =RCfE -----END PGP SIGNATURE----- --Apple-Mail=_7EA0CD9A-0EC4-4974-B5EA-9E0713E99790-- From owner-freebsd-scsi@freebsd.org Fri Dec 4 17:26:58 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6CC9DA41A43 for ; Fri, 4 Dec 2015 17:26:58 +0000 (UTC) (envelope-from dgilbert@interlog.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5398D1958 for ; Fri, 4 Dec 2015 17:26:58 +0000 (UTC) (envelope-from dgilbert@interlog.com) Received: by mailman.ysv.freebsd.org (Postfix) id 50D91A41A42; Fri, 4 Dec 2015 17:26:58 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 506DEA41A41 for ; Fri, 4 Dec 2015 17:26:58 +0000 (UTC) (envelope-from dgilbert@interlog.com) Received: from smtp.infotech.no (smtp.infotech.no [82.134.31.41]) by mx1.freebsd.org (Postfix) with ESMTP id 11FA01957 for ; Fri, 4 Dec 2015 17:26:57 +0000 (UTC) (envelope-from dgilbert@interlog.com) Received: from localhost (localhost [127.0.0.1]) by smtp.infotech.no (Postfix) with ESMTP id 372ED20418E; Fri, 4 Dec 2015 18:18:04 +0100 (CET) X-Virus-Scanned: by amavisd-new-2.6.6 (20110518) (Debian) at infotech.no Received: from smtp.infotech.no ([127.0.0.1]) by localhost (smtp.infotech.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f2Qnmo1jN9hF; Fri, 4 Dec 2015 18:18:02 +0100 (CET) Received: from [192.168.254.24] (unknown [50.107.164.250]) by smtp.infotech.no (Postfix) with ESMTPA id A19A720417C; Fri, 4 Dec 2015 18:18:01 +0100 (CET) Reply-To: dgilbert@interlog.com Subject: Re: Minor improvement in debugging References: To: Warner Losh , scsi@freebsd.org From: Douglas Gilbert Message-ID: <5661CAC5.9080603@interlog.com> Date: Fri, 4 Dec 2015 12:17:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 17:26:58 -0000 On 15-12-04 12:03 PM, Warner Losh wrote: > While writing the NVMe CAM attachment, I noticed that the xpt_action() > routine’s logging would be a lot more useful if we logged the function > code. In addition, it is useful to log calls to the SIM inside of > xpt_action_default(). Some sims have debugs, others don’t. > > This review fixes that. https://reviews.freebsd.org/D4382 Hi, Had a quick look at your patch. If you are naming the containing function in a printf style call then you could do this: printf("%s: \n", __func__ ); That is a little less reabable but more robust, for example if someone later renames the containing function. This assumes compliance with C99 (when __func__ was introduced) or later. Doug Gilbert From owner-freebsd-scsi@freebsd.org Fri Dec 4 17:27:12 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8FD4DA41A73 for ; Fri, 4 Dec 2015 17:27:12 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 624F5198D for ; Fri, 4 Dec 2015 17:27:12 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id 6172BA41A72; Fri, 4 Dec 2015 17:27:12 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61121A41A71 for ; Fri, 4 Dec 2015 17:27:12 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-oi0-x22b.google.com (mail-oi0-x22b.google.com [IPv6:2607:f8b0:4003:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 19744198C for ; Fri, 4 Dec 2015 17:27:12 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by oige206 with SMTP id e206so70651029oig.2 for ; Fri, 04 Dec 2015 09:27:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=ow9007m6X/AbJrU13ZUfgfmYZ99/P1jcFdCc9MAH/9U=; b=piIWfJs6TdDYtAi+EI/hC1LcBCVZdO6XedwdUzcj2qhyBcRoRqlWepHJObxEnpOuWb Agxy5GOgzrsG4SZjBbzrwkDbIHjSYuRp+HpWYJpJVAK9x/EzTVygzvMlTh6ySlN7XgJ8 PWS5vFyOLg9rzohY0VgEUOVg7fZgb3aqTmehhA8uVlX2VylSEJ9oO4F+a5ts9xxf2rcL VdDTfJCv5elHxWa1q2/Ehxjh+gih8Wv1RTgUo3WMHmjahdEEEfaWTviY35on+Wiccfaf bedEcOcWRpstKRnbbkCNMuPWRzztQ0Gu4eNNm2cE4yAOXfozWieo1Rty+8LTjqCngPvC Bxjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=ow9007m6X/AbJrU13ZUfgfmYZ99/P1jcFdCc9MAH/9U=; b=I3u/uM1LOXgc7pf6K2XRGeJkCs3bKmULY9BExqBaps4JvEz7fePJ91diGDp33e7Z9e XNb/oCVn95JgFzNENDyM7zsnZEAvKx1NBDhok9MGciFT6PHa5lFvdZcH3SwsoIL/20VO 8L/F5nJwOXBD9r1IeVCttRzibIeR+kEERGQ7ozadqrzBlbhsYAv1/cTXknDLBijbghsV WqvBdIR/IQdXW3m9MtEz5+j+GdFxpoV8vxQTcsDRDVjgLHAgNWRC7ii1wB9QDo6lFV21 FS6wZTYVqQYgZ9zxCqfFCTq8Px7PedeQNGWhrJ7vh8uFDjLFo5RS2Yz5gPKwwEKsCZSK KVrQ== X-Gm-Message-State: ALoCoQlC78RFpFMLFXeRxYvwHP5GP33VzHINPihVPtmlKYVsRgNjTjAZs0cLR2heRiLtU1+ANBQr X-Received: by 10.202.71.132 with SMTP id u126mr13078549oia.113.1449250031185; Fri, 04 Dec 2015 09:27:11 -0800 (PST) Received: from ?IPv6:2601:280:4900:3700:4939:59c6:c70c:980e? ([2601:280:4900:3700:4939:59c6:c70c:980e]) by smtp.gmail.com with ESMTPSA id y9sm6180292obg.4.2015.12.04.09.27.10 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Dec 2015 09:27:10 -0800 (PST) Sender: Warner Losh Subject: Re: Minor improvement in debugging Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Content-Type: multipart/signed; boundary="Apple-Mail=_67E0377A-C2C0-4D03-90FB-1AE81E999176"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5.2 From: Warner Losh In-Reply-To: <5661CAC5.9080603@interlog.com> Date: Fri, 4 Dec 2015 10:27:09 -0700 Cc: scsi@freebsd.org Message-Id: <7AEAED43-1EC8-42C0-9AAD-BE31AEE258CA@bsdimp.com> References: <5661CAC5.9080603@interlog.com> To: dgilbert@interlog.com X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 17:27:12 -0000 --Apple-Mail=_67E0377A-C2C0-4D03-90FB-1AE81E999176 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Dec 4, 2015, at 10:17 AM, Douglas Gilbert = wrote: >=20 > On 15-12-04 12:03 PM, Warner Losh wrote: >> While writing the NVMe CAM attachment, I noticed that the = xpt_action() >> routine=E2=80=99s logging would be a lot more useful if we logged the = function >> code. In addition, it is useful to log calls to the SIM inside of >> xpt_action_default(). Some sims have debugs, others don=E2=80=99t. >>=20 >> This review fixes that. https://reviews.freebsd.org/D4382 >=20 > Hi, > Had a quick look at your patch. If you are naming the containing > function in a printf style call then you could do this: > printf("%s: \n", __func__ ); >=20 > That is a little less reabable but more robust, for example if someone > later renames the containing function. >=20 > This assumes compliance with C99 (when __func__ was introduced) or = later. The CAM debug doesn=E2=80=99t do that anywhere, so I=E2=80=99m not going = to introduce it piecemeal. But it is a great general suggestion. Warner --Apple-Mail=_67E0377A-C2C0-4D03-90FB-1AE81E999176 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWYczuAAoJEGwc0Sh9sBEAwAEP/03pM01AiCQRpH/Jnyxyk3rA DCjBNkJ6wnanPVsfU+efdgcUx+qkOrr4UhIrHr0FuTiQZObq6VRI3TMJhP3uLJlM YptN+cqCiDY1YaXgp6KOy3YXNJR2Lpg36TLsUyTtt1YZzP0BjOCFXX0h/OACUhPM VKuQ7UzDBx9SAqAruFCZj1b2oth+RpEu2jodCXZLsjobV5o3eDJDcvXuYMT2MKiJ Lh7VuZAW7b3GHeJDUsHAg8MpfPbFkQjXO3xL4W6iDVEnuK/62YBGU+XH2aumhmjd c/NygNVcC80rzf+W4p1mSNNBSB4l1aTEIArFKu9VXEkJe5YktYb/ORZj80ZVOYvt G1Hu60uidka3UdibcEkgdjjMjckuVsIkJO1/GjG8G2qMAbOS0ZODiLFZAGo+VxQ/ 5aGzYdr8WJMxCtprNUb31NcRArkYVENf0c1k3w9AWaoK/fG/h39if4aoA5/dBLio NuvlXEasg2mMeD31xk6fN2zP2QRFfipn7abFRnjgkrajUziz/fHXNIEDthI/8MDo f7RaX8fABmUmXrdNl3W0wYs1PSzrjjquchFuJstQZIcUGzfTFwcJY3p5Wkuomk2h mH0fRKs5UIa9ZNljdxVnfYKqMC1xDwrGUyKPhrSHhquLhXi4PF+YtvHH1n+nfkMF FNAwW5IclWlt56C0uN/5 =er4T -----END PGP SIGNATURE----- --Apple-Mail=_67E0377A-C2C0-4D03-90FB-1AE81E999176--