From owner-freebsd-sysinstall@FreeBSD.ORG Mon Jun 1 14:17:33 2015 Return-Path: Delivered-To: freebsd-sysinstall@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BC0065DE for ; Mon, 1 Jun 2015 14:17:33 +0000 (UTC) (envelope-from ellisw@panasas.com) Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0080.outbound.protection.outlook.com [207.46.100.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 891FD11B2 for ; Mon, 1 Jun 2015 14:17:33 +0000 (UTC) (envelope-from ellisw@panasas.com) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ellisw@panasas.com; Received: from [172.17.3.251] (63.252.212.99) by DM2PR0801MB667.namprd08.prod.outlook.com (10.242.173.25) with Microsoft SMTP Server (TLS) id 15.1.172.22; Mon, 1 Jun 2015 14:17:30 +0000 Message-ID: <556C6975.2010400@panasas.com> Date: Mon, 1 Jun 2015 10:17:25 -0400 From: "Ellis H. Wilson III" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Subject: Re: RFC: Patches to achieve bsdinstall script without dialogs References: <54EF7B40.2030706@panasas.com> <551172FC.1010508@panasas.com> <55117618.8020308@freebsd.org> <5556264C.7080708@panasas.com> In-Reply-To: <5556264C.7080708@panasas.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [63.252.212.99] X-ClientProxiedBy: DM2PR10CA0032.namprd10.prod.outlook.com (25.160.213.42) To DM2PR0801MB667.namprd08.prod.outlook.com (10.242.173.25) X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(42134001)(42139001); SRVR:DM2PR0801MB667; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(520003)(5005006)(3002001); SRVR:DM2PR0801MB667; BCL:0; PCL:0; RULEID:; SRVR:DM2PR0801MB667; X-Forefront-PRVS: 05947791E4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(6009001)(189002)(51704005)(199003)(164054003)(377454003)(24454002)(479174004)(87976001)(64706001)(59896002)(47776003)(2351001)(86362001)(80316001)(19580395003)(19580405001)(83506001)(92566002)(50986999)(66066001)(33656002)(65806001)(65956001)(93886004)(36756003)(50466002)(64126003)(4001350100001)(4001540100001)(81156007)(23746002)(5890100001)(106356001)(42186005)(105586002)(76176999)(54356999)(122386002)(87266999)(2950100001)(97736004)(101416001)(62966003)(15975445007)(77156002)(1720100001)(65816999)(46102003)(107886002)(450100001)(110136002)(5001860100001)(40100003)(5001830100001)(68736005)(5001960100002)(77096005)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0801MB667; H:[172.17.3.251]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: panasas.com does not designate permitted sender hosts) X-OriginatorOrg: panasas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2015 14:17:30.3322 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0801MB667 X-BeenThere: freebsd-sysinstall@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Sysinstall Work List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2015 14:17:33 -0000 It's been a bit over two weeks since I circulated this. Does anyone have thoughts on the patch? I apologize for the gentle reminder if this was already incorporated, in testing, or otherwise being paid attention to. Thanks, ellis On 05/15/2015 01:01 PM, Ellis H. Wilson III wrote: > On 03/24/2015 10:35 AM, Allan Jude wrote: >> These changes look ok to me. >> >> 2 main things: These would need to be based on HEAD not 10.1 in order to >> be committed > > Nathan, Allan, et. al.: > > Please see attached for a new set of patches based off of HEAD. Sorry > this took some time for me to get back to. Notes follow: > > The following experienced no real changes between 10.1 (which my last > patches were based on) and HEAD, and therefore can be deemed completely > safe: > > usr.sbin/bsdconfig/share/common.subr > usr.sbin/bsdinstall/scripts/checksum > usr.sbin/bsdinstall/scripts/script > > The following experienced changes, but the existing patch went through > without any problems. I visually inspected it afterwards and it looked > perfectly fine: > > usr.sbin/bsdinstall/partedit/scripted.c > > The following experienced minor changes such that the patch failed, but > only needed minor modifications to achieve the same intent: > > usr.sbin/bsdinstall/partedit/partedit.h > usr.sbin/bsdinstall/partedit/partedit.c > > The following was significantly changed from the 10.1 version. Since > the new version used dpv, which makes ASCII output difficult, the > cleanest solution I could identify was to forward port some of the old > logic. There may be a better way to do this, but this is my attempt. I > defer to the original author's best judgement. > > usr.sbin/bsdinstall/distextract/distextract.c > > All of our machines are running 10.1 or older, so I wasn't able to > compile and test the changes above since they lack dpv. I therefore > fired up a VM and made sure they at least compile. Particularly in the > last case (distextract), the patch should be tested before being > committed. I apologize I don't have the resources to do this myself > currently. > > Best, > > ellis > > > _______________________________________________ > freebsd-sysinstall@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall > To unsubscribe, send any mail to "freebsd-sysinstall-unsubscribe@freebsd.org" >