From owner-freebsd-sysinstall@FreeBSD.ORG Wed Jun 10 19:46:15 2015 Return-Path: Delivered-To: freebsd-sysinstall@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E8BED593 for ; Wed, 10 Jun 2015 19:46:15 +0000 (UTC) (envelope-from ellisw@panasas.com) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0097.outbound.protection.outlook.com [65.55.169.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9C57D1BF2 for ; Wed, 10 Jun 2015 19:46:14 +0000 (UTC) (envelope-from ellisw@panasas.com) Authentication-Results: freebsd.org; dkim=none (message not signed) header.d=none; Received: from [172.17.3.251] (63.252.212.99) by DM2PR0801MB666.namprd08.prod.outlook.com (10.242.173.24) with Microsoft SMTP Server (TLS) id 15.1.184.17; Wed, 10 Jun 2015 19:46:05 +0000 Message-ID: <557893F9.8090700@panasas.com> Date: Wed, 10 Jun 2015 15:46:01 -0400 From: "Ellis H. Wilson III" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Subject: Re: RFC: Patches to achieve bsdinstall script without dialogs References: <54EF7B40.2030706@panasas.com> <551172FC.1010508@panasas.com> <55117618.8020308@freebsd.org> <5556264C.7080708@panasas.com> <556C6975.2010400@panasas.com> In-Reply-To: <556C6975.2010400@panasas.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [63.252.212.99] X-ClientProxiedBy: BL2PR01CA0042.prod.exchangelabs.com (10.141.66.42) To DM2PR0801MB666.namprd08.prod.outlook.com (10.242.173.24) X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(42134001)(42139001); SRVR:DM2PR0801MB666; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(520003)(3002001); SRVR:DM2PR0801MB666; BCL:0; PCL:0; RULEID:; SRVR:DM2PR0801MB666; X-Forefront-PRVS: 06036BD506 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(6049001)(6009001)(24454002)(377454003)(479174004)(51704005)(164054003)(54356999)(4001350100001)(19580405001)(15975445007)(65816999)(80316001)(2351001)(19580395003)(23746002)(86362001)(50986999)(42186005)(2950100001)(87976001)(87266999)(64126003)(83506001)(99136001)(76176999)(92566002)(47776003)(110136002)(66066001)(93886004)(65956001)(65806001)(107886002)(5001960100002)(189998001)(33656002)(46102003)(59896002)(50466002)(77156002)(62966003)(450100001)(1720100001)(77096005)(5890100001)(36756003)(122386002)(40100003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0801MB666; H:[172.17.3.251]; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en; X-OriginatorOrg: panasas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2015 19:46:05.7555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0801MB666 X-BeenThere: freebsd-sysinstall@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Sysinstall Work List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2015 19:46:16 -0000 Another 10 days, another bump. I'd love to get the ear of a committer here who would be willing to drive this to completion. Unfortunately I do not have such privileges. Best, ellis On 06/01/2015 10:17 AM, Ellis H. Wilson III wrote: > It's been a bit over two weeks since I circulated this. Does anyone > have thoughts on the patch? I apologize for the gentle reminder if this > was already incorporated, in testing, or otherwise being paid attention to. > > Thanks, > > ellis > > On 05/15/2015 01:01 PM, Ellis H. Wilson III wrote: >> On 03/24/2015 10:35 AM, Allan Jude wrote: >>> These changes look ok to me. >>> >>> 2 main things: These would need to be based on HEAD not 10.1 in order to >>> be committed >> >> Nathan, Allan, et. al.: >> >> Please see attached for a new set of patches based off of HEAD. Sorry >> this took some time for me to get back to. Notes follow: >> >> The following experienced no real changes between 10.1 (which my last >> patches were based on) and HEAD, and therefore can be deemed completely >> safe: >> >> usr.sbin/bsdconfig/share/common.subr >> usr.sbin/bsdinstall/scripts/checksum >> usr.sbin/bsdinstall/scripts/script >> >> The following experienced changes, but the existing patch went through >> without any problems. I visually inspected it afterwards and it looked >> perfectly fine: >> >> usr.sbin/bsdinstall/partedit/scripted.c >> >> The following experienced minor changes such that the patch failed, but >> only needed minor modifications to achieve the same intent: >> >> usr.sbin/bsdinstall/partedit/partedit.h >> usr.sbin/bsdinstall/partedit/partedit.c >> >> The following was significantly changed from the 10.1 version. Since >> the new version used dpv, which makes ASCII output difficult, the >> cleanest solution I could identify was to forward port some of the old >> logic. There may be a better way to do this, but this is my attempt. I >> defer to the original author's best judgement. >> >> usr.sbin/bsdinstall/distextract/distextract.c >> >> All of our machines are running 10.1 or older, so I wasn't able to >> compile and test the changes above since they lack dpv. I therefore >> fired up a VM and made sure they at least compile. Particularly in the >> last case (distextract), the patch should be tested before being >> committed. I apologize I don't have the resources to do this myself >> currently. >> >> Best, >> >> ellis >> >> >> _______________________________________________ >> freebsd-sysinstall@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall >> To unsubscribe, send any mail to >> "freebsd-sysinstall-unsubscribe@freebsd.org" >> > > _______________________________________________ > freebsd-sysinstall@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall > To unsubscribe, send any mail to > "freebsd-sysinstall-unsubscribe@freebsd.org" From owner-freebsd-sysinstall@FreeBSD.ORG Sat Jun 13 03:28:21 2015 Return-Path: Delivered-To: freebsd-sysinstall@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AAD7D51C for ; Sat, 13 Jun 2015 03:28:21 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8998B9E1 for ; Sat, 13 Jun 2015 03:28:21 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (polaris.tachypleus.net [75.101.50.44]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id t5D3GWMh023822 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Fri, 12 Jun 2015 20:16:32 -0700 Message-ID: <557BA090.4070908@freebsd.org> Date: Fri, 12 Jun 2015 20:16:32 -0700 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: freebsd-sysinstall@freebsd.org Subject: Re: RFC: Patches to achieve bsdinstall script without dialogs References: <54EF7B40.2030706@panasas.com> <551172FC.1010508@panasas.com> <55117618.8020308@freebsd.org> <5556264C.7080708@panasas.com> In-Reply-To: <5556264C.7080708@panasas.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Sonic-CAuth: UmFuZG9tSVYQ+pQuAeN3YuOsouv7BvwzheiWcKc5jrJKgH0NVy52AGrfhFLUYPYOfs2/0gCj+CxpwhvWJf1zjqTvSgaOyzwPMajQ+PaabXA= X-Sonic-ID: C;mM0cl3oR5RGU5zDDQUxNRQ== M;oj5ll3oR5RGU5zDDQUxNRQ== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: freebsd-sysinstall@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Sysinstall Work List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2015 03:28:21 -0000 On 05/15/15 10:01, Ellis H. Wilson III wrote: > On 03/24/2015 10:35 AM, Allan Jude wrote: >> These changes look ok to me. >> >> 2 main things: These would need to be based on HEAD not 10.1 in order to >> be committed > > Nathan, Allan, et. al.: > > Please see attached for a new set of patches based off of HEAD. Sorry > this took some time for me to get back to. Notes follow: > > The following experienced no real changes between 10.1 (which my last > patches were based on) and HEAD, and therefore can be deemed > completely safe: > > usr.sbin/bsdconfig/share/common.subr > usr.sbin/bsdinstall/scripts/checksum > usr.sbin/bsdinstall/scripts/script > > The following experienced changes, but the existing patch went through > without any problems. I visually inspected it afterwards and it > looked perfectly fine: > > usr.sbin/bsdinstall/partedit/scripted.c > > The following experienced minor changes such that the patch failed, > but only needed minor modifications to achieve the same intent: > > usr.sbin/bsdinstall/partedit/partedit.h > usr.sbin/bsdinstall/partedit/partedit.c > > The following was significantly changed from the 10.1 version. Since > the new version used dpv, which makes ASCII output difficult, the > cleanest solution I could identify was to forward port some of the old > logic. There may be a better way to do this, but this is my attempt. > I defer to the original author's best judgement. > > usr.sbin/bsdinstall/distextract/distextract.c > > All of our machines are running 10.1 or older, so I wasn't able to > compile and test the changes above since they lack dpv. I therefore > fired up a VM and made sure they at least compile. Particularly in the > last case (distextract), the patch should be tested before being > committed. I apologize I don't have the resources to do this myself > currently. Thanks for this! This is a great feature and I'll take care of shepherding it into the tree. A few comments: 1. Could you change the variable for turning this on to something other than BSDINSTALL_SCRIPTED? There are cases where you might want a scripted install, but also dialogs. I'm thinking in particular of PXE installing a bunch of identical machines with humans sitting in front of them. There are a couple of similar issues in the partition editor, where "scripted" is assumed to mean "no dialogs ever". 2. Some of the C code has whitespace issues. See the extract_files() vs. extract_files_scripted() prototypes. Could you fix these? 3. The libdpv business you mention is unfortunate, though I don't see a better way. Devin, do you have any comments about this? Is libdpv necessary in all of these cases? Is there a better way to do it? 4. If you are familiar with man pages, it would be great if you could add some description of this to the bsdinstall man page. If you aren't, I can take care of it. 5. Could you send me both your 10-STABLE patches and -HEAD patches? It would help me with merging this into 10 for the 10.2 release to have both. Thanks again, and apologies your patches sat on the mailing list for so long. -Nathan