From owner-freebsd-testing@freebsd.org Sun Oct 18 01:50:11 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CA005A1085B for ; Sun, 18 Oct 2015 01:50:11 +0000 (UTC) (envelope-from jmmv@meroh.net) Received: from mail-qg0-f42.google.com (mail-qg0-f42.google.com [209.85.192.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 82E4119A for ; Sun, 18 Oct 2015 01:50:10 +0000 (UTC) (envelope-from jmmv@meroh.net) Received: by qgbb65 with SMTP id b65so26036039qgb.2 for ; Sat, 17 Oct 2015 18:50:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=mWx+wyPglLT8/5v+KLhUVFOioKGiYQG+Gc8EAs6/plc=; b=PfwvXSWnzvTnhK0ptSAgLPacDnVd8TtoLsOhUZm+UY389PkoHw7IZ05e8/pm9qvHsz O94i4/nY44Vrko5EJdKKGGuSpzuDDosxVdme8VFkIDy89GJiRUCUsNNvcd0n+p3IrDwf 2D4tzihkXMmvqYwYXXsx3SEq+XJSU/962Uq2PYzqtCO3sAnnLe6dgaDnhB+b/iHWr2N+ ZUVkmXz6DQ9sbj8kuM5SW055LeHP7zb3TzZqZ9dCUriN4LWK/Zh0BGYZAk1mccP/GJbJ O8ZytdcZHeRsYOLu3m30G2tfwlh6Q2hEGXV8vFiBp8SsGV8amEUFz5CkgMZVuaZjlR4t bKJA== X-Gm-Message-State: ALoCoQkUiA2aR6d4Xu/i6Be0qGc+Yn5IXZ/i79VxRXDuXZzAaVsgTR6BdlXpNYjkesSJuaFLeFeE X-Received: by 10.140.43.183 with SMTP id e52mr20577545qga.38.1445133009112; Sat, 17 Oct 2015 18:50:09 -0700 (PDT) Received: from ?IPv6:2604:2000:c667:7600:4815:f07:b75a:45a7? ([2604:2000:c667:7600:4815:f07:b75a:45a7]) by smtp.gmail.com with ESMTPSA id f31sm11328065qkh.24.2015.10.17.18.50.08 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 17 Oct 2015 18:50:08 -0700 (PDT) Sender: Julio Merino Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.0 \(3094\)) Subject: Re: [RFC] Rename `make test` in suite.test.mk with `make regress` From: Julio Merino In-Reply-To: Date: Sat, 17 Oct 2015 21:50:02 -0400 Cc: "freebsd-testing@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <5C39F495-5717-450F-8460-14B69DD48AD6@freebsd.org> References: To: NGie Cooper X-Mailer: Apple Mail (2.3094) X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Oct 2015 01:50:11 -0000 On Oct 17, 2015, at 18:03, NGie Cooper wrote: >=20 > Hi all, > There=E2=80=99s a lesser known target in suite.test.mk that runs = `kyua test` in a similar manner to how Jenkins and other groups have = integrated kyua into their test infrastructures. > The legacy target on FreeBSD was `regress`, but the target = created with the bsd.test.mk creation back a few years ago was `test`. = Why change from `test` to `regress`? There are places in the tree = (bin/test for example) that have targets named test, so in order to = avoid clashing with a common target (name), it=E2=80=99s best to use the = legacy target name. > Would anyone have any serious heartburn over the change? Is this only because of bin/test? Seems like renaming a target to avoid = that one collision is just moving the problem around. It is possible = that some other directory could later grow a target that conflicts with = your new name. Strictly speaking, "regress" is wrong. We do not have regression tests = only. Also, "regress" is a pretty obscure name for a target; it does = not appear in any other projects nor in any other build systems that I = know of. Have you considered "check"? That'd be in line with what automake does, = for example, which would homogenize the target name with a ton of other = projects out there.=