From owner-freebsd-toolchain@FreeBSD.ORG Tue Feb 10 20:50:29 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AB19BF7D for ; Tue, 10 Feb 2015 20:50:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8D74A68D for ; Tue, 10 Feb 2015 20:50:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1AKoTXX093476 for ; Tue, 10 Feb 2015 20:50:29 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1AKoTuV093475; Tue, 10 Feb 2015 20:50:29 GMT (envelope-from root) Date: Tue, 10 Feb 2015 20:50:29 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Request, 55 lines] D1819: libdwarf: Handle .rel relocations Message-ID: X-Priority: 3 Thread-Topic: D1819: libdwarf: Handle .rel relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Thread-Index: OTU0ZGZmMDVmZDkwODkyYzExMzg2N2RjMDgy X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 20:50:29 -0000 emaste created this revision. emaste added a reviewer: gnn. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY Some architectures have .rel relocations for debug data, so handle it in addition to .rela. Issue discovered from ctfconvert on un-linked ARM object files. REVISION DETAIL https://reviews.freebsd.org/D1819 AFFECTED FILES libdwarf/_libdwarf.h libdwarf/dwarf_reloc.c libdwarf/dwarf_set_reloc_application.3 libdwarf/libdwarf.c libdwarf/libdwarf_elf_init.c To: emaste, gnn Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 02:32:40 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 894AC548 for ; Wed, 11 Feb 2015 02:32:40 +0000 (UTC) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47A8EF13 for ; Wed, 11 Feb 2015 02:32:40 +0000 (UTC) Received: from localhost (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id D4E4628111F for ; Wed, 11 Feb 2015 12:32:30 +1000 (EST) X-Amavis-Modified: Mail body modified (using disclaimer) - iredmail.onthenet.com.au X-Virus-Scanned: amavisd-new at iredmail.onthenet.com.au Received: from iredmail.onthenet.com.au ([127.0.0.1]) by localhost (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5625e9WW_yU5 for ; Wed, 11 Feb 2015 12:32:30 +1000 (EST) Received: from Peters-MacBook-Pro.local (unknown [64.245.0.210]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id 11F9328111C; Wed, 11 Feb 2015 12:32:28 +1000 (EST) Message-ID: <54DABF3A.8060003@freebsd.org> Date: Tue, 10 Feb 2015 18:32:26 -0800 From: Peter Grehan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: freebsd-toolchain@freebsd.org Subject: Resurrecting clang external toolchain support in Makefile.inc Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 02:32:40 -0000 Hi toolchain folk, I've recently tried using the base system clang as an external toolchain i.e. make CROSS_COMPILER_PREFIX=/usr/bin/ buildworld .. and found that this no longer works after r273755 which split XFLAGS into XC/XCXXFLAGS. This appears to be because the XFLAGS definitions that define --sysroot and -B options aren't being passed through to clang, resulting in using header files from the host system. My quick hack was --- Makefile.inc1 (revision 278542) +++ Makefile.inc1 (working copy) @@ -374,6 +374,8 @@ TARGET_ABI?= unknown TARGET_TRIPLE?= ${TARGET_ARCH:C/amd64/x86_64/}-${TARGET_ABI}-freebsd11.0 XCFLAGS+= -target ${TARGET_TRIPLE} +XCFLAGS+= ${XFLAGS} +XCXXFLAGS+= ${XFLAGS} .endif .endif However, this doesn't look to be the right way to fix this. Any opinions on a proper fix ? later, Peter. From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 02:51:08 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3C1FD936 for ; Wed, 11 Feb 2015 02:51:08 +0000 (UTC) Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0DBA4141 for ; Wed, 11 Feb 2015 02:51:07 +0000 (UTC) Received: by mail-pa0-f49.google.com with SMTP id fb1so1110726pad.8 for ; Tue, 10 Feb 2015 18:51:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=BL6KCaoIJwa5l/TIIQa3bEtQ6fKSzu/lWxbYmATXxDY=; b=epfRrOapU48aeBYHxbp61ajMB9tNmgJAj5W/daVRFRnKCJv1clm9lh/A0hKkF5tnUd f+ZvF4Mc6cyEJ79m/rc1F70/BRGhStNKhx0APu/AjPdb7Ewig8oJNsH20L3ekg4BuB6S HkUWUMuQ+oFLuf2ltU0Cg7plVieEyxPBy/5y6VV5rIl5J7FQ6S2nTqxLdKP9frnUwfUq W7nACFH5qfhj2JfQWihJhJD6Kk6kVmmvW2zSf5oOYC3z8VUUG+wG6aA8dwqthgl2wJ5p Nfq7R35HyuAn6BC9v+AY+FP0PXvhewEs98/zLAuHbKSJJuzDg+Chhaq6EFbUgDj6qSKq pC9w== X-Gm-Message-State: ALoCoQnI1LYo1vtJ6hF9Y/5FgjPUylShfMpnKPMccHVa0xkUk17lrLqBJlK43AIc3dRlYfleoRfN X-Received: by 10.70.25.4 with SMTP id y4mr26339915pdf.5.1423623061099; Tue, 10 Feb 2015 18:51:01 -0800 (PST) Received: from netflix-mac-wired.bsdimp.com ([50.253.99.174]) by mx.google.com with ESMTPSA id y2sm20716240pdm.31.2015.02.10.18.51.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Feb 2015 18:51:00 -0800 (PST) Sender: Warner Losh Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: Resurrecting clang external toolchain support in Makefile.inc From: Warner Losh In-Reply-To: <54DABF3A.8060003@freebsd.org> Date: Tue, 10 Feb 2015 19:50:59 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <54DABF3A.8060003@freebsd.org> To: Peter Grehan X-Mailer: Apple Mail (2.2070.6) Cc: freebsd-toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 02:51:08 -0000 > On Feb 10, 2015, at 7:32 PM, Peter Grehan wrote: >=20 > Hi toolchain folk, >=20 > I've recently tried using the base system clang as an external = toolchain i.e. >=20 > make CROSS_COMPILER_PREFIX=3D/usr/bin/ buildworld >=20 > .. and found that this no longer works after r273755 which split = XFLAGS into XC/XCXXFLAGS. This appears to be because the XFLAGS = definitions that define --sysroot and -B options aren't being passed = through to clang, resulting in using header files from the host system. >=20 > My quick hack was >=20 > --- Makefile.inc1 (revision 278542) > +++ Makefile.inc1 (working copy) > @@ -374,6 +374,8 @@ > TARGET_ABI?=3D unknown > TARGET_TRIPLE?=3D = ${TARGET_ARCH:C/amd64/x86_64/}-${TARGET_ABI}-freebsd11.0 > XCFLAGS+=3D -target ${TARGET_TRIPLE} > +XCFLAGS+=3D ${XFLAGS} > +XCXXFLAGS+=3D ${XFLAGS} > .endif > .endif >=20 > However, this doesn't look to be the right way to fix this. >=20 > Any opinions on a proper fix ? I have a similar =E2=80=9Cfix=E2=80=9D in my tree as well, but hadn=E2=80=99= t pushed it because I wasn=E2=80=99t quite sure the right way either. Warner= From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 08:45:39 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4508B8F9; Wed, 11 Feb 2015 08:45:39 +0000 (UTC) Received: from mail-we0-x22b.google.com (mail-we0-x22b.google.com [IPv6:2a00:1450:400c:c03::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C3767D8B; Wed, 11 Feb 2015 08:45:38 +0000 (UTC) Received: by mail-we0-f171.google.com with SMTP id p10so1935720wes.2; Wed, 11 Feb 2015 00:45:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=hTraqvvCl6gQCKGjvErI+M9pziSmzchdT/oJk4oAzoA=; b=BkuPMnjCh6T27qlJad3GpiI1cgQgWlczp2HMDybiFMYbhO3q+W7QL3MfDySkf1xBXF GXlM9v0X3Mt5Nzqt6x7gVnGboLS6y+uWWhK17BuV3svenGckizWhxHNzMch17Wwe6y0t flseT0x4COBxrvP/1xhizeV73OCnyODvSeWH5CvEyoCdT9sCc/eZicb1U9v4hZWFlwlM kZ3UhJARJlOsZ7QT+nsay9p0vCvvJdhHJC9Zpi0dlWIa4DHw9OreFzn18FrdjW7CTQE8 izY8O+SjwcmYr3oDga2eW4Zczv/ZvUYrPOJwhDo3Y8agOhcf8divOfsyZ2aWRZTDHqp7 WhMw== X-Received: by 10.194.133.68 with SMTP id pa4mr1745532wjb.26.1423644337215; Wed, 11 Feb 2015 00:45:37 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id pr9sm307760wjc.4.2015.02.11.00.45.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Feb 2015 00:45:36 -0800 (PST) Sender: Baptiste Daroussin Date: Wed, 11 Feb 2015 09:45:34 +0100 From: Baptiste Daroussin To: Warner Losh Subject: Re: Resurrecting clang external toolchain support in Makefile.inc Message-ID: <20150211084534.GY29891@ivaldir.etoilebsd.net> References: <54DABF3A.8060003@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RUh7Gb6wQL2PrpWP" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-toolchain@freebsd.org, Peter Grehan X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 08:45:39 -0000 --RUh7Gb6wQL2PrpWP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 10, 2015 at 07:50:59PM -0700, Warner Losh wrote: >=20 > > On Feb 10, 2015, at 7:32 PM, Peter Grehan wrote: > >=20 > > Hi toolchain folk, > >=20 > > I've recently tried using the base system clang as an external toolchai= n i.e. > >=20 > > make CROSS_COMPILER_PREFIX=3D/usr/bin/ buildworld > >=20 > > .. and found that this no longer works after r273755 which split XFLAGS= into XC/XCXXFLAGS. This appears to be because the XFLAGS definitions that = define --sysroot and -B options aren't being passed through to clang, resul= ting in using header files from the host system. > >=20 > > My quick hack was > >=20 > > --- Makefile.inc1 (revision 278542) > > +++ Makefile.inc1 (working copy) > > @@ -374,6 +374,8 @@ > > TARGET_ABI?=3D unknown > > TARGET_TRIPLE?=3D ${TARGET_ARCH:C/amd64/x86_64/}-${TARGET_ABI}-freebsd1= 1.0 > > XCFLAGS+=3D -target ${TARGET_TRIPLE} > > +XCFLAGS+=3D ${XFLAGS} > > +XCXXFLAGS+=3D ${XFLAGS} > > .endif > > .endif > >=20 > > However, this doesn't look to be the right way to fix this. > >=20 > > Any opinions on a proper fix ? >=20 > I have a similar =E2=80=9Cfix=E2=80=9D in my tree as well, but hadn=E2=80= =99t pushed it because I wasn=E2=80=99t quite sure the right way either. >=20 > Warner In my opinion we should track down the last traces of XFLAGS and turn them = into proper XCFLAGS and XCXXFLAGS, the intent was to get rid of XFLAGS because t= he name was confusing. so instead of adding XFLAGS to XC*FLAGS, the XFLAGS should juste be convert= ed into XC*FLAGS directly in my opinion. Best regards, Bapt --RUh7Gb6wQL2PrpWP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlTbFq4ACgkQ8kTtMUmk6EzdRACglKn6YCo/ZgkPcZtpUXRgSxKY vYAAn25LVYF5dxRf/b6slUUXOTXIr5Ju =O1TQ -----END PGP SIGNATURE----- --RUh7Gb6wQL2PrpWP-- From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 19:03:47 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0E4A183C for ; Wed, 11 Feb 2015 19:03:47 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E5826BE9 for ; Wed, 11 Feb 2015 19:03:46 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BJ3kCY024201 for ; Wed, 11 Feb 2015 19:03:46 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BJ3kFm024200; Wed, 11 Feb 2015 19:03:46 GMT (envelope-from root) Date: Wed, 11 Feb 2015 19:03:46 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Request, 6 lines] D1826: libdwarf: Add symbol value when processing .rela relocations Message-ID: X-Priority: 3 Thread-Topic: D1826: libdwarf: Add symbol value when processing .rela relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-Cc: Thread-Index: ZjAwMzYxOWQ0Y2NkNDBkZjQ5NmIzZDI0ODQx X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 19:03:47 -0000 emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY In practice .rela debug relocations often use the the .debug_* sections as the symbol, which has the value 0: ``` Relocation section '.rela.debug_info' at offset 0xd18 contains 205 entries: Offset Info Type Sym. Value Sym. Name + Addend 000000000006 001a0000000a R_X86_64_32 0000000000000000 .debug_abbrev + 0 00000000000c 001e0000000a R_X86_64_32 0000000000000000 .debug_str + 0 000000000012 001e0000000a R_X86_64_32 0000000000000000 .debug_str + 45 ``` so in those cases there is no difference if the symbol value is used in the relocation or not. It is not always the case though: ``` 000000000039 002700000001 R_X86_64_64 0000000000000010 xen_pci_driver + 0 ``` REVISION DETAIL https://reviews.freebsd.org/D1826 AFFECTED FILES libdwarf/libdwarf_elf_init.c To: emaste Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 19:04:42 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DA027868 for ; Wed, 11 Feb 2015 19:04:42 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BB97ABF2 for ; Wed, 11 Feb 2015 19:04:42 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BJ4gs9024911 for ; Wed, 11 Feb 2015 19:04:42 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BJ4gAt024910; Wed, 11 Feb 2015 19:04:42 GMT (envelope-from root) Date: Wed, 11 Feb 2015 19:04:42 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Commented On] D1826: libdwarf: Add symbol value when processing .rela relocations Message-ID: X-Priority: 3 Thread-Topic: D1826: libdwarf: Add symbol value when processing .rela relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZjAwMzYxOWQ0Y2NkNDBkZjQ5NmIzZDI0ODQxIFTbp8o= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 19:04:42 -0000 emaste added a comment. See also D1819 REVISION DETAIL https://reviews.freebsd.org/D1826 To: emaste Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 19:05:49 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 565538C1 for ; Wed, 11 Feb 2015 19:05:49 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 31158C06 for ; Wed, 11 Feb 2015 19:05:49 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BJ5mfe025890 for ; Wed, 11 Feb 2015 19:05:48 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BJ5mOD025889; Wed, 11 Feb 2015 19:05:48 GMT (envelope-from root) Date: Wed, 11 Feb 2015 19:05:48 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Updated] D1826: libdwarf: Add symbol value when processing .rela relocations Message-ID: <7007041315a1aab295ce2da662e5894a@localhost.localdomain> X-Priority: 3 Thread-Topic: D1826: libdwarf: Add symbol value when processing .rela relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZjAwMzYxOWQ0Y2NkNDBkZjQ5NmIzZDI0ODQxIFTbqAw= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 19:05:49 -0000 emaste added reviewers: kostikbel, rpaulo. REVISION DETAIL https://reviews.freebsd.org/D1826 To: emaste, kostikbel, rpaulo Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 19:18:46 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D7EF4E2B for ; Wed, 11 Feb 2015 19:18:46 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B7FD5D36 for ; Wed, 11 Feb 2015 19:18:46 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BJIkGF038797 for ; Wed, 11 Feb 2015 19:18:46 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BJIkvg038796; Wed, 11 Feb 2015 19:18:46 GMT (envelope-from root) Date: Wed, 11 Feb 2015 19:18:46 +0000 To: freebsd-toolchain@freebsd.org From: "kostikbel (Konstantin Belousov)" Subject: [Differential] [Accepted] D1826: libdwarf: Add symbol value when processing .rela relocations Message-ID: X-Priority: 3 Thread-Topic: D1826: libdwarf: Add symbol value when processing .rela relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZjAwMzYxOWQ0Y2NkNDBkZjQ5NmIzZDI0ODQxIFTbqxY= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 19:18:46 -0000 kostikbel accepted this revision. kostikbel added a comment. This revision is now accepted and ready to land. It looks fine, but definitely is extremely subtle. The dwarf_get_reloc_size() returns zero for non-abs relocations, so dwarf_write_{m.l}sb() does nothing for other relocation types. This at least deserves explanation in a comment. REVISION DETAIL https://reviews.freebsd.org/D1826 To: emaste, rpaulo, kostikbel Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 19:19:51 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 69232F4C for ; Wed, 11 Feb 2015 19:19:51 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 488DCD52 for ; Wed, 11 Feb 2015 19:19:51 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BJJp3i039583 for ; Wed, 11 Feb 2015 19:19:51 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BJJpwA039582; Wed, 11 Feb 2015 19:19:51 GMT (envelope-from root) Date: Wed, 11 Feb 2015 19:19:51 +0000 To: freebsd-toolchain@freebsd.org From: "rpaulo (Rui Paulo)" Subject: [Differential] [Accepted] D1819: libdwarf: Handle .rel relocations Message-ID: <416a2f37df4c67466fc2f26d73c5d0e1@localhost.localdomain> X-Priority: 3 Thread-Topic: D1819: libdwarf: Handle .rel relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OTU0ZGZmMDVmZDkwODkyYzExMzg2N2RjMDgyIFTbq1c= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 19:19:51 -0000 rpaulo added a subscriber: rpaulo. rpaulo accepted this revision. rpaulo added a reviewer: rpaulo. rpaulo added a comment. This revision is now accepted and ready to land. Reviewed. REVISION DETAIL https://reviews.freebsd.org/D1819 To: emaste, gnn, rpaulo Cc: rpaulo, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 19:21:52 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E2C65FAF for ; Wed, 11 Feb 2015 19:21:52 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C2968DFB for ; Wed, 11 Feb 2015 19:21:52 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BJLq9g043911 for ; Wed, 11 Feb 2015 19:21:52 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BJLqkf043910; Wed, 11 Feb 2015 19:21:52 GMT (envelope-from root) Date: Wed, 11 Feb 2015 19:21:52 +0000 To: freebsd-toolchain@freebsd.org From: "rpaulo (Rui Paulo)" Subject: [Differential] [Accepted] D1826: libdwarf: Add symbol value when processing .rela relocations Message-ID: <8ef72d0413ab9e063884ff0f48eac988@localhost.localdomain> X-Priority: 3 Thread-Topic: D1826: libdwarf: Add symbol value when processing .rela relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZjAwMzYxOWQ0Y2NkNDBkZjQ5NmIzZDI0ODQxIFTbq9A= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 19:21:53 -0000 rpaulo accepted this revision. rpaulo added a comment. I agree with kib that this deserves a comment. And perhaps add another comment in D1819 explaining why it isn't needed for .rel relocations. REVISION DETAIL https://reviews.freebsd.org/D1826 To: emaste, kostikbel, rpaulo Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 19:25:04 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9FDF1B7 for ; Wed, 11 Feb 2015 19:25:04 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7F7DAE2E for ; Wed, 11 Feb 2015 19:25:04 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BJP46u046431 for ; Wed, 11 Feb 2015 19:25:04 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BJP4xv046430; Wed, 11 Feb 2015 19:25:04 GMT (envelope-from root) Date: Wed, 11 Feb 2015 19:25:04 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Updated] D1819: libdwarf: Handle .rel relocations Message-ID: <927efe6058d0fa446941e22b5b7da2f6@localhost.localdomain> X-Priority: 3 Thread-Topic: D1819: libdwarf: Handle .rel relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OTU0ZGZmMDVmZDkwODkyYzExMzg2N2RjMDgyIFTbrJA= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 19:25:04 -0000 emaste added a reviewer: br. REVISION DETAIL https://reviews.freebsd.org/D1819 To: emaste, gnn, rpaulo, br Cc: rpaulo, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 19:37:36 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6203F281 for ; Wed, 11 Feb 2015 19:37:36 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4151FF2D for ; Wed, 11 Feb 2015 19:37:36 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BJbZVt058821 for ; Wed, 11 Feb 2015 19:37:35 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BJbZwJ058820; Wed, 11 Feb 2015 19:37:35 GMT (envelope-from root) Date: Wed, 11 Feb 2015 19:37:35 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Updated, 8 lines] D1826: libdwarf: Add symbol value when processing .rela relocations Message-ID: <57c5f660d1247efd329cc9874f395880@localhost.localdomain> X-Priority: 3 Thread-Topic: D1826: libdwarf: Add symbol value when processing .rela relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZjAwMzYxOWQ0Y2NkNDBkZjQ5NmIzZDI0ODQxIFTbr38= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 19:37:36 -0000 emaste updated this revision to Diff 3739. emaste added a comment. This revision now requires review to proceed. explicitly skip _dwarf_write_* if size==0 and add comment explaining that means unknown or non-absolute relocation CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1826?vs=3737&id=3739 REVISION DETAIL https://reviews.freebsd.org/D1826 AFFECTED FILES contrib/elftoolchain/libdwarf/libdwarf_elf_init.c To: emaste, rpaulo, kostikbel Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 19:49:38 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 83F3566A for ; Wed, 11 Feb 2015 19:49:38 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 62EC186 for ; Wed, 11 Feb 2015 19:49:38 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BJncM4073374 for ; Wed, 11 Feb 2015 19:49:38 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BJnc0N073373; Wed, 11 Feb 2015 19:49:38 GMT (envelope-from root) Date: Wed, 11 Feb 2015 19:49:38 +0000 To: freebsd-toolchain@freebsd.org From: "kostikbel (Konstantin Belousov)" Subject: [Differential] [Accepted] D1826: libdwarf: Add symbol value when processing .rela relocations Message-ID: <9255637518256a33741f964d3ae72a6d@localhost.localdomain> X-Priority: 3 Thread-Topic: D1826: libdwarf: Add symbol value when processing .rela relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZjAwMzYxOWQ0Y2NkNDBkZjQ5NmIzZDI0ODQxIFTbslI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 19:49:38 -0000 kostikbel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1826 To: emaste, rpaulo, kostikbel Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 19:54:03 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 33F9E97D for ; Wed, 11 Feb 2015 19:54:03 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 137C916A for ; Wed, 11 Feb 2015 19:54:03 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BJs2Ud079599 for ; Wed, 11 Feb 2015 19:54:02 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BJs2ig079598; Wed, 11 Feb 2015 19:54:02 GMT (envelope-from root) Date: Wed, 11 Feb 2015 19:54:02 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Closed] D1826: libdwarf: Add symbol value when processing .rela relocations Message-ID: X-Priority: 3 Thread-Topic: D1826: libdwarf: Add symbol value when processing .rela relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZjAwMzYxOWQ0Y2NkNDBkZjQ5NmIzZDI0ODQxIFTbs1o= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 19:54:03 -0000 emaste closed this revision. emaste updated this revision to Diff 3740. emaste added a comment. Closed by commit rS278593 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1826?vs=3739&id=3740#toc REVISION DETAIL https://reviews.freebsd.org/D1826 AFFECTED FILES head/contrib/elftoolchain/libdwarf/libdwarf_elf_init.c To: emaste, rpaulo, kostikbel Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 20:00:23 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6DAE9BDC for ; Wed, 11 Feb 2015 20:00:23 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4C4A41AE for ; Wed, 11 Feb 2015 20:00:23 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BK0NrI084880 for ; Wed, 11 Feb 2015 20:00:23 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BK0NmB084879; Wed, 11 Feb 2015 20:00:23 GMT (envelope-from root) Date: Wed, 11 Feb 2015 20:00:23 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Updated, 81 lines] D1819: libdwarf: Handle .rel relocations Message-ID: <7701d9e0497189a3ee82625be3dcc2de@localhost.localdomain> X-Priority: 3 Thread-Topic: D1819: libdwarf: Handle .rel relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OTU0ZGZmMDVmZDkwODkyYzExMzg2N2RjMDgyIFTbtNc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 20:00:23 -0000 emaste updated this revision to Diff 3741. emaste added a comment. This revision now requires review to proceed. Refactor common parts of .rel and .rela handling, based on feedback about non-obvious size==0 return from _dwarf_get_reloc_size CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1819?vs=3722&id=3741 REVISION DETAIL https://reviews.freebsd.org/D1819 AFFECTED FILES libdwarf/_libdwarf.h libdwarf/dwarf_reloc.c libdwarf/dwarf_set_reloc_application.3 libdwarf/libdwarf.c libdwarf/libdwarf_elf_init.c To: emaste, gnn, br, rpaulo Cc: rpaulo, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 21:17:07 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A074A4EC; Wed, 11 Feb 2015 21:17:07 +0000 (UTC) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com [209.85.215.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BFD2E9F; Wed, 11 Feb 2015 21:17:07 +0000 (UTC) Received: by labhz20 with SMTP id hz20so6066818lab.0; Wed, 11 Feb 2015 13:17:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:cc:content-type; bh=yUpFR5WUla835/Fm8Ed6khbNk5JO+fDw3+/EGxt1vE0=; b=Wad17CY3HdtiNLF4cYKV+CUJjSyc18/6BtuP8CNo/4TY6YsqyKvreD69JDa006omjQ Tsj6a6VcTl4XKzZSHj6pGsBWEjfi+FEBDtKfzuaCJDU5bbUHJn5imlTEdCytLxwkPfS7 HOT/di93jca0JfXxWbj1I0ySY4uJV6p3ZsEgYH6Up2jK2Ci7hLHBHtRT/TaGwP64790V Sv2/c5Jl4aqohYLI5V5bl3acduUKZNMqs57b4n9OvL/avlWFoam6e4N7rOAkWZ6N+AKU hu5JsuF9rfOn85JwGvzVDRllfDkWyfN84z08I8VwENbNqaIxMS0Jsa1mEC64xlCKXDcw LC7A== MIME-Version: 1.0 X-Received: by 10.112.126.98 with SMTP id mx2mr522112lbb.84.1423689425042; Wed, 11 Feb 2015 13:17:05 -0800 (PST) Sender: crodr001@gmail.com Received: by 10.112.28.40 with HTTP; Wed, 11 Feb 2015 13:17:04 -0800 (PST) Date: Wed, 11 Feb 2015 13:17:04 -0800 X-Google-Sender-Auth: dqDFKjiRmqrK8NDUgeBWdhn9PcI Message-ID: Subject: clang and scanbuild From: Craig Rodrigues To: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: freebsd-toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 21:17:07 -0000 Hi, We currently have a Jenkins job which checks out llvm trunk and builds it like this: svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm cd llvm ./configure --enable-optimized --disable-assertions --disable-docs --enable-targets=host \ --with-c-include-dirs=${WORKDIR}/obj${WORKDIR}/src/tmp/usr/include \ --with-cxx-include-root=${WORKDIR}/obj${WORKDIR}/src/tmp/usr/include gmake -j4 cp -p ./tools/clang/tools/scan-build/scan-build \ ./tools/clang/tools/scan-build/scanview.css \ ./tools/clang/tools/scan-build/sorttable.js \ Release/bin cp -p ./tools/clang/tools/scan-build/ccc-analyzer \ ./tools/clang/tools/scan-build/c++-analyzer \ Release/bin We then do this to invoke scan-build over the FreeBSD tree: /usr/bin/time -l \ env CCC_ANALYZER_CHECKER_DEADCODE=0 \ ${SCAN_BUILD} \ --use-cc ${OBJ}${SRCDIR}/tmp/usr/bin/cc \ --use-c++ ${OBJ}${SRCDIR}/tmp/usr/bin/c++ \ -k -o $output make ${JFLAG} $MYFLAGS \ CROSS_COMPILER_PREFIX=${OBJ}${SRCDIR}/tmp/usr/bin/ "$@" We can continue to do this, but I was wondering if: (1) is there a FreeBSD port which has this stuff? (2) is there enough llvm source in FreeBSD that we can build this in FreeBSD instead of checking out llvm source? -- Craig From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 21:43:17 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 637748E8; Wed, 11 Feb 2015 21:43:17 +0000 (UTC) Received: from tensor.andric.com (unknown [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1C39F184; Wed, 11 Feb 2015 21:43:17 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::9dec:c6e6:fdea:aaa9] (unknown [IPv6:2001:7b8:3a7:0:9dec:c6e6:fdea:aaa9]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 8DC595C2E; Wed, 11 Feb 2015 22:43:12 +0100 (CET) Subject: Re: clang and scanbuild Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_79B07EDB-D1FD-44AA-A02E-92B5BDCE6843"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b5 (769970b) From: Dimitry Andric In-Reply-To: Date: Wed, 11 Feb 2015 22:43:07 +0100 Message-Id: <08E18A70-59E0-441D-A705-0F3F3B7B9998@FreeBSD.org> References: To: Craig Rodrigues X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 21:43:17 -0000 --Apple-Mail=_79B07EDB-D1FD-44AA-A02E-92B5BDCE6843 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 11 Feb 2015, at 22:17, Craig Rodrigues wrote: > > We currently have a Jenkins job which checks out llvm trunk and builds > it like this: > > svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm > cd llvm > ./configure --enable-optimized --disable-assertions --disable-docs > --enable-targets=host \ > --with-c-include-dirs=${WORKDIR}/obj${WORKDIR}/src/tmp/usr/include \ > --with-cxx-include-root=${WORKDIR}/obj${WORKDIR}/src/tmp/usr/include > > gmake -j4 > > cp -p ./tools/clang/tools/scan-build/scan-build \ > ./tools/clang/tools/scan-build/scanview.css \ > ./tools/clang/tools/scan-build/sorttable.js \ > Release/bin > > cp -p ./tools/clang/tools/scan-build/ccc-analyzer \ > ./tools/clang/tools/scan-build/c++-analyzer \ > Release/bin > > We then do this to invoke scan-build over the FreeBSD tree: > > /usr/bin/time -l \ > env CCC_ANALYZER_CHECKER_DEADCODE=0 \ > ${SCAN_BUILD} \ > --use-cc ${OBJ}${SRCDIR}/tmp/usr/bin/cc \ > --use-c++ ${OBJ}${SRCDIR}/tmp/usr/bin/c++ \ > -k -o $output make ${JFLAG} $MYFLAGS \ > CROSS_COMPILER_PREFIX=${OBJ}${SRCDIR}/tmp/usr/bin/ "$@" > > > We can continue to do this, but I was wondering if: > (1) is there a FreeBSD port which has this stuff? Yes, choose either lang/clang-devel, or lang/clangXY, where XY is the version you are interested in. > (2) is there enough llvm source in FreeBSD that we can build this in > FreeBSD instead of checking out llvm source? You can already run the analyzers with the clang executable in base, unless you built your world using WITHOUT_CLANG_FULL. You do need perl installed, of course. -Dimitry --Apple-Mail=_79B07EDB-D1FD-44AA-A02E-92B5BDCE6843 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlTbzO8ACgkQsF6jCi4glqNQggCfTqmQOW91hK7rYwSmS9V17S5k ej8AoLq0QwUcWLKAiZCpcRqsFThKA39Z =YF3t -----END PGP SIGNATURE----- --Apple-Mail=_79B07EDB-D1FD-44AA-A02E-92B5BDCE6843-- From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 22:40:40 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 38D60692 for ; Wed, 11 Feb 2015 22:40:40 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1788D8F8 for ; Wed, 11 Feb 2015 22:40:40 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BMedd1053471 for ; Wed, 11 Feb 2015 22:40:39 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BMedPR053470; Wed, 11 Feb 2015 22:40:39 GMT (envelope-from root) Date: Wed, 11 Feb 2015 22:40:39 +0000 To: freebsd-toolchain@freebsd.org From: "gnn (George Neville-Neil)" Subject: [Differential] [Accepted] D1819: libdwarf: Handle .rel relocations Message-ID: <8443142f38aef7687f26cd6304518da2@localhost.localdomain> X-Priority: 3 Thread-Topic: D1819: libdwarf: Handle .rel relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OTU0ZGZmMDVmZDkwODkyYzExMzg2N2RjMDgyIFTb2mc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 22:40:40 -0000 gnn accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1819 To: emaste, br, rpaulo, gnn Cc: rpaulo, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Feb 11 23:33:12 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 850547A9 for ; Wed, 11 Feb 2015 23:33:12 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 63386ED7 for ; Wed, 11 Feb 2015 23:33:12 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1BNXCjC021423 for ; Wed, 11 Feb 2015 23:33:12 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BNXCdV021422; Wed, 11 Feb 2015 23:33:12 GMT (envelope-from root) Date: Wed, 11 Feb 2015 23:33:12 +0000 To: freebsd-toolchain@freebsd.org From: "imp (Warner Losh)" Subject: [Differential] [Accepted] D1819: libdwarf: Handle .rel relocations Message-ID: <88a410df95bc63ebcc749f3047f0c2ac@localhost.localdomain> X-Priority: 3 Thread-Topic: D1819: libdwarf: Handle .rel relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OTU0ZGZmMDVmZDkwODkyYzExMzg2N2RjMDgyIFTb5rg= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 23:33:12 -0000 imp accepted this revision. imp added a reviewer: imp. REVISION DETAIL https://reviews.freebsd.org/D1819 To: emaste, br, rpaulo, gnn, imp Cc: rpaulo, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Feb 12 00:02:20 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7EFB4BB4 for ; Thu, 12 Feb 2015 00:02:20 +0000 (UTC) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 391581BE for ; Thu, 12 Feb 2015 00:02:19 +0000 (UTC) Received: from localhost (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id 05CCB281111 for ; Thu, 12 Feb 2015 10:02:17 +1000 (EST) X-Amavis-Modified: Mail body modified (using disclaimer) - iredmail.onthenet.com.au X-Virus-Scanned: amavisd-new at iredmail.onthenet.com.au Received: from iredmail.onthenet.com.au ([127.0.0.1]) by localhost (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gro69zOHY31z for ; Thu, 12 Feb 2015 10:02:16 +1000 (EST) Received: from Peters-MacBook-Pro.local (unknown [64.245.0.210]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id BBD3B280F55; Thu, 12 Feb 2015 10:02:13 +1000 (EST) Message-ID: <54DBED83.8070204@freebsd.org> Date: Wed, 11 Feb 2015 16:02:11 -0800 From: Peter Grehan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Baptiste Daroussin , Warner Losh Subject: Re: Resurrecting clang external toolchain support in Makefile.inc References: <54DABF3A.8060003@freebsd.org> <20150211084534.GY29891@ivaldir.etoilebsd.net> In-Reply-To: <20150211084534.GY29891@ivaldir.etoilebsd.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 00:02:20 -0000 Hi Bapt, > In my opinion we should track down the last traces of XFLAGS and turn them into > proper XCFLAGS and XCXXFLAGS, the intent was to get rid of XFLAGS because the > name was confusing. > > so instead of adding XFLAGS to XC*FLAGS, the XFLAGS should juste be converted > into XC*FLAGS directly in my opinion. How about the appended ? It moves the sysroot definition into the non-GCC XC/XCXXFLAGS defs, and renames XFLAGS to BFLAGS. This should be identical to pre r273755 behaviour. later, Peter. --- Makefile.inc1 (revision 278542) +++ Makefile.inc1 (working copy) @@ -348,16 +348,15 @@ SIZE="${XSIZE}" .if ${XCC:M/*} -XFLAGS= --sysroot=${WORLDTMP} .if defined(CROSS_BINUTILS_PREFIX) # In the case of xdev-build tools, CROSS_BINUTILS_PREFIX won't be a # directory, but the compiler will look in the right place for it's # tools so we don't need to tell it where to look. .if exists(${CROSS_BINUTILS_PREFIX}) -XFLAGS+= -B${CROSS_BINUTILS_PREFIX} +BFLAGS+= -B${CROSS_BINUTILS_PREFIX} .endif .else -XFLAGS+= -B${WORLDTMP}/usr/bin +BFLAGS+= -B${WORLDTMP}/usr/bin .endif .if ${TARGET} == "arm" .if ${TARGET_ARCH:M*hf*} != "" @@ -374,6 +373,8 @@ TARGET_ABI?= unknown TARGET_TRIPLE?= ${TARGET_ARCH:C/amd64/x86_64/}-${TARGET_ABI}-freebsd11.0 XCFLAGS+= -target ${TARGET_TRIPLE} +XCFLAGS+= --sysroot=${WORLDTMP} ${BFLAGS} +XCXXFLAGS+= --sysroot=${WORLDTMP} ${BFLAGS} .endif .endif From owner-freebsd-toolchain@FreeBSD.ORG Thu Feb 12 01:02:19 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 12D33AC5 for ; Thu, 12 Feb 2015 01:02:19 +0000 (UTC) Received: from mail-ig0-f182.google.com (mail-ig0-f182.google.com [209.85.213.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CDE8497F for ; Thu, 12 Feb 2015 01:02:18 +0000 (UTC) Received: by mail-ig0-f182.google.com with SMTP id h15so678310igd.3 for ; Wed, 11 Feb 2015 17:02:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=CPekrUaYaB5Ci+z0OYXgRifQWHr2HhLXQr3KNB2zRlU=; b=Q6vlb5LCzZx18mNFZVAzWo0wo1gx8JoNKB4c1BNm8u9drBWODPpVAKa6nJ7azQkRjr ew7613X06pYNA3dC9x1tqO+Jw8g8lSd/AxGeln8g0pnD7177sPfBWDX+odRgmyWYGApp zzBY0G9GM2Kg22bYOqx+xuHp0b2WcXeuKq3JB5vtaCW6LGwQ39kVNcLFxNwicGJdtWTR 4/06r0HpFaP7wfL38ZolInR7v2d2o+rz92AUa3r5Fsm0gIkIpvNKiIYpBCEC8meEuBkP DNUUL/CACRN3AVEH+nAVKm8En1sYz9cuhz3PXcH29LseTg2S+RHbz6iTBP3azk25mgWA 0slQ== X-Gm-Message-State: ALoCoQn0YUhZpp0zaXEDlnbVuligDaaTkk+9X+ZHacpWb2YXdHjztSZe79jfdoidFXAKeafH3J/Z X-Received: by 10.107.27.76 with SMTP id b73mr1760005iob.64.1423702931001; Wed, 11 Feb 2015 17:02:11 -0800 (PST) Received: from netflix-mac-wired.bsdimp.com ([50.253.99.174]) by mx.google.com with ESMTPSA id k125sm1443740ioe.29.2015.02.11.17.02.10 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 11 Feb 2015 17:02:10 -0800 (PST) Sender: Warner Losh Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: Resurrecting clang external toolchain support in Makefile.inc From: Warner Losh In-Reply-To: <54DBED83.8070204@freebsd.org> Date: Wed, 11 Feb 2015 18:02:09 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <54DABF3A.8060003@freebsd.org> <20150211084534.GY29891@ivaldir.etoilebsd.net> <54DBED83.8070204@freebsd.org> To: Peter Grehan X-Mailer: Apple Mail (2.2070.6) Cc: freebsd-toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 01:02:19 -0000 > On Feb 11, 2015, at 5:02 PM, Peter Grehan wrote: >=20 > Hi Bapt, >=20 >> In my opinion we should track down the last traces of XFLAGS and turn = them into >> proper XCFLAGS and XCXXFLAGS, the intent was to get rid of XFLAGS = because the >> name was confusing. >>=20 >> so instead of adding XFLAGS to XC*FLAGS, the XFLAGS should juste be = converted >> into XC*FLAGS directly in my opinion. >=20 > How about the appended ? It moves the sysroot definition into the = non-GCC XC/XCXXFLAGS defs, and renames XFLAGS to BFLAGS. This should be = identical to pre r273755 behaviour. >=20 > later, >=20 > Peter. >=20 > --- Makefile.inc1 (revision 278542) > +++ Makefile.inc1 (working copy) > @@ -348,16 +348,15 @@ > SIZE=3D"${XSIZE}" >=20 > .if ${XCC:M/*} > -XFLAGS=3D --sysroot=3D${WORLDTMP} > .if defined(CROSS_BINUTILS_PREFIX) > # In the case of xdev-build tools, CROSS_BINUTILS_PREFIX won't be a > # directory, but the compiler will look in the right place for it's > # tools so we don't need to tell it where to look. > .if exists(${CROSS_BINUTILS_PREFIX}) > -XFLAGS+=3D -B${CROSS_BINUTILS_PREFIX} > +BFLAGS+=3D -B${CROSS_BINUTILS_PREFIX} > .endif > .else > -XFLAGS+=3D -B${WORLDTMP}/usr/bin > +BFLAGS+=3D -B${WORLDTMP}/usr/bin > .endif > .if ${TARGET} =3D=3D "arm" > .if ${TARGET_ARCH:M*hf*} !=3D "" > @@ -374,6 +373,8 @@ > TARGET_ABI?=3D unknown > TARGET_TRIPLE?=3D = ${TARGET_ARCH:C/amd64/x86_64/}-${TARGET_ABI}-freebsd11.0 > XCFLAGS+=3D -target ${TARGET_TRIPLE} > +XCFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > +XCXXFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > .endif > .endif I like this patch better than the one I have. I=E2=80=99m not 100% sure = the =E2=80=98else=E2=80=99 clause will work, but it is certainly better = than we have today. Warner From owner-freebsd-toolchain@FreeBSD.ORG Thu Feb 12 02:09:13 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 17F56682 for ; Thu, 12 Feb 2015 02:09:13 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EA223F62 for ; Thu, 12 Feb 2015 02:09:12 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1C29CXW082369 for ; Thu, 12 Feb 2015 02:09:12 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1C29C9m082368; Thu, 12 Feb 2015 02:09:12 GMT (envelope-from root) Date: Thu, 12 Feb 2015 02:09:12 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Closed] D1819: libdwarf: Handle .rel relocations Message-ID: <465c267c689bf1acf4c000620a3be2c4@localhost.localdomain> X-Priority: 3 Thread-Topic: D1819: libdwarf: Handle .rel relocations X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OTU0ZGZmMDVmZDkwODkyYzExMzg2N2RjMDgyIFTcC0g= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 02:09:13 -0000 emaste closed this revision. emaste updated this revision to Diff 3742. emaste added a comment. Closed by commit rS278611 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1819?vs=3741&id=3742#toc REVISION DETAIL https://reviews.freebsd.org/D1819 AFFECTED FILES head/contrib/elftoolchain/libdwarf/_libdwarf.h head/contrib/elftoolchain/libdwarf/dwarf_reloc.c head/contrib/elftoolchain/libdwarf/dwarf_set_reloc_application.3 head/contrib/elftoolchain/libdwarf/libdwarf.c head/contrib/elftoolchain/libdwarf/libdwarf_elf_init.c To: emaste, br, rpaulo, gnn, imp Cc: rpaulo, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Feb 12 02:15:02 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 33665738 for ; Thu, 12 Feb 2015 02:15:02 +0000 (UTC) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E0AB26F for ; Thu, 12 Feb 2015 02:15:01 +0000 (UTC) Received: from localhost (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id CCFBF281112 for ; Thu, 12 Feb 2015 12:14:58 +1000 (EST) X-Amavis-Modified: Mail body modified (using disclaimer) - iredmail.onthenet.com.au X-Virus-Scanned: amavisd-new at iredmail.onthenet.com.au Received: from iredmail.onthenet.com.au ([127.0.0.1]) by localhost (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j1b46MzH96A7 for ; Thu, 12 Feb 2015 12:14:58 +1000 (EST) Received: from Peters-MacBook-Pro.local (unknown [64.245.0.210]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id D4EEB280F52; Thu, 12 Feb 2015 12:14:55 +1000 (EST) Message-ID: <54DC0C9D.80009@freebsd.org> Date: Wed, 11 Feb 2015 18:14:53 -0800 From: Peter Grehan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Warner Losh Subject: Re: Resurrecting clang external toolchain support in Makefile.inc References: <54DABF3A.8060003@freebsd.org> <20150211084534.GY29891@ivaldir.etoilebsd.net> <54DBED83.8070204@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 02:15:02 -0000 Hi Warner, > I like this patch better than the one I have. I’m not 100% sure the > ‘else’ clause will work The else for CROSS_BINUTILS_PREFIX ? If so, yes, that appears to work: I'm building with in-tree binutils. Ok for this to be committed ? later, Peter. From owner-freebsd-toolchain@FreeBSD.ORG Thu Feb 12 06:55:19 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ACB86275 for ; Thu, 12 Feb 2015 06:55:19 +0000 (UTC) Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7360417C for ; Thu, 12 Feb 2015 06:55:19 +0000 (UTC) Received: by mail-ig0-f171.google.com with SMTP id h15so1883362igd.4 for ; Wed, 11 Feb 2015 22:55:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=ZNK0Biq1oN18Y+jHIc8RS71V2/tknHKBk1NE4aowoAo=; b=FGkjuSONk1RLGaBIQaAX/xGGkH1vEpFQpviJw4/vMs8raNmoMw+YQSSpYz64F1cJT4 sNUw4+wtplmC1Klc+8unofSOOhURwIJ/egF1CYD/cJGHn6b0U1MENPn/kbw5eQFzRhPl tmN9tt2H+NsPsFKI9EsqhryPu0L5Uksdor2lJynx9Z/NTyWJKTmRzqXVeq60PqTbJtRb G9rHFW9Wh9Zmd8DZ4mr881XrGUPgXGroFcAWuPVH25jHJMPZq4xp0V9IhPggmZzTH2Gs dkx/sgrnPsDh6NqAHu2/34PUicvUKkQe7RAk0kKqgTXbCgeDDNAz2WqIUUaEK5LkNyWs 4N/g== X-Gm-Message-State: ALoCoQnh6OW4t8PxRy0OHcYyYTGQytGAulmYme6Xu0HQsP39vYnBiOM2pRzGsmLvAVSb5rG3utWA X-Received: by 10.107.10.148 with SMTP id 20mr1765582iok.79.1423724118653; Wed, 11 Feb 2015 22:55:18 -0800 (PST) Received: from netflix-mac-wired.bsdimp.com ([50.253.99.174]) by mx.google.com with ESMTPSA id c4sm714210igt.19.2015.02.11.22.55.17 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 11 Feb 2015 22:55:18 -0800 (PST) Sender: Warner Losh Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: Resurrecting clang external toolchain support in Makefile.inc From: Warner Losh In-Reply-To: <54DC0C9D.80009@freebsd.org> Date: Wed, 11 Feb 2015 23:55:17 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <54DABF3A.8060003@freebsd.org> <20150211084534.GY29891@ivaldir.etoilebsd.net> <54DBED83.8070204@freebsd.org> <54DC0C9D.80009@freebsd.org> To: Peter Grehan X-Mailer: Apple Mail (2.2070.6) Cc: freebsd-toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 06:55:19 -0000 > On Feb 11, 2015, at 7:14 PM, Peter Grehan wrote: >=20 > Hi Warner, >=20 >> I like this patch better than the one I have. I=E2=80=99m not 100% = sure the >> =E2=80=98else=E2=80=99 clause will work >=20 > The else for CROSS_BINUTILS_PREFIX ? If so, yes, that appears to work: = I'm building with in-tree binutils. >=20 > Ok for this to be committed ? Yes. I=E2=80=99m happy. Warner From owner-freebsd-toolchain@FreeBSD.ORG Thu Feb 12 07:01:45 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 749E5325; Thu, 12 Feb 2015 07:01:45 +0000 (UTC) Received: from mail-we0-x235.google.com (mail-we0-x235.google.com [IPv6:2a00:1450:400c:c03::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0E71524E; Thu, 12 Feb 2015 07:01:45 +0000 (UTC) Received: by mail-we0-f181.google.com with SMTP id w62so8047359wes.12; Wed, 11 Feb 2015 23:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=epsh9+2JFwXasGCZGCme38I6N0qQSwlZ34q0T2aUSNI=; b=ZI1obQzcQf3RjQ3EsAdkE4RfXtFmmdpcgG8s4UrV6Z8e4hGTQVdbP/dyfdvNFU1MvV 2eQ9G+gm3wrY8KPES1kM3HDh7PGCKEiox6LIu4+szI3DnE0YPpveR2fxbKHf0lOls7ox i5JxQsFGN566X6D7uzlshWpHGsqXaPmRwiwY9uVY0ZK2z+AySrB9ggqV+mz8Ph34fdLr pDCb9Ri3lf8+kk0n7tlQHs4aQwalGMNNUS9piU3DGgCcsSxb+z9Zw0e1a+fCKdQzlWfI LhCGf1/zxoYhebpQ9kNNS+7+dCjEfPZRtaRDJiVtPp8+V+5yqbEUIH9mVJrKJL+Jt+n/ VoYg== X-Received: by 10.180.76.133 with SMTP id k5mr3282003wiw.30.1423724503380; Wed, 11 Feb 2015 23:01:43 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id fd10sm1231045wib.4.2015.02.11.23.01.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Feb 2015 23:01:42 -0800 (PST) Sender: Baptiste Daroussin Date: Thu, 12 Feb 2015 08:01:40 +0100 From: Baptiste Daroussin To: Warner Losh Subject: Re: Resurrecting clang external toolchain support in Makefile.inc Message-ID: <20150212070140.GC29891@ivaldir.etoilebsd.net> References: <54DABF3A.8060003@freebsd.org> <20150211084534.GY29891@ivaldir.etoilebsd.net> <54DBED83.8070204@freebsd.org> <54DC0C9D.80009@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ITEy4z2kE7rjCDPK" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-toolchain@freebsd.org, Peter Grehan X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 07:01:45 -0000 --ITEy4z2kE7rjCDPK Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 11, 2015 at 11:55:17PM -0700, Warner Losh wrote: >=20 > > On Feb 11, 2015, at 7:14 PM, Peter Grehan wrote: > >=20 > > Hi Warner, > >=20 > >> I like this patch better than the one I have. I=E2=80=99m not 100% sur= e the > >> =E2=80=98else=E2=80=99 clause will work > >=20 > > The else for CROSS_BINUTILS_PREFIX ? If so, yes, that appears to work: = I'm building with in-tree binutils. > >=20 > > Ok for this to be committed ? >=20 > Yes. I=E2=80=99m happy. >=20 Ok for me as well! Best regards, Bapt --ITEy4z2kE7rjCDPK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlTcT9QACgkQ8kTtMUmk6Ez7rgCePaghfMb6JtHQKOFhzGeYhg3g IIwAmwQBGKcr0ObhtZaGcJOV/IYtbzZq =bFD6 -----END PGP SIGNATURE----- --ITEy4z2kE7rjCDPK--