From owner-freebsd-toolchain@FreeBSD.ORG Wed Apr 29 23:31:48 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A979A587; Wed, 29 Apr 2015 23:31:48 +0000 (UTC) Received: from mail-pd0-x235.google.com (mail-pd0-x235.google.com [IPv6:2607:f8b0:400e:c02::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 76DA3175B; Wed, 29 Apr 2015 23:31:48 +0000 (UTC) Received: by pdbqa5 with SMTP id qa5so42163606pdb.1; Wed, 29 Apr 2015 16:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:subject:date:message-id:cc:to:mime-version; bh=erCiJdpHoC+eiePCdTIsO/AKpvE32lLd9GSoWSpCmnw=; b=Di4hgoLi/DlKY4P3XosBOqUrkQ/opbChMM9clNFSUnpdVi9Wz9nkI1wdYP2t5cwg1U MNloV7JbVbt2NCfE95i6X8/QDDFyNG2CqKiYj4Xqwht9q07eHsU5hmrOf4SHBF1rpSPW iCKFZw3im3UK5QjwoShX3QrM2qBEsLtFFlN2WyRJWYwJ0TQ+h8gR2z82LPrx5HHPAZKX F0IFwzDsOhKTueZWBLLJUXT6tegfpaeRQDRtRXy00dzzrefhclbZFIJ1exjDVACKcqHP DMycD9nb91LqVLpjaKMA4jVAzKw3hLmoxniZC9Sxg1vEyI25As6smE/mivF7USXlWoqZ 0Rww== X-Received: by 10.68.237.40 with SMTP id uz8mr2695178pbc.140.1430350308010; Wed, 29 Apr 2015 16:31:48 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:857d:cd13:79bf:f40d? ([2601:8:ab80:7d6:857d:cd13:79bf:f40d]) by mx.google.com with ESMTPSA id nl16sm269191pdb.56.2015.04.29.16.31.46 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 29 Apr 2015 16:31:47 -0700 (PDT) From: Garrett Cooper X-Pgp-Agent: GPGMail 2.5b6 Content-Type: multipart/signed; boundary="Apple-Mail=_2D05942A-C4E9-4980-82BA-3E7662F69B4F"; protocol="application/pgp-signature"; micalg=pgp-sha512 Subject: A better way to get runtime coverage with libprofile_rt (from compiler_rt) / gcov? Date: Wed, 29 Apr 2015 16:31:45 -0700 Message-Id: <1DCB7CE4-2AC1-4AC6-B630-8A55BAF546BB@gmail.com> Cc: Anthony Cornehl , Benno Rice To: FreeBSD Toolchain Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) X-Mailer: Apple Mail (2.1878.6) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2015 23:31:48 -0000 --Apple-Mail=_2D05942A-C4E9-4980-82BA-3E7662F69B4F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 Hi all, In order to adapt an existing process to clang, I went and tried = to figure out how to get coverage generation to work on FreeBSD with = shared binaries (not static binaries), which is the default for = clang/gcc: = https://github.com/yaneurabeya/scratch/blob/master/coverage-with-shared-li= bs-freebsd . In doing this I had to commit a few cardinal sins: 1. I had to specify -lgcov, even though the gcc docs said = --coverage implied this. 2. I had to link in static libraries directly using LDADD: = https://github.com/yaneurabeya/scratch/blob/master/coverage-with-shared-li= bs-freebsd/Makefile.inc#L9 . If I didn=92t, things would blow when it = tried to link lib/libfoo.so into bin/foo , so there might be a = difference in behavior between clang and gcc in that regard (I tried = using LDFLAGS + LDADD with just -lclang_rt.profile-x86_64, but that = didn=92t seem to work either): /usr/bin/ld: foo: hidden symbol `llvm_gcda_emit_arcs' in = /usr/bin/../lib/clang/3.6.0/lib/freebsd/libclang_rt.profile-x86_64.a(GCDAP= rofiling.o) is referenced by DSO /usr/bin/ld: final link failed: Nonrepresentable section on output Does anyone know of a better way to solve this problem, i.e. = avoid having to hardcode the full path to libclang_rt.profile-x86_64.a = (or perhaps make clang do the right thing when trying to link in the = library)? Thanks! -NGie $ make -s obj depend all =3D=3D=3D> lib (obj) =3D=3D=3D> bin (obj) =3D=3D=3D> lib (depend) =3D=3D=3D> bin (depend) =3D=3D=3D> lib (all) =3D=3D=3D> bin (all) $ make get-coverage LD_LIBRARY_PATH=3D/usr/obj/usr/src.svn/tests/foo/lib = /usr/obj/usr/src.svn/tests/foo/bin/foo This is foo lcov --capture --directory /usr/obj/usr/src.svn/tests/foo --output-file = /usr/obj/usr/src.svn/tests/foo/coverage.info Capturing coverage data from /usr/obj/usr/src.svn/tests/foo Found gcov version: 4.2.1 Scanning /usr/obj/usr/src.svn/tests/foo for .gcda files ... Found 2 data files in /usr/obj/usr/src.svn/tests/foo Processing lib/foo.gcda /usr/obj/usr/src.svn/tests/foo/lib/foo.gcno:version '402*', prefer = '402p' /usr/obj/usr/src.svn/tests/foo/lib/foo.gcda:version '402*', prefer = version '402p' /usr/obj/usr/src.svn/tests/foo/lib/foo.gcno:'foo' has arcs from exit = block Processing bin/foo.gcda /usr/obj/usr/src.svn/tests/foo/bin/foo.gcno:version '402*', prefer = '402p' /usr/obj/usr/src.svn/tests/foo/bin/foo.gcda:version '402*', prefer = version '402p' Finished .info-file creation genhtml /usr/obj/usr/src.svn/tests/foo/coverage.info --output-directory = output Reading data file /usr/obj/usr/src.svn/tests/foo/coverage.info Found 2 entries. Found common filename prefix "/usr/src.svn/tests/foo" Writing .css and .png files. Generating output. Processing file bin/foo.c Processing file lib/foo.c Writing directory view page. Overall coverage rate: lines......: 100.0% (4 of 4 lines) functions..: 100.0% (2 of 2 functions) --Apple-Mail=_2D05942A-C4E9-4980-82BA-3E7662F69B4F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVQWnhAAoJEMZr5QU6S73eyooH/REUPj4X5HNiEO72U7GmJrr+ hkSEKUT9oLYhtSNIaChKESr+a0Yb48j2XGgDHPEMD6hKxsKz4HXVSXiWgBUVVsRK J/71kvGwamyoUv+jCgMwVZ+5su0si/n+DCfA/RjowRf0yRLSiJGavPUFhnJG2ZAF pqsoxr2MuMn7apxnHAVGkxGV3Hke94UD4OkFaaG9ijnaVsHffuVT+P1vGVb2lDGz HpeMtLLwyQGl0T9MXKRQgRx+QLhrI/dGwuJIDRII9ZzOiNkn6vfJm4yEq0e7fJ/e y/DApeaJOblJgLAijVWZ7KdrSeVyoiANuvTa9kMBTdpsPHeZsW3wQ6ebEJ885no= =+lQL -----END PGP SIGNATURE----- --Apple-Mail=_2D05942A-C4E9-4980-82BA-3E7662F69B4F-- From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 30 15:00:30 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8253F45A for ; Thu, 30 Apr 2015 15:00:30 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5B872154A for ; Thu, 30 Apr 2015 15:00:30 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3UF0TJw048896 for ; Thu, 30 Apr 2015 15:00:30 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3UF0TXu048895; Thu, 30 Apr 2015 15:00:29 GMT (envelope-from daemon-user) Date: Thu, 30 Apr 2015 15:00:29 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Request, 19 lines] D2408: Add ELF Tool Chain's c++filt to the build Message-ID: X-Priority: 3 Thread-Topic: D2408: Add ELF Tool Chain's c++filt to the build X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Thread-Index: NTlmNTU4Y2I5N2RjNDEwM2E5OWYxY2VlZTc3 Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_2f7102b9ca1bb76a91f7333b7aac484e" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2015 15:00:30 -0000 --b1_2f7102b9ca1bb76a91f7333b7aac484e Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit emaste created this revision. emaste added a reviewer: brooks. emaste added a subscriber: freebsd-toolchain. REVISION DETAIL https://reviews.freebsd.org/D2408 AFFECTED FILES usr.bin/Makefile usr.bin/cxxfilt/Makefile CHANGE DETAILS diff --git a/usr.bin/cxxfilt/Makefile b/usr.bin/cxxfilt/Makefile new file mode 100644 --- /dev/null +++ b/usr.bin/cxxfilt/Makefile @@ -0,0 +1,17 @@ +# $FreeBSD$ + +.include + +ELFTCDIR= ${.CURDIR}/../../contrib/elftoolchain +SRCDIR= ${ELFTCDIR}/cxxfilt + +.PATH: ${SRCDIR} + +PROG= c++filt +SRCS= cxxfilt.c + +LIBADD= elftc + +CFLAGS+=-I${ELFTCDIR}/libelftc -I${ELFTCDIR}/common + +.include diff --git a/usr.bin/Makefile b/usr.bin/Makefile --- a/usr.bin/Makefile +++ b/usr.bin/Makefile @@ -36,6 +36,7 @@ csplit \ ctlstat \ cut \ + ${_cxxfilt} \ demandoc \ dirname \ dpv \ @@ -237,6 +238,7 @@ .if ${MK_ELFTOOLCHAIN_TOOLS} != "no" _addr2line= addr2line +_cxxfilt= cxxfilt _elfcopy= elfcopy _nm= nm _readelf= readelf EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: freebsd-toolchain --b1_2f7102b9ca1bb76a91f7333b7aac484e Content-Type: text/x-patch; charset=utf-8; name="D2408.5105.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D2408.5105.patch" ZGlmZiAtLWdpdCBhL3Vzci5iaW4vY3h4ZmlsdC9NYWtlZmlsZSBiL3Vzci5iaW4vY3h4ZmlsdC9N YWtlZmlsZQpuZXcgZmlsZSBtb2RlIDEwMDY0NAotLS0gL2Rldi9udWxsCisrKyBiL3Vzci5iaW4v Y3h4ZmlsdC9NYWtlZmlsZQpAQCAtMCwwICsxLDE3IEBACisjICRGcmVlQlNEJAorCisuaW5jbHVk ZSA8c3JjLm9wdHMubWs+CisKK0VMRlRDRElSPQkkey5DVVJESVJ9Ly4uLy4uL2NvbnRyaWIvZWxm dG9vbGNoYWluCitTUkNESVI9CQkke0VMRlRDRElSfS9jeHhmaWx0CisKKy5QQVRIOiAke1NSQ0RJ Un0KKworUFJPRz0JYysrZmlsdAorU1JDUz0JY3h4ZmlsdC5jCisKK0xJQkFERD0JZWxmdGMKKwor Q0ZMQUdTKz0tSSR7RUxGVENESVJ9L2xpYmVsZnRjIC1JJHtFTEZUQ0RJUn0vY29tbW9uCisKKy5p bmNsdWRlIDxic2QucHJvZy5taz4KZGlmZiAtLWdpdCBhL3Vzci5iaW4vTWFrZWZpbGUgYi91c3Iu YmluL01ha2VmaWxlCi0tLSBhL3Vzci5iaW4vTWFrZWZpbGUKKysrIGIvdXNyLmJpbi9NYWtlZmls ZQpAQCAtMzYsNiArMzYsNyBAQAogCWNzcGxpdCBcCiAJY3Rsc3RhdCBcCiAJY3V0IFwKKwkke19j eHhmaWx0fSBcCiAJZGVtYW5kb2MgXAogCWRpcm5hbWUgXAogCWRwdiBcCkBAIC0yMzcsNiArMjM4 LDcgQEAKIAogLmlmICR7TUtfRUxGVE9PTENIQUlOX1RPT0xTfSAhPSAibm8iCiBfYWRkcjJsaW5l PQlhZGRyMmxpbmUKK19jeHhmaWx0PQljeHhmaWx0CiBfZWxmY29weT0JZWxmY29weQogX25tPQkJ bm0KIF9yZWFkZWxmPQlyZWFkZWxmCgo= --b1_2f7102b9ca1bb76a91f7333b7aac484e-- From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 30 15:08:17 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 26EC76CB for ; Thu, 30 Apr 2015 15:08:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 059A715D4 for ; Thu, 30 Apr 2015 15:08:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3UF8GTc051178 for ; Thu, 30 Apr 2015 15:08:16 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3UF8GcW051177; Thu, 30 Apr 2015 15:08:16 GMT (envelope-from daemon-user) Date: Thu, 30 Apr 2015 15:08:16 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Commented On] D2408: Add ELF Tool Chain's c++filt to the build Message-ID: <7fe93998747d1c634c8b04c67f88ff09@localhost.localdomain> X-Priority: 3 Thread-Topic: D2408: Add ELF Tool Chain's c++filt to the build X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NTlmNTU4Y2I5N2RjNDEwM2E5OWYxY2VlZTc3IFVCRWA= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2015 15:08:17 -0000 emaste added a comment. Oh - we also need either: diff --git a/gnu/usr.bin/cc/Makefile b/gnu/usr.bin/cc/Makefile index abc9876..12ee7f8 100644 --- a/gnu/usr.bin/cc/Makefile +++ b/gnu/usr.bin/cc/Makefile @@ -12,7 +12,10 @@ SUBDIR+= cpp .endif .if ${MK_CXX} != "no" -SUBDIR+= cc1plus c++ c++filt +SUBDIR+= cc1plus c++ +.if ${MK_ELFTOOLCHAIN_TOLOLS} != "no" +SUBDIR+= c++filt +.endif .endif .if ${MK_GCOV} != "no" or --- a/usr.bin/Makefile +++ b/usr.bin/Makefile @@ -238,7 +238,9 @@ SUBDIR+= ee .if ${MK_ELFTOOLCHAIN_TOOLS} != "no" _addr2line= addr2line +.if ${MK_GCC} != "no" && ${MK_CXX} != "no" _cxxfilt= cxxfilt +.endif _elfcopy= elfcopy _nm= nm _readelf= readelf REVISION DETAIL https://reviews.freebsd.org/D2408 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 30 15:33:33 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4AD33E14 for ; Thu, 30 Apr 2015 15:33:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2BECE1907 for ; Thu, 30 Apr 2015 15:33:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3UFXWTZ059443 for ; Thu, 30 Apr 2015 15:33:32 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3UFXWox059442; Thu, 30 Apr 2015 15:33:32 GMT (envelope-from daemon-user) Date: Thu, 30 Apr 2015 15:33:32 +0000 To: freebsd-toolchain@freebsd.org From: "brooks (Brooks Davis)" Subject: [Differential] [Updated] D2408: Add ELF Tool Chain's c++filt to the build Message-ID: X-Priority: 3 Thread-Topic: D2408: Add ELF Tool Chain's c++filt to the build X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NTlmNTU4Y2I5N2RjNDEwM2E5OWYxY2VlZTc3IFVCS0w= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2015 15:33:33 -0000 brooks added a comment. s/MK_ELFTOOLCHAIN_TOLOLS/MK_ELFTOOLCHAIN_TOOLS/ required :) REVISION DETAIL https://reviews.freebsd.org/D2408 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 30 15:39:34 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D2B9FF95 for ; Thu, 30 Apr 2015 15:39:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B0D151942 for ; Thu, 30 Apr 2015 15:39:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3UFdYkg059720 for ; Thu, 30 Apr 2015 15:39:34 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3UFdYoK059719; Thu, 30 Apr 2015 15:39:34 GMT (envelope-from daemon-user) Date: Thu, 30 Apr 2015 15:39:34 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Updated, 26 lines] D2408: Add ELF Tool Chain's c++filt to the build Message-ID: X-Priority: 3 Thread-Topic: D2408: Add ELF Tool Chain's c++filt to the build X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NTlmNTU4Y2I5N2RjNDEwM2E5OWYxY2VlZTc3IFVCTLY= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_e0054449863fc0ba6e9256b56bb4b064" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2015 15:39:34 -0000 --b1_e0054449863fc0ba6e9256b56bb4b064 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit emaste updated this revision to Diff 5108. emaste added a comment. - prefer ELF Tool Chain's c++filt - exclude from make delete-old - fix typo CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2408?vs=5105&id=5108 REVISION DETAIL https://reviews.freebsd.org/D2408 AFFECTED FILES gnu/usr.bin/cc/Makefile tools/build/mk/OptionalObsoleteFiles.inc usr.bin/Makefile usr.bin/cxxfilt/Makefile CHANGE DETAILS diff --git a/usr.bin/cxxfilt/Makefile b/usr.bin/cxxfilt/Makefile new file mode 100644 --- /dev/null +++ b/usr.bin/cxxfilt/Makefile @@ -0,0 +1,17 @@ +# $FreeBSD$ + +.include + +ELFTCDIR= ${.CURDIR}/../../contrib/elftoolchain +SRCDIR= ${ELFTCDIR}/cxxfilt + +.PATH: ${SRCDIR} + +PROG= c++filt +SRCS= cxxfilt.c + +LIBADD= elftc + +CFLAGS+=-I${ELFTCDIR}/libelftc -I${ELFTCDIR}/common + +.include diff --git a/usr.bin/Makefile b/usr.bin/Makefile --- a/usr.bin/Makefile +++ b/usr.bin/Makefile @@ -36,6 +36,7 @@ csplit \ ctlstat \ cut \ + ${_cxxfilt} \ demandoc \ dirname \ dpv \ @@ -237,6 +238,7 @@ .if ${MK_ELFTOOLCHAIN_TOOLS} != "no" _addr2line= addr2line +_cxxfilt= cxxfilt _elfcopy= elfcopy _nm= nm _readelf= readelf diff --git a/tools/build/mk/OptionalObsoleteFiles.inc b/tools/build/mk/OptionalObsoleteFiles.inc --- a/tools/build/mk/OptionalObsoleteFiles.inc +++ b/tools/build/mk/OptionalObsoleteFiles.inc @@ -1004,7 +1004,9 @@ .if ${MK_CXX} == no OLD_FILES+=usr/bin/CC OLD_FILES+=usr/bin/c++ +.if ${MK_ELFTOOLCHAIN_TOOLS} == no OLD_FILES+=usr/bin/c++filt +.endif OLD_FILES+=usr/bin/g++ OLD_FILES+=usr/libexec/cc1plus .if ${MK_GCC} == no diff --git a/gnu/usr.bin/cc/Makefile b/gnu/usr.bin/cc/Makefile --- a/gnu/usr.bin/cc/Makefile +++ b/gnu/usr.bin/cc/Makefile @@ -12,7 +12,10 @@ .endif .if ${MK_CXX} != "no" -SUBDIR+= cc1plus c++ c++filt +SUBDIR+= cc1plus c++ +.if ${MK_ELFTOOLCHAIN_TOOLS} != "no" +SUBDIR+= c++filt +.endif .endif .if ${MK_GCOV} != "no" EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: freebsd-toolchain --b1_e0054449863fc0ba6e9256b56bb4b064 Content-Type: text/x-patch; charset=utf-8; name="D2408.5108.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D2408.5108.patch" ZGlmZiAtLWdpdCBhL3Vzci5iaW4vY3h4ZmlsdC9NYWtlZmlsZSBiL3Vzci5iaW4vY3h4ZmlsdC9N YWtlZmlsZQpuZXcgZmlsZSBtb2RlIDEwMDY0NAotLS0gL2Rldi9udWxsCisrKyBiL3Vzci5iaW4v Y3h4ZmlsdC9NYWtlZmlsZQpAQCAtMCwwICsxLDE3IEBACisjICRGcmVlQlNEJAorCisuaW5jbHVk ZSA8c3JjLm9wdHMubWs+CisKK0VMRlRDRElSPQkkey5DVVJESVJ9Ly4uLy4uL2NvbnRyaWIvZWxm dG9vbGNoYWluCitTUkNESVI9CQkke0VMRlRDRElSfS9jeHhmaWx0CisKKy5QQVRIOiAke1NSQ0RJ Un0KKworUFJPRz0JYysrZmlsdAorU1JDUz0JY3h4ZmlsdC5jCisKK0xJQkFERD0JZWxmdGMKKwor Q0ZMQUdTKz0tSSR7RUxGVENESVJ9L2xpYmVsZnRjIC1JJHtFTEZUQ0RJUn0vY29tbW9uCisKKy5p bmNsdWRlIDxic2QucHJvZy5taz4KZGlmZiAtLWdpdCBhL3Vzci5iaW4vTWFrZWZpbGUgYi91c3Iu YmluL01ha2VmaWxlCi0tLSBhL3Vzci5iaW4vTWFrZWZpbGUKKysrIGIvdXNyLmJpbi9NYWtlZmls ZQpAQCAtMzYsNiArMzYsNyBAQAogCWNzcGxpdCBcCiAJY3Rsc3RhdCBcCiAJY3V0IFwKKwkke19j eHhmaWx0fSBcCiAJZGVtYW5kb2MgXAogCWRpcm5hbWUgXAogCWRwdiBcCkBAIC0yMzcsNiArMjM4 LDcgQEAKIAogLmlmICR7TUtfRUxGVE9PTENIQUlOX1RPT0xTfSAhPSAibm8iCiBfYWRkcjJsaW5l PQlhZGRyMmxpbmUKK19jeHhmaWx0PQljeHhmaWx0CiBfZWxmY29weT0JZWxmY29weQogX25tPQkJ bm0KIF9yZWFkZWxmPQlyZWFkZWxmCmRpZmYgLS1naXQgYS90b29scy9idWlsZC9tay9PcHRpb25h bE9ic29sZXRlRmlsZXMuaW5jIGIvdG9vbHMvYnVpbGQvbWsvT3B0aW9uYWxPYnNvbGV0ZUZpbGVz LmluYwotLS0gYS90b29scy9idWlsZC9tay9PcHRpb25hbE9ic29sZXRlRmlsZXMuaW5jCisrKyBi L3Rvb2xzL2J1aWxkL21rL09wdGlvbmFsT2Jzb2xldGVGaWxlcy5pbmMKQEAgLTEwMDQsNyArMTAw NCw5IEBACiAuaWYgJHtNS19DWFh9ID09IG5vCiBPTERfRklMRVMrPXVzci9iaW4vQ0MKIE9MRF9G SUxFUys9dXNyL2Jpbi9jKysKKy5pZiAke01LX0VMRlRPT0xDSEFJTl9UT09MU30gPT0gbm8KIE9M RF9GSUxFUys9dXNyL2Jpbi9jKytmaWx0CisuZW5kaWYKIE9MRF9GSUxFUys9dXNyL2Jpbi9nKysK IE9MRF9GSUxFUys9dXNyL2xpYmV4ZWMvY2MxcGx1cwogLmlmICR7TUtfR0NDfSA9PSBubwpkaWZm IC0tZ2l0IGEvZ251L3Vzci5iaW4vY2MvTWFrZWZpbGUgYi9nbnUvdXNyLmJpbi9jYy9NYWtlZmls ZQotLS0gYS9nbnUvdXNyLmJpbi9jYy9NYWtlZmlsZQorKysgYi9nbnUvdXNyLmJpbi9jYy9NYWtl ZmlsZQpAQCAtMTIsNyArMTIsMTAgQEAKIC5lbmRpZgogCiAuaWYgJHtNS19DWFh9ICE9ICJubyIK LVNVQkRJUis9IGNjMXBsdXMgYysrIGMrK2ZpbHQKK1NVQkRJUis9IGNjMXBsdXMgYysrCisuaWYg JHtNS19FTEZUT09MQ0hBSU5fVE9PTFN9ICE9ICJubyIKK1NVQkRJUis9IGMrK2ZpbHQKKy5lbmRp ZgogLmVuZGlmCiAKIC5pZiAke01LX0dDT1Z9ICE9ICJubyIKCg== --b1_e0054449863fc0ba6e9256b56bb4b064-- From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 30 15:42:00 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CA38EFF5 for ; Thu, 30 Apr 2015 15:42:00 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AD8431A10 for ; Thu, 30 Apr 2015 15:42:00 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3UFg0il062179 for ; Thu, 30 Apr 2015 15:42:00 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3UFg0hL062178; Thu, 30 Apr 2015 15:42:00 GMT (envelope-from daemon-user) Date: Thu, 30 Apr 2015 15:42:00 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Commented On] D2408: Add ELF Tool Chain's c++filt to the build Message-ID: X-Priority: 3 Thread-Topic: D2408: Add ELF Tool Chain's c++filt to the build X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NTlmNTU4Y2I5N2RjNDEwM2E5OWYxY2VlZTc3IFVCTUg= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2015 15:42:00 -0000 emaste added inline comments. INLINE COMMENTS gnu/usr.bin/cc/Makefile:16 Sigh, this is backwards. Will update to `== "no"` - i.e., build GCC's c++filt in the `WITHOUT_ELFTOOLCHAIN_TOOLS` case. REVISION DETAIL https://reviews.freebsd.org/D2408 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 30 15:43:40 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6A584C9 for ; Thu, 30 Apr 2015 15:43:40 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4F3B91A20 for ; Thu, 30 Apr 2015 15:43:40 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3UFhe69062345 for ; Thu, 30 Apr 2015 15:43:40 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3UFheMY062344; Thu, 30 Apr 2015 15:43:40 GMT (envelope-from daemon-user) Date: Thu, 30 Apr 2015 15:43:40 +0000 To: freebsd-toolchain@freebsd.org From: "brooks (Brooks Davis)" Subject: [Differential] [Accepted] D2408: Add ELF Tool Chain's c++filt to the build Message-ID: X-Priority: 3 Thread-Topic: D2408: Add ELF Tool Chain's c++filt to the build X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NTlmNTU4Y2I5N2RjNDEwM2E5OWYxY2VlZTc3IFVCTaw= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2015 15:43:40 -0000 brooks accepted this revision. brooks added a comment. This revision has a positive review. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D2408 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 30 16:07:43 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 49523845 for ; Thu, 30 Apr 2015 16:07:43 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2C4681CD8 for ; Thu, 30 Apr 2015 16:07:43 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3UG7h47068952 for ; Thu, 30 Apr 2015 16:07:43 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3UG7haH068951; Thu, 30 Apr 2015 16:07:43 GMT (envelope-from daemon-user) Date: Thu, 30 Apr 2015 16:07:42 +0000 To: freebsd-toolchain@freebsd.org From: "imp (Warner Losh)" Subject: [Differential] [Accepted] D2408: Add ELF Tool Chain's c++filt to the build Message-ID: <506bd06683de0aae9a9c816543ebd513@localhost.localdomain> X-Priority: 3 Thread-Topic: D2408: Add ELF Tool Chain's c++filt to the build X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NTlmNTU4Y2I5N2RjNDEwM2E5OWYxY2VlZTc3IFVCU04= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2015 16:07:43 -0000 imp added a subscriber: imp. imp accepted this revision. imp added a reviewer: imp. imp added a comment. I came to troll you for TOLO -> YOLO, but brooks beat me to it... REVISION DETAIL https://reviews.freebsd.org/D2408 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks, imp Cc: imp, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 30 21:30:41 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ABA7044B for ; Thu, 30 Apr 2015 21:30:41 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8EAAE1F5B for ; Thu, 30 Apr 2015 21:30:41 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3ULUfgn063272 for ; Thu, 30 Apr 2015 21:30:41 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3ULUf7N063271; Thu, 30 Apr 2015 21:30:41 GMT (envelope-from daemon-user) Date: Thu, 30 Apr 2015 21:30:41 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Closed] D2408: Add ELF Tool Chain's c++filt to the build Message-ID: X-Priority: 3 Thread-Topic: D2408: Add ELF Tool Chain's c++filt to the build X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NTlmNTU4Y2I5N2RjNDEwM2E5OWYxY2VlZTc3IFVCnwE= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_f63d1571da1b247d0c2c68fe11824bb5" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2015 21:30:41 -0000 --b1_f63d1571da1b247d0c2c68fe11824bb5 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit This revision was automatically updated to reflect the committed changes. Closed by commit rS282285: Add ELF Tool Chain's c++filt to the build (authored by emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2408?vs=5108&id=5123#toc REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D2408 AFFECTED FILES head/gnu/usr.bin/cc/Makefile head/tools/build/mk/OptionalObsoleteFiles.inc head/usr.bin/Makefile CHANGE DETAILS diff --git a/head/tools/build/mk/OptionalObsoleteFiles.inc b/head/tools/build/mk/OptionalObsoleteFiles.inc --- a/head/tools/build/mk/OptionalObsoleteFiles.inc +++ b/head/tools/build/mk/OptionalObsoleteFiles.inc @@ -1004,7 +1004,9 @@ .if ${MK_CXX} == no OLD_FILES+=usr/bin/CC OLD_FILES+=usr/bin/c++ +.if ${MK_ELFTOOLCHAIN_TOOLS} == no OLD_FILES+=usr/bin/c++filt +.endif OLD_FILES+=usr/bin/g++ OLD_FILES+=usr/libexec/cc1plus .if ${MK_GCC} == no diff --git a/head/gnu/usr.bin/cc/Makefile b/head/gnu/usr.bin/cc/Makefile --- a/head/gnu/usr.bin/cc/Makefile +++ b/head/gnu/usr.bin/cc/Makefile @@ -12,7 +12,10 @@ .endif .if ${MK_CXX} != "no" -SUBDIR+= cc1plus c++ c++filt +SUBDIR+= cc1plus c++ +.if ${MK_ELFTOOLCHAIN_TOOLS} == "no" +SUBDIR+= c++filt +.endif .endif .if ${MK_GCOV} != "no" diff --git a/head/usr.bin/Makefile b/head/usr.bin/Makefile --- a/head/usr.bin/Makefile +++ b/head/usr.bin/Makefile @@ -36,6 +36,7 @@ csplit \ ctlstat \ cut \ + ${_cxxfilt} \ demandoc \ dirname \ dpv \ @@ -237,6 +238,7 @@ .if ${MK_ELFTOOLCHAIN_TOOLS} != "no" _addr2line= addr2line +_cxxfilt= cxxfilt _elfcopy= elfcopy _nm= nm _readelf= readelf EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks, imp Cc: imp, freebsd-toolchain --b1_f63d1571da1b247d0c2c68fe11824bb5 Content-Type: text/x-patch; charset=utf-8; name="D2408.5123.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D2408.5123.patch" ZGlmZiAtLWdpdCBhL2hlYWQvdG9vbHMvYnVpbGQvbWsvT3B0aW9uYWxPYnNvbGV0ZUZpbGVzLmlu YyBiL2hlYWQvdG9vbHMvYnVpbGQvbWsvT3B0aW9uYWxPYnNvbGV0ZUZpbGVzLmluYwotLS0gYS9o ZWFkL3Rvb2xzL2J1aWxkL21rL09wdGlvbmFsT2Jzb2xldGVGaWxlcy5pbmMKKysrIGIvaGVhZC90 b29scy9idWlsZC9tay9PcHRpb25hbE9ic29sZXRlRmlsZXMuaW5jCkBAIC0xMDA0LDcgKzEwMDQs OSBAQAogLmlmICR7TUtfQ1hYfSA9PSBubwogT0xEX0ZJTEVTKz11c3IvYmluL0NDCiBPTERfRklM RVMrPXVzci9iaW4vYysrCisuaWYgJHtNS19FTEZUT09MQ0hBSU5fVE9PTFN9ID09IG5vCiBPTERf RklMRVMrPXVzci9iaW4vYysrZmlsdAorLmVuZGlmCiBPTERfRklMRVMrPXVzci9iaW4vZysrCiBP TERfRklMRVMrPXVzci9saWJleGVjL2NjMXBsdXMKIC5pZiAke01LX0dDQ30gPT0gbm8KZGlmZiAt LWdpdCBhL2hlYWQvZ251L3Vzci5iaW4vY2MvTWFrZWZpbGUgYi9oZWFkL2dudS91c3IuYmluL2Nj L01ha2VmaWxlCi0tLSBhL2hlYWQvZ251L3Vzci5iaW4vY2MvTWFrZWZpbGUKKysrIGIvaGVhZC9n bnUvdXNyLmJpbi9jYy9NYWtlZmlsZQpAQCAtMTIsNyArMTIsMTAgQEAKIC5lbmRpZgogCiAuaWYg JHtNS19DWFh9ICE9ICJubyIKLVNVQkRJUis9IGNjMXBsdXMgYysrIGMrK2ZpbHQKK1NVQkRJUis9 IGNjMXBsdXMgYysrCisuaWYgJHtNS19FTEZUT09MQ0hBSU5fVE9PTFN9ID09ICJubyIKK1NVQkRJ Uis9IGMrK2ZpbHQKKy5lbmRpZgogLmVuZGlmCiAKIC5pZiAke01LX0dDT1Z9ICE9ICJubyIKZGlm ZiAtLWdpdCBhL2hlYWQvdXNyLmJpbi9NYWtlZmlsZSBiL2hlYWQvdXNyLmJpbi9NYWtlZmlsZQot LS0gYS9oZWFkL3Vzci5iaW4vTWFrZWZpbGUKKysrIGIvaGVhZC91c3IuYmluL01ha2VmaWxlCkBA IC0zNiw2ICszNiw3IEBACiAJY3NwbGl0IFwKIAljdGxzdGF0IFwKIAljdXQgXAorCSR7X2N4eGZp bHR9IFwKIAlkZW1hbmRvYyBcCiAJZGlybmFtZSBcCiAJZHB2IFwKQEAgLTIzNyw2ICsyMzgsNyBA QAogCiAuaWYgJHtNS19FTEZUT09MQ0hBSU5fVE9PTFN9ICE9ICJubyIKIF9hZGRyMmxpbmU9CWFk ZHIybGluZQorX2N4eGZpbHQ9CWN4eGZpbHQKIF9lbGZjb3B5PQllbGZjb3B5CiBfbm09CQlubQog X3JlYWRlbGY9CXJlYWRlbGYKCg== --b1_f63d1571da1b247d0c2c68fe11824bb5--