From owner-freebsd-wireless@freebsd.org Sun Nov 1 21:00:18 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3D67A23E29 for ; Sun, 1 Nov 2015 21:00:18 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A74FA1D72 for ; Sun, 1 Nov 2015 21:00:18 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tA1L0IxM059015 for ; Sun, 1 Nov 2015 21:00:18 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201511012100.tA1L0IxM059015@kenobi.freebsd.org> From: bugzilla-noreply@FreeBSD.org To: freebsd-wireless@FreeBSD.org Subject: Problem reports for freebsd-wireless@FreeBSD.org that need special attention X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 Date: Sun, 01 Nov 2015 21:00:18 +0000 Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2015 21:00:18 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- Open | 154598 | [ath] Atheros 5424/2424 can't connect to WPA netw Open | 163312 | [panic] [ath] kernel panic: page fault with ath0 Open | 166190 | [ath] TX hangs and frames stuck in TX queue Open | 166357 | [ath] 802.11n TX stall when the first frame in th Open | 169362 | [ath] AR5416: radar pulse PHY errors sometimes in 5 problems total for which you should take action. From owner-freebsd-wireless@freebsd.org Mon Nov 2 19:03:11 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D40BAA24382 for ; Mon, 2 Nov 2015 19:03:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A72D21DC9 for ; Mon, 2 Nov 2015 19:03:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tA2J3BYL086915 for ; Mon, 2 Nov 2015 19:03:11 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-wireless@FreeBSD.org Subject: [Bug 204228] wlan interface cannot connect to AP if_iwm driver - Intel Dual Band Wireless AC 3160 Date: Mon, 02 Nov 2015 19:03:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: freebsd@go4more.de X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-wireless@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 19:03:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204228 Bug ID: 204228 Summary: wlan interface cannot connect to AP if_iwm driver - Intel Dual Band Wireless AC 3160 Product: Base System Version: 11.0-CURRENT Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: wireless Assignee: freebsd-wireless@FreeBSD.org Reporter: freebsd@go4more.de WLAN Driver if_iwm (Intel Dual Band Wireless AC 3160) cannot connect to AP. The driver loads correctly, I can create a wlan0 interface but when I want to connect to a WPA2 secured AP the connection fails with the error message: kernel: iwm0: mem 0xf7c00000-0xf7c01fff irq 18 at device 0.0 on pci1 kernel: iwm0: revision: 0x160, firmware 25.228 (API ver. 9) kernel: wlan0: Ethernet address: 34:e6:ad:50:55:87 wpa_supplicant[1085]: Successfully initialized wpa_supplicant wpa_supplicant[1086]: wlan0: Trying to associate with 00:15:0c:4e:9f:52 (SSID='NET.HAYAT_WLAN_01' freq=2442 MHz) kernel: iwm0: iwm_update_edca: called [...] kernel: iwm0: fatal firmware error kernel: iwm0: iwm_auth: binding cmd kernel: iwm0: iwm_newstate: could not move to auth state: 35 wpa_supplicant[1317]: wlan0: Authentication with 00:15:0c:4e:9f:52 timed out. wpa_supplicant[1317]: wlan0: CTRL-EVENT-DISCONNECTED bssid=00:15:0c:4e:9f:52 reason=3 locally_generated=1 wlan0: CTRL-EVENT-SSID-TEMP-DISABLED id=0 ssid="NET.HAYAT_WLAN_01" auth_failures=1 duration=10 reason=CONN_FAILED kernel: iwm0: could not initiate scan HW: Zotac ZBox RI323 with Intel Dual Band Wireless AC 3160 SW: FreeBDS 11-CURRENT at r290151 WLan Interface (after kldload if_iwm und wpa_supplicant start wlan0): wlan0: flags=8843 metric 0 mtu 1500 ether 34:e6:ad:50:55:87 nd6 options=29 media: IEEE 802.11 Wireless Ethernet autoselect (autoselect) status: no carrier ssid "" channel 7 (2442 MHz 11g) country US authmode WPA2/802.11i privacy ON deftxkey UNDEF txpower 0 bmiss 10 scanvalid 60 protmode CTS wme roaming MANUAL groups: wlan -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-wireless@freebsd.org Mon Nov 2 22:38:46 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDDC5A245A4 for ; Mon, 2 Nov 2015 22:38:46 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 848EB1AE4; Mon, 2 Nov 2015 22:38:46 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by ioll68 with SMTP id l68so1726849iol.3; Mon, 02 Nov 2015 14:38:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=6KGXjc5M8hEtEZc3rH7uSKRRGwahlJCYwOWzQqXUzXk=; b=p+pGTbcxDKB5jd1hJHOk3/4DxCdwBfVOlaKRsXVLBXHxlcfzSOmRRVKXc7D4G2LNkx gYFxH+Z/Bd0Yt9idB0emXocxCahIo0OZAqchByEhwvSa6w+oLPzjqYAXf9bwJvtvnNpU H90Ps5cn0qXd5ylUXJ30J3n832rUo+BXXs+T2lkN5qUEG2paQgX1S61eeJpcf6bWMm1/ 6Q5ABQCC98dhEPdhCk2+uiHcPfSMnP6wH+Uwmakr3/3SVIIkvoaWUcsTyWRhptcFmJh4 Nr8V1gfysA+zxDI38yQztIqCOidHUBL4ibF8qYfN3z4GEmdkTYXaFEFki2XvbmXMCIPv g2XQ== MIME-Version: 1.0 X-Received: by 10.107.3.72 with SMTP id 69mr24475882iod.75.1446503925970; Mon, 02 Nov 2015 14:38:45 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.46.66 with HTTP; Mon, 2 Nov 2015 14:38:45 -0800 (PST) In-Reply-To: References: <1446174922.809135.424262409.16BCE412@webmail.messagingengine.com> <1446474203.3014685.426732569.13D78488@webmail.messagingengine.com> Date: Mon, 2 Nov 2015 14:38:45 -0800 X-Google-Sender-Auth: BQAZOh1gqXYpuLuWhYizE_1Q1XM Message-ID: Subject: Re: bridge/wifi panic From: Adrian Chadd To: Andriy Voskoboinyk , "freebsd-wireless@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 22:38:46 -0000 Actually, this is more annoying than I'd thought. There's a whole bunch of places where mbufs can change during processing in ath(4) and yeah, we can't guarantee the original mbuf is available. I wonder how many other drivers are doing this - stuff like m_collapse(), m_defrag(), etc. If this is called then the original mbuf can't be returned upon error. I'm torn as to whether to back out the mbuf API change and have the driver consume it, or whether we want to go through the pain of fixing things. Let's figure this out ASAP. Thanks, -adrian On 2 November 2015 at 14:35, Adrian Chadd wrote: > Ok, yeah, I think your initial churn of ath(4) for error handling is > way incomplete, and we're going to have to fix this stuff before it > causes lots more issues in -HEAD. > > > > -a From owner-freebsd-wireless@freebsd.org Mon Nov 2 22:49:19 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9ED6BA247FA for ; Mon, 2 Nov 2015 22:49:19 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: from mail-lf0-f48.google.com (mail-lf0-f48.google.com [209.85.215.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2764E1F26; Mon, 2 Nov 2015 22:49:18 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: by lffz202 with SMTP id z202so70207839lff.3; Mon, 02 Nov 2015 14:49:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=content-type:to:subject:references:date:cc:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=9SWqWw1WPTHoPaVvIopSkIv/Ofx0/5iPMiLbZkSFq48=; b=L2wocLL7Xjb2OXcne//mfLwdYWvhtfh1Fe5VmFLFpPaVQV764mV8L0Xa2F4WznS/pe IzcuPeQz937QXzfXg/DgmNKo30OZi+HNI5F3JHPx73v/Gx61riDFwiO3Me4phUaQqq2N +d5hXJFfASBINjW4FSw2qKRlOufjCNlYjHb1ogN3ES6RiE0EJQW4+G+GOJFhiuk2X5nL 7bZZShpQ+/XhmbhGF0IfatA5J7Eg1EER5b0ktE2om7gJg0MFLr/dula/e8Qi4mki8Frn 74Cn2albwu5NiSiJkUxwnX+GoUo2PAmftRQcFEXICjfG5XFkqy3vDnegcgUAAY+VooDh 9+bQ== X-Received: by 10.112.35.196 with SMTP id k4mr11205733lbj.3.1446504550835; Mon, 02 Nov 2015 14:49:10 -0800 (PST) Received: from localhost (host-176-37-109-22.la.net.ua. [176.37.109.22]) by smtp.gmail.com with ESMTPSA id j136sm2577655lfe.38.2015.11.02.14.49.10 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 02 Nov 2015 14:49:10 -0800 (PST) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Adrian Chadd" , "freebsd-wireless@freebsd.org" Subject: Re: bridge/wifi panic References: <1446174922.809135.424262409.16BCE412@webmail.messagingengine.com> <1446474203.3014685.426732569.13D78488@webmail.messagingengine.com> Date: Tue, 03 Nov 2015 00:49:07 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Andriy Voskoboinyk" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.16 (FreeBSD) X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 22:49:19 -0000 Tue, 03 Nov 2015 00:38:45 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Adrian Chadd = : > Actually, this is more annoying than I'd thought. There's a whole > bunch of places where mbufs can change during processing in ath(4) and= > yeah, we can't guarantee the original mbuf is available. > > I wonder how many other drivers are doing this - stuff like > m_collapse(), m_defrag(), etc. If this is called then the original > mbuf can't be returned upon error. I have thinked about that few hours ago - there are many ways to fix it:= 1) add a guarantee for current m_collapse() / m_defrag() that current mbuf pointer will not change (like it works in OpenBSD); 2) implement third function with this guarantee (for backward = compatibility); 3) pass pointer to mbuf pointer via ic_raw_xmit() / ic_transmit() - then the caller can change it (that's the way I've seen in other m_collapse() consumers); 4) move m_defrag() / m_collapse() to the net80211 (to the = ieee80211_encap() ?). This will require an additional parameter, which will limit max number of segments for device. ... (something else?) *) leave it 'as is'. > > I'm torn as to whether to back out the mbuf API change and have the > driver consume it, or whether we want to go through the pain of fixing= > things. > > Let's figure this out ASAP. > > Thanks, > > > -adrian > > > On 2 November 2015 at 14:35, Adrian Chadd wrote: >> Ok, yeah, I think your initial churn of ath(4) for error handling is >> way incomplete, and we're going to have to fix this stuff before it >> causes lots more issues in -HEAD. >> >> >> >> -a From owner-freebsd-wireless@freebsd.org Mon Nov 2 23:24:36 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3BDB8A25146 for ; Mon, 2 Nov 2015 23:24:36 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x22b.google.com (mail-ig0-x22b.google.com [IPv6:2607:f8b0:4001:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EC1BD1AFA; Mon, 2 Nov 2015 23:24:35 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by igbdj2 with SMTP id dj2so1845891igb.1; Mon, 02 Nov 2015 15:24:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=2H4fX9Dep97wVEmbrWlXxxRYpCucQb7PfG/sxIDk6EY=; b=kgvkHlmBj78Q5VSKfQc2g5DOhG1brMwc6cQnsH47qNPC0r/C8DcmlW5oFrYqpJJPDr 1JNUxVjdkL5ZlUuSEQTuxwm5x7D85OlfkSaWPynn6TIMPwc81PSDODV6ghJCKIhEZq4k fsviqZ6rJzicspC5CWhYjZWGcSTMxqjMn/j6q9xEZlMPg+35R8/Wo0c0g6Gq1zV6gyek IBC/dSXQGxxq64E+b/l8gbRhiIeX7Vh99rYSJ8w0n33ir+k9v0g9otYXEjKlYPsZlndM 6W5U4c/CFKWQ+osHNiL0A3dcutGSXLsiDwHcXPeUU0mtXWEK7h+cdI+qi4NIRzIUp3gK LrRg== MIME-Version: 1.0 X-Received: by 10.50.155.41 with SMTP id vt9mr13386816igb.22.1446506675475; Mon, 02 Nov 2015 15:24:35 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.46.66 with HTTP; Mon, 2 Nov 2015 15:24:35 -0800 (PST) In-Reply-To: References: <1446174922.809135.424262409.16BCE412@webmail.messagingengine.com> <1446474203.3014685.426732569.13D78488@webmail.messagingengine.com> Date: Mon, 2 Nov 2015 15:24:35 -0800 X-Google-Sender-Auth: Z1Jvgy93EBghNntECfo4c7gu1Og Message-ID: Subject: Re: bridge/wifi panic From: Adrian Chadd To: Andriy Voskoboinyk Cc: "freebsd-wireless@freebsd.org" , Mark Felder Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 23:24:36 -0000 On 2 November 2015 at 14:49, Andriy Voskoboinyk wrote: > Tue, 03 Nov 2015 00:38:45 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Adrian Chadd > : > >> Actually, this is more annoying than I'd thought. There's a whole >> bunch of places where mbufs can change during processing in ath(4) and >> yeah, we can't guarantee the original mbuf is available. >> >> I wonder how many other drivers are doing this - stuff like >> m_collapse(), m_defrag(), etc. If this is called then the original >> mbuf can't be returned upon error. > > > I have thinked about that few hours ago - there are many ways to fix it: > > 1) add a guarantee for current m_collapse() / m_defrag() that current > mbuf pointer will not change (like it works in OpenBSD); > 2) implement third function with this guarantee (for backward > compatibility); > 3) pass pointer to mbuf pointer via ic_raw_xmit() / ic_transmit() - > then the caller can change it (that's the way I've seen in other > m_collapse() consumers); > 4) move m_defrag() / m_collapse() to the net80211 (to the ieee80211_encap= () > ?). > This will require an additional parameter, which will limit max number > of segments for device. > ... (something else?) > *) leave it 'as is'. I'm worried that there's a bunch of other places where this happens. I'm also worried about trying to modify the rest of the mbuf API right now just to fix things; I'd rather we revert things back to working state and do this work in a branch. in ath(4), the main place this gets unhappy is ath_tx_dmasetup() where it may do a defrag first, and then if the defrag succeeds but the load fails, then we're stuck with an mbuf that isn't the original one. I think the safest thing to do here is to revert it so the driver has to free the mbuf (ie, how it was.) We should sit down and figure out how to more cleanly solve this before we attempt it again. Do you have a problem with that? Any other ideas? -adrian From owner-freebsd-wireless@freebsd.org Tue Nov 3 06:17:18 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A4B5A25CE9 for ; Tue, 3 Nov 2015 06:17:18 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C25611038; Tue, 3 Nov 2015 06:17:17 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by iodd200 with SMTP id d200so9529985iod.0; Mon, 02 Nov 2015 22:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=1ZmvNF/n8mrBZXVJDdq/z8mAHiD+441a8la6JcGOz9I=; b=b84u5+4Kh9a6qwC+RNfzT9NkHKQL0o+xOFpHZOXpVr8Ip/aMoUH8xCcgaX4hiZ+oOp xGzPsmudQj8m1P4a27R1Y/LBC5U51BNdM7Qe/18+lPQnYUO0Nk0o/RpuHiUUfqnyvUgQ G8xRrkK1F8xpXQbJGa4NzScukxn9JCIJQhw8B+fbz3o9NWLCJ+ckrwMkVZ7d0MEGJ4Dp jXR3D96T4TOHp0W8v6skeHPmweJg6TrtHqwAHpVy14JlFqEWAbXsnkG8aov7am+ntlF1 56tf8Ko94RgG8KSDyQ8yB1rtI+c1oC6nzMQuTSn8A8U4yoLvbbzV0hbg1zZXfv3aUR/B ouxg== MIME-Version: 1.0 X-Received: by 10.107.152.2 with SMTP id a2mr25170798ioe.123.1446531437328; Mon, 02 Nov 2015 22:17:17 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.46.66 with HTTP; Mon, 2 Nov 2015 22:17:17 -0800 (PST) In-Reply-To: References: <1446174922.809135.424262409.16BCE412@webmail.messagingengine.com> <1446474203.3014685.426732569.13D78488@webmail.messagingengine.com> Date: Mon, 2 Nov 2015 22:17:17 -0800 X-Google-Sender-Auth: MzWrTpJO0mZaeSgzWIhcOJ5AHjA Message-ID: Subject: Re: bridge/wifi panic From: Adrian Chadd To: Andriy Voskoboinyk Cc: "freebsd-wireless@freebsd.org" , Mark Felder Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 06:17:18 -0000 Ok, I've dug into it a bit more. The root bits here were more exposed from the ifnet changes that were made, but the TL;DR is that if the driver starts to transmit the frame and fails, we can't return an error. We have to free the buffer ourselves. So for ath, and maybe iwn too, we can't return an error if we decide to start encapsulating the frame. That's the point where the mbuf may change. For something like "interface is down", "queue depth is too large", etc then we can do it. So for ath, I think I have to pick a point in the output path where we won't return the mbuf. It's likely once we call ath_tx_start() then we should consume the mbuf and return no-error. Now, the bug bug here is that ath_tx_start() actually does free the mbuf, and we .. then return failure codes. We should return OK, and consume the node reference. I'll sleep on it and see :) -adrian From owner-freebsd-wireless@freebsd.org Tue Nov 3 13:41:06 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55278A2476D for ; Tue, 3 Nov 2015 13:41:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3ACCD1E9C for ; Tue, 3 Nov 2015 13:41:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tA3Df6kg006960 for ; Tue, 3 Nov 2015 13:41:06 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-wireless@FreeBSD.org Subject: [Bug 203745] A2DP Support for Bluetooth Headphone Audio Date: Tue, 03 Nov 2015 13:41:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tony@git-pull.com X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-wireless@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 13:41:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203745 --- Comment #21 from Tony Narlock --- (In reply to Hans Petter Selasky from comment #20) I tried again on revision 3644. Continue to get the AUTOCONFIG FAILED. I'm still pretty interested in getting this working. I'm going to dig a bit more into cuse and OSS myself. Does anyone know any good overviews on that part of the codebase? -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-wireless@freebsd.org Tue Nov 3 13:52:14 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA841A24B47 for ; Tue, 3 Nov 2015 13:52:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A0E1A1452 for ; Tue, 3 Nov 2015 13:52:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tA3DqEwZ025280 for ; Tue, 3 Nov 2015 13:52:14 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-wireless@FreeBSD.org Subject: [Bug 203745] A2DP Support for Bluetooth Headphone Audio Date: Tue, 03 Nov 2015 13:52:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: hselasky@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-wireless@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 13:52:14 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203745 --- Comment #22 from Hans Petter Selasky --- Everything Bluetooth related is in backend_bt/*.[ch] -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-wireless@freebsd.org Tue Nov 3 15:31:19 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05734A2527A for ; Tue, 3 Nov 2015 15:31:19 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C8DBD1E6A; Tue, 3 Nov 2015 15:31:18 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by iofz202 with SMTP id z202so22125166iof.2; Tue, 03 Nov 2015 07:31:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=jWwNf2BrMMKeZJLQNl/Dg1weq4VYKP3Gxhdyfc5NtsA=; b=R2HddsE/Rv1zdFwmNNrwTVs3HUKxz+fi+PzL8eK2/sL5DIOUHQl2Bd20ruH7RHn97T ygbn3j8b0gRKF0bJTl4mma29EnJ55ZQAGgAuUhtMa5fzYdyPjR6vK4wyy6lPPbxWMUrH Um7BF9JKCYo3EA2n3gCDoFn/K4n3SBoSgv3BjAi2nM4i1QXRluEipSYx6M964l0PCRDi YT4QruhJEsg3bEJRlhhvM+vruUPZUR69JRXHXX03hjQlNwaaaBIr+DS0uN76BO8Gk7Cd HNl9Q9E9FSEHXFfkK3QXm3mT6hXlFEez2J3xXHVH9QEFGi3Gp8H0SwHrzfsqiwXXuE/R 0e9A== MIME-Version: 1.0 X-Received: by 10.107.152.2 with SMTP id a2mr27041152ioe.123.1446564678236; Tue, 03 Nov 2015 07:31:18 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.46.66 with HTTP; Tue, 3 Nov 2015 07:31:18 -0800 (PST) Date: Tue, 3 Nov 2015 07:31:18 -0800 X-Google-Sender-Auth: C19cE4p8_zYfrxYpiISOfg8SHG4 Message-ID: Subject: (untested) ath fix upon error From: Adrian Chadd To: "freebsd-wireless@freebsd.org" , Mark Felder Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 15:31:19 -0000 hiya, what do people think about this to fix ath(4) transmit errors: adrian@victoria:~/work/freebsd/head-embedded/src % svn diff sys/dev/ath Index: sys/dev/ath/if_ath.c =================================================================== --- sys/dev/ath/if_ath.c (revision 290048) +++ sys/dev/ath/if_ath.c (working copy) @@ -3320,6 +3320,9 @@ * * Note: if this fails, then the mbufs are freed but * not the node reference. + * + * So, we now have to free the node reference ourselves here + * and return OK up to the stack. */ next = m->m_nextpkt; if (ath_tx_start(sc, ni, bf, m)) { @@ -3336,7 +3339,14 @@ */ ath_txfrag_cleanup(sc, &frags, ni); ATH_TXBUF_UNLOCK(sc); - retval = ENOBUFS; + + /* + * XXX: And free the node/return OK; ath_tx_start() may have + * modified the buffer. We currently have no way to + * signify that the mbuf was freed but there was an error. + */ + ieee80211_node_free(ni); + retval = 0; goto finish; } .. the idea is that we can't return failure once we've called ath_tx_start(), as the mbuf needs to be consumed. So we return OK and just count an error. -adrian From owner-freebsd-wireless@freebsd.org Tue Nov 3 16:40:13 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E2F2A24508 for ; Tue, 3 Nov 2015 16:40:13 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 066D7197A; Tue, 3 Nov 2015 16:40:12 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: by lfgh9 with SMTP id h9so24598279lfg.1; Tue, 03 Nov 2015 08:40:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=content-type:to:subject:references:date:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=/7g0Ud4GguT8XUJ99szZxNi63MfyToQqUtkf2cGH0yc=; b=jsw9YB9hKuibziCOac7TF1N3G105++vp7iC88pgutpPKRI3fPR4a/Ck0ZI6HlEpYpl S7wvg1iXXtVtsoCofI3dXs3GojlpzkIaxhE/COfknOh1RBA4wtRwWrruAIgqPqbWLvS8 h0DdQM0HmSiJrKX807mMMSpuOHuB+SUBxG6tOpPks2tIpswz+fAY3S4VkjlTELRgjlAQ vJ/90B3vWu33A/8FOOpaE8QId/B/TSFQwqvmbtYiP9BJG5YYD0zzidlDkUG3hqV6l52M YwnhgUrFTh8ni+n/0cODEdoDuvJHCWdLWQQGMj701BtAWE1s8TtReebW9qVEp1bLNsHf Jaow== X-Received: by 10.112.158.98 with SMTP id wt2mr13683049lbb.33.1446567171667; Tue, 03 Nov 2015 08:12:51 -0800 (PST) Received: from localhost (host-176-37-109-22.la.net.ua. [176.37.109.22]) by smtp.gmail.com with ESMTPSA id h7sm4899506lbk.8.2015.11.03.08.12.50 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 03 Nov 2015 08:12:51 -0800 (PST) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Adrian Chadd" , "freebsd-wireless@freebsd.org" , "Mark Felder" Subject: Re: (untested) ath fix upon error References: Date: Tue, 03 Nov 2015 18:12:48 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Andriy Voskoboinyk" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.16 (FreeBSD) X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 16:40:13 -0000 Tue, 03 Nov 2015 17:31:18 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Adrian Chadd = : > hiya, > > what do people think about this to fix ath(4) transmit errors: > > adrian@victoria:~/work/freebsd/head-embedded/src % svn diff sys/dev/at= h > Index: sys/dev/ath/if_ath.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/dev/ath/if_ath.c (revision 290048) > +++ sys/dev/ath/if_ath.c (working copy) > @@ -3320,6 +3320,9 @@ > * > * Note: if this fails, then the mbufs are freed but > * not the node reference. > + * > + * So, we now have to free the node reference ourselves here > + * and return OK up to the stack. > */ > next =3D m->m_nextpkt; > if (ath_tx_start(sc, ni, bf, m)) { > @@ -3336,7 +3339,14 @@ > */ > ath_txfrag_cleanup(sc, &frags, ni); > ATH_TXBUF_UNLOCK(sc); > - retval =3D ENOBUFS; > + > + /* > + * XXX: And free the node/return OK; ath_tx_start() ma= y = > have > + * modified the buffer. We currently have no way= to > + * signify that the mbuf was freed but there was = an = > error. > + */ > + ieee80211_node_free(ni); > + retval =3D 0; > goto finish; > } > > > .. the idea is that we can't return failure once we've called > ath_tx_start(), as the mbuf needs to be consumed. So we return OK and > just count an error. > Yes, I think this (temporary?) workaround should fix the issue. > > > -adrian From owner-freebsd-wireless@freebsd.org Tue Nov 3 21:24:40 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ACA5FA24295 for ; Tue, 3 Nov 2015 21:24:40 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x22f.google.com (mail-ig0-x22f.google.com [IPv6:2607:f8b0:4001:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 707FE1EBD; Tue, 3 Nov 2015 21:24:40 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by igpw7 with SMTP id w7so90242547igp.0; Tue, 03 Nov 2015 13:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=hvAQmfncVjr9tSV/cUJpgxbBLt7xGC2izIrMghQBYdg=; b=tmgfSZ3qJvInwpBThl4okXjGGzUCWG8B/yzi+DkT7O1IVMJWr+V6mhzeHSSZNv+XFu j0t/Y/yyNaaFFSWmd/I9d4LqWkD6Mb7AwQ4gGsWsIbPGc752Jgj1KRMIxtAf5noF6Sc6 bpHrKu9j4nQNr9hOOev2J7S5qzdkcic+UdAn3J+lwUWPNICG3Tr6oE8nvr7cMGctcdDm 0u6Ga1muhIF3Jldq7qj3hsnm0P4AIeTEYp+MhlClmvni0vMOBHP219JzbwUspJoAVeya r78eHd2YoST5tAShwTtbIpVXVm1QVoIRGHsp4NzVVh7XSEZoBz9KFnd82nvAyGanVh9F PAjQ== MIME-Version: 1.0 X-Received: by 10.50.73.228 with SMTP id o4mr19764064igv.37.1446585879841; Tue, 03 Nov 2015 13:24:39 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.46.66 with HTTP; Tue, 3 Nov 2015 13:24:39 -0800 (PST) In-Reply-To: References: <1446174922.809135.424262409.16BCE412@webmail.messagingengine.com> <1446474203.3014685.426732569.13D78488@webmail.messagingengine.com> Date: Tue, 3 Nov 2015 13:24:39 -0800 X-Google-Sender-Auth: K2B1YzPQtw3-gYe61akISggdZNI Message-ID: Subject: Re: bridge/wifi panic From: Adrian Chadd To: Andriy Voskoboinyk Cc: "freebsd-wireless@freebsd.org" , Mark Felder Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 21:24:40 -0000 Ok, try updating to the latest -HEAD. I /think/ I fixed the ath(4) transmit issue. Thanks! -a From owner-freebsd-wireless@freebsd.org Wed Nov 4 18:11:50 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B194A26D18 for ; Wed, 4 Nov 2015 18:11:50 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x232.google.com (mail-ig0-x232.google.com [IPv6:2607:f8b0:4001:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 64844196B; Wed, 4 Nov 2015 18:11:50 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by igpw7 with SMTP id w7so111187937igp.0; Wed, 04 Nov 2015 10:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=zG+HV7b4EGComw4Jp4ui4kYy9ntPpfr3+mUkE5VROqw=; b=THisumX17exocqFOMyGB6m0zkeopwf4gcjo4+RgE2iB3vpgk1yymDOrgJlKfUEkjs1 y9usMdzEVDLteelS/4wH93H4Dk7GFKbowbhbSk5P3HjIUUe6WUlZO6OILN5FjLyKoYqY mmCJEqQnaXOxtBEZw0Q9IF0f7YdchHq0Wgr1LLAu4c2qAFARVHw/QSvRBqUBLzMFoJwD hmHEKsU/RSLfqSHmwFxr2CQfasKHlmd6XoZU5TDzo2x+gfZOFps6cD28KmWhXnU6IvB3 GWzV1bfvs85+7duHqt/nUG63xH21VBuJB1/BdrZY35r+1Q+JoJ5X8JBrQpHimY3DNBhz A38g== MIME-Version: 1.0 X-Received: by 10.50.62.104 with SMTP id x8mr4603129igr.22.1446660709887; Wed, 04 Nov 2015 10:11:49 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.46.66 with HTTP; Wed, 4 Nov 2015 10:11:49 -0800 (PST) In-Reply-To: References: Date: Wed, 4 Nov 2015 10:11:49 -0800 X-Google-Sender-Auth: -J4DAQTaSIaELpOsr4rDc6CL18k Message-ID: Subject: Re: (untested) ath fix upon error From: Adrian Chadd To: Andriy Voskoboinyk Cc: "freebsd-wireless@freebsd.org" , Mark Felder Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 18:11:50 -0000 On 3 November 2015 at 08:12, Andriy Voskoboinyk wrote: > Tue, 03 Nov 2015 17:31:18 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Adrian Chadd > : > > >> hiya, >> >> what do people think about this to fix ath(4) transmit errors: >> >> adrian@victoria:~/work/freebsd/head-embedded/src % svn diff sys/dev/ath >> Index: sys/dev/ath/if_ath.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- sys/dev/ath/if_ath.c (revision 290048) >> +++ sys/dev/ath/if_ath.c (working copy) >> @@ -3320,6 +3320,9 @@ >> * >> * Note: if this fails, then the mbufs are freed but >> * not the node reference. >> + * >> + * So, we now have to free the node reference ourselves here >> + * and return OK up to the stack. >> */ >> next =3D m->m_nextpkt; >> if (ath_tx_start(sc, ni, bf, m)) { >> @@ -3336,7 +3339,14 @@ >> */ >> ath_txfrag_cleanup(sc, &frags, ni); >> ATH_TXBUF_UNLOCK(sc); >> - retval =3D ENOBUFS; >> + >> + /* >> + * XXX: And free the node/return OK; ath_tx_start() may >> have >> + * modified the buffer. We currently have no way t= o >> + * signify that the mbuf was freed but there was an >> error. >> + */ >> + ieee80211_node_free(ni); >> + retval =3D 0; >> goto finish; >> } >> >> >> .. the idea is that we can't return failure once we've called >> ath_tx_start(), as the mbuf needs to be consumed. So we return OK and >> just count an error. >> > > Yes, I think this (temporary?) workaround should fix the issue. > Cool, thanks! -a From owner-freebsd-wireless@freebsd.org Wed Nov 4 18:18:31 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E6C52A26DD2 for ; Wed, 4 Nov 2015 18:18:30 +0000 (UTC) (envelope-from feld@FreeBSD.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BB4E61B30 for ; Wed, 4 Nov 2015 18:18:30 +0000 (UTC) (envelope-from feld@FreeBSD.org) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 6557C20479 for ; Wed, 4 Nov 2015 13:18:29 -0500 (EST) Received: from web3 ([10.202.2.213]) by compute2.internal (MEProxy); Wed, 04 Nov 2015 13:18:29 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=9MGSK4t1NrKt5ii tI0jDVII5S2s=; b=AM9z1PftbGxWfHFju+DIYjS/Jimik83sc3mak3haU5WfXIE +2AbhA4fMCtkr5O6AoO+CtUT/1aFxg2YaXiIY1yhfG9vk14OBPSpqAL7PQhhKPLv J+SvfvT0mZMWn4Zwiwm1I1HYS8k/khgYOkZKm7/q0fI0qJ4u7Mw9AV6aGzTk= Received: by web3.nyi.internal (Postfix, from userid 99) id 3CCBF10B363; Wed, 4 Nov 2015 13:18:29 -0500 (EST) Message-Id: <1446661109.2248371.429186785.7A1E02D8@webmail.messagingengine.com> X-Sasl-Enc: N1jiOZbLCzjOEEDCcooZkVvZQbaiWxn5SYXmenbWP/RQ 1446661109 From: Mark Felder To: Adrian Chadd , Andriy Voskoboinyk Cc: freebsd-wireless@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-341322f1 In-Reply-To: References: Subject: Re: (untested) ath fix upon error Date: Wed, 04 Nov 2015 12:18:29 -0600 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 18:18:31 -0000 On Wed, Nov 4, 2015, at 12:11, Adrian Chadd wrote: > On 3 November 2015 at 08:12, Andriy Voskoboinyk wrote: > > Tue, 03 Nov 2015 17:31:18 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0= =D0=BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Adrian Chadd > > : > > > > > >> hiya, > >> > >> what do people think about this to fix ath(4) transmit errors: > >> > >> adrian@victoria:~/work/freebsd/head-embedded/src % svn diff sys/dev/ath > >> Index: sys/dev/ath/if_ath.c > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> --- sys/dev/ath/if_ath.c (revision 290048) > >> +++ sys/dev/ath/if_ath.c (working copy) > >> @@ -3320,6 +3320,9 @@ > >> * > >> * Note: if this fails, then the mbufs are freed but > >> * not the node reference. > >> + * > >> + * So, we now have to free the node reference ourselves here > >> + * and return OK up to the stack. > >> */ > >> next =3D m->m_nextpkt; > >> if (ath_tx_start(sc, ni, bf, m)) { > >> @@ -3336,7 +3339,14 @@ > >> */ > >> ath_txfrag_cleanup(sc, &frags, ni); > >> ATH_TXBUF_UNLOCK(sc); > >> - retval =3D ENOBUFS; > >> + > >> + /* > >> + * XXX: And free the node/return OK; ath_tx_start() may > >> have > >> + * modified the buffer. We currently have no way= to > >> + * signify that the mbuf was freed but there was = an > >> error. > >> + */ > >> + ieee80211_node_free(ni); > >> + retval =3D 0; > >> goto finish; > >> } > >> > >> > >> .. the idea is that we can't return failure once we've called > >> ath_tx_start(), as the mbuf needs to be consumed. So we return OK and > >> just count an error. > >> > > > > Yes, I think this (temporary?) workaround should fix the issue. > > >=20 > Cool, thanks! >=20 >=20 > -a I'm running it... if I can manage a few days uptime it has worked. --=20 Mark Felder ports-secteam member feld@FreeBSD.org From owner-freebsd-wireless@freebsd.org Fri Nov 6 01:25:23 2015 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 059FCA26559 for ; Fri, 6 Nov 2015 01:25:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DB5D41C45 for ; Fri, 6 Nov 2015 01:25:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tA61PMEG042736 for ; Fri, 6 Nov 2015 01:25:22 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-wireless@FreeBSD.org Subject: [Bug 203105] [new driver] Port openbsd rtwn, new rtl8188ce driver Date: Fri, 06 Nov 2015 01:25:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: Alex.R.Laurie@gmail.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-wireless@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2015 01:25:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203105 Alex.R.Laurie@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Alex.R.Laurie@gmail.com --- Comment #11 from Alex.R.Laurie@gmail.com --- I have a Lenovo SL510 with a rtl8188CE. Currently running OpenBSD-Current on it and the driver is working well. I'd be happy to test on FreeBSD. -- You are receiving this mail because: You are the assignee for the bug.