From owner-freebsd-xen@freebsd.org Sun Jul 19 15:58:33 2015 Return-Path: Delivered-To: freebsd-xen@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 335069A5CFB for ; Sun, 19 Jul 2015 15:58:33 +0000 (UTC) (envelope-from gnn@freebsd.org) Received: from smtp.hungerhost.com (smtp.hungerhost.com [216.38.53.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 58B391255; Sun, 19 Jul 2015 15:58:32 +0000 (UTC) (envelope-from gnn@freebsd.org) Received: from cpe-74-73-224-71.nyc.res.rr.com ([74.73.224.71]:52233 helo=[192.168.0.8]) by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85) (envelope-from ) id 1ZGqz1-0006q5-Ey; Sun, 19 Jul 2015 11:58:31 -0400 From: "George Neville-Neil" To: "Colin Percival" Cc: "Kristof Provost" , "Mark Felder" , freebsd-xen@freebsd.org Subject: Re: Networking under Xen Date: Sun, 19 Jul 2015 11:58:20 -0400 Message-ID: <55D3D012-140C-4230-8F23-5975D1A5CACD@freebsd.org> In-Reply-To: <55A611B1.6000000@freebsd.org> References: <4E7B7075-4E0D-4EA7-9F5D-6D252CFBD487@gmail.com> <1436890526.3162974.323521249.6B73E6E2@webmail.messagingengine.com> <55A55AE8.4090101@freebsd.org> <1436901780.3211878.323698017.360F8D73@webmail.messagingengine.com> <20F2398D-ECDF-4CF4-966D-18C894779C4C@FreeBSD.org> <55A611B1.6000000@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: MailMate (1.9.2r5107) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - freebsd.org X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2015 15:58:33 -0000 On 15 Jul 2015, at 3:54, Colin Percival wrote: > On 07/15/15 00:44, Kristof Provost wrote: >>> On 14 Jul 2015, at 21:23, Mark Felder wrote: >>> On Tue, Jul 14, 2015, at 13:54, Colin Percival wrote: >>>> More precisely *pf* is a known issue. It's inserting TCP checksums >>>> into TSO packets. I reported this a long time ago and I don't know >>>> why pf still hasn't been fixed. >>> >>> I think Kristof may have solved this in HEAD with all of the care >>> and >>> feeding he has been doing to pf, but I haven't verified. >> >> I wouldn’t expect so. As far as I know I’ve not fixed anything >> TSO or >> checksum related. > > In my tests, deleting these lines from pf_ioctl.c > > 3570 /* We need a proper CSUM befor we start (s. OpenBSD ip_output) */ > 3571 if ((*m)->m_pkthdr.csum_flags & CSUM_DELAY_DATA) { > 3572 in_delayed_cksum(*m); > 3573 (*m)->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA; > 3574 } > > unbreaks pf+TSO on EC2 instances. I'm not entirely sure why these > lines > are there in the first place, which is why I didn't want to simply go > in > and remove them -- but it may be that wrapping those lines in > something > like "if ((csum_flags & CSUM_TSO) == 0)" would solve the problem > without > breaking anything else. > Since Kristof is already working on this, I'll let him address it. If necessary open a PR on this specifically please. Best, George