From owner-svn-src-all@FreeBSD.ORG Sun Apr 19 00:01:25 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0F85B83A for ; Sun, 19 Apr 2015 00:01:25 +0000 (UTC) Received: from nm24-vm0.bullet.mail.bf1.yahoo.com (nm24-vm0.bullet.mail.bf1.yahoo.com [98.139.213.161]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B1306695 for ; Sun, 19 Apr 2015 00:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1429401677; bh=vAk6qO/z4o0BXp376Ves/9fLOX2/3vGU1nFuDuUHMBk=; h=Date:From:To:Subject:References:In-Reply-To:From:Subject; b=HxexhSSoHe7MdNOvo9/I1+0kZxvyqxFixNoIjDMqI5OomKuDpOcQls+QX2/Nll+it/aI9YLYCOK7uadP2GBCf1+8nJ60U2uHaoSuq0zGNqHEWs4Lvl2cvl4s2dZPuUzBpV5T4LiM98lno0MW68E8syNSMUIqlHzRjOTWmRJk+EDgTblqGAtu8uJ7ceXsQVQ9hSoo9qOK6Go56JqJIyNB3JWBt6rTNltJo7ij3gX2fZ2vK8sInZrah9TwZUkGiwAJ5w7IAeTqabh8/7N3iWPNHzlOxkTBjHjLpS85Yh4GAQ7LxQImz+8+1MHcwjxaX8ds//wLtaq2EvqC6DFTgqacgA== Received: from [98.139.215.140] by nm24.bullet.mail.bf1.yahoo.com with NNFMP; 19 Apr 2015 00:01:17 -0000 Received: from [98.139.211.207] by tm11.bullet.mail.bf1.yahoo.com with NNFMP; 19 Apr 2015 00:01:17 -0000 Received: from [127.0.0.1] by smtp216.mail.bf1.yahoo.com with NNFMP; 19 Apr 2015 00:01:17 -0000 X-Yahoo-Newman-Id: 155474.87340.bm@smtp216.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 5ObfdfEVM1k2By6rXJLAmqajUKU4aiweXqycBrVqk9kFQQg .msmNOJKf8gNlGazxDfaeymlF1.DZ2lL4fSp4SLdntzaA3s43PXHBSvPtZ2A h6VZgUbdQfBccf90VtvMqclzKJXlqOf.gHaz9nwx3oJPL3cXIJO8jambMyfR Yoa6B7p7NdlKBuVLBM.8jsbr.z_zq_51A_QuGSgPRbrGurSEOfosKH2qtQHl tCbxa5L53c1iMTzGrskn87PJNJbtDjidVuQIU0eDFHH2KU.L5d0e851bIdFT rWpSL2ygEOnCF85NKGuggONy_AJ0Cuk.PIkZ7cHPsncSnF2lt4sqiGMxTvOL Zf2oJK7iBHi7xL_u1mLHgE0VW_0rjevlE4Eonqvez0_2eac0qqgLjYckDzJ. Xc4ezp2VLeeLEuO_axmr11xdxQ6E3ZUGUGsXGY7tD_wZC8t38Ohe9NlCJ3Sg 9oiIpp87xYalKqa9h1Ye9BZDmut7h1QB1hVubtBuCj8lIW8FZQJxTPoFa.VI kSbD_GQEA4jWB9Xbp4umk_t6qMA.s3SJA X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <5532F05B.2070204@FreeBSD.org> Date: Sat, 18 Apr 2015 19:01:31 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r281719 - head/bin/ed References: <201504182356.t3INu4HD008807@svn.freebsd.org> In-Reply-To: <201504182356.t3INu4HD008807@svn.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2015 00:01:25 -0000 Oh yes ... On 04/18/15 18:56, Eitan Adler wrote: > Author: eadler > Date: Sat Apr 18 23:56:04 2015 > New Revision: 281719 > URL: https://svnweb.freebsd.org/changeset/base/281719 > > Log: > bin/ed: use correct type in multiplication > The result is line_t** so the multiplication should be size * > sizeof(line_t*) > > MFC After: 1 month > > Modified: > head/bin/ed/glbl.c > > Modified: head/bin/ed/glbl.c > ============================================================================== > --- head/bin/ed/glbl.c Sat Apr 18 23:49:57 2015 (r281718) > +++ head/bin/ed/glbl.c Sat Apr 18 23:56:04 2015 (r281719) > @@ -153,7 +153,7 @@ set_active_node(line_t *lp) > if (active_list != NULL) { > #endif > if ((ts = (line_t **) realloc(active_list, > - (ti += MINBUFSZ) * sizeof(line_t **))) == NULL) { > + (ti += MINBUFSZ) * sizeof(line_t *))) == NULL) { > fprintf(stderr, "%s\n", strerror(errno)); > errmsg = "out of memory"; > SPL0(); > Found by: clang static checker http://scan.freebsd.org/scan-build/bin/2015-04-18-amd64/report-9ba1bb.html#EndPath ;) Thanks, Pedro.