From owner-svn-src-head@freebsd.org Sun Dec 13 00:41:57 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8C4D4A4114C for ; Sun, 13 Dec 2015 00:41:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ABE5181A for ; Sun, 13 Dec 2015 00:41:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by qkfb125 with SMTP id b125so90713936qkf.2 for ; Sat, 12 Dec 2015 16:41:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=cccyQ15Yp+jbPPTctJH8DS5Armc+45mrCE1dVnbxu8c=; b=IQCPkXvOS3cscUj1mr0hsUkJlqu4wPFSLY6Ym4dGQmRcgOr/xun2dJpG4JxGbcWMcj Zvysuhno7jxLLJq12kBXtu2eAh38nHMMIavq5e95ALRFHk4xytw8prx66CfdfxXwx17Y fwfKt0Zl0dxc4DbwUrWwz0tSCuEOKgqcFdPLgx+kw/y8utXWSIRkDRstkBh1ZrMuO/aK ZyPXJcMDtU1rfnVsocq/RtEWgAZxnXVYOHaWZlqAN6Klv7LtiVnaOw7b4pToHJePSuo0 VTwyDM5uNKB8xTcFs0XO4A9AbvUdYNXms0FRZv+0+0s54/5Gm6ktSfq6bKQtMbeBmhWQ QQRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=cccyQ15Yp+jbPPTctJH8DS5Armc+45mrCE1dVnbxu8c=; b=iM5k2SAswhTJJIeOdp3Clg4WiL+C4NS6/FrGt4fCBL9wyOSyHUgCKwPj1ezqvjzGTg pLL3UTt7iDqopYmt+2rMM/EXLSMGoGSClwgSksF/FaOa6dtsYK3DWilNiyM56rcpJAil MpM/ficlkH03mZpYZOuplu1eXi7cG8KpQHziI3tXUbZCm0vIOtVV9kUP1Yh50xdRq+DG NYowfWqjBWApgvSm+UwznvA3/bZrNIAGyqZgqmKF7nfrCzvmi8tCJmadBf7HC++zO9Tm Ste1Fi/RjhzJ1k7ykD2rjuLLEMhQh/20bTuIoyQUWHKNHSlHvc8kHAAbxbjOYO239//J p8Ww== X-Gm-Message-State: ALoCoQldQ5pcBE7OFT7RgTQ1ZyxjDM2MqaOjKHIrGBvvTsaX6XEWWyVhjOYPP7tvNsQRbhNzF/mQGvbmULPVcu1J8kmFgGvJHg== MIME-Version: 1.0 X-Received: by 10.55.207.73 with SMTP id e70mr32915980qkj.77.1449967315352; Sat, 12 Dec 2015 16:41:55 -0800 (PST) Sender: wlosh@bsdimp.com Received: by 10.140.27.181 with HTTP; Sat, 12 Dec 2015 16:41:55 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: <4D007463-F8E5-4092-9FA4-0396E0A1444D@shxd.cx> References: <201512070402.tB742V3Z081964@repo.freebsd.org> <4D007463-F8E5-4092-9FA4-0396E0A1444D@shxd.cx> Date: Sat, 12 Dec 2015 17:41:55 -0700 X-Google-Sender-Auth: 91L_Gr31HxPCcabYZq8O1hmWiQ0 Message-ID: Subject: Re: svn commit: r291913 - head/tools/tools/nanobsd From: Warner Losh To: Devin Teske Cc: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= , Warner Losh , src-committers , svn-src-all , svn-src-head , Devin Teske Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Dec 2015 00:41:57 -0000 On Sat, Dec 12, 2015 at 8:27 AM, Devin Teske wrote: > > > On Dec 11, 2015, at 11:55 PM, Olivier Cochard-Labb=C3=A9 > wrote: > > On Mon, Dec 7, 2015 at 5:02 AM, Warner Losh wrote: > >> Author: imp >> Date: Mon Dec 7 04:02:31 2015 >> New Revision: 291913 >> URL: https://svnweb.freebsd.org/changeset/base/291913 >> >> Log: >> Generally use shorter, more idiomatic sh expressions in a bunch of >> places. >> >> Modified: >> head/tools/tools/nanobsd/defaults.sh (contents, props changed) >> > > > =E2=80=8BHi, > > I beleive there is a tipo here : > =E2=80=8B > > >> >> Modified: head/tools/tools/nanobsd/defaults.sh >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/tools/tools/nanobsd/defaults.sh Mon Dec 7 04:02:19 2015 >> (r291912) >> +++ head/tools/tools/nanobsd/defaults.sh Mon Dec 7 04:02:31 2015 >> (r291913) >> >> ####################################################################### >> @@ -949,21 +949,21 @@ export_var ( ) { # Don't wawnt a subshe >> # Call this function to set defaults _after_ parsing options. >> # dont want a subshell otherwise variable setting is thrown away. >> set_defaults_and_export ( ) { >> - test -n "${NANO_OBJ}" || NANO_OBJ=3D/usr/obj/nanobsd.${NANO_NAME= } >> - test -n "${MAKEOBJDIRPREFIX}" || MAKEOBJDIRPREFIX=3D${NANO_OBJ} >> - test -n "${NANO_DISKIMGDIR}" || NANO_DISKIMGDIR=3D${NANO_OBJ} >> + : ${NANO_OBJ:=3D/usr/obj/nanobsd.${NANO_NAME}} >> + : ${MAKEOBJDIRPREFIX:=3D${NANO_OBJ}} >> + : ${NANO_DISKIMGDIR=3D:${NANO_OBJ}} >> NANO_WORLDDIR=3D${NANO_OBJ}/_.w >> NANO_MAKE_CONF_BUILD=3D${MAKEOBJDIRPREFIX}/make.conf.build >> NANO_MAKE_CONF_INSTALL=3D${NANO_OBJ}/make.conf.install >> >> > > > =E2=80=8BNotice the line: > : ${NANO_DISKIMGDIR=3D:${NANO_OBJ}} > > > Author meant ":=3D" instead of "=3D:" > Correct. It should be fixed now. Warner