From owner-svn-src-user@freebsd.org Sun Oct 18 00:04:30 2015 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E4223A17572 for ; Sun, 18 Oct 2015 00:04:30 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B35561A57 for ; Sun, 18 Oct 2015 00:04:30 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by pabws5 with SMTP id ws5so2284181pab.2 for ; Sat, 17 Oct 2015 17:04:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=8N+YviqLD5mjUGG/w1UxQvaci+efdUskHo0vHFhKPj8=; b=Jfl1nHyvApiaNAegb6uULZ/dJ+mzFnIfQyUz1lNW1ew6PyzKGuxh+RNhZf9iJghYEi 5RmnUsi+myqWpiaSLhoDpe8plM4VuSigEcwqWl5wL7rw2IJQ0eZ7N4WROqowPJQCVDrq H/h4VRWkeH23BM+BG0hbcMkQdaZIjOh8uPSpgx0boP7vu8W3vUqsSUaLa87LN9rykEjF unCVkZFkXzxTrGMZG3gFG5aB5QJvwmEVNHybKCujMEnFrwsQFZXyW5jhRQQTVc8cVKHQ wmnZu/93eldM9KuH6YN5uGdYBr7YPz8tCw0wUGxjeqq5uo62bHhgjdMMIyJBP1Ls4BrC 9Tng== X-Gm-Message-State: ALoCoQkMrGWEBWI9ErwSJ6HHIxBI0yRS9YZef71p1pIcX+b+iXATXycRBw0HA5Ug8rsgUHQPYMJO X-Received: by 10.68.134.170 with SMTP id pl10mr25623446pbb.35.1445126670014; Sat, 17 Oct 2015 17:04:30 -0700 (PDT) Received: from ip-100-127-128-53.ec2.internal ([69.53.245.5]) by smtp.gmail.com with ESMTPSA id pf7sm28517228pbc.6.2015.10.17.17.04.28 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 17 Oct 2015 17:04:29 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r289471 - in user/ngie/bug203673: bin/df bin/ls bin/ps lib/libxo lib/libxo/tests lib/libxo/tests/encoder libexec/ftpd sbin/savecore share/mk usr.bin/iscsictl usr.bin/netstat usr.bin/pro... Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Content-Type: multipart/signed; boundary="Apple-Mail=_77FDA87D-E3D3-4DE0-AE7D-E3650F5C2615"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5.2 From: Warner Losh In-Reply-To: <5622D517.5000606@FreeBSD.org> Date: Sat, 17 Oct 2015 18:04:27 -0600 Cc: NGie Cooper , Garrett Cooper , src-committers@freebsd.org, svn-src-user@freebsd.org Message-Id: References: <201510172138.t9HLcwiF095174@repo.freebsd.org> <5622D147.7050701@FreeBSD.org> <542455B8-3355-497A-B667-AF72C197B9A4@gmail.com> <5622D243.5020603@FreeBSD.org> <5622D517.5000606@FreeBSD.org> To: Bryan Drewery X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Oct 2015 00:04:31 -0000 --Apple-Mail=_77FDA87D-E3D3-4DE0-AE7D-E3650F5C2615 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 17, 2015, at 5:09 PM, Bryan Drewery = wrote: >=20 > On 10/17/15 4:04 PM, NGie Cooper wrote: >>=20 >>> On Oct 17, 2015, at 15:57, Bryan Drewery = wrote: >>>=20 >>> On 10/17/15 3:56 PM, NGie Cooper wrote: >>>>=20 >>>>> On Oct 17, 2015, at 15:52, Bryan Drewery = wrote: >>>>>=20 >>>>> On 10/17/15 2:38 PM, Garrett Cooper wrote: >>>>>> -LIBADD=3D xo util >>>>>> +LIBADD=3D util xo >>>>>=20 >>>>> Woops! >>>>=20 >>>> It=E2=80=99s intentional. I sorted the lists alphabetically and in = doing so also made it more apparent that libxo isn=E2=80=99t the one = pull in libutil by accident :) (someone went and added libxo before = libutil everywhere so it was hard to know who needed libutil as a first = order dependency instead of as a side-effect of libxo). >>>>=20 >>>> I=E2=80=99ll change the final commit message to reflect that. >>>>=20 >>>> Thanks for the pointers earlier :). >>>>=20 >>>=20 >>> Do keep in mind that ordering can be significant for linking. >>=20 >> How? As far as the final object size, the time it takes to link the = objects, ...? >>=20 >=20 > If two libraries provide the same symbols. For example r265003. Easily > sen with libmd and libcrypto too if I remember right. Also consider libA and libB. Lib B calls something in lib A. If nothing = in the main program calls it, and it is in its own .o, then that .o = won=E2=80=99t get pulled in from the .a, so the symbol won=E2=80=99t get = resolved. This is very definitely true for static libraries. The rules = for dynamic are different, but then Bryan=E2=80=99s example applies. Order matters. Don=E2=80=99t alphabetize just for =E2=80=9Cneatness=E2=80=9D= sake. Warner --Apple-Mail=_77FDA87D-E3D3-4DE0-AE7D-E3650F5C2615 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWIuILAAoJEGwc0Sh9sBEAqKcP+wXoAPhJkPUQ9fw1JhnUpi1U +LgQUOBE6NsAPnwwcn0kvHWC1qPaYQFpHNOVnXZN/o6RitKxBRivOvesHa+/gPKG vQ99zzBjxj3dEnVzsDadFjvwOKB1qHMwO/Sko/S4i65veXndIcqa/22H7SQgsHdl +suUTuieCRst9U9sVC7zbJgCWRLbgu/dDkNr+2WLupdCWm30kyiF1jvT6dzxISsw HCgW6AoWsZKPq10ZJ1X8MHRXjFSZaigQZZ1w6qBY9kLyMvt3Mlm6Vrlxdrop1S8u dD7uWp1Jq4u57rWnQC46nNAzqmz0Z98IBmAtOMUk1gEIipeYpvPKwh053Pb9fcgB 9JUX9fEZPJNHW/s0XO0r5FdnJa17/TKL3KXigzlHuTCevdBsGogcoj87LIgx8HhV 3ZRcqptWuLv7aR+AK0Tnke/rJ24aZO7WTKqN2ef1i2LGu44B5bXTonZwftNclArv JNvDTrKdXTFOiBrnd+IFZLLzLfutIZkxHDxVjK4mPGS+QUrrF6NY2ZLztbttfZTE Rv0GFfETvmNQVYoiPBF/j4JIV9F3mNFN7SB1Lv4nha1pou3oSI60yWO6/G3wZqYU RUumx0eMPKOPiXGJJkfkJWj81nflC2XG7bxTefIou/RVNNnQ5q5EUhggSLcC+auM hdy+dgWcE3woWqkm5N28 =89MV -----END PGP SIGNATURE----- --Apple-Mail=_77FDA87D-E3D3-4DE0-AE7D-E3650F5C2615--