From owner-freebsd-arch@freebsd.org Sun Oct 2 00:24:33 2016 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7833A9D95F for ; Sun, 2 Oct 2016 00:24:33 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7EAB21F9F; Sun, 2 Oct 2016 00:24:33 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-it0-x244.google.com with SMTP id 184so4314180ity.0; Sat, 01 Oct 2016 17:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=G0wBPBSeDGTNHH4HTbxRdd2QKTZqdR2MRRlQYjfJzd4=; b=TkEmZ5YlACmUjo96FjCRU0pL2bpNOW1aUHMqLyrkNnlENeC8B/2Hp6VEIutKcnHZcY T9pRYF4vhI1uJZ1dC3FtcmWYmoWiwbHKCwWn6GUQ2/sFexlSOnwbiVu35bsDjkveOVM/ NjvAn88VyAxAsQYgMZkXjRVYZ3crs8X7sRnRwgB0iHptQavevYfnrgTfz4Al1UITSt9Z WS5c/Yj6iO+nph9oH6J6HiMABUtVvORf732scYhj4t+xKRJVPObFwOvfsFouOqX8EGWb dQvflmVGugn+0skRT5AhiuzkXe+jyQisl3LNU8TkTMIV+Kfrw/9siHNOfdWdDT3PZL85 PZ0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=G0wBPBSeDGTNHH4HTbxRdd2QKTZqdR2MRRlQYjfJzd4=; b=NVv/z77QQDSo7/eM+6L0m0xM49XmGu7qo7kkCVdSnbCTCbWsQ58alkzJEka/oHwluQ OlE1GO5xmOajMQBfzUjH5+MILGuGhm7MSYhK0ZyCfOZpHvurGU6rFOaNbKXjXtJ68K1P 7rD/h0jWDULWY+iz094x+/ehRCvPAiQ6nT3d2AUeXyZf0u87hctOHAaRaghvHIape2z1 02ZGSFaqrHdn1X4Q14mAoooqg1vS8+kwGIRLsN6YglZO75MCNS3IUZHkNxVIjYJqgC35 wzyUcatKh293YDJNgMxtoGcicYy6E7QCWxc3V7GrJXZcbunwIOKpwpHF6U5BNclJYSnN UTeg== X-Gm-Message-State: AA6/9RmB5bHRf90+CXRmhWvKM7OaJasjlXxcSsHiFBRvarmBBOYZ08RcFNZQrnHuExFvHw== X-Received: by 10.36.9.67 with SMTP id 64mr11145103itm.96.1475367873049; Sat, 01 Oct 2016 17:24:33 -0700 (PDT) Received: from [22.66.114.211] ([172.56.13.206]) by smtp.gmail.com with ESMTPSA id e79sm10523398iod.4.2016.10.01.17.24.32 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 01 Oct 2016 17:24:32 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Ngie Cooper Mime-Version: 1.0 (1.0) Subject: Re: mq on kqueue broken after upgrade to FreeBSD 11 Date: Sun, 2 Oct 2016 09:23:43 +0900 Message-Id: <675F9A5B-BC2D-4F02-A160-74924327CC7B@gmail.com> References: <8A6CD0D3-C4D5-40DF-B2AD-4C454CC88AD1@perftech.com> <20160930094544.GP38409@kib.kiev.ua> <19A6EEAA-C68E-4DAD-B98F-4D904734BD8B@perftech.com> <20160930152006.GS38409@kib.kiev.ua> <20160930184418.1047afc2@kan> <20161001092515.GW38409@kib.kiev.ua> Cc: Alexander Kabaev , Lewis Donzis , deischen@freebsd.org, freebsd-arch@freebsd.org In-Reply-To: <20161001092515.GW38409@kib.kiev.ua> To: Konstantin Belousov X-Mailer: iPhone Mail (13G36) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Oct 2016 00:24:33 -0000 > On Oct 1, 2016, at 18:25, Konstantin Belousov wrote: > >> On Fri, Sep 30, 2016 at 06:44:18PM -0400, Alexander Kabaev wrote: >> No objection, but possible suggestion: if the primary use of this >> symbol is for tests and nothing else, maybe it does belong in >> FBSDprivate_1.0 FBSDprivate_1.0 section instead? > > Good question. The symbols are useful for real-world code, not only for > the tests. But I think that we should mark symbol as non-portable. Usual > approach of adding _np suffix seems to be the right thing to do there. > > What about the following ? The change proposed below looks good to me, at first glance :).. Thank you for proposing/doing this! -Ngie