From owner-freebsd-fs@freebsd.org Sun Jul 10 04:51:51 2016 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32FB9B84A74 for ; Sun, 10 Jul 2016 04:51:51 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EC5411C82; Sun, 10 Jul 2016 04:51:50 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: by mail-it0-x244.google.com with SMTP id d65so237428ith.0; Sat, 09 Jul 2016 21:51:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=u2wZ+b12+5VoR331xSKqZanrr/MnZSIPSZM8BhR4WXA=; b=ruPPw75TEMyaRSspjxn+AUq4/WISvx+EiYy+UJ0vDMtl2frYmtTo4sbbuujuWeUiqx fh2B0hJ4yv6ep8NOgwc3ShxvSqjZgXhW0o+l+/8knY7jVu/qZYxWt1q+DVBRlj0Wo3QN 3ObNPMWr4fGqBdmMtt2DzguhD8Ei/+G70iCgM3tbYci00hu1Tu54k661XlQf4sMbONVe K4rw9wbV3RCMDk9v7fRV9QMMVWNoeMx5qOcWxrI/einxTOYf2TA0Xwgfys1paZqRYfV8 zu23Ou2tk+GRSC4nngkl/3wPzU+lnKF3XWVX3m0/q5nmMpEkvFNAcPUz/A9a6E74r5Tn Gcyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=u2wZ+b12+5VoR331xSKqZanrr/MnZSIPSZM8BhR4WXA=; b=FRCfe09IahFzVaypY+tGpLS9TYP/JqEwjOCjWqd6EiJmASSIoC4v/+deVtqnGHO3C8 3B9gf5oKU8M0OY4mWBhEy1KLdLIf1w1pZ2h5EleKJ7NOwOYVUud5C+HfETfKE6RoL74k 9yj7aaMXiqdPpEhDyc25dymJV2obCeIJUGgzCpvSrSZ6dMS8STGOqxCoGmjwjIns3c61 n1NGLdx4NCgJoVQvU9y3HbC8UkPjA4r+rKjJVHvrVI778x7SZ6cTgOEBtajTWon0Mhgo 1NJJNVDpaNK1lIl6mKBOOOUo9KLAQoOWW4L9NHlh1WAxdXMLiKCT1TYMggOKsoKi/g7i 6nwA== X-Gm-Message-State: ALyK8tJN5mPa46I/d7SkIITLVWg1Qn1kTFii2lpMbDhXn0tSchgkUdy3wIjN9KIUTZg11hHcC7Wj4reH3Ymf/w== MIME-Version: 1.0 X-Received: by 10.36.44.136 with SMTP id i130mr9013259iti.99.1468126310205; Sat, 09 Jul 2016 21:51:50 -0700 (PDT) Sender: kmacybsd@gmail.com Received: by 10.107.168.101 with HTTP; Sat, 9 Jul 2016 21:51:50 -0700 (PDT) In-Reply-To: References: Date: Sat, 9 Jul 2016 21:51:50 -0700 X-Google-Sender-Auth: iSaZL9js7vN9ar5_R6dE8QzWpbI Message-ID: Subject: Re: [Bug 203864] ZFS deadlock between zfs send, zfs rename and ctrl-C From: "K. Macy" To: "bugzilla-noreply@freebsd.org" Cc: "freebsd-fs@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jul 2016 04:51:51 -0000 On Saturday, July 9, 2016, wrote: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203864 > > --- Comment #17 from Andriy Gapon --- > Another observation is that the current code seems to be broken in a > couple of > places as well. > > 1. dsl_dataset_rename_snapshot_sync_impl() uses ddrsa_fsname to construct > the > old and new snapshot names, but this would be wrong in the case of a > recursive > snpashot rename (zfs rename -r x@snap1 x@snap2) as ddrsa_fsname always > points > to the name of the top level filesystem. > > 2. dsl_dataset_promote_sync(): as far as I can see, oldname is never > populated, > so the code can do arbitrary renames. Have you tried enabling opensolaris witness? > > -- > You are receiving this mail because: > You are the assignee for the bug. > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org > " >