Date: Mon, 18 Jul 2016 01:34:29 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-geom@FreeBSD.org Subject: [Bug 209113] Heap overflow in geom ioctl handler Message-ID: <bug-209113-14739-6Lmu3S1BEp@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-209113-14739@https.bugs.freebsd.org/bugzilla/> References: <bug-209113-14739@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209113 rday <ryan@ryanday.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ryan@ryanday.net --- Comment #1 from rday <ryan@ryanday.net> --- Created attachment 172625 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=172625&action=edit Fix for 209113 A problem existed where a g_malloc call would allocate a buffer length specified by a 32 bit integer. Then copyin would write a 64 bit integer worth of data into the buffer. By changing g_malloc()'s len argument to be a size_t (matching malloc) the buffer will always be large enough for copyin. It is still possible to hang the process while waiting for a large enough allocation, so the M_NOWAIT flag has replaced the M_WAITOK flag. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209113-14739-6Lmu3S1BEp>