From owner-freebsd-hackers@freebsd.org Mon Oct 24 06:14:01 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0DAD4C1F353 for ; Mon, 24 Oct 2016 06:14:01 +0000 (UTC) (envelope-from damian@damianek.be) Received: from mail-yb0-x229.google.com (mail-yb0-x229.google.com [IPv6:2607:f8b0:4002:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C7137E7D for ; Mon, 24 Oct 2016 06:14:00 +0000 (UTC) (envelope-from damian@damianek.be) Received: by mail-yb0-x229.google.com with SMTP id d128so11584041ybh.2 for ; Sun, 23 Oct 2016 23:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=damianek-be.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lDYW8+OaXbKc67Ye0nR8/1rOfFmgo0UAnxSH95VeeMI=; b=wmyy5q7vsnhwzuyUvNWv+mfrEM5CmMNtmgdHGUo3fbygvUoEpMaHZrzAGMa288HhSE w0plYyT3DtwUNKnSH6xCm6z0V9Q/Vrq8M1bSVv8Uh3WnuiLIcYJ/m8wlZJ42EsUwZYtv WncXeU+iV4cGNQU9/9uOXYaProxBDJyzJIqXYmoJe/2HOnrHzZNPjr9rS/d7lXwJncmg /wUccCGvCo/gZ5qavQstwukoL+T2ZDhUcgh4y6/dg6T2SYrwAv25mVfMt2av3vbc/K6l cC5ziN5WzjKnslYKDszKDlmYFGGnhgBXwG+tesPL+K50nSqj3nexoXGIfJpp3v7a71g7 98oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lDYW8+OaXbKc67Ye0nR8/1rOfFmgo0UAnxSH95VeeMI=; b=KLmZ/ESmV0wTh90iSQk/HVdJFp3Q8NaBuWpXhxjMZvhYk9LMWnWBQ7/uCUzYMkSQT+ +/Xiv1ufF5z8WMV7zagPclvoPex8H2Gf9Y6/OtxFYrefSBKrQnNZvQJDgvahEdd4eOxl +nkbzvHUxor8jbfMERCB7OuYZ84IoWYqpnjQcHTUaKsObbalm5PRcBtqFbgAAW/PcTLc QHkAGVDbpp2zGX/wV+h1TcpJAnvQnBn3OfFsWn0KQBI0+YEKtciChwyEHWE4NArIeT6V 3YleM4fWNBkD4FkHQyZOjOCJjf5is4YYpeMEGfraxPIahXDeFNCJF9gjjhxL5yNsYLyY OaFQ== X-Gm-Message-State: ABUngvdcboalYTWKPHSCUOWZ3UMvUxZzUqP99s4k7AP2HCqZJ95MVT4KB3fa05yL8MBWIZyC6Gv2MbnhJgD8Ww== X-Received: by 10.36.22.67 with SMTP id a64mr992674ita.58.1477289639394; Sun, 23 Oct 2016 23:13:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.39.71 with HTTP; Sun, 23 Oct 2016 23:13:19 -0700 (PDT) In-Reply-To: <99EA092D-EB84-4D54-9583-F7E328466376@gmail.com> References: <30603328-0967-4F43-AF8F-1291439DEEE3@gmail.com> <75FC0C9B-F70B-4524-856F-9C8F4EB45776@gmail.com> <99EA092D-EB84-4D54-9583-F7E328466376@gmail.com> From: "damian@damianek.be" Date: Mon, 24 Oct 2016 08:13:19 +0200 Message-ID: Subject: Re: FreeBSD11 buildworld WITHOUT_ICONV To: "Ngie Cooper (yaneurabeya)" Cc: freebsd-hackers@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2016 06:14:01 -0000 2016-10-21 23:12 GMT+02:00 Ngie Cooper (yaneurabeya) : > > Rev 307725 > > Still same problem: > > /usr/src/lib/libc/tests/iconv/iconvctl_test.c:30:10: fatal error: > 'iconv.h' file not found > > Are you trying to build from lib/libc/tests or > lib/libc/tests/iconv ? If the latter, then yes=E2=80=A6 that will not wor= k. The > former case should work though (and I tested this out before I committed > the change by setting MK_ICONV=3Dno). > I'm trying make buildworld from /usr/src. In /usr/src/tools/build/options i don't see MK_ICONV option. Now i try on revision 307846 and MK_ICONV=3Dno (and WITHOUT_ICONV=3Dyes) in /etc/src.conf --=20 damian@damianek.be From owner-freebsd-hackers@freebsd.org Mon Oct 24 06:25:43 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84ED5C1F599 for ; Mon, 24 Oct 2016 06:25:43 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x233.google.com (mail-pf0-x233.google.com [IPv6:2607:f8b0:400e:c00::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 40FC52FC for ; Mon, 24 Oct 2016 06:25:43 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x233.google.com with SMTP id 128so92870619pfz.0 for ; Sun, 23 Oct 2016 23:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=i/SqiGPGWHXaEUNvmTXU3hT0krU+Ztlrj4bqBEJToqQ=; b=A1zImJZAdmjNMvESRzhb5BuWbPbEOvdV/gyVRFCIjjy2opzvGITdQRLzAW+79C6Q25 h6wkMwr4TVVTS3nAKfS6kEtP+mcEzuiDOeM5cTSFfjSzBWBOwl6wHDdLfqaU8V3AbaCb Di75YzCrLXv/ySNMxwtgQIbuVP6xfOwL7RnisKu8hefDscqA3xiKJ7hXKDxRWpJkkxEa IDZyRjTxJyjXMohskrcEeyEgdfWJ2uFEduc1ejkDSjjlsBZPeGlDDD43h6Y7DmbKZE9I K0Y/0mlFvRTVUuEwkeKmEPoezQZqOQnJshrdE/2d0kSnOm4ifGeER6cIN+s96o+EBRng ES8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=i/SqiGPGWHXaEUNvmTXU3hT0krU+Ztlrj4bqBEJToqQ=; b=dF7DzuGc/0mV4C1DhH5h6PfexhymoGBiaPl1UIxTnYWKYDqBOBlUrrHGQYF9VsKiVP aH08AfdSuTNUScYKF9HjNp2aZKwho28rst30wi7trHEelmndRdvqN1pRh7sfmPv+s2Y5 uxhBy9G9cJvNbRiRvG8bTmr4fpUfTNeXA8xtqHrIaqdSuU2XRDfYWCXGCLoQUqmgkoN+ w7UYpvAXepFpv5Euc89VvXJqc9Aa+K0zlg9IcKCv/RStazmwiROIpmSo9q7RX/7GtWEu N6YRjKsFnKZi5JazihQMM1Mz4jJ6DuP1NMc157fWaKDQS0aNNXc1fepG/QML2W+pLeBd GWew== X-Gm-Message-State: ABUngvdxLv0eXURZjC8PfY6enbUtUnJ/X+dMoEV3TuTySCe9Ol7dkXYrjuvMBJ5i9bB/4g== X-Received: by 10.98.35.220 with SMTP id q89mr25544022pfj.141.1477290342745; Sun, 23 Oct 2016 23:25:42 -0700 (PDT) Received: from [192.168.20.12] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id l7sm1764683pfk.80.2016.10.23.23.25.42 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 23 Oct 2016 23:25:42 -0700 (PDT) Subject: Re: FreeBSD11 buildworld WITHOUT_ICONV Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_F12F62D7-663C-41F8-BAF5-235165CF7EAB"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Sun, 23 Oct 2016 23:25:40 -0700 Cc: freebsd-hackers@freebsd.org Message-Id: References: <30603328-0967-4F43-AF8F-1291439DEEE3@gmail.com> <75FC0C9B-F70B-4524-856F-9C8F4EB45776@gmail.com> <99EA092D-EB84-4D54-9583-F7E328466376@gmail.com> To: "damian@damianek.be" X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2016 06:25:43 -0000 --Apple-Mail=_F12F62D7-663C-41F8-BAF5-235165CF7EAB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 23, 2016, at 23:13, damian@damianek.be wrote: >=20 > 2016-10-21 23:12 GMT+02:00 Ngie Cooper (yaneurabeya) = : > > Rev 307725 > > Still same problem: > > /usr/src/lib/libc/tests/iconv/iconvctl_test.c:30:10: fatal error: = 'iconv.h' file not found >=20 > Are you trying to build from lib/libc/tests or = lib/libc/tests/iconv ? If the latter, then yes=E2=80=A6 that will not = work. The former case should work though (and I tested this out before I = committed the change by setting MK_ICONV=3Dno). >=20 > I'm trying make buildworld from /usr/src. > In /usr/src/tools/build/options i don't see MK_ICONV option. >=20 > Now i try on revision 307846 and MK_ICONV=3Dno (and WITHOUT_ICONV=3Dyes)= in /etc/src.conf If you set WITHOUT_foo=3Dy, it will set MK_foo=3Dno (example = below with MK_ICONV and the directory of interest). So, I=E2=80=99m not = entirely sure why your example is failing (yet). Some logs with failing = context somewhere would definitely help. Thanks, -Ngie $ make -C lib/libc/tests/ -VSUBDIR:Miconv -VMK_ICONV iconv yes $ env MK_ICONV=3Dno make -C lib/libc/tests/ -VSUBDIR:Miconv -VMK_ICONV no $ --Apple-Mail=_F12F62D7-663C-41F8-BAF5-235165CF7EAB Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYDallAAoJEPWDqSZpMIYVFiEQAKyLY0gIcczJ2VYFZT8qL8zy YPTBY4XELL16B9HVoduPqA2SvnYpcUCDTL5kEQPlIql9ifY5MIbXZmObf6dloae6 Jw6qoK5aEbyzLOwu8XUzN/emYLGRRtTVWiUyNczV02gp/OjnCvQhE+qHDbhi9uoG cHz2UkEfdPrOu6V9xgrpL69Z1izfUrzIIfVZEfMW0O0JItGTFrWzZLtwrfxBtcjR FAwF1YBWSC9frtVfq3YMwNG0eKQp0PlGhBZlc3DbzRdOU2jOba1SNpPqS/+u8Si9 m8i+4dhg89QxRDjLpIwhkLij5s9pQp7aJaZTr7w+u85dRBd1lx5L1+OuAhjL3dKF ZsCdWy2HhWFjYy/04O9f4c7ctK8nfpMzBpRqs9SkFfSMkHXoBYS3Eyzv+tlNBfoM 1EWnLTzRomSLUgYyuG9Ah/XoH4z2L8DTwzcp1Fy2/5H1I8Dr4rLHgTFHt/VjOLRp GF5ixbzg+Xkm51IXyjQ97ZL8EexN/8vmMzStUi58DoTq5jdzF9oQLg3gE5+QDXPs IbLyqMqm6XtiYbi5vjVSQX0z+zUj/xlvKNI8BBjhxwqrrrXSZzFYSNBSfIafQRHH qAcLQ+C3i3DRvIXzYcwN0gi33NrvolT3uOFA/pjgv3ljbOieOjaWpWiS2sEnGSt1 k/eyneXC7bl/TV62UCxF =FIt5 -----END PGP SIGNATURE----- --Apple-Mail=_F12F62D7-663C-41F8-BAF5-235165CF7EAB-- From owner-freebsd-hackers@freebsd.org Mon Oct 24 10:00:38 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84963C1C884 for ; Mon, 24 Oct 2016 10:00:38 +0000 (UTC) (envelope-from damian@damianek.be) Received: from mail-yb0-x231.google.com (mail-yb0-x231.google.com [IPv6:2607:f8b0:4002:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 443A16EB for ; Mon, 24 Oct 2016 10:00:38 +0000 (UTC) (envelope-from damian@damianek.be) Received: by mail-yb0-x231.google.com with SMTP id d128so18727077ybh.2 for ; Mon, 24 Oct 2016 03:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=damianek-be.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FeuUT+6uy5uxJ3Zb4aNCSXvcwSnIQ67aHN9+LrVe6ro=; b=2M8NczMOMdSavE/fhpcXsoXrQRF/i20niorgQih2ZtBUBHkwF89+fL/a/uIKdQ55H+ L02gm1Qu5B+CCwSXgGSD+NmZck2nCOqQb4xa61RsBBaDsSC3FNqLnIMKjNVJQnbWH4tX gFyBjdd0UN/UAYcsyFqAgnx6OPKytCY2LahFIG2AxQZX+lLexx+7cp0XlcYaPyipmgrM TU0G841jSvFcF3AfiZT3eURD3LZxY7eXkltHVciOiIgIQZY+8DBJbuPp5KV3r6K/wVGA LSoq+v5kHN6+rJLOS50nRvSM0KmBaf1GRPVPdNmO/tjk19WBqld6bVcWziMyYr1tIv0F xeBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FeuUT+6uy5uxJ3Zb4aNCSXvcwSnIQ67aHN9+LrVe6ro=; b=l617GpaL6NQmusmAi/Ga+tNLwQBj8wFncV2wk9qKSjwapAL39v+yxfkXXQe3P/TIhu /HHXZAZGjOPkHNwqUHWikVQ3qpzzCMpxY4hKdqbTel3yqOyWuUVHuOLn3bGyPBakZJbb XYDaroNf/IxDENF2rAmDX/pPGGgmiSTMfRQO5hwlEkF4QDf7K/UdYjPFgTcdFiCSuhfA A6hswkHF2rc+QdJPmHZIO/Uta5TyHreiPRO3a2j9teSacO4ixnL9fF7xMc/dkHHC5sf2 kwkg5zf+U8XOnh5v4wOWZS5L1fTuhLG/6BeoKnVV4bUZdYwA5Z4gaVAp/JG64LYuJ9Ou EmYw== X-Gm-Message-State: ABUngvdMjc9zBpiRD4AaDCUdTljkLxOu0r768sS1/QoAOGy8yaRMBUb49e4HJ3pRsTYo45y5uLTRzfYUlrwikg== X-Received: by 10.36.56.136 with SMTP id b130mr1405767ita.117.1477303237228; Mon, 24 Oct 2016 03:00:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.39.71 with HTTP; Mon, 24 Oct 2016 02:59:56 -0700 (PDT) In-Reply-To: References: <30603328-0967-4F43-AF8F-1291439DEEE3@gmail.com> <75FC0C9B-F70B-4524-856F-9C8F4EB45776@gmail.com> <99EA092D-EB84-4D54-9583-F7E328466376@gmail.com> From: "damian@damianek.be" Date: Mon, 24 Oct 2016 11:59:56 +0200 Message-ID: Subject: Re: FreeBSD11 buildworld WITHOUT_ICONV To: "Ngie Cooper (yaneurabeya)" Cc: freebsd-hackers@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2016 10:00:38 -0000 2016-10-24 8:25 GMT+02:00 Ngie Cooper (yaneurabeya) = : > > Now i try on revision 307846 and MK_ICONV=3Dno (and WITHOUT_ICONV=3Dyes= ) in > /etc/src.conf > > If you set WITHOUT_foo=3Dy, it will set MK_foo=3Dno (example belo= w > with MK_ICONV and the directory of interest). So, I=E2=80=99m not entirel= y sure why > your example is failing (yet). Some logs with failing context somewhere > would definitely help. > Thanks, > -Ngie > > $ make -C lib/libc/tests/ -VSUBDIR:Miconv -VMK_ICONV > iconv > yes > $ env MK_ICONV=3Dno make -C lib/libc/tests/ -VSUBDIR:Miconv -VMK_ICONV > > no > $ > Rev 307846 (svn src ~8AM CEST): root:/usr/src # grep ICONV /etc/src.conf WITHOUT_ICONV=3Dyes MK_ICONV=3Dno root:/usr/src # make -C lib/libc/tests/ -VSUBDIR:Miconv -VMK_ICONV iconv no root:/usr/src # env MK_ICONV=3Dno make -C lib/libc/tests/ -VSUBDIR:Miconv -VMK_ICONV iconv no make buildworld: =3D=3D=3D> lib/libc/tests/iconv (all) (cd /usr/src/lib/libc/tests/iconv && DEPENDFILE=3D.depend.iconvctl_test NO_SUBDIR=3D1 /usr/obj/usr/src/make.amd64/bmake -f /usr/src/lib/libc/tests/iconv/Makefile _RECURSING_PROGS=3Dt PROG=3Diconvctl_test ) echo iconvctl_test.full: /usr/obj/usr/src/tmp/usr/lib/libc.a /usr/obj/usr/src/tmp/usr/lib/libprivateatf-c.a >> .depend.iconvctl_test cc -O2 -pipe -march=3Dnative -g -MD -MF.depend.iconvctl_test.iconvctl_test.o -MTiconvctl_test.o -std=3Dgnu99 -fstack-protector-strong -Qunused-arguments -c /usr/src/lib/libc/tests/iconv/iconvctl_test.c -o iconvctl_test.o /usr/src/lib/libc/tests/iconv/iconvctl_test.c:30:10: fatal error: 'iconv.h' file not found #include ^ 1 error generated. *** Error code 1 Stop. bmake[7]: stopped in /usr/src/lib/libc/tests/iconv *** Error code 1 --=20 damian@damianek.be From owner-freebsd-hackers@freebsd.org Mon Oct 24 15:40:42 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8AB6C1FB9D for ; Mon, 24 Oct 2016 15:40:42 +0000 (UTC) (envelope-from claudiu.ciurdariu@gmail.com) Received: from mail-lf0-x235.google.com (mail-lf0-x235.google.com [IPv6:2a00:1450:4010:c07::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 20137AC9 for ; Mon, 24 Oct 2016 15:40:42 +0000 (UTC) (envelope-from claudiu.ciurdariu@gmail.com) Received: by mail-lf0-x235.google.com with SMTP id f134so35248320lfg.2 for ; Mon, 24 Oct 2016 08:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=1JeVdRhqR+E82llIbdruZWC2xJHO5hl2RMLjD/8QePo=; b=OibhJOsilUwbvWCu96twkvWNS4s+3iP+RejS2Wx4rtNURQHwfd3LXIfedf7v11sv+O BSk1QL7nYmT+SA2CGBE872ql7UZlj/iS5a9aMYCY5ycHzKthL6eczKrig+HIqjNSdDB1 zgRev+485LoRlLw+toQHV1ROWZbdnQyLDocwpQIMoewYvXwlAILxXkTwljwcNLBkA4C3 ev3HI295hGP3TlizkBD67+1IB2UX2Qnh7BldJGTnTgvVKeCEOgz2sOI5WolIeT3K3Ano ErQFSc3k/wqRUihYYL/ZTFskNcVIEdJtjjn3QeqionJYTAdheUiaGS7HjCwd2rdwdDen AdVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=1JeVdRhqR+E82llIbdruZWC2xJHO5hl2RMLjD/8QePo=; b=gYBL/cSxjV3kiyHHS8YL0KLOw6HE0Ueiukdj8unZF85F66QQ0HGW2tM18GTqUPquxO aKBTyUesOhV2LZqzHZccH/IK85IidmyrhbnpoDgqDntbERscV4opIspR37kQMMW5D4IQ T8K5uMNynC81WvTwLL5cDaC6VBVSntjPRk4h+PyJncx++h8mHiz0fXKQ1Z9MqLTgO7gt rhUTDLndzXlc7YtcSoQ7zu8N+pvHZeNDC0xEvhtgHoPgrTT2vEMpJnTVvFg9gbm0krCa AjrJExAtHDHviMYlOh39g2//ykiwPrCFakgvL61tUd7wxDmITPthx9aml36/Jabr7XLd Ht8A== X-Gm-Message-State: ABUngveXV3otmGhvXo3GRChJ9d/2rnbm6JwaRSyIcqS+ga10Juvs/ThMWuFauczaJd7/g6YBjLk2DXo9IiCT1w== X-Received: by 10.25.76.130 with SMTP id z124mr3495074lfa.53.1477323639976; Mon, 24 Oct 2016 08:40:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.127.150 with HTTP; Mon, 24 Oct 2016 08:40:39 -0700 (PDT) From: Claudiu Ciurdariu Date: Mon, 24 Oct 2016 16:40:39 +0100 Message-ID: Subject: FreeBSD 11 boot problem in a UEFI ZFS-root with 4K native HDDs setup To: freebsd-hackers@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2016 15:40:42 -0000 Trying to boot FreeBSD 11 RELEASE in UEFI mode after installing the OS with root on a 4K native 2-disk ZFS mirror and getting the error below: >> FreeBSD EFI boot block Loader path: /boot/loader.efi Initializing modules: ZFS UFS Probing 14 block devices...........*.+ done ZFS found the following pools zroot UFS found no partitions ZFS: i/o error - all block copies unavailable ZFS: can't read MOS of pool zroot ZFS: i/o error - all block copies unavailable ZFS: can't read MOS of pool zroot Failed to load '/boot/loader.efi' panic: No bootable partitions found! The partition layout looks like this: # gpart show => 6 488378629 ada0 GPT (1.8T) 6 200 1 efi (800K) 206 50 - free - (200K) 256 488378368 2 freebsd-zfs (1.8T) 488378624 11 - free - (44K) => 6 488378629 ada1 GPT (1.8T) 6 200 1 efi (800K) 206 50 - free - (200K) 256 488378368 2 freebsd-zfs (1.8T) 488378624 11 - free - (44K) # gpart list Geom name: ada0 modified: false state: OK fwheads: 16 fwsectors: 63 last: 488378634 first: 6 entries: 128 scheme: GPT Providers: 1. Name: ada0p1 Mediasize: 819200 (800K) Sectorsize: 4096 Stripesize: 0 Stripeoffset: 24576 Mode: r0w0e0 rawuuid: 1f029d6d-99f4-11e6-819b-001e67e6cc2f rawtype: c12a7328-f81f-11d2-ba4b-00a0c93ec93b label: efiboot0 length: 819200 offset: 24576 type: efi index: 1 end: 205 start: 6 2. Name: ada0p2 Mediasize: 2000397795328 (1.8T) Sectorsize: 4096 Stripesize: 0 Stripeoffset: 1048576 Mode: r1w1e1 rawuuid: 1f496f99-99f4-11e6-819b-001e67e6cc2f rawtype: 516e7cba-6ecf-11d6-8ff8-00022d09712b label: zfs0 length: 2000397795328 offset: 1048576 type: freebsd-zfs index: 2 end: 488378623 start: 256 Consumers: 1. Name: ada0 Mediasize: 2000398909440 (1.8T) Sectorsize: 4096 Mode: r1w1e2 Geom name: ada1 modified: false state: OK fwheads: 16 fwsectors: 63 last: 488378634 first: 6 entries: 128 scheme: GPT Providers: 1. Name: ada1p1 Mediasize: 819200 (800K) Sectorsize: 4096 Stripesize: 0 Stripeoffset: 24576 Mode: r0w0e0 rawuuid: 1faf567b-99f4-11e6-819b-001e67e6cc2f rawtype: c12a7328-f81f-11d2-ba4b-00a0c93ec93b label: efiboot1 length: 819200 offset: 24576 type: efi index: 1 end: 205 start: 6 2. Name: ada1p2 Mediasize: 2000397795328 (1.8T) Sectorsize: 4096 Stripesize: 0 Stripeoffset: 1048576 Mode: r1w1e1 rawuuid: 1fc2d874-99f4-11e6-819b-001e67e6cc2f rawtype: 516e7cba-6ecf-11d6-8ff8-00022d09712b label: zfs1 length: 2000397795328 offset: 1048576 type: freebsd-zfs index: 2 end: 488378623 start: 256 Consumers: 1. Name: ada1 Mediasize: 2000398909440 (1.8T) Sectorsize: 4096 Mode: r1w1e2 And the ZFS dataset: # zfs list NAME USED AVAIL REFER MOUNTPOINT zroot 301M 1.76T 96K /mnt/zroot zroot/ROOT 299M 1.76T 96K none zroot/ROOT/default 299M 1.76T 299M /mnt zroot/tmp 128K 1.76T 128K /mnt/tmp zroot/usr 384K 1.76T 96K /mnt/usr zroot/usr/home 96K 1.76T 96K /mnt/usr/home zroot/usr/ports 96K 1.76T 96K /mnt/usr/ports zroot/usr/src 96K 1.76T 96K /mnt/usr/src zroot/var 588K 1.76T 96K /mnt/var zroot/var/audit 96K 1.76T 96K /mnt/var/audit zroot/var/crash 96K 1.76T 96K /mnt/var/crash zroot/var/log 108K 1.76T 108K /mnt/var/log zroot/var/mail 96K 1.76T 96K /mnt/var/mail zroot/var/tmp 96K 1.76T 96K /mnt/var/tmp The HDDs are 2 Tohsiba 4Kn spinning disks: # camcontrol devlist at scbus4 target 0 lun 0 (ses0,pass0) at scbus7 target 0 lun 0 (ada0,pass1) at scbus8 target 0 lun 0 (ada1,pass2) at scbus11 target 0 lun 0 (ses1,pass3) at scbus12 target 0 lun 0 (pass4,cd0) at scbus12 target 0 lun 1 (da0,pass5) Any idea what the issue might be? Thanks, Claudiu From owner-freebsd-hackers@freebsd.org Tue Oct 25 13:39:16 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77DADC21305 for ; Tue, 25 Oct 2016 13:39:16 +0000 (UTC) (envelope-from damian@damianek.be) Received: from mail-yb0-x231.google.com (mail-yb0-x231.google.com [IPv6:2607:f8b0:4002:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B7FEF3C for ; Tue, 25 Oct 2016 13:39:15 +0000 (UTC) (envelope-from damian@damianek.be) Received: by mail-yb0-x231.google.com with SMTP id f97so90083419ybi.1 for ; Tue, 25 Oct 2016 06:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=damianek-be.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nbbfEOanXBjpWw8ISZErHgF0HwVlBeAmtWvgb00SyLI=; b=d46B0OCzazOgKmPDio5/t2uezz7cBm0S9mZgtI3R0Pbu8yvzuz1kZsgf8OzcdkzhPp igB8rgNCHC9YUYVwNPM2G1r9xe5ysLA2CjoLA4c7razoHTcTgVDx/7/Wz/i9QuNPLTta B+mT/86qOyriiNLZWX+V/QWB5rKNMVpZ+GkRtF7x8pS+e/kh2965A0+F2fe7V9x7+b5e xDtFI6md1+n18qWfB5RQstqnMJIOlA5zzhgo+1FY3vfKinCWojMmjLXMz65ea/S9K4bT HEodE8mZ2WshpjyJVaKMuystDKCTJa6+RiZu30mDZCpIyyqQeQRrR+X1pZCwBDk4O0UX y7qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nbbfEOanXBjpWw8ISZErHgF0HwVlBeAmtWvgb00SyLI=; b=GpjiLEUUp+ACuDyfTzkN5sEaHzdFLcq+eBbU7c9kqzYhEhcKo3wdFfmpTN4pAA8lxr 3GvtteoWb7v9PmQP5hmej7FAGnrAG/BVuIvncPI2k+v9dQxw3wMm4oPL9mDltfY5Bvip hJ7qxLdxKV/SZCzfFfGqVkU+cZ4N3isbbZX+Rak5m1xG5SUif5T6R8RKJ6XZV/2TkuVo 9XbYY1SJwID35C4Nld8/60dQTa++7wQ/RwxLSoGUYlWJGrm+D3MVW0/3KIZdYyMpza02 JLvFePHbq+1WrilHUYsip3NirR8Am4TM5/HGyZlpoKaXvxAyX0MI7vg5/5dsFVL3KpuM cBqQ== X-Gm-Message-State: ABUngvc+JX48BVqVC2ySEtt4f0MKAehpNkj6Swr/skdh1zHAI4wHLJ2OIuVcp+Z+ZpZ1COtgrn59PjY0uCjgpQ== X-Received: by 10.36.56.136 with SMTP id b130mr1712538ita.117.1477402754709; Tue, 25 Oct 2016 06:39:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.39.71 with HTTP; Tue, 25 Oct 2016 06:38:34 -0700 (PDT) In-Reply-To: References: <30603328-0967-4F43-AF8F-1291439DEEE3@gmail.com> <75FC0C9B-F70B-4524-856F-9C8F4EB45776@gmail.com> <99EA092D-EB84-4D54-9583-F7E328466376@gmail.com> From: "damian@damianek.be" Date: Tue, 25 Oct 2016 15:38:34 +0200 Message-ID: Subject: Re: FreeBSD11 buildworld WITHOUT_ICONV To: "Ngie Cooper (yaneurabeya)" Cc: freebsd-hackers@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2016 13:39:16 -0000 2016-10-24 11:59 GMT+02:00 damian@damianek.be : > Rev 307846 (svn src ~8AM CEST): > > make buildworld: > ===> lib/libc/tests/iconv (all) > (cd /usr/src/lib/libc/tests/iconv && DEPENDFILE=.depend.iconvctl_test > NO_SUBDIR=1 /usr/obj/usr/src/make.amd64/bmake -f > /usr/src/lib/libc/tests/iconv/Makefile _RECURSING_PROGS=t > PROG=iconvctl_test ) > echo iconvctl_test.full: /usr/obj/usr/src/tmp/usr/lib/libc.a > /usr/obj/usr/src/tmp/usr/lib/libprivateatf-c.a >> .depend.iconvctl_test > cc -O2 -pipe -march=native -g -MD -MF.depend.iconvctl_test.iconvctl_test.o > -MTiconvctl_test.o -std=gnu99 -fstack-protector-strong > -Qunused-arguments -c /usr/src/lib/libc/tests/iconv/iconvctl_test.c -o > iconvctl_test.o > /usr/src/lib/libc/tests/iconv/iconvctl_test.c:30:10: fatal error: > 'iconv.h' file not found > #include > ^ > 1 error generated. > *** Error code 1 > > Stop. > bmake[7]: stopped in /usr/src/lib/libc/tests/iconv > *** Error code 1 > > Ok, i answer myself: --- lib/libc/tests/Makefile.orig 2016-10-25 14:42:00.637660000 +0200 +++ lib/libc/tests/Makefile 2016-10-25 14:44:05.357114000 +0200 @@ -9,5 +9,7 @@ TESTS_SUBDIRS+= gen TESTS_SUBDIRS+= hash -TESTS_SUBDIRS+= iconv +.if ${MK_ICONV} != "no" +TESTS_SUBDIRS+= iconv +.endif TESTS_SUBDIRS+= inet TESTS_SUBDIRS+= net And... works fine: -------------------------------------------------------------- >>> World build completed on Tue Oct 25 15:35:50 CEST 2016 -------------------------------------------------------------- -- damian@damianek.be From owner-freebsd-hackers@freebsd.org Fri Oct 28 21:14:40 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0412FC25B6C for ; Fri, 28 Oct 2016 21:14:40 +0000 (UTC) (envelope-from nonesuch@longcount.org) Received: from mail-yw0-x22c.google.com (mail-yw0-x22c.google.com [IPv6:2607:f8b0:4002:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C1D9FDD7 for ; Fri, 28 Oct 2016 21:14:39 +0000 (UTC) (envelope-from nonesuch@longcount.org) Received: by mail-yw0-x22c.google.com with SMTP id w3so103036973ywg.1 for ; Fri, 28 Oct 2016 14:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=longcount-org.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=TerTZKysxet+WkAl18KJhZFVb8lQonq0BJ6HEE9aijE=; b=WvtzCjcxS2UeEdmrWyu/EJ4fE/z9nVeaMvwenxbYoz5lsR5XPRQKTxGIy5/GuosA/f 69fIGlNpdxnULtQ0tBIXkq2qE/eg+A1cbkCn7/naXaYEyz/eS0bzaETNXa8B9MD9vHb2 ihi728n1TxM0/w8K/ly/5T8Trp+Y90q3RGV1pYhv9na0elGf2LjweV4At2ygBFyveHnL T+QCrsaJcj6eQIBr9Xc/wnZ67IVopdQof3/Gs1dG/Y5rt7O0AZ+J3Yb9/Bc9IgLqitRm 8Xk3XZ+esSXzSpcy1U6V8QDsN7vPW0jy3ffaHJOI1gghed1RBaxJDrfsjFrmHNDuPgP+ DbfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=TerTZKysxet+WkAl18KJhZFVb8lQonq0BJ6HEE9aijE=; b=ft1j1ibjAbrtOLt6wKSagk5YlMpYD0XP7cnhBrtYSSKGoVMNDBAO1aIKKR9jmNe9TR Z7DToUQGQSm84qzEhLCCHVAf7AoIfDztgjLtouhast35rrX/mNvCktRkTUeiLRcUJEeM h9p2iW7Ycd1MRliP94qhoD+ub+Zjsq5wKdQtTZxdaDsTTbefyDa0UvSzTfnr4gzrh5ct L5xSnE9vlQBJOMexFYuDNr7b/53RP4Pm+1d+L7DowSpL1iUCpznVhmcbI4tANqPZfpPr 5h+7Fdj/xnyRWz32OF1IOwpSGsTOqbuH046gtu20KevB/TWLXSESKvJ+TAct3c51Pvni at4w== X-Gm-Message-State: ABUngvdg+Gc2Q9/7viXTwJIzBikAMhmeYA4/LAaM0JwnawOBTzvzurWYcWFczqI2dN1HiC/74Ab322W7XTke6w== X-Received: by 10.13.198.129 with SMTP id i123mr13726660ywd.132.1477689277845; Fri, 28 Oct 2016 14:14:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.94.215 with HTTP; Fri, 28 Oct 2016 14:14:37 -0700 (PDT) X-Originating-IP: [24.44.110.108] From: Mark Saad Date: Fri, 28 Oct 2016 17:14:37 -0400 Message-ID: Subject: lacp weirdness on 10.3-STABLE To: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 21:14:40 -0000 Hi everyone I wast sure where to start on this one. So let me jump in here. I have a box with a dual port solarflare card. Both ports were running in lacp lagg for a while with out any issues. I took the box down free up some space in the rack. I reciently booted it back up; using the original network ports and cables from the original seutp. However I can not bring up the lagg in lacp mode. Trussing the process is showing this n01:~ # ifconfig lagg0 up lacp ifconfig: lacp: bad value n01:~ # truss ifconfig lagg0 up lacp ..... read(4,"# $FreeBSD: stable/10/etc/networ"...,4096) = 368 (0x170) read(4,0x801c47000,4096) = 0 (0x0) close(4) = 0 (0x0) ifconfig: write(2,"ifconfig: ",10) = 10 (0xa) lacp: bad valuewrite(2,"lacp: bad value",15) = 15 (0xf) .... I am at a loss. The Switch ports are in the original configs as well. Anyone have any ideas ? Kernel and Userland are FreeBSD 10.3-STABLE #0: Tue Aug 23 14:48:27 EDT 2016 -- mark saad | nonesuch@longcount.org From owner-freebsd-hackers@freebsd.org Fri Oct 28 21:17:51 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 80D1AC25CE5 for ; Fri, 28 Oct 2016 21:17:51 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 436701026 for ; Fri, 28 Oct 2016 21:17:51 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1c0EX6-0006f2-0l; Sat, 29 Oct 2016 00:17:48 +0300 Date: Sat, 29 Oct 2016 00:17:47 +0300 From: Slawa Olhovchenkov To: Mark Saad Cc: "freebsd-hackers@freebsd.org" Subject: Re: lacp weirdness on 10.3-STABLE Message-ID: <20161028211747.GU57714@zxy.spb.ru> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 21:17:51 -0000 On Fri, Oct 28, 2016 at 05:14:37PM -0400, Mark Saad wrote: > Hi everyone > I wast sure where to start on this one. So let me jump in here. > I have a box with a dual port solarflare card. Both ports were running in > lacp > lagg for a while with out any issues. I took the box down free up some > space in the rack. I reciently > booted it back up; using the original network ports and cables from the > original seutp. However I can not bring up the lagg in lacp mode. Trussing > the process is showing this > > n01:~ # ifconfig lagg0 up lacp > ifconfig: lacp: bad value ifconfig lagg0 up laggproto lacp > n01:~ # truss ifconfig lagg0 up lacp > ..... > read(4,"# $FreeBSD: stable/10/etc/networ"...,4096) = 368 (0x170) > read(4,0x801c47000,4096) = 0 (0x0) > close(4) = 0 (0x0) > ifconfig: write(2,"ifconfig: ",10) = 10 (0xa) > lacp: bad valuewrite(2,"lacp: bad value",15) = 15 (0xf) > .... > > I am at a loss. The Switch ports are in the original configs as well. > Anyone have any ideas ? > Kernel and Userland are FreeBSD 10.3-STABLE #0: Tue Aug 23 14:48:27 EDT > 2016 > > > -- > mark saad | nonesuch@longcount.org > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" From owner-freebsd-hackers@freebsd.org Sat Oct 29 21:37:21 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AEEC4C26CFC for ; Sat, 29 Oct 2016 21:37:21 +0000 (UTC) (envelope-from dumbbell@FreeBSD.org) Received: from mail.made4.biz (mail.made4.biz [IPv6:2001:41d0:2:c018::1:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 78F003D1 for ; Sat, 29 Oct 2016 21:37:21 +0000 (UTC) (envelope-from dumbbell@FreeBSD.org) Received: from 141.7.19.93.rev.sfr.net ([93.19.7.141] helo=magellan.dumbbell.fr) by mail.made4.biz with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87 (FreeBSD)) (envelope-from ) id 1c0bJW-000Lq2-42 for freebsd-hackers@freebsd.org; Sat, 29 Oct 2016 23:37:19 +0200 To: "freebsd-hackers@freebsd.org" From: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= Subject: Linux' struct address_space & FreeBSD's vm_object Message-ID: Date: Sat, 29 Oct 2016 23:37:13 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wrWAIoLvm0igI7WMDSWPohCt1oPvJaThA" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Oct 2016 21:37:21 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wrWAIoLvm0igI7WMDSWPohCt1oPvJaThA Content-Type: multipart/mixed; boundary="pJfrg5t3ajHA4MuUpoS2t0vSaJq7hhKSj"; protected-headers="v1" From: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= To: "freebsd-hackers@freebsd.org" Message-ID: Subject: Linux' struct address_space & FreeBSD's vm_object --pJfrg5t3ajHA4MuUpoS2t0vSaJq7hhKSj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! I'm tracking a memory leak in the drm-next-4.7 branch [1]. I found the issue, however, I'm unsure of the solution for now. Let me sum up what I understand (or what I think I understand :): In Linux, they use a `struct vm_area_struct` to represent a mapping of an object. It holds the callback functions (open, close and fault) of the device driver and the private data to be used with those callbacks. All `struct vm_area_struct` are stored in a tree in another structure called `struct address_space` which belongs to the owner of the resource (an inode in the case of DRM). This structure holds references to pages loaded from the inode, so it acts as a page cache. So: struct inode `-- struct address_space |-- tree of pages `-- tree of struct vm_area_struct In DRM, there is a `struct vm_area_struct` for each mapping of each graphics object. But those mapping are all stored in the same `struct address_space` belonging to an "anonymous inode" attached to the device. Furthermore, a DRM driver creates three character devices in /dev for each real device, and all three character devices use this same anonymous inode. Therefore, if I understand correctly, all mappings for all three character devices use the same list of pages. Thus the memory is shared. In DRM, when a mapping must be released, eg. i915_gem_release_mmap() indirectly calls unmap_mapping_range() with the anonymous inode's `struct address_space`. This function removes all mappings of a given graphics object, thus removes all `struct vm_area_struct` from `struct address` which are covered by the specified range. Currently, on FreeBSD, `struct address_space` is replaced by the vm_object returned by cdev_pager_allocate(). The first issue is that we never create the equivalent of `struct address_space` for the global anonymous inode. Therefore the code responsible for removing mappings does nothing and mappings & pages are leaked. Anyway, the d_mmap_single implementation doesn't even try to fill the equivalent of `struct address_space`. So that's my understanding of the issue. First, I'm not 100% sure of what I described and second, I don't see how to implement the same shared page cache in FreeBSD because a device pager vm_object can't be shared by multiple mappings (or can it?). Can you confirm my comprehension? Do you have any ideas to implement that= ? Thank you very much for your time! [1] In the development tree for DRM: https://github.com/FreeBSDDesktop/freebsd-base-graphics --=20 Jean-S=C3=A9bastien P=C3=A9dron --pJfrg5t3ajHA4MuUpoS2t0vSaJq7hhKSj-- --wrWAIoLvm0igI7WMDSWPohCt1oPvJaThA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJYFRaJAAoJEDnpl2Gl/ZTMLwgP/1h6/XVuyXqUCDWPClaJxpIv RT1+AEwrF7MWxciskSpSMr2mh54Xdjf2wZh6y3ct/LHpXqVmsXqGMDLjCz1dbc0G yErVXnijI5HuH3Gp+0nRXA2bMv0FxDYrwTtjWnhBvXvDt3N211bFw5iQbbo/6B5+ E75Dy2Y4ux0/CWy22tSyCRFWzEKMckdxK3BTCkKdOqZtLRRrjq6qV+4OYYJxNqdQ XbY6NUKEBXz+jrRjewOuqd3cq9UmEmLYk09x8xwpn8EBKiIRG9Va4kigJTv9ZjJQ ZztHipWQrz9A/rin8CUVuxVhLZos6BDz+a7drtG1ZldUfgofFKK6U7jnxhE4qAt5 Z0NFU5Fd+bu7qhGEtWTjzZywTmPjtboI06BYknRS8ckZnTOlhfb2kVFO7sIOA2yF Ui4yHZAn9DRHvQQv2+HqKIxiplRjCj3Fpu6aXYM6tNmZQG/hok+GNGmGEjFDmJgh PZZr6JHfv/DXn2eUoHJdTq7y0qRTMUHG84ZsRn0lZhgptwFsGcmc6Bhr/BiFODvi Hyq8cbnjsFNDVG98ZWg1ggw26QttgZo4bCWTMGRd26sSw1WW5QZP90f2H/ASgJlU Ymirz+wGEdZ9hYUe3UazYnRSc766bmy553FoAPSDOaxEctMemJBZijJVT4gyrFUy +AWW+jWlhjaIf2cCb8bZ =n94E -----END PGP SIGNATURE----- --wrWAIoLvm0igI7WMDSWPohCt1oPvJaThA--