From owner-freebsd-office@freebsd.org Sun Dec 11 07:24:12 2016 Return-Path: Delivered-To: freebsd-office@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA07DC707D5 for ; Sun, 11 Dec 2016 07:24:12 +0000 (UTC) (envelope-from srl@icu-project.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 937BACA4 for ; Sun, 11 Dec 2016 07:24:12 +0000 (UTC) (envelope-from srl@icu-project.org) Received: by mailman.ysv.freebsd.org (Postfix) id 92E46C707D4; Sun, 11 Dec 2016 07:24:12 +0000 (UTC) Delivered-To: office@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 92994C707D2 for ; Sun, 11 Dec 2016 07:24:12 +0000 (UTC) (envelope-from srl@icu-project.org) Received: from p3plsmtpout001.prod.phx3.secureserver.net (p3plsmtpout001.prod.phx3.secureserver.net [208.109.80.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 55857CA3; Sun, 11 Dec 2016 07:24:11 +0000 (UTC) (envelope-from srl@icu-project.org) Received: from gdx.icu-project.org ([208.109.101.195]) by : HOSTING RELAY : with SMTP id FyTPctKZt4Y6lFyTQcO5xS; Sun, 11 Dec 2016 00:23:04 -0700 x-originating-ip: 208.109.101.195 Received: from [10.0.10.140] (secure.in-nahla.com [173.164.162.109]) (authenticated bits=0) by gdx.icu-project.org (8.14.4/8.14.4) with ESMTP id uBB7Knvr005359 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Sun, 11 Dec 2016 00:23:03 -0700 User-Agent: Microsoft-MacOutlook/f.15.1.160411 Date: Sat, 10 Dec 2016 23:23:05 -0800 Subject: Re: ICU port? From: "Steven R. Loomis" To: Tijl Coosemans CC: Message-ID: <2A4B7B3F-3FEE-4E2D-99A7-FB23C15C4765@icu-project.org> Thread-Topic: ICU port? References: <20161210160419.79ade1e2@kalimero.tijl.coosemans.org> In-Reply-To: <20161210160419.79ade1e2@kalimero.tijl.coosemans.org> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable X-CMAE-Envelope: MS4wfOaIRujeUcpnLSWSUVgUwDQeKcx/hvPb4tfgzYDuYVY5eJpqdEJY/qcn0Qu0srmy+aU0z5XIFo2oJ8+ZEqlAa52zT8KnblGJpZPU7FKa9uKSevKxkDjT Efun6FhJjR3QVIYk+MwmS5d3Dno7vQa1JtvZws/9FVJQcZQoUoaY+LAPUYFmgpuzzhAMeo7msK/Solnv7nYNC5tii2VlaeOOWLA= X-BeenThere: freebsd-office@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Office applications on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Dec 2016 07:24:12 -0000 El 12/10/16 7:04 AM, "Tijl Coosemans" escribi=C3=B3: >On Fri, 09 Dec 2016 15:44:47 -0800 "Steven R. Loomis" wrote: >> I came across this address (though it seems to be a generic one) >> on http://portsmon.freebsd.org/portoverview.py?category=3Ddevel&portname=3Di= cu >> and https://svnweb.freebsd.org/ports/head/devel/icu/ >>=20 >> I work on ICU. 58.2 is shipping today (hopefully). >>=20 >> It seems there are a bunch of patches in >> https://svnweb.freebsd.org/ports/head/devel/icu/files/ >>=20 >> It would be great to get these pushed upstream to ICU. >>=20 >> Any way we can try to do that? >> ICU=E2=80=99s CLA is at https://ssl.icu-project.org/trac/wiki/IcuDownstreams#c= la >> for accepting patches. > >Feel free to commit them. Could you consider signing the CLA at the bottom of http://icu-project.org/= trac/#cla ? It=E2=80=99s 1-click if you have a Github id. > >The Makefile patches fix installation of static libraries. INSTALL-L >is equal to INSTALL_PROGRAM which may include the -s flag to strip >(debug) symbols. Stripping removes the .symtab section from ELF files >which is ok for programs and dynamically linked libraries (which also >have a .dynsym section listing exported symbols), but not for static >libraries. If you strip a static library it will no longer export any >symbols, i.e. the output of "readelf -s libfoo.a" will be empty. Sounds like a good one to upstream also. >patch-common_umutex.cpp: >This code is compiled conditionally and one of the cases is a c++11 >compiler without header. uio.fState is an atomic variable and >cannot be read directly. I used umtx_loadAcquire in the patch because >that's what's used elsewhere to read fState. OK. Why would not be available? >patch-common_unicode_platform.h: >I believe that since a few versions ICU is compiled with _XOPEN_SOURCE >defined. This makes our libc headers more strictly standards compliant >so they don't define BYTE_ORDER and BIG_ENDIAN. _BYTE_ORDER and >_BIG_ENDIAN are still defined though. The patch should probably just >add them without removing the former. You should also check if other >operating systems define these macros and if their definition is >compatible or not. This is a good idea. >patch-common_unicode_uconfig.h: >This is just local FreeBSD configuration. You probably don't want to >commit this. Ok > >patch-config_mh-bsd-gcc: >Makes this file more similar to the Linux one. Sure, this sounds like a good one to take upstream. >patch-r39484: >Patch from https://ssl.icu-project.org/trac/ticket/12827 Ok, just a backport. Thanks! P.s. 58.2 just shipped.