From owner-freebsd-ports@freebsd.org Sun May 8 03:28:42 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 66E6BB229AC for ; Sun, 8 May 2016 03:28:42 +0000 (UTC) (envelope-from ganbold@gmail.com) Received: from mail-oi0-x232.google.com (mail-oi0-x232.google.com [IPv6:2607:f8b0:4003:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 30C1D149E for ; Sun, 8 May 2016 03:28:42 +0000 (UTC) (envelope-from ganbold@gmail.com) Received: by mail-oi0-x232.google.com with SMTP id x19so178572365oix.2 for ; Sat, 07 May 2016 20:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=syCzaHxWAr2DySeJhuq627WS/3op+gV/Q3SgNp9adto=; b=fbexmL4+e40ApEN3N4yw9GT+Ju2+wYXsUIFdhkgMJg9D1y3DgfoZ06UUGzncMWUhEb pd/p2g4Dd8qOBEIUpS24V4XIPSzz8qYBHibBA7IRP78AfajUCIcmY7i8cgVbyg6kz5oC ABry0YaNnoZOPQzi07kRA9SjViYLmTFQ7vTy7UhSluEWZdR4Ot7FQh98eZtQugQlvZjf IlGEkT2jaWg5BbVT7Lbbf9GItzOv7ibYEhdZMGAtQtcogi5hS/n0CRI9qXaXC4EfmPev U9rOotYGqttBkJIk2YHQfTwtfcQQ/7zuzi1N1D0EYYm8hiQDWwmbaBA3u263G0N8qFiM aVmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=syCzaHxWAr2DySeJhuq627WS/3op+gV/Q3SgNp9adto=; b=eNVsNhC/oomWVCq6kxDVkUDrRuaUcNmPY/vJazKEzaM18mRyEZlONpKm+2VZL4A58n GFVHoBmoUJE+7d03LALN/XLNn20d9wT8gORJkQvD9loRz5BJxXo2E4pOu095o3TVsNNi KIx//MHx+WpNBijKBWwWjVmacPP99mNBZipIm+XuSAESE61vebEuHV3PB0v2f1YA5sTr q1G+yGeVo2YigGjTCdIJJOGwWnIbyutWQs7iAUPPyRxNDmMGPg7tYV6y0glVr5v7MJ/U jVOIOZCFyRjzGIw8VtWFPBAPAwaf0Sv/ucdHGEQJgEd9I42CSYXv8hsQrqmM6olugE1V ynTw== X-Gm-Message-State: AOPr4FWImyLGFxfSaw3vQf1q+g3A33nrAdoGBg//Cn9nvmWO6OsjwwRm/TmUZjD7h3SMmrNeFgixb31ww6WNVg== MIME-Version: 1.0 X-Received: by 10.202.232.206 with SMTP id f197mr12952318oih.182.1462678121398; Sat, 07 May 2016 20:28:41 -0700 (PDT) Received: by 10.182.158.66 with HTTP; Sat, 7 May 2016 20:28:41 -0700 (PDT) In-Reply-To: <20160507070925.GA2295@home.opsec.eu> References: <20160507070925.GA2295@home.opsec.eu> Date: Sun, 8 May 2016 12:28:41 +0900 Message-ID: Subject: Re: new port for review: LDAP Authenticator plugin for MySQL From: Ganbold Tsagaankhuu To: Kurt Jaeger Cc: freebsd-ports@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 May 2016 03:28:42 -0000 Hi, On Sat, May 7, 2016 at 4:09 PM, Kurt Jaeger wrote: > Hi! > > > Can anyone take a look or review new port at > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208913 ? > > This is LDAP Authenticator plugin for MySQL. > > One important thing: new ports should be submitted as shar-file. > > There are several issues, which running > > cd > portlint -AC > > flags. In my case portent -AC shows "pkg-descr: exceeds 24 lines, make it shorter if possible.(currently 39 lines)" I will fix that. > One other thing that sticks out: Is it really necessary to have > the ateam prefix for the port ? > Yes, we can't remove the A-Team part because then the project name is basically the same as the project we forked. We need it there to differentiate. > > I've added a shar of the modified port to the PR, which still > does not yet fetch and build. Can you provide a version 1.0 > on github that we can fetch ? > Should it necessarily does have version 1.0 in github? Can't it use GH_TAGNAME ? thanks, Ganbold > > Btw, I've created the shar with: > > shar `find mysql-ldap-auth -print` > /tmp/ldap.shar > > -- > pi@opsec.eu +49 171 3101372 4 years to > go ! >