From owner-freebsd-security@freebsd.org Sun Sep 4 01:44:10 2016 Return-Path: Delivered-To: freebsd-security@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C469BB78747 for ; Sun, 4 Sep 2016 01:44:10 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 92A45810 for ; Sun, 4 Sep 2016 01:44:10 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x241.google.com with SMTP id g185so5703531ith.0 for ; Sat, 03 Sep 2016 18:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=92nF924YfEE93qKrLPu7i1HLJLeZUn5PcBfE+n+vo7A=; b=NV9WKIhODmd1KFrvPVG0X47Uhr8MDyyZM/y1gsWDKJMTT0osTb5KZMxSKnY3vBJzp+ ieOKpgGoXEfHuOWk8MyfodUO8Wrrb8cXmifPMXe4vPeDpt7cWX1AdE9gSFzJEkh6snx4 opqIM+4UI99vfciaWtONRqgWGpAelbpjw/ryWARHzMMTqf/87wOkzyscpWwWXgm/PN5k eIhVohvmp2vNQ9PfQ+Gow/mS9IjamCuacuWDZ3xfGuLJ9P3wCWW1aE9i5/CwfKx86ctk NpedqUIifSXT1N8hGWHSOVog8gYUKg4cBLsn+nmqgxwqGJeuzqcjTWDu1ixcoGBmFdmO XYZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=92nF924YfEE93qKrLPu7i1HLJLeZUn5PcBfE+n+vo7A=; b=Iq00IE2n2DH+owE+XJSy0sNtWQNsSuEtKJG7olEBPdmkk+TihVM+aNeVrwlkFF5RMz HCpmWs5dAnTsdY/IfdIVxI/CGKKkas734nWK+EMU/clyeA3S9yuVeyn0scIfPBcV3YLG 2UCyAde/MMKxQyWxG0bviQBM5A4sPtYbiIlbMm72KRuy1Bg59EEN4iYdy42D3TApS6GN 0eV+z0RJNcMM2B+YgXiqkBRU2N6ll2XKmxcC9QtAQC8mZl3r+BsA8jBZbj4cUni8slpl lfMk7FJIKWi+RSVpucLmE+ITiTVsh2jJ+ih2snHubUqZjA9UpN+rrv3eNk9GkOMENeye APPQ== X-Gm-Message-State: AE9vXwP/bVt2H0w0wxQE0AYXF68NqUMP8Ohf/02Om7rzeO6UsfORaTWv3XmDXZ+hXCQC2AX5XEGuKFsPOz6ihA== X-Received: by 10.36.129.193 with SMTP id q184mr13021287itd.35.1472953449987; Sat, 03 Sep 2016 18:44:09 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.138.28 with HTTP; Sat, 3 Sep 2016 18:43:49 -0700 (PDT) In-Reply-To: <22474.13802.335507.240401@hergotha.csail.mit.edu> References: <1472737438.3589865.712736753.5CFBB0DC@webmail.messagingengine.com> <22474.13802.335507.240401@hergotha.csail.mit.edu> From: Ed Maste Date: Sun, 4 Sep 2016 01:43:49 +0000 X-Google-Sender-Auth: wJfI1T2yPGL93pGGI66ZK6l5Xb4 Message-ID: Subject: Re: edit others user crontab, security bug To: Garrett Wollman Cc: Damian Weber , freebsd-security@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Security issues \[members-only posting\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Sep 2016 01:44:10 -0000 On 3 September 2016 at 02:31, Garrett Wollman wrote: > > I see now that this was fixed by emaste@ yesterday (r305269). I'm a > bit disappointed that it was done using MAXLOGNAME, but looking at the > way it's used in the code, fixing it to use the proper POSIX parameter > {LOGIN_NAME_MAX} would require significant restructuring, ... Yep, as I mentioned in the code review for my change I agree cron warrants a deeper investigation and refactoring, but I wanted to get the immediate issue fixed as soon as possible. -Ed